I rewrite std.time for Phobos
SHOO さんは書きました: > I make std.time module for Phobos. This module provides Time, Span, > Clock, StopWatch and some utility functions for time operation. > I hope combine this module to Phobos instead of std.date. > > download is here: > http://j.mp/95aS1K (== http://dusers.dip.jp/ ... /time.d) > http://j.mp/9p5DDu (patch for Phobos's trunk r1481) > http://ideone.com/eiQ19 (for code view) > > Besides, is there the necessary function? (This module lacks the > daylight saving time handling, because of a lack of my understanding.) > > > I talk about the process that reached making... > > Tango is great library for D1. I am Tango user and I am indebted to > Tango well. But Tango has some probrems. > > - Tango's license is BSD lisence or AFL. This license is incompatible to > Phobos's Boost license. > - The specification is disregarded, for example Object.dispose and string. > - Tango supports only D1 > - In particular, deep regret is to have split resources of D into two > halves. > > If possible, I want to migrate to D2. And I want to be separated from > Tango. However, some functions are insufficient for Phobos compared with > Tango. > The std.date module is one of the list of dissatisfaction to Phobos. > I summarize my (and some of Japanese users's) opinion following: > > - I want to handle it as another thing for the time and the time span. > - I want a more structural class for time operating. > - std.date is a bit buggy... > > By these reasons, I made std.time module as the first step of the > contribution for Phobos. Too late to update std.time, but... My old code was represented infringing Tango's license. (See: http://www.digitalmars.com/d/archives/digitalmars/D/announce/Masahiro_Nakagawa_and_SHOO_invited_to_join_Phobos_developers_18108.html ) Therefore, I checked and rewrote some codes for excluding code that may infringe Tango. This: http://ideone.com/M2zB7 I checked it carefully. And I clarified an origin of source of all cords. (Check "Note:" tags.) I hereby made clear that this module does not include the cord which infringes Tango. The interface referred to ptime and time_duration of Boost. (I think others are rather complicating for standard library.) By this reason, I changed some names. (Span to Duration) If this contribution is turned down, I give up std.time.
Re: I rewrite std.time for Phobos
(Note that SHOO means "code" where he says "cord". "Code" and "cord" are both コード in Japanese, so it's easy for Japanese folks to get the two words mixed up.) --bb 2010/5/13 SHOO : > SHOO さんは書きました: >> I make std.time module for Phobos. This module provides Time, Span, >> Clock, StopWatch and some utility functions for time operation. >> I hope combine this module to Phobos instead of std.date. >> >> download is here: >> http://j.mp/95aS1K (== http://dusers.dip.jp/ ... /time.d) >> http://j.mp/9p5DDu (patch for Phobos's trunk r1481) >> http://ideone.com/eiQ19 (for code view) >> >> Besides, is there the necessary function? (This module lacks the >> daylight saving time handling, because of a lack of my understanding.) >> >> >> I talk about the process that reached making... >> >> Tango is great library for D1. I am Tango user and I am indebted to >> Tango well. But Tango has some probrems. >> >> - Tango's license is BSD lisence or AFL. This license is incompatible to >> Phobos's Boost license. >> - The specification is disregarded, for example Object.dispose and string. >> - Tango supports only D1 >> - In particular, deep regret is to have split resources of D into two >> halves. >> >> If possible, I want to migrate to D2. And I want to be separated from >> Tango. However, some functions are insufficient for Phobos compared with >> Tango. >> The std.date module is one of the list of dissatisfaction to Phobos. >> I summarize my (and some of Japanese users's) opinion following: >> >> - I want to handle it as another thing for the time and the time span. >> - I want a more structural class for time operating. >> - std.date is a bit buggy... >> >> By these reasons, I made std.time module as the first step of the >> contribution for Phobos. > > Too late to update std.time, but... > > > My old code was represented infringing Tango's license. > (See: > http://www.digitalmars.com/d/archives/digitalmars/D/announce/Masahiro_Nakagawa_and_SHOO_invited_to_join_Phobos_developers_18108.html > ) > > > Therefore, I checked and rewrote some codes for excluding code that may > infringe Tango. > > This: http://ideone.com/M2zB7 > > I checked it carefully. And I clarified an origin of source of all > cords. (Check "Note:" tags.) > I hereby made clear that this module does not include the cord which > infringes Tango. > > The interface referred to ptime and time_duration of Boost. (I think > others are rather complicating for standard library.) > By this reason, I changed some names. (Span to Duration) > > If this contribution is turned down, I give up std.time. >
Re: I rewrite std.time for Phobos
On Thu, 13 May 2010 10:42:56 -0400, SHOO wrote: Therefore, I checked and rewrote some codes for excluding code that may infringe Tango. I don't know if this will be enough, I wish I could tell you different. Can you identify which functions you rewrote from the original proposal to help focus Tango's attention? Is there anyone listening from Tango who can check this against Tango code to see if you still consider it to be infringing? If this contribution is turned down, I give up std.time. First, I hope this can be included, it looks like very solid code. Second, if it cannot be included, I hope this does not dissuade you from contributing to Phobos for other modules. -Steve
SHOO's time code
On Fri, 30 Apr 2010 09:55:51 -0400, Moritz Warning wrote: On Fri, 30 Apr 2010 09:07:06 -0400, Steven Schveighoffer wrote: On Fri, 30 Apr 2010 09:02:32 -0400, Moritz Warning wrote: have you thought about just asking the authors of the Tango code in question? I would imagine they would say that they only see a minor resemblance in the api and asking wouldn't even be necessary from their point of view. One of the major authors of the Tango time module, John Chapman, cannot be located so until he is and agrees the proposed Phobos time module cannot be accepted." -Steve Well, then let's point this out (we need to contact JC, that's the problem at heart). All the blaming doesn't help anyone. FYI, John Chapman is no longer a blocker for this path. -Steve
Re: I rewrite std.time for Phobos
Steven Schveighoffer wrote: First, I hope this can be included, it looks like very solid code. Second, if it cannot be included, I hope this does not dissuade you from contributing to Phobos for other modules. Basically, the next time there's a suggestion of infringement from anyone, I'd like a specific list of the lines of source that are infringing. I don't think there's any reasonable way to deal with it otherwise. It shouldn't be necessary to guess what those lines might be.
Re: SHOO's time code
On Thu, 13 May 2010 16:45:45 -0400, Steven Schveighoffer wrote: > On Fri, 30 Apr 2010 09:55:51 -0400, Moritz Warning > wrote: > >> On Fri, 30 Apr 2010 09:07:06 -0400, Steven Schveighoffer wrote: >> >>> On Fri, 30 Apr 2010 09:02:32 -0400, Moritz Warning >>> wrote: >>> have you thought about just asking the authors of the Tango code in question? I would imagine they would say that they only see a minor resemblance in the api and asking wouldn't even be necessary from their point of view. >>> One of the major authors of the Tango time module, John Chapman, >>> cannot be located so until he is and agrees the proposed Phobos time >>> module cannot be accepted." >>> >>> -Steve >> Well, then let's point this out (we need to contact JC, that's the >> problem at heart). >> All the blaming doesn't help anyone. > > FYI, John Chapman is no longer a blocker for this path. > > -Steve I have asked Kris Bell and Matti Niemenmaa. No Problem at all.
