[jQuery] DatePicker: Z-index issues
Hi all, I'm getting awkward issues with datepicker, best illustrated with screenshots: http://hosted.jazzle.co.uk/datePicker/datePickerIssue.jpg and http://hosted.jazzle.co.uk/datePicker/datePickerIssue2.jpg (the second is less of a problem but notable none the less) I am using the latest datepicker (rev 1566). any ideas on how to fix this? any help/suggestions/questions very welcome. Jez -- View this message in context: http://www.nabble.com/DatePicker%3A-Z-index-issues-tf3480302.html#a9713633 Sent from the JQuery mailing list archive at Nabble.com. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] DatePicker: Z-index issues
jazzle wrote: Hi all, I'm getting awkward issues with datepicker, best illustrated with screenshots: http://hosted.jazzle.co.uk/datePicker/datePickerIssue.jpg and http://hosted.jazzle.co.uk/datePicker/datePickerIssue2.jpg (the second is less of a problem but notable none the less) I am using the latest datepicker (rev 1566). any ideas on how to fix this? any help/suggestions/questions very welcome. Jez Hi, Did you also update your CSS when you updated the JavaScript? Which browser are you seeing the problem in? I recently fixed the issue which looked like this in IE7 ( http://dev.jquery.com/changeset/1566 ) - but the change required a change to the CSS as well as the Javascript. The culprit was a position: relative on div.date-picker-holder. Does my demo page [ http://www.kelvinluck.com/assets/jquery/datePicker/ ] break in your browser? Cheers, Kelvin :) p.s. what is the problem in the second image? ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] DatePicker: Z-index issues
vitch wrote: jazzle wrote: Hi all, I'm getting awkward issues with datepicker, best illustrated with screenshots: http://hosted.jazzle.co.uk/datePicker/datePickerIssue.jpg and http://hosted.jazzle.co.uk/datePicker/datePickerIssue2.jpg (the second is less of a problem but notable none the less) I am using the latest datepicker (rev 1566). any ideas on how to fix this? any help/suggestions/questions very welcome. Jez Hi, Did you also update your CSS when you updated the JavaScript? Which browser are you seeing the problem in? I recently fixed the issue which looked like this in IE7 ( http://dev.jquery.com/changeset/1566 ) - but the change required a change to the CSS as well as the Javascript. The culprit was a position: relative on div.date-picker-holder. Does my demo page [ http://www.kelvinluck.com/assets/jquery/datePicker/ ] break in your browser? Cheers, Kelvin :) p.s. what is the problem in the second image? Hi, looks like I hadn't got the new CSS, so now it is fixed - many thanks. :) The second image is showing the datepicker off the edge of the screen, and the user can't scroll to it. Could the screen edge be detected and the datepicker flipped to the other side of the icon? Jez -- View this message in context: http://www.nabble.com/DatePicker%3A-Z-index-issues-tf3480302.html#a9714247 Sent from the JQuery mailing list archive at Nabble.com. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] DatePicker: Z-index issues
Hi, looks like I hadn't got the new CSS, so now it is fixed - many thanks. :) The second image is showing the datepicker off the edge of the screen, and the user can't scroll to it. Could the screen edge be detected and the datepicker flipped to the other side of the icon? Jez Hi, Ah - I see. I thought that was just how you cropped the screenshot! At the moment the date picker doesn't detect the edge of the screen and position itself sensibly. This is on my TODO list and would definitely be a useful feature... In the meantime, you can do the change through CSS. See lines 64 and 73 of my CSS file. You could change both of these values to flip which side the date picker appeared on globally. Alternatively , you could do something like I show in this demo: http://kelvinluck.com/assets/jquery/datePicker/alignDemo.html Hope that helps, Kelvin :) ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
[jQuery] Datepicker Enhancement Request
I was curious to find out if anyone has modified Kelvin's excellent datepicker plugin to work with a series of select lists instead of a single line text field? If not, could this functionality be included? Thanks. Ryan Rose http://www.digiwize.com ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] Datepicker Enhancement Request
Try this date picker http://www.frequency-decoder.com/2006/10/02/unobtrusive-date-picker- widgit-update Hrvoje On 23 ožu, 2007, at 16:08, Ryan Rose wrote: I was curious to find out if anyone has modified Kelvin's excellent datepicker plugin to work with a series of select lists instead of a single line text field? If not, could this functionality be included? Thanks. Ryan Rose http://www.digiwize.com ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/ Hrvoje Blažeković tel.: 048/220 418 fax.: 048/220 417 e-mail: [EMAIL PROTECTED] ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker
We also have an upcoming need for a calendar component. Our release is Feb. 26th so I'm not sure if this is going to make it in by then (or if I'll have it done in time). But what about if we come up with a core feature list. I think I can start putting some time towards this. Cheers, -js On 1/15/07, Zach Shelton [EMAIL PROTECTED] wrote: I've only recently discovered jQuery, and I'm quite impressed. I'm going to be porting some code for an application that was developed without a js framework (I'm going to be using it in the next version of my CMS project http://lucidcms.net ). For the most part, I' think this is going to be pretty painless and jQuery will give me a lot of new possibilities. But I'm having a hard time finding a suitable replacement for jscalendar ( http://www.dynarch.com/demos/jscalendar/ ). The datePicker plugin doesn't have the range of features available in jscalendar, and while I admire simplicity and light weight, there are things in jscalendar that I can not give up (inclusion of time element in addition to date is the most critical part). Are there any other date/time selectors out there in the jQuery universe, I've scoured several forums and followed Google search results several pages deep, all to no avail. The best I came up with was a plugin for Drupal that simply takes jscalendar and wraps it with jQuery (along with the Drupal jstools API). If there is nothing out there already, I may have to abandon the conversion effort, as I just don't have the time right now for a doing something as complicated as jscalendar myself. Thanks in advance for any leads you may have. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/ ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
[jQuery] datePicker
I've only recently discovered jQuery, and I'm quite impressed. I'm going to be porting some code for an application that was developed without a js framework (I'm going to be using it in the next version of my CMS project http://lucidcms.net ). For the most part, I' think this is going to be pretty painless and jQuery will give me a lot of new possibilities. But I'm having a hard time finding a suitable replacement for jscalendar ( http://www.dynarch.com/demos/jscalendar/ ). The datePicker plugin doesn't have the range of features available in jscalendar, and while I admire simplicity and light weight, there are things in jscalendar that I can not give up (inclusion of time element in addition to date is the most critical part). Are there any other date/time selectors out there in the jQuery universe, I've scoured several forums and followed Google search results several pages deep, all to no avail. The best I came up with was a plugin for Drupal that simply takes jscalendar and wraps it with jQuery (along with the Drupal jstools API). If there is nothing out there already, I may have to abandon the conversion effort, as I just don't have the time right now for a doing something as complicated as jscalendar myself. Thanks in advance for any leads you may have. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker
Zach Shelton schrieb: The best I came up with was a plugin for Drupal that simply takes jscalendar and wraps it with jQuery (along with the Drupal jstools API). If there is nothing out there already, I may have to abandon the conversion effort, as I just don't have the time right now for a doing something as complicated as jscalendar myself. To my knowledge there is no sophisticated calendar widget for jQuery available. -- Jörn Zaefferer http://bassistance.de ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker
This is actually on my todo list as I know I will need it eventually. However, I have no for sure time line on when I would have something ready. -- Brandon Aaron On 1/15/07, Zach Shelton [EMAIL PROTECTED] wrote: I've only recently discovered jQuery, and I'm quite impressed. I'm going to be porting some code for an application that was developed without a js framework (I'm going to be using it in the next version of my CMS project http://lucidcms.net ). For the most part, I' think this is going to be pretty painless and jQuery will give me a lot of new possibilities. But I'm having a hard time finding a suitable replacement for jscalendar ( http://www.dynarch.com/demos/jscalendar/ ). The datePicker plugin doesn't have the range of features available in jscalendar, and while I admire simplicity and light weight, there are things in jscalendar that I can not give up (inclusion of time element in addition to date is the most critical part). Are there any other date/time selectors out there in the jQuery universe, I've scoured several forums and followed Google search results several pages deep, all to no avail. The best I came up with was a plugin for Drupal that simply takes jscalendar and wraps it with jQuery (along with the Drupal jstools API). If there is nothing out there already, I may have to abandon the conversion effort, as I just don't have the time right now for a doing something as complicated as jscalendar myself. Thanks in advance for any leads you may have. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/ ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
[jQuery] datePicker changes layout
When I apply the datepicker to an input, it alters the layout of the items in the form. http://www.texotela.co.uk/datepickerbug.php How can I prevent this from happening? ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
[jQuery] datePicker changes layout
I noticed this too, it must be down to the floated calendar button You could wrap your inputs in a div and give it a 'clearfix' class: http://positioniseverything.net/easyclearing.html ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker changes layout
When I apply the datepicker to an input, it alters the layout of the items in the form. http://www.texotela.co.uk/datepickerbug.php How can I prevent this from happening? It looks like the elements that the date picker adds so that there is somewhere for the pop up calendar to appear are disturbing the layout of your form. For now all I can suggest is playing with the CSS to get the result you are after. You can look at the styles I use for the inputs on the demo page as there is no shuffling there... In the longer term I'll look into changing the way the date picker is attached so that it can be absolutely positioned in the right place rather than inserting markup around the relevant inputs. I'm guessing I can probably borrow some code from the tool tip plugins or dimensions.js to help with this? Cheers, Kelvin :) ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
[jQuery] datePicker changes layout
Not sure if my responses get through, basically it's a problem relating to the floating of the calendar button. Search for 'clearfix' on google and attach that classname to a containing div.* Posted:* Thu Dec 7 11:13:55 EST 2006 *From:* Kelvin Luck kelvin at kelvinluck.com mailto:discuss%40jquery.com?Subject=%5BjQuery%5D%20datePicker%20changes%20layoutIn-Reply-To=45781EE8.8000207%40mikeholloway.co.uk When I apply the datepicker to an input, it alters the layout of the items in the form. http://www.texotela.co.uk/datepickerbug.php How can I prevent this from happening? It looks like the elements that the date picker adds so that there is somewhere for the pop up calendar to appear are disturbing the layout of your form. For now all I can suggest is playing with the CSS to get the result you are after. You can look at the styles I use for the inputs on the demo page as there is no shuffling there... In the longer term I'll look into changing the way the date picker is attached so that it can be absolutely positioned in the right place rather than inserting markup around the relevant inputs. I'm guessing I can probably borrow some code from the tool tip plugins or dimensions.js to help with this? Cheers, Kelvin :) ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker changes layout
Sam, I was playing with the CSS on your page, and when I did a refresh on it, it magically worked. Congrats on solving the puzzle. I'm curious, what did you do to get it to work for you? --Karl _ Karl Swedberg www.englishrules.com www.learningjquery.com On Dec 7, 2006, at 11:13 AM, Kelvin Luck wrote: When I apply the datepicker to an input, it alters the layout of the items in the form. http://www.texotela.co.uk/datepickerbug.php How can I prevent this from happening? It looks like the elements that the date picker adds so that there is somewhere for the pop up calendar to appear are disturbing the layout of your form. For now all I can suggest is playing with the CSS to get the result you are after. You can look at the styles I use for the inputs on the demo page as there is no shuffling there... In the longer term I'll look into changing the way the date picker is attached so that it can be absolutely positioned in the right place rather than inserting markup around the relevant inputs. I'm guessing I can probably borrow some code from the tool tip plugins or dimensions.js to help with this? Cheers, Kelvin :) ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/ ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker changes layout
oops. stupid me...I forgot to re-activate the plugin. The good news is that I think I've found a solution for you: 1., wrap the to in a span: span class=to to /span 2. add some CSS defs to your stylesheet: #when input, #when span.to { float: left; } #where { clear: left; } Hope that works for you. It worked for me when I manipulated the page using Firebug. Cheers, --Karl _ Karl Swedberg www.englishrules.com www.learningjquery.com On Dec 7, 2006, at 12:36 PM, Karl Swedberg wrote: Sam, I was playing with the CSS on your page, and when I did a refresh on it, it magically worked. Congrats on solving the puzzle. I'm curious, what did you do to get it to work for you? --Karl _ Karl Swedberg www.englishrules.com www.learningjquery.com On Dec 7, 2006, at 11:13 AM, Kelvin Luck wrote: When I apply the datepicker to an input, it alters the layout of the items in the form. http://www.texotela.co.uk/datepickerbug.php How can I prevent this from happening? It looks like the elements that the date picker adds so that there is somewhere for the pop up calendar to appear are disturbing the layout of your form. For now all I can suggest is playing with the CSS to get the result you are after. You can look at the styles I use for the inputs on the demo page as there is no shuffling there... In the longer term I'll look into changing the way the date picker is attached so that it can be absolutely positioned in the right place rather than inserting markup around the relevant inputs. I'm guessing I can probably borrow some code from the tool tip plugins or dimensions.js to help with this? Cheers, Kelvin :) ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/ ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/ ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker changes layout
On 12/7/06, Kelvin Luck [EMAIL PROTECTED] wrote: In the longer term I'll look into changing the way the date picker is attached so that it can be absolutely positioned in the right place rather than inserting markup around the relevant inputs. I put up a crude CSS example page on positioning the calendar div without doing any wrapping. Hopefully it's useful. Link: http://perifer.se/test/datepickerCSS.htm /Anders ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker changes layout
On 07/12/06, Karl Swedberg [EMAIL PROTECTED] wrote: oops. stupid me...I forgot to re-activate the plugin. The good news is that I think I've found a solution for you: 1., wrap the to in a span: span class=to to /span 2. add some CSS defs to your stylesheet: #when input, #when span.to { float: left; } #where { clear: left; } Hope that works for you. It worked for me when I manipulated the page using Firebug. Cheers, --Karl While that could be one possible solution I would like it to work without requiring any extra markup added to the page (apart from that added by the plugin). ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
[jQuery] datePicker plugin - inputClick bug fix and other alterations
I've made a few changes to the Kelvin Luck's date picker plugin (http://kelvinluck.com/assets/jquery/datePicker/). After adding the ability to click the input to show the calendar it replaces any existing css classes that may already exist on it (which I should have caught when adding it). So I have changed it to use addClass instead of attr({'class' : '...'}). Along with that, I have reduced the number of times 'attr' is used: i.e. $(a).attr({'title' : 'Foo', 'rel' : 'myrel', 'href' : 'javascript:;'}) becomes: $(a).title('Foo').rel('myrel').href('javascript:;') I have left alone those attributes that don't have a shorthand equivalent (scope, abbr, cellspacing). Download from: http://www.texotela.co.uk/datePicker_source.zip ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker plugin - inputClick bug fix and other alterations
On 11/27/06, Sam Collett [EMAIL PROTECTED] wrote: Along with that, I have reduced the number of times 'attr' is used: i.e. $(a).attr({'title' : 'Foo', 'rel' : 'myrel', 'href' : 'javascript:;'}) becomes: $(a).title('Foo').rel('myrel').href('javascript:;') I'm curious why you have done this? Those helper methods might be deprecated from the core in the 1.1 release. -- Brandon Aaron ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker plugin - inputClick bug fix and other alterations
On 27/11/06, Brandon Aaron [EMAIL PROTECTED] wrote: On 11/27/06, Sam Collett [EMAIL PROTECTED] wrote: Along with that, I have reduced the number of times 'attr' is used: i.e. $(a).attr({'title' : 'Foo', 'rel' : 'myrel', 'href' : 'javascript:;'}) becomes: $(a).title('Foo').rel('myrel').href('javascript:;') I'm curious why you have done this? Those helper methods might be deprecated from the core in the 1.1 release. -- Brandon Aaron I've changed it to use attr to set attributes (addClass is still used to set the class) and noticed that 'val' was used instead of attr to get the value (so that has been fixed too). Download link is till the same. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
[jQuery] datePicker plugin - show on input click
At the moment, the date picker plugin (http://kelvinluck.com/assets/jquery/datePicker/) uses an anchor added after the input to show the calendar. What I wanted to do is show it when I clicked on the input instead. Also I think it is good practice to add events after adding an element to the DOM (adding before can cause memory leaks in IE IIRC), so I have made another tweak to do that. The fix is as follows (applied to the uncompressed version): jQuery.fn.datePicker = function(a) { this.each(function() { if(this.nodeName.toLowerCase() != 'input') return; jQuery.datePicker.setDateWindow(this, a); if (!jQuery.datePicker.isInited(this)) { var chooseDate = jQuery.datePicker.getChooseDateStr(); var calBut; if(a a.inputClick){ calBut = jQuery(this).attr({'class':'date-picker', 'title':chooseDate}) } else { calBut = jQuery(a).attr({'href':'javascript:;', 'class':'date-picker', 'title':chooseDate}) .append(span + chooseDate + /span); } jQuery(this).wrap( 'div class=date-picker-holder/div' ).before( jQuery(div).attr({'class':'popup-calendar'}) ).after( calBut ); calBut.click(jQuery.datePicker.show); jQuery.datePicker.setInited(this); } }); }; To use: $('input#date1').datePicker({inputClick: true}); i.e. add 'inputClick: true' as an option to show the picker when you click on the input box containing the date. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] DatePicker plugin: dateFormat enhancement [u]
Hi Stefan, devsteff [c] wrote: hi community and kevin luck, It's keLvin but that's OK :) first i must thank kevin you for his great datepicker. it's really fantastic and fits perfect into my project (even the css :)). Glad you like it! but unfortunately he forget the old world in his predefiend dateFormats versions. here in swiss, austria, and german is the . the regular dateFormat separator. so i've changed your plugin a bit and made the formatting/parsing of a date a bit more generic. Sorry - didn't mean to leave anyone out! Thanks for your patch, I've reviewed it and added it into the plugin. This does mean that anyone who upgrades the plugin and who is setting a date format will need to edit their code but it adds a great deal of flexibility. if you find this patch usefull, pls. commit it into the SVN. Done :) btw, i have some feature requests: 1) i need the ability to select a date in the far future (life insurance finalization date ~ +20 years, that should not be on weekend, so i need to lookup into the calendar). i.e. year paging as well as month paging or direkt year selectiong (select box) This must be the most requested feature for the plugin. It's something I originally thought unnecessary but since there has been so many requests for it I am willing to implement it. When I next get a free couple of hours I'll look at adding it in... 2) the possibility to set the weeks startday for example to sunday I did this earlier this week. Check through the plugin's page ( http://kelvinluck.com/assets/jquery/datePicker/ ) and you will find an example (basically when you initialise the datePicker you pass in a 'firstDayOfWeek' - this allows different datePickers on the same page to start on different days of the week (if you so desire). did you (kevin) plan something like that? if not, i will take this version and start a branch... regards stefan Thanks for the feedback and the patch! Kelvin :) ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] DatePicker plugin: dateFormat enhancement [u]
It's keLvin but that's OK :) sorry keLvin, mea culpa! This must be the most requested feature for the plugin. It's something I originally thought unnecessary but since there has been so many requests for it I am willing to implement it. When I next get a free couple of hours I'll look at adding it in... yippy! saves me a bunch of time, analyzing and understanding your code in depth! I did this earlier this week. Check through the plugin's page ( http://kelvinluck.com/assets/jquery/datePicker/ ) and you will find an example (basically when you initialise the datePicker you pass in a 'firstDayOfWeek' - this allows different datePickers on the same page to start on different days of the week (if you so desire). ok, very nice. exactly what i want. so all my datepicker-wishes comes true. that's a good point to go to bed. tanks a lot good night, stefan ps: your flickr wanaka winter pics are breathtaking! ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker is gone when 2nd time loading a form
you put it into the place where you build your form, and give it id=opsa?=$_SESSION['count']?(if your using php)or maybe use _javascript_, and useid = $(sdds).attr('id');$(sdds).attr('id',id+count); but a REAL solution would be much nicer :)2006/9/20, Chris Mcleod [EMAIL PROTECTED]: Where do you put this? I'm having the same problem as you were, with some forms loaded by Thickbox. The first form loads fine, but subsequent forms are missing the Date Picker "widgets". Chris From: [EMAIL PROTECTED] [mailto: [EMAIL PROTECTED]] On Behalf Of Michael Grosser Sent: 19 September 2006 17:03 To: discuss Subject: [jQuery] datePicker is gone when 2nd time loading a form and now for the solution :/ $_SESSION['count'] ++; and every form input gets a raising id, so that its unique everytime - datepicker works : __ This email has been scanned by Senergy Ltd for viruses. Powered by MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email __ ___jQuery mailing listdiscuss@jquery.com http://jquery.com/discuss/-- mfg M.Grosser ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker is gone when 2nd time loading a form
Where do you put this? Im having the same problem as you were, with some forms loaded by Thickbox. The first form loads fine, but subsequent forms are missing the Date Picker widgets. Chris From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Michael Grosser Sent: 19 September 2006 17:03 To: discuss Subject: [jQuery] datePicker is gone when 2nd time loading a form and now for the solution :/ $_SESSION['count'] ++; and every form input gets a raising id, so that its unique everytime - datepicker works : __ This email has been scanned by Senergy Ltd for viruses. Powered by MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email __ ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
[jQuery] datePicker is gone when 2nd time loading a form
and now for the solution :/$_SESSION['count'] ++;and every form input gets a raising id, so that its unique everytime - datepicker works : ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
[jQuery] datePicker is gone when 2nd time loading a form
im loading a form via load, the first time i load it, datepicker is there, if i now a 2nd time try to load the form, there is no date picker...(im loading it into the same place as before ('#menu'))the datepicker code is inside the for .html file script $('input#von').datePicker({startDate:'01/01/2000'}); $('input#bis').datePicker({startDate:'01/01/2000'});/scriptinputs have the same name when i load 2nd time.. any suggestions what to do ?(maybe sth like closedatePicker() ? )mfg MG ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
[jQuery] datePicker plugin IE memory leak fixed
Hi, I have just released an updated version of my date picker plugin: http://kelvinluck.com/assets/jquery/datePicker/ Thanks to Sean McKenna who reported a memory leak in IE. This turned out to be a pretty major one but relatively easy to fix and so I'd recommend anyone using the date picker to upgrade ASAP... I would like some advise on the cause of the problem and if there is a more robust solution. Basically, when the calendar opens IE uses a bunch more memory (~35MB on my system). When you switch months I was clearing the old calendar from the DOM by doing this: $('div.popup-calendar', _openCal).remove(); (basically calling remove on the div that contained it). This wasn't freeing the memory in IE and another ~35MB or so was being used. And when you closed the calendar and the pop up div was removed only the last ~35MB was being freed up. As you can imagine, a recipe for disaster! My solution was to call: $('div.popup-calendar', _openCal).empty(); Before the remove command above. Now IE consistently uses ~35MB more memory while the calendar is open and frees this when the calendar closes. Much better. I was wondering if it is expected behaviour to have to call empty before remove when developing with jQuery or whether this should be done internally? One other problem I noticed is that if I chain the two calls (as I should be able to): $('div.popup-calendar', _openCal).empty().remove(); Now when the calendar opens it uses ~35MB more memory. When you switch months for the first time it doubles this to ~70MB more memory. It stays constant at this while you switch months and then frees the memory when you close the calendar. It is interesting that the chained methods react consistently differently to calling the methods one after the other - is this expected or indicative of another bug? Sorry for the long email but I'd appreciate it if anyone had any feedback on these problems, Cheers, Kelvin :) ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker plugin IE memory leak fixed
Hello Kelvin. I just want to take the oportunity to give you some suggestions for features I miss in your date picker: I would need a possibility to change the month and year in the popped up window: | | January 2006 | | Something like this, where would switch to the next month and would go the next year. I see that one can currently move forward in months, but not backwars and not in years. -- Milian Wolff http://milianw.de ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] datePicker plugin IE memory leak fixed
Hi Milian, Thanks for the feedback. This is something that has been requested quite a few times. However, I'm still not convinced by the usefulness of it, I have never needed this functionality on a page I have made or used. Since it seems to be a popular request I'll consider adding it in in the future but am too busy to do it at the moment... Re. not being able to move backwards, this depends on how you use the date picker. By default it only lets you select dates in the future but as documented on the plugin's page, you can pass a startDate (and endDate) into the plugin to control which dates people can select. The startDate can be in the past and then a user will be able to select dates back to that date... Cheers, Kelvin :) Milian Wolff wrote: Hello Kelvin. I just want to take the oportunity to give you some suggestions for features I miss in your date picker: I would need a possibility to change the month and year in the popped up window: | | January 2006 | | Something like this, where would switch to the next month and would go the next year. I see that one can currently move forward in months, but not backwars and not in years. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/