Re: Can I get another pair of eyes on a few tickets?
On Sun, Mar 22, 2009 at 10:31 AM, Justin Lilly wrote: > Just rounding up a list of tickets I've worked on which could use > another pair of eyes. Thanks; I've reviewed 'em. Note that a couple are already marked for 1.1, which means we'll get to 'em between the beta and the final. Right now we're wrapping up features for the feature freeze on Monday. I've left comments on some of the tickets, but a couple of extra notes are in order: > 7944 generic date-based views get confused with a single-digit numeric > month_format This is fixed in the class-based generic view work I'm trying to wrap up in time for the beta; weather do or not, though, this'll be fixed in 1.1. Only reason I've not committed it is because I'm trying to get the more general refactor done instead. > 10237 symmetry lost when inheriting a self-referential m2m field via > MTI Yup, accepted for 1.1. > 10583 id should be visible from the admin for the sites framework This is really just bikeshedding; in general we don't accept tickets that do stuff like change list_display because sooner or later someone else will that having the site id there is ugly and submit a patch for that. I've left a comment to that effect as part of the wontfix. Jacob --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Can I get another pair of eyes on a few tickets?
Just rounding up a list of tickets I've worked on which could use another pair of eyes. Consider this a call for reviews for the following tickets: 6273 support for passwd-like password changing http://code.djangoproject.com/ticket/6273 A new feature, albeit a small one, which adds a management command for changing a user's password. Adrian called it a "good idea". 7944 generic date-based views get confused with a single-digit numeric month_format http://code.djangoproject.com/ticket/7944 This is specifically to review strptime_delimiters4.patch as the one after it doesn't seem to add any additional functionality and it lacks tests. This the #4 patch has been working in production with no ill-effects. 10237 symmetry lost when inheriting a self-referential m2m field via MTI http://code.djangoproject.com/ticket/10237 When a model inherits a self-referential m2m field via a non-abstract base class, it loses symmetry because the of a comparison that doesn't take into account an object's ancestry. The code involved here is from around magic removal. 10538 html id conflicts in admindocs http://code.djangoproject.com/ticket/10538 Simple fix for conflicting HTML id's in the admindoc's model list view. Fixed by prepending "app-" to the id attribute. 10583 id should be visible from the admin for the sites framework http://code.djangoproject.com/ticket/10583 This one is quite new (just submitted it today), but I think as we have to use the SITE_ID in settings.py, it ought to be viewable through the admin. Otherwise, we have to drop to the database which seems a bit pointless. This is a simple change to the admin.py's list_display attribute. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
