Re: What do you think about unify templates feature?

2019-01-19 Thread J . Pablo Martín Cobos
Bonus track: If you have a template with complete HTML (without blocks).
You can add to this command another features like compress HTML or use line
styles (using pyliner[1]) and win more time yet :-) Because this feature
does not consume run time, but this feature waste preprocessing time, like
compilemessage command.

Best,


REF's
1. https://pypi.org/project/Pyliner/

El sáb., 19 ene. 2019 a las 19:34, J. Pablo Martín Cobos ()
escribió:

> I reply between lines,
>
> El sáb., 19 ene. 2019 a las 12:31, Adam Johnson () escribió:
>
>> I agree, I'd like to see a third party package too.
>>
>
>
> If I have any time I will do it. And I will say something in this thread.
>
>
>>
>> I'm all up for seeing improvements in template rendering speed but
>> working code in a third party package is way more valuable than more
>> discussion. Many of Django's major features in the past (e.g.
>> SecurityMiddleware, Migrations) were third party packages for a long time
>> before being merged in due to community consensus that they were a good
>> idea.
>>
>
> Yes, With this email I see it is a nice feature. If I have any time I will
> work in this feature. I don't need more discussion :-)
>
>
>>
>> Nice to see that it is an improvement over the cached loader, but it does
>> seem like it would complicate things for users quite a bit as it stands -
>> having to run another command on deployments, maybe modifying view code to
>> load a different template name in production, and creating more files that
>> increase the size of a deployment or use more memory.
>>
>
> It will be like collecstatic command. Also, it would be a optional
> feature. You want to win several miliseconds per request, run this command.
> If you don't want win these miliseconds... you don't have do anything.
>
>
>>
>> Also I think there might be a number of edge cases that would make
>> "unification" very hard - IIRC you can have an {% if %} around a {%
>> block %} or at least around {{ block.super }}.
>>
>>
> It is not a problem. I complicate my previous example, it now works:
>
> 1. news.html
>
> {% extends "base.html" %}
>
> {% block title %}
> {% include "inc.news.title.html" %}
> {% endblock %}
>
> {% block content %}
> {% if news %}
> {% for news_item in news %}
> {{ news_item.title }}
> {{ news_item.subtitle }}
> {% endfor %}
> {% else %}
> {{ block.super }}
> {% endif %}
> {% endblock %}
>
> 2. base.html
>
>  http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
> http://www.w3.org/1999/xhtml"; lang="{{
> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
> %}>
> 
> {% block title %}{% endblock %}
> 
> 
> {% block content %}
> Sorry no results
> {% endblock %}
> 
> 
>
> 3. inc.news.title.html
> News
>
> With this command I preproces every template of a settings variable and I
> get something like this:
>
> news.unify.html
>
>  http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
> http://www.w3.org/1999/xhtml"; lang="{{
> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
> %}>
> 
> News
> 
> 
> {% if news %}
> {% for news_item in news %}
> {{ news_item.title }}
> {{ news_item.subtitle }}
> {% endfor %}
> {% else %}
> Sorry no results
> {% endif %}
> 
> 
>
> Best,
>
>
>
>> On Sat, 19 Jan 2019 at 10:00, Jani Tiainen  wrote:
>>
>>> Hi.
>>>
>>> Unfortunately Django is already big. Every new feature requires careful
>>> consideration since it adds maintenance burden to already loaded
>>> maintainers.
>>>
>>> So best and pretty much only way to make your feature appear in Django
>>> itself is to prove that your solution is widely adopted in everyday use and
>>> it's "winning" technology.
>>>
>>> That would practically mean that code is well written, constantly
>>> maintained and documented.
>>>
>>> You can keep showing speed test results but they really won't get you
>>> anywhere. Let the people decide is your feature good or not. Get more
>>> contributors to your feature to resolve edge cases that doesn't work yet.
>>>
>>>
>>> J. Pablo Martín Cobos  kirjoitti la 19. tammik. 2019
>>> klo 10.22:
>>>





 El sáb., 19 ene. 2019 7:08, Jani Tiainen  escribió:

> Hi,
>
> You said that this doesn't require any change in Django at all.
>
> So this doesn't need to be in Django at all, it can survive as its own
> and that way it should be.
>
> So make your enhancement as reusable app and release it to public. Get
> people to use it. Fix the bugs that appears. Write a good documentation.
> Give the support.
>
>
 Yes, it is an option, or another opti

Re: What do you think about unify templates feature?

2019-01-19 Thread J . Pablo Martín Cobos
I reply between lines,

El sáb., 19 ene. 2019 a las 12:31, Adam Johnson () escribió:

> I agree, I'd like to see a third party package too.
>


If I have any time I will do it. And I will say something in this thread.


>
> I'm all up for seeing improvements in template rendering speed but working
> code in a third party package is way more valuable than more discussion.
> Many of Django's major features in the past (e.g. SecurityMiddleware,
> Migrations) were third party packages for a long time before being merged
> in due to community consensus that they were a good idea.
>

Yes, With this email I see it is a nice feature. If I have any time I will
work in this feature. I don't need more discussion :-)


>
> Nice to see that it is an improvement over the cached loader, but it does
> seem like it would complicate things for users quite a bit as it stands -
> having to run another command on deployments, maybe modifying view code to
> load a different template name in production, and creating more files that
> increase the size of a deployment or use more memory.
>

It will be like collecstatic command. Also, it would be a optional feature.
You want to win several miliseconds per request, run this command. If you
don't want win these miliseconds... you don't have do anything.


>
> Also I think there might be a number of edge cases that would make
> "unification" very hard - IIRC you can have an {% if %} around a {% block
> %} or at least around {{ block.super }}.
>
>
It is not a problem. I complicate my previous example, it now works:

1. news.html

{% extends "base.html" %}

{% block title %}
{% include "inc.news.title.html" %}
{% endblock %}

{% block content %}
{% if news %}
{% for news_item in news %}
{{ news_item.title }}
{{ news_item.subtitle }}
{% endfor %}
{% else %}
{{ block.super }}
{% endif %}
{% endblock %}

2. base.html

http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
http://www.w3.org/1999/xhtml"; lang="{{
LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
%}>

{% block title %}{% endblock %}


{% block content %}
Sorry no results
{% endblock %}



3. inc.news.title.html
News

With this command I preproces every template of a settings variable and I
get something like this:

news.unify.html

http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
http://www.w3.org/1999/xhtml"; lang="{{
LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
%}>

News


{% if news %}
{% for news_item in news %}
{{ news_item.title }}
{{ news_item.subtitle }}
{% endfor %}
{% else %}
Sorry no results
{% endif %}



Best,



> On Sat, 19 Jan 2019 at 10:00, Jani Tiainen  wrote:
>
>> Hi.
>>
>> Unfortunately Django is already big. Every new feature requires careful
>> consideration since it adds maintenance burden to already loaded
>> maintainers.
>>
>> So best and pretty much only way to make your feature appear in Django
>> itself is to prove that your solution is widely adopted in everyday use and
>> it's "winning" technology.
>>
>> That would practically mean that code is well written, constantly
>> maintained and documented.
>>
>> You can keep showing speed test results but they really won't get you
>> anywhere. Let the people decide is your feature good or not. Get more
>> contributors to your feature to resolve edge cases that doesn't work yet.
>>
>>
>> J. Pablo Martín Cobos  kirjoitti la 19. tammik. 2019
>> klo 10.22:
>>
>>>
>>>
>>>
>>>
>>>
>>> El sáb., 19 ene. 2019 7:08, Jani Tiainen  escribió:
>>>
 Hi,

 You said that this doesn't require any change in Django at all.

 So this doesn't need to be in Django at all, it can survive as its own
 and that way it should be.

 So make your enhancement as reusable app and release it to public. Get
 people to use it. Fix the bugs that appears. Write a good documentation.
 Give the support.


>>> Yes, it is an option, or another option is convince for this feature is
>>> in Django.
>>>
>>> This doesn't need to be in Django, but I think, it is convenient, like
>>> any improve.
>>>
>>> Thanks!
>>>
>>>
>>>
>>>

 On Sat, Jan 19, 2019 at 12:18 AM J. Pablo Martín Cobos <
 goi...@gmail.com> wrote:

> I reply beetween lines,
>
> El vie., 18 ene. 2019 a las 21:25, Jani Tiainen ()
> escribió:
>
>> Hi,
>>
>> Lets try this again.
>>
>> Your system could be nice if it really helps rendering speed.
>>
>
> Yes we get several miliseconds per request.
>
>
>>
>> But does it require changes in Django core itself, or is it

Re: What do you think about unify templates feature?

2019-01-19 Thread J . Pablo Martín Cobos
I reply between lines,

El sáb., 19 ene. 2019 a las 11:00, Jani Tiainen ()
escribió:

> Hi.
>
> Unfortunately Django is already big. Every new feature requires careful
> consideration since it adds maintenance burden to already loaded
> maintainers.
>

Yes, I know it.


>
> So best and pretty much only way to make your feature appear in Django
> itself is to prove that your solution is widely adopted in everyday use and
> it's "winning" technology.
>
> That would practically mean that code is well written, constantly
> maintained and documented.
>
> You can keep showing speed test results but they really won't get you
> anywhere. Let the people decide is your feature good or not. Get more
> contributors to your feature to resolve edge cases that doesn't work yet.
>

My experience: I proposed a new feature (much more complicated to be
accepted) 8 years ago [1] (when Django was already a big project). I did a
reusable Django app with this feature and I did 3 pull requests (8 years
ago, 7 years ago and 5 years ago), but these never were accepted. The
feature was implemented 4 years ago.  Currently, I think if I only had
create that ticket had been the same.

I don't need nobody use my code, I don't need maintain code... I only need
a good idea, and somebody (I or another person) implements it. You have
your opinion to contribute, and I had the same opinion, but my experience
is other with Django. You can see in my github profile [2] I have
colaborate with other projects without problems.

Anyway if I have any time to do a code that works in every cases and I have
any time to do a reusable app, and I will do it. In short time, I will
create a ticket in Django.

Thanks for your opinion :-)

Best,


REF's

1. https://code.djangoproject.com/ticket/15053
2. https://github.com/goinnn



>
> J. Pablo Martín Cobos  kirjoitti la 19. tammik. 2019
> klo 10.22:
>
>>
>>
>>
>>
>>
>> El sáb., 19 ene. 2019 7:08, Jani Tiainen  escribió:
>>
>>> Hi,
>>>
>>> You said that this doesn't require any change in Django at all.
>>>
>>> So this doesn't need to be in Django at all, it can survive as its own
>>> and that way it should be.
>>>
>>> So make your enhancement as reusable app and release it to public. Get
>>> people to use it. Fix the bugs that appears. Write a good documentation.
>>> Give the support.
>>>
>>>
>> Yes, it is an option, or another option is convince for this feature is
>> in Django.
>>
>> This doesn't need to be in Django, but I think, it is convenient, like
>> any improve.
>>
>> Thanks!
>>
>>
>>
>>
>>>
>>> On Sat, Jan 19, 2019 at 12:18 AM J. Pablo Martín Cobos 
>>> wrote:
>>>
 I reply beetween lines,

 El vie., 18 ene. 2019 a las 21:25, Jani Tiainen ()
 escribió:

> Hi,
>
> Lets try this again.
>
> Your system could be nice if it really helps rendering speed.
>

 Yes we get several miliseconds per request.


>
> But does it require changes in Django core itself, or is it completely
> standalone package that doesn't require changing Django itself to operate?
> If it requires changes in Django itself, it would be useful to describe
> what changes are needed and why.
>
>
 You don't need any change in Django. This command generates a new
 template. I paste another time my first example:

 1. news.html

 {% extends "base.html" %}

 {% block title %}
 {% include "inc.news.title.html" %}
 {% endblock %}

 {% block content %}
 {% for news_item in news %}
 {{ news_item.title }}
 {{ news_item.subtitle }}
 {% endfor %}
 {% endblock %}

 2. base.html

 >>> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
 http://www.w3.org/1999/xhtml"; lang="{{
 LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
 %}>
 
 {% block title %}{% endblock %}
 
 
 {% block content %}{% endblock %}
 
 

 3. inc.news.title.html
 News

 With this command I preprocess every template of a settings variable
 and I get something like this:

 news.unify.html (or if you want the command can overwrite news.html)

 >>> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
 http://www.w3.org/1999/xhtml"; lang="{{
 LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
 %}>
 
 News
 
 
 {% for news_item in news %}
 {{ news_item.title }}
 {{ news_item.subtitle }}
 {% endfor %}
 
 

 It is only a preprocess to get time for each request.

 Note that you can even no build custom rendering engines since Django
> supports those now (with default implementati

Re: What do you think about unify templates feature?

2019-01-19 Thread Adam Johnson
I agree, I'd like to see a third party package too.

I'm all up for seeing improvements in template rendering speed but working
code in a third party package is way more valuable than more discussion.
Many of Django's major features in the past (e.g. SecurityMiddleware,
Migrations) were third party packages for a long time before being merged
in due to community consensus that they were a good idea.

Nice to see that it is an improvement over the cached loader, but it does
seem like it would complicate things for users quite a bit as it stands -
having to run another command on deployments, maybe modifying view code to
load a different template name in production, and creating more files that
increase the size of a deployment or use more memory.

Also I think there might be a number of edge cases that would make
"unification" very hard - IIRC you can have an {% if %} around a {% block %}
or at least around {{ block.super }}.

On Sat, 19 Jan 2019 at 10:00, Jani Tiainen  wrote:

> Hi.
>
> Unfortunately Django is already big. Every new feature requires careful
> consideration since it adds maintenance burden to already loaded
> maintainers.
>
> So best and pretty much only way to make your feature appear in Django
> itself is to prove that your solution is widely adopted in everyday use and
> it's "winning" technology.
>
> That would practically mean that code is well written, constantly
> maintained and documented.
>
> You can keep showing speed test results but they really won't get you
> anywhere. Let the people decide is your feature good or not. Get more
> contributors to your feature to resolve edge cases that doesn't work yet.
>
>
> J. Pablo Martín Cobos  kirjoitti la 19. tammik. 2019
> klo 10.22:
>
>>
>>
>>
>>
>>
>> El sáb., 19 ene. 2019 7:08, Jani Tiainen  escribió:
>>
>>> Hi,
>>>
>>> You said that this doesn't require any change in Django at all.
>>>
>>> So this doesn't need to be in Django at all, it can survive as its own
>>> and that way it should be.
>>>
>>> So make your enhancement as reusable app and release it to public. Get
>>> people to use it. Fix the bugs that appears. Write a good documentation.
>>> Give the support.
>>>
>>>
>> Yes, it is an option, or another option is convince for this feature is
>> in Django.
>>
>> This doesn't need to be in Django, but I think, it is convenient, like
>> any improve.
>>
>> Thanks!
>>
>>
>>
>>
>>>
>>> On Sat, Jan 19, 2019 at 12:18 AM J. Pablo Martín Cobos 
>>> wrote:
>>>
 I reply beetween lines,

 El vie., 18 ene. 2019 a las 21:25, Jani Tiainen ()
 escribió:

> Hi,
>
> Lets try this again.
>
> Your system could be nice if it really helps rendering speed.
>

 Yes we get several miliseconds per request.


>
> But does it require changes in Django core itself, or is it completely
> standalone package that doesn't require changing Django itself to operate?
> If it requires changes in Django itself, it would be useful to describe
> what changes are needed and why.
>
>
 You don't need any change in Django. This command generates a new
 template. I paste another time my first example:

 1. news.html

 {% extends "base.html" %}

 {% block title %}
 {% include "inc.news.title.html" %}
 {% endblock %}

 {% block content %}
 {% for news_item in news %}
 {{ news_item.title }}
 {{ news_item.subtitle }}
 {% endfor %}
 {% endblock %}

 2. base.html

 >>> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
 http://www.w3.org/1999/xhtml"; lang="{{
 LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
 %}>
 
 {% block title %}{% endblock %}
 
 
 {% block content %}{% endblock %}
 
 

 3. inc.news.title.html
 News

 With this command I preprocess every template of a settings variable
 and I get something like this:

 news.unify.html (or if you want the command can overwrite news.html)

 >>> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
 http://www.w3.org/1999/xhtml"; lang="{{
 LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
 %}>
 
 News
 
 
 {% for news_item in news %}
 {{ news_item.title }}
 {{ news_item.subtitle }}
 {% endfor %}
 
 

 It is only a preprocess to get time for each request.

 Note that you can even no build custom rendering engines since Django
> supports those now (with default implementations for Django Templating
> Language and Jinja2) your system actually might fall in this category.
>
>
 No, It is not a new render e

Re: What do you think about unify templates feature?

2019-01-19 Thread Jani Tiainen
Hi.

Unfortunately Django is already big. Every new feature requires careful
consideration since it adds maintenance burden to already loaded
maintainers.

So best and pretty much only way to make your feature appear in Django
itself is to prove that your solution is widely adopted in everyday use and
it's "winning" technology.

That would practically mean that code is well written, constantly
maintained and documented.

You can keep showing speed test results but they really won't get you
anywhere. Let the people decide is your feature good or not. Get more
contributors to your feature to resolve edge cases that doesn't work yet.


J. Pablo Martín Cobos  kirjoitti la 19. tammik. 2019 klo
10.22:

>
>
>
>
>
> El sáb., 19 ene. 2019 7:08, Jani Tiainen  escribió:
>
>> Hi,
>>
>> You said that this doesn't require any change in Django at all.
>>
>> So this doesn't need to be in Django at all, it can survive as its own
>> and that way it should be.
>>
>> So make your enhancement as reusable app and release it to public. Get
>> people to use it. Fix the bugs that appears. Write a good documentation.
>> Give the support.
>>
>>
> Yes, it is an option, or another option is convince for this feature is in
> Django.
>
> This doesn't need to be in Django, but I think, it is convenient, like any
> improve.
>
> Thanks!
>
>
>
>
>>
>> On Sat, Jan 19, 2019 at 12:18 AM J. Pablo Martín Cobos 
>> wrote:
>>
>>> I reply beetween lines,
>>>
>>> El vie., 18 ene. 2019 a las 21:25, Jani Tiainen ()
>>> escribió:
>>>
 Hi,

 Lets try this again.

 Your system could be nice if it really helps rendering speed.

>>>
>>> Yes we get several miliseconds per request.
>>>
>>>

 But does it require changes in Django core itself, or is it completely
 standalone package that doesn't require changing Django itself to operate?
 If it requires changes in Django itself, it would be useful to describe
 what changes are needed and why.


>>> You don't need any change in Django. This command generates a new
>>> template. I paste another time my first example:
>>>
>>> 1. news.html
>>>
>>> {% extends "base.html" %}
>>>
>>> {% block title %}
>>> {% include "inc.news.title.html" %}
>>> {% endblock %}
>>>
>>> {% block content %}
>>> {% for news_item in news %}
>>> {{ news_item.title }}
>>> {{ news_item.subtitle }}
>>> {% endfor %}
>>> {% endblock %}
>>>
>>> 2. base.html
>>>
>>> >> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>>> http://www.w3.org/1999/xhtml"; lang="{{
>>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
>>> %}>
>>> 
>>> {% block title %}{% endblock %}
>>> 
>>> 
>>> {% block content %}{% endblock %}
>>> 
>>> 
>>>
>>> 3. inc.news.title.html
>>> News
>>>
>>> With this command I preprocess every template of a settings variable and
>>> I get something like this:
>>>
>>> news.unify.html (or if you want the command can overwrite news.html)
>>>
>>> >> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>>> http://www.w3.org/1999/xhtml"; lang="{{
>>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
>>> %}>
>>> 
>>> News
>>> 
>>> 
>>> {% for news_item in news %}
>>> {{ news_item.title }}
>>> {{ news_item.subtitle }}
>>> {% endfor %}
>>> 
>>> 
>>>
>>> It is only a preprocess to get time for each request.
>>>
>>> Note that you can even no build custom rendering engines since Django
 supports those now (with default implementations for Django Templating
 Language and Jinja2) your system actually might fall in this category.


>>> No, It is not a new render engine. It would be a pre render engine. It
>>> is a new feature.
>>>
>>>
 Even code is bad you really need to start get some momentum for your
 system. Otherwise it's really hard to provide any feedback for example
 there might be some edgecases you might not have thought of.

>>>
>>> I want to know if this is a nice feature for Django community, then I
>>> will create a ticket... and if nobody resolve it I will propose a change,
>>> but I know ifor experience it is very hard collaborate with code in Django,
>>> and more difficult with a new feature.
>>>
>>> To understand it, the best is to use the command with a simple template
>>> such as admin/index.html.
>>>
>>> Best,
>>>
>>>

 On Fri, Jan 18, 2019 at 7:23 PM J. Pablo Martín Cobos 
 wrote:

> Sorry, I reply beetween lines
>
> El vie., 18 ene. 2019 16:32, J. Pablo Martín Cobos 
> escribió:
>
>> Hi another time,
>>
>> I am tring to reply every people in this email:
>>
>> Josh
>>
>> I was not using django.template.loaders.cached.Loader, but the result
>> are very similar i.e:
>>
>> App Tem

Re: What do you think about unify templates feature?

2019-01-19 Thread J . Pablo Martín Cobos
El sáb., 19 ene. 2019 7:08, Jani Tiainen  escribió:

> Hi,
>
> You said that this doesn't require any change in Django at all.
>
> So this doesn't need to be in Django at all, it can survive as its own and
> that way it should be.
>
> So make your enhancement as reusable app and release it to public. Get
> people to use it. Fix the bugs that appears. Write a good documentation.
> Give the support.
>
>
Yes, it is an option, or another option is convince for this feature is in
Django.

This doesn't need to be in Django, but I think, it is convenient, like any
improve.

Thanks!




>
> On Sat, Jan 19, 2019 at 12:18 AM J. Pablo Martín Cobos 
> wrote:
>
>> I reply beetween lines,
>>
>> El vie., 18 ene. 2019 a las 21:25, Jani Tiainen ()
>> escribió:
>>
>>> Hi,
>>>
>>> Lets try this again.
>>>
>>> Your system could be nice if it really helps rendering speed.
>>>
>>
>> Yes we get several miliseconds per request.
>>
>>
>>>
>>> But does it require changes in Django core itself, or is it completely
>>> standalone package that doesn't require changing Django itself to operate?
>>> If it requires changes in Django itself, it would be useful to describe
>>> what changes are needed and why.
>>>
>>>
>> You don't need any change in Django. This command generates a new
>> template. I paste another time my first example:
>>
>> 1. news.html
>>
>> {% extends "base.html" %}
>>
>> {% block title %}
>> {% include "inc.news.title.html" %}
>> {% endblock %}
>>
>> {% block content %}
>> {% for news_item in news %}
>> {{ news_item.title }}
>> {{ news_item.subtitle }}
>> {% endfor %}
>> {% endblock %}
>>
>> 2. base.html
>>
>> > http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>> http://www.w3.org/1999/xhtml"; lang="{{
>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
>> %}>
>> 
>> {% block title %}{% endblock %}
>> 
>> 
>> {% block content %}{% endblock %}
>> 
>> 
>>
>> 3. inc.news.title.html
>> News
>>
>> With this command I preprocess every template of a settings variable and
>> I get something like this:
>>
>> news.unify.html (or if you want the command can overwrite news.html)
>>
>> > http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>> http://www.w3.org/1999/xhtml"; lang="{{
>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
>> %}>
>> 
>> News
>> 
>> 
>> {% for news_item in news %}
>> {{ news_item.title }}
>> {{ news_item.subtitle }}
>> {% endfor %}
>> 
>> 
>>
>> It is only a preprocess to get time for each request.
>>
>> Note that you can even no build custom rendering engines since Django
>>> supports those now (with default implementations for Django Templating
>>> Language and Jinja2) your system actually might fall in this category.
>>>
>>>
>> No, It is not a new render engine. It would be a pre render engine. It is
>> a new feature.
>>
>>
>>> Even code is bad you really need to start get some momentum for your
>>> system. Otherwise it's really hard to provide any feedback for example
>>> there might be some edgecases you might not have thought of.
>>>
>>
>> I want to know if this is a nice feature for Django community, then I
>> will create a ticket... and if nobody resolve it I will propose a change,
>> but I know ifor experience it is very hard collaborate with code in Django,
>> and more difficult with a new feature.
>>
>> To understand it, the best is to use the command with a simple template
>> such as admin/index.html.
>>
>> Best,
>>
>>
>>>
>>> On Fri, Jan 18, 2019 at 7:23 PM J. Pablo Martín Cobos 
>>> wrote:
>>>
 Sorry, I reply beetween lines

 El vie., 18 ene. 2019 16:32, J. Pablo Martín Cobos 
 escribió:

> Hi another time,
>
> I am tring to reply every people in this email:
>
> Josh
>
> I was not using django.template.loaders.cached.Loader, but the result
> are very similar i.e:
>
> App Template Num templates rendered before unify Num templates
> rendered after unify AVG Time render template before unify (ms) AVG
> Time render template after unify (ms)
> Django admin admin/index.html 3 1 80 70
> Django constance admin/constance/change_list.html 7 1 330 180
> Django su su/login.html 5 3 10 5
>
> Pavlos:
>
>1. Yes, I wrote this email to contribute another time. Actually I
>am already Django contributor[1][2]
>2. I didn't share my code, because it is not a nice code. *For me
>it is a teoric question. I don't want anybody have a bad opinion of 
> this
>proposal for the implementation*. But I am sharing [3] it without
>problems, but please I know this solution is incomplete for many 
> reason.
>3. About your question: "I am not sure I understood anything so
>>

Re: What do you think about unify templates feature?

2019-01-18 Thread Jani Tiainen
Hi,

You said that this doesn't require any change in Django at all.

So this doesn't need to be in Django at all, it can survive as its own and
that way it should be.

So make your enhancement as reusable app and release it to public. Get
people to use it. Fix the bugs that appears. Write a good documentation.
Give the support.



On Sat, Jan 19, 2019 at 12:18 AM J. Pablo Martín Cobos 
wrote:

> I reply beetween lines,
>
> El vie., 18 ene. 2019 a las 21:25, Jani Tiainen ()
> escribió:
>
>> Hi,
>>
>> Lets try this again.
>>
>> Your system could be nice if it really helps rendering speed.
>>
>
> Yes we get several miliseconds per request.
>
>
>>
>> But does it require changes in Django core itself, or is it completely
>> standalone package that doesn't require changing Django itself to operate?
>> If it requires changes in Django itself, it would be useful to describe
>> what changes are needed and why.
>>
>>
> You don't need any change in Django. This command generates a new
> template. I paste another time my first example:
>
> 1. news.html
>
> {% extends "base.html" %}
>
> {% block title %}
> {% include "inc.news.title.html" %}
> {% endblock %}
>
> {% block content %}
> {% for news_item in news %}
> {{ news_item.title }}
> {{ news_item.subtitle }}
> {% endfor %}
> {% endblock %}
>
> 2. base.html
>
>  http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
> http://www.w3.org/1999/xhtml"; lang="{{
> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
> %}>
> 
> {% block title %}{% endblock %}
> 
> 
> {% block content %}{% endblock %}
> 
> 
>
> 3. inc.news.title.html
> News
>
> With this command I preprocess every template of a settings variable and I
> get something like this:
>
> news.unify.html (or if you want the command can overwrite news.html)
>
>  http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
> http://www.w3.org/1999/xhtml"; lang="{{
> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
> %}>
> 
> News
> 
> 
> {% for news_item in news %}
> {{ news_item.title }}
> {{ news_item.subtitle }}
> {% endfor %}
> 
> 
>
> It is only a preprocess to get time for each request.
>
> Note that you can even no build custom rendering engines since Django
>> supports those now (with default implementations for Django Templating
>> Language and Jinja2) your system actually might fall in this category.
>>
>>
> No, It is not a new render engine. It would be a pre render engine. It is
> a new feature.
>
>
>> Even code is bad you really need to start get some momentum for your
>> system. Otherwise it's really hard to provide any feedback for example
>> there might be some edgecases you might not have thought of.
>>
>
> I want to know if this is a nice feature for Django community, then I will
> create a ticket... and if nobody resolve it I will propose a change, but I
> know ifor experience it is very hard collaborate with code in Django, and
> more difficult with a new feature.
>
> To understand it, the best is to use the command with a simple template
> such as admin/index.html.
>
> Best,
>
>
>>
>> On Fri, Jan 18, 2019 at 7:23 PM J. Pablo Martín Cobos 
>> wrote:
>>
>>> Sorry, I reply beetween lines
>>>
>>> El vie., 18 ene. 2019 16:32, J. Pablo Martín Cobos 
>>> escribió:
>>>
 Hi another time,

 I am tring to reply every people in this email:

 Josh

 I was not using django.template.loaders.cached.Loader, but the result
 are very similar i.e:

 App Template Num templates rendered before unify Num templates
 rendered after unify AVG Time render template before unify (ms) AVG
 Time render template after unify (ms)
 Django admin admin/index.html 3 1 80 70
 Django constance admin/constance/change_list.html 7 1 330 180
 Django su su/login.html 5 3 10 5

 Pavlos:

1. Yes, I wrote this email to contribute another time. Actually I
am already Django contributor[1][2]
2. I didn't share my code, because it is not a nice code. *For me
it is a teoric question. I don't want anybody have a bad opinion of this
proposal for the implementation*. But I am sharing [3] it without
problems, but please I know this solution is incomplete for many reason.
3. About your question: "I am not sure I understood anything so
far. Are you just pre-rendering {% include %} tags, so the template 
 engine
doesn't have to do that in runtime?" Yes :-)
4. About it: "I think what you did is addressed more neatly with
the django.template.loaders.cached.Loader, as Josh Smeaton mentioned." 
 and
"Experimenting like this, even if you end up rediscovering something 
 that
exists" It is s

Re: What do you think about unify templates feature?

2019-01-18 Thread J . Pablo Martín Cobos
I reply beetween lines,

El vie., 18 ene. 2019 a las 21:25, Jani Tiainen ()
escribió:

> Hi,
>
> Lets try this again.
>
> Your system could be nice if it really helps rendering speed.
>

Yes we get several miliseconds per request.


>
> But does it require changes in Django core itself, or is it completely
> standalone package that doesn't require changing Django itself to operate?
> If it requires changes in Django itself, it would be useful to describe
> what changes are needed and why.
>
>
You don't need any change in Django. This command generates a new template.
I paste another time my first example:

1. news.html

{% extends "base.html" %}

{% block title %}
{% include "inc.news.title.html" %}
{% endblock %}

{% block content %}
{% for news_item in news %}
{{ news_item.title }}
{{ news_item.subtitle }}
{% endfor %}
{% endblock %}

2. base.html

http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
http://www.w3.org/1999/xhtml"; lang="{{
LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
%}>

{% block title %}{% endblock %}


{% block content %}{% endblock %}



3. inc.news.title.html
News

With this command I preprocess every template of a settings variable and I
get something like this:

news.unify.html (or if you want the command can overwrite news.html)

http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
http://www.w3.org/1999/xhtml"; lang="{{
LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
%}>

News


{% for news_item in news %}
{{ news_item.title }}
{{ news_item.subtitle }}
{% endfor %}



It is only a preprocess to get time for each request.

Note that you can even no build custom rendering engines since Django
> supports those now (with default implementations for Django Templating
> Language and Jinja2) your system actually might fall in this category.
>
>
No, It is not a new render engine. It would be a pre render engine. It is a
new feature.


> Even code is bad you really need to start get some momentum for your
> system. Otherwise it's really hard to provide any feedback for example
> there might be some edgecases you might not have thought of.
>

I want to know if this is a nice feature for Django community, then I will
create a ticket... and if nobody resolve it I will propose a change, but I
know ifor experience it is very hard collaborate with code in Django, and
more difficult with a new feature.

To understand it, the best is to use the command with a simple template
such as admin/index.html.

Best,


>
> On Fri, Jan 18, 2019 at 7:23 PM J. Pablo Martín Cobos 
> wrote:
>
>> Sorry, I reply beetween lines
>>
>> El vie., 18 ene. 2019 16:32, J. Pablo Martín Cobos 
>> escribió:
>>
>>> Hi another time,
>>>
>>> I am tring to reply every people in this email:
>>>
>>> Josh
>>>
>>> I was not using django.template.loaders.cached.Loader, but the result
>>> are very similar i.e:
>>>
>>> App Template Num templates rendered before unify Num templates rendered
>>> after unify AVG Time render template before unify (ms) AVG Time render
>>> template after unify (ms)
>>> Django admin admin/index.html 3 1 80 70
>>> Django constance admin/constance/change_list.html 7 1 330 180
>>> Django su su/login.html 5 3 10 5
>>>
>>> Pavlos:
>>>
>>>1. Yes, I wrote this email to contribute another time. Actually I am
>>>already Django contributor[1][2]
>>>2. I didn't share my code, because it is not a nice code. *For me it
>>>is a teoric question. I don't want anybody have a bad opinion of this
>>>proposal for the implementation*. But I am sharing [3] it without
>>>problems, but please I know this solution is incomplete for many reason.
>>>3. About your question: "I am not sure I understood anything so far.
>>>Are you just pre-rendering {% include %} tags, so the template engine
>>>doesn't have to do that in runtime?" Yes :-)
>>>4. About it: "I think what you did is addressed more neatly with the
>>>django.template.loaders.cached.Loader, as Josh Smeaton mentioned." and
>>>"Experimenting like this, even if you end up rediscovering something that
>>>exists" It is something different than django cache loader, of course I
>>>know django cache loader, I fixed a problem with django cached loader [4]
>>>five years ago :-). With django cache loader, we get django get a 
>>> template
>>>quickly. But If your view finally render 3 templates, django cached 
>>> loader
>>>will have to get 3 templates (from cache). With my proposal your view
>>>render only 1 template (This is not 100% true, 1 + templates about
>>>templatetags except extends and include)
>>>
>>> Jani:
>>>
>>> Currently you only need move the new template result to the old path of
>>> the template

Re: What do you think about unify templates feature?

2019-01-18 Thread Jani Tiainen
Hi,

Lets try this again.

Your system could be nice if it really helps rendering speed.

But does it require changes in Django core itself, or is it completely
standalone package that doesn't require changing Django itself to operate?
If it requires changes in Django itself, it would be useful to describe
what changes are needed and why.

Note that you can even no build custom rendering engines since Django
supports those now (with default implementations for Django Templating
Language and Jinja2) your system actually might fall in this category.

Even code is bad you really need to start get some momentum for your
system. Otherwise it's really hard to provide any feedback for example
there might be some edgecases you might not have thought of.


On Fri, Jan 18, 2019 at 7:23 PM J. Pablo Martín Cobos 
wrote:

> Sorry, I reply beetween lines
>
> El vie., 18 ene. 2019 16:32, J. Pablo Martín Cobos 
> escribió:
>
>> Hi another time,
>>
>> I am tring to reply every people in this email:
>>
>> Josh
>>
>> I was not using django.template.loaders.cached.Loader, but the result are
>> very similar i.e:
>>
>> App Template Num templates rendered before unify Num templates rendered
>> after unify AVG Time render template before unify (ms) AVG Time render
>> template after unify (ms)
>> Django admin admin/index.html 3 1 80 70
>> Django constance admin/constance/change_list.html 7 1 330 180
>> Django su su/login.html 5 3 10 5
>>
>> Pavlos:
>>
>>1. Yes, I wrote this email to contribute another time. Actually I am
>>already Django contributor[1][2]
>>2. I didn't share my code, because it is not a nice code. *For me it
>>is a teoric question. I don't want anybody have a bad opinion of this
>>proposal for the implementation*. But I am sharing [3] it without
>>problems, but please I know this solution is incomplete for many reason.
>>3. About your question: "I am not sure I understood anything so far.
>>Are you just pre-rendering {% include %} tags, so the template engine
>>doesn't have to do that in runtime?" Yes :-)
>>4. About it: "I think what you did is addressed more neatly with the
>>django.template.loaders.cached.Loader, as Josh Smeaton mentioned." and
>>"Experimenting like this, even if you end up rediscovering something that
>>exists" It is something different than django cache loader, of course I
>>know django cache loader, I fixed a problem with django cached loader [4]
>>five years ago :-). With django cache loader, we get django get a template
>>quickly. But If your view finally render 3 templates, django cached loader
>>will have to get 3 templates (from cache). With my proposal your view
>>render only 1 template (This is not 100% true, 1 + templates about
>>templatetags except extends and include)
>>
>> Jani:
>>
>> Currently you only need move the new template result to the old path of
>> the template. But it is only because I want. If you change this line [5]
>> for this other you don't need any change:
>>
>> destination_name = template.origin.name
>>
>>
>> 8 years ago I requested a feature related with templates
>>
>
> [6]
>
>
> , now I have a new request :-) 8 years ago I tried resolved my proposal,
>> now I only want propose something :-D
>>
>> I think in this change for Django :-)
>>
>>
>> REF's
>>
>> 1.
>> https://github.com/django/django/pulls?q=is%3Apr+author%3Agoinnn+is%3Aclosed
>> 2.
>> https://code.djangoproject.com/query?status=assigned&status=closed&status=new&reporter=~pmartin&col=id&col=summary&col=status&col=owner&col=type&col=component&col=version&desc=1&order=id
>> 3. https://gist.github.com/goinnn/8a42314fccdd13bcf4df256a277ec1f6
>> (tested in Django 1.8 - 1.11)
>> 4.
>> https://github.com/django/django/pull/1936/commits/e669bca5c8fe6d13ea745d338203cd9e7470ae6b
>> 5.
>> https://gist.github.com/goinnn/8a42314fccdd13bcf4df256a277ec1f6#file-unify_templates-py-L58
>> 6. https://code.djangoproject.com/ticket/15053
>>
>>
>> Best,
>>
>>
>> El vie., 18 ene. 2019 a las 14:11, Jani Tiainen ()
>> escribió:
>>
>>> Hi.
>>>
>>> Does this require changes to django internals or can it work as an
>>> external package?
>>>
>>> Also you should release it as a package so people can start using it,
>>> also preferably releasing it with BSD license like Django itself is.
>>> Otherwise there are very little chances that your solution would make to
>>> django it self.
>>>
>>> Improvements to rendering are always welcome, but they must come without
>>> too much maintenance burden.
>>>
>>> On Thu, Jan 17, 2019 at 11:02 AM J. Pablo Martín Cobos 
>>> wrote:
>>>
 Hi,

 From one year ago, I am using an own command for Django templates that
 unify them. With an example it is easy to see. If I am to render for
 example a template call news.html like it:

 1. news.html

 {% extends "base.html" %}

 {% block title %}
 {% include "inc.news.title.html" %}
 {% endblock %}

   

Re: What do you think about unify templates feature?

2019-01-18 Thread J . Pablo Martín Cobos
Sorry, I reply beetween lines

El vie., 18 ene. 2019 16:32, J. Pablo Martín Cobos 
escribió:

> Hi another time,
>
> I am tring to reply every people in this email:
>
> Josh
>
> I was not using django.template.loaders.cached.Loader, but the result are
> very similar i.e:
>
> App Template Num templates rendered before unify Num templates rendered
> after unify AVG Time render template before unify (ms) AVG Time render
> template after unify (ms)
> Django admin admin/index.html 3 1 80 70
> Django constance admin/constance/change_list.html 7 1 330 180
> Django su su/login.html 5 3 10 5
>
> Pavlos:
>
>1. Yes, I wrote this email to contribute another time. Actually I am
>already Django contributor[1][2]
>2. I didn't share my code, because it is not a nice code. *For me it
>is a teoric question. I don't want anybody have a bad opinion of this
>proposal for the implementation*. But I am sharing [3] it without
>problems, but please I know this solution is incomplete for many reason.
>3. About your question: "I am not sure I understood anything so far.
>Are you just pre-rendering {% include %} tags, so the template engine
>doesn't have to do that in runtime?" Yes :-)
>4. About it: "I think what you did is addressed more neatly with the
>django.template.loaders.cached.Loader, as Josh Smeaton mentioned." and
>"Experimenting like this, even if you end up rediscovering something that
>exists" It is something different than django cache loader, of course I
>know django cache loader, I fixed a problem with django cached loader [4]
>five years ago :-). With django cache loader, we get django get a template
>quickly. But If your view finally render 3 templates, django cached loader
>will have to get 3 templates (from cache). With my proposal your view
>render only 1 template (This is not 100% true, 1 + templates about
>templatetags except extends and include)
>
> Jani:
>
> Currently you only need move the new template result to the old path of
> the template. But it is only because I want. If you change this line [5]
> for this other you don't need any change:
>
> destination_name = template.origin.name
>
>
> 8 years ago I requested a feature related with templates
>

[6]


, now I have a new request :-) 8 years ago I tried resolved my proposal,
> now I only want propose something :-D
>
> I think in this change for Django :-)
>
>
> REF's
>
> 1.
> https://github.com/django/django/pulls?q=is%3Apr+author%3Agoinnn+is%3Aclosed
> 2.
> https://code.djangoproject.com/query?status=assigned&status=closed&status=new&reporter=~pmartin&col=id&col=summary&col=status&col=owner&col=type&col=component&col=version&desc=1&order=id
> 3. https://gist.github.com/goinnn/8a42314fccdd13bcf4df256a277ec1f6
> (tested in Django 1.8 - 1.11)
> 4.
> https://github.com/django/django/pull/1936/commits/e669bca5c8fe6d13ea745d338203cd9e7470ae6b
> 5.
> https://gist.github.com/goinnn/8a42314fccdd13bcf4df256a277ec1f6#file-unify_templates-py-L58
> 6. https://code.djangoproject.com/ticket/15053
>
>
> Best,
>
>
> El vie., 18 ene. 2019 a las 14:11, Jani Tiainen ()
> escribió:
>
>> Hi.
>>
>> Does this require changes to django internals or can it work as an
>> external package?
>>
>> Also you should release it as a package so people can start using it,
>> also preferably releasing it with BSD license like Django itself is.
>> Otherwise there are very little chances that your solution would make to
>> django it self.
>>
>> Improvements to rendering are always welcome, but they must come without
>> too much maintenance burden.
>>
>> On Thu, Jan 17, 2019 at 11:02 AM J. Pablo Martín Cobos 
>> wrote:
>>
>>> Hi,
>>>
>>> From one year ago, I am using an own command for Django templates that
>>> unify them. With an example it is easy to see. If I am to render for
>>> example a template call news.html like it:
>>>
>>> 1. news.html
>>>
>>> {% extends "base.html" %}
>>>
>>> {% block title %}
>>> {% include "inc.news.title.html" %}
>>> {% endblock %}
>>>
>>> {% block content %}
>>> {% for news_item in news %}
>>> {{ news_item.title }}
>>> {{ news_item.subtitle }}
>>> {% endfor %}
>>> {% endblock %}
>>>
>>> 2. base.html
>>>
>>> >> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>>> http://www.w3.org/1999/xhtml"; lang="{{
>>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
>>> %}>
>>> 
>>> {% block title %}{% endblock %}
>>> 
>>> 
>>> {% block content %}{% endblock %}
>>> 
>>> 
>>>
>>> 3. inc.news.title.html
>>> News
>>>
>>> With this command I preproces every template of a settings variable and
>>> I get something like this:
>>>
>>> news.unify.html
>>>
>>> >> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>>> http://www.w3.org/1999/xhtml"; lang="{{
>>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endi

Re: What do you think about unify templates feature?

2019-01-18 Thread J . Pablo Martín Cobos
Hi another time,

I am tring to reply every people in this email:

Josh

I was not using django.template.loaders.cached.Loader, but the result are
very similar i.e:

App Template Num templates rendered before unify Num templates rendered
after unify AVG Time render template before unify (ms) AVG Time render
template after unify (ms)
Django admin admin/index.html 3 1 80 70
Django constance admin/constance/change_list.html 7 1 330 180
Django su su/login.html 5 3 10 5

Pavlos:

   1. Yes, I wrote this email to contribute another time. Actually I am
   already Django contributor[1][2]
   2. I didn't share my code, because it is not a nice code. *For me it is
   a teoric question. I don't want anybody have a bad opinion of this proposal
   for the implementation*. But I am sharing [3] it without problems, but
   please I know this solution is incomplete for many reason.
   3. About your question: "I am not sure I understood anything so far. Are
   you just pre-rendering {% include %} tags, so the template engine doesn't
   have to do that in runtime?" Yes :-)
   4. About it: "I think what you did is addressed more neatly with the
   django.template.loaders.cached.Loader, as Josh Smeaton mentioned." and
   "Experimenting like this, even if you end up rediscovering something that
   exists" It is something different than django cache loader, of course I
   know django cache loader, I fixed a problem with django cached loader [4]
   five years ago :-). With django cache loader, we get django get a template
   quickly. But If your view finally render 3 templates, django cached loader
   will have to get 3 templates (from cache). With my proposal your view
   render only 1 template (This is not 100% true, 1 + templates about
   templatetags except extends and include)

Jani:

Currently you only need move the new template result to the old path of the
template. But it is only because I want. If you change this line [5] for
this other you don't need any change:

destination_name = template.origin.name


8 years ago I requested a feature related with templates, now I have a new
request :-) 8 years ago I tried resolved my proposal, now I only want
propose something :-D

I think in this change for Django :-)


REF's

1.
https://github.com/django/django/pulls?q=is%3Apr+author%3Agoinnn+is%3Aclosed
2.
https://code.djangoproject.com/query?status=assigned&status=closed&status=new&reporter=~pmartin&col=id&col=summary&col=status&col=owner&col=type&col=component&col=version&desc=1&order=id
3. https://gist.github.com/goinnn/8a42314fccdd13bcf4df256a277ec1f6 (tested
in Django 1.8 - 1.11)
4.
https://github.com/django/django/pull/1936/commits/e669bca5c8fe6d13ea745d338203cd9e7470ae6b
5.
https://gist.github.com/goinnn/8a42314fccdd13bcf4df256a277ec1f6#file-unify_templates-py-L58
6. https://code.djangoproject.com/ticket/15053


Best,


El vie., 18 ene. 2019 a las 14:11, Jani Tiainen ()
escribió:

> Hi.
>
> Does this require changes to django internals or can it work as an
> external package?
>
> Also you should release it as a package so people can start using it, also
> preferably releasing it with BSD license like Django itself is. Otherwise
> there are very little chances that your solution would make to django it
> self.
>
> Improvements to rendering are always welcome, but they must come without
> too much maintenance burden.
>
> On Thu, Jan 17, 2019 at 11:02 AM J. Pablo Martín Cobos 
> wrote:
>
>> Hi,
>>
>> From one year ago, I am using an own command for Django templates that
>> unify them. With an example it is easy to see. If I am to render for
>> example a template call news.html like it:
>>
>> 1. news.html
>>
>> {% extends "base.html" %}
>>
>> {% block title %}
>> {% include "inc.news.title.html" %}
>> {% endblock %}
>>
>> {% block content %}
>> {% for news_item in news %}
>> {{ news_item.title }}
>> {{ news_item.subtitle }}
>> {% endfor %}
>> {% endblock %}
>>
>> 2. base.html
>>
>> > http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>> http://www.w3.org/1999/xhtml"; lang="{{
>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
>> %}>
>> 
>> {% block title %}{% endblock %}
>> 
>> 
>> {% block content %}{% endblock %}
>> 
>> 
>>
>> 3. inc.news.title.html
>> News
>>
>> With this command I preproces every template of a settings variable and I
>> get something like this:
>>
>> news.unify.html
>>
>> > http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>> http://www.w3.org/1999/xhtml"; lang="{{
>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
>> %}>
>> 
>> News
>> 
>> 
>> {% for news_item in news %}
>> {{ news_item.title }}
>> {{ news_item.subtitle }}
>> {% endfor %}
>> 
>> 
>>
>> So I have a two improves:
>>
>>1. It is more 

Re: What do you think about unify templates feature?

2019-01-18 Thread Jani Tiainen
Hi.

Does this require changes to django internals or can it work as an external
package?

Also you should release it as a package so people can start using it, also
preferably releasing it with BSD license like Django itself is. Otherwise
there are very little chances that your solution would make to django it
self.

Improvements to rendering are always welcome, but they must come without
too much maintenance burden.

On Thu, Jan 17, 2019 at 11:02 AM J. Pablo Martín Cobos 
wrote:

> Hi,
>
> From one year ago, I am using an own command for Django templates that
> unify them. With an example it is easy to see. If I am to render for
> example a template call news.html like it:
>
> 1. news.html
>
> {% extends "base.html" %}
>
> {% block title %}
> {% include "inc.news.title.html" %}
> {% endblock %}
>
> {% block content %}
> {% for news_item in news %}
> {{ news_item.title }}
> {{ news_item.subtitle }}
> {% endfor %}
> {% endblock %}
>
> 2. base.html
>
>  http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
> http://www.w3.org/1999/xhtml"; lang="{{
> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
> %}>
> 
> {% block title %}{% endblock %}
> 
> 
> {% block content %}{% endblock %}
> 
> 
>
> 3. inc.news.title.html
> News
>
> With this command I preproces every template of a settings variable and I
> get something like this:
>
> news.unify.html
>
>  http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
> http://www.w3.org/1999/xhtml"; lang="{{
> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
> %}>
> 
> News
> 
> 
> {% for news_item in news %}
> {{ news_item.title }}
> {{ news_item.subtitle }}
> {% endfor %}
> 
> 
>
> So I have a two improves:
>
>1. It is more fast. And in a real project a view can render easyly 50
>templates
>2. I use news.html to develop and news.unify.html to production. So I
>don't lose legilibility.
>
>
> What do you think about "unify templates feature"? Do you know if exists a
> similar public project in github/gitlab/bitbucket etc?
>
>
> Best,
>
> --
> Pablo Martín Cobos
> Computer engineer
> Python/Django developer
> 652 53 37 36
> goi...@gmail.com
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/CALNyWLGNcuK8DTnU9w9fyGFhFfT3dAz7vfj3B%2BnDHWTfneLNFw%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Jani Tiainen

- Well planned is half done, and a half done has been sufficient before...

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAHn91odKFPEc96hbTLmuckAdhmf9LHykEvk--J%3D5vjNmyVGF5w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: What do you think about unify templates feature?

2019-01-18 Thread Pavlos Georgiadis
Hi,

I guess the reason you wrote to this list about your unify command, is
because you don't mind contributing it to the django project.

So maybe you could show the code of this command, so people can
understand what improvements it can offer.

I am not sure I understood anything so far. Are you just pre-rendering
{% include %} tags, so the template engine doesn't have to do that in
runtime?


--

Pavlos Georgiadis


On 18/01/19 11:31, J. Pablo Martín Cobos wrote:
> I answer between lines
>
> El jue., 17 ene. 2019 a las 18:42, Maciek Olko ( >) escribió:
>
> Did you try to measure the difference in time of rendering
> standard and your way?
>
>
> Yes. I have several examples:
>
> App   TemplateNum templates rendered before unify Num templates
> rendered after unify  Time render template before unify (ms)  Time
> render template after unify (ms)  Improve
> Django admin  admin/index.html3   1   75 - 11071 - 79 
> 22%
> Django admin  admin/change_list.html  26  Command error   180-300
> Command error 
> Django admin  admin/change_form.html  16  Command error   350-400
> Command error 
> Django constance  admin/constance/change_list.html7   1   
> 350-400
> 150-250   75%
> Django su su/login.html   5   3   15- 20  10 - 12 54%
>
>
> My command currently does not work with several complex templates like
> admin/change_list.html or admin/change_form.html But we can improve
> it, currently it works with almost all.
>
> If there is a nice improve with views that render few templates...
> imagine with views with a lot of templates.
>
> I have measure these times with django-debug-toolbar-template-timings
>
> With this email only I want to know if you see it can be a important
> feature to add to Django framework... or it is a silly thing.
>
> Best,
>
>  
>
> Regards,
> Maciej
>
> czw., 17.01.2019, 10:02 użytkownik J. Pablo Martín Cobos
> mailto:goi...@gmail.com>> napisał:
>
> Hi,
>
> From one year ago, I am using an own command for Django
> templates that unify them. With an example it is easy to see.
> If I am to render for example a template call news.html like it:
>
> 1. news.html
>
>     {% extends "base.html" %}
>
>     {% block title %}
>         {% include "inc.news.title.html" %}
>     {% endblock %}
>
>     {% block content %}
>         {% for news_item in news %}
>             {{ news_item.title }}
>             {{ news_item.subtitle }}
>         {% endfor %}
>     {% endblock %}
>
> 2. base.html
>
>      "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>     http://www.w3.org/1999/xhtml"; lang="{{
> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI
> %}dir="rtl"{% endif %}>
>         
>             {% block title %}{% endblock %}
>         
>         
>             {% block content %}{% endblock %}
>         
>     
>
> 3. inc.news.title.html
>     News
>
> With this command I preproces every template of a settings
> variable and I get something like this:
>
> news.unify.html
>
>      "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>     http://www.w3.org/1999/xhtml"; lang="{{
> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI
> %}dir="rtl"{% endif %}>
>         
>             News
>         
>         
>             {% for news_item in news %}
>                 {{ news_item.title }}
>                 {{ news_item.subtitle }}
>             {% endfor %}
>         
>     
>
> So I have a two improves:
>
>  1. It is more fast. And in a real project a view can render
> easyly 50 templates
>  2. I use news.html to develop and news.unify.html to
> production. So I don't lose legilibility.
>
>
> What do you think about "unify templates feature"? Do you know
> if exists a similar public project in github/gitlab/bitbucket etc?
>
>
> Best,
>
> -- 
> Pablo Martín Cobos
> Computer engineer
> Python/Django developer
> 652 53 37 36 
> goi...@gmail.com 
> -- 
> You received this message because you are subscribed to the
> Google Groups "Django developers (Contributions to Django
> itself)" group.
> To unsubscribe from this group and stop receiving emails from
> it, send an email to
> django-developers+unsubscr...@googlegroups.com
> .
> To post to this group, send email to
> django-

Re: What do you think about unify templates feature?

2019-01-18 Thread Josh Smeaton
Are you 
using 
https://docs.djangoproject.com/en/2.1/ref/templates/api/#django.template.loaders.cached.Loader
 
in your tests? And you should find a way to test rendering from the command 
line, which will allow you to get much better timing information.

On Friday, 18 January 2019 20:40:29 UTC+11, Goinnn wrote:
>
> I answer between lines
>
>
> El vie., 18 ene. 2019 a las 5:03, shiva kumar ( >) escribió:
>
>> Could you please explain about it. I hadn't understood ur idea.
>>
>
>
>1. Currently: with you render a view, this render a template. But 
>usually, this template extends of another and include others. So Django 
> has 
>to get these templates to create an HTML. This process get time.
>2. My proposal: Preprocess templates for some (or all) them. Creating 
>a template without extends or includes. So, in my previous email you can 
>see, Django render less templates, so Django win time.
>
> We can get a backend a  little faster with very little effort.
>
> Best!
>
>  
>
>> On Thu 17 Jan, 2019 2:32 pm J. Pablo Martín Cobos >  wrote:
>>
>>> Hi,
>>>
>>> From one year ago, I am using an own command for Django templates that 
>>> unify them. With an example it is easy to see. If I am to render for 
>>> example a template call news.html like it:
>>>
>>> 1. news.html
>>>
>>> {% extends "base.html" %}
>>>
>>> {% block title %}
>>> {% include "inc.news.title.html" %}
>>> {% endblock %}
>>>
>>> {% block content %}
>>> {% for news_item in news %}
>>> {{ news_item.title }}
>>> {{ news_item.subtitle }}
>>> {% endfor %}
>>> {% endblock %}
>>>
>>> 2. base.html
>>>
>>> >> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>>> http://www.w3.org/1999/xhtml"; lang="{{ 
>>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif 
>>> %}>
>>> 
>>> {% block title %}{% endblock %}
>>> 
>>> 
>>> {% block content %}{% endblock %}
>>> 
>>> 
>>>
>>> 3. inc.news.title.html
>>> News
>>>
>>> With this command I preproces every template of a settings variable and 
>>> I get something like this:
>>>
>>> news.unify.html
>>>
>>> >> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>>> http://www.w3.org/1999/xhtml"; lang="{{ 
>>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif 
>>> %}>
>>> 
>>> News
>>> 
>>> 
>>> {% for news_item in news %}
>>> {{ news_item.title }}
>>> {{ news_item.subtitle }}
>>> {% endfor %}
>>> 
>>> 
>>>
>>> So I have a two improves:
>>>
>>>1. It is more fast. And in a real project a view can render easyly 
>>>50 templates
>>>2. I use news.html to develop and news.unify.html to production. So 
>>>I don't lose legilibility.
>>>
>>>
>>> What do you think about "unify templates feature"? Do you know if exists 
>>> a similar public project in github/gitlab/bitbucket etc?
>>>
>>>
>>> Best,
>>>
>>> -- 
>>> Pablo Martín Cobos
>>> Computer engineer
>>> Python/Django developer
>>> 652 53 37 36
>>> goi...@gmail.com 
>>>
>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Django developers (Contributions to Django itself)" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to django-develop...@googlegroups.com .
>>> To post to this group, send email to django-d...@googlegroups.com 
>>> .
>>> Visit this group at https://groups.google.com/group/django-developers.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/django-developers/CALNyWLGNcuK8DTnU9w9fyGFhFfT3dAz7vfj3B%2BnDHWTfneLNFw%40mail.gmail.com
>>>  
>>> 
>>> .
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to django-develop...@googlegroups.com .
>> To post to this group, send email to django-d...@googlegroups.com 
>> .
>> Visit this group at https://groups.google.com/group/django-developers.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/django-developers/CAMsYeuFV3EV_3H%2BR0q9xi5Q6EQq6L2cLkatcvrTtSYW%3D2zRk7A%40mail.gmail.com
>>  
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
> -- 
> Juan Pablo Martín Cobos
> Ingeniero informático
> Desarrollador Python/Django
> 652 53 37 36all 
> g

Re: What do you think about unify templates feature?

2019-01-18 Thread J . Pablo Martín Cobos
I answer between lines


El vie., 18 ene. 2019 a las 5:03, shiva kumar (<
kannamshivakumar...@gmail.com>) escribió:

> Could you please explain about it. I hadn't understood ur idea.
>


   1. Currently: with you render a view, this render a template. But
   usually, this template extends of another and include others. So Django has
   to get these templates to create an HTML. This process get time.
   2. My proposal: Preprocess templates for some (or all) them. Creating a
   template without extends or includes. So, in my previous email you can see,
   Django render less templates, so Django win time.

We can get a backend a  little faster with very little effort.

Best!



> On Thu 17 Jan, 2019 2:32 pm J. Pablo Martín Cobos 
>> Hi,
>>
>> From one year ago, I am using an own command for Django templates that
>> unify them. With an example it is easy to see. If I am to render for
>> example a template call news.html like it:
>>
>> 1. news.html
>>
>> {% extends "base.html" %}
>>
>> {% block title %}
>> {% include "inc.news.title.html" %}
>> {% endblock %}
>>
>> {% block content %}
>> {% for news_item in news %}
>> {{ news_item.title }}
>> {{ news_item.subtitle }}
>> {% endfor %}
>> {% endblock %}
>>
>> 2. base.html
>>
>> > http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>> http://www.w3.org/1999/xhtml"; lang="{{
>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
>> %}>
>> 
>> {% block title %}{% endblock %}
>> 
>> 
>> {% block content %}{% endblock %}
>> 
>> 
>>
>> 3. inc.news.title.html
>> News
>>
>> With this command I preproces every template of a settings variable and I
>> get something like this:
>>
>> news.unify.html
>>
>> > http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>> http://www.w3.org/1999/xhtml"; lang="{{
>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
>> %}>
>> 
>> News
>> 
>> 
>> {% for news_item in news %}
>> {{ news_item.title }}
>> {{ news_item.subtitle }}
>> {% endfor %}
>> 
>> 
>>
>> So I have a two improves:
>>
>>1. It is more fast. And in a real project a view can render easyly 50
>>templates
>>2. I use news.html to develop and news.unify.html to production. So I
>>don't lose legilibility.
>>
>>
>> What do you think about "unify templates feature"? Do you know if exists
>> a similar public project in github/gitlab/bitbucket etc?
>>
>>
>> Best,
>>
>> --
>> Pablo Martín Cobos
>> Computer engineer
>> Python/Django developer
>> 652 53 37 36
>> goi...@gmail.com
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to django-developers+unsubscr...@googlegroups.com.
>> To post to this group, send email to django-developers@googlegroups.com.
>> Visit this group at https://groups.google.com/group/django-developers.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/django-developers/CALNyWLGNcuK8DTnU9w9fyGFhFfT3dAz7vfj3B%2BnDHWTfneLNFw%40mail.gmail.com
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/CAMsYeuFV3EV_3H%2BR0q9xi5Q6EQq6L2cLkatcvrTtSYW%3D2zRk7A%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Juan Pablo Martín Cobos
Ingeniero informático
Desarrollador Python/Django
652 53 37 36all  <652%2053%2037%2036>
goi...@gmail.com

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion 

Re: What do you think about unify templates feature?

2019-01-18 Thread J . Pablo Martín Cobos
I answer between lines

El jue., 17 ene. 2019 a las 18:42, Maciek Olko ()
escribió:

> Did you try to measure the difference in time of rendering standard and
> your way?
>
>
Yes. I have several examples:

App Template Num templates rendered before unify Num templates rendered
after unify Time render template before unify (ms) Time render template
after unify (ms) Improve
Django admin admin/index.html 3 1 75 - 110 71 - 79 22%
Django admin admin/change_list.html 26 Command error 180-300 Command error
Django admin admin/change_form.html 16 Command error 350-400 Command error
Django constance admin/constance/change_list.html 7 1 350-400 150-250 75%
Django su su/login.html 5 3 15- 20 10 - 12 54%

My command currently does not work with several complex templates like
admin/change_list.html or admin/change_form.html But we can improve it,
currently it works with almost all.

If there is a nice improve with views that render few templates... imagine
with views with a lot of templates.

I have measure these times with django-debug-toolbar-template-timings

With this email only I want to know if you see it can be a important
feature to add to Django framework... or it is a silly thing.

Best,



> Regards,
> Maciej
>
> czw., 17.01.2019, 10:02 użytkownik J. Pablo Martín Cobos 
> napisał:
>
>> Hi,
>>
>> From one year ago, I am using an own command for Django templates that
>> unify them. With an example it is easy to see. If I am to render for
>> example a template call news.html like it:
>>
>> 1. news.html
>>
>> {% extends "base.html" %}
>>
>> {% block title %}
>> {% include "inc.news.title.html" %}
>> {% endblock %}
>>
>> {% block content %}
>> {% for news_item in news %}
>> {{ news_item.title }}
>> {{ news_item.subtitle }}
>> {% endfor %}
>> {% endblock %}
>>
>> 2. base.html
>>
>> > http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>> http://www.w3.org/1999/xhtml"; lang="{{
>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
>> %}>
>> 
>> {% block title %}{% endblock %}
>> 
>> 
>> {% block content %}{% endblock %}
>> 
>> 
>>
>> 3. inc.news.title.html
>> News
>>
>> With this command I preproces every template of a settings variable and I
>> get something like this:
>>
>> news.unify.html
>>
>> > http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
>> http://www.w3.org/1999/xhtml"; lang="{{
>> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
>> %}>
>> 
>> News
>> 
>> 
>> {% for news_item in news %}
>> {{ news_item.title }}
>> {{ news_item.subtitle }}
>> {% endfor %}
>> 
>> 
>>
>> So I have a two improves:
>>
>>1. It is more fast. And in a real project a view can render easyly 50
>>templates
>>2. I use news.html to develop and news.unify.html to production. So I
>>don't lose legilibility.
>>
>>
>> What do you think about "unify templates feature"? Do you know if exists
>> a similar public project in github/gitlab/bitbucket etc?
>>
>>
>> Best,
>>
>> --
>> Pablo Martín Cobos
>> Computer engineer
>> Python/Django developer
>> 652 53 37 36
>> goi...@gmail.com
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to django-developers+unsubscr...@googlegroups.com.
>> To post to this group, send email to django-developers@googlegroups.com.
>> Visit this group at https://groups.google.com/group/django-developers.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/django-developers/CALNyWLGNcuK8DTnU9w9fyGFhFfT3dAz7vfj3B%2BnDHWTfneLNFw%40mail.gmail.com
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/CALYYG805GZFJL5b_9nortw8Sj%2Bkrx1p4xqki7C96Zd8vHeYsmw%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Pablo Mart

Re: What do you think about unify templates feature?

2019-01-17 Thread shiva kumar
Could you please explain about it. I hadn't understood ur idea.

On Thu 17 Jan, 2019 2:32 pm J. Pablo Martín Cobos  Hi,
>
> From one year ago, I am using an own command for Django templates that
> unify them. With an example it is easy to see. If I am to render for
> example a template call news.html like it:
>
> 1. news.html
>
> {% extends "base.html" %}
>
> {% block title %}
> {% include "inc.news.title.html" %}
> {% endblock %}
>
> {% block content %}
> {% for news_item in news %}
> {{ news_item.title }}
> {{ news_item.subtitle }}
> {% endfor %}
> {% endblock %}
>
> 2. base.html
>
>  http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
> http://www.w3.org/1999/xhtml"; lang="{{
> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
> %}>
> 
> {% block title %}{% endblock %}
> 
> 
> {% block content %}{% endblock %}
> 
> 
>
> 3. inc.news.title.html
> News
>
> With this command I preproces every template of a settings variable and I
> get something like this:
>
> news.unify.html
>
>  http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
> http://www.w3.org/1999/xhtml"; lang="{{
> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
> %}>
> 
> News
> 
> 
> {% for news_item in news %}
> {{ news_item.title }}
> {{ news_item.subtitle }}
> {% endfor %}
> 
> 
>
> So I have a two improves:
>
>1. It is more fast. And in a real project a view can render easyly 50
>templates
>2. I use news.html to develop and news.unify.html to production. So I
>don't lose legilibility.
>
>
> What do you think about "unify templates feature"? Do you know if exists a
> similar public project in github/gitlab/bitbucket etc?
>
>
> Best,
>
> --
> Pablo Martín Cobos
> Computer engineer
> Python/Django developer
> 652 53 37 36
> goi...@gmail.com
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/CALNyWLGNcuK8DTnU9w9fyGFhFfT3dAz7vfj3B%2BnDHWTfneLNFw%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMsYeuFV3EV_3H%2BR0q9xi5Q6EQq6L2cLkatcvrTtSYW%3D2zRk7A%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: What do you think about unify templates feature?

2019-01-17 Thread Maciek Olko
Did you try to measure the difference in time of rendering standard and
your way?

Regards,
Maciej

czw., 17.01.2019, 10:02 użytkownik J. Pablo Martín Cobos 
napisał:

> Hi,
>
> From one year ago, I am using an own command for Django templates that
> unify them. With an example it is easy to see. If I am to render for
> example a template call news.html like it:
>
> 1. news.html
>
> {% extends "base.html" %}
>
> {% block title %}
> {% include "inc.news.title.html" %}
> {% endblock %}
>
> {% block content %}
> {% for news_item in news %}
> {{ news_item.title }}
> {{ news_item.subtitle }}
> {% endfor %}
> {% endblock %}
>
> 2. base.html
>
>  http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
> http://www.w3.org/1999/xhtml"; lang="{{
> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
> %}>
> 
> {% block title %}{% endblock %}
> 
> 
> {% block content %}{% endblock %}
> 
> 
>
> 3. inc.news.title.html
> News
>
> With this command I preproces every template of a settings variable and I
> get something like this:
>
> news.unify.html
>
>  http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
> http://www.w3.org/1999/xhtml"; lang="{{
> LANGUAGE_CODE|default:"en-us" }}" {% if LANGUAGE_BIDI %}dir="rtl"{% endif
> %}>
> 
> News
> 
> 
> {% for news_item in news %}
> {{ news_item.title }}
> {{ news_item.subtitle }}
> {% endfor %}
> 
> 
>
> So I have a two improves:
>
>1. It is more fast. And in a real project a view can render easyly 50
>templates
>2. I use news.html to develop and news.unify.html to production. So I
>don't lose legilibility.
>
>
> What do you think about "unify templates feature"? Do you know if exists a
> similar public project in github/gitlab/bitbucket etc?
>
>
> Best,
>
> --
> Pablo Martín Cobos
> Computer engineer
> Python/Django developer
> 652 53 37 36
> goi...@gmail.com
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/CALNyWLGNcuK8DTnU9w9fyGFhFfT3dAz7vfj3B%2BnDHWTfneLNFw%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CALYYG805GZFJL5b_9nortw8Sj%2Bkrx1p4xqki7C96Zd8vHeYsmw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.