Re: [Django] #19665: 'Command' object has no attribute 'stderr'

[Django]

#19665: 'Command' object has no attribute 'stderr'
-+-
 Reporter:  stefankoegl  |Owner:  claudep
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 Mike, my guess is that your command overrode the `__init__` method of the
 command without calling the super `__init__`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.7888b6492896bcc3e5173b445feec3f9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by jdufresne):

 * needs_better_patch:  1 => 0


Comment:

 > I've left some comments for improvement on the pull request.

 I have addressed all comments in the PR. All additional feedback is
 welcome. Thanks.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.c7d94d012e64231d08c3d1ba456409aa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26525: Tutorial02 document issue

[Django]

#26525: Tutorial02 document issue
---+
 Reporter:  edwardspbe |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Documentation  |Version:  1.9
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  1  |  UI/UX:  0
---+
 I believe there is an issue with
 [https://docs.djangoproject.com/en/1.9/intro/tutorial02/#activating-models
 Writing your first Django app, part 2].  The directions for adding
 ''polls'' is incorrect.

 {{{

 Edit the mysite/settings.py file again, and change the INSTALLED_APPS
 setting to include the string polls.apps.PollsConfig. It’ll look like
 this:

 mysite/settings.py
 INSTALLED_APPS = [
 'polls.apps.PollsConfig',
 }}}


 This should read;

 {{{

 Edit the mysite/settings.py file again, and change the INSTALLED_APPS
 setting to include the string polls. It’ll look like this:

 mysite/settings.py
 INSTALLED_APPS = [
 'polls',
 }}}

 If not, the following instructions to execute;

 {{{
  python manage.py makemigrations polls
 }}}
 will fail with the error

 {{{
 ImportError: No module named apps
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.dd925275e7ff4e09b5adcea971499040%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26524: Django Admin list_display - Unable to display foreign key id

[Django]

#26524: Django Admin list_display - Unable to display foreign key id
---+---
 Reporter:  cristianocca   |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  contrib.admin  |Version:  1.9
 Severity:  Normal |   Keywords:  admin list_display changelist
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+---
 Given these two models.


 {{{
 class A(models.Model):
 name = models.CharField(max_length=100)

 def __unicode__(self):
 return self.name

 class B(models.Model):
 name = models.CharField(max_length=100)
 fk = models.ForeignKey(A)

 def __unicode__(self):
 return self.name
 }}}

 And these model admin


 {{{
 class AAdmin(admin.ModelAdmin):
 list_display = ('id','name')
 admin.site.register(A, AAdmin)

 class BAdmin(admin.ModelAdmin):
 list_display = ('id','name','fk_id','fk')
 admin.site.register(B, BAdmin)
 }}}

 As you see, for BAdmin I'm trying to display the actual id of the foreign
 key, so I prevent an additional unwanted join (or worse, one query per
 related object if no select related is added). However, the admin page
 refuses to display the id and instead renders the whole object (calling
 the __unicode__ method) which causes the additional join I don't want.
 In order to demostrate it I also added the 'fk' relation which works as
 expected

 The change list result is then


 {{{
 1   test B  test A  test A
 }}}

 where it should be

 {{{
 1   test B  1   test A
 }}}


 In order to work around it, I can define a callable that just returns the
 id property, but that's terrible because I lose any sort option on it plus
 I need to write quite a few more lines.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/055.17dfa47b739060b687961ed0cda5ee2f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26504: Prevent logging warnings for page "Not Found" before redirect to language-prefixed page

[Django]

#26504: Prevent logging warnings for page "Not Found" before redirect to 
language-
prefixed page
-+-
 Reporter:  cworth-gh|Owner:  Tim
 Type:   |  Graham 
  Cleanup/optimization   |   Status:  closed
Component:  Error reporting  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * owner:   => Tim Graham 
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"40b69607c751c4afa453edfd41d2ed155e58187e" 40b69607]:
 {{{
 #!CommitTicketReference repository=""
 revision="40b69607c751c4afa453edfd41d2ed155e58187e"
 Fixed #26504 -- Avoided logging "Not Found" warnings if a middleware
 handles the 404.

 For example, this avoids a warning in the case of a request that's
 redirected to a language-prefixed URL by LocaleMiddleware.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8db01ca5adbca5b6659b95bc0df3e4cb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19665: 'Command' object has no attribute 'stderr'

[Django]

#19665: 'Command' object has no attribute 'stderr'
-+-
 Reporter:  stefankoegl  |Owner:  claudep
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Rather than reopening a 3 year old ticket, please open a new one and
 include a test case for Django's test suite or a sample project to
 reproduce the issue. Thanks!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.0da0372d2a3c60aac1f3762e515cf995%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26425: SubfieldBase deprecation warning may appear as coming from six

[Django]

#26425: SubfieldBase deprecation warning may appear as coming from six
-+-
 Reporter:  mvanderlinde |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Utilities|  Version:  1.9
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
  runserver,SubfieldBase,RemovedInDjango110Warning|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Feel free to reopen if you want to propose a patch.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.b2e7f442e36f5035c30847c7ddc473bb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26281: Improve utils.formats.date_format() error message when using time formatting with datetime.date

[Django]

#26281: Improve utils.formats.date_format() error message when using time
formatting with datetime.date
--+
 Reporter:  flesser   |Owner:  benxy
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Utilities |  Version:  1.9
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"45c7acdc507d26451f3c3f22b5d60bdd6d572cfc" 45c7acdc]:
 {{{
 #!CommitTicketReference repository=""
 revision="45c7acdc507d26451f3c3f22b5d60bdd6d572cfc"
 Fixed #26281 -- Added a helpful error message for an invalid format
 specifier to dateformat.format().
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.05a6eca21e065fb488bbcd81453bd63a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19665: 'Command' object has no attribute 'stderr'

[Django]

#19665: 'Command' object has no attribute 'stderr'
-+-
 Reporter:  stefankoegl  |Owner:  claudep
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by mikepelley):

 * cc: mike@… (added)
 * status:  closed => new
 * resolution:  fixed =>


Comment:

 I believe I'm having this same problem again with 1.9.5 (see below). I
 took a brief look at the code and perhaps the fix for #23663 reverted the
 fix for this bug, although my review was superficial so I might have that
 wrong. In the error below, I raised the CommandError exception explicitly
 after discovering a data validation error.

 (virtualenv3) mike@rhea:~/Workspace/auris-server/auris$ ./manage.py
 load_systems ../populated.json
 Traceback (most recent call last):
   File "/home/mike/Workspace/virtualenv3/lib/python3.4/site-
 packages/django/core/management/base.py", line 348, in run_from_argv
 self.execute(*args, **cmd_options)
   File "/home/mike/Workspace/virtualenv3/lib/python3.4/site-
 packages/django/core/management/base.py", line 399, in execute
 output = self.handle(*args, **options)
   File "/home/mike/Workspace/auris-
 server/auris/db/management/commands/load_systems.py", line 44, in handle
 self._validate_fields()
   File "/home/mike/Workspace/auris-
 server/auris/db/management/commands/load_systems.py", line 24, in
 _validate_fields
 '{2})'.format(field, data['name'], system_id))
 django.core.management.base.CommandError: Unknown field "alignment"
 present in system id 1

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File "./manage.py", line 10, in 
 execute_from_command_line(sys.argv)
   File "/home/mike/Workspace/virtualenv3/lib/python3.4/site-
 packages/django/core/management/__init__.py", line 353, in
 execute_from_command_line
 utility.execute()
   File "/home/mike/Workspace/virtualenv3/lib/python3.4/site-
 packages/django/core/management/__init__.py", line 345, in execute
 self.fetch_command(subcommand).run_from_argv(self.argv)
   File "/home/mike/Workspace/virtualenv3/lib/python3.4/site-
 packages/django/core/management/base.py", line 357, in run_from_argv
 self.stderr.write('%s: %s' % (e.__class__.__name__, e))
 AttributeError: 'Command' object has no attribute 'stderr'

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.d1ece9dee29594b7f599e8daf3a798f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17209: Dogfood class-based views in contrib.auth

[Django]

#17209: Dogfood class-based views in contrib.auth
-+-
 Reporter:  melinath |Owner:  auvipy
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  class-based views| Triage Stage:  Accepted
  admin auth |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 If you think you'll be able to work on it before the feature freeze (Mai
 16th), then fine. If not, then simply deassign yourself.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.76e9762f33cd2f6f511c2854ea68cfdb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26522: Bug in django.db.models.sql.Query.combine

[Django]

#26522: Bug in django.db.models.sql.Query.combine
-+-
 Reporter:  OleLaursen   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 Could you [https://docs.djangoproject.com/en/dev/internals/contributing
 /triaging-tickets/#bisecting-a-regression bisect the regression]? If you
 can provide the test app that you use for that process, it'll be helpful.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.34f1181ef2e02cf45b5f3763739410fa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26520: SessionBase.pop() no longer raises a KeyError

[Django]

#26520: SessionBase.pop() no longer raises a KeyError
-+-
 Reporter:  tuky |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.sessions |  Version:  1.9
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"845d43e37ed0086baa55ba791a5d386da54e943b" 845d43e3]:
 {{{
 #!CommitTicketReference repository=""
 revision="845d43e37ed0086baa55ba791a5d386da54e943b"
 [1.9.x] Fixed #26520 -- Fixed a regression where SessionBase.pop() didn't
 return a KeyError.

 Backport of b040ac06ebba2348cece7390b88f746d2c91d07b from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.fb340c060fdbb54a4c34b842fc50117e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26520: SessionBase.pop() no longer raises a KeyError

[Django]

#26520: SessionBase.pop() no longer raises a KeyError
-+-
 Reporter:  tuky |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.sessions |  Version:  1.9
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b040ac06ebba2348cece7390b88f746d2c91d07b" b040ac06]:
 {{{
 #!CommitTicketReference repository=""
 revision="b040ac06ebba2348cece7390b88f746d2c91d07b"
 Fixed #26520 -- Fixed a regression where SessionBase.pop() didn't return a
 KeyError.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.2a83a209b92796ac3483e2ad833c9c46%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24621: request.session.pop's second param is not documented

[Django]

#24621: request.session.pop's second param is not documented
---+
 Reporter:  gabor  |Owner:  adamzap
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  1.8
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"ebb55a247c0f060f3e2cf0e363137106385bda0f" ebb55a24]:
 {{{
 #!CommitTicketReference repository=""
 revision="ebb55a247c0f060f3e2cf0e363137106385bda0f"
 [1.9.x] Refs #24621 -- Added a test for SessionBase.pop()'s 'default'
 argument.

 Backport of 973f393761253f5fbf031f435d103545f1927041 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.2b6d0b59648a4509e9878af8eecf0402%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24621: request.session.pop's second param is not documented

[Django]

#24621: request.session.pop's second param is not documented
---+
 Reporter:  gabor  |Owner:  adamzap
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  1.8
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"973f393761253f5fbf031f435d103545f1927041" 973f3937]:
 {{{
 #!CommitTicketReference repository=""
 revision="973f393761253f5fbf031f435d103545f1927041"
 Refs #24621 -- Added a test for SessionBase.pop()'s 'default' argument.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.3f06fb39bdaaf710ea2f1696d11b513b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26520: SessionBase.pop() no longer raises a KeyError

[Django]

#26520: SessionBase.pop() no longer raises a KeyError
-+-
 Reporter:  tuky |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.sessions |  Version:  1.9
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


Old description:

> The fix of https://code.djangoproject.com/ticket/24621 led to always
> providing a default to session's dict method pop. This prevents a
> KeyError to ever be thrown, which should be expected by a pop-function.
>
> Pull request is https://github.com/django/django/pull/6480

New description:

 The fix of #24621 led to always providing a `default` to session's dict's
 `pop()` method. This prevents a `KeyError` from ever being raised, which
 should be expected by a pop-function.

 Pull request is https://github.com/django/django/pull/6480

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.027dd0aa3d9f95311e876f2df7ae4d91%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #15250: Cannot fill parent model instance in cache

[Django]

#15250: Cannot fill parent model instance in cache
-+-
 Reporter:  vzima|Owner:
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 I closed #26523 as a duplicate (but it should be confirmed when solving
 this ticket).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.7faa1e62913e13fab832d325ee62e206%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26523: Unable to select_related() an implicit one to one relationship in multi-table inheritance (was: Unable to prefetch the implicit one to one relationship)

[Django]

#26523: Unable to select_related() an implicit one to one relationship in multi-
table inheritance
-+-
 Reporter:  czpython |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0
 * resolution:   => duplicate


Comment:

 I think it's a duplicate of #15250.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.37d65970afc0f9f78620a5133a8b702a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26424: Allow URLValidator to skip schemes validation

[Django]

#26424: Allow URLValidator to skip schemes validation
--+
 Reporter:  timgraham |Owner:  burhan
 Type:  New feature   |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by burhan):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.469f9a0d6b9bb9c5d8e106e44aeb8108%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26511: Django 1.9 and Postgres 9.4 jsonb string containment inside JSONField

[Django]

#26511: Django 1.9 and Postgres 9.4 jsonb string containment inside JSONField
--+
 Reporter:  eoinmurray|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  postgres, jsonb   | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by timgraham):

 You can probably copy the `Cast` function from Django master
 (03b6947728466e4e907487f30dd4dfec94a8eb2f) into your project.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.7aa3de8142bddea3f3c0210ae17cb378%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26425: SubfieldBase deprecation warning may appear as coming from six (was: django/utils/six.py generates a RemovedInDjango110Warning)

[Django]

#26425: SubfieldBase deprecation warning may appear as coming from six
-+-
 Reporter:  mvanderlinde |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Utilities|  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  runserver,SubfieldBase,RemovedInDjango110Warning|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * type:  Bug => Cleanup/optimization
 * easy:  1 => 0


Comment:

 I don't think it's worth spending any time on this issue given grep should
 be a simple solution.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.811427f661324a5481fb7256d719a6bc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26425: django/utils/six.py generates a RemovedInDjango110Warning

[Django]

#26425: django/utils/six.py generates a RemovedInDjango110Warning
-+-
 Reporter:  mvanderlinde |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Utilities|  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  runserver,SubfieldBase,RemovedInDjango110Warning|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by davidszotten):

 * status:  closed => new
 * resolution:  invalid =>


Comment:

 seeing this from a few different 3rd party packages. if they are using
 six.with_metaclass, the otherwise helpful indication of what caused there
 warning is pretty useless

 i guess it's possible to try to detect six, though an easier workaround
 might be to bump the stacklevel, and err on the side of going too far,
 which might at least find an import statement indicating where to look

 thoughts?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.b5e949ab73928faaa47c435ccb891e97%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26523: Unable to prefetch the implicit one to one relationship

[Django]

#26523: Unable to prefetch the implicit one to one relationship
--+
 Reporter:  czpython  |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Database layer (models, ORM)  |Version:  1.8
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 Given the following models:


 {{{
 class Fruit(models.Model):
 weight = models.PositiveIntegerField(default=100)


 class Apple(Fruit):
 farmer = models.CharField(max_length=200, blank=True)


 class Kiwi(models.Model):
 fruit = models.OneToOneField(Fruit)
 farmer = models.CharField(max_length=200, blank=True)
 }}}

 I would like to prefetch the fruit object related to an apple or kiwi.

 So I ran the following:


 {{{
 In [2]: kiwi = Kiwi.objects.select_related('fruit').latest('id')
 QUERY = u'SELECT "fruits_kiwi"."id", "fruits_kiwi"."fruit_id",
 "fruits_kiwi"."farmer", "fruits_fruit"."id", "fruits_fruit"."weight" FROM
 "fruits_kiwi" INNER JOIN "fruits_fruit" ON ( "fruits_kiwi"."fruit_id" =
 "fruits_fruit"."id" ) ORDER BY "fruits_kiwi"."id" DESC LIMIT 1' - PARAMS =
 () [0.84ms]

 In [3]: kiwi.fruit
 Out[3]: 
 }}}

 As you can see, calling kiwi.fruit does not result in any extra queries.

 Now I tried with Apple:


 {{{
 In [4]: apple = Apple.objects.select_related('fruit_ptr').latest('id')
 QUERY = u'SELECT "fruits_fruit"."id", "fruits_fruit"."weight",
 "fruits_apple"."fruit_ptr_id", "fruits_apple"."farmer" FROM "fruits_apple"
 INNER JOIN "fruits_fruit" ON ( "fruits_apple"."fruit_ptr_id" =
 "fruits_fruit"."id" ) ORDER BY "fruits_apple"."fruit_ptr_id" DESC LIMIT 1'
 - PARAMS = () [0.31ms]

 In [5]: apple.fruit_ptr
 QUERY = u'SELECT "fruits_fruit"."id", "fruits_fruit"."weight" FROM
 "fruits_fruit" WHERE "fruits_fruit"."id" = %s' - PARAMS = (16,) [0.35ms]
 Out[5]: 
 }}}

 Calling apple.fruit_ptr results in a query to the database even though
 it's set to prefetch the related fruit.

 I've traced the bug to
 
https://github.com/django/django/blob/stable/1.8.x/django/db/models/query_utils.py#L186

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.a0c46c16f906c9048732efcece93ffae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26522: Bug in django.db.models.sql.Query.combine

[Django]

#26522: Bug in django.db.models.sql.Query.combine
-+-
 Reporter:  OleLaursen   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by OleLaursen):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Oh, I forgot to mention - it crashes on the very last line {{{
 filtered_invoices |= qs }}} in the above with r = 2. So after having
 constructed a pretty complicated thing.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b7ff7eb088b519a690d6dbc6de1e91d7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16327: "save as new" redirects to list view instead of newly-created item

[Django]

#16327: "save as new" redirects to list view instead of newly-created item
---+---
 Reporter:  candlerb   |Owner:  giuliettamasina
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  1.3
 Severity:  Normal |   Resolution:  fixed
 Keywords:  saveasnew  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"08cd6a0e56bac04e322388e7059072ad98db303c" 08cd6a0]:
 {{{
 #!CommitTicketReference repository=""
 revision="08cd6a0e56bac04e322388e7059072ad98db303c"
 Fixed #16327 -- Redirected "Save as new" to change view instead of the
 changelist.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.541a835225353ba31bf790abe4a0887c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26522: Bug in django.db.models.sql.Query.combine

[Django]

#26522: Bug in django.db.models.sql.Query.combine
--+
 Reporter:  OleLaursen|  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Database layer (models, ORM)  |Version:  1.9
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 Hi,

 There's a logical error somewhere in Query.combine or friends.

 I have a pretty complicated query with many-to-many self-joins and ORs,
 and after the upgrade to Django 1.9 and Python 3 combine() sometimes, but
 not always, crashes with the assertion error
 {{{
 assert set(change_map.keys()).intersection(set(change_map.values())) ==
 set()
 }}}

 Inspecting the change_map, it does indeed contain a circular reference
 (BTW shouldn't you use "not" to test for an empty set rather than
 comparing with set()?).

 At first, I didn't understand how it could crash sometimes and sometimes
 not - we're talking about the same query being executed through a view.
 But when I examine change_map, its content does indeed change from reload
 to reload - I suppose this may have something to do with the order of
 dicts/sets the combine() algorithm is using.

 Here comes some code, I cut out a bunch of unused stuff, but otherwise
 it's the same:

 {{{
 class Invoice(models.Model):
 customer = models.ForeignKey(Customer)

 date_created = models.DateField(default=datetime.date.today,
 db_index=True)
 date_sent = models.DateField(null=True, blank=True)
 date_due = models.DateField(null=True, blank=True)
 date_paid = models.DateField(null=True, blank=True)
 date_credited = models.DateField(null=True, blank=True)
 date_collect = models.DateField(null=True, blank=True)

 invoice_type = models.CharField(default="invoice", max_length=32)

 reminders = models.ManyToManyField("Invoice",
 related_name="reminded_set", blank=True)
 reminder_counter = models.IntegerField(null=True, blank=True)
 }}}

 That's the model, and in the view:

 {{{
 import datetime
 from django.db.models import Q

 date = datetime.datetime.now()

 invoices = Invoice.objects.filter(
 Q(date_created__lte=date),
 Q(date_paid__gt=date) | Q(date_paid=None),
 Q(date_credited__gt=date) | Q(date_credited=None),
 customer=1,
 )

 filtered_invoices = Invoice.objects.none()

 not_due = Q(date_due__gte=date) | Q(date_due=None)
 not_reminded_yet = ~Q(reminders__date_created__lte=date)
 not_collected = Q(date_collect__gt=date) | Q(date_collect=None)

 filtered_invoices |= invoices.filter(not_due, not_collected,
 date_sent__lte=date, invoice_type="invoice")

 filtered_invoices |= invoices.filter(not_collected, not_reminded_yet,
 date_sent__lte=date, date_due__lt=date, invoice_type="invoice")

 for r in [1, 2, 3]:
 qs = invoices.filter(not_collected,
 reminders__date_created__lte=date, reminders__reminder_counter=r,
 invoice_type="invoice")
 for i in range(r + 1, 3 + 1):
 qs = qs.filter(~Q(reminders__reminder_counter=i) |
 Q(reminders__reminder_counter=i, reminders__date_created__gt=date))
 filtered_invoices |= qs
 }}}

 I realize it's pretty complicated but I'm not sure what's essential and
 what's not. I hope someone knowledgeable of how combine() works can figure
 out why ordering in some cases matters.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.e26f982bf27f4f832b4918a50d863d01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26511: Django 1.9 and Postgres 9.4 jsonb string containment inside JSONField

[Django]

#26511: Django 1.9 and Postgres 9.4 jsonb string containment inside JSONField
--+
 Reporter:  eoinmurray|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  postgres, jsonb   | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by eoinmurray):

 Is there any way to do this in Django <=1.9.5?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.3d67e5b388935d232d93b16734ec71c9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26521: CreateModel allows duplicate field names

[Django]

#26521: CreateModel allows duplicate field names
--+
 Reporter:  w0rp  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * type:  Uncategorized => Cleanup/optimization
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Probably wouldn't hurt.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.878e84eb55b0cb614a407e63da2975e1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26521: CreateModel allows duplicate field names

[Django]

#26521: CreateModel allows duplicate field names
---+
 Reporter:  w0rp   |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Migrations |Version:  1.9
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 I hit this bug while manually editing a migration file after squashing
 files. If you define the same field twice in a list of fields for
 CreateModel, then migrate will take the second field definition without
 reporting any errors.

 {{{#!python
 class Migration(migrations.Migration):
 operations = [
 migrations.CreateModel(
 name='Foo',
 fields=[
 ('id', models.AutoField(verbose_name='ID',
 serialize=False, auto_created=True, primary_key=True)),
 ('created', models.DateTimeField(auto_now_add=True,
 db_index=True)),
 # This one will be used.
 ('created', models.DateField(auto_now_add=True,
 db_index=True)),
 ],
 ),
 ]
 }}}

 I think the migration code should check for duplicate fields, and then
 report an error if you have mistakenly defined the same field twice for
 the fields array.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.de9e697d492df317051b81420f6af80a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26520: SessionBase.pop() no longer raises a KeyError

[Django]

#26520: SessionBase.pop() no longer raises a KeyError
--+
 Reporter:  tuky  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sessions  |  Version:  1.9
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+

Comment (by tuky):

 I already changed my pull request to reflect timgraham's idea.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a99c2b14cdd20ca3a31a1524e2325f16%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26520: SessionBase.pop() no longer raises a KeyError

[Django]

#26520: SessionBase.pop() no longer raises a KeyError
--+
 Reporter:  tuky  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sessions  |  Version:  1.9
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+

Comment (by niconoe):

 I am currently trying timgraham's suggested implementation, and it seems
 to work well for all those cases:


 {{{#!python
 (Pdb) session.pop('machin')
 *** KeyError: 'machin'
 (Pdb) session.pop('machin', 'truc')
 'truc'
 (Pdb) session.pop('machin', default='truc')
 'truc'
 }}}

 Should I make a pull request with this?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.eafcf10263a978ae8dc5fbb0f83c77a0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26520: SessionBase.pop() no longer raises a KeyError

[Django]

#26520: SessionBase.pop() no longer raises a KeyError
--+
 Reporter:  tuky  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sessions  |  Version:  1.9
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+

Comment (by tuky):

 Maybe, Django users out there are already using the named argument
 `default`, so it would be bad to remove it again. Although the solution is
 more complex in code, it seems more explicit for documentation and code
 introspection. Either way, I am happy, that it will raise a `KeyError`
 again.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.9b20ea79225bd59a9ae34b1e3ec96c2f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17209: Dogfood class-based views in contrib.auth

[Django]

#17209: Dogfood class-based views in contrib.auth
-+-
 Reporter:  melinath |Owner:  auvipy
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  class-based views| Triage Stage:  Accepted
  admin auth |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by auvipy):

 Replying to [comment:29 claudep]:
 > auvipy, still working on this?
  If you are willing to take it over for your personal sprint then OK but
 if not then I would be happy to start work on it. been busy with other
 projects.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1930f65619bca375f8658a059ff385f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26520: SessionBase.pop() no longer raises a KeyError (was: Undo #24621 to make session.pop raise a KeyError again)

[Django]

#26520: SessionBase.pop() no longer raises a KeyError
--+
 Reporter:  tuky  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sessions  |  Version:  1.9
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * stage:  Unreviewed => Accepted
 * severity:  Normal => Release blocker


Comment:

 How about using a pattern borrowed from cpython?
 {{{ #!python
 __marker = object()

 def pop(self, key, default=__marker):
 self.modified = self.modified or key in self._session
 args = () if default is self.__marker else (default,)
 return self._session.pop(key, *args)
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.cdc6c6c1568613a497a0de0c4cfe2cd8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26519: Support for Normalisation for Django Passwords

[Django]

#26519: Support for Normalisation for Django Passwords
---+--
 Reporter:  Arun   |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:  invalid
 Keywords:  Normalisation  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Yes, this isn't the correct place for usage questions, even if you don't
 get an answer on the [https://groups.google.com/d/topic/django-
 users/Q0WDYqJsBsY/discussion django-users thread].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.4e8dfd72260640b0c168387b4d35873a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26519: Support for Normalisation for Django Passwords

[Django]

#26519: Support for Normalisation for Django Passwords
---+--
 Reporter:  Arun   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:
 Keywords:  Normalisation  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by rleir):

 It looks as if you also asked this question on the Users mailing list.
 Depending on the discussion there, you could bring it up in the Dev
 mailing list. Could I suggest you remove this issue until there has been
 some discussion there? When you get a moment, thanks!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.795ca734f0be7fddbf81d05eaf8bba6a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26519: Support for Normalisation for Django Passwords

[Django]

#26519: Support for Normalisation for Django Passwords
---+--
 Reporter:  Arun   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:
 Keywords:  Normalisation  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by rleir):

 And this discussion
 http://stackoverflow.com/questions/2798794/how-do-i-properly-implement-
 unicode-passwords

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.3dad61516b6957d1227c80f1748a5570%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26519: Support for Normalisation for Django Passwords

[Django]

#26519: Support for Normalisation for Django Passwords
---+--
 Reporter:  Arun   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:
 Keywords:  Normalisation  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by niconoe):

 * cc: nicolas@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.d64bb0be7196c7b31e46c32660b328a0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26519: Support for Normalisation for Django Passwords

[Django]

#26519: Support for Normalisation for Django Passwords
---+--
 Reporter:  Arun   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  contrib.auth   |  Version:  1.9
 Severity:  Normal |   Resolution:
 Keywords:  Normalisation  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by niconoe):

 Just for clarification, are you  talking about normalization regarding
 i18n and Unicode issues, such as discussed at
 http://stackoverflow.com/questions/16173328/what-unicode-normalization-
 and-other-processing-is-appropriate-for-passwords-w ?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.dffcef2c8a29565823cad1802bda7129%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26520: Undo #24621 to make session.pop raise a KeyError again

[Django]

#26520: Undo #24621 to make session.pop raise a KeyError again
--+--
 Reporter:  tuky  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sessions  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by niconoe):

 `dict.pop` raise KeyError if the key is not found AND there's no default
 provided as second argument... Won't implementing the same in
 `session.pop` reconcile this ticket and
 https://code.djangoproject.com/ticket/24621 ?

 Example:


 {{{
 >>> {}.pop('machin')
 Traceback (most recent call last):
   File "", line 1, in 
 KeyError: 'machin'
 >>> {}.pop('machin', 'truc')
 'truc'
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.20df4e5fe444d61d26b7a1fb22086933%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26520: Undo #24621 to make session.pop raise a KeyError again

[Django]

#26520: Undo #24621 to make session.pop raise a KeyError again
--+--
 Reporter:  tuky  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sessions  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by tuky):

 Thanks for your feedback. Do you just propose to further change the docs
 or also even the code? I think the `session.pop` wrapper should have a
 signature as close to the original `dict.pop` as possible:

 {{{
 >>> {}.pop("key", default="fallback")
 Traceback (most recent call last):
   File "", line 2, in 
 {}.pop("key", default="fallback")
 TypeError: pop() takes no keyword arguments
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.b5d7ed9e1fb217f59c09dabef9bb7130%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26520: Undo #24621 to make session.pop raise a KeyError again

[Django]

#26520: Undo #24621 to make session.pop raise a KeyError again
--+--
 Reporter:  tuky  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sessions  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by MarkusH):

 While I agree that `.pop()` should raise a `KeyError` on a missing key I
 don't think reverting that particular commit is the solution. We should
 rather fix the underlying bug than what covers it up.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.37c3c4916cbfcfb58b1c4f19256f0123%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26520: Undo #24621 to make session.pop raise a KeyError again

[Django]

#26520: Undo #24621 to make session.pop raise a KeyError again
--+--
 Reporter:  tuky  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sessions  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--
Description changed by tuky:

Old description:

> The fix of https://code.djangoproject.com/ticket/24621 led to always
> providing a default to session's dict method pop. This prevents a
> KeyError to ever be thrown, which should be expected by a pop-function.
>
> Pull request is underway.

New description:

 The fix of https://code.djangoproject.com/ticket/24621 led to always
 providing a default to session's dict method pop. This prevents a KeyError
 to ever be thrown, which should be expected by a pop-function.

 Pull request is https://github.com/django/django/pull/6480

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.7f13f99fd21aa19e85660cd984aef0ed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26520: Undo #24621 to make session.pop raise a KeyError again

[Django]

#26520: Undo #24621 to make session.pop raise a KeyError again
--+--
 Reporter:  tuky  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.sessions  |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--
Changes (by tuky):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 pull request is here: https://github.com/django/django/pull/6480

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.46d67769688ee5e295ae40fc5cd0bccf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26520: Undo #24621 to make session.pop raise a KeyError again

[Django]

#26520: Undo #24621 to make session.pop raise a KeyError again
--+
 Reporter:  tuky  |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  contrib.sessions  |Version:  1.9
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  1
Easy pickings:  1 |  UI/UX:  0
--+
 The fix of https://code.djangoproject.com/ticket/24621 led to always
 providing a default to session's dict method pop. This prevents a KeyError
 to ever be thrown, which should be expected by a pop-function.

 Pull request is underway.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.0999d27dd9ef94b354b7c7ceea3c608a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17209: Dogfood class-based views in contrib.auth

[Django]

#17209: Dogfood class-based views in contrib.auth
-+-
 Reporter:  melinath |Owner:  auvipy
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  class-based views| Triage Stage:  Accepted
  admin auth |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 auvipy, still working on this?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.48204d82d626f8d7d1085356f78cd1b8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25789: Inefficient Queries Generated due to not using WHERE EXISTS

[Django]

#25789: Inefficient Queries Generated due to not using WHERE EXISTS
-+-
 Reporter:  cancan101|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  QuerySet.extra   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by schinckel):

 It's not totally relevant (at least not yet), but I have a version of this
 that works with .annotate():

 https://github.com/django/django/pull/6478

 There's also a django-developers thread that hopefully may get some
 discussion.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9d172d454d64a7be3a0fb8e67150e028%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.