Re: [Django] #26600: map says a queryset is not iterable

2018-06-06 Thread Django
#26600: map says a queryset is not iterable
-+-
 Reporter:  ihucos   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  queryset iterator| Triage Stage:
  map|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette):

 Philipp, if you hit a similar exception that means `map` must be involved
 somehow.

 If you didn't call it yourself then it's likely caused by a usage of `map`
 internally in the queryset iteration code.

 In this case the ticket resolution still stands, Python 2 `map`'s
 shadowing of the underlying exception makes it impossible to determine its
 true nature and thus we cannot conclude Django is at fault. As mentioned
 previously this should all be solved on Python 3 where `map` doesn't
 exhibit this behaviour.

 By the way an `in` operation on a queryset you are disposing off is likely
 to trigger a `MemoryError` just like in the original report. I'd suggest
 you opt for something along `queryset.filter(pk=instance.pk).exists()`
 instead.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.57617ee625eaff5ab8122f3958213c1f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #26600: map says a queryset is not iterable

2018-06-06 Thread Django
#26600: map says a queryset is not iterable
-+-
 Reporter:  ihucos   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  queryset iterator| Triage Stage:
  map|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by pro100filipp):

 The problem is not only with the map. We faced the same issue when using
 code like this:

 {{{
 if model_instance in model.objects.all():
 ...
 }}}

 Replying to [comment:8 Simon Charette]:
 > I think we can close as ''wontfix'' given `map` doesn't turn
 `__iter__()` exceptions into `TypeError` on Py3k and we don't support Py2k
 anymore.
 >
 > Thanks for the investigation Vitaliy.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.31b038b9fa064139c427126999e3f643%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29152: Allow more control over ArgumentParser initialization in management commands

2018-06-06 Thread Django
#29152: Allow more control over ArgumentParser initialization in management
commands
-+-
 Reporter:  Dmitry   |Owner:
 Type:   |  humbertotm
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  2.0
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by humbertotm):

 Replying to [comment:7 Dmitry]:
 > Replying to [comment:5 Tom Forbes]:
 > > The create_parser method could just pass in all kwargs to
 CommandParser, rather than having a parser_kwargs instance variable?
 > >
 > >
 > > {{{#!python
 > > def create_parser(self, **kwargs):
 > > return super().create_parser(my_custom_arg=123)
 > >
 > > # In BaseCommand
 > > def create_parser(self, **kwargs):
 > > kwargs.setdefault('description', ...)
 > > return CommandParser(self, **kwargs)
 > > }}}
 > >
 > > Might be a bit more flexible
 > I agree, this looks better.

 By the looks of this, I am guessing that every call to this method in the
 code base would have to be modified to fit this new signature, right?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.1c0a948a7e5905808f288d7a4c55af7f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28621: Crash in QuerySet.annotate() with OuterRef

2018-06-06 Thread Django
#28621: Crash in QuerySet.annotate() with OuterRef
-+-
 Reporter:  Дилян Палаузов   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  QuerySet.extra   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Filip Kilibarda):

 Replying to [comment:6 Ben Davis]:
 > I am also getting this error. Is there a workaround?
 >
 > `AttributeError: 'ResolvedOuterRef' object has no attribute
 'contains_aggregate'`
 >
 > My query looks like this:
 > {{{#!python
 > class ProgramQuerySet(models.QuerySet):
 > def with_remaining_volunteers_needed(self):
 > sessions_query = (
 > Session.objects
 > .filter(program=OuterRef('id'))
 > .annotate(needed=OuterRef('volunteers_per_session') -
 Count('volunteer_attendances'))
 > .order_by('-needed')
 > .values('needed')[:1]
 > )
 >
 > return self.annotate(
 > volunteers_per_session=(F('num_student_seats') *
 F('student_volunteer_ratio')),
 > needed=Subquery(sessions_query,
 output_field=models.IntegerField())
 > )
 > }}}

 I'm having exactly the same issue. Have you found a workaround for this?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.4e4c17d7003374622bbfebdd0b35abde%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29301: Reorder management command arguments in --help output to prioritize command-specific arguments

2018-06-06 Thread Django
#29301: Reorder management command arguments in --help output to prioritize
command-specific arguments
-+-
 Reporter:  David Foster |Owner:  David
 Type:   |  Foster
  Cleanup/optimization   |   Status:  closed
Component:  Core (Management |  Version:  2.0
  commands)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"33b5313d7c0869d6268fa8d550d20eaa172bdfb1" 33b5313d]:
 {{{
 #!CommitTicketReference repository=""
 revision="33b5313d7c0869d6268fa8d550d20eaa172bdfb1"
 [2.1.x] Fixed #29301 -- Added custom help formatter to BaseCommand class

 This partially reverts c3055242c81812278ebdc93dd109f30d2cbd1610.
 Thanks Adam Johnson and Carlton Gibson for the reviews.
 Backport of ce3351b9508896afdf87d11bd64fd6b5ad928228 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d2eeca58e942b49970ee789a9ac598ef%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29301: Reorder management command arguments in --help output to prioritize command-specific arguments

2018-06-06 Thread Django
#29301: Reorder management command arguments in --help output to prioritize
command-specific arguments
-+-
 Reporter:  David Foster |Owner:  David
 Type:   |  Foster
  Cleanup/optimization   |   Status:  closed
Component:  Core (Management |  Version:  2.0
  commands)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ce3351b9508896afdf87d11bd64fd6b5ad928228" ce3351b9]:
 {{{
 #!CommitTicketReference repository=""
 revision="ce3351b9508896afdf87d11bd64fd6b5ad928228"
 Fixed #29301 -- Added custom help formatter to BaseCommand class

 This partially reverts c3055242c81812278ebdc93dd109f30d2cbd1610.
 Thanks Adam Johnson and Carlton Gibson for the reviews.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.558503ae4f9af79a408bf200e739cdd1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29477: wrong translation on es_MX

2018-06-06 Thread Django
#29477: wrong translation on es_MX
-+-
 Reporter:  zodman   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Thanks for the report, but translations are handled through Transifex.
 
https://docs.djangoproject.com/en/2.0/internals/contributing/localizing/#translations

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4d0093889d21a8917538ef2d3669d690%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #11964: Add the ability to use database-level CHECK CONSTRAINTS

2018-06-06 Thread Django
#11964: Add the ability to use database-level CHECK CONSTRAINTS
-+-
 Reporter:  Matthew Schinckel|Owner:  Ian Foote
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  check contsraint | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4e65525dc7eacd02c734bb38406c7b95%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29152: Allow more control over ArgumentParser initialization in management commands

2018-06-06 Thread Django
#29152: Allow more control over ArgumentParser initialization in management
commands
-+-
 Reporter:  Dmitry   |Owner:
 Type:   |  humbertotm
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  2.0
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by humbertotm):

 * status:  new => assigned
 * owner:  nobody => humbertotm


Comment:

 Hi, guys.

 I would like to work on this.
 There's been no activity in this thread lately, so I'm hoping this is
 still a valid issue. If not, please let me know.
 Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.2364c4d061c2c521100248f8586bcdfc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28462: ModelAdmin.list_editable unusably slow and memory intensive with large datasets

2018-06-06 Thread Django
#28462: ModelAdmin.list_editable unusably slow and memory intensive with large
datasets
-+-
 Reporter:  Ben Cole |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"744a44dfa1df21d10e19c6928066eb1408993b29" 744a44df]:
 {{{
 #!CommitTicketReference repository=""
 revision="744a44dfa1df21d10e19c6928066eb1408993b29"
 [2.0.x] Refs #28462 -- Fixed 'invalid escape sequence' warning on Python
 3.6+.

 Backport of e9bd1a3e12df132527a8d8bea95858e856ac7be4 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.491f07647294951facc6620937ab88ec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29476: Filter with BooleanField produces invalid SQL for .query

2018-06-06 Thread Django
#29476: Filter with BooleanField produces invalid SQL for .query
-+-
 Reporter:  Martin Gropp |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 As discussed in #17741, the `query` attribute isn't intended to give valid
 SQL.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.406f0854be075254f98146fc7b8dc08d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29477: wrong translation on es_MX

2018-06-06 Thread Django
#29477: wrong translation on es_MX
-+-
 Reporter:  zodman   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by zodman:

Old description:

> https://github.com/django/django/blob/d6859a14891f028dde8c6d27fb2960ef9984a072/django/contrib/auth/locale/es_MX/LC_MESSAGES/django.po#L79
>
> Correct:
>
> #, python-format
> msgid ""
> "Please enter a correct %(username)s and password. Note that both fields
> may "
> "be case-sensitive."
> msgstr ""
> "Por favor introduzca %(username)s y contraseña correctos. Note que puede
> que "
> "ambos campos sean estrictos en relación a diferencias entre mayúsculas y
> "
> "minúsculas."

New description:

 
https://github.com/django/django/blob/d6859a14891f028dde8c6d27fb2960ef9984a072/django/contrib/auth/locale/es_MX/LC_MESSAGES/django.po#L79

 Correct:


 {{{
 #, python-format
 msgid ""
 "Please enter a correct %(username)s and password. Note that both fields
 may "
 "be case-sensitive."
 msgstr ""
 "Por favor introduzca %(username)s y contraseña correctos. Note que puede
 que "
 "ambos campos sean estrictos en relación a diferencias entre mayúsculas y
 "
 "minúsculas."
 }}}

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.bd5e5380c6f6447e624125b08e050b95%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28462: ModelAdmin.list_editable unusably slow and memory intensive with large datasets

2018-06-06 Thread Django
#28462: ModelAdmin.list_editable unusably slow and memory intensive with large
datasets
-+-
 Reporter:  Ben Cole |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"38bdac4752cd8b27b786fc4aec5516d785f4b6ba" 38bdac47]:
 {{{
 #!CommitTicketReference repository=""
 revision="38bdac4752cd8b27b786fc4aec5516d785f4b6ba"
 [2.1.x] Refs #28462 -- Fixed 'invalid escape sequence' warning on Python
 3.6+.

 Backport of e9bd1a3e12df132527a8d8bea95858e856ac7be4 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e808f6e4456f972f0f126a84dcd7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #29477: wrong translation on es_MX

2018-06-06 Thread Django
#29477: wrong translation on es_MX
+
   Reporter:  zodman|  Owner:  nobody
   Type:  Bug   | Status:  new
  Component:  Internationalization  |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 
https://github.com/django/django/blob/d6859a14891f028dde8c6d27fb2960ef9984a072/django/contrib/auth/locale/es_MX/LC_MESSAGES/django.po#L79

 Correct:

 #, python-format
 msgid ""
 "Please enter a correct %(username)s and password. Note that both fields
 may "
 "be case-sensitive."
 msgstr ""
 "Por favor introduzca %(username)s y contraseña correctos. Note que puede
 que "
 "ambos campos sean estrictos en relación a diferencias entre mayúsculas y
 "
 "minúsculas."

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.82fe9ab465592e8d47ac7e7b7c4458a5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28462: ModelAdmin.list_editable unusably slow and memory intensive with large datasets

2018-06-06 Thread Django
#28462: ModelAdmin.list_editable unusably slow and memory intensive with large
datasets
-+-
 Reporter:  Ben Cole |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"e9bd1a3e12df132527a8d8bea95858e856ac7be4" e9bd1a3]:
 {{{
 #!CommitTicketReference repository=""
 revision="e9bd1a3e12df132527a8d8bea95858e856ac7be4"
 Refs #28462 -- Fixed 'invalid escape sequence' warning on Python 3.6+.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4a8adc2cdf9510aa1c99686fa1339ed7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #29476: Filter with BooleanField produces invalid SQL for .query

2018-06-06 Thread Django
#29476: Filter with BooleanField produces invalid SQL for .query
-+-
   Reporter:  Martin |  Owner:  nobody
  Gropp  |
   Type:  Bug| Status:  new
  Component:  Database   |Version:  1.11
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Hiho!

 I ran into this issue today on 1.11.13:
 I am using `.filter` on a QuerySet to select all elements that have a
 `BooleanField` set to true.
 This works fine when run against the database, but the SQL produced by
 `QuerySet.query` is incorrect.

 Here's an example:
 {{{
 class Foo(Model):
 bar = BooleanField()

 query = str(Foo.objects.filter(bar=True).query)
 }}}

 Will produce SQL like this:
 {{{
 SELECT "table"."id", "table"."bar" FROM "table" WHERE "table"."bar" = True
 }}}

 This will not work, because `True` is interpreted as a column name.

 (I was trying to use this SQL as part of a raw query, and ended up working
 around the problem by replacing the `.filter` with another raw query
 casting `bar` to integer in the `where`.)


 Cheers
 Martin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.2a579bdff322c1296f462fa3cbf6deca%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29451: Add compatibility with MySQL 8

2018-06-06 Thread Django
#29451: Add compatibility with MySQL 8
-+-
 Reporter:  Tim Graham   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"c4f099de1d0d82c5e1f88768300896eae69bddbd" c4f099d]:
 {{{
 #!CommitTicketReference repository=""
 revision="c4f099de1d0d82c5e1f88768300896eae69bddbd"
 Refs #29451 -- Used quote_name for column names in tests.

 Regression in a253a580e6f20fb7087490225538422eb6cab0bb
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fb86ba5331bd521ccf6ad328ea667dc1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #820: Add "view" permission to compliment add/change/delete (was: [patch] "view" permission to compliment add/change/delete)

2018-06-06 Thread Django
#820: Add "view" permission to compliment add/change/delete
-+-
 Reporter:  kayos@…  |Owner:  Adrian
 |  Holovaty
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:  Design
 |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * type:  enhancement => New feature
 * resolution:  wontfix => duplicate


Comment:

 This is fixed in #8936 so changing resolution to "duplicate" rather than
 "wontfix".

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/079.08cc90c12cbb2fb2806a6acaef2a74f5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29475: Only the change permission allows reading data

2018-06-06 Thread Django
#29475: Only the change permission allows reading data
-+-
 Reporter:  James Howe   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  security | Triage Stage:
  permissions|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Duplicate of #8936 (fixed in Django 2.1).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.44b6b03bd0da5e8d66cd8ae924a00ea0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29475: Only the change permission allows reading data

2018-06-06 Thread Django
#29475: Only the change permission allows reading data
-+-
 Reporter:  James Howe   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  security | Triage Stage:
  permissions|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by James Howe):

 * keywords:  securoty permissions => security permissions


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.25083d212ba33d5c3c6f159668ff763a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24384: compilemessages shouldn't return with exit code 0 when it fails

2018-06-06 Thread Django
#24384: compilemessages shouldn't return with exit code 0 when it fails
-+-
 Reporter:  Aymeric Augustin |Owner:  Claude
 |  Paroz
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/10027 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.23e78a5c3b21491b4fe013bba835ad0b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #29475: Only the change permission allows reading data

2018-06-06 Thread Django
#29475: Only the change permission allows reading data
-+-
   Reporter:  James  |  Owner:  nobody
  Howe   |
   Type:  Bug| Status:  new
  Component: |Version:  1.11
  contrib.admin  |   Keywords:  securoty
   Severity:  Normal |  permissions
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 This is a big problem as there's no separate view permission.

 I want a set of admins to be able to view and delete objects, but not edit
 or add new ones.
 However, if only the delete permission is given, there's no way to find or
 list the objects in the first place.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.f98a0b0c514f90509b4764a61d0fc909%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29419: Limiting visibility of Admin actions to `change` permission only isn't right.

2018-06-06 Thread Django
#29419: Limiting visibility of Admin actions to `change` permission only isn't
right.
-+-
 Reporter:  Paulo|Owner:  Carlton
 |  Gibson
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * component:  Documentation => contrib.admin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e839c6ec98deacd72cacc826600ddd3e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #24384: compilemessages shouldn't return with exit code 0 when it fails

2018-06-06 Thread Django
#24384: compilemessages shouldn't return with exit code 0 when it fails
-+-
 Reporter:  Aymeric Augustin |Owner:  Claude
 |  Paroz
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * owner:  nobody => Claude Paroz
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f12e19d73ec4368381cee19523dc2990%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29428: Add support to admin for expressions like (Lower('myfield'), ) in model Meta.ordering

2018-06-06 Thread Django
#29428: Add support to admin for expressions like (Lower('myfield'),) in model
Meta.ordering
-+-
 Reporter:  Dutch Stiphout   |Owner:  Nicolas
 |  Noé
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Release blocker  |   Resolution:
 Keywords:  admin ordering   | Triage Stage:  Accepted
  expression AttributeError  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * cc: Carlton Gibson (added)


Comment:

 A couple of points:

 First, I wondered why the existing test from the fix for #28958 didn't
 fail since it already uses `Upper`
 ([https://github.com/django/django/pull/9491/files#diff-
 a7a67d6270c5d6e0ded64c97a77132ffR67 here]):

 {{{
  Upper(F('name')).asc(),
 }}}

 The key point is the `asc()` call, which returns an `OrderBy` (which then
 gets processed by [https://github.com/django/django/pull/9491/files#diff-
 ea7d8c684e252f3dad6aa458df7d3070R291 the block added] in the fix).

 Remove the `asc()` call and the test fails with the error raised in
 `get_ordering_field_columns()`.

 The ordering works without the `asc()` call (or the `F` for that matter)
 so maybe `get_ordering_field_columns()` should call `field.asc()` (if
 available, when not already an `OrderBy`) in order to correct the
 behaviour here.

 Second, whilst you can an `ordering` including (say)
 `Lower('description')` on the model, if you try to set it on the
 ModelAdmin, the admin's
 
[https://github.com/django/django/blob/b37bac39b387bc87872d37d4b07783b67ef28d0c/django/contrib/admin/checks.py#L476
 `_check_ordering` check] will error (in `LOOKUP_SEP in field_name`). This
 occurs in for the transform or `OrderBy` case. This check needs adjusting.

 @Nicolas Noé Are you good to work on this ticket still?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.bb66674ffea64f05dac5a8f0bb52adc0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29419: Limiting visibility of Admin actions to `change` permission only isn't right.

2018-06-06 Thread Django
#29419: Limiting visibility of Admin actions to `change` permission only isn't
right.
-+-
 Reporter:  Paulo|Owner:  Carlton
 |  Gibson
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  new => assigned
 * owner:  (none) => Carlton Gibson


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8900ecdd5cc9e30d7dab2c188dab31c7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.