Re: [Django] #33061: ValueError not raised by some cache backends for incr() / decr() with negative delta when a key is missing

2021-08-30 Thread Django
#33061: ValueError not raised by some cache backends for incr() / decr() with
negative delta when a key is missing
-+-
 Reporter:  Chris Jerdonek   |Owner:  Sondre
 |  Lillebø Gundersen
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f5f91aec4a6ac27b50d83dacc0dea187%40djangoproject.com.


Re: [Django] #33074: Do not require fields on UpdateView/CreateView if form specified

2021-08-30 Thread Django
#33074: Do not require fields on UpdateView/CreateView if form specified
-+-
 Reporter:  Dan Swain|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Generic views|  Version:  3.2
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  CreateView   | Triage Stage:
  UpdateView form ModelFormMixin |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Thanks for the report, however specifying both `fields` and `form_class`
 is not permitted and `fields` are not checked when `form_class` is
 specified, see
 
[https://github.com/django/django/blob/3219dd3388c437b4bd869b76ddd43c9cdad05090/django/views/generic/edit.py#L76-L99
 get_form_class()]. I'm not sure how you could reach this path with
 `form_class` 樂

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.e601b957099057bf9d09ceab0ddcc3c0%40djangoproject.com.


Re: [Django] #33070: Select2 doesn't load translations with subtags. (was: Error using select2 translation files)

2021-08-30 Thread Django
#33070: Select2 doesn't load translations with subtags.
-+-
 Reporter:  Cleiton de Lima  |Owner:  sarath ak
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:  select2  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  closed => new
 * cc: info@… (removed)
 * cc: Johannes Maron, Claude Paroz (added)
 * easy:  1 => 0
 * resolution:  invalid =>
 * stage:  Unreviewed => Accepted


Comment:

 Replying to [comment:4 Cleiton de Lima]:
 > Replying to [comment:3 Mariusz Felisiak]:
 > > `LANGUAGE_CODE` should be lowercased, so `pt-br` instead of `pt-BR`,
 see [https://docs.djangoproject.com/en/3.2/topics/i18n/#definitions
 "Definitions"], [https://docs.djangoproject.com/en/3.2/ref/settings
 /#language-code LANGUAGE_CODE docs], and the list of
 
[https://github.com/django/django/blob/3219dd3388c437b4bd869b76ddd43c9cdad05090/django/conf/global_settings.py#L124
 LANGUAGES].
 >
 > The translation of select2 only accepts pt-BR that way.
 > The file is found but the translation doesn't work. It only works when
 the tag html has
 > {{{...}}}
 >

 Thanks, I didn't notice that `Select2` loads translations based on `LANG`.
 Lowercase when searching for a file will help only for `pt-BR` but not for
 `zh-hans`, `pt-br` etc. We could probably add `lang` to the `attrs`, e.g.:
 {{{
 diff --git a/django/contrib/admin/widgets.py
 b/django/contrib/admin/widgets.py
 index aeb74773ac..f1002cac6c 100644
 --- a/django/contrib/admin/widgets.py
 +++ b/django/contrib/admin/widgets.py
 @@ -388,6 +388,7 @@ class AutocompleteMixin:
  self.db = using
  self.choices = choices
  self.attrs = {} if attrs is None else attrs.copy()
 +self.i18n_name = SELECT2_TRANSLATIONS.get(get_language())

  def get_url(self):
  return reverse(self.url_name % self.admin_site.name)
 @@ -413,6 +414,7 @@ class AutocompleteMixin:
  'data-theme': 'admin-autocomplete',
  'data-allow-clear': json.dumps(not self.is_required),
  'data-placeholder': '',  # Allows clearing of the input.
 +'lang': self.i18n_name,
  'class': attrs['class'] + (' ' if attrs['class'] else '') +
 'admin-autocomplete',
  })
  return attrs
 @@ -449,8 +451,7 @@ class AutocompleteMixin:
  @property
  def media(self):
  extra = '' if settings.DEBUG else '.min'
 -i18n_name = SELECT2_TRANSLATIONS.get(get_language())
 -i18n_file = ('admin/js/vendor/select2/i18n/%s.js' % i18n_name,)
 if i18n_name else ()
 +i18n_file = ('admin/js/vendor/select2/i18n/%s.js' %
 self.i18n_name,) if self.i18n_name else ()
  return forms.Media(
  js=(
  'admin/js/vendor/jquery/jquery%s.js' % extra,
 }}}
 What do you think? It works for me.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.07855d9a69066294000b15a735bd42d0%40djangoproject.com.


Re: [Django] #6106: make-messages.py should not touch POT-Creation-Date

2021-08-30 Thread Django
#6106: make-messages.py should not touch POT-Creation-Date
-+-
 Reporter:  Marc Fargas  |Owner:  Ramiro
 Type:   |  Morales
  Cleanup/optimization   |   Status:  closed
Component:   |  Version:  dev
  Internationalization   |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Daniyal Abbasi):

 Sure Mariusz. I've started the discussion on the mailing list!
 [https://groups.google.com/g/django-developers/c/8QK4MYIE-
 Us/m/oNygOdHTAwAJ Link]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.077b89c88c178c6afc5d863de8a21d2b%40djangoproject.com.


Re: [Django] #33062: File upload crash when a file extension contains null characters.

2021-08-30 Thread Django
#33062: File upload crash when a file extension contains null characters.
-+-
 Reporter:  Alex Vandiver|Owner:  Ased
 |  mammad
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  3.2
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ased mammad):

 * owner:  nobody => Ased mammad
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4791a1626af6a25f482f84578f38dd58%40djangoproject.com.


[Django] #33074: Do not require fields on UpdateView/CreateView if form specified

2021-08-30 Thread Django
#33074: Do not require fields on UpdateView/CreateView if form specified
-+-
   Reporter:  Dan Swain  |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |
  Component:  Generic|Version:  3.2
  views  |   Keywords:  CreateView
   Severity:  Normal |  UpdateView form ModelFormMixin
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 When a form class is specified on CreateView or UpdateView, then even
 though the fields are specified on the form, the following error occurs:

 django.core.exceptions.ImproperlyConfigured: Using ModelFormMixin (base
 class of MyModelCreateView) without the 'fields' attribute is prohibited.

 It seems like fields should not have to be specified on a CreateView or
 UpdateView when a form is specified since fields HAVE to be specified on a
 form.  Why can't the view just use the fields specified on the form?
 Raising this error when no fields have been specified on the view but a
 form HAS been specified seems to go against DRY.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/054.73020fdf4328deaf3bf4c53d14455b2a%40djangoproject.com.


Re: [Django] #33070: Error using select2 translation files

2021-08-30 Thread Django
#33070: Error using select2 translation files
-+--
 Reporter:  Cleiton de Lima  |Owner:  sarath ak
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  3.2
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  select2  | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--

Comment (by Cleiton de Lima):

 Replying to [comment:3 Mariusz Felisiak]:
 > `LANGUAGE_CODE` should be lowercased, so `pt-br` instead of `pt-BR`, see
 [https://docs.djangoproject.com/en/3.2/topics/i18n/#definitions
 "Definitions"], [https://docs.djangoproject.com/en/3.2/ref/settings
 /#language-code LANGUAGE_CODE docs], and the list of
 
[https://github.com/django/django/blob/3219dd3388c437b4bd869b76ddd43c9cdad05090/django/conf/global_settings.py#L124
 LANGUAGES].

 The translation of select2 only accepts pt-BR that way.
 
https://github.com/django/django/blob/main/django/contrib/admin/static/admin/js/vendor/select2/i18n
 /pt-BR.js

 https://github.com/django/django/blob/main/django/contrib/admin/widgets.py#L453

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.dce2a4507def5a3f62a05a4f55939f81%40djangoproject.com.


Re: [Django] #33073: AttributeError when annotating with Exists(none()) and aggregation

2021-08-30 Thread Django
#33073: AttributeError when annotating with Exists(none()) and aggregation
-+-
 Reporter:  Matthijs Kooijman|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: David Wobrock, Simon Charette (added)
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report. It's really similar to the #33018, however
 [https://github.com/django/django/pull/14770 the proposed patch] doesn't
 fix this issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.3e050288fb478a797e88cb0f6cef4bf2%40djangoproject.com.


Re: [Django] #33070: Error using select2 translation files

2021-08-30 Thread Django
#33070: Error using select2 translation files
-+--
 Reporter:  Cleiton de Lima  |Owner:  sarath ak
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  3.2
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  select2  | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * has_patch:  1 => 0
 * resolution:   => invalid


Comment:

 `LANGUAGE_CODE` should be lowercased, so `pt-br` instead of `pt-BR`, see
 [https://docs.djangoproject.com/en/3.2/topics/i18n/#definitions
 "Definitions"], [https://docs.djangoproject.com/en/3.2/ref/settings
 /#language-code LANGUAGE_CODE docs], and the list of
 
[https://github.com/django/django/blob/3219dd3388c437b4bd869b76ddd43c9cdad05090/django/conf/global_settings.py#L124
 LANGUAGES].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.a10ee676983980eaa83b6a86f317ee80%40djangoproject.com.


[Django] #33073: AttributeError when annotating with Exists(none()) and aggregation

2021-08-30 Thread Django
#33073: AttributeError when annotating with Exists(none()) and aggregation
-+-
   Reporter:  Matthijs   |  Owner:  nobody
  Kooijman   |
   Type: | Status:  new
  Uncategorized  |
  Component:  Database   |Version:  dev
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 I ran into a problem with annotating a field with an Exists subquery,
 passing {{{MyModel.objects.none()}}} to Exists. On Django main branch,
 this throws an AttributeError, on 2.2.24 this returns an empty queryset
 (and printing the query attribute of the queryset raises EmptyResultSet).

 Strangely enough this only seems to occur when I add a second annotation
 using an aggregation (I tried Sum, Max and Count). Adding a second
 aggregation using a plain field (e.g. {{{F('id')}}}) does not seem to
 trigger the problem. Each of the annotations individually also work, but
 not together.

 It seems this already fails on the most basic (empty) model definition, no
 options or specific fields required.

 I have not really investigated the details, I'm not too familiar with the
 query generating code.

 Below is a testcase (ready to be included as a regression test).

 {{{
 --- a/tests/model_regress/tests.py
 +++ b/tests/model_regress/tests.py
 @@ -236,6 +236,18 @@ class Horse(models.Model, metaclass=HorseBase):

  self.assertEqual(Horse.horns, 1)

 +def test_exists_none_with_aggregate(self):
 +Party.objects.create()
 +qs = Party.objects.all().annotate(
 +foo=models.Count('id'),
 +bar=models.Exists(Party.objects.none()),
 +)
 +# Throws EmptyResultSet on 2.2.24, or AttributeError:
 'NothingNode' object has no attribute
 +# 'get_source_expressions' on 3.2.6
 +qs.query
 +# Returns empty result on 2.2.24 or throws on 3.2.6
 +self.assertEqual(len(qs), 1)
 +

 ./runtests.py
 model_regress.tests.ModelTests.test_exists_none_with_aggregate
 (... snip some stuff ...)
 Traceback (most recent call last):
   File "django/tests/model_regress/tests.py", line 249, in
 test_exists_empty_with_aggregate
 self.assertEqual(len(qs), 1)
   File "django/db/models/query.py", line 262, in __len__
 self._fetch_all()
   File "django/db/models/query.py", line 1352, in _fetch_all
 self._result_cache = list(self._iterable_class(self))
   File "django/db/models/query.py", line 51, in __iter__
 results = compiler.execute_sql(chunked_fetch=self.chunked_fetch,
 chunk_size=self.chunk_size)
   File "django/db/models/sql/compiler.py", line 1185, in execute_sql
 sql, params = self.as_sql()
   File "django/db/models/sql/compiler.py", line 527, in as_sql
 extra_select, order_by, group_by = self.pre_sql_setup()
   File "django/db/models/sql/compiler.py", line 64, in pre_sql_setup
 group_by = self.get_group_by(self.select + extra_select, order_by)
   File "django/db/models/sql/compiler.py", line 129, in get_group_by
 cols = expr.get_group_by_cols()
   File "django/db/models/expressions.py", line 1159, in get_group_by_cols
 external_cols = self.get_external_cols()
   File "django/db/models/expressions.py", line 1143, in get_external_cols
 return self.query.get_external_cols()
   File "django/db/models/sql/query.py", line 1057, in get_external_cols
 return [
   File "django/db/models/sql/query.py", line 1057, in 
 return [
   File "django/db/models/sql/query.py", line 1697, in _gen_cols
 expr.get_source_expressions(),
 AttributeError: 'NothingNode' object has no attribute
 'get_source_expressions'
 }}}

 (Can be pulled from https://github.com/matthijskooijman/django/blob
 /testcase-exists-none/tests/model_regress/tests.py#L239)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/059.59f71e0eba515ba081bdb635119ec4b5%40djangoproject.com.


Re: [Django] #33070: Error using select2 translation files

2021-08-30 Thread Django
#33070: Error using select2 translation files
-+--
 Reporter:  Cleiton de Lima  |Owner:  sarath ak
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:  select2  | Triage Stage:  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--
Changes (by sarath ak):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.78bba6f1aea917f0066d77b6103876ad%40djangoproject.com.


Re: [Django] #33071: ContentType selects wrong DB in multiple DB setup

2021-08-30 Thread Django
#33071: ContentType selects wrong DB in multiple DB setup
-+-
 Reporter:  Taylor H |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:   |  Version:  3.2
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * type:  Uncategorized => Bug
 * resolution:   => duplicate


Comment:

 I'm pretty sure it's a duplicate of #15610 or #16281.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.fa87baa28898a8619d83b8eae59590d5%40djangoproject.com.


Re: [Django] #33070: Error using select2 translation files

2021-08-30 Thread Django
#33070: Error using select2 translation files
-+--
 Reporter:  Cleiton de Lima  |Owner:  sarath ak
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:  select2  | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--
Changes (by sarath ak):

 * owner:  nobody => sarath ak
 * status:  new => assigned


Comment:

 I fixed it

 https://github.com/django/django/pull/14813

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.77b30ab46de52bc50a21ae819107c566%40djangoproject.com.


Re: [Django] #32975: ModelAdmin for proxy model with InlineModelAdmin for proxy superclass reference results in admin.E202

2021-08-30 Thread Django
#32975: ModelAdmin for proxy model with InlineModelAdmin for proxy superclass
reference results in admin.E202
-+-
 Reporter:  Lucas Weyne  |Owner:  Taulant
 |  Aliraj
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  3.1
 Severity:  Normal   |   Resolution:
 Keywords:  proxy,   | Triage Stage:  Accepted
  InlineModelAdmin, E202 |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Taulant Aliraj):

 * has_patch:  0 => 1


Comment:

 Opened a PR for this: https://github.com/django/django/pull/14812

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2d9a262a2eb05fd6e966b975f74fb702%40djangoproject.com.


Re: [Django] #33072: Providing Django Channels Documentation within djangoproject.com documentation

2021-08-30 Thread Django
#33072: Providing Django Channels Documentation within djangoproject.com
documentation
---+--
 Reporter:  Varun Sharma   |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Documentation  |  Version:  3.2
 Severity:  Normal |   Resolution:  invalid
 Keywords:  documentation  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Django Channels is a separate package that has its own
 [https://channels.readthedocs.io/en/latest/?badge=latest docs] with enough
 examples, IMO. You can open a new issue in
 [https://github.com/django/channels/issues Channel's repository] if you
 think some examples are missing.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.122a8c5a5be243e9ed22fa43c41f57a1%40djangoproject.com.


[Django] #33072: Providing Django Channels Documentation within djangoproject.com documentation

2021-08-30 Thread Django
#33072: Providing Django Channels Documentation within djangoproject.com
documentation
-+---
   Reporter:  VSofficial |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Documentation  |Version:  3.2
   Severity:  Normal |   Keywords:  documentation
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+---
 Django Channels does not have sufficient documentation available for
 Official Django documentation available at djangoproject.com. Developing
 documentation with actual examples.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.19ec07ce069bed4a5bfb6f4b0306df65%40djangoproject.com.


Re: [Django] #33071: ContentType selects wrong DB in multiple DB setup

2021-08-30 Thread Django
#33071: ContentType selects wrong DB in multiple DB setup
-+-
 Reporter:  Taylor H |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:   |  Version:  3.2
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Taylor H:

Old description:

> I just introduced multiple DBs in my Django app to split up some of the
> write/read load. I found that ContentType does not work across multiple
> DBs with GenericForeignKey. It is hard coded to use the same DB as the
> source/parent model. Here is the code that has a hard coded .using().
>
> {{{
> def get_all_objects_for_this_type(self, **kwargs):
> """
> Return all objects of this type for the keyword arguments given.
> """
> return
> self.model_class()._base_manager.using(self._state.db).filter(**kwargs)
> }}}
>

> https://github.com/django/django/blame/main/django/contrib/contenttypes/models.py#L181
>
> Is there are reason for hard coding using() here instead of using the DB
> router like other places in the code? If we could just removing the using
> everything just works

New description:

 I just introduced multiple DBs in my Django app to split up some of the
 write/read load. I found that ContentType does not work across multiple
 DBs with GenericForeignKey. It is hard coded to use the same DB as the
 source model. Here is the code that has a hard coded .using().

 {{{
 def get_all_objects_for_this_type(self, **kwargs):
 """
 Return all objects of this type for the keyword arguments given.
 """
 return
 self.model_class()._base_manager.using(self._state.db).filter(**kwargs)
 }}}


 
https://github.com/django/django/blame/main/django/contrib/contenttypes/models.py#L181

 Is there are reason for hard coding using() here instead of using the DB
 router like other places in the code? If we could just removing the using
 everything just works

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.314aa86cbe9de9e7f1a3147b1afb1091%40djangoproject.com.


[Django] #33071: ContentType selects wrong DB in multiple DB setup

2021-08-30 Thread Django
#33071: ContentType selects wrong DB in multiple DB setup
+
   Reporter:  Taylor H  |  Owner:  nobody
   Type:  Uncategorized | Status:  new
  Component:  contrib.contenttypes  |Version:  3.2
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 I just introduced multiple DBs in my Django app to split up some of the
 write/read load. I found that ContentType does not work across multiple
 DBs with GenericForeignKey. It is hard coded to use the same DB as the
 source/parent model. Here is the code that has a hard coded .using().

 {{{
 def get_all_objects_for_this_type(self, **kwargs):
 """
 Return all objects of this type for the keyword arguments given.
 """
 return
 self.model_class()._base_manager.using(self._state.db).filter(**kwargs)
 }}}


 
https://github.com/django/django/blame/main/django/contrib/contenttypes/models.py#L181

 Is there are reason for hard coding using() here instead of using the DB
 router like other places in the code? If we could just removing the using
 everything just works

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/055.a0a52d640a447917db755f902057f2cc%40djangoproject.com.


Re: [Django] #33061: ValueError not raised by some cache backends for incr() / decr() with negative delta when a key is missing

2021-08-30 Thread Django
#33061: ValueError not raised by some cache backends for incr() / decr() with
negative delta when a key is missing
-+-
 Reporter:  Chris Jerdonek   |Owner:  Sondre
 |  Lillebø Gundersen
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Sondre Lillebø Gundersen):

 * cc: Sondre Lillebø Gundersen (added)
 * has_patch:  0 => 1


Comment:

 Opened at PR for this: https://github.com/django/django/pull/14810 :)

 As far as I can tell, it should now work as I expected it to originally -
 and I think that fixes any uncertainty around the handling of a missing
 key, since negative deltas are now treated the same as positive deltas,
 just with the extra step.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9eae7b7e571e9db35b4172d677c58491%40djangoproject.com.


[Django] #33070: Error using select2 translation files

2021-08-30 Thread Django
#33070: Error using select2 translation files
---+-
   Reporter:  Cleiton de Lima  |  Owner:  nobody
   Type:  Bug  | Status:  new
  Component:  contrib.admin|Version:  3.2
   Severity:  Normal   |   Keywords:  select2
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  1
  UI/UX:  0|
---+-
 For example, when using the setting {{{LANGUAGE_CODE="pt-BR"}}}, the
 translation of select2 is not applied, the static file i18n is not found.
 This is due to the fact that some languages are converted to lowercase.
 https://github.com/django/django/blob/main/django/contrib/admin/widgets.py#L366

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/056.cac9a1c5e65262af3b984e22b7312d92%40djangoproject.com.


Re: [Django] #24900: KeyError when trying to migrate backward to a replaced migration

2021-08-30 Thread Django
#24900: KeyError when trying to migrate backward to a replaced migration
+-
 Reporter:  Carl Meyer  |Owner:  Jacob Walls
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  dev
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-

Comment (by Mariusz Felisiak ):

 In [changeset:"9e17cc062c62eec1177aaf65ebebba43e074cde2" 9e17cc0]:
 {{{
 #!CommitTicketReference repository=""
 revision="9e17cc062c62eec1177aaf65ebebba43e074cde2"
 Refs #24900 -- Added MigrationLoader test for applying squashed
 migrations.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f957cb83613cd5437a9d95081885aa37%40djangoproject.com.


Re: [Django] #24900: KeyError when trying to migrate backward to a replaced migration

2021-08-30 Thread Django
#24900: KeyError when trying to migrate backward to a replaced migration
+-
 Reporter:  Carl Meyer  |Owner:  Jacob Walls
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  dev
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"3219dd3388c437b4bd869b76ddd43c9cdad05090" 3219dd33]:
 {{{
 #!CommitTicketReference repository=""
 revision="3219dd3388c437b4bd869b76ddd43c9cdad05090"
 Fixed #24900 -- Allowed migrating backward to squashed migrations.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e0188ed96ebf15c813fc9f8caabc09e8%40djangoproject.com.


Re: [Django] #6106: make-messages.py should not touch POT-Creation-Date

2021-08-30 Thread Django
#6106: make-messages.py should not touch POT-Creation-Date
-+-
 Reporter:  Marc Fargas  |Owner:  Ramiro
 Type:   |  Morales
  Cleanup/optimization   |   Status:  closed
Component:   |  Version:  dev
  Internationalization   |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * severity:   => Normal
 * cc: Daniyal Abbasi (added)
 * needs_tests:  0 => 1
 * easy:   => 0
 * ui_ux:   => 0
 * type:   => Cleanup/optimization
 * stage:  Someday/Maybe => Unreviewed


Comment:

 Daniyal, Can you take this to DevelopersMailingList to reach a wider
 audience and see what other think? see
 [https://code.djangoproject.com/ticket/33056#comment:6 comment].

 [https://github.com/django/django/pull/14800 PR]

 #33056 was a duplicate.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8b46160af7c6029dc57c4c286b436e56%40djangoproject.com.


Re: [Django] #33056: makemessages overrides the *.po files even if they are already up to date

2021-08-30 Thread Django
#33056: makemessages overrides the *.po files even if they are already up to 
date
-+-
 Reporter:  Daniyal Abbasi   |Owner:  Daniyal
 Type:   |  Abbasi
  Cleanup/optimization   |   Status:  closed
Component:   |  Version:  3.2
  Internationalization   |
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * has_patch:  1 => 0
 * resolution:   => duplicate
 * needs_tests:  1 => 0


Comment:

 Duplicate of #6106.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.0709e5e8ce4c2eb2b83c33aab517b5b9%40djangoproject.com.


Re: [Django] #33068: makemessages is inconvenient when overriding default django translations

2021-08-30 Thread Django
#33068: makemessages is inconvenient when overriding default django translations
-+-
 Reporter:  Satyajeet Kanetkar   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:   |  Version:  3.2
  Internationalization   |   Resolution:
 Severity:  Normal   |  worksforme
 Keywords:  makemessages | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Claude Paroz (added)
 * status:  new => closed
 * resolution:   => worksforme


Comment:

 Thanks for the report, however I cannot reproduce this issue with
 following steps:
  - create new project
  - copy `django/conf/locale/mr/LC_MESSAGES/django.po` to the
 `/locale/mr/LC_MESSAGES/django.po`
  - add `LOCALE_PATHS = [BASE_DIR / 'locale']` to settings
  - translate some strings in `/locale/mr/LC_MESSAGES/django.po`
  - compile messages,
  - call `python manage.py makemessages -l mr`

 I don't see any lines commented in the
 `/locale/mr/LC_MESSAGES/django.po`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5b7e64b830bebbfeec306a68da039462%40djangoproject.com.


Re: [Django] #33056: makemessages overrides the *.po files even if they are already up to date

2021-08-30 Thread Django
#33056: makemessages overrides the *.po files even if they are already up to 
date
-+-
 Reporter:  Daniyal Abbasi   |Owner:  Daniyal
 Type:   |  Abbasi
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  3.2
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 This may be discussed on the django-developers mailing list.

 I guess the closing 11 years ago was to keep the meaning of `POT-Creation-
 Date` as "last time we checked for new translations", vs "last time a
 string changed in the file". However I can understand the issue it is with
 source control, having been bitten by this too. Now I think I'm rather in
 favour of the change, but getting more opinions from the mailing list
 would be great.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.426d53aca2a3b0c875f66a7917397f3a%40djangoproject.com.


Re: [Django] #29850: Add window support for RowRange frames

2021-08-30 Thread Django
#29850: Add window support for RowRange frames
-+-
 Reporter:  Daniel Fuchs |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  GSoC | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Raphael Michel, Mads Jensen (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f651a4d642a10ed64bd168c714258087%40djangoproject.com.


Re: [Django] #24900: KeyError when trying to migrate backward to a replaced migration

2021-08-30 Thread Django
#24900: KeyError when trying to migrate backward to a replaced migration
+-
 Reporter:  Carl Meyer  |Owner:  Jacob Walls
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  dev
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.bfa5f2527c139da999a847f2b6b8a53f%40djangoproject.com.


Re: [Django] #33061: ValueError not raised by some cache backends for incr() / decr() with negative delta when a key is missing

2021-08-30 Thread Django
#33061: ValueError not raised by some cache backends for incr() / decr() with
negative delta when a key is missing
-+-
 Reporter:  Chris Jerdonek   |Owner:  Sondre
 |  Lillebø Gundersen
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Sondre Lillebø Gundersen):

 * owner:  nobody => Sondre Lillebø Gundersen
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ab81344c0dbbc4987fc6fe7200cd2090%40djangoproject.com.


Re: [Django] #32992: Reverse time zone conversion in Trunc()/Extract() database functions.

2021-08-30 Thread Django
#32992: Reverse time zone conversion in Trunc()/Extract() database functions.
-+-
 Reporter:  James Beith  |Owner:  Carlton
 |  Gibson
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"fe3a854e1de2753ad6fa78a8584f85186092f801" fe3a854e]:
 {{{
 #!CommitTicketReference repository=""
 revision="fe3a854e1de2753ad6fa78a8584f85186092f801"
 [3.2.x] Fixed #32992 -- Restored offset extraction for fixed offset
 timezones.

 Regression in 10d126198434810529e0220b0c6896ed64ca0e88.

 Backport of cbba49971e3e8c6685e4ce6ab87b1187ae87 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b248382439266ad3c8d31721ddd7e369%40djangoproject.com.


Re: [Django] #32992: Reverse time zone conversion in Trunc()/Extract() database functions.

2021-08-30 Thread Django
#32992: Reverse time zone conversion in Trunc()/Extract() database functions.
-+-
 Reporter:  James Beith  |Owner:  Carlton
 |  Gibson
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"cbba49971e3e8c6685e4ce6ab87b1187ae87" cbba499]:
 {{{
 #!CommitTicketReference repository=""
 revision="cbba49971e3e8c6685e4ce6ab87b1187ae87"
 Fixed #32992 -- Restored offset extraction for fixed offset timezones.

 Regression in 10d126198434810529e0220b0c6896ed64ca0e88.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ba8e95b4512ea260a4a212796a52da5f%40djangoproject.com.


Re: [Django] #33061: ValueError not raised by some cache backends for incr() / decr() with negative delta when a key is missing

2021-08-30 Thread Django
#33061: ValueError not raised by some cache backends for incr() / decr() with
negative delta when a key is missing
-+
 Reporter:  Chris Jerdonek   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by Mariusz Felisiak):

 Replying to [comment:9 Vijay ]:
 > Can you please tell me what does `self._cache.decr()` return for a
 missing key ?

 The same as `self._cache.incr()`, it depends on the library and it's
 described in the
 
[https://github.com/django/django/blob/main/django/core/cache/backends/memcached.py
 code]. This doesn't really matter for the ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.72021262fe88af0144541caad5d3a64c%40djangoproject.com.


Re: [Django] #33061: ValueError not raised by some cache backends for incr() / decr() with negative delta when a key is missing

2021-08-30 Thread Django
#33061: ValueError not raised by some cache backends for incr() / decr() with
negative delta when a key is missing
-+
 Reporter:  Chris Jerdonek   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by Vijay ):

 Replying to [comment:8 Mariusz Felisiak]:
 > Replying to [comment:7 Sondre Lillebø Gundersen]:
 > >
 > > The missing key would not be raised from `incr` but from `decr`,
 right? Perhaps I'm missing the point 
 >
 >
 > You're missing that it calls `self._cache.decr()` not `self.decr()`.

 Can you please tell me what does `self._cache.decr()` return for a non-
 existing key ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3f42bdbb1ac7e14fdec1fb72c8aa360c%40djangoproject.com.


Re: [Django] #32992: Reverse time zone conversion in Trunc()/Extract() database functions.

2021-08-30 Thread Django
#32992: Reverse time zone conversion in Trunc()/Extract() database functions.
-+-
 Reporter:  James Beith  |Owner:  Carlton
 |  Gibson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.94f498a9c66e3a230b1b6dcf429fc6e9%40djangoproject.com.


Re: [Django] #33069: Comment to match code in django.form.widget.Widget.value_from_datadict

2021-08-30 Thread Django
#33069: Comment to match code in django.form.widget.Widget.value_from_datadict
---+--
 Reporter:  Michael|Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  3.2
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 If works as documented with a dict, see
 [https://docs.python.org/3/library/stdtypes.html?highlight=dict#dict.get
 dict.get() docs].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e79b7b48f0bbacc880da7e93056af21c%40djangoproject.com.


[Django] #33069: Comment to match code in django.form.widget.Widget.value_from_datadict

2021-08-30 Thread Django
#33069: Comment to match code in django.form.widget.Widget.value_from_datadict
-+
   Reporter:  Michael|  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  3.2
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+
 The comment says it returns `None` if not provided,  maybe you are
 expecting a default dict to be passed in as `data`, in which case this
 ticket is invalid, but if it is a normal dict:

 django/form/widget.py line 258 (class Widget):
 {{{
 def value_from_datadict(self, data, files, name):
 """
 Given a dictionary of data and this widget's name, return the
 value
 of this widget or None if it's not provided.
 """
 return data.get(name)
 }}}

 then either the comment needs to trim `or None if it's not provided` or
 the code changed to `data.get(name, None)`

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.64d7f9ff991992152eb6601820c59361%40djangoproject.com.


Re: [Django] #33062: File upload crash when a file extension contains null characters. (was: Null byte in uploaded filename extension is not cleaned up, results in exception)

2021-08-30 Thread Django
#33062: File upload crash when a file extension contains null characters.
--+
 Reporter:  Alex Vandiver |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  File uploads/storage  |  Version:  3.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * cc: Florian Apolloner (added)
 * component:  Forms => File uploads/storage
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the detailed report! I'd remove null characters in
 `MultiPartParser.sanitize_file_name()`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.28e82849ceaa87c89f8a577d7eefc635%40djangoproject.com.


Re: [Django] #33054: Make captureOnCommitCallbacks capture callbacks added by callbacks

2021-08-30 Thread Django
#33054: Make captureOnCommitCallbacks capture callbacks added by callbacks
-+-
 Reporter:  Evgenii Morozov  |Owner:  Evgenii
 |  Morozov
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  on_commit| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"d89f976bddb49fb168334960acc8979c3de991fa" d89f976b]:
 {{{
 #!CommitTicketReference repository=""
 revision="d89f976bddb49fb168334960acc8979c3de991fa"
 Fixed #33054 -- Made TestCase.captureOnCommitCallbacks() capture callbacks
 recursively.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.36589e495a3ea0396c295c9082e698bd%40djangoproject.com.


Re: [Django] #33056: makemessages overrides the *.po files even if they are already up to date

2021-08-30 Thread Django
#33056: makemessages overrides the *.po files even if they are already up to 
date
-+-
 Reporter:  Daniyal Abbasi   |Owner:  Daniyal
 Type:   |  Abbasi
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  3.2
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 Claude, it looks like a duplicate of #6106. IMO we should close this as a
 duplicate and reopen the original ticket if we want to change the previous
 decision.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.f22707cdb03aea15a6e9c5f17846892f%40djangoproject.com.


Re: [Django] #33057: Foreign key constraint in m2m tables is not recreated when altering type of referenced primary key on Oracle.

2021-08-30 Thread Django
#33057: Foreign key constraint in m2m tables is not recreated when altering 
type of
referenced primary key on Oracle.
-+-
 Reporter:  Fabio Sangiovanni|Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Mariusz Felisiak
 * status:  new => assigned
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.44a23d4a0983dbd81cd584b5c5a5c5e5%40djangoproject.com.


Re: [Django] #33057: Foreign key constraint in m2m tables is not recreated when altering type of referenced primary key on Oracle. (was: DROP of foreign key constraints in through model when related m

2021-08-30 Thread Django
#33057: Foreign key constraint in m2m tables is not recreated when altering 
type of
referenced primary key on Oracle.
---+
 Reporter:  Fabio Sangiovanni  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Migrations |  Version:  3.2
 Severity:  Normal |   Resolution:
 Keywords:  oracle | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Mariusz Felisiak):

 * keywords:   => oracle
 * status:  closed => new
 * resolution:  duplicate =>
 * stage:  Unreviewed => Accepted


Comment:

 > Do you think an additional test specifically targeting ManyToManyField
 relations would add any value?

 Yes it is. I noticed that it doesn't work on Oracle, see
 [https://github.com/django/django/pull/14809 PR].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3663ca003ef2269ce66afa295b2458bf%40djangoproject.com.