Re: [Django] #11764: Bugfix: typo with avoid.update(..) in db/models/sql/compiler.py:SQLCompiler:fill_related_selections

[Django]

#11764: Bugfix: typo with avoid.update(..) in
db/models/sql/compiler.py:SQLCompiler:fill_related_selections
---+
  Reporter:  aurelio   | Owner:  ramiro
Status:  assigned  | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by wogan):

  * stage:  Accepted => Ready for checkin
  * milestone:  1.3 => 1.2

Comment:

 Updated the patch, made a minor change to the test.

 I could successfully run the test (failing appropriately when the patch is
 not applied).

 Is it possible to get this in for 1.2?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11764: Bugfix: typo with avoid.update(..) in db/models/sql/compiler.py:SQLCompiler:fill_related_selections

[Django]

#11764: Bugfix: typo with avoid.update(..) in
db/models/sql/compiler.py:SQLCompiler:fill_related_selections
---+
  Reporter:  aurelio   | Owner:  ramiro
Status:  assigned  | Milestone:  1.3   
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * milestone:  1.2 => 1.3

Comment:

 Not critical for 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11764: Bugfix: typo with avoid.update(..) in db/models/sql/compiler.py:SQLCompiler:fill_related_selections

[Django]

#11764: Bugfix: typo with avoid.update(..) in
db/models/sql/compiler.py:SQLCompiler:fill_related_selections
---+
  Reporter:  aurelio   | Owner:  ramiro
Status:  assigned  | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by Alex):

  * stage:  Ready for checkin => Accepted

Comment:

 Moving off of RFC since ramiro notes that we can longer reproduce this :/

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11764: Bugfix: typo with avoid.update(..) in db/models/sql/compiler.py:SQLCompiler:fill_related_selections

[Django]

#11764: Bugfix: typo with avoid.update(..) in
db/models/sql/compiler.py:SQLCompiler:fill_related_selections
---+
  Reporter:  aurelio   | Owner:  ramiro
Status:  assigned  | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by ramiro):

 Replying to [comment:3 wogan]:
 > Updated patch as the typo had moved from
 [source:django/trunk/django/db/models/sql/query.py query.py] to
 [source:django/trunk/django/db/models/sql/compiler.py compiler.py].

 Thanks for updating the patch. I had spotted the code move and implemented
 a simliar updating locally. Problem is that the regression test case I had
 added now pass with and without the fix applied. I ran the full Django
 test suite with code coverage analysis turned on and it shows that exact
 code path isn't exercised anymore.

 This means we need to update the test because the core committers won't
 get this change in without a regression test. But I don't know if it's
 possible at all.

 Sorry for not updating the ticket, I only made a comment about this on the
 `#django-dev` IRC channel.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11764: Bugfix: typo with avoid.update(..) in db/models/sql/compiler.py:SQLCompiler:fill_related_selections

[Django]

#11764: Bugfix: typo with avoid.update(..) in
db/models/sql/compiler.py:SQLCompiler:fill_related_selections
---+
  Reporter:  aurelio   | Owner:  ramiro
Status:  assigned  | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by wogan):

 * cc: dja...@wogan.id.au (added)
  * summary:  Bugfix: typo with avoid.update(..) in
  db/models/sql/query.py:BaseQuery:fill_related_selections
  => Bugfix: typo with avoid.update(..) in
  db/models/sql/compiler.py:SQLCompiler:fill_related_selections

Comment:

 Updated patch as the typo had moved from
 [source:django/trunk/django/db/models/sql/query.py query.py] to
 [source:django/trunk/django/db/models/sql/compiler.py compiler.py].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.