Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2021-07-05 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
-+-
 Reporter:  harm |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Uncategorized|  Version:  1.2-beta
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  session accessed | Triage Stage:
  vary cookie|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jerome Leclanche):

 Replying to [comment:14 Aymeric Augustin]:
 > If you're using `i18n_patterns` (introduced in Django 1.4) and the URL
 contains a language prefix, `get_language_from_request` will select the
 active language without reading the session.
 >
 > So, in practice, this is fixed.

 @Aymeric Augustin -- I believe there's an unhandled edge case if
 i18n_patterns receives ``prefix_default_language=False``: accept-language
 will still be set, even though the language of the page in question is
 static. I can't investigate more right now, and I know that
 ``prefix_default_language`` is fairly new, but leaving this here for
 posterity.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.562029679d9ff6df41bf04d6e5e02d7e%40djangoproject.com.


Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2015-10-01 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
-+-
 Reporter:  harm |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Uncategorized|  Version:  1.2-beta
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  session accessed | Triage Stage:
  vary cookie|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 Do you have any ideas to address the issue? I haven't taken time to
 understand it but if you have a proposal, it's probably better to start a
 thread on the DevelopersMailingList as discussed above rather than comment
 on this old ticket which has been closed several times. Thanks.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.8b652b660501714299af515be1e50649%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2015-10-01 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
-+-
 Reporter:  harm |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Uncategorized|  Version:  1.2-beta
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  session accessed | Triage Stage:
  vary cookie|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by svleeuwen):

 I don't think this is fixed.

 For instance when using a CMS like FeinCMS you have to use LocalMiddleware
 but won't use i18n_patterns.

 There are likely more use cases where localisation is required but
 i18n_patterns won't be used.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.bd1ad35d709d2dca622c3a2a3fe52eef%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2013-01-20 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
-+-
 Reporter:  harm |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Uncategorized|  Version:  1.2-beta
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  session accessed | Triage Stage:
  vary cookie|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * type:   => Uncategorized
 * ui_ux:   => 0
 * resolution:  wontfix => fixed
 * severity:   => Normal
 * easy:   => 0


Comment:

 If you're using `i18n_patterns` (introduced in Django 1.4) and the URL
 contains a language prefix, `get_language_from_request` will select the
 active language without reading the session.

 So, in practice, this is fixed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-04-06 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody
  
Status:  closed | Milestone:
  
 Component:  Uncategorized  |   Version:  1.2-beta  
  
Resolution:  wontfix|  Keywords:  session accessed vary 
cookie
 Stage:  Unreviewed | Has_patch:  0 
  
Needs_docs:  0  |   Needs_tests:  0 
  
Needs_better_patch:  0  |  
+---
Changes (by gabrielhurley):

  * keywords:  => session accessed vary cookie

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-28 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody  
Status:  closed | Milestone:  
 Component:  Uncategorized  |   Version:  1.2-beta
Resolution:  wontfix|  Keywords:  
 Stage:  Unreviewed | Has_patch:  0   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Comment (by harm):

 http://groups.google.com/group/django-
 developers/browse_thread/thread/4ae62c8d59671226

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-26 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody  
Status:  closed | Milestone:  
 Component:  Uncategorized  |   Version:  1.2-beta
Resolution:  wontfix|  Keywords:  
 Stage:  Unreviewed | Has_patch:  0   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Comment (by russellm):

 In short, no, I don't have any ideas. If you want to follow this up, I
 suggest starting a thread in django-developers. It's a non-trivial topic,
 and it's going to require a lot of thought and discussion if we're going
 to get it right. Trac isn't the best place to have this discussion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-26 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody  
Status:  closed | Milestone:  
 Component:  Uncategorized  |   Version:  1.2-beta
Resolution:  wontfix|  Keywords:  
 Stage:  Unreviewed | Has_patch:  0   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Comment (by harm):

 Yeah, I get (now) that this can't be solved for views that actually
 require translation.

 Its rather unfortunate though , that using i18n renders the '''complete'''
 site 0% cachable. (except  media/) Even parts of the site that are not
 related to i18n at all.
 I really feel this is an undesired situation

 I still wonder if adding some settings/parameters. to LocaleMiddleWare can
 improve the current situation.
 For example:  the ability to exclude/include apps (by means of urls)  from
 LocaleMiddleware. this prevents LocaleMiddleware from touching the session
 for urls where you as site builder you don't want translations.

 That would give the freedom to explicitly control (if desired) what parts
 of your site you want to i18n enable. (or the reverse which parts of you
 site you want to exclude). All possible with backwards compatibility.

 Any thoughts ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-26 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody  
Status:  closed | Milestone:  
 Component:  Uncategorized  |   Version:  1.2-beta
Resolution:  wontfix|  Keywords:  
 Stage:  Unreviewed | Has_patch:  0   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by russellm):

  * status:  reopened => closed
  * resolution:  => wontfix

Comment:

 Replying to [comment:8 harm]:
 > Should we allow LocalMiddleware to read out a session via a backdoor?
 (because the LocalMiddleware _knows_ that it only looks at the language,
 and that it adds the correct Vary: Content-Language  anyway. So that as
 fas as LocalMiddleware knows, Vary: cookie should not be set.

 Incorrect. It would be true if Django were *only* using the Accept-
 Language header to choose the page language. However, the session *is*
 being read to determine the site language, and a user can modify the site
 language using the i18n views. As a result, this means that Vary: Cookie
 is actually correct. The page *is* varying based on what is in the cookie,
 and as a result, it isn't cacheable independent of the cookie.

 I completely agree that this is annoying from a page caching perspective,
 but I'm not sure I see what we can do about it, other than changing the
 way i18n works so that it doesn't have any dependency on the cookie -- but
 this would mean (1) breaking backwards compatibility, and/or (2) removing
 the ability for users to select their language.

 Regrettably, I'm going to close this wontfix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-26 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody  
Status:  reopened   | Milestone:  
 Component:  Uncategorized  |   Version:  1.2-beta
Resolution: |  Keywords:  
 Stage:  Unreviewed | Has_patch:  0   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Comment (by harm):

 I can't test trunk right now.

 But reading [12546]  and [12624] i don't think they are related. They
 touch django caching stuff. Not the logic when to add Vary: headers

 Thinking about this problem more, its actually quite hard to get this
 right.  Where else as from the session can LocaleMiddleware his info ?
 With the current code ,if it reads the session, than automatically
 session.accessed gets set. If session.accessed is set -> Vary: Cookie is
 added.

 Should we allow LocalMiddleware to read out a session via a backdoor?
 (because the LocalMiddleware _knows_ that it only looks at the language,
 and that it adds the correct Vary: Content-Language  anyway. So that as
 fas as LocalMiddleware knows, Vary: cookie should not be set.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-26 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody  
Status:  reopened   | Milestone:  
 Component:  Uncategorized  |   Version:  1.2-beta
Resolution: |  Keywords:  
 Stage:  Unreviewed | Has_patch:  0   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Comment (by russellm):

 Ok - I can now reproduce. The problem was that I had USE_I18N=False in my
 settings, which meant that the dummy translation functions were being
 used.

 I can verify this also occurs on 1.1, so it isn't a recent change.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-26 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody  
Status:  reopened   | Milestone:  
 Component:  Uncategorized  |   Version:  1.2-beta
Resolution: |  Keywords:  
 Stage:  Unreviewed | Has_patch:  0   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Comment (by ramiro):

 I don't have time to set up an environment to tests this right now, but
 just wanted to point that 1.2-beta 1 got bundled on Feb 06 and the [12546]
 and [12624] changes were committed after that (Feb 23 and March 01
 respectively). If you are effectively using the beta1 tarball, can you
 retry with a newer SVN checkout?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-26 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody  
Status:  reopened   | Milestone:  
 Component:  Uncategorized  |   Version:  1.2-beta
Resolution: |  Keywords:  
 Stage:  Unreviewed | Has_patch:  0   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by harm):

  * status:  closed => reopened
  * resolution:  worksforme =>

Comment:

 I made a copy/past error in the testcase {{{ tests.py }}}  above. (missing
 {{{ vary = response.get('vary',None) }}} )

 {{{
 #!python
 def test_hi(self):
 response = self.client.get('/hi')

 vary = response.get('vary',None)
 if vary:
 print "Vary: %s" % (vary)
 else:
 print " - no vary headers "

 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-26 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody  
Status:  closed | Milestone:  
 Component:  Uncategorized  |   Version:  1.2-beta
Resolution:  worksforme |  Keywords:  
 Stage:  Unreviewed | Has_patch:  0   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Comment (by harm):

 here is a reproducible testcase.

 Start with a new project
 all default, no custom context processors, no custom middleware

 views.y
 {{{
 #!python
 from django.http import HttpResponse
 def hi(request):
  return HttpResponse("hi")
 }}}

 tests.py
 {{{
 #!python
 from django.test import TestCase
 from views import hi

 class SimpleTest(TestCase):
 def test_hi(self):
 response = self.client.get('/hi')
 vary = response.get('vary',None)
   if vary:
  print "Vary: %s" % (vary)
   else:
  print " - no vary headers "
 }}}

 without {{{ django.middleware.locale.LocaleMiddleware }}} issue  {{{
 python manage.py test }}}. The result is
 {{{
 - no vary headers
 }}}


 add   {{{'django.middleware.locale.LocaleMiddleware'}}}  to the
 {{{MIDDLEWARE_CLASSES}}} in {{{settings.py}}} and issue {{{ python
 manage.py test }}} again. Now you get the incorrect result. A Cookie is
 added
 {{{
 Vary: Accept-Language, Cookie
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-26 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody  
Status:  closed | Milestone:  
 Component:  Uncategorized  |   Version:  1.2-beta
Resolution:  worksforme |  Keywords:  
 Stage:  Unreviewed | Has_patch:  0   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by harm):

  * version:  1.1-beta-1 => 1.2-beta

Comment:

 I selected the incorrect version -> 1.2-beta

 The problem is that the LocaleMiddleware reads the request.session.  The
 Session Middleware later detects that the session was touched
 (session.accessed) and appends the Vary: Cookie header.

 {{{
 #!python
 class LocaleMiddleware(object):
  def process_request(self, request):
 language = translation.get_language_from_request(request)   <-
 accesses session.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-26 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody
Status:  closed | Milestone:
 Component:  Uncategorized  |   Version:  1.1-beta-1
Resolution:  worksforme |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by russellm):

  * status:  new => closed
  * resolution:  => worksforme

Comment:

 I can't reproduce this. According to my testing, the locale middleware
 adds the "Vary: Accept-Language" and "Content-Language" headers. From a
 visual inspection of the code, I can't see anything that would modify the
 Cookie header.

 If you insist this is happening, you'll need to provide a specific example
 of a view and configuaration that doesn't set Vary: Cookie until you turn
 on the Locale middleware.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-26 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
+---
  Reporter:  harm   | Owner:  nobody
Status:  new| Milestone:
 Component:  Uncategorized  |   Version:  1.1-beta-1
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by ramiro):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 harm,

 Are you really reporting this against 1.1-beta1?. If the answer is no, we
 need the exact release/beta/SVN revision at which you are seeing this.

 #6552 was about a context processor not a middleware. Are you sure you are
 not using the same custom context processor that led you to erroneously
 reopen that ticket?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



[Django] #13217: LocaleMiddleware breaks caching. (Vary: Cookie)

2010-03-26 Thread Django
#13217: LocaleMiddleware  breaks caching.  (Vary: Cookie)
---+
 Reporter:  harm   |   Owner:  nobody
   Status:  new|   Milestone:
Component:  Uncategorized  | Version:  1.1-beta-1
 Keywords: |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 Enabling {{{ django.middleware.locale.LocaleMiddleware }}}  causes that
 django adds a 'Vary: Cookie' header to every reponse.

 The net effects of responses with Vary: Cookie, is that they are not
 properly cached by reverse proxies, and worse, never cached by end
 browsers. (Browser may cache requests with the same cookie, but in reality
 NO browser is implemented like that,

 And this happens for _every_ response

 Is there a way to achieve this without always touching the session ? So
 that we just get a {{{ Vary : Accept-Language }}}

 similar tickets with other middleware #6552

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.