Re: [Django] #14355: "readonly" fields don't display their "help_text" in admin

[Django]

#14355: "readonly" fields don't display their "help_text" in admin
+---
   Reporter:  jester| Owner:  wamberg   

 Status:  assigned  | Milestone:  1.3   

  Component:  django.contrib.admin  |   Version:  1.2   

 Resolution:|  Keywords:  readonly 
help_text
   Triage Stage:  Ready for checkin | Has patch:  1 

Needs documentation:  0 |   Needs tests:  0 

Patch needs improvement:  0 |  
+---
Changes (by julien):

  * needs_better_patch:  1 => 0
  * needs_tests:  1 => 0
  * stage:  Accepted => Ready for checkin


Comment:

 Thank you alexbmeng, subsume and wamberg. Your latest patch looked good.
 I've just removed a line (`self.help_text = ...`) which was unnecessary
 and wrote some slightly more thorough tests. I believe this is RFC now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14355: "readonly" fields don't display their "help_text" in admin

[Django]

#14355: "readonly" fields don't display their "help_text" in admin
---+
  Reporter:  jester| Owner:  wamberg   
Status:  assigned  | Milestone:  1.3   
 Component:  django.contrib.admin  |   Version:  1.2   
Resolution:|  Keywords:  readonly help_text
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Changes (by wamberg):

  * owner:  nobody => wamberg
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14355: "readonly" fields don't display their "help_text" in admin

[Django]

#14355: "readonly" fields don't display their "help_text" in admin
---+
  Reporter:  jester| Owner:  nobody
Status:  new   | Milestone:  1.3   
 Component:  django.contrib.admin  |   Version:  1.2   
Resolution:|  Keywords:  readonly help_text
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Changes (by nessita):

  * owner:  nessita => nobody

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14355: "readonly" fields don't display their "help_text" in admin

[Django]

#14355: "readonly" fields don't display their "help_text" in admin
---+
  Reporter:  jester| Owner:  nessita   
Status:  new   | Milestone:  1.3   
 Component:  django.contrib.admin  |   Version:  1.2   
Resolution:|  Keywords:  readonly help_text
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Changes (by nessita):

  * needs_better_patch:  0 => 1
  * stage:  Unreviewed => Accepted
  * needs_tests:  0 => 1
  * milestone:  => 1.3

Comment:

 I confirmed that the help text is not being shown in the admin add/change
 form, for a read only field.

 The patch attached by the reporter does not include tests for this fix, so
 I'm setting this bug properties accordingly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14355: "readonly" fields don't display their "help_text" in admin

[Django]

#14355: "readonly" fields don't display their "help_text" in admin
---+
  Reporter:  jester| Owner:  nessita   
Status:  new   | Milestone:
 Component:  django.contrib.admin  |   Version:  1.2   
Resolution:|  Keywords:  readonly help_text
 Stage:  Unreviewed| Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by nessita):

  * owner:  nobody => nessita

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14355: "readonly" fields don't display their "help_text" in admin

[Django]

#14355: "readonly" fields don't display their "help_text" in admin
---+
  Reporter:  jester| Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.admin  |   Version:  1.2   
Resolution:|  Keywords:  readonly help_text
 Stage:  Unreviewed| Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by anonymous):

  * needs_better_patch:  => 0
  * has_patch:  0 => 1
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14355: "readonly" fields don't display their "help_text" in admin

[Django]

#14355: "readonly" fields don't display their "help_text" in admin
--+-
 Reporter:  jester|   Owner:  nobody
   Status:  new   |   Milestone:
Component:  django.contrib.admin  | Version:  1.2   
 Keywords:  readonly help_text|   Stage:  Unreviewed
Has_patch:  0 |  
--+-
 == Steps to reproduce ==

 1. Define a Model, whose field(s) specify `help_text`, e.g.:

 {{{
 class MyModel(Model):
 my_regular_field = CharField(max_length=255, help_text="this is my
 regular field")
 my_readonly_field = CharField(max_length=255, help_text="this is my
 readonly field")
 }}}

 2. Define a ModelAdmin for your Model, including one of its fields in
 `readonly_fields`, e.g.:

 {{{
 class MyModelAdmin(ModelAdmin):
 fields = 'my_regular_field', 'my_readonly_field'
 readonly_fields = 'my_readonly_field',
 admin.site.register(MyModel, MyModelAdmin)
 }}}

 In the object view/edit screen, "My regular field" will have help text,
 "My readonly field" will not.

 == Expectation ==

 The expected behavior is that readonly fields will work just like
 "regular" fields, except their widget will be their plain value rather
 than a form element -- i.e., any string specified as "help_text" should be
 displayed after the field.

 == Uneducated guesswork ==

 I don't dig very deep into the workings of the admin very often, and so,
 obviously, what I'm about to say may be entirely unhelpful.  However, it
 appears that `helpers.AdminReadonlyField` constructs a limited, faux field
 object, a dict, at `self.field`, rather than assign the appropriate
 BoundField instance.  This is perhaps because readonly fields are not
 available to it in `self.form.fields`.  In the template,
 `field.field.field.help_text` fails, as the dict does not contain
 "help_text", (and I'm not sure where AdminReadonlyField would get it,
 anyway).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.