Re: [Django] #15573: runtests.py sets incorrect SITE_ID when using Oracle

[Django]

#15573: runtests.py sets incorrect SITE_ID when using Oracle
---+
 Reporter:  ikelly |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords:  oracle site_id | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |
---+

Comment (by Tim Graham ):

 In [changeset:"1f98ec2e53e4636863396ab54f671f4546f9ba4c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="1f98ec2e53e4636863396ab54f671f4546f9ba4c"
 Fixed #23929 -- Added more tests for create_default_site.

 Refs: #15346, #15573, #16353, #16828.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a958e4d96b3510aedde6fea1ea675df9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #15573: runtests.py sets incorrect SITE_ID when using Oracle

[Django]

#15573: runtests.py sets incorrect SITE_ID when using Oracle
---+
 Reporter:  ikelly |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  SVN
 Severity:  Normal |   Resolution:  fixed
 Keywords:  oracle site_id | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |
---+

Comment (by loewis):

 In [16950]:
 {{{
 #!CommitTicketReference repository="" revision="16950"
 Merged revisions
 
16743,16745,16747-16750,16752-16754,16756-16760,16770,16773-16800,16802-16804,16806,16808,16811,16813,16815,16817-16826,16829-16833,16835-16836,16838-16843,16845-16858,16860-16866,16868,16871-16877,16882-16890,16893-16947
 via svnmerge from
 https://code.djangoproject.com/svn/django/trunk

 
   r16743 | gabrielhurley | 2011-09-09 23:36:58 +0200 (Fr, 09 Sep 2011) | 2
 lines

   Fixed #16791 -- Updated a broken URL in the README file. Thanks to
 paulcwatts for the report and patch.
 
   r16745 | Alex | 2011-09-09 23:45:58 +0200 (Fr, 09 Sep 2011) | 1 line

   Switch to using explicit new-style division behavior, rather than
 relying on teh classic behavior.
 
   r16747 | SmileyChris | 2011-09-10 00:32:38 +0200 (Sa, 10 Sep 2011) | 1
 line

   Fix and test for cleaning a non-string value in a URLField
 
   r16748 | gabrielhurley | 2011-09-10 00:33:28 +0200 (Sa, 10 Sep 2011) | 2
 lines

   Fixed #16786 -- Minor cleanups in the memcached section of the caching
 topic guide. Thanks to jamesp for the report and patch.
 
   r16749 | jbronn | 2011-09-10 00:34:23 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #16408 -- Fixed conversion of dates, and other problems with the
 SpatiaLite backend.
 
   r16750 | jbronn | 2011-09-10 00:47:18 +0200 (Sa, 10 Sep 2011) | 1 line

   Removed extra call to `syncdb` that slipped in with r16749.
 
   r16752 | SmileyChris | 2011-09-10 00:57:12 +0200 (Sa, 10 Sep 2011) | 1
 line

   Fixes #16664 -- URLField's to_python method fails with ValueError on
 some urls on python 2.7. Based on patch by zigzag.
 
   r16753 | russellm | 2011-09-10 01:02:33 +0200 (Sa, 10 Sep 2011) | 1 line

   Added two pointless query repeats to work around a known issue with
 MySQL that was causing failures in our test suite.
 
   r16754 | gabrielhurley | 2011-09-10 01:25:48 +0200 (Sa, 10 Sep 2011) | 2
 lines

   Fixed #16782 -- Corrected a broken cross-reference to the database
 engine setting in the tutorial. Thanks to mjumbewu for the report and
 patch.
 
   r16756 | kmtracey | 2011-09-10 02:05:48 +0200 (Sa, 10 Sep 2011) | 2
 lines

   Fixed #15722: ensure formsets evaluate to True even if they have no
 forms. Thanks mlavin.
 
   r16757 | jbronn | 2011-09-10 02:29:34 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #13670 -- Comparisons with the spatial adapter won't blow up in
 some corner cases.  Thanks, milosu for the bug report and jpaulett for the
 patch.
 
   r16758 | russellm | 2011-09-10 02:46:38 +0200 (Sa, 10 Sep 2011) | 1 line

   Added protection against spoofing of X_FORWARDED_HOST headers. A
 security announcement will be made shortly.
 
   r16759 | russellm | 2011-09-10 02:46:48 +0200 (Sa, 10 Sep 2011) | 1 line

   Corrected an issue which could allow attackers to manipulate session
 data using the cache. A security announcement will be made shortly.
 
   r16760 | russellm | 2011-09-10 02:47:00 +0200 (Sa, 10 Sep 2011) | 1 line

   Altered the behavior of URLField to avoid a potential DOS vector, and to
 avoid potential leakage of local filesystem data. A security announcement
 will be made shortly.
 
   r16770 | Alex | 2011-09-10 03:53:56 +0200 (Sa, 10 Sep 2011) | 1 line

   Make ``Formset.__getitem__`` O(1), rather than O(n).  If you override
 ``__iter__`` you now need to also override ``__getitem__`` for consistant
 behavior.  Thanks to Carl and Russ for the review.
 
   r16773 | Alex | 2011-09-10 04:42:05 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #11404.  Added ``FormSet.has_changed``, for consistancy with
 ``Form.has_changed``. Thanks to michelts for the patch.
 
   r16774 | Alex | 2011-09-10 04:52:37 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #16793. Added more cross referencing to the load tag's
 documentation.  Thanks to bluejeansummer for the patch.
 
   r16775 | jbronn | 2011-09-10 05:04:30 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #16790 -- Modified the geographic admin to work after r16594.
 Thanks, jdiego, for the bug report and patch.
 
   r16776 | carljm | 2011-09-10 05:26:13 +0200 (Sa, 10 Sep 2011) | 1 line

 

Re: [Django] #15573: runtests.py sets incorrect SITE_ID when using Oracle

[Django]

#15573: runtests.py sets incorrect SITE_ID when using Oracle
+---
   Reporter:  ikelly|  Owner:  nobody
   Type:  Bug   | Status:  closed
  Milestone:|  Component:  Testing framework
Version:  SVN   |   Severity:  Normal
 Resolution:  fixed |   Keywords:  oracle site_id
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
+---

Comment (by carljm):

 In [16869]:
 {{{
 #!CommitTicketReference repository="" revision="16869"
 [1.3.X] Fixed #16353 -- don't try to create Site objects on all databases.
 Refs #15573, #15346. Thanks Aymeric Augustin for the report and the patch.

 Backport of r16868 in trunk.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15573: runtests.py sets incorrect SITE_ID when using Oracle

[Django]

#15573: runtests.py sets incorrect SITE_ID when using Oracle
+---
   Reporter:  ikelly|  Owner:  nobody
   Type:  Bug   | Status:  closed
  Milestone:|  Component:  Testing framework
Version:  SVN   |   Severity:  Normal
 Resolution:  fixed |   Keywords:  oracle site_id
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
+---

Comment (by carljm):

 In [16868]:
 {{{
 #!CommitTicketReference repository="" revision="16868"
 Fixed #16353 -- don't try to create Site objects on all databases. Refs
 #15573, #15346. Thanks Aymeric Augustin for the report and the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15573: runtests.py sets incorrect SITE_ID when using Oracle

[Django]

#15573: runtests.py sets incorrect SITE_ID when using Oracle
+---
   Reporter:  ikelly|  Owner:  nobody
   Type:  Bug   | Status:  closed
  Milestone:|  Component:  Testing framework
Version:  SVN   |   Severity:  Normal
 Resolution:  fixed |   Keywords:  oracle site_id
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
+---
Changes (by carljm):

 * easy:   => 0


Comment:

 This change broke running of tests in a project without contrib.sites
 installed (#15850), due to the underlying issue #15866. I've fixed #15866
 in trunk, but wasn't planning to backport to 1.3.X for stability reasons,
 since #15866 itself is not a regression and the fix changes the behavior
 of (internal and undocumented) methods in a backwards-incompatible way.

 However, #15850 is a significant regression and still needs fixing in
 1.3.X. I think the least-invasive approach there will be to modify the
 change made in r16028 to check INSTALLED_APPS for django.contrib.sites
 rather than using the return value of get_model. I don't feel comfortable
 making that change myself, though, since I don't have Oracle available to
 ensure that the fix still works for the original purpose.

 Ian, would you be able to make that change in 1.3.X?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15573: runtests.py sets incorrect SITE_ID when using Oracle

[Django]

#15573: runtests.py sets incorrect SITE_ID when using Oracle
-+-
   Reporter:  ikelly |Owner:  nobody
 Status:  new|Milestone:
  Component:  Testing|  Version:  SVN
  framework  | Keywords:  oracle site_id
 Resolution: |Has patch:  0
   Triage Stage:  Accepted   |  Needs tests:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-

Comment (by ikelly):

 A related problem occurs elsewhere: the fixtures for the flatpages tests
 use a hard-coded site id of 1.  Maybe the best way to fix this is going to
 be to find a way to coerce the default site id to be 1 when running the
 test suite.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15573: runtests.py sets incorrect SITE_ID when using Oracle

[Django]

#15573: runtests.py sets incorrect SITE_ID when using Oracle
-+-
   Reporter:  ikelly |Owner:  nobody
 Status:  new|Milestone:
  Component:  Testing|  Version:  SVN
  framework  | Keywords:  oracle site_id
 Resolution: |Has patch:  0
   Triage Stage:  Accepted   |  Needs tests:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by russellm):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15573: runtests.py sets incorrect SITE_ID when using Oracle

[Django]

#15573: runtests.py sets incorrect SITE_ID when using Oracle
-+-
   Reporter:  ikelly |Owner:  nobody
 Status:  new|Milestone:
  Component:  Testing|  Version:  SVN
  framework  | Keywords:  oracle site_id
 Resolution: |Has patch:  0
   Triage Stage: |  Needs tests:  0
  Unreviewed |
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by ikelly):

 * needs_docs:   => 0
 * version:  1.2 => SVN
 * needs_tests:   => 0
 * needs_better_patch:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15573: runtests.py sets incorrect SITE_ID when using Oracle

[Django]

#15573: runtests.py sets incorrect SITE_ID when using Oracle
---+---
 Reporter:  ikelly | Owner:  nobody
   Status:  new| Milestone:
Component:  Testing framework  |   Version:  1.2
 Keywords:  oracle site_id |  Triage Stage:  Unreviewed
Has patch:  0  |
---+---
 Running the test suite under Oracle currently generates a large number of
 errors that look like this:

 {{{
 ==
 ERROR: test_shortcut_view
 (django.contrib.contenttypes.tests.ContentTypesTests)
 --
 Traceback (most recent call last):
   File "C:\Django\django.trunk\django\contrib\contenttypes\tests.py", line
 66, in test_shortcut_view
 current_site = Site.objects.get_current()
   File "C:\Django\django.trunk\django\contrib\sites\models.py", line 26,
 in get_current
 current_site = self.get(pk=sid)
   File "C:\Django\django.trunk\django\db\models\manager.py", line 132, in
 get
 return self.get_query_set().get(*args, **kwargs)
   File "C:\Django\django.trunk\django\db\models\query.py", line 349, in
 get
 % self.model._meta.object_name)
 DoesNotExist: Site matching query does not exist.

 --
 }}}

 This seems to be a result of r14537.  Since the test setup does a syncdb
 followed by a flush on each database, the default Site object gets created
 twice.  Since the sequence reset no longer decreases the sequence value,
 the second Site object created, the one that sticks around and gets used
 for the tests, has an id of 2 instead of 1.  However, runtests.py forces
 the SITE_ID setting to be 1.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.