Re: [Django] #18347: Unit tests contain raw inserts to an identity column

[Django]

#18347: Unit tests contain raw inserts to an identity column
-+-
 Reporter:  manfre   |Owner:  akaariai
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  identity |  checkin
  insert,mssql   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-

Comment (by Preston Holmes ):

 In [changeset:"9979c12f4a13a707fbfdd01f1694864fa53b6e6a"]:
 {{{
 #!CommitTicketReference repository=""
 revision="9979c12f4a13a707fbfdd01f1694864fa53b6e6a"
 Fixed #18347 -- Removed autofield raw SQL inserts from tests
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18347: Unit tests contain raw inserts to an identity column

[Django]

#18347: Unit tests contain raw inserts to an identity column
-+-
 Reporter:  manfre   |Owner:  akaariai
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  identity |  checkin
  insert,mssql   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-

Comment (by Anssi Kääriäinen ):

 In [changeset:"a1fd9555f2cc32d10cdbc4aa71f86bac50ffd9c1"]:
 {{{
 #!CommitTicketReference repository=""
 revision="a1fd9555f2cc32d10cdbc4aa71f86bac50ffd9c1"
 [1.5.x] Fixed #18347 -- Removed autofield raw SQL inserts from tests

 Backpatch of 71e14cf3aa024496adcb23e83ddf13a7c5ddeb32
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18347: Unit tests contain raw inserts to an identity column

[Django]

#18347: Unit tests contain raw inserts to an identity column
-+-
 Reporter:  manfre   |Owner:  akaariai
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  identity |  checkin
  insert,mssql   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by Anssi Kääriäinen ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"71e14cf3aa024496adcb23e83ddf13a7c5ddeb32"]:
 {{{
 #!CommitTicketReference repository=""
 revision="71e14cf3aa024496adcb23e83ddf13a7c5ddeb32"
 Fixed #18347 -- Removed autofield raw SQL inserts from tests
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18347: Unit tests contain raw inserts to an identity column

[Django]

#18347: Unit tests contain raw inserts to an identity column
-+-
 Reporter:  manfre   |Owner:  akaariai
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  identity |  checkin
  insert,mssql   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-

Comment (by aaugustin):

 The patch looks good to me too.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18347: Unit tests contain raw inserts to an identity column

[Django]

#18347: Unit tests contain raw inserts to an identity column
-+-
 Reporter:  manfre   |Owner:  akaariai
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  identity |  checkin
  insert,mssql   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by Architekt):

 * stage:  Accepted => Ready for checkin


Comment:

 Patch from akaariai works, tests pass also for PostgreSQL and SQLite3 (if
 test is not skipped).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18347: Unit tests contain raw inserts to an identity column

[Django]

#18347: Unit tests contain raw inserts to an identity column
-+-
 Reporter:  manfre   |Owner:  akaariai
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  identity |  Needs documentation:  0
  insert,mssql   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by manfre):

 * owner:  manfre => akaariai


Comment:

 Passing ownership because your patch works for django-mssql

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18347: Unit tests contain raw inserts to an identity column

[Django]

#18347: Unit tests contain raw inserts to an identity column
-+-
 Reporter:  manfre   |Owner:  manfre
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  identity |  Needs documentation:  0
  insert,mssql   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by manfre):

 Tests pass with your patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18347: Unit tests contain raw inserts to an identity column

[Django]

#18347: Unit tests contain raw inserts to an identity column
-+-
 Reporter:  manfre   |Owner:  manfre
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  identity |  Needs documentation:  0
  insert,mssql   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by akaariai):

 An alternate patch which just removes inserts into the primary key field.
 Would this work for mssql? If not, then adding a new model without
 autofield primary key is still one possibility.

 https://github.com/akaariai/django/tree/ticket_18347

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18347: Unit tests contain raw inserts to an identity column

[Django]

#18347: Unit tests contain raw inserts to an identity column
-+-
 Reporter:  manfre   |Owner:  manfre
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  identity |  Needs documentation:  0
  insert,mssql   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by aaugustin):

 * stage:  Unreviewed => Accepted


Comment:

 The patch looks pretty good to me.

 However, wouldn't it be just as easy to not include the primary key in the
 inserted values in these two tests? I wouldn't like to expand the database
 backend API more than necessary.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18347: Unit tests contain raw inserts to an identity column

[Django]

#18347: Unit tests contain raw inserts to an identity column
-+-
 Reporter:  manfre   |Owner:  manfre
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  identity |  Unreviewed
  insert,mssql   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by manfre):

 * needs_better_patch:   => 0
 * has_patch:  0 => 1
 * easy:  0 => 1
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Pull request
 
https://github.com/manfre/django/commit/06d8aee7edc1ff2862ad8c64d1097090df46fdfa

 {{{
 Added enable_identity_insert, disable_identity_insert, and
 contextmanager identity_insert_enabled to DatabaseOperations for
 database backends that need to take special actions to allow
 identity inserts.

 All raw insert statements that set a value in to the identity field
 should include these guards to allow all database backends to
 function.
 }}}

 Implementation followed the paradigm used by enable/disable constraints.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #18347: Unit tests contain raw inserts to an identity column

[Django]

#18347: Unit tests contain raw inserts to an identity column
--+
 Reporter:  manfre|  Owner:  manfre
 Type:  Bug   | Status:  new
Component:  Database layer (models, ORM)  |Version:  master
 Severity:  Normal|   Keywords:  identity
 Triage Stage:  Unreviewed|  insert,mssql
Easy pickings:  0 |  Has patch:  0
  |  UI/UX:  0
--+
 Two unit tests in transactions_regress.TestTransactionClosing fail for
 MSSQL because of raw inserts in to an identity column. MSSQL and
 potentially other 3rd party backends require actions to allow this type of
 insert.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.