Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  closed
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"4965a774074780f3e4858bcc975476f71edf2c2c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="4965a774074780f3e4858bcc975476f71edf2c2c"
 Removed PIL compatability layer per deprecation timeline.

 refs #19934.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c504434d742f08167035ed585dbc06ad%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  closed
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Andrew Godwin ):

 In [changeset:"e9b703f5a5e5de68a28abd2e6651e6100b0c6b49"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e9b703f5a5e5de68a28abd2e6651e6100b0c6b49"
 Correctly format missing Pillow/PIL exceptions messages. refs #19934
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.dabe7b0667c0c6fdf56d7b21dde103b2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  closed
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"e7a6eaf5fee9c5854e0d2d86f21132ac4a1415f6"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e7a6eaf5fee9c5854e0d2d86f21132ac4a1415f6"
 [1.6.x] Correctly format missing Pillow/PIL exceptions messages. refs
 #19934

 Backport of b9590a6935 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f3c24e37eff4081c0326e4325e1880c7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  closed
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"b9590a69357917a3dbf2c7234774803bd43767ef"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b9590a69357917a3dbf2c7234774803bd43767ef"
 Correctly format missing Pillow/PIL exceptions messages. refs #19934
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.14c00dca1ecfaa84c10a9e2443b91439%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  closed
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"b82a2c41387648f81387b1e03371331db3630269"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b82a2c41387648f81387b1e03371331db3630269"
 Merge pull request #1349 from chrismedrela/ticket19934-comment

 Added clarification comments to django.utils.image; refs #19934
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7fdb462377f5f48d90c1bd4a01e45cdf%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  closed
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Christopher Medrela ):

 In [changeset:"b4c61c2665c0aa06dcdc4f823be03f23b9696408"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b4c61c2665c0aa06dcdc4f823be03f23b9696408"
 Added clarification comments to django.utils.image; refs #19934
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f79b525fdce5b678fac348987fc119ca%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  closed
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by chrismedrela):

 @daniellindsley - Thank you for your answer. I created a pull request
 clarifying the situation https://github.com/django/django/pull/1349.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1caa28f9468d1d7246a395c9cbe9d5a1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  closed
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by daniellindsley):

 @chrismedrela - I'm not aware of a way that import can fail without a
 completely broken Pillow/PIL install (missing Python modules, not just a
 missing C compiler). It was also directly moved from
 
https://github.com/django/django/commit/33793f7c3edd8ff144ff2e9434367267c20af26a#L0L38,
 so it would've been failing that way before. AFAICT, that shouldn't ever
 fail, and if it does, we should be raising an {{{ ImportError }}} so the
 user knows what's wrong.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.eb653448ab1f72a16ca9dc04c5980e37%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  closed
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by chrismedrela):

 * cc: chrismedrela (added)


Comment:

 I'm working on my GSoC project and I need to be sure what kind of
 exceptions may be raised while importing `django.utils.image`. Is it
 possible to end with an `ImportError`? There is one import statement which
 is not wrapped in try-except clause
 
https://github.com/django/django/commit/33793f7c3edd8ff144ff2e9434367267c20af26a#L3R133.
 If it may fail, we should wrap it in try-except blocks and reraise as an
 `ImproprelyConfigured` exception. If not, then adding a comment why it
 can't happen would clarify the situation.

 For me it looks like it can't happen. If line 95 or 99 succeed then
 respectively line 131 or 133 must succeed too; otherwise an
 `ImproperlyConfigured` exception is being raised (line 102). Nonetheless,
 I'm not sure and I would like to hear your opinion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b3cfdf556dcaac62ebf0ff3d8a68860e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  closed
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Daniel Lindsley ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"33793f7c3edd8ff144ff2e9434367267c20af26a"]:
 {{{
 #!CommitTicketReference repository=""
 revision="33793f7c3edd8ff144ff2e9434367267c20af26a"
 Fixed #19934 - Use of Pillow is now preferred over PIL.

 This starts the deprecation period for PIL (support to end in 1.8).
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  assigned
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aaugustin):

 For 2.d, I was thinking of a paragraph in the release notes, probably in
 the backwards-incompatible changes section.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  assigned
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by daniellindsley):

 * cc: daniellindsley (added)
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  assigned
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by daniellindsley):

 @aaugustin - One thing I missed was 2.d. I'm not actually sure where that
 documentation ought to go. Thoughts?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  assigned
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by daniellindsley):

 I think I have pretty much everything implemented, at least to start with.
 PR is at https://github.com/django/django/pull/1059. Feedback would be
 appreciated.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  assigned
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aaugustin):

 That works for me, I'm happy to review a patch along these lines.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  assigned
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by daniellindsley):

 My vote is +0 for deprecating the PIL (in that Pillow becomes the
 "blessed" version), but I think detecting which is installed & using shims
 to gloss what little Django uses of either is a very doable task. By my
 count, the PIL/_imaging is only used in 4 files in Django (plus lots of
 test files) & none of the usages are particularly advanced.

 I'm also +0 on the error reporting shim, in that I think we need to be
 able to inform the user that their install may be mis-configured. The
 existing comment (& the detection going on) will have to change. Again,
 I'm of the belief we can shim over that & have some ideas on detection.

 The only thing I'd add to the plan you've laid out is """2.a.1) Create any
 necessary shims to aid Django in detecting which, if any, are installed &
 to aid in providing useful error messages about the installation."""

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
-+-
 Reporter:  aaugustin|Owner:
 Type:   |  daniellindsley
  Cleanup/optimization   |   Status:  assigned
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by daniellindsley):

 * owner:  nobody => daniellindsley
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by aaugustin):

 To sum up,

 '''1) We must make the following decisions:'''

 ''1.a) Will we deprecate support for PIL?''

 On one hand, this would make testing easier and simplify import code —
 unlike PIL, Pillow is importable from a predictable location.

 On the other hand, there isn't much value in forcing this change upon
 everyone. Since Pillow and PIL can't coexist, it would be a problem for
 projects that depend on PIL internals (eg. `import _imaging`), and even
 more for projects that depend on libraries that depend on PIL internals.

 Finally, I haven't found any way to determine if the installed library is
 PIL or Pillow. We'd need one to show deprecation warnings when PIL is
 installed.

 ''1.b) Will we keep the error reporting shim introduced in #7727?''

 Even if we deprecate support for PIL, that'll take two releases, and we
 need a solution in the mean time to allow using support PIL (CPython only)
 and Pillow (CPython or PyPy).

 Unless we find a way to tell PIL from Pillow, it seems better to remove
 this check and allow using Pillow on PyPy, even at the cost of less-than-
 helpful error messages when attempting to use PIL with PyPy. When you're
 using PyPy, you're supposed to know what you are doing...

 (NB: `PIL/Image.py` appears to contain code to display a nice error when
 `_imaging` isn't available, both in PIL and in Pillow. Does #7727 predate
 this code?)


 '''2) We must make the following changes:'''

 2.a) Modify the documentation to point to Pillow instead of PIL.

 2.b) Modify the `ImportError` messages.

 2.c) If the answer to 1.b is "non", revert 4016d526.

 2.d) Describe the changes in the release notes.

 

 My vote is -0 for 1.a and -0 for 1.b. I'd like to hear more opinions
 before making a final decision.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 I don't think we will '''require''' Pillow >2.0.0, IMHO we should still
 support the legacy PIL for Django on Python 2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by aclark):

 IIUC you should be able to revert 4016d5264ab049c33c845c5337ce2a3e50754268
 since (AFAIK) as of Pillow 2.0.0 we fully support PyPy. If this is not the
 case, please add a comment to:
 
https://github.com/django/django/commit/4016d5264ab049c33c845c5337ce2a3e50754268

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 From https://bitbucket.org/pypy/compatibility/wiki/Home:
 ''The Python Imaging Library adds image processing capabilities to your
 Python interpreter. Since it is not maintained, use the pillow fork
 instead. Pillow is pypy compatible.''

 See also https://github.com/python-imaging/Pillow/issues/67

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by russellm):

 @claudep IIRC, the logic here is that Image is importable under PyPy
 (because it's pure python), but _imaging isn't (because it's a C module).
 What is being done here is a way of identifying PyPy by functionality --
 if you try to use ImageField under PyPy, an exception will be raised
 because the _imaging module doesn't exist..

 I have no idea what the analog is under Pillow. If Pillow can be executed
 under PyPy, the issue doesn't exist at all (which gives us another reason
 to switch to Pillow). If Pillow doesn't work under PyPy, then we'll need a
 way to identify that at runtime.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 I have successfully ran PIL tests with Pillow 2.0.0 on Python 3.2, except
 for the `_imaging` import in `from PIL import Image, _imaging`.
 `_imaging` cannot be imported from Pillow. This was introduced in
 [4016d5264a] (#7727) to workaround a !PyPy issue. Is this !PyPy issue
 still valid? If yes, is there an other test that we can make which would
 be both Pillow and !PyPy compatible?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 Yes, I think we should wait for version 2 (Python 3 support) before
 actually recommending Pillow. But nothing prevents working on a patch now,
 if you don't mind maintaining the patch (i.e. periodic rebasing) until the
 time of merging.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by micsco):

 * cc: mike+django-trac@… (added)


Comment:

 I'm happy to spend some time getting things up to speed here and submit a
 patch, however is it felt better to wait for 2.0? As that would be a
 better integration point?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by carljm):

 Django 1.5 already has Python 2.6 as minimum version, so Python < 2.6 is
 not an issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by aclark):

 Pillow's Python 3 support will land in version 2.0. At which point, anyone
 needing < Python 2.6 should use Pillow < 2.0. I'm not sure if old Python
 versions are a concern for Django, but I thought I'd mention it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by sjaensch):

 * cc: sj@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by apollo13):

 +1 for Pillow, even if it doesn't have Python 3 support (yet).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by static):

 I have had many problems using PIL and solved it by swiching to Pillow.
 Take this as a +1 too.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 I must say that I monitor Pillow for some time, waiting eagerly for its
 Python 3 support. At my current knowledge, it's the best target for a PIL
 replacement. Takes this as a +1 from me.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Python 3  |  Version:  master
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by reinout):

 * cc: reinout@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #19934: Switch to a Python 3-compatible imaging library

[Django]

#19934: Switch to a Python 3-compatible imaging library
+
   Reporter:  aaugustin |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Python 3  |Version:  master
   Severity:  Release blocker   |   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Originally reported by Marijonas Petrauskas on the django-developers
 mailing-list

 

 Why isn't Pillow the recommended Django image library yet? PIL has
 been unmaintained for almost 3 years and has a number of annoying bugs
 (e.g. fails to open some valid JPEG files, maybe has some security
 issues as well). Pillow, on the other hand, is a backwards-compatible
 community-maintained fork, which has most of those issues fixed and
 will even support Python 3 soon.

 I think this change would involve (1) running the test suite with
 Pillow, (2) updating the documentation and (3) updating the ImageField
 warning shown when PIL is not installed.

 

 Marking as a release blocker because of our goal to fully support Python 3
 in 1.6.

 I don't know if Pillow is the best choice, we should review the
 alternatives in all cases.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.