Re: [Django] #25384: New Migrations Generated with Improperly Sorted Imports

[Django]

#25384: New Migrations Generated with Improperly Sorted Imports
--+
 Reporter:  jambonrose|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Migrations|  Version:  1.8
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Markus Holtermann ):

 In [changeset:"84b0a8d2aad042fb573df5055b6153770d0929ac" 84b0a8d]:
 {{{
 #!CommitTicketReference repository=""
 revision="84b0a8d2aad042fb573df5055b6153770d0929ac"
 Fixed #25384 -- Ordered imports in newly created migration files

 Partial forwardport of 3cc5cc79584b66dafac54264d072ac1206426471 from
 stable/1.8.x as the issue was already fixed in master in
 a7bc00e17bebe34cdf23f744937b3c386ee73d81
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.99209cae32cf296409a98c4315214aaf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25384: New Migrations Generated with Improperly Sorted Imports

[Django]

#25384: New Migrations Generated with Improperly Sorted Imports
--+
 Reporter:  jambonrose|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Migrations|  Version:  1.8
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Markus Holtermann ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"3cc5cc79584b66dafac54264d072ac1206426471" 3cc5cc79]:
 {{{
 #!CommitTicketReference repository=""
 revision="3cc5cc79584b66dafac54264d072ac1206426471"
 [1.8.x] Fixed #25384 -- Ordered imports in newly created migration files
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f5f2c0c7d68a273e0b92d02aadbb3cec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25384: New Migrations Generated with Improperly Sorted Imports

[Django]

#25384: New Migrations Generated with Improperly Sorted Imports
--+
 Reporter:  jambonrose|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by MarkusH):

 * has_patch:  0 => 1


Old description:

> New migration files are generated with the following line of code (found
> in the `django/db/migrations/writer.py` file):
>
> from django.db import models, migrations
>
> Anytime [https://pypi.python.org/pypi/isort isort] is run on a migration
> file (for example, for data migrations), it will reorder the import to:
>
> from django.db import migrations, models
>
> It would be great if we were generating properly sorted documents.

New description:

 New migration files are generated with the following line of code (found
 in the `django/db/migrations/writer.py` file):
 {{{
 from django.db import models, migrations
 }}}
 Anytime [https://pypi.python.org/pypi/isort isort] is run on a migration
 file (for example, for data migrations), it will reorder the import to:
 {{{
 from django.db import migrations, models
 }}}
 It would be great if we were generating properly sorted documents.

--

Comment:

 PR: https://github.com/django/django/pull/5274

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1d674bcf6540f0cbbafebca5adb5eea6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25384: New Migrations Generated with Improperly Sorted Imports

[Django]

#25384: New Migrations Generated with Improperly Sorted Imports
--+
 Reporter:  jambonrose|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by MarkusH):

 * status:  closed => new
 * resolution:  duplicate =>
 * stage:  Unreviewed => Accepted


Comment:

 As briefly discussed on IRC the other day, I add a patch for 1.8 to change
 the order of those two imports. It's annoying to change the order
 manually.

 The issue is indeed fixed on master.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.bc6f94e6e8645d1e9221119823579fe2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25384: New Migrations Generated with Improperly Sorted Imports

[Django]

#25384: New Migrations Generated with Improperly Sorted Imports
-+-
 Reporter:  jambonrose   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Migrations   |  Version:  1.8
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * resolution:  invalid => duplicate


Comment:

 (done in #24155)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.73b10831f054abbd7684696dbc63eecc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25384: New Migrations Generated with Improperly Sorted Imports

[Django]

#25384: New Migrations Generated with Improperly Sorted Imports
-+-
 Reporter:  jambonrose   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Migrations   |  Version:  1.8
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by jambonrose):

 * status:  new => closed
 * resolution:   => invalid


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.4d1f4923f26333bf25cd2f040ffeb2c4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25384: New Migrations Generated with Improperly Sorted Imports

[Django]

#25384: New Migrations Generated with Improperly Sorted Imports
-+-
 Reporter:  jambonrose   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Migrations   |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by jambonrose):

 Argh. Collin is right. I was looking at this on the wrong branch. Very
 sorry.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.d6e7aa3b7be6529595cda7eb479f0e80%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25384: New Migrations Generated with Improperly Sorted Imports

[Django]

#25384: New Migrations Generated with Improperly Sorted Imports
-+-
 Reporter:  jambonrose   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Migrations   |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by collinanderson):

 Hi, could you try this out on master (1.9)? I think it _may_ have been
 fixed already.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.db4efe76eedc4ee3794093ef3aa39a46%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25384: New Migrations Generated with Improperly Sorted Imports

[Django]

#25384: New Migrations Generated with Improperly Sorted Imports
-+-
 Reporter:  jambonrose   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Migrations   |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by mlorant):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Old description:

> New migration files are generated with the following line of code (found
> in the `django/db/migrations/writer.py` file):
>
> from django.db import models, migrations
>
> Anytime [https://pypi.python.org/pypi/isort isort] is run on a migration
> file (for example, for data migrations), it will reorder the import to:
>
> from django.db import models, migrations
>
> It would be great if we were generating properly sorted documents.

New description:

 New migration files are generated with the following line of code (found
 in the `django/db/migrations/writer.py` file):

 from django.db import models, migrations

 Anytime [https://pypi.python.org/pypi/isort isort] is run on a migration
 file (for example, for data migrations), it will reorder the import to:

 from django.db import migrations, models

 It would be great if we were generating properly sorted documents.

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1a8d5c946dfa48acd21b0f38606df70e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #25384: New Migrations Generated with Improperly Sorted Imports

[Django]

#25384: New Migrations Generated with Improperly Sorted Imports
--+
 Reporter:  jambonrose|  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Migrations|Version:  1.8
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  1 |  UI/UX:  0
--+
 New migration files are generated with the following line of code (found
 in the `django/db/migrations/writer.py` file):

 from django.db import models, migrations

 Anytime [https://pypi.python.org/pypi/isort isort] is run on a migration
 file (for example, for data migrations), it will reorder the import to:

 from django.db import models, migrations

 It would be great if we were generating properly sorted documents.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.7c608980340aa6e30b1caaa25d54426e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.