Re: [Django] #25415: Make DiscoverRunner run system checks

[Django]

#25415: Make DiscoverRunner run system checks
---+
 Reporter:  Adam Chainz|Owner:  nobody
 Type:  New feature|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5eff8a77838540b27b6bef024dfccfd76008fd4c" 5eff8a77]:
 {{{
 #!CommitTicketReference repository=""
 revision="5eff8a77838540b27b6bef024dfccfd76008fd4c"
 Fixed #25415 -- Made DiscoverRunner run system checks.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.452f8e31712dcaeb2cd87e30d2364567%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25415: Make DiscoverRunner run system checks

[Django]

#25415: Make DiscoverRunner run system checks
---+
 Reporter:  Adam Chainz|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"391c450fbae8c3301954563288147578a1ae4a6d" 391c450]:
 {{{
 #!CommitTicketReference repository=""
 revision="391c450fbae8c3301954563288147578a1ae4a6d"
 Refs #25415 -- Made MySQL backend skip field validation of unsupported
 models.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.4ce7a8b4acacd0ad6ffd7f757cdef291%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25415: Make DiscoverRunner run system checks

[Django]

#25415: Make DiscoverRunner run system checks
---+
 Reporter:  Adam Chainz|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"6d947e8c3218c7137cd3fffecf1ca5b9274a20c6" 6d947e8c]:
 {{{
 #!CommitTicketReference repository=""
 revision="6d947e8c3218c7137cd3fffecf1ca5b9274a20c6"
 Refs #25415 -- Fixed/silenced check errors in Django's test suite.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.3e609804167698eda60b9596da012b07%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25415: Make DiscoverRunner run system checks

[Django]

#25415: Make DiscoverRunner run system checks
---+
 Reporter:  adamchainz |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"652bcc6f5fa9084768890488fec5208e082c2add" 652bcc6f]:
 {{{
 #!CommitTicketReference repository=""
 revision="652bcc6f5fa9084768890488fec5208e082c2add"
 Refs #25415 -- Fixed invalid models in the test suite.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.3f69788dfabd5e29787e7947b0e2aa2f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25415: Make DiscoverRunner run system checks

[Django]

#25415: Make DiscoverRunner run system checks
---+
 Reporter:  adamchainz |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by adamchainz):

 I've corrected all the check errors exception from some E340 errors (check
 added June 3 in #12810):

 {{{
 django.core.management.base.SystemCheckError: SystemCheckError: System
 check identified some issues:

 ERRORS:
 model_options.Article.authors: (fields.E340) The field's intermediary
 table 'model_options_articleref_authors' clashes with the table name of
 'model_options.ArticleRef.authors'.
 model_options.Article.reviewers: (fields.E340) The field's intermediary
 table 'model_options_articleref_reviewers' clashes with the table name of
 'model_options.ArticleRef.reviewers'.
 model_options.ArticleRef.authors: (fields.E340) The field's intermediary
 table 'model_options_articleref_authors' clashes with the table name of
 'model_options.Article.authors'.
 model_options.ArticleRef.reviewers: (fields.E340) The field's intermediary
 table 'model_options_articleref_reviewers' clashes with the table name of
 'model_options.Article.reviewers'.
 unmanaged_models.C01.mm_a: (fields.E340) The field's intermediary table
 'd01' clashes with the table name of 'unmanaged_models.Intermediate'.
 unmanaged_models.C02.mm_a: (fields.E340) The field's intermediary table
 'd01' clashes with the table name of 'unmanaged_models.C01.mm_a'.
 }}}

 In the first case the test models seem to hack their M2M fields to use the
 same tables on purpose (??). In the second case the tests are re-using the
 tables for unmanaged models on purpose.

 For the latter case, I can imagine that E340 should ignore unmanaged
 models, but I'm not 100% sure. For the former though, whether it's the
 `model_options` tests that are 'wrong', or the check, I don't think I'm
 qualified to know :/

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.c946eac663bd6f7e1c3d5f635c57bf95%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25415: Make DiscoverRunner run system checks (was: Django 1.8 regression: tests no longer run checks)

[Django]

#25415: Make DiscoverRunner run system checks
---+
 Reporter:  adamchainz |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timgraham):

 * version:  1.8 => master
 * type:  Bug => New feature


Comment:

 As I wrote [https://groups.google.com/d/topic/django-developers/GyuVJ-
 E6Or4/discussion to the mailing list] , I'm fine to proceed with this. We
 need a separate commit to fix the existing errors/warnings in Django's
 test suite, as well as documentation for the change and a mention in the
 release notes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.26a63c7c753a860e0e29c5220bb3ba7e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.