Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+-
 Reporter:  umbrae@… |Owner:
 Type:  New feature  |  aashu_dwivedi
Component:  contrib.auth |   Status:  reopened
 Severity:  Normal   |  Version:  SVN
 Keywords:  authentication   |   Resolution:
  backends easy-pickings | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by danielr):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+-
 Reporter:  umbrae@… |Owner:
 Type:  New feature  |  aashu_dwivedi
Component:  contrib.auth |   Status:  reopened
 Severity:  Normal   |  Version:  SVN
 Keywords:  authentication   |   Resolution:
  backends easy-pickings | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by carljm):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Please don't mark tickets fixed without explanation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+-
 Reporter:  umbrae@… |Owner:
 Type:  New feature  |  aashu_dwivedi
Component:  contrib.auth |   Status:  closed
 Severity:  Normal   |  Version:  SVN
 Keywords:  authentication   |   Resolution:  fixed
  backends easy-pickings | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by myusuf3):

 * status:  reopened => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+-
   Reporter:  umbrae@…   |  Owner:  aashu_dwivedi
   Type:  New| Status:  reopened
  feature|  Component:  contrib.auth
  Milestone:  1.4|   Severity:  Normal
Version:  SVN|   Keywords:  authentication
 Resolution: |  backends easy-pickings
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+-
Changes (by aaugustin):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Revert apparent spam.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+-
   Reporter:  umbrae@…   |  Owner:  aashu_dwivedi
   Type:  New| Status:  closed
  feature|  Component:  contrib.auth
  Milestone:  1.4|   Severity:  Normal
Version:  SVN|   Keywords:  authentication
 Resolution:  fixed  |  backends easy-pickings
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+-
Changes (by anonymous):

 * status:  new => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+-
   Reporter:  umbrae@…   |  Owner:  aashu_dwivedi
   Type:  New| Status:  new
  feature|  Component:  contrib.auth
  Milestone:  1.4|   Severity:  Normal
Version:  SVN|   Keywords:  authentication
 Resolution: |  backends easy-pickings
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+-
Changes (by carljm):

 * stage:  Design decision needed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+-
   Reporter:  umbrae@…   |  Owner:  aashu_dwivedi
   Type:  New| Status:  new
  feature|  Component:  contrib.auth
  Milestone:  1.4|   Severity:  Normal
Version:  SVN|   Keywords:  authentication
 Resolution: |  backends easy-pickings
   Triage Stage:  Design |  Has patch:  1
  decision needed|Needs tests:  0
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by dan.julius@…):

 * needs_better_patch:  1 => 0
 * ui_ux:   => 0
 * stage:  Accepted => Design decision needed


Comment:

 Modified PermissionDeniedBackend class:
 - Set supports_anonymous_user and supports_object_permissions to True
 - Added supports_inactive_user = True (which will be required in v1.5)

 Implementing similar functionality for permissions will require design
 change regarding get_all_permissions.
 Since each backend provides a list of permissions it allows, the list
 would be inconsistent if a backend raised the PermissionDenied exception
 on a permission already in the list.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+-
   Reporter:  umbrae@…   |  Owner:  aashu_dwivedi
   Type:  New| Status:  new
  feature|  Component:  contrib.auth
  Milestone:  1.4|   Severity:  Normal
Version:  SVN|   Keywords:  authentication
 Resolution: |  backends easy-pickings
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  1
-+-
Changes (by apollo13):

 * cc: florian+django@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+-
   Reporter:  umbrae@…   |  Owner:  aashu_dwivedi
   Type:  New| Status:  new
  feature|  Component:  contrib.auth
  Milestone:  1.4|   Severity:  Normal
Version:  SVN|   Keywords:  authentication
 Resolution: |  backends easy-pickings
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  1
-+-
Changes (by anonymous):

 * needs_better_patch:  0 => 1


Comment:

 `PermissionDeniedBackend` should set `supports_anonymous_user` and
 `supports_object_permissions` to `True` since that will be the default
 soon (and the only option). And if we are already on it: Shouldn't the
 permission part of the backends support the same mechanism?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+-
   Reporter:  umbrae@…   |Owner:  aashu_dwivedi
 Status:  new|Milestone:  1.4
  Component: |  Version:  SVN
  contrib.auth   | Keywords:  authentication
 Resolution: |  backends easy-pickings
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-

Comment (by aaugustin):

 #15716 was a duplicate.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+-
   Reporter:  umbrae@…   |Owner:  aashu_dwivedi
 Status:  new|Milestone:  1.4
  Component:  Contrib|  Version:  SVN
  apps   | Keywords:  authentication
 Resolution: |  backends easy-pickings
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-
Changes (by lrekucki):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0
 * stage:  Ready for checkin => Accepted
 * milestone:   => 1.4


Comment:

 On a bureaucratic note: you shouldn't mark your own patches as "Ready for
 checkin". Instead update the appropriate flags and someone else will
 review the patch (also see the
 [http://docs.djangoproject.com/en/dev/howto/contribute/#triage-stages-
 explained contributing howto]).

 Thanks for your work on this, aashu_dwivedi.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+-
   Reporter:  umbrae@…   |Owner:  aashu_dwivedi
 Status:  new|Milestone:
  Component:  Contrib|  Version:  SVN
  apps   | Keywords:  authentication
 Resolution: |  backends easy-pickings
   Triage Stage:  Ready for  |Has patch:  1
  checkin|  Needs tests:  0
Needs documentation:  1  |
Patch needs improvement:  1  |
-+-
Changes (by aashu_dwivedi):

 * stage:  Accepted => Ready for checkin


Comment:

 Added corrected patch with the required addition to the documentation .

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
+---
   Reporter:  umbrae@…  | Owner:  aashu_dwivedi 
   
 Status:  new   | Milestone:
   
  Component:  Contrib apps  |   Version:  SVN   
   
 Resolution:|  Keywords:  authentication 
backends easy-pickings
   Triage Stage:  Accepted  | Has patch:  1 
   
Needs documentation:  1 |   Needs tests:  0 
   
Patch needs improvement:  1 |  
+---
Changes (by lrekucki):

  * needs_better_patch:  0 => 1
  * stage:  Ready for checkin => Accepted
  * needs_docs:  0 => 1


Comment:

 Yes, otherwise people won't even know the feature is available.

 Some comments to the patch:

 * Your tests fail (did you runned them?):
 {{{
 Traceback (most recent call last):
   File "/home/lrekucki/django/django-
 gh/django/contrib/auth/tests/auth_backends.py", line 388, in
 test_authenticates
 self.assertEqual(authenticate(username='test',password='test'),self.user1)
 NameError: global name 'authenticate' is not defined
 }}}

 * Some of your code (like "except PermissionDenied" in
 {{{django/contrib/__init__.py}}}) is indented with tabs. Mixin spaces and
 tabs is bad. Django prefers 4 spaces as indentation.
 * You should also format your code according to PEP8 (i.e. whitespace
 around operators, whitespace after comma in argument list).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
-+--
   Reporter:  umbrae@…   | Owner:  aashu_dwivedi

 Status:  new| Milestone:   

  Component:  Contrib apps   |   Version:  SVN  

 Resolution: |  Keywords:  authentication 
backends easy-pickings
   Triage Stage:  Ready for checkin  | Has patch:  1

Needs documentation:  0  |   Needs tests:  0

Patch needs improvement:  0  |  
-+--
Changes (by aashu_dwivedi):

  * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
+---
   Reporter:  umbrae@…  | Owner:  aashu_dwivedi 
   
 Status:  new   | Milestone:
   
  Component:  Contrib apps  |   Version:  SVN   
   
 Resolution:|  Keywords:  authentication 
backends easy-pickings
   Triage Stage:  Accepted  | Has patch:  1 
   
Needs documentation:  0 |   Needs tests:  0 
   
Patch needs improvement:  0 |  
+---

Comment (by aashu_dwivedi):

 I am not sure but do i need to update the documentation also ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2550: [patch] Allow a Backend to Globally Fail Authentication

[Django]

#2550: [patch] Allow a Backend to Globally Fail Authentication
---+
  Reporter:  umb...@gmail.com  | Owner:  aashu_dwivedi  
  
Status:  new   | Milestone: 
  
 Component:  Contrib apps  |   Version:  SVN
  
Resolution:|  Keywords:  authentication 
backends easy-pickings
 Stage:  Accepted  | Has_patch:  1  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by aashu_dwivedi):

  * owner:  nobody => aashu_dwivedi
  * status:  reopened => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.