Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
-+-
 Reporter:  Tim Graham   |Owner:  Paul
 Type:   |  Schilling
  Cleanup/optimization   |   Status:  closed
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"298d02a77a69321af8c0023df3250663e9d1362d" 298d02a7]:
 {{{
 #!CommitTicketReference repository=""
 revision="298d02a77a69321af8c0023df3250663e9d1362d"
 Fixed #25617 -- Added case-insensitive unique username validation in
 UserCreationForm.

 Co-Authored-By: Neven Mundar 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701855d4c7ba3-547eeed1-df53-457d-a80b-47b30b752721-00%40eu-central-1.amazonses.com.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
-+-
 Reporter:  Tim Graham   |Owner:  Paul
 Type:   |  Schilling
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701855d0cdd00-da587ecd-4b1d-402c-bd75-482378d99f76-00%40eu-central-1.amazonses.com.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
-+-
 Reporter:  Tim Graham   |Owner:  Paul
 Type:   |  Schilling
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0
 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184fd232806-7d9090df-4f81-49f4-bdfa-862af906a75a-00%40eu-central-1.amazonses.com.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
-+-
 Reporter:  Tim Graham   |Owner:  Paul
 Type:   |  Schilling
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * needs_docs:  0 => 1


Comment:

 [https://github.com/django/django/pull/16103 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070183a1370857-e6378bd5-0603-4338-91a1-ed043ed1ef87-00%40eu-central-1.amazonses.com.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
-+-
 Reporter:  Tim Graham   |Owner:  Paul
 Type:   |  Schilling
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018374b95e96-1c574140-83f0-4890-954c-278cd2b70285-00%40eu-central-1.amazonses.com.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
-+-
 Reporter:  Tim Graham   |Owner:  Paul
 Type:   |  Schilling
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Paul Schilling):

 * owner:  (none) => Paul Schilling
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018373d330e8-ae6da5c5-e904-4ffc-a018-259b315fedf5-00%40eu-central-1.amazonses.com.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  Tim Graham|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * owner:  Neven Munđar => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182a5d456f4-468ac9b1-539b-4b72-ba6e-eda423c1d9fe-00%40eu-central-1.amazonses.com.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
-+-
 Reporter:  Tim Graham   |Owner:  Neven
 Type:   |  Munđar
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by René Fleschenberg):

 * cc: René Fleschenberg (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.68e528c9760f12a19699e66a7e3ba06e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
-+-
 Reporter:  Tim Graham   |Owner:  Neven
 Type:   |  Munđar
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Kye Russell):

 * cc: Kye Russell (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9c7071b4baf436084dc4be47b7050ddc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  timgraham |Owner:  nmundar
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by berkerpeksag):

 * cc: berker.peksag@… (added)


Comment:

 Looking at https://github.com/django/django/pull/5572 again, I'd suggest
 the following API:

 * Adding a `clean_username` method would make `UserCreationForm` less
 subclass friendly. I'd suggest rename `UserCreationForm` to
 `BaseUserCreationForm` and document it as a preferred way to extend user
 creation form
 * Add a `clean_username` method to `UserCreationForm` (it will be a
 subclass of `BaseUserCreationForm`)

 Thoughts?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7e89f60e46ad8eb9b952060b4f804b25%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  timgraham |Owner:  nmundar
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a5a912ce52ce718fa0dfd199b01d13c6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  timgraham |Owner:  nmundar
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by nmundar):

 * needs_better_patch:  1 => 0


Comment:

 It's fixed now, stupid mistake. Previous form data that I've used didn't
 trigger password length validation.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bb78c95a2f81b7fcb60af70228007bd5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  timgraham |Owner:  nmundar
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 There's a test failure.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2a228ce819719645fa36394f9cbcf785%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  timgraham |Owner:  nmundar
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by nmundar):

 PR: https://github.com/django/django/pull/5572

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ee920075861bbac15d09d7813cd0a575%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  timgraham |Owner:  nmundar
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by timgraham):

 Are you able to convert the patch into a pull request?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e6d4d3b135ab540e1ec96b26ccdab21a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  timgraham |Owner:  nmundar
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by nmundar):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f85d6a6da5be4f92fddae757ab1bca28%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  timgraham |Owner:  nmundar
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by nmundar):

 It's possible to achieve the effect described in this ticket by raising
 ValidationError in UserCreationForm.clean_username. However, this
 introduces one additional side-effect in tests of password validation
 logic. UserAttributeSimilarityValidator will not be able to check if
 username is similar to password because previously raised ValidationError
 will make username attribute None in password validator and "The password
 is too similar to the username." message will be missing from error list.
 Since the username in this case has to be changed anyway, omitting this
 message may not be relevant because password similarity check makes sense
 only on valid usernames. That's the explanation why
 auth_tests.test_forms.UserCreationFormTest.test_validates_password has to
 be tweaked in the patch.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c1b8ce4ddcb5c3287cd62e8c3193bb63%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  timgraham |Owner:  nmundar
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by nmundar):

 * Attachment "ticket_25617.patch" added.


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7ed65933a285599a6700838ec308f857%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  timgraham |Owner:  nmundar
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by nmundar):

 * owner:  nobody => nmundar
 * cc: nmundar@… (added)
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9af3afe84b9d6159ee2a5c8a24f868e3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  timgraham |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by zachborboa):

 * cc: zachborboa@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3927b79c157e5bcfe4189fc2660f09bd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
--+
 Reporter:  timgraham |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2b103a0ca96f9844f26546fb3383fbc7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #25617: Disallow usernames that differ only in case in UserCreationForm

[Django]

#25617: Disallow usernames that differ only in case in UserCreationForm
+
   Reporter:  timgraham |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.auth  |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Most applications don't treat user names as case sensitive. While we can't
 treat usernames as case-insensitive everywhere in Django due to backwards
 compatibility (#2273), by using `username__iexact` when checking for
 uniqueness of new usernames in `UserCreationForm`, we can at least prevent
 the creation of new usernames that differ only in case from an existing
 one. This protection won't cover creating a user in the shell or through
 the `createsuperuser` management command, but I don't think this is
 critical.

 This wouldn't affect any usernames that already exist, and users will
 still need to login with the same case that they register with.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.1ee421a6be9a25113ef4430523a59295%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.