Re: [Django] #26586: makemigrations does not detect custom field subclassing change

[Django]

#26586: makemigrations does not detect custom field subclassing change
-+-
 Reporter:  tuffnatty|Owner:  baylee
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  migrations, custom   | Triage Stage:  Accepted
  fields |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 For future reference, it would probably be fine to reclassify this ticket
 as a documentation issue, but since you've already created another issue,
 I'll close this.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4eba98d29ba6560bdebf7825c2ca1988%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26586: makemigrations does not detect custom field subclassing change

[Django]

#26586: makemigrations does not detect custom field subclassing change
-+-
 Reporter:  tuffnatty|Owner:  baylee
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  migrations, custom   | Triage Stage:  Accepted
  fields |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by baylee):

 After discussion with Markus at PyCon sprints 2016:

 This isn't possible. The closest we get is
 
[https://github.com/django/django/blob/master/django/db/migrations/autodetector.py#L879
 here], where we could add a check for `get_internal_type()` of the two
 fields. But that won't work because the old state and new state are
 dynamically generated from the field definition in the migration files.
 The only way to handle this would be if we saved internal type as part of
 the migrations.

 Propose closing this in favor of adding documentation in #26702

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6426176abbafa781e041062f21c86d77%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26586: makemigrations does not detect custom field subclassing change

[Django]

#26586: makemigrations does not detect custom field subclassing change
-+-
 Reporter:  tuffnatty|Owner:  baylee
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  migrations, custom   | Triage Stage:  Accepted
  fields |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by baylee):

 * owner:  nobody => baylee
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.68844ec2fa1cefc29d6e2557f402e353%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26586: makemigrations does not detect custom field subclassing change

[Django]

#26586: makemigrations does not detect custom field subclassing change
-+-
 Reporter:  tuffnatty|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  migrations, custom   | Triage Stage:  Accepted
  fields |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Brobin:

Old description:

> Example:
> {{{
> class MyLongTextField(models.CharField):
> def __init__(self, *args, **kwargs):
> kwargs["max_length"] = 2000
> super(MyLongTextField, self).__init__(*args, **kwargs)
> }}}
> After changing this to
> {{{
> class MyLongTextField(models.TextField):
> def __init__(self, *args, **kwargs):
> kwargs["max_length"] = 2000
> super(MyLongTextField, self).__init__(*args, **kwargs)
> }}}
> manage.py makemigrations detects no changes.

New description:

 Example:
 {{{#!python
 class MyLongTextField(models.CharField):
 def __init__(self, *args, **kwargs):
 kwargs["max_length"] = 2000
 super(MyLongTextField, self).__init__(*args, **kwargs)
 }}}
 After changing this to
 {{{#!python
 class MyLongTextField(models.TextField):
 def __init__(self, *args, **kwargs):
 kwargs["max_length"] = 2000
 super(MyLongTextField, self).__init__(*args, **kwargs)
 }}}
 manage.py makemigrations detects no changes.

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b320b9ed19579dd75519f5d643ef12e7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26586: makemigrations does not detect custom field subclassing change

[Django]

#26586: makemigrations does not detect custom field subclassing change
-+-
 Reporter:  tuffnatty|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  migrations, custom   | Triage Stage:  Accepted
  fields |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by tuffnatty):

 I think that expected behaviour is to generate an `ALTER TABLE table_name
 ALTER COLUMN column_name TYPE TEXT` migration operation. However, I'm not
 familiar enough with migration internals to predict what it takes to
 detect a change like this.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8ce399ae3b3068a953c6d93fea964536%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26586: makemigrations does not detect custom field subclassing change

[Django]

#26586: makemigrations does not detect custom field subclassing change
-+-
 Reporter:  tuffnatty|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  migrations, custom   | Triage Stage:  Accepted
  fields |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I'm not sure how to handle this.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ee27ea06fd265316c8afb828686b2175%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #26586: makemigrations does not detect custom field subclassing change

[Django]

#26586: makemigrations does not detect custom field subclassing change
+---
 Reporter:  tuffnatty   |  Owner:  nobody
 Type:  Bug | Status:  new
Component:  Migrations  |Version:  1.9
 Severity:  Normal  |   Keywords:  migrations, custom fields
 Triage Stage:  Unreviewed  |  Has patch:  0
Easy pickings:  0   |  UI/UX:  0
+---
 Example:
 {{{
 class MyLongTextField(models.CharField):
 def __init__(self, *args, **kwargs):
 kwargs["max_length"] = 2000
 super(MyLongTextField, self).__init__(*args, **kwargs)
 }}}
 After changing this to
 {{{
 class MyLongTextField(models.TextField):
 def __init__(self, *args, **kwargs):
 kwargs["max_length"] = 2000
 super(MyLongTextField, self).__init__(*args, **kwargs)
 }}}
 manage.py makemigrations detects no changes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.3bb68e5e5a9b890adf4bb33de59e7f32%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.