Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Mariusz
 Type:   |  Felisiak
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"4982958ec0c359908566fc1f34ef71297ea4337d" 4982958]:
 {{{
 #!CommitTicketReference repository=""
 revision="4982958ec0c359908566fc1f34ef71297ea4337d"
 Refs #27674 -- Removed GeoModelAdmin and OSMGeoAdmin per deprecation
 timeline.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070185bf595604-9e9e48d1-41c4-4f10-8959-d547493eb69c-00%40eu-central-1.amazonses.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Mariusz
 Type:   |  Felisiak
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"ce7b4f39e3635bfcaa2cec84d5da93c1dedcaa9c" ce7b4f3]:
 {{{
 #!CommitTicketReference repository=""
 revision="ce7b4f39e3635bfcaa2cec84d5da93c1dedcaa9c"
 Refs #27674 -- Removed django.contrib.gis.admin.OpenLayersWidget per
 deprecation timeline.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070185bf59583a-f1b993b3-b56a-47a5-9a63-b86d7ae4ff77-00%40eu-central-1.amazonses.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Mariusz
 Type:   |  Felisiak
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018050a28da8-076d54a5-9128-42c0-9de4-ef5a5b93c28e-00%40eu-central-1.amazonses.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Mariusz
 Type:   |  Felisiak
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"eeb0bb63795f7500156abaed2a94aae681a9fc4a" eeb0bb6]:
 {{{
 #!CommitTicketReference repository=""
 revision="eeb0bb63795f7500156abaed2a94aae681a9fc4a"
 Refs #27674 --- Deprecated django.contrib.gis.admin.OpenLayersWidget.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018050a229b4-6a39ea93-7b3d-481d-beee-77fe3642848e-00%40eu-central-1.amazonses.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Mariusz
 Type:   |  Felisiak
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  (none) => Mariusz Felisiak
 * status:  new => assigned
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/15624 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701804f86eeba-53100d1c-2376-44f4-a0d2-fdfed9f134fd-00%40eu-central-1.amazonses.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
--+
 Reporter:  Claude Paroz  |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  GIS   |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.8699ea11165dea5f73dfc3193e1c17ba%40djangoproject.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
--+
 Reporter:  Claude Paroz  |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  GIS   |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * owner:  Giannis Adamopoulos => (none)
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.53450df2c1d86d15ff964d4d496b6182%40djangoproject.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Giannis
 Type:   |  Adamopoulos
  Cleanup/optimization   |   Status:  new
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"448145092c23074b5c3b6c0502358c1d7eface8b" 44814509]:
 {{{
 #!CommitTicketReference repository=""
 revision="448145092c23074b5c3b6c0502358c1d7eface8b"
 Refs #27674 -- Added tests for GISModelAdmin.gis_widget_kwargs.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5d1215f860e4ec6a0e2a3ce56249ad3f%40djangoproject.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Giannis
 Type:   |  Adamopoulos
  Cleanup/optimization   |   Status:  new
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.cc866e82ede39d7eede51611ff0d423b%40djangoproject.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Giannis
 Type:   |  Adamopoulos
  Cleanup/optimization   |   Status:  new
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  closed => new
 * resolution:  fixed =>
 * needs_tests:  1 => 0
 * stage:  Ready for checkin => Accepted


Comment:

 Replying to [comment:10 Nick Pope]:
 > While looking into #33372 I noticed that there are two
 `OpenLayersWidget` classes:
 >
 > - `django.contrib.gis.admin.widgets.OpenLayersWidget` - this is used by
 the deprecated `GeoModelAdmin` class and targets OpenLayers 2.x
 > - `django.contrib.gis.forms.widgets.OpenLayersWidget` - this is used as
 a parent to `OSMWidget` (used by the new `GISModelAdmin`) and targets
 OpenLayers 3.x
 >
 > Deprecation warnings were added for `GeoModelAdmin` and `OSMGeoAdmin` as
 part of this ticket but `.admin.widgets.OpenLayersWidget` has no warning.
 Do we need to add one?

 Agreed, we can deprecate
 `django.contrib.gis.admin.widgets.OpenLayersWidget` in Django 4.1 and
 remove it in 5.0. Let's reopen.

 > Do we also need to warn about `gis/admin/openlayers.html` and
 `gis/admin/osm.html` templates going away? (Not sure whether we add a
 documentation note?)

 As far as I'm concerned, it is not needed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c2710df3904735f1ce661ecf88b7798c%40djangoproject.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Giannis
 Type:   |  Adamopoulos
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Nick Pope):

 While looking into #33372 I noticed that there are two `OpenLayersWidget`
 classes:

 - `django.contrib.gis.admin.widgets.OpenLayersWidget` - this is used by
 the deprecated `GeoModelAdmin` class and targets OpenLayers 2.x
 - `django.contrib.gis.forms.widgets.OpenLayersWidget` - this is used as a
 parent to `OSMWidget` (used by the new `GISModelAdmin`) and targets
 OpenLayers 3.x

 Deprecation warnings were added for `GeoModelAdmin` and `OSMGeoAdmin` as
 part of this ticket but `.admin.widgets.OpenLayersWidget` has no warning.
 Do we need to add one?

 Do we also need to warn about `gis/admin/openlayers.html` and
 `gis/admin/osm.html` templates going away? (Not sure whether we add a
 documentation note?)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.379fdeea445a1c42c0c481db2f85eeb5%40djangoproject.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Giannis
 Type:   |  Adamopoulos
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"4555aa0a489cb9dcf764edf12339097cdfa5ff84" 4555aa0a]:
 {{{
 #!CommitTicketReference repository=""
 revision="4555aa0a489cb9dcf764edf12339097cdfa5ff84"
 Fixed #27674 -- Deprecated GeoModelAdmin and OSMGeoAdmin.

 Co-authored-by: Mariusz Felisiak 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ac46fd32568e1988e8b8d8a059d8b9a7%40djangoproject.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Giannis
 Type:   |  Adamopoulos
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin
 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.57dcac1eadd6b65a0e1f732240ee55c6%40djangoproject.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Giannis
 Type:   |  Adamopoulos
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * needs_docs:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.24f73974397e29f4b561863a9521ab27%40djangoproject.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Giannis
 Type:   |  Adamopoulos
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a6eda4436c07366f903a116ff0fe197e%40djangoproject.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Giannis
 Type:   |  Adamopoulos
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Giannis Adamopoulos):

 [https://github.com/django/django/pull/13733 Submitted PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.18b369f10eb933d1fe1151871e8e48e6%40djangoproject.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-+-
 Reporter:  Claude Paroz |Owner:  Giannis
 Type:   |  Adamopoulos
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Giannis Adamopoulos):

 * owner:  nobody => Giannis Adamopoulos
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f4c596bc435ea769a3063e54330a06ed%40djangoproject.com.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham):

 Another idea: I like to see this sort of issue solved at the form level,
 if possible, to allow reusing the solution outside the admin.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.b94374259b6b9aa0c9d97aa627751038%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz):

 Sure. The typical example is to be sure all geometry widgets use a
 specific map widget, or specific map widget attributes.
 With `formfield_overrides`, you'd have to specify all field types:
 {{{
 class MyModelAdmin(admin.ModelAdmin):
 formfield_overrides = {
 models.PointField: {'widget': MyCustomMapWidget},
 models.PolygonField: {'widget': MyCustomMapWidget},
 models.LineField: {'widget': MyCustomMapWidget},
 models.MultiPointField: {'widget': MyCustomMapWidget},
 ...
 }
 }}}
 which is not nice if you have many geometry field types in your project. I
 think it's a case where `formfield_for_dbfield` is handy:
 {{{
 class MyModelAdmin(admin.ModelAdmin):
 def formfield_for_dbfield(self, db_field, request, **kwargs):
 if isinstance(db_field, models.GeometryField) and db_field.dim <
 3:
 kwargs['widget'] = OSMWidget(default_lon=151, default_lat=-33)
 return db_field.formfield(**kwargs)
 else:
 return super(GeoModelAdmin,
 self).formfield_for_dbfield(db_field, request, **kwargs)
 }}}

 An alternative would be to still provide a GIS admin utility (subclass or
 mixin) which sets the same map widget for all geometry fields, like the
 current `GeoModelAdmin.get_map_widget()`. Basically the current code
 without all the boiler plate code copying class attributes to widget
 attributes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.dcdd8aec72163cdbec6185f2dffedda1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Comment:

 Could you describe the relevance of `formfield_for_dbfield` in a bit more
 detail?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3549c8ea55bb3f752a7e7c0a8116f762%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #27674: Deprecate GeoModelAdmin and OSMGeoAdmin

[Django]

#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
+
   Reporter:  Claude Paroz  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  GIS   |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 The geometry fields now have default map widgets, so the need of gis-
 specific `ModelAdmin` classes is therefore less relevant.

 However, the fact that `ModelAdmin.formfield_for_dbfield` is not
 documented does not help, so I'd suggest to document it first.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.6585c1b008d8632d4d8478d0c44fb14f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.