Re: [Django] #33750: Use for timezone warning in admin

[Django]

#33750: Use  for timezone warning in admin
-+-
 Reporter:  Florian Demmer   |Owner:  Florian
 Type:   |  Demmer
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Carlton Gibson ):

 In [changeset:"6f80050496780e2f8a65e2a4374dd6375c9fbfa5" 6f80050]:
 {{{
 #!CommitTicketReference repository=""
 revision="6f80050496780e2f8a65e2a4374dd6375c9fbfa5"
 Fixed #33781 -- Restored alignment for admin split-field timezone
 warnings.

 Regression in f3e2bb0833105f43efc0cc6f19c8465bc1b1a785.
 Refs #33750 and #27207.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d8014b44-72444259-5488-4b78-aa14-d3138044318b-00%40eu-central-1.amazonses.com.

Re: [Django] #33750: Use for timezone warning in admin

[Django]

#33750: Use  for timezone warning in admin
-+-
 Reporter:  Florian Demmer   |Owner:  Florian
 Type:   |  Demmer
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f3e2bb0833105f43efc0cc6f19c8465bc1b1a785" f3e2bb0]:
 {{{
 #!CommitTicketReference repository=""
 revision="f3e2bb0833105f43efc0cc6f19c8465bc1b1a785"
 Fixed #33750 -- Fixed timezone warning alignment with help texts.

 Previously help_text was wrapped in a paragraph, but the change to div
 broke the alignment, refs #27207.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811ea4a9dc-691943bc-f29a-499b-96ce-f14ae4f4ae39-00%40eu-central-1.amazonses.com.

Re: [Django] #33750: Use for timezone warning in admin

[Django]

#33750: Use  for timezone warning in admin
-+-
 Reporter:  Florian Demmer   |Owner:  Florian
 Type:   |  Demmer
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Florian Demmer
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811e919853-448be518-e28b-47c8-b89b-ed3d1899f48d-00%40eu-central-1.amazonses.com.

Re: [Django] #33750: Use for timezone warning in admin

[Django]

#33750: Use  for timezone warning in admin
--+
 Reporter:  Florian Demmer|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.admin |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  1
--+
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181137e413b-26db32c7-6127-4b6e-b132-91aa62282208-00%40eu-central-1.amazonses.com.

Re: [Django] #33750: Use for timezone warning in admin

[Django]

#33750: Use  for timezone warning in admin
-+-
 Reporter:  Florian Demmer   |Owner:  nobody
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Description changed by Florian Demmer:

Old description:

> Previously help_text was inserted as  in admin. This was changed in
> #27207 to use a .
>
> The
> [https://github.com/django/django/blob/0dd29209091280ccf34e07c9468746c396b7778e/django/contrib/admin/static/admin/js/admin/DateTimeShortcuts.js#L61
> addTimezoneWarning()] function has "always" added the warning by
> inserting a  and .
>
> Also using a  with the help class here avoids problems with left-
> alignment of the inserted text and removes the need for the .

New description:

 Previously help_text was inserted as  in admin. This was changed in
 #27207 to use a .

 The
 
[https://github.com/django/django/blob/0dd29209091280ccf34e07c9468746c396b7778e/django/contrib/admin/static/admin/js/admin/DateTimeShortcuts.js#L61
 addTimezoneWarning()] function has "always" added the warning by inserting
 a  and .

 Also using a  with the help class here avoids problems with left-
 alignment of the inserted text (see attachment) and removes the need for
 the .

 PR: https://github.com/django/django/pull/15743

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181102bd708-facf9d30-d8aa-4772-b21f-e551885828f0-00%40eu-central-1.amazonses.com.

Re: [Django] #33750: Use for timezone warning in admin

[Django]

#33750: Use  for timezone warning in admin
-+-
 Reporter:  Florian Demmer   |Owner:  nobody
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Florian Demmer):

 * Attachment "33750.jpg" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018110278182-df948b37-bc6a-407a-a3ae-cfaa2f7e63be-00%40eu-central-1.amazonses.com.

[Django] #33750: Use for timezone warning in admin

[Django]

#33750: Use  for timezone warning in admin
+--
   Reporter:  Florian Demmer|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  assigned
  Component:  contrib.admin |Version:  4.0
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  1 |
+--
 Previously help_text was inserted as  in admin. This was changed in
 #27207 to use a .

 The
 
[https://github.com/django/django/blob/0dd29209091280ccf34e07c9468746c396b7778e/django/contrib/admin/static/admin/js/admin/DateTimeShortcuts.js#L61
 addTimezoneWarning()] function has "always" added the warning by inserting
 a  and .

 Also using a  with the help class here avoids problems with left-
 alignment of the inserted text and removes the need for the .

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018110256a3d-e94da506-edd2-4956-8cb0-7fb62adcd460-00%40eu-central-1.amazonses.com.