subject:"\[Django\] #6903\: Go back to old change

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:  oinopion
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by revolunet):

 The querystring approach has the advantages of being explicit and allow to
 have multi-tabs/windows in different states.

 Having the breadcrumbs use the QS is optional but i thing it adds some
 comfort for the user (let's get back to where i were)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.773c5e4fe1da3939b2bcf6245ae621db%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

Comment (by empty):

Four years ago I started using the querystring approach to this problem
and it has worked flawlessly. I'm not sure why there's such consternation
over the query string parameters in the URL. It's actually quite useful
(for sending to a friend) and the exact same behavior you would get with
regular filtering of the change list.

I understand the desire to get the "perfect" implementation here but
sometimes "great" is the enemy of "good enough". Perhaps we can get some
resolution by going forward with the querystring approach. It's not as
though anything is lost by implementing this.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.8c955d5f878c2cc2f19c9f4e373abe4a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:  oinopion
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+
Changes (by charettes):

 * cc: charettes (added)


Comment:

 I also think the querystring is the more appropriate approach, not sure
 about the `sticky_filters` wording thought.

 I'd say leave the breadcrumbs as they are.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c3a0eec9dcd4fdc0f5875bbe3ad1182e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

Comment (by loic84):

I've tried to sum up the different options that have been used so far in
this ticket.

'''The problem:'''

We need the sticky filters to survive an arbitrarily long path made of
GET, POST, and Redirects.

'''The options:'''

The only 2 *consistent* ways of doing it are the querystring and the
session. There is a third option that involve reading the referrer and
storing information in a hidden field, but at least for redirects and html
links we need a fallback method.

There is no perfect solution:
- If we pick the querystring, we add a lot of things to the URLs.
- If we pick the session, we lose the direct link between the
`change_list` that started the chain of events and the one to which we
return. (as explained in comment:71)
- If we pick an hybrid solution, we lack consistency and we still suffer
from the defects of whatever we use as a fallback.

For the issue at hand I value predictably and reliability much more than
the aesthetic of the URL, especially for an admin site. So I'd like to
suggest using the querystring and offering an option to switch off the
behavior: `ModelAdmin.sticky_filters`. The developer gets to pick, he can
have prestine URLs or a robust preservation of changelist filters, not
both. If we go with that, we'll have to decide what's the default value of
the `sticky_filters` flag.

Proof of concept: https://github.com/loic/django/compare/ticket6903

I tested it manually and I have yet to fail it, I'll write the docs and
tests tomorrow.

Unlike previous attempts at using the querystring, it relies on a
templatetag that accounts for existing querystring parameters.

I've also left out the breadcrumbs, as I like that they point to a fresh
`change_list`, but that's debatable, I can easily add them.

Thoughts?

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.0844b3e98a9863fe14b615e26e2410ad%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-06-15 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:  oinopion
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+
Changes (by loic84):

 * needs_better_patch:  0 => 1


Comment:

 I looked further into it, I pass on the delete link as there is no easy
 way to POST to the delete URL because `submit_line.html` is included
 within a form, and you can't have a form within a form. Fixing it requires
 a refactor too big to be within the scope of this ticket.

 That said, the patch and the tests only cover the basic scenarios:
 - `change_list > add_view > save`
 - `change_list > change_view > save`
 - `change_list > delete_view > save`

 You are out of luck if you do:
 - `change_list > change_view  (Save and continue editing) > change_view >
 save`
 - `change_list > change_view (Save and add another) > add_view > save`

 The reason we lose track of filters is that `_continue`, `_saveasnew` and
 `_addanother` rely on `HttpResponseRedirect` so we have to use the
 querystring for such cases.

 At this point I agree with @empty, I'd vote to use querystring everywhere,
 the URL is not that ugly and if anything, it gives some context of where
 you came from. If you want to keep the pretty URLs where possible, just
 append the querystring to these `HttpResponseRedirect` and allow
 `_changelist_filters` to come from either POST or GET.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2dc0a238bace35e5ee0829ec7ba13f2c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-06-14 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:  oinopion
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+

Comment (by anonymous):

 Can we please not bikeshed about delete link?  It does not bring us any
 closer to closing this 5 years old ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e192f009f4265125ee8111fe49f247af%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-06-14 Thread Django

Comment (by loic84):

Somehow I missed the updates for that ticket and just saw oinopion's PR on
github.

I really like the patch, except that I would have taken this opportunity
to turn the delete link into a delete button.

1. It's more in line with the HTTP spec where GET should be free of side
effects. (We do have a confirmation page, but that's an implementation
detail.)
2. It's consistant with the `change_list` delete action, and the rest of
the `change_view` actions.
4. It avoids special casing the delete link in this patch.
5. Less importantly, it avoids an ugly URL for the delete confirmation
page.

That said, this could be changed later in a different patch/ticket but I
doubt such a minor cleanup would get much attention on its own.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.df9b9e64fde44f423446fa0d167deb9a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-06-12 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:  oinopion
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+
Changes (by oinopion):

 * needs_docs:  1 => 0


Comment:

 I'm not really sure what kind of documentation this would need: Functional
 details of admin are not documented. Release notes might be a good place,
 but should I put it in 1.6?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8361a12af60e60b88f5e23392f393f8f%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-06-12 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:  oinopion
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+
Changes (by oinopion):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.be368a1f8f52d5dba86fde87e526d1a1%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-06-12 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:  oinopion
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by oinopion):

 I've submitted [https://github.com/django/django/pull/1264 pull request]
 from previous ticket with some small corrections.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.04bb6eebe245d56e6aa314b3590f707a%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-06-11 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:  oinopion
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+
Changes (by oinopion):

 * owner:   => oinopion
 * cc: tomek@… (added)
 * status:  new => assigned


Comment:

 I've updated older patch by julien. It was missing passing filters to
 delete view. It is still missing some `is_safe_url` checks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3483b9de3e280d4dbad1d4b25b85ac26%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by empty):

 The original querystring approach has worked fine for us for years. Are we
 over thinking the approach on this? I'd really like to see this get in.
 It's sort of a non starter for a lot of our clients.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by julien):

 Using the http referer us a good idea. I've just posted a quick proof of
 concept (I haven't tested this manually yet).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by loic84):

 @julien: when the user goes from `changelist_view` to `change_view` you
 can retrieve the querystring from HTTP_REFERER.

 The only time where you might need an ugly URL is for the delete link, but
 I think we should POST (instead of GET) to the `delete_view` anyway, just
 like we do for the delete action.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by julien):

 While I like the idea of a hidden field in the change form, we still need
 a way of passing the filters from the changelist to the change form when
 an object is clicked in the changelist. Passing the filters via the
 querystring would look a bit ugly and would kind of defeat the purpose of
 using a hidden field.

 Ideally, I'd like a way that doesn't clutter the urls and also satisfies
 the principle of least surprise :)

 Sorry I haven't had much time to think all of this through yet. Please
 don't let this deter you from working on this patch. I'll continue to
 provide feedback whenever needed. Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-02-28 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by revolunet):

 Wow. There are 12 patches in this page, made by various people, and the
 desired implementation is still not defined.
 This feature may not be a priority, even if more than 3 years old, but
 would be cool if the core team could agree on the implementation so we can
 try again and kill that one ;)
 Anyone here going at djangocon.eu and interested in fixing that with me ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-02-28 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by julien):

 @loic84: I agree with these concerns. I'd like to avoid cluttering the
 urls so a hidden field sounds like a sane approach.

 This means the match needs to be reworked further. The tests should also
 be extended to simulate a multi-tab use case. If someone can propose a
 patch that would be great, otherwise I'll try to work on it at Pycon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-02-28 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+
Changes (by kraken):

 * cc: kraken (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-02-26 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by loic84):

 I'd like to voice my concern regarding this approach. We typically deal
 with the admin using multiple tabs and with this patch the redirect
 becomes rather unpredictable.

 I'd love a solution for persistent `ChangeList` filters since the current
 behavior forces us to set all our filters repeatedly but at least what is
 happening is obvious. It's extremely confusing to land on an empty
 `ChangeList` upon saving because in parallel you checked something in a
 different tab and set a restrictive bunch of filters.

 There ought to be a direct connection between the `ChangeList` that led to
 a add/change form and the `ChangeList` it redirects to.

 Maybe a hidden form field and a querystring parameter for the delete link?
 Actually semantically it would even make sense that the delete link be
 changed to a delete form with a submit button.

 BTW, if you still plan to go ahead with the current patch, `module_name`
 should be amended to `model_name`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-02-24 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by julien):

 Ok, so I have wrapped up the implementation and tests. There is just one
 minor test failure:

 {{{
 ==
 FAIL: test_changelist_view_count_queries
 (regressiontests.admin_views.tests.AdminCustomQuerysetTest)
 --
 Traceback (most recent call last):
   File "/django/tests/regressiontests/admin_views/tests.py", line 2550, in
 test_changelist_view_count_queries
 self.assertEqual(resp.context['selection_note_all'], 'All 2 selected')
   File "/django/django/test/testcases.py", line 195, in __exit__
 executed, self.num
 AssertionError: 6 != 4 : 6 queries executed, 4 expected
 }}}

 I haven't looked into this yet but it's most likely because the session
 lookups require extra database queries (which is normal).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-02-22 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by julien):

 Replying to [comment:68 gabbork]:
 > hi, will you include this new feature in next 1.5 django release?

 1.5 has been in feature-freeze mode since the first release candidate came
 out some weeks ago. I'm really hoping to have it included in 1.6 though.
 I'm planning to wrap up the patch this weekend during the worldwide
 sprint, and then I'll be seeking feedback from users to make sure we get
 the user experience right.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-02-22 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by gabbork):

 hi, will you include this new feature in next 1.5 django release?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-02-05 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by julien):

 I think the latest patch above looks good. Only tests should be added and
 slightly improved as noted in my previous comment. I'll try to get to that
 soon if no one beats me up to it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-02-05 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by revolunet):

 any news on this ?
 needs more improvments ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2013-01-09 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+
Changes (by andybak):

 * cc: andybak (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2012-12-30 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by julien):

 Ok, so the review took a bit longer than anticipated as I realized we
 first needed to clean up the `ModelAdmin` API a little in #19505.

 This allows a much more succinct and cleaner approach as in the patch
 above.

 Tests are still needed. The tests from the previous patch could probably
 be reused. However, they could be simplified a bit by testing a model
 simpler than `auth.User`.

 As always, feedback is appreciated. Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2012-12-17 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by julien):

 Thanks revolunet for updating the patch. I've started reviewing it. I'll
 try to provide some detailed feedback soon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2012-12-09 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by revolunet):

 Hi :)

 So here's my session based patch :
 https://github.com/revolunet/django/compare/bug-6903-2

 Its much more simpler than the querystring based approach :

  - records the current changelist querystring in an
 `admin_[APP]_[MODEL]_filters` session variable
  - if any, redirect with that querystring on add/change/delete object

 I added some standard unittests

 comments ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

2012-12-04 Thread Django

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by revolunet):

 Hi guys, thanks for reviewing/commenting again... this has definitely to
 be fixed.

 After have read all the comments, i first went with the URL solution.
 Works well but makes urls a little ugly, true. if this is a problem for
 most of you, we can go with the session.

 The session is another approach that could also work well and i can
 rewrite my patch and tests to make this happen :)
 The only little issue is multi-windows but this could be resolved in a 2nd
 pass?

 I understand and agree with the fact that this session filters is just
 one-time use and should not affect the direct links to the change list.

 Waiting for your approval to kill this one...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by jarrow):

 To cite my four years younger self ;)

 > I proposed to use the session to store the filters so that you don't
 pass your filters and search queries around whenever you pass the URL of
 an edit form to someone else. So I would use a hash of the data and use it
 as a key in the session. This key would then be passed around instead of
 the info.

 So yes, I'm all for using the session, '''but''' I think it would be great
 to still have a querystring parameter that holds a hash/key of the data
 that it is in the session (i.e. filter settings). This way one could work
 with multiple browser windows and it would still work as expected.

 Great to see this is moving again! Go, Django! :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by aaugustin):

 Replying to [comment:57 hejsan]:
 > Why not cookies?

 cookies == session

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save

#6903: Go back to old change_list view after hitting save
---+
 Reporter:  jarrow |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+

Comment (by Velmont):

 Here's someone else. It makes much sense not to clutter the urls with
 something that should be an implementation detail. Rather than doing it as
 a session, it might also be possible just to do it client-side with
 localStorage. If I'd hacked a quickfix patch myself, I'd probably do that.
 Minimal changes. But it wouldn't fix the problem when not using javascript
 ofc.

 I'll take the patch as it is now into a membership management system,
 hopefully I won't have to do it for next release. The workflow is hampered
 without it :-)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6903: Go back to old change_list view after hitting save