Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+-
 Reporter:  semenov  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.1
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Duplicate of #24974 which is fixed in Django 1.10.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.746abcc21a7352f5314993de0dba1d46%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+
 Reporter:  semenov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by vzima):

 * cc: vlastimil.zima@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ab2b87dd4bac7d7121254a371175615d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+
 Reporter:  semenov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by claudep):

 Replying to [comment:14 IlyaSemenov]:
 > Will it make it better if I come up with a patch which moves
 `formfield_callback` into the Meta class (where it would make perfect
 sense along with `widgets` and `labels`), or even allows to use ''either''
 way (for backward compatibility)?

 Indeed, I think it would be an interesting alternative to consider.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.346c54d31522cd6d7086611e9388bb5f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+
 Reporter:  semenov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by IlyaSemenov):

 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.7acb1bc3c8d7be9c09248c8ce7901105%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+
 Reporter:  semenov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by IlyaSemenov):

 Added tests: https://github.com/IlyaSemenov/django/tree/ticket_12915

 I am not happy with the patch either, but the main problem here is the
 original design decision to provide formfield_callback as a class-level
 lambda rather than @staticmethod or a Meta class attribute.

 Will it make it better if I come up with a patch which moves
 `formfield_callback` into the Meta class (where it would make perfect
 sense along with `widgets` and `labels`), or even allows to use ''either''
 way (for backward compatibility)?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.7a7dd01e2c6fe4aed2df81bdc401796a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+
 Reporter:  semenov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by claudep):

 Writing a test would probably be the next step.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5092427ebe97c74c42ba5fb655240fcb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+
 Reporter:  semenov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by IlyaSemenov):

 How'd you like to improve the latest patch? It's been 5 years, and I'm
 suffering from this again.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.97797cea218d8cf577c179ff340719f2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+
 Reporter:  semenov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by melinath):

 Also, just FTR - formfield_callback use *is* documented with
 modelform_factory.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.827f5c96b3c2a5213dd614a47f46bb68%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+
 Reporter:  semenov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by jezdez):

 * needs_docs:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
+
   Reporter:  semenov   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  Forms
Version:  1.1   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  1
Patch needs improvement:  1 |  Easy pickings:  0
+
Changes (by tomchristie):

 * cc: tom@… (added)
 * easy:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
---+
  Reporter:  semenov   | Owner:  nobody
Status:  new   | Milestone:
 Component:  Forms |   Version:  1.1   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Changes (by russellm):

  * needs_better_patch:  0 => 1
  * stage:  Unreviewed => Accepted

Comment:

 I'm not completely happy with either of the patches you present, but I
 accept the problem.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+--
  Reporter:  semenov | Owner:  nobody
Status:  new | Milestone:
 Component:  Forms   |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  1 
Needs_better_patch:  0   |  
-+--
Comment (by semenov):

 A little note for those who don't understand the importance of the
 problem. I truly believe that an empty inherited class should always
 behave exactly as its parent. That is a fundamental principle of
 polymorphism, which is not followed by ModelForms.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+--
  Reporter:  semenov | Owner:  nobody
Status:  new | Milestone:
 Component:  Forms   |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  1 
Needs_better_patch:  0   |  
-+--
Changes (by semenov):

  * has_patch:  0 => 1
  * needs_tests:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+--
  Reporter:  semenov | Owner:  nobody
Status:  new | Milestone:
 Component:  Forms   |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by semenov):

 No, changing pop() to get() doesn't help. That does store a manually
 specified formfield_callback for a class; but that doesn't lookup a
 missing formfield_callback from a parent. Moreover, it will break on a
 double inheritance chain, e.g. when class A(ModelForm) stores a
 formfield_classback, class B(A) doesn't store but still can lookup parent,
 then class C(B) can't even lookup since B didn't store formfield_callback.

 I am attaching a patch which adds the desired behavior accurately. Please
 let me know if it's of any interest to commiters and I will come up with a
 regression test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12915: formfield_callback is lost in an inherited ModelForm

[Django]

#12915: formfield_callback is lost in an inherited ModelForm
-+--
  Reporter:  semenov | Owner:  nobody
Status:  new | Milestone:
 Component:  Forms   |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by ramiro):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 I'd say the fact that the value of `formfield_callback` is stored as a
 ModelForm class attribute is an internal implementation detail and that's
 why it isn't documented as such.

 Anyway, maybe changing the `pop()` to `get()` here does it?:
 
http://code.djangoproject.com/browser/django/trunk/django/forms/models.py?rev=12402#L204

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.