Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  Carl Meyer|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Mariusz Felisiak ):

 In [changeset:"2fb872e56f064361c2cd4674c0f23cd419994d82" 2fb872e5]:
 {{{
 #!CommitTicketReference repository=""
 revision="2fb872e56f064361c2cd4674c0f23cd419994d82"
 Refs #23879 -- Made introspection respect required_db_features.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b0cf3d57509db5c2db3f2fdfd67136c3%40djangoproject.com.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz ):

 In [changeset:"6b6d13bf6ed02c345912829e3850a201f113712a" 6b6d13b]:
 {{{
 #!CommitTicketReference repository=""
 revision="6b6d13bf6ed02c345912829e3850a201f113712a"
 Stopped conditional discovery of gis_tests apps

 Refs #23879.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c3aa25927fb46f3a60ab3ed818442c08%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz ):

 In [changeset:"36e90d1f45a13f53ce25fdc2d9c04433b835c9af" 36e90d1f]:
 {{{
 #!CommitTicketReference repository=""
 revision="36e90d1f45a13f53ce25fdc2d9c04433b835c9af"
 Stopped special-casing postgres-specific tests

 Refs #23879.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.19454a61aa3abcc79fc8a04e31ef544f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8097e5483210fa8c9d6142f1d48e1caed6d7b7bb" 8097e54]:
 {{{
 #!CommitTicketReference repository=""
 revision="8097e5483210fa8c9d6142f1d48e1caed6d7b7bb"
 Fixed #23879 -- Allowed model migration skip based on feature/vendor

 Thanks Carl Meyer for the report and review, and Tim Graham for the
 review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c3544eb91347a2ad035c6425c1fd7d62%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e82a52f559b1cb7db5ed3824caac186c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0fc3b466d74dd9545f82c19628b44ba1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Seems on the right track to me.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4f761551eaa54bfac7ab56d285a474de%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * has_patch:  0 => 1


Comment:

 I finally succeeded in having a seemingly-working patch. Not commit-ready,
 but a base for discussion:
 https://github.com/django/django/pull/4452

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e6b819e4d5ee9334a6ee87981face07f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by MarkusH):

 The general idea to have some vendor specifics in the migration code base
 sounds good. But I have to agree with Carl on the problems that arise from
 not loading a migration. I think the skipping of vendor miss-matches
 should happen during the actual migrate process. This still allows
 dependency resolutions and state changes independent from the vendor.

 Moving the vendor part into operations would furthermore give us some
 flexibility for advanced database features. E.g. once `contrib.postgres`
 got support for views, these views could be generated within the same
 migration, one operation could be
 `django.contrib.postgres.operations.CreateView` (with a PostgreSQL vendor
 marker) while a `RunSQL` operation would run everywhere but on PostgreSQL.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b7822aab03b963a5ea6eae4c1123f852%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by carljm):

 I agree. I think there are probably some aspects that require further
 thought (like what happens if a later migration is "appropriate for this
 connection" but has a dependency on one that is not?), but I think the
 general idea is sound.

 I wonder if perhaps it would work better if it were operations rather than
 entire migrations that were marked as for-certain-db-vendor-only? I could
 imagine some API like a mark-for-vender wrapper to surround a list of
 operations in a migration file.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ea1d9c2f08a90cb4bb0a40e21fa0a155%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 Wojtek, I think your POC patch is interesting, and would be worth being
 completed with docs and tests.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.990f4eb74e820031a127aca2eed90354%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by timgraham):

 That looks interesting. It would probably be worth discussing the issue of
 database vendor specific migrations on the DevelopersMailingList. If it's
 been discussed before I'm not aware of it.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.71bc74f8c4bb64ecce5b7cce9299fc49%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by wrwrwr):

 I can confirm that removing the GIS toggle already gives a bunch of
 skipped tests without any failures or errors.

 On the other hand, postgres tests can't be dealt with easily --
 `postgres_tests` have some migrations that rely on PostgreSQL specific
 operations, and cause the test database creation to fail with any other
 backend. Resolving this would require some way to limit migrations or
 whole test apps to specific backends.

 I was able to get it to work with an
 [https://github.com/wrwrwr/django/compare/feature/always-test-gis-and-
 postgres ad-hoc solution] (that wasn't properly thought over or
 researched). It may be an interesting question how to deal with database-
 specific migrations in reusable apps.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.dfbd47b423c6cc4cc6c4d563a7078768%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by prestontimmons):

 Carl,

 I think the discovery result is still the same as it was when the discover
 runner was merged. Claude's changes simply replaced the old `geo_apps`
 function:

 
https://github.com/django/django/commit/bd563f0f571e7c76b40e8c8d7a0e1f34dcfeb810
 
https://github.com/django/django/commit/57f190ed3b77eb105cc86ecfabc455662410d40a

 Using `discovery_paths` this way—to conditionally add test applications
 from contrib to INSTALLED_APPS—isn't really obvious from the code, though.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fc6a70214bfb7c35629cca1530d2080e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by carljm):

 Hmm, I'll need to look into this a bit more. The issue is not with the
 tests themselves, but with the test models/migrations; in at least the GIS
 case, those fail immediately when creating the test database if you don't
 have a GIS-enabled database backend.

 I know we had this working when the test-discovery branch was merged; I'll
 need to look back and see how it worked then and what's changed since.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f75db1f0ceff2614b616ebc5bbc62d71%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by carljm):

 Yes, that's right. I fixed one issue in
 4932a7b8e0a25c7447d7ad7ae8ae53a35d2541ac yesterday. I have a system here
 that doesn't have GEOS installed, and I can run `runtests.py
 django.contrib.gis` and get a bunch of skipped tests, some passed tests,
 no failures or errors.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6ed686e811a6de3c51fbc1eb1cf6c604%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23879: We should use test-skipping, not conditional discovery in runtests.py

[Django]

#23879: We should use test-skipping, not conditional discovery in runtests.py
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * version:  1.6 => master
 * stage:  Unreviewed => Accepted


Comment:

 In fact I think that `django.contrib.gis` tests already satisfy your
 demand. If someone has a GIS-lib-free system at hand, it would be nice to
 test and report any failure/traceback.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.aaf8e721705e783c02dfbad110f486ae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.