Re: [Django] #26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting django.template.Template is broken

[Django]

#26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting
django.template.Template is broken
-+-
 Reporter:  davidswelt   |Owner:  timgraham
 Type:  Bug  |   Status:  closed
Component:  Template system  |  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"33a4040d07ded45203b47cb2be9de69f9922b36c" 33a4040d]:
 {{{
 #!CommitTicketReference repository=""
 revision="33a4040d07ded45203b47cb2be9de69f9922b36c"
 Refs #26253 -- Forwardported release note.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.bcc7b9027e7aa903d2393538f31baeee%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting django.template.Template is broken

[Django]

#26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting
django.template.Template is broken
-+-
 Reporter:  davidswelt   |Owner:  timgraham
 Type:  Bug  |   Status:  closed
Component:  Template system  |  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"c6ab81db79654fe767b3a1f593d4b8c11dc38934" c6ab81db]:
 {{{
 #!CommitTicketReference repository=""
 revision="c6ab81db79654fe767b3a1f593d4b8c11dc38934"
 [1.9.x] Refs #26253 -- Amended release note as this issue doesn't affect
 1.8.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.521f5f5d85fe331dce131c81ededceab%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting django.template.Template is broken

[Django]

#26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting
django.template.Template is broken
-+-
 Reporter:  davidswelt   |Owner:  timgraham
 Type:  Bug  |   Status:  closed
Component:  Template system  |  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"061a7ff3661bcad4632f1418017c5a9a24a1dc6c" 061a7ff3]:
 {{{
 #!CommitTicketReference repository=""
 revision="061a7ff3661bcad4632f1418017c5a9a24a1dc6c"
 [1.8.x] Refs #26253 -- Added tests for deprecation shims in
 SimpleTemplateResponse.

 Backport of 3fedfc452fa94f8a6c9a64289d00202313ceb564 from stable/1.9.x
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.d2ce1b032b61f4a168f8da4f35edf466%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting django.template.Template is broken

[Django]

#26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting
django.template.Template is broken
-+-
 Reporter:  davidswelt   |Owner:  timgraham
 Type:  Bug  |   Status:  closed
Component:  Template system  |  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"3fedfc452fa94f8a6c9a64289d00202313ceb564" 3fedfc45]:
 {{{
 #!CommitTicketReference repository=""
 revision="3fedfc452fa94f8a6c9a64289d00202313ceb564"
 [1.9.x] Fixed #26253 -- Fixed crashing deprecation shims in
 SimpleTemplateResponse.

 Thanks David Reitter for the report and initial patch.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e172a9b4ec11f0ae1ebf820d879894d7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting django.template.Template is broken

[Django]

#26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting
django.template.Template is broken
-+-
 Reporter:  davidswelt   |Owner:  timgraham
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by charettes):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.701371dab1e2d28199be577412703843%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting django.template.Template is broken

[Django]

#26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting
django.template.Template is broken
-+-
 Reporter:  davidswelt   |Owner:  timgraham
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_tests:  1 => 0


Comment:

 [https://github.com/django/django/pull/6177 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.26bfb9c796614244ecd44c109ed55a39%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting django.template.Template is broken

[Django]

#26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting
django.template.Template is broken
-+-
 Reporter:  davidswelt   |Owner:  timgraham
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * owner:  nobody => timgraham
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.16ff7d68f395ee83fa6ba292fbe95f45%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting django.template.Template is broken

[Django]

#26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting
django.template.Template is broken
-+
 Reporter:  davidswelt   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by davidswelt):

 Sorry, I looked into writing a test and pretty much got stuck with what
 seemed to be the test scripts running the system install of Django rather
 than the code in the checkout.
 I won’t have the time to submit more than the patch I submitted, due to
 various professional obligations.  Apologies.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.6762a8b191193cdcb5434b81da92ee38%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting django.template.Template is broken (was: TemplateResponse and SimpleTemplateResponse: error message causes Ty

[Django]

#26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting
django.template.Template is broken
-+
 Reporter:  davidswelt   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by timgraham):

 * severity:  Normal => Release blocker
 * needs_tests:  0 => 1
 * version:  1.9 => 1.8
 * keywords:  Teamplates =>
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 Oh, I had trouble understanding your patch and the problem. The issue is
 that the backwards compatibility shim crashes. If you are able to add
 tests for the patch and send a pull request, that would be great.
 {{{
 from django.template import Template
 from django.template.response import TemplateResponse
 from django.http import HttpRequest

 request = HttpRequest()
 content = "…"
 t = Template(content)
 response = TemplateResponse(request, t)
 ...
   File "/home/tim/code/django/django/template/response.py", line 28, in
 __init__
 template = BackendTemplate(template)
 TypeError: __init__() missing 1 required positional argument: 'backend'
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.6daea23b0b309a7bee81f07244712be9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.