Re: [Dovecot] Allowing tilde at start of mailbox names [listescape-plugin.c]
Timo Sirainen wrote: I think the latest http://dovecot.org/patches/1.1/listescape-plugin.c should work with latest Dovecot from hg. At least I fixed the most obvious problems. I have been using it for a few weeks and it has been working well, but yesterday I noticed it also seems to be escaping the \ (backslash) character in folder names. This wouldn't be a problem except it breaks operation of folders that already had a \ in the name before the plugin was loaded. This isn't a huge problem for us but I want to figure out if I should special case migration of folder names containing a \ to be the new internal representation \5c or if the plugin should just deal with normal \'s in the foldernames properly. Existing folder names with a \ such as \test still show up as \test in the mail client listing, but all known attempts to access it fail, I think internally it is probably looking for a folder named \5ctest and not finding it. Thus the user cannot read, delete, rename, unsubscribe, anything. They are stuck with a useless folder while the plugin is loaded. I doubt many of our users have this situation and they can contact us to fix it if they notice, but I did have one user alert me of it. On the other hand if a folder and its subscription are manually renamed to \5ctest, it works fine, or if they create a new one it uses a \5c on the backend. Thanks for assistance.
Re: [Dovecot] Allowing tilde at start of mailbox names [listescape-plugin.c]
AM == Adam McDougall [EMAIL PROTECTED] writes: AM I have been using it for a few weeks and it has been working well, AM but yesterday I noticed it also seems to be escaping the \ AM (backslash) character in folder names. listescape has to escape '\' so that applications of decode-encode and encode-decode are idempotent. If it did not do this a client that asked, for example, to create a folder called a\2eb (i.e. issues CREATE a\2eb) would be shown the folder as a.b by dovecot in a subsequent folder listing. AM This wouldn't be a problem except it breaks operation of folders AM that already had a \ in the name before the plugin was loaded. AM This isn't a huge problem for us but I want to figure out if I AM should special case migration of folder names containing a \ to be AM the new internal representation \5c or if the plugin should just AM deal with normal \'s in the foldernames properly. Yes, I think you need to rename folders that contained a '\' in the name before you started using listescape, but clearly you should not rename any folders that have subsequently been created by the listescape plugin that contain a '\'.
Re: [Dovecot] Allowing tilde at start of mailbox names [listescape-plugin.c]
On Wed, Jul 25, 2007 at 08:28:52PM +0300, Timo Sirainen wrote: On 25.7.2007, at 19.13, pod wrote: TS It's mostly there just to make sure that ~/ or ~user/ can't be TS used to open mailboxes where you weren't supposed to have access TS to. I didn't think anyone would really want to have mailboxes TS beginning with ~. Do you really want them? (I don't think they TS were possible with UW-IMAP either?) Unfortunately yes it would be useful in my case to have them because of historical accident. How about if listescape plugin escaped it? That would make it possible to use them but still safe against accidental problems. For others too, I implemented a plugin for escaping mailbox names with Maildir so that it's possible to use '.' in mailbox names: http://dovecot.org/patches/1.0/listescape-plugin.c I am using the 1.1 version of this plugin. So far it seems to be working fine. Is there a chance of having it be an official plugin distributed with 1.1? That would make it fit into my build environment alot cleaner, as well as a FreeBSD port I intend to submit so others can build 1.1 easily. One way or another I plan to keep using listescape and will need to find the best way to keep it functioning alongside dovecot upgrades, even if that means compiling and installing it manually each time. Thanks.
Re: [Dovecot] Allowing tilde at start of mailbox names [listescape-plugin.c]
On Sun, Dec 02, 2007 at 03:01:51AM -0500, Adam McDougall wrote:
On Wed, Jul 25, 2007 at 08:28:52PM +0300, Timo Sirainen wrote:
On 25.7.2007, at 19.13, pod wrote:
TS It's mostly there just to make sure that ~/ or ~user/ can't be
TS used to open mailboxes where you weren't supposed to have access
TS to. I didn't think anyone would really want to have mailboxes
TS beginning with ~. Do you really want them? (I don't think they
TS were possible with UW-IMAP either?)
Unfortunately yes it would be useful in my case to have them because of
historical accident.
How about if listescape plugin escaped it? That would make it possible to
use them but still safe against accidental problems.
For others too, I implemented a plugin for escaping mailbox names with
Maildir so that it's possible to use '.' in mailbox names:
http://dovecot.org/patches/1.0/listescape-plugin.c
I am using the 1.1 version of this plugin. So far it seems to be working
fine.
Is there a chance of having it be an official plugin distributed with 1.1?
That would make it fit into my build environment alot cleaner, as well as
a FreeBSD port I intend to submit so others can build 1.1 easily. One way
or another I plan to keep using listescape and will need to find the best way
to keep it functioning alongside dovecot upgrades, even if that means
compiling
and installing it manually each time. Thanks.
Actually two issues came up. I think they are both involving folder listing.
- In squirrelmail, if I am subscribed to #shared/decs with the listescape
plugin enabled, the shared folders such as #shared/decs/network are greyed out.
#shared/decs is a public namespace and the only reason I would be subscribed to
it is for Outlook Express's sake or so Squirrelmail will show the shared folder
hierarchy (same reason for subscribing to #shared, but being subscribed to
#shared
doesn't seem to hurt anything). I think squirrelmail sees the subscription to
the folder (I can subscribe to unsubscribed shared folders too) but when it
tries
to LIST the folder, it gets nothing.
- In all programs, it seems like listing folders in my additional private hidden
namespaces comes up with nothing. a LIST mail/% a OK List completed.
If I try to access a folder under mail/ directly by typing the path into mutt,
it works.
with listescape:
---
a list dot.test
* LIST (\HasNoChildren) . dot.test
a OK List completed.
a LIST mail/
* LIST (\Noselect \HasChildren) / mail/
a OK List completed.
a LIST mail/%
a OK List completed.
(a LSUB * shows all the folders I am subscribed to, including
#shared/decs/network)
a LSUB #shared/%
* LSUB () / #shared/decs
a OK Lsub completed.
a LIST #shared/decs
* LIST (\Noselect \HasChildren) / #shared/decs
a OK List completed.
a LSUB #shared/decs/%
a OK Lsub completed.
a LIST #shared/decs/network
a OK List completed.
(for some reason in squirrelmail, if I am unsubscribed from #shared/decs with
the listescape
plugin enabled, the shared folders such as #shared/decs/network are not greyed
out and work,
but I cant seem to easily reproduce that result with imap commands.
Without listescape loaded:
---
a list dot\\2etest
* LIST (\HasNoChildren) . {10}
dot\2etest
a OK List completed.
a LIST mail/
* LIST (\Noselect \HasChildren) / mail/
a OK List completed.
a LIST mail/%
* LIST (\HasNoChildren) / mail/20041223
* LIST (\HasNoChildren) / mail/20050324
* LIST (\HasNoChildren) / mail/APA-MEA-DISCUSS
* LIST (\HasNoChildren) / mail/Drafts
* LIST (\HasNoChildren) / mail/IMAP
* LIST (\HasNoChildren) / mail/Junk E-mail
(etc, all the folders I expect)
a LSUB #shared/%
* LSUB () / #shared/decs
a OK Lsub completed.
a LIST #shared/decs
* LIST (\Noselect \HasChildren) / #shared/decs
a OK List completed.
a LSUB #shared/decs/%
* LSUB () / #shared/decs/unixadmin
* LSUB () / #shared/decs/support
* LSUB () / #shared/decs/security
* LSUB () / #shared/decs/printmaster
* LSUB () / #shared/decs/postmaster
* LSUB () / #shared/decs/pcadmin
* LSUB () / #shared/decs/network
* LSUB () / #shared/decs/linuxadmin
a OK Lsub completed.
a LIST #shared/decs/network
* LIST (\HasChildren) / #shared/decs/network
a OK List completed.
# 1.1.beta9: /usr/local/etc/dovecot.conf
ssl_cert_file: /usr/local/etc/apache2/ssl/mail.egr.msu.edu.pem
ssl_key_file: /usr/local/etc/apache2/ssl/mail.egr.msu.edu.pem
login_dir: /var/run/dovecot/login
login_executable: /usr/local/libexec/dovecot/imap-login
mail_max_userip_connections: 25
verbose_proctitle: yes
first_valid_uid: 1000
first_valid_gid: 1000
mail_extra_groups: postlocal
mail_location:
maildir:%h/Maildir:CONTROL=%h/Maildir/dovecot/private/control:INDEX=%h/Maildir/dovecot/private/indexes
mmap_disable: yes
dotlock_use_excl: yes
mail_nfs_storage: yes
mail_nfs_index: yes
mail_plugins: acl fts fts_squat listescape
mail_log_max_lines_per_sec: 0
Re: [Dovecot] Allowing tilde at start of mailbox names
On 25.7.2007, at 16.35, pod wrote: In lib-storage/index/maildir/maildir-storage.c maildir_is_valid_create_name() and maildir_is_valid_existing_name() the following sequence of tests appear but I don't really understand why It's mostly there just to make sure that ~/ or ~user/ can't be used to open mailboxes where you weren't supposed to have access to. I didn't think anyone would really want to have mailboxes beginning with ~. Do you really want them? (I don't think they were possible with UW-IMAP either?) Why is it not possible to have mailbox names that begin with '~' but without '~' carrying any special meaning? That's what the code does if you don't have mail_full_filesystem_access=yes, but I thought I'd prevent this in =no case just in case of a bug somewhere, possibly even outside of Dovecot itself. I have been working on a patch (appended but incomplete; the option only works against maildir atm) that adds a new option mail_allow_tilde and my admittedly limited testing seems to indicate that it does the right thing but maybe I am barking up the wrong tree. Am I missing something here? There are too many settings already. mail_full_filesystem_access=no should be enough for this. PGP.sig Description: This is a digitally signed message part
Re: [Dovecot] Allowing tilde at start of mailbox names
TS == Timo Sirainen [EMAIL PROTECTED] writes:
TS It's mostly there just to make sure that ~/ or ~user/ can't be
TS used to open mailboxes where you weren't supposed to have access
TS to. I didn't think anyone would really want to have mailboxes
TS beginning with ~. Do you really want them? (I don't think they
TS were possible with UW-IMAP either?)
Unfortunately yes it would be useful in my case to have them because of
historical accident. UW-IMAP does in fact allow it but maybe only if one
is using particular build-time options such as blackBoxDir; I forget the
precise details. Suffice to say at some point users were erroneously told
to configure clients with '~/mail' as a prefix and this in combination
with the particular UW-IMAP build options means we have users with folder
hierarchies beginning ~/mail ('~' uninterpreted). I don't think I can
work around this with a hidden namespace since a client subsequently
configured not to use a prefix will be used to seeing folders under
~/mail ('~' uninterpreted). I'm (increasingly forlornly it seems)
attempting to migrate with no user visible change.
Why is it not possible to have mailbox names that begin with '~'
but without '~' carrying any special meaning?
TS That's what the code does if you don't have
TS mail_full_filesystem_access=yes, but I thought I'd prevent this in
TS no case just in case of a bug somewhere, possibly even outside of
TS Dovecot itself.
I appreciate your reasoning regarding bugs elsewhere. I was, however,
hoping to introduce a mode of behaviour that would allow me to accept the
risk. I'm not using virtual users; every login runs under its own uid so
I still have filesystem permissions as a reasonable fall back.
TS There are too many settings
TS already. mail_full_filesystem_access=no should be enough for this.
I completely understand why you want to keep the number of setting down.
My motivation for introducing a new setting was a vain hope that allowing
uninterpreted (*name == '~') behaviour could go into the 1.0 codebase but
without also changing the meaning of mail_full_filesystem_access=no in
existing deployments.
Re: [Dovecot] Allowing tilde at start of mailbox names
On 25.7.2007, at 19.13, pod wrote: TS It's mostly there just to make sure that ~/ or ~user/ can't be TS used to open mailboxes where you weren't supposed to have access TS to. I didn't think anyone would really want to have mailboxes TS beginning with ~. Do you really want them? (I don't think they TS were possible with UW-IMAP either?) Unfortunately yes it would be useful in my case to have them because of historical accident. How about if listescape plugin escaped it? That would make it possible to use them but still safe against accidental problems. For others too, I implemented a plugin for escaping mailbox names with Maildir so that it's possible to use '.' in mailbox names: http://dovecot.org/patches/1.0/listescape-plugin.c PGP.sig Description: This is a digitally signed message part
Re: [Dovecot] Allowing tilde at start of mailbox names
TS == Timo Sirainen [EMAIL PROTECTED] writes: TS How about if listescape plugin escaped it? That would make it TS possible to use them but still safe against accidental problems. Yes, I think that would work fine at least for my particular purposes since we'll almost certainly be running with the listescape plugin anyway. TS For others too, I implemented a plugin for escaping mailbox names TS with Maildir so that it's possible to use '.' in mailbox names: TS http://dovecot.org/patches/1.0/listescape-plugin.c Not one to blow your own trumpet are you! For further explanation for the benefit of the list: I recently contacted Timo privately asking if he would consider us funding him to implement a modified maildir layout for us. A few hours later he responded with listescape-plugin.c. What an absolute star.
