[patch v2] nouveau: unwind on load errors
On Fri, Jul 30, 2010 at 05:04:32PM +0200, Dan Carpenter wrote:
> nuveau_load() just returned directly if there was an error instead of
>
^^ typo
> releasing resources.
>
>
> Signed-off-by: Dan Carpenter
> ---
> V2: updated to the nouveau git tree.
Thanks.
Reviewed-by: Marcin Slusarz
> diff --git a/drivers/gpu/drm/nouveau/nouveau_state.c
> b/drivers/gpu/drm/nouveau/nouveau_state.c
> index ee3729e..cf16bfb 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_state.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_state.c
> @@ -739,8 +739,10 @@ int nouveau_load(struct drm_device *dev, unsigned long
> flags)
> int ret;
>
> dev_priv = kzalloc(sizeof(*dev_priv), GFP_KERNEL);
> - if (!dev_priv)
> - return -ENOMEM;
> + if (!dev_priv) {
> + ret = -ENOMEM;
> + goto err_out;
> + }
> dev->dev_private = dev_priv;
> dev_priv->dev = dev;
>
> @@ -750,8 +752,10 @@ int nouveau_load(struct drm_device *dev, unsigned long
> flags)
>dev->pci_vendor, dev->pci_device, dev->pdev->class);
>
> dev_priv->wq = create_workqueue("nouveau");
> - if (!dev_priv->wq)
> - return -EINVAL;
> + if (!dev_priv->wq) {
> + ret = -EINVAL;
> + goto err_priv;
> + }
>
> /* resource 0 is mmio regs */
> /* resource 1 is linear FB */
> @@ -764,7 +768,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
> flags)
> if (!dev_priv->mmio) {
> NV_ERROR(dev, "Unable to initialize the mmio mapping. "
>"Please report your setup to " DRIVER_EMAIL "\n");
> - return -EINVAL;
> + ret = -EINVAL;
> + goto err_wq;
> }
> NV_DEBUG(dev, "regs mapped ok at 0x%llx\n",
> (unsigned long long)mmio_start_offs);
> @@ -812,7 +817,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
> flags)
> break;
> default:
> NV_INFO(dev, "Unsupported chipset 0x%08x\n", reg0);
> - return -EINVAL;
> + ret = -EINVAL;
> + goto err_mmio;
> }
>
> NV_INFO(dev, "Detected an NV%2x generation card (0x%08x)\n",
> @@ -820,7 +826,7 @@ int nouveau_load(struct drm_device *dev, unsigned long
> flags)
>
> ret = nouveau_remove_conflicting_drivers(dev);
> if (ret)
> - return ret;
> + goto err_mmio;
>
> /* Map PRAMIN BAR, or on older cards, the aperture withing BAR0 */
> if (dev_priv->card_type >= NV_40) {
> @@ -834,7 +840,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
> flags)
> dev_priv->ramin_size);
> if (!dev_priv->ramin) {
> NV_ERROR(dev, "Failed to PRAMIN BAR");
> - return -ENOMEM;
> + ret = -ENOMEM;
> + goto err_mmio;
> }
> } else {
> dev_priv->ramin_size = 1 * 1024 * 1024;
> @@ -842,7 +849,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
> flags)
> dev_priv->ramin_size);
> if (!dev_priv->ramin) {
> NV_ERROR(dev, "Failed to map BAR0 PRAMIN.\n");
> - return -ENOMEM;
> + ret = -ENOMEM;
> + goto err_mmio;
> }
> }
>
> @@ -857,9 +865,21 @@ int nouveau_load(struct drm_device *dev, unsigned long
> flags)
> /* For kernel modesetting, init card now and bring up fbcon */
> ret = nouveau_card_init(dev);
> if (ret)
> - return ret;
> + goto err_ramin;
>
> return 0;
> +
> +err_ramin:
> + iounmap(dev_priv->ramin);
> +err_mmio:
> + iounmap(dev_priv->mmio);
> +err_wq:
> + destroy_workqueue(dev_priv->wq);
> +err_priv:
> + kfree(dev_priv);
> + dev->dev_private = NULL;
> +err_out:
> + return ret;
> }
>
> void nouveau_lastclose(struct drm_device *dev)
No subject
df16dd53c575d0cb9dbee20a3149927c862a9ff6 hwmon: (ltc4245) Read only one GPIO pin and *sometime* before this commit: 09bdf591f4724c7d0328d4d7b8808492addb5a28 drm/radeon/kms: fix dpms state on resume Alex, I am pretty much a 'newb' when it comes to git and the kernel in general and currently git is making my brain hurt severely. When I have the time I will read up more on git and try and work out an easy way to exclude unrelated commits that break my kernel and include bug fix commits that allow me to bisect this issue successfully. Any pointers to articles/howtos on dealing with this specific kind of issue with git? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[patch v2] nouveau: unwind on load errors
nuveau_load() just returned directly if there was an error instead of
releasing resources.
Signed-off-by: Dan Carpenter
---
V2: updated to the nouveau git tree.
diff --git a/drivers/gpu/drm/nouveau/nouveau_state.c
b/drivers/gpu/drm/nouveau/nouveau_state.c
index ee3729e..cf16bfb 100644
--- a/drivers/gpu/drm/nouveau/nouveau_state.c
+++ b/drivers/gpu/drm/nouveau/nouveau_state.c
@@ -739,8 +739,10 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
int ret;
dev_priv = kzalloc(sizeof(*dev_priv), GFP_KERNEL);
- if (!dev_priv)
- return -ENOMEM;
+ if (!dev_priv) {
+ ret = -ENOMEM;
+ goto err_out;
+ }
dev->dev_private = dev_priv;
dev_priv->dev = dev;
@@ -750,8 +752,10 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
dev->pci_vendor, dev->pci_device, dev->pdev->class);
dev_priv->wq = create_workqueue("nouveau");
- if (!dev_priv->wq)
- return -EINVAL;
+ if (!dev_priv->wq) {
+ ret = -EINVAL;
+ goto err_priv;
+ }
/* resource 0 is mmio regs */
/* resource 1 is linear FB */
@@ -764,7 +768,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
if (!dev_priv->mmio) {
NV_ERROR(dev, "Unable to initialize the mmio mapping. "
"Please report your setup to " DRIVER_EMAIL "\n");
- return -EINVAL;
+ ret = -EINVAL;
+ goto err_wq;
}
NV_DEBUG(dev, "regs mapped ok at 0x%llx\n",
(unsigned long long)mmio_start_offs);
@@ -812,7 +817,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
break;
default:
NV_INFO(dev, "Unsupported chipset 0x%08x\n", reg0);
- return -EINVAL;
+ ret = -EINVAL;
+ goto err_mmio;
}
NV_INFO(dev, "Detected an NV%2x generation card (0x%08x)\n",
@@ -820,7 +826,7 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
ret = nouveau_remove_conflicting_drivers(dev);
if (ret)
- return ret;
+ goto err_mmio;
/* Map PRAMIN BAR, or on older cards, the aperture withing BAR0 */
if (dev_priv->card_type >= NV_40) {
@@ -834,7 +840,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
dev_priv->ramin_size);
if (!dev_priv->ramin) {
NV_ERROR(dev, "Failed to PRAMIN BAR");
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_mmio;
}
} else {
dev_priv->ramin_size = 1 * 1024 * 1024;
@@ -842,7 +849,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
dev_priv->ramin_size);
if (!dev_priv->ramin) {
NV_ERROR(dev, "Failed to map BAR0 PRAMIN.\n");
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_mmio;
}
}
@@ -857,9 +865,21 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
/* For kernel modesetting, init card now and bring up fbcon */
ret = nouveau_card_init(dev);
if (ret)
- return ret;
+ goto err_ramin;
return 0;
+
+err_ramin:
+ iounmap(dev_priv->ramin);
+err_mmio:
+ iounmap(dev_priv->mmio);
+err_wq:
+ destroy_workqueue(dev_priv->wq);
+err_priv:
+ kfree(dev_priv);
+ dev->dev_private = NULL;
+err_out:
+ return ret;
}
void nouveau_lastclose(struct drm_device *dev)
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #7 from Droste 2010-07-30 15:58:29 PDT --- Created an attachment (id=37477) --> (https://bugs.freedesktop.org/attachment.cgi?id=37477) Xorg log with MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #6 from Droste 2010-07-30 15:57:58 PDT --- Created an attachment (id=37476) --> (https://bugs.freedesktop.org/attachment.cgi?id=37476) lspci -vt with MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Droste changed: What|Removed |Added Attachment #37475|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Droste changed: What|Removed |Added Attachment #37474|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Droste changed: What|Removed |Added Attachment #37473|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Droste changed: What|Removed |Added Attachment #37472|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Droste changed: What|Removed |Added Attachment #37471|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Droste changed: What|Removed |Added Attachment #37470|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #5 from Droste 2010-07-30 15:55:00 PDT --- Created an attachment (id=37475) --> (https://bugs.freedesktop.org/attachment.cgi?id=37475) lspci -vnn with MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #4 from Droste 2010-07-30 15:54:26 PDT --- Created an attachment (id=37474) --> (https://bugs.freedesktop.org/attachment.cgi?id=37474) dmesg with MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #3 from Droste 2010-07-30 15:43:34 PDT --- Created an attachment (id=37473) --> (https://bugs.freedesktop.org/attachment.cgi?id=37473) Xorg log without MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #2 from Droste 2010-07-30 15:43:09 PDT --- Created an attachment (id=37472) --> (https://bugs.freedesktop.org/attachment.cgi?id=37472) lspci -vt without MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #1 from Droste 2010-07-30 15:42:22 PDT --- Created an attachment (id=37471) --> (https://bugs.freedesktop.org/attachment.cgi?id=37471) lspci -vnn without MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29327] New: radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Summary: radeon interrupts don't fire with MSI Product: DRI Version: DRI CVS Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/Radeon AssignedTo: dri-devel at lists.freedesktop.org ReportedBy: tdroste at gmx.de Created an attachment (id=37470) --> (https://bugs.freedesktop.org/attachment.cgi?id=37470) dmesg without MSI If I boot the current d-r-t kernel with MSI enabled the radeon module doesn't fire any interrupts. Without the interrupts and vblank_mode in driconf set to 3 the screen stops refreshing. This is always reproducible. To make it work again I have to boot with pci=nomsi. Software versions kernel current d-r-t (2.6.35-rc2) ddx, mesa, xserver git master Hardware Radeon X1950pro RV570 (AGP) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[PATCH] drm: nouveau: set TASK_(UN)INTERRUPTIBLE before schedule_timeout()
Kulikov Vasiliy writes:
> set_current_state() is called only once before the first iteration.
> After return from schedule_timeout() current state is TASK_RUNNING. If
> we are going to wait again, set_current_state() must be called.
>
> Signed-off-by: Kulikov Vasiliy
> ---
> drivers/gpu/drm/nouveau/nouveau_fence.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
Thanks, I've pushed this patch to the Nouveau kernel tree.
> diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c
> b/drivers/gpu/drm/nouveau/nouveau_fence.c
> index 813d853..bae 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_fence.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
> @@ -186,7 +186,6 @@ nouveau_fence_wait(void *sync_obj, void *sync_arg, bool
> lazy, bool intr)
> unsigned long timeout = jiffies + (3 * DRM_HZ);
> int ret = 0;
>
> - __set_current_state(intr ? TASK_INTERRUPTIBLE : TASK_UNINTERRUPTIBLE);
>
> while (1) {
> if (nouveau_fence_signalled(sync_obj, sync_arg))
> @@ -197,6 +196,8 @@ nouveau_fence_wait(void *sync_obj, void *sync_arg, bool
> lazy, bool intr)
> break;
> }
>
> + __set_current_state(intr ? TASK_INTERRUPTIBLE
> + : TASK_UNINTERRUPTIBLE);
> if (lazy)
> schedule_timeout(1);
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20100730/05c183cb/attachment.pgp>
[Bug 29323] New: [r300g] floor texture damage
https://bugs.freedesktop.org/show_bug.cgi?id=29323 Summary: [r300g] floor texture damage Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: minor Priority: low Component: Drivers/DRI/r300 AssignedTo: dri-devel at lists.freedesktop.org ReportedBy: d.okias at gmail.com Created an attachment (id=37465) --> (https://bugs.freedesktop.org/attachment.cgi?id=37465) sweethome.jpeg When I look in: Sweethome or Counter Strike 1.6 on the floor, which is distanced, then it show some black artefacts in that area. After coming closer (in both programs) it disapear. HW: RS690 Debug: none assert or warning. dmesg: https://bugs.freedesktop.org/attachment.cgi?id=37439 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 25483] Neverwinter nights lacks ram when using the radeon driver
https://bugs.freedesktop.org/show_bug.cgi?id=25483 --- Comment #24 from Alex Deucher 2010-07-30 12:50:07 PDT --- Created an attachment (id=37464) View: https://bugs.freedesktop.org/attachment.cgi?id=37464 Review: https://bugs.freedesktop.org/review?bug=25483=37464 possible fix Does this patch help? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 27443] radeonFreeTexImageData: Assertion `!image->base.Data' failed when running Ogre3D samples
https://bugs.freedesktop.org/show_bug.cgi?id=27443 --- Comment #7 from Tobias Jakobi 2010-07-30 12:07:32 PDT --- Confirming this problem for ut2004, only the 'Instant Action' gamemode works for me -- all other fail with this assertion. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 27443] radeonFreeTexImageData: Assertion `!image->base.Data' failed when running Ogre3D samples
https://bugs.freedesktop.org/show_bug.cgi?id=27443 --- Comment #6 from Jon Sturm 2010-07-30 11:51:44 PDT --- Created an attachment (id=37463) --> (https://bugs.freedesktop.org/attachment.cgi?id=37463) UT2004.log I have attached the logfile UT2004 gives me after it claims to recive a SIGBUS due to this bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 27443] radeonFreeTexImageData: Assertion `!image->base.Data' failed when running Ogre3D samples
https://bugs.freedesktop.org/show_bug.cgi?id=27443 --- Comment #5 from Jon Sturm 2010-07-30 11:48:22 PDT --- I am getting this same error on my rv730 card, Radeon HD4850, as soon as a map loads for any gametype in UT2004. I am running a custom built kernel from airlied's DRM-Radeon-Testing branch and libdrm, mesa, and ddx all from git. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29322] Very slow rendering with UMS on radeon 9000 AGP (rv250)
https://bugs.freedesktop.org/show_bug.cgi?id=29322 --- Comment #3 from support.intranet at libero.it 2010-07-30 10:34:30 PDT --- Gl renderer is identified as Mesa DRI R200 (RV250 4966) 20090101 AGP 2x x86/MMX/SSE TCL, so the identifier "software rendering" is probably incorrect. I would probably need to say "99% of 3D apps run so slow that it seems like they are rendered by the CPU or there is some serious bug in the driver". -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29322] Very slow rendering with UMS on radeon 9000 AGP (rv250)
https://bugs.freedesktop.org/show_bug.cgi?id=29322 support.intranet at libero.it changed: What|Removed |Added Summary|Software rendering with UMS |Very slow rendering with |on radeon 9000 AGP (rv250) |UMS on radeon 9000 AGP ||(rv250) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 27744] atombios stuck in loop - during suspend
https://bugs.freedesktop.org/show_bug.cgi?id=27744 --- Comment #12 from willjcroz 2010-07-30 10:23:57 PDT --- (In reply to comment #11) > As a rough indicator for now: 2.6.35 rc3 resumes (from ram suspend) OK Scrub that, rc3 does not resume (either some weird fluke or my mistake). I'm afraid I didn't get very far bisecting. Basically none of 2.6.34 (release) and 2.6.35-rc kernels resume. I'm assuming you are only interested in when the atombios errors appear. Sometime between 2.6.34 and 2.6.35-rc1 a bug was introduced preventing my kernel from booting until just before 2.6.35-rc3.
[Bug 29322] Software rendering with UMS on radeon 9000 AGP (rv250)
https://bugs.freedesktop.org/show_bug.cgi?id=29322 --- Comment #2 from support.intranet at libero.it 2010-07-30 09:41:56 PDT --- Created an attachment (id=37462) --> (https://bugs.freedesktop.org/attachment.cgi?id=37462) glxinfo Says direct rendering enabled, but actually it isn't (except from a few simple apps) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29322] Software rendering with UMS on radeon 9000 AGP (rv250)
https://bugs.freedesktop.org/show_bug.cgi?id=29322 --- Comment #1 from support.intranet at libero.it 2010-07-30 09:40:40 PDT --- Created an attachment (id=37461) --> (https://bugs.freedesktop.org/attachment.cgi?id=37461) Xorg.0.log -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29322] New: Software rendering with UMS on radeon 9000 AGP (rv250)
https://bugs.freedesktop.org/show_bug.cgi?id=29322 Summary: Software rendering with UMS on radeon 9000 AGP (rv250) Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/r200 AssignedTo: dri-devel at lists.freedesktop.org ReportedBy: support.intranet at libero.it Created an attachment (id=37460) --> (https://bugs.freedesktop.org/attachment.cgi?id=37460) dmesg Booting with radeon.modeset=0 (kernel 2.6.34.1) makes every 3D app (except from glxgears and OpenBVE so far) run in software rendering, at about 0.2 fps. With KMS 3d works in hardware, but is very sluggish (together with 2D). This happens with mesa 7.7 through git. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29318] Marbleblast textures broken on r600
https://bugs.freedesktop.org/show_bug.cgi?id=29318 --- Comment #2 from Adam K Kirchhoff 2010-07-30 05:30:54 PDT --- Created an attachment (id=37458) --> (https://bugs.freedesktop.org/attachment.cgi?id=37458) Good textures with r300 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29318] Marbleblast textures broken on r600
https://bugs.freedesktop.org/show_bug.cgi?id=29318 --- Comment #1 from Adam K Kirchhoff 2010-07-30 05:30:24 PDT --- Created an attachment (id=37457) --> (https://bugs.freedesktop.org/attachment.cgi?id=37457) Bad textures with r600 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29318] New: Marbleblast textures broken on r600
https://bugs.freedesktop.org/show_bug.cgi?id=29318 Summary: Marbleblast textures broken on r600 Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel at lists.freedesktop.org ReportedBy: akirchhoff135014 at comcast.net On some levels the textures in marbleblast are washed out. The demo is available here: http://www.torquepowered.com/products/download/15 You can see this on intermediate level 24. Mesa is from git: 2.0 Mesa 7.9-devel. Happens with both KMS and UMS. Works fine with both r300 and fglrx. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29317] Neverwinter night cloak texture is broken on r600
https://bugs.freedesktop.org/show_bug.cgi?id=29317 --- Comment #2 from Adam K Kirchhoff 2010-07-30 04:01:53 PDT --- Created an attachment (id=37456) --> (https://bugs.freedesktop.org/attachment.cgi?id=37456) How should look, courtesy of fglrx. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29317] Neverwinter night cloak texture is broken on r600
https://bugs.freedesktop.org/show_bug.cgi?id=29317 --- Comment #1 from Adam K Kirchhoff 2010-07-30 04:01:21 PDT --- Created an attachment (id=37455) --> (https://bugs.freedesktop.org/attachment.cgi?id=37455) How it looks with r600 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29317] New: Neverwinter night cloak texture is broken on r600
https://bugs.freedesktop.org/show_bug.cgi?id=29317 Summary: Neverwinter night cloak texture is broken on r600 Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel at lists.freedesktop.org ReportedBy: akirchhoff135014 at comcast.net With r600, mesa from git (2.0 Mesa 7.9-devel) both with and without KMS, the texture on my players cloak flickers constantly. The cloak also does not move properly with the character. For example, if I rest, my character sits down, but the cloak remains standing. Works fine with fglrx and with r300. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 25483] Neverwinter nights lacks ram when using the radeon driver
https://bugs.freedesktop.org/show_bug.cgi?id=25483 --- Comment #23 from Adam K Kirchhoff 2010-07-30 03:55:40 PDT --- I have seen these leaks as well. It gets to the point where the OOM killer kicks in and things start dying. Has anyone taken a stab at fixing these leaks? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[git pull] drm fixes
Just two, one edid, the other a radeon pm info reporting fix. The following changes since commit fc0f5ac8fe693d1b05f5a928cc48135d1c8b7f2e: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs (2010-07-27 14:32:59 -0700) are available in the git repository at: ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-fixes Adam Jackson (1): drm/edid: Fix the HDTV hack sync adjustment Daniel J Blueman (1): drm/radeon/kms: fix radeon mid power profile reporting drivers/gpu/drm/drm_edid.c |4 ++-- drivers/gpu/drm/radeon/radeon_pm.c |1 + 2 files changed, 3 insertions(+), 2 deletions(-)
[Bug 25483] Neverwinter nights lacks ram when using the radeon driver
https://bugs.freedesktop.org/show_bug.cgi?id=25483 --- Comment #23 from Adam K Kirchhoff akirchhoff135...@comcast.net 2010-07-30 03:55:40 PDT --- I have seen these leaks as well. It gets to the point where the OOM killer kicks in and things start dying. Has anyone taken a stab at fixing these leaks? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29317] New: Neverwinter night cloak texture is broken on r600
https://bugs.freedesktop.org/show_bug.cgi?id=29317 Summary: Neverwinter night cloak texture is broken on r600 Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: akirchhoff135...@comcast.net With r600, mesa from git (2.0 Mesa 7.9-devel) both with and without KMS, the texture on my players cloak flickers constantly. The cloak also does not move properly with the character. For example, if I rest, my character sits down, but the cloak remains standing. Works fine with fglrx and with r300. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29317] Neverwinter night cloak texture is broken on r600
https://bugs.freedesktop.org/show_bug.cgi?id=29317 --- Comment #1 from Adam K Kirchhoff akirchhoff135...@comcast.net 2010-07-30 04:01:21 PDT --- Created an attachment (id=37455) -- (https://bugs.freedesktop.org/attachment.cgi?id=37455) How it looks with r600 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29317] Neverwinter night cloak texture is broken on r600
https://bugs.freedesktop.org/show_bug.cgi?id=29317 --- Comment #2 from Adam K Kirchhoff akirchhoff135...@comcast.net 2010-07-30 04:01:53 PDT --- Created an attachment (id=37456) -- (https://bugs.freedesktop.org/attachment.cgi?id=37456) How should look, courtesy of fglrx. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29318] New: Marbleblast textures broken on r600
https://bugs.freedesktop.org/show_bug.cgi?id=29318 Summary: Marbleblast textures broken on r600 Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: akirchhoff135...@comcast.net On some levels the textures in marbleblast are washed out. The demo is available here: http://www.torquepowered.com/products/download/15 You can see this on intermediate level 24. Mesa is from git: 2.0 Mesa 7.9-devel. Happens with both KMS and UMS. Works fine with both r300 and fglrx. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29318] Marbleblast textures broken on r600
https://bugs.freedesktop.org/show_bug.cgi?id=29318 --- Comment #2 from Adam K Kirchhoff akirchhoff135...@comcast.net 2010-07-30 05:30:54 PDT --- Created an attachment (id=37458) -- (https://bugs.freedesktop.org/attachment.cgi?id=37458) Good textures with r300 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[patch v2] nouveau: unwind on load errors
nuveau_load() just returned directly if there was an error instead of
releasing resources.
Signed-off-by: Dan Carpenter erro...@gmail.com
---
V2: updated to the nouveau git tree.
diff --git a/drivers/gpu/drm/nouveau/nouveau_state.c
b/drivers/gpu/drm/nouveau/nouveau_state.c
index ee3729e..cf16bfb 100644
--- a/drivers/gpu/drm/nouveau/nouveau_state.c
+++ b/drivers/gpu/drm/nouveau/nouveau_state.c
@@ -739,8 +739,10 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
int ret;
dev_priv = kzalloc(sizeof(*dev_priv), GFP_KERNEL);
- if (!dev_priv)
- return -ENOMEM;
+ if (!dev_priv) {
+ ret = -ENOMEM;
+ goto err_out;
+ }
dev-dev_private = dev_priv;
dev_priv-dev = dev;
@@ -750,8 +752,10 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
dev-pci_vendor, dev-pci_device, dev-pdev-class);
dev_priv-wq = create_workqueue(nouveau);
- if (!dev_priv-wq)
- return -EINVAL;
+ if (!dev_priv-wq) {
+ ret = -EINVAL;
+ goto err_priv;
+ }
/* resource 0 is mmio regs */
/* resource 1 is linear FB */
@@ -764,7 +768,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
if (!dev_priv-mmio) {
NV_ERROR(dev, Unable to initialize the mmio mapping.
Please report your setup to DRIVER_EMAIL \n);
- return -EINVAL;
+ ret = -EINVAL;
+ goto err_wq;
}
NV_DEBUG(dev, regs mapped ok at 0x%llx\n,
(unsigned long long)mmio_start_offs);
@@ -812,7 +817,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
break;
default:
NV_INFO(dev, Unsupported chipset 0x%08x\n, reg0);
- return -EINVAL;
+ ret = -EINVAL;
+ goto err_mmio;
}
NV_INFO(dev, Detected an NV%2x generation card (0x%08x)\n,
@@ -820,7 +826,7 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
ret = nouveau_remove_conflicting_drivers(dev);
if (ret)
- return ret;
+ goto err_mmio;
/* Map PRAMIN BAR, or on older cards, the aperture withing BAR0 */
if (dev_priv-card_type = NV_40) {
@@ -834,7 +840,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
dev_priv-ramin_size);
if (!dev_priv-ramin) {
NV_ERROR(dev, Failed to PRAMIN BAR);
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_mmio;
}
} else {
dev_priv-ramin_size = 1 * 1024 * 1024;
@@ -842,7 +849,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
dev_priv-ramin_size);
if (!dev_priv-ramin) {
NV_ERROR(dev, Failed to map BAR0 PRAMIN.\n);
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_mmio;
}
}
@@ -857,9 +865,21 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
/* For kernel modesetting, init card now and bring up fbcon */
ret = nouveau_card_init(dev);
if (ret)
- return ret;
+ goto err_ramin;
return 0;
+
+err_ramin:
+ iounmap(dev_priv-ramin);
+err_mmio:
+ iounmap(dev_priv-mmio);
+err_wq:
+ destroy_workqueue(dev_priv-wq);
+err_priv:
+ kfree(dev_priv);
+ dev-dev_private = NULL;
+err_out:
+ return ret;
}
void nouveau_lastclose(struct drm_device *dev)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29322] New: Software rendering with UMS on radeon 9000 AGP (rv250)
https://bugs.freedesktop.org/show_bug.cgi?id=29322 Summary: Software rendering with UMS on radeon 9000 AGP (rv250) Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/r200 AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: support.intra...@libero.it Created an attachment (id=37460) -- (https://bugs.freedesktop.org/attachment.cgi?id=37460) dmesg Booting with radeon.modeset=0 (kernel 2.6.34.1) makes every 3D app (except from glxgears and OpenBVE so far) run in software rendering, at about 0.2 fps. With KMS 3d works in hardware, but is very sluggish (together with 2D). This happens with mesa 7.7 through git. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29322] Very slow rendering with UMS on radeon 9000 AGP (rv250)
https://bugs.freedesktop.org/show_bug.cgi?id=29322 support.intra...@libero.it changed: What|Removed |Added Summary|Software rendering with UMS |Very slow rendering with |on radeon 9000 AGP (rv250) |UMS on radeon 9000 AGP ||(rv250) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29322] Very slow rendering with UMS on radeon 9000 AGP (rv250)
https://bugs.freedesktop.org/show_bug.cgi?id=29322 --- Comment #3 from support.intra...@libero.it 2010-07-30 10:34:30 PDT --- Gl renderer is identified as Mesa DRI R200 (RV250 4966) 20090101 AGP 2x x86/MMX/SSE TCL, so the identifier software rendering is probably incorrect. I would probably need to say 99% of 3D apps run so slow that it seems like they are rendered by the CPU or there is some serious bug in the driver. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 27443] radeonFreeTexImageData: Assertion `!image-base.Data' failed when running Ogre3D samples
https://bugs.freedesktop.org/show_bug.cgi?id=27443 --- Comment #5 from Jon Sturm jasturm...@aol.com 2010-07-30 11:48:22 PDT --- I am getting this same error on my rv730 card, Radeon HD4850, as soon as a map loads for any gametype in UT2004. I am running a custom built kernel from airlied's DRM-Radeon-Testing branch and libdrm, mesa, and ddx all from git. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 27443] radeonFreeTexImageData: Assertion `!image-base.Data' failed when running Ogre3D samples
https://bugs.freedesktop.org/show_bug.cgi?id=27443 --- Comment #6 from Jon Sturm jasturm...@aol.com 2010-07-30 11:51:44 PDT --- Created an attachment (id=37463) -- (https://bugs.freedesktop.org/attachment.cgi?id=37463) UT2004.log I have attached the logfile UT2004 gives me after it claims to recive a SIGBUS due to this bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 27443] radeonFreeTexImageData: Assertion `!image-base.Data' failed when running Ogre3D samples
https://bugs.freedesktop.org/show_bug.cgi?id=27443 --- Comment #7 from Tobias Jakobi liquid.a...@gmx.net 2010-07-30 12:07:32 PDT --- Confirming this problem for ut2004, only the 'Instant Action' gamemode works for me -- all other fail with this assertion. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 25483] Neverwinter nights lacks ram when using the radeon driver
https://bugs.freedesktop.org/show_bug.cgi?id=25483 --- Comment #24 from Alex Deucher ag...@yahoo.com 2010-07-30 12:50:07 PDT --- Created an attachment (id=37464) View: https://bugs.freedesktop.org/attachment.cgi?id=37464 Review: https://bugs.freedesktop.org/review?bug=25483attachment=37464 possible fix Does this patch help? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29323] New: [r300g] floor texture damage
https://bugs.freedesktop.org/show_bug.cgi?id=29323 Summary: [r300g] floor texture damage Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: minor Priority: low Component: Drivers/DRI/r300 AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: d.ok...@gmail.com Created an attachment (id=37465) -- (https://bugs.freedesktop.org/attachment.cgi?id=37465) sweethome.jpeg When I look in: Sweethome or Counter Strike 1.6 on the floor, which is distanced, then it show some black artefacts in that area. After coming closer (in both programs) it disapear. HW: RS690 Debug: none assert or warning. dmesg: https://bugs.freedesktop.org/attachment.cgi?id=37439 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [patch v2] nouveau: unwind on load errors
On Fri, Jul 30, 2010 at 05:04:32PM +0200, Dan Carpenter wrote:
nuveau_load() just returned directly if there was an error instead of
^^ typo
releasing resources.
Signed-off-by: Dan Carpenter erro...@gmail.com
---
V2: updated to the nouveau git tree.
Thanks.
Reviewed-by: Marcin Slusarz marcin.slus...@gmail.com
diff --git a/drivers/gpu/drm/nouveau/nouveau_state.c
b/drivers/gpu/drm/nouveau/nouveau_state.c
index ee3729e..cf16bfb 100644
--- a/drivers/gpu/drm/nouveau/nouveau_state.c
+++ b/drivers/gpu/drm/nouveau/nouveau_state.c
@@ -739,8 +739,10 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
int ret;
dev_priv = kzalloc(sizeof(*dev_priv), GFP_KERNEL);
- if (!dev_priv)
- return -ENOMEM;
+ if (!dev_priv) {
+ ret = -ENOMEM;
+ goto err_out;
+ }
dev-dev_private = dev_priv;
dev_priv-dev = dev;
@@ -750,8 +752,10 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
dev-pci_vendor, dev-pci_device, dev-pdev-class);
dev_priv-wq = create_workqueue(nouveau);
- if (!dev_priv-wq)
- return -EINVAL;
+ if (!dev_priv-wq) {
+ ret = -EINVAL;
+ goto err_priv;
+ }
/* resource 0 is mmio regs */
/* resource 1 is linear FB */
@@ -764,7 +768,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
if (!dev_priv-mmio) {
NV_ERROR(dev, Unable to initialize the mmio mapping.
Please report your setup to DRIVER_EMAIL \n);
- return -EINVAL;
+ ret = -EINVAL;
+ goto err_wq;
}
NV_DEBUG(dev, regs mapped ok at 0x%llx\n,
(unsigned long long)mmio_start_offs);
@@ -812,7 +817,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
break;
default:
NV_INFO(dev, Unsupported chipset 0x%08x\n, reg0);
- return -EINVAL;
+ ret = -EINVAL;
+ goto err_mmio;
}
NV_INFO(dev, Detected an NV%2x generation card (0x%08x)\n,
@@ -820,7 +826,7 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
ret = nouveau_remove_conflicting_drivers(dev);
if (ret)
- return ret;
+ goto err_mmio;
/* Map PRAMIN BAR, or on older cards, the aperture withing BAR0 */
if (dev_priv-card_type = NV_40) {
@@ -834,7 +840,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
dev_priv-ramin_size);
if (!dev_priv-ramin) {
NV_ERROR(dev, Failed to PRAMIN BAR);
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_mmio;
}
} else {
dev_priv-ramin_size = 1 * 1024 * 1024;
@@ -842,7 +849,8 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
dev_priv-ramin_size);
if (!dev_priv-ramin) {
NV_ERROR(dev, Failed to map BAR0 PRAMIN.\n);
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_mmio;
}
}
@@ -857,9 +865,21 @@ int nouveau_load(struct drm_device *dev, unsigned long
flags)
/* For kernel modesetting, init card now and bring up fbcon */
ret = nouveau_card_init(dev);
if (ret)
- return ret;
+ goto err_ramin;
return 0;
+
+err_ramin:
+ iounmap(dev_priv-ramin);
+err_mmio:
+ iounmap(dev_priv-mmio);
+err_wq:
+ destroy_workqueue(dev_priv-wq);
+err_priv:
+ kfree(dev_priv);
+ dev-dev_private = NULL;
+err_out:
+ return ret;
}
void nouveau_lastclose(struct drm_device *dev)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] New: radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Summary: radeon interrupts don't fire with MSI Product: DRI Version: DRI CVS Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/Radeon AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: tdro...@gmx.de Created an attachment (id=37470) -- (https://bugs.freedesktop.org/attachment.cgi?id=37470) dmesg without MSI If I boot the current d-r-t kernel with MSI enabled the radeon module doesn't fire any interrupts. Without the interrupts and vblank_mode in driconf set to 3 the screen stops refreshing. This is always reproducible. To make it work again I have to boot with pci=nomsi. Software versions kernel current d-r-t (2.6.35-rc2) ddx, mesa, xserver git master Hardware Radeon X1950pro RV570 (AGP) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #1 from Droste tdro...@gmx.de 2010-07-30 15:42:22 PDT --- Created an attachment (id=37471) -- (https://bugs.freedesktop.org/attachment.cgi?id=37471) lspci -vnn without MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #2 from Droste tdro...@gmx.de 2010-07-30 15:43:09 PDT --- Created an attachment (id=37472) -- (https://bugs.freedesktop.org/attachment.cgi?id=37472) lspci -vt without MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #3 from Droste tdro...@gmx.de 2010-07-30 15:43:34 PDT --- Created an attachment (id=37473) -- (https://bugs.freedesktop.org/attachment.cgi?id=37473) Xorg log without MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #4 from Droste tdro...@gmx.de 2010-07-30 15:54:26 PDT --- Created an attachment (id=37474) -- (https://bugs.freedesktop.org/attachment.cgi?id=37474) dmesg with MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #5 from Droste tdro...@gmx.de 2010-07-30 15:55:00 PDT --- Created an attachment (id=37475) -- (https://bugs.freedesktop.org/attachment.cgi?id=37475) lspci -vnn with MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Droste tdro...@gmx.de changed: What|Removed |Added Attachment #37470|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Droste tdro...@gmx.de changed: What|Removed |Added Attachment #37472|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Droste tdro...@gmx.de changed: What|Removed |Added Attachment #37473|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Droste tdro...@gmx.de changed: What|Removed |Added Attachment #37474|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 Droste tdro...@gmx.de changed: What|Removed |Added Attachment #37475|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #6 from Droste tdro...@gmx.de 2010-07-30 15:57:58 PDT --- Created an attachment (id=37476) -- (https://bugs.freedesktop.org/attachment.cgi?id=37476) lspci -vt with MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29327] radeon interrupts don't fire with MSI
https://bugs.freedesktop.org/show_bug.cgi?id=29327 --- Comment #7 from Droste tdro...@gmx.de 2010-07-30 15:58:29 PDT --- Created an attachment (id=37477) -- (https://bugs.freedesktop.org/attachment.cgi?id=37477) Xorg log with MSI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
