Fixes coccicheck warning:

drivers/gpu/drm/amd/powerplay/amdgpu_smu.c:1192:5-8: Unneeded variable: "ret". 
Return "0" on line 1195
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c:1945:5-8: Unneeded variable: "ret". 
Return "0" on line 1961

Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: zhengbin <zhengbi...@huawei.com>
---
 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c 
b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index 36001a4..98691d4 100644
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -1189,10 +1189,9 @@ static int smu_free_memory_pool(struct smu_context *smu)
 {
        struct smu_table_context *smu_table = &smu->smu_table;
        struct smu_table *memory_pool = &smu_table->memory_pool;
-       int ret = 0;

        if (memory_pool->size == SMU_MEMORY_POOL_SIZE_ZERO)
-               return ret;
+               return 0;

        amdgpu_bo_free_kernel(&memory_pool->bo,
                              &memory_pool->mc_address,
@@ -1200,7 +1199,7 @@ static int smu_free_memory_pool(struct smu_context *smu)

        memset(memory_pool, 0, sizeof(struct smu_table));

-       return ret;
+       return 0;
 }

 static int smu_start_smc_engine(struct smu_context *smu)
@@ -1942,7 +1941,6 @@ int smu_write_watermarks_table(struct smu_context *smu)
 int smu_set_watermarks_for_clock_ranges(struct smu_context *smu,
                struct dm_pp_wm_sets_with_clock_ranges_soc15 *clock_ranges)
 {
-       int ret = 0;
        struct smu_table *watermarks = 
&smu->smu_table.tables[SMU_TABLE_WATERMARKS];
        void *table = watermarks->cpu_addr;

@@ -1958,7 +1956,7 @@ int smu_set_watermarks_for_clock_ranges(struct 
smu_context *smu,

        mutex_unlock(&smu->mutex);

-       return ret;
+       return 0;
 }

 const struct amd_ip_funcs smu_ip_funcs = {
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to