cleaning unfenced buffer
Hi, If my driver emit fence function fail should there be a way to clean unfenced buffer ? Or should i do this by myself in the function which validate buffer ? If so then i915 execbuffer is likely buggy in this regards (don't try to unload module then as it will trigger BUG_ON(!list_empty(bm-unfenced)) Cheers, Jerome Glisse - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
irq_enabled
Hi, dev-irq_enabled is set to 0 in drm_setup (drm_fdops.c) is this really necessary ? Or would be ok i move this 0 things to drm functions which initialize drm structure and let then the flags be set by irq function. My problem is that i enable irq in load function so client don't have to worry about enabling it, but on first client connection the flags is reset to 0 so on unload the irq handler isn't removed which cause bad things i reload and launch another client. Moving this initialization to drm struct initialization won't change anythings for others driver as if they enabled irq then the field will be put to 0 again on last_close which calls drm_irq_uninstall. Cheers, Jerome Glisse - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
radeon syncronization
Hi, So while playing with buffer move i am facing a problem and would like to know if anyone ever faced it. I emitting a bitblt multi to move data from ttm to vram just after the bitblt multi there is a WAIT_UNTIL packet emitted with WAIT_2D_IDLECLEAN, WAIT_HOST_IDLECLEAN set however if i add a blit from the destination memory to the framebuffer (to see what gets copied) just after this wait packet i see garbage and the end of the copied data so it's like while doing the second blit the first blit isn't yet finished or even started. If i add long enough udelay before emitting the wait packet i see data fine. My guess is that wait idle doesn't work :( i have tried with setting many others (allmost all) wait flags but results stay the them i need a udelay. Anyone got though/information on that ? Cheers, Jerome Glisse - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: cleaning unfenced buffer
Jerome Glisse wrote: Hi, If my driver emit fence function fail should there be a way to clean unfenced buffer ? Or should i do this by myself in the function which validate buffer ? If so then i915 execbuffer is likely buggy in this regards (don't try to unload module then as it will trigger BUG_ON(!list_empty(bm-unfenced)) Cheers, Jerome Glisse Hi. If fencing fails, the function that validates the buffer must clean the unfenced list. There is a function to clean the unfenced list in drm_bo.c. This is typically called if the function receives a signal while waiting to validate a buffer, which is a very common case if the X server is the caller. If command submission has already occured when fencing fails, the calling function must wait for GPU idle before cleaning the list. /Thomas - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
patch to add _DRM_DRIVER flag
As discussed on irc... patch to add _DRM_DRIVER map flag so that drm_lastclose won't clean up maps that the driver wants to manage. robert. -- Robert Noland [EMAIL PROTECTED] 2Hip Networks 0001-Add-_DRM_DRIVER-map-flag.patch Description: application/mbox signature.asc Description: This is a digitally signed message part - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/-- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 13234] bus_space functions were imported in 3.0
http://bugs.freedesktop.org/show_bug.cgi?id=13234 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|dri-|[EMAIL PROTECTED] |[EMAIL PROTECTED] | Status|NEW |ASSIGNED --- Comment #2 from [EMAIL PROTECTED] 2007-11-18 16:43 PST --- Under at least some cases, this is invoking evil... This patch should idle until I have time to figure out why... -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. You are the assignee for the bug, or are watching the assignee. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 13233] Build broken on FreeBSD
http://bugs.freedesktop.org/show_bug.cgi?id=13233 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #12526|0 |1 is obsolete|| --- Comment #5 from [EMAIL PROTECTED] 2007-11-18 16:46 PST --- (From update of attachment 12526) This was taken care of by the drm_internal.h -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: patch to add _DRM_DRIVER flag
On Sun, 2007-11-18 at 18:24 -0500, Robert Noland wrote: As discussed on irc... patch to add _DRM_DRIVER map flag so that drm_lastclose won't clean up maps that the driver wants to manage. bah, missing (), corrected patch... robert. -- Robert Noland [EMAIL PROTECTED] 2Hip Networks 0001-Add-_DRM_DRIVER-map-flag.patch Description: application/mbox signature.asc Description: This is a digitally signed message part - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/-- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
dev-counter
Looking at this more, dev-counter is also incorrect with i915. In i915_driver_load, we have dev-counter += 4, but in drm_firstopen we initialize it to 6. I'm guessing that we should probably move that initialization to drm_load... robert. -- Robert Noland [EMAIL PROTECTED] 2Hip Networks signature.asc Description: This is a digitally signed message part - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/-- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: dev-counter
On Sun, 2007-11-18 at 22:47 -0500, Robert Noland wrote: Looking at this more, dev-counter is also incorrect with i915. In i915_driver_load, we have dev-counter += 4, but in drm_firstopen we initialize it to 6. I'm guessing that we should probably move that initialization to drm_load... Looks like linux does the initialization at module load time, so this is a bsd only problem... robert. robert. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel -- Robert Noland [EMAIL PROTECTED] 2Hip Networks signature.asc Description: This is a digitally signed message part - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/-- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 13296] New: counters should be initialized at load time
http://bugs.freedesktop.org/show_bug.cgi?id=13296 Summary: counters should be initialized at load time Product: DRI Version: DRI CVS Platform: All OS/Version: FreeBSD Status: NEW Severity: normal Priority: medium Component: DRM modules AssignedTo: dri-devel@lists.sourceforge.net ReportedBy: [EMAIL PROTECTED] Currently the i915 attempts to add additional counters at load time. FreeBSD doesn't initialize the counters until drm_firstopen, which resets the count. It also seems reasonable that the counters should track events over the lifetime of the module... -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 13296] counters should be initialized at load time
http://bugs.freedesktop.org/show_bug.cgi?id=13296 --- Comment #1 from [EMAIL PROTECTED] 2007-11-18 20:55 PST --- Created an attachment (id=12621) -- (http://bugs.freedesktop.org/attachment.cgi?id=12621action=view) Init counters at load time -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 13296] counters should be initialized at load time
http://bugs.freedesktop.org/show_bug.cgi?id=13296 --- Comment #2 from [EMAIL PROTECTED] 2007-11-18 22:38 PST --- Since most of the module gets reset between lastclose and firstopen, it makes sense to me that the counters would as well. Setting up the list of counters at load time would make sense though. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 13233] Build broken on FreeBSD
http://bugs.freedesktop.org/show_bug.cgi?id=13233 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
