Re: Gem GTT mmaps..
Le vendredi 06 février 2009 à 14:24 -0800, Jesse Barnes a écrit :
+ map = list-map;
+ if (map) {
+ drm_free(map, sizeof(*map), DRM_MEM_DRIVER);
+ list-map = NULL;
I would have inverted the two last lines (otherwise why wouldn't you
directly drw_free(list-map) ?).
Xav
--
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 12491] i915 lockdep warning
http://bugzilla.kernel.org/show_bug.cgi?id=12491 --- Comment #2 from r...@sisk.pl 2009-02-07 05:42 --- Handled-By : Roland Dreier rola...@cisco.com Patch : http://marc.info/?l=linux-kernelm=123378709730700w=2 -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. -- Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 12441] Xorg can't use dri on radeon X1950 AGP
http://bugzilla.kernel.org/show_bug.cgi?id=12441 --- Comment #14 from r...@sisk.pl 2009-02-07 06:38 --- Patch : http://bugzilla.kernel.org/attachment.cgi?id=20032action=view Handled-By : Dave Airlie airl...@linux.ie -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. -- Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] capture last_vblank count at IRQ uninstall time too
On Fri, 2009-02-06 at 13:04 -0800, Jesse Barnes wrote:
In dc1336ff4fe08ae7cfe8301bfd7f0b2cfd31d20a (set vblank enable flag correctly
across IRQ uninstall), we made sure drivers that uninstall their interrupt
handler set the vblank enabled flag correctly, so that when interrupts are
re-enabled, vblank interrupts counts work as expected. However I missed the
last_vblank field: it needs to be updated as well, otherwise, at the next
drm_update_vblank_count we'll end up comparing a current count to a stale
one (the last one captured by the disable function), which may trigger the
wraparound handling, leading to a jumpy counter and hangs in drm_wait_vblank.
The jumpy counter can prevent the DRM_WAIT_ON from returning success if the
difference between the current count and the requested count is greater than
2^23, leading to timeouts or hangs, if the ioctl is restarted in a loop (as
is the case in libdrm 2.4.4).
Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index 69aa0ab..3795dbc 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -276,6 +276,7 @@ int drm_irq_uninstall(struct drm_device * dev)
for (i = 0; i dev-num_crtcs; i++) {
DRM_WAKEUP(dev-vbl_queue[i]);
dev-vblank_enabled[i] = 0;
+ dev-last_vblank[i] = dev-driver-get_vblank_counter(dev, i);
}
spin_unlock_irqrestore(dev-vbl_lock, irqflags);
It probably comes as no surprise to you that I like this much better
than the workarounds proposed previously. :)
--
Earthling Michel Dänzer |http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
--
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] capture last_vblank count at IRQ uninstall time too
On Saturday, February 7, 2009 6:54 am Michel Dänzer wrote:
On Fri, 2009-02-06 at 13:04 -0800, Jesse Barnes wrote:
In dc1336ff4fe08ae7cfe8301bfd7f0b2cfd31d20a (set vblank enable flag
correctly across IRQ uninstall), we made sure drivers that uninstall
their interrupt handler set the vblank enabled flag correctly, so that
when interrupts are re-enabled, vblank interrupts counts work as
expected. However I missed the last_vblank field: it needs to be
updated as well, otherwise, at the next drm_update_vblank_count we'll end
up comparing a current count to a stale one (the last one captured by the
disable function), which may trigger the wraparound handling, leading to
a jumpy counter and hangs in drm_wait_vblank.
The jumpy counter can prevent the DRM_WAIT_ON from returning success if
the difference between the current count and the requested count is
greater than 2^23, leading to timeouts or hangs, if the ioctl is
restarted in a loop (as is the case in libdrm 2.4.4).
Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index 69aa0ab..3795dbc 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -276,6 +276,7 @@ int drm_irq_uninstall(struct drm_device * dev)
for (i = 0; i dev-num_crtcs; i++) {
DRM_WAKEUP(dev-vbl_queue[i]);
dev-vblank_enabled[i] = 0;
+ dev-last_vblank[i] = dev-driver-get_vblank_counter(dev, i);
}
spin_unlock_irqrestore(dev-vbl_lock, irqflags);
It probably comes as no surprise to you that I like this much better
than the workarounds proposed previously. :)
I guess we can take that as an ack then :)
I really wish we didn't uninstall our IRQ handler in the xf86-video-intel
driver; hope you don't make the same mistake on radeon.
--
Jesse Barnes, Intel Open Source Technology Center
--
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] capture last_vblank count at IRQ uninstall time too
On Fri, 6 Feb 2009, Jesse Barnes wrote: In dc1336ff4fe08ae7cfe8301bfd7f0b2cfd31d20a (set vblank enable flag correctly across IRQ uninstall), we made sure drivers that uninstall their interrupt handler set the vblank enabled flag correctly, so that when interrupts are re-enabled, vblank interrupts counts work as expected. However I missed the last_vblank field: it needs to be updated as well, otherwise, at the next drm_update_vblank_count we'll end up comparing a current count to a stale one (the last one captured by the disable function), which may trigger the wraparound handling, leading to a jumpy counter and hangs in drm_wait_vblank. The jumpy counter can prevent the DRM_WAIT_ON from returning success if the difference between the current count and the requested count is greater than 2^23, leading to timeouts or hangs, if the ioctl is restarted in a loop (as is the case in libdrm 2.4.4). Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org Works fine on my GM965, fixing the issue I had. Tested-by: Timo Aaltonen tjaal...@cc.hut.fi t -- Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 16334] [DRM 945GM] i915 Oops (i915_driver_lastclose) when shutdown X
http://bugs.freedesktop.org/show_bug.cgi?id=16334 --- Comment #9 from Jie Luo cloth...@gmail.com 2009-02-07 18:47:34 PST --- (In reply to comment #7) Does this still exist with the latest code? Didn't see it for a long time, assume it was fixed. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
