Re: [PATCH] drm/i915: add _PAGE_IOMAP to GTT mapping attributes
On Thu, Oct 01, 2009 at 09:31:19AM -0700, Jeremy Fitzhardinge wrote: On 10/01/09 01:41, Jan Beulich wrote: Why, what's wrong with VM_IO? It's documented as being Memory mapped I/O or similar. VM_PFNMAP is another option, but that seems more dubious. Are there places where VM_IO is being legitimately set on normal page mappings? This is what Nick responded on my similar question: Hmm, good question. Unfortunately I think VM_IO was never really intended to set pte protection bits, but just protect the vma from get_user_pages (actually it is hard to know exactly what some of the vma flags bits were really intended for, but that seems to be the current reasonable use). VM_PFNMAP seems more specifically about preventing get_user_pages (ie, no struct page), (though I guess that could have changed with _PAGE_SPECIAL ptes). And there's the ever-mysterious VM_RESERVED. Does that mean it Well, yes basically these VM flags need a good cleanup. What should be done is like GFP flags where we define specific bits which direct the core mm to do a _particular_ thing (eg. don't get_user_pages, or this points to IO memory, etc). and then define combinations of them which are useful to drivers. I think Jan's point is simply that drivers _currently_ are in a bit of a mess here so the trivial approach to using VM_IO is not going to work without some fixups. PFNMAP may be used when we _do_ have struct pages but don't want to touch them, and also IO mappings can have pfn_valid true if the memory model has allocated a memory map for those pages. So I don't think they quite fit. Also drivers don't always want to allow get_user_pages even if they are working on normal memory (actually the default should be to _disallow_ it and a bit should be set to allow it, because you have to be somewhat aware of what the races and page reference lifetimes are with get_user_pages). The most prominent reason for not deriving _PAGE_IOMAP from VM_IO is probably the fact that remap_pfn_range() sets VM_IO, but clearly can be called for local RAM pages (e.g. through mmap_kmem()). mmap_kmem looks pretty broken anyway. All the CONFIG_STRICT_DEVMEM checks make sure the pages being mapped are *not* regular pages, and will end up failing all /dev/kmem mappings as a result. So I think in that case I think it gets set as an accidental erroneous side-effect. And if you grep for the uses of VM_IO, you'll find a few more examples (mostly arch specific, but anyway) that show that such an implication isn't valid at present. Pointers? The overwhelmingly common use is on mappings of hardware devices, and most of the tests of the bit explicitly reference IO as the reason they're testing it. Why would you set it if the mapping weren't for IO anyway? There are other ways to prevent, for example, core dumping it, or having it participate in normal memory management, or preventing get_user_pages, or whatever. The use of remap_pfn_range() is a slightly different matter, but it also looks like it is only used on device memory too (aside from the kmem thing mentioned above). But I'm not sure if it is defined to be only used on IO(-like) memory regions... Last time I audited most of the drivers due to the expanding-mremap security hole, there are definitely a large number of them that just seemed to randomly set VM_IO and/or VM_RESERVED. Probably due to the fact that they aren't well defined to start with. -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [Xen-devel] Re: ATI radeon fails with iommu=soft swiotlb=force (seen on RV730/RV740 and RS780/RS800)
Dmesg report attached:- [ 18.088588] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.088653] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.338143] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.338214] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.338270] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.378688] [ cut here ] [ 18.378696] kernel BUG at mm/slab.c:521! [ 18.378699] invalid opcode: [#1] SMP [ 18.378706] last sysfs file: /sys/devices/pci:00/:00:01.0/:01:00.0/enable [ 18.378709] CPU 0 [ 18.378713] Modules linked in: ppdev bnep video output lp parport snd_hda_codec_atihdmi snd_hda_codec_analog arc4 ecb snd_seq_dummy snd_seq_oss rtl8187 snd_seq_midi snd_hda_intel snd_hda_codec snd_rawmidi mac80211 snd_seq_midi_event snd_pcm_oss led_class snd_seq snd_mixer_oss eeprom_93cx6 snd_seq_device snd_pcm pcspkr iTCO_wdt iTCO_vendor_support intel_agp snd_timer snd soundcore snd_page_alloc cfg80211 usbhid ohci1394 ieee1394 r8169 mii sky2 [ 18.378786] Pid: 2927, comm: Xorg Not tainted 2.6.31.1 #5 P5K Premium [ 18.378789] RIP: e030:[81107afe] [81107afe] kfree+0xae/0x1d0 [ 18.378799] RSP: e02b:8801e1469c78 EFLAGS: 00010046 [ 18.378802] RAX: ea0006906580 RBX: 8801e01cfff8 RCX: 863cd063 [ 18.378805] RDX: 8008 RSI: 863cd063 RDI: 8801e01d [ 18.378808] RBP: 8801e1469cc8 R08: 8186cde0 R09: [ 18.378811] R10: 7ff0 R11: 0001 R12: 81315b94 [ 18.378814] R13: 8801e1469dc8 R14: 2000 R15: 8801e951d780 [ 18.378821] FS: 7f2f9bd2a700() GS:c900() knlGS: [ 18.378825] CS: e033 DS: ES: CR0: 8005003b [ 18.378828] CR2: 00e2e608 CR3: 0001e0d7c000 CR4: 2660 [ 18.378831] DR0: DR1: DR2: [ 18.378834] DR3: DR6: 0ff0 DR7: 0400 [ 18.378838] Process Xorg (pid: 2927, threadinfo 8801e1468000, task 8801e6094480) [ 18.378840] Stack: [ 18.378842] c90012977fff 8801e1469d30 8801dfb37800 8801e01d [ 18.378850] 0 0200 8801e01cfff8 8801dfb37800 8801e1469dc8 [ 18.378859] 0 2000 8801e951d780 8801e1469d68 81315b94 [ 18.378869] Call Trace: [ 18.378877] [81315b94] drm_sg_alloc+0x424/0x590 [ 18.378882] [81315d09] drm_sg_alloc_ioctl+0x9/0x10 [ 18.378887] [8130ee25] drm_ioctl+0x175/0x3c0 [ 18.378892] [8119d805] ? ext4_file_write+0x55/0x180 [ 18.378897] [81315d00] ? drm_sg_alloc_ioctl+0x0/0x10 [ 18.378903] [8100fe61] ? xen_clocksource_read+0x21/0x30 [ 18.378908] [81010ef7] ? xen_spin_lock+0xa7/0x110 [ 18.378913] [8111e47d] vfs_ioctl+0x7d/0xa0 [ 18.378917] [8111e92b] do_vfs_ioctl+0x3fb/0x590 [ 18.378921] [8111eb59] sys_ioctl+0x99/0xa0 [ 18.378926] [8110f980] ? sys_write+0x50/0x90 [ 18.378931] [81014f02] system_call_fastpath+0x16/0x1b [ 18.378933] Code: ba 00 00 00 00 00 ea ff ff 48 01 d0 48 8b 10 66 85 d2 79 13 48 8b 40 10 48 8b 10 66 85 d2 79 07 48 8b 40 10 48 8b 10 84 d2 78 0a 0f 0b eb fe 66 0f 1f 44 00 00 4c 8b 78 28 65 8b 04 25 88 e0 00 [ 18.379033] RIP [81107afe] kfree+0xae/0x1d0 [ 18.379038] RSP 8801e1469c78 [ 18.379042] ---[ end trace f245dfcffec6c0b3 ]--- [ 18.392165] [drm:drm_release] *ERROR* Device busy: 1 [ 20.202543] sky2 eth0: disabling interface [ 20.288075] sky2 peth0: enabling interface [ 20.288720] ADDRCONF(NETDEV_UP): peth0: link is not ready [ 21.524894] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 21.524960] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 21.752539] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 21.752601] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 21.752654] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 21.795030] [ cut here ] [ 21.795037] kernel BUG at mm/slab.c:521! [ 21.795041] invalid opcode: [#2] SMP [ 21.795047] last sysfs file: /sys/devices/pci:00/:00:01.0/:01:00.0/enable [ 21.795050] CPU 1 [ 21.795054] Modules linked in: binfmt_misc ppdev bnep video output lp parport snd_hda_codec_atihdmi snd_hda_codec_analog arc4 ecb snd_seq_dummy snd_seq_oss rtl8187 snd_seq_midi snd_hda_intel snd_hda_codec snd_rawmidi mac80211 snd_seq_midi_event snd_pcm_oss led_class snd_seq snd_mixer_oss eeprom_93cx6 snd_seq_device snd_pcm pcspkr
Re: Gallium3D Technical Session
Uros, Capturing this event on video is something we want to do. Thank you for your feedback. Regards, Jens On Oct 1, 2009, at 11:37 AM, Uros Nedic wrote: It'd be very nice if you could record session for people who are unable to attend this significant event. I'd be one of the first persons who would like to hear as much as possible about Gallium3D. Thanks, Uros Nedic --- Every kind of peaceful cooperation among men is primarily based on mutual trust and only secondarily on institutions such as courts of justice and police. - Albert Einstein (1879 - 1955) From: j...@stormpeakinnovations.com To: mesa3d-...@lists.sourceforge.net; dri- de...@lists.sourceforge.net Subject: Gallium3D Technical Session Date: Wed, 30 Sep 2009 07:58:32 -0600 The developers of Gallium3D are hosting a full day, in depth, technical session on Nov 13th at VMware's campus in Palo Alto, California. Please contact me directly to reserve your seat. Regards, Jens Owen -- Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel See all the ways you can stay connected to friends and family -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
RE: Gallium3D Technical Session
Jens, Could you please take care that this video will be captured in hi-resand with good voice quality so we who do not have luck to attend itcould get as much information as possible. Thanks,Uros --- Every kind of peaceful cooperation among men is primarily based on mutual trust and only secondarily on institutions such as courts of justice and police. - Albert Einstein (1879 - 1955) CC: mesa3d-...@lists.sourceforge.net; dri-devel@lists.sourceforge.net From: j...@stormpeakinnovations.com To: ur...@live.com Subject: Re: Gallium3D Technical Session Date: Fri, 2 Oct 2009 06:22:16 -0600 Uros, Capturing this event on video is something we want to do. Thank you for your feedback. Regards, Jens On Oct 1, 2009, at 11:37 AM, Uros Nedic wrote: It'd be very nice if you could record session for people who are unable to attend this significant event. I'd be one of the first persons who would like to hear as much as possible about Gallium3D. Thanks, Uros Nedic --- Every kind of peaceful cooperation among men is primarily based on mutual trust and only secondarily on institutions such as courts of justice and police. - Albert Einstein (1879 - 1955) From: j...@stormpeakinnovations.com To: mesa3d-...@lists.sourceforge.net; dri- de...@lists.sourceforge.net Subject: Gallium3D Technical Session Date: Wed, 30 Sep 2009 07:58:32 -0600 The developers of Gallium3D are hosting a full day, in depth, technical session on Nov 13th at VMware's campus in Palo Alto, California. Please contact me directly to reserve your seat. Regards, Jens Owen -- Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel See all the ways you can stay connected to friends and family _ Windows Live™: Keep your life in sync. Check it out! http://windowslive.com/explore?ocid=TXT_TAGLM_WL_t1_allup_explore_012009-- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf-- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: 2.6.32-rc1-git2: Reported regressions from 2.6.31
Jaswinder Singh Rajput wrote: If you add one more entry say Suspected commit : then it will be great and will solve regressions much faster. Will? Might. You can request submitter to submit 'suspected commit' by git bisect and also specify git bisect links like : (for more information about git bisect check http://kerneltrap.org/node/11753) I disagree. A reporter should only be asked to bisect (using git or other tools) /if/ a developer determined that bisection may speed up the debugging process or is the only remaining option to make progress with a bug. It would be wrong to steal a reporter's valuable time by asking for bisection before anybody familiar with the matter even had a first look at the report. Remember: - Not all bugs can be economically narrowed down by bisection. - Bisection requires skills, rigor, and time. - Alas there are considerable sections in our kernel history which are not bisectable. -- Stefan Richter -=-==--= =-=- ---=- http://arcgraph.de/sr/ -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: ATI radeon fails with iommu=soft swiotlb=force (seen on RV730/RV740 and RS780/RS800)
Konrad Rzeszutek Wilk konrad.w...@oracle.com 01.10.09 21:21 The are other users of 'vmalloc_32' that look like they depend on this memory being under the 4GB mark. Most of them are do video capture through USB - so it probably is limited to only accessing up to 4GB. I just went through all of the users of vmalloc_32(), and more than half of them seem bogus (like some legitimate use of it got cloned many times without really needing all the restrictions that come with this). Of course I can't verify that I'm right with all of those, so I'm not sure how to proceed with trying to do some clean up here... Jan -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [Mesa3d-dev] Gallium3D Technical Session
To at least give some feedback: I think this is a great initiative and I wish I could be there. You should do this in northern Europe more often. VMWare has offices in Sweden, right? ;) In any case, if you can get it on video it would be fantastic, and if you could live stream it, I would consider it a miracle. On Fri, 2009-10-02 at 06:22 -0600, Jens Owen wrote: Uros, Capturing this event on video is something we want to do. Thank you for your feedback. Regards, Jens On Oct 1, 2009, at 11:37 AM, Uros Nedic wrote: It'd be very nice if you could record session for people who are unable to attend this significant event. I'd be one of the first persons who would like to hear as much as possible about Gallium3D. Thanks, Uros Nedic --- Every kind of peaceful cooperation among men is primarily based on mutual trust and only secondarily on institutions such as courts of justice and police. - Albert Einstein (1879 - 1955) From: j...@stormpeakinnovations.com To: mesa3d-...@lists.sourceforge.net; dri- de...@lists.sourceforge.net Subject: Gallium3D Technical Session Date: Wed, 30 Sep 2009 07:58:32 -0600 The developers of Gallium3D are hosting a full day, in depth, technical session on Nov 13th at VMware's campus in Palo Alto, California. Please contact me directly to reserve your seat. Regards, Jens Owen -- Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel See all the ways you can stay connected to friends and family -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Mesa3d-dev mailing list mesa3d-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 24263] Can't unset coherent_mode via xrandr with KMS enabled
http://bugs.freedesktop.org/show_bug.cgi?id=24263 --- Comment #1 from Alex Deucher ag...@yahoo.com 2009-10-02 07:51:02 PST --- Does: xrandr --output DVI-0 --set coherent 0 work? -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: kms and memory bandwidth limitations
On Fri, Oct 2, 2009 at 12:20 AM, Dave Airlie airl...@gmail.com wrote: So I was looking at the memory bandwidth limitations that ajax added to the X server, and how we could add the concept to KMS. Now the X server is in a lucky position as when it gets the modes it also knows what bit depth its going to run in, and it can use that at the mode validation time to remove modes for bandwidth reasons. As discussed at XDC, it would also be nice to have a randr call to set up the entire display system in one shot rather than per-crtc since some combinations of modes and depths may not work in multi-head configurations, but may be just fine in single head configurations. Alex Now KMS doesn't know what bitdepth its users is going to use until they associate a modeset is done and the framebuffer is assigned to the crtc, however failing to set the mode at this stage would be rude as we never removed the mode from the list. I can see a few solutions to this (some hacky some not): 1) add a new field to the mode getting ioctl, specifying what bit depth the user would like to have the mode list validated against before returning, this probably means speccing a new ioctl since I think this one is full. 2) add a new ioctl to be set by the kms user app, which pretty much says I'm interested in modes that can work at this bpp, with a default to 32-bit depth. 3) add some new flags to the modes, stating what bit sized depths they are supported at (i.e. DRM_MODE_FLAG_8BIT, 16BIT, 32BIT, 64BIT etc) 4) pass the info about memory bw to the caller (i.e. X) - uggh no. I'm sort of leaning towards 2 at the moment as its probably the simpler, just wondering if anyone has any other ideas or preferences? Dave. -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: 2.6.32-rc1-git2: Reported regressions from 2.6.31
On Friday 02 October 2009, Stefan Richter wrote: Jaswinder Singh Rajput wrote: If you add one more entry say Suspected commit : then it will be great and will solve regressions much faster. Will? Might. In fact I add the First-Bad-Commit annotation where there is a bisection result or it's possible to fix things by reverting a specific commit. You can request submitter to submit 'suspected commit' by git bisect and also specify git bisect links like : (for more information about git bisect check http://kerneltrap.org/node/11753) I disagree. A reporter should only be asked to bisect (using git or other tools) /if/ a developer determined that bisection may speed up the debugging process or is the only remaining option to make progress with a bug. It would be wrong to steal a reporter's valuable time by asking for bisection before anybody familiar with the matter even had a first look at the report. Agreed. Thanks, Rafael -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] drm/radeon/kms: respect single crtc cards, only create one crtc.
On Fri, Oct 2, 2009 at 12:25 AM, Dave Airlie airl...@gmail.com wrote:
From: Dave Airlie airl...@redhat.com
Also add single crtc for RN50 chips.
Signed-off-by: Dave Airlie airl...@redhat.com
---
drivers/gpu/drm/radeon/r100.c | 8 +---
drivers/gpu/drm/radeon/radeon_display.c | 6 +-
drivers/gpu/drm/radeon/radeon_encoders.c | 6 +-
drivers/gpu/drm/radeon/radeon_fb.c | 7 ++-
drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 5 -
include/drm/drm_pciids.h | 4 ++--
6 files changed, 27 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
index 7bea923..5fe12c0 100644
--- a/drivers/gpu/drm/radeon/r100.c
+++ b/drivers/gpu/drm/radeon/r100.c
@@ -2135,9 +2135,11 @@ void r100_bandwidth_update(struct radeon_device *rdev)
mode1 = rdev-mode_info.crtcs[0]-base.mode;
pixel_bytes1 =
rdev-mode_info.crtcs[0]-base.fb-bits_per_pixel / 8;
}
- if (rdev-mode_info.crtcs[1]-base.enabled) {
- mode2 = rdev-mode_info.crtcs[1]-base.mode;
- pixel_bytes2 =
rdev-mode_info.crtcs[1]-base.fb-bits_per_pixel / 8;
+ if (!(rdev-flags RADEON_SINGLE_CRTC)) {
+ if (rdev-mode_info.crtcs[1]-base.enabled) {
+ mode2 = rdev-mode_info.crtcs[1]-base.mode;
+ pixel_bytes2 =
rdev-mode_info.crtcs[1]-base.fb-bits_per_pixel / 8;
+ }
}
min_mem_eff.full = rfixed_const_8(0);
diff --git a/drivers/gpu/drm/radeon/radeon_display.c
b/drivers/gpu/drm/radeon/radeon_display.c
index 5d8141b..44cfcfd 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -724,7 +724,11 @@ int radeon_modeset_init(struct radeon_device *rdev)
if (ret) {
return ret;
}
- /* allocate crtcs - TODO single crtc */
+
+ if (rdev-flags RADEON_SINGLE_CRTC)
+ num_crtc = 1;
+
+ /* allocate crtcs */
for (i = 0; i num_crtc; i++) {
radeon_crtc_init(rdev-ddev, i);
}
diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c
b/drivers/gpu/drm/radeon/radeon_encoders.c
index 6216467..a65ab1a 100644
--- a/drivers/gpu/drm/radeon/radeon_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_encoders.c
@@ -1345,6 +1345,7 @@ radeon_atombios_set_dig_info(struct radeon_encoder
*radeon_encoder)
void
radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_id,
uint32_t supported_device)
{
+ struct radeon_device *rdev = dev-dev_private;
struct drm_encoder *encoder;
struct radeon_encoder *radeon_encoder;
@@ -1364,7 +1365,10 @@ radeon_add_atom_encoder(struct drm_device *dev,
uint32_t encoder_id, uint32_t su
return;
encoder = radeon_encoder-base;
- encoder-possible_crtcs = 0x3;
+ if (rdev-flags RADEON_SINGLE_CRTC)
+ encoder-possible_crtcs = 0x1;
+ else
+ encoder-possible_crtcs = 0x3;
encoder-possible_clones = 0;
radeon_encoder-enc_priv = NULL;
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c
b/drivers/gpu/drm/radeon/radeon_fb.c
index 1ba704e..325e40b 100644
--- a/drivers/gpu/drm/radeon/radeon_fb.c
+++ b/drivers/gpu/drm/radeon/radeon_fb.c
@@ -146,6 +146,7 @@ int radeonfb_create(struct drm_device *dev,
unsigned long tmp;
bool fb_tiled = false; /* useful for testing */
u32 tiling_flags = 0;
+ int crtc_count;
mode_cmd.width = surface_width;
mode_cmd.height = surface_height;
@@ -217,7 +218,11 @@ int radeonfb_create(struct drm_device *dev,
rfbdev = info-par;
rfbdev-helper.funcs = radeon_fb_helper_funcs;
rfbdev-helper.dev = dev;
- ret = drm_fb_helper_init_crtc_count(rfbdev-helper, 2,
+ if (rdev-flags RADEON_SINGLE_CRTC)
+ crtc_count = 1;
+ else
+ crtc_count = 2;
+ ret = drm_fb_helper_init_crtc_count(rfbdev-helper, crtc_count,
RADEONFB_CONN_LIMIT);
if (ret)
goto out_unref;
diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
index b1547f7..0ebbd29 100644
--- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
@@ -1318,7 +1318,10 @@ radeon_add_legacy_encoder(struct drm_device *dev,
uint32_t encoder_id, uint32_t
return;
encoder = radeon_encoder-base;
- encoder-possible_crtcs = 0x3;
+ if (rdev-flags RADEON_SINGLE_CRTC)
+ encoder-possible_crtcs = 0x1;
+ else
+ encoder-possible_crtcs = 0x3;
encoder-possible_clones = 0;
radeon_encoder-enc_priv = NULL;
diff --git
Re: [Mesa3d-dev] Gallium3D Technical Session
On Oct 2, 2009, at 9:45 AM, RALOVICH, Kristóf wrote: On Fri, Oct 2, 2009 at 09:07, Joakim Sindholt b...@zhasha.com wrote: To at least give some feedback: I think this is a great initiative and I wish I could be there. You should do this in northern Europe more often. VMWare has offices in Sweden, right? ;) In any case, if you can get it on video it would be fantastic, and if you could live stream it, I would consider it a miracle. On Fri, 2009-10-02 at 06:22 -0600, Jens Owen wrote: Uros, Capturing this event on video is something we want to do. Thank you for your feedback. Regards, Jens On Oct 1, 2009, at 11:37 AM, Uros Nedic wrote: It'd be very nice if you could record session for people who are unable to attend this significant event. I'd be one of the first persons who would like to hear as much as possible about Gallium3D. Thanks, Uros Nedic --- Every kind of peaceful cooperation among men is primarily based on mutual trust and only secondarily on institutions such as courts of justice and police. - Albert Einstein (1879 - 1955) From: j...@stormpeakinnovations.com To: mesa3d-...@lists.sourceforge.net; dri- de...@lists.sourceforge.net Subject: Gallium3D Technical Session Date: Wed, 30 Sep 2009 07:58:32 -0600 The developers of Gallium3D are hosting a full day, in depth, technical session on Nov 13th at VMware's campus in Palo Alto, California. Please contact me directly to reserve your seat. Regards, Jens Owen -- Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel See all the ways you can stay connected to friends and family -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Mesa3d-dev mailing list mesa3d-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Mesa3d-dev mailing list mesa3d-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev I also believe having the video recording of the sessions is very useful. Please advertise the location of the videos so that people will find it easily. Thank you for the feedback. I will look into what is available and follow up over the next two weeks. Regards, Jens -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [Mesa3d-dev] Gallium3D Technical Session
On Fri, Oct 2, 2009 at 09:07, Joakim Sindholt b...@zhasha.com wrote: To at least give some feedback: I think this is a great initiative and I wish I could be there. You should do this in northern Europe more often. VMWare has offices in Sweden, right? ;) In any case, if you can get it on video it would be fantastic, and if you could live stream it, I would consider it a miracle. On Fri, 2009-10-02 at 06:22 -0600, Jens Owen wrote: Uros, Capturing this event on video is something we want to do. Thank you for your feedback. Regards, Jens On Oct 1, 2009, at 11:37 AM, Uros Nedic wrote: It'd be very nice if you could record session for people who are unable to attend this significant event. I'd be one of the first persons who would like to hear as much as possible about Gallium3D. Thanks, Uros Nedic --- Every kind of peaceful cooperation among men is primarily based on mutual trust and only secondarily on institutions such as courts of justice and police. - Albert Einstein (1879 - 1955) From: j...@stormpeakinnovations.com To: mesa3d-...@lists.sourceforge.net; dri- de...@lists.sourceforge.net Subject: Gallium3D Technical Session Date: Wed, 30 Sep 2009 07:58:32 -0600 The developers of Gallium3D are hosting a full day, in depth, technical session on Nov 13th at VMware's campus in Palo Alto, California. Please contact me directly to reserve your seat. Regards, Jens Owen -- Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel See all the ways you can stay connected to friends and family -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Mesa3d-dev mailing list mesa3d-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Mesa3d-dev mailing list mesa3d-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev I also believe having the video recording of the sessions is very useful. Please advertise the location of the videos so that people will find it easily. Thanks, Kristof -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 23714] Alpha issue with textures in clutter demo
http://bugs.freedesktop.org/show_bug.cgi?id=23714 Alex Deucher ag...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #4 from Alex Deucher ag...@yahoo.com 2009-10-02 11:10:12 PST --- Should be fixed now. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 24263] Can't unset coherent_mode via xrandr with KMS enabled
http://bugs.freedesktop.org/show_bug.cgi?id=24263 --- Comment #2 from Adam K Kirchhoff ad...@voicenet.com 2009-10-02 08:20:43 PST --- Bah... Sorry I mistyped in my original report. Where I said: I can run 'xrandr --output DVI-0 --set mode 0' without any errors, and it does change the value for coherent to 0, but it doesn't let the monitor work. I should have said: I can run 'xrandr --output DVI-0 --set coherent 0' without any errors, and it does change the value for coherent to 0, but it doesn't let the monitor work. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 24281] New: Random noise on image when using clutter-gst
http://bugs.freedesktop.org/show_bug.cgi?id=24281 Summary: Random noise on image when using clutter-gst Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel@lists.sourceforge.net ReportedBy: kdeko...@yahoo.com Created an attachment (id=2) -- (http://bugs.freedesktop.org/attachment.cgi?id=2) Screenshot showing the artifacts I have an application based on clutter-gst that I am using for media playback. In software mode (although slow) and on Intel G35 the app displays fine. However, when run on r600 (rv635 in my case) the initial image is pretty good, but when scaled I start getting noise in the image, perhaps a rounding error somewhere? The test application can be fetched from SVN svn checkout http://fosfor.googlecode.com/svn/trunk/ fosfor-read-only It requires, clutter 1.0, clutter gtk 0.10, clutter gst 0.10 and gtk 2.16 (Fedora rawhide statisfies all these requirements) The good news is that the corruption used to be much much worse, and this is almost perfect. If you don't want to install the test app, I am willing to try mesa patches and report good or bad results. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] i915: Fix i2c init message
On Wed, 2009-09-30 at 14:26 -0600, Tim Gardner wrote:
From 8ef5591fa4392b4228b0be97013a8218f267ef90 Mon Sep 17 00:00:00 2001
From: Tim Gardner tim.gard...@canonical.com
Date: Wed, 30 Sep 2009 14:08:15 -0600
Subject: [PATCH] i915: Fix i2c init message
BugLink: http://bugs.launchpad.net/bugs/409361
This message appears to be informational only.
Less than that, it appears to be debug only. Shall I just whack it to
DRM_DEBUG?
Signed-off-by: Tim Gardner tim.gard...@canonical.com
Cc: sta...@kernel.org
---
drivers/gpu/drm/i915/intel_dp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 2b914d7..d0f950c 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -400,7 +400,7 @@ intel_dp_i2c_init(struct intel_output *intel_output,
const char *name)
{
struct intel_dp_priv *dp_priv = intel_output-dev_priv;
- DRM_ERROR(i2c_init %s\n, name);
+ DRM_INFO(i2c_init %s\n, name);
dp_priv-algo.running = false;
dp_priv-algo.address = 0;
dp_priv-algo.aux_ch = intel_dp_i2c_aux_ch;
--
Eric Anholt
e...@anholt.net eric.anh...@intel.com
signature.asc
Description: This is a digitally signed message part
--
Come build with us! The BlackBerryreg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9#45;12, 2009. Register now#33;
http://p.sf.net/sfu/devconf--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 24283] New: [KMS] Failure to parse crtc reloc
http://bugs.freedesktop.org/show_bug.cgi?id=24283 Summary: [KMS] Failure to parse crtc reloc Product: DRI Version: XOrg 6.7.0 Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: DRM/Radeon AssignedTo: dri-devel@lists.sourceforge.net ReportedBy: pau...@gentoo.org Created an attachment (id=3) -- (http://bugs.freedesktop.org/attachment.cgi?id=3) my Xorg.0.log file (contains setup information) With kernels 2.6.31 and 2.6.32_rc1 the following problem occurs when using KMS with my mobility radeon X1700 (PCI:*(0:1:0:0) 1002:71d5:1043:1242 ATI Technologies Inc M66-P [Mobility Radeon X1700] rev 0, Mem @ 0xc000/268435456, 0xfdff/65536, I/O @ 0xb000/256, BIOS @ 0x/131072) Whenever trying to use 3d (let's take glxgears as the example) I just get a black screen / errors in case of kwin. And the kernel log / dmesg contains large repetitions of the following: [drm:r100_cs_packet_parse_vline] *ERROR* unknown crtc reloc (0x0653) [drm:r300_packet0_check] *ERROR* No reloc for ib[25]=0x6538 [drm] ib[24]=0x194E [drm] ib[25]=0x81450019 [drm:radeon_cs_ioctl] *ERROR* Invalid command stream ! Notice that I have slightly modified the code (only this) to output the actual value of reg in the relevant swith in r100_cs_packet_parse_vline. Also notice that ( ib[24] 2 == 0x6538 (AVIVO_D1MODE_VLINE_START_END)) one of the switch conditions, and the value in the second line. This is in a dual screen setup with the non-laptop screen connected through dvi. I tested it with disabled second screen (through xrandr) and then things work. Using the VGA connection doesn't help. Things still don't work. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 24283] [KMS] Failure to parse crtc reloc
http://bugs.freedesktop.org/show_bug.cgi?id=24283 --- Comment #1 from Paul de Vrieze pau...@gentoo.org 2009-10-02 14:07:44 PST --- A small addition. When using single screen on the external (non-laptop) screen. The same error occurs as when using dual screen mode: [drm:radeon_cs_ioctl] *ERROR* Invalid command stream ! [drm:r100_cs_packet_parse_vline] *ERROR* unknown crtc reloc (0x0653) [drm:r300_packet0_check] *ERROR* No reloc for ib[25]=0x6538 [drm] ib[24]=0x194E [drm] ib[25]=0x81450019 [drm:radeon_cs_ioctl] *ERROR* Invalid command stream ! Also in dual screen mode moving the glxgears app to the laptop screen makes no difference. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 24283] [KMS] Failure to parse crtc reloc
http://bugs.freedesktop.org/show_bug.cgi?id=24283 Alex Deucher ag...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #2 from Alex Deucher ag...@yahoo.com 2009-10-02 14:13:45 PST --- *** This bug has been marked as a duplicate of bug 24196 *** -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [Intel-gfx] [PATCH 0/8] drmmode overlay support v3
On Tue, 2009-09-15 at 22:57 +0200, Daniel Vetter wrote: Hi all, Latest version of my overlay kms work. I've added the new stuff as separated patches for easier testing in case something blows up. Please review. Thanks, Daniel Daniel Vetter (8): [drm]: make drm_mode_object_find typesafe [drm/i915]: add i915_lp_ring_sync helper [drm/i915]: kill superflous IS_I855 macro [drm/i915] implement drmmode overlay support v4 [drm/i915] fully switch off overlay when not in use [drm/i915] implement fastpath for overlay flip waiting [drm/i915] implement interruptible sleeps in the overlay code [drm/i915] kill i915_lp_ring_sync OK, I've finally pulled this for -next, with a bit of hand resolving of conflicts. I debated, because of the somewhat unusual series of adding the ring sync, implementing, fixing the ring sync use, then removing ring sync. Often, that sort of stuff gets flattened out in the commit history. However, in this case I think it's OK as overlays are touchy and bisectability for is the interruptible stuff working correctly may prove useful. Then I noticed that you'd told me that there was newer stuff in your gitorious tree. Only, that stuff claims to be older (v3), and doesn't have some of the patches above. So I've pushed my merge to drm-overlay of my tree for review -- is it what you think should land? drivers/gpu/drm/drm_crtc.c |3 +- drivers/gpu/drm/i915/Makefile|1 + drivers/gpu/drm/i915/i915_dma.c |7 + drivers/gpu/drm/i915/i915_drv.h |8 +- drivers/gpu/drm/i915/i915_gem.c | 37 +- drivers/gpu/drm/i915/i915_reg.h |5 + drivers/gpu/drm/i915/intel_display.c | 45 +- drivers/gpu/drm/i915/intel_drv.h | 39 + drivers/gpu/drm/i915/intel_overlay.c | 1420 ++ include/drm/drm_crtc.h |3 +- include/drm/drm_os_linux.h |2 +- include/drm/i915_drm.h | 71 ++ 12 files changed, 1620 insertions(+), 21 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_overlay.c ___ Intel-gfx mailing list intel-...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf-- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[PATCH] drm/radeon/kms: add support for Surround View
From c452529658530f18d7295e02d9007417aeca80b4 Mon Sep 17 00:00:00 2001
From: Alex Deucher alexdeuc...@gmail.com
Date: Fri, 2 Oct 2009 17:36:41 -0400
Subject: [PATCH] drm/radeon/kms: add support for Surround View
Surround View is an option in the system bios that
enables the AMD IGP chip in conjunction with a
discrete AMD card. However, since the IGP vbios is
part of the system bios it is not accessible via the
rom bar or the legacy vga location. When Surround View
is enabled in the system bios, the system bios puts a
copy of the IGP vbios image at the start of vram.
This patch adds support for reading the vbios image out
of vram on IGP cards.
Signed-off-by: Alex Deucher alexdeuc...@gmail.com
---
drivers/gpu/drm/radeon/radeon_bios.c | 49 -
1 files changed, 47 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_bios.c
b/drivers/gpu/drm/radeon/radeon_bios.c
index 96e37a6..34a9b91 100644
--- a/drivers/gpu/drm/radeon/radeon_bios.c
+++ b/drivers/gpu/drm/radeon/radeon_bios.c
@@ -33,12 +33,50 @@
/*
* BIOS.
*/
+
+/* If you boot an IGP board with a discrete card as the primary,
+ * the IGP rom is not accessible via the rom bar as the IGP rom is
+ * part of the system bios. On boot, the system bios puts a
+ * copy of the igp rom at the start of vram if a discrete card is
+ * present.
+ */
+static bool igp_read_bios_from_vram(struct radeon_device *rdev)
+{
+ uint8_t __iomem *bios;
+ resource_size_t vram_base;
+ resource_size_t size = 256 * 1024; /* ??? */
+
+ rdev-bios = NULL;
+ vram_base = drm_get_resource_start(rdev-ddev, 0);
+ bios = ioremap(vram_base, size);
+ if (!bios) {
+ DRM_ERROR(Unable to mmap vram\n);
+ return false;
+ }
+
+ if (size == 0 || bios[0] != 0x55 || bios[1] != 0xaa) {
+ iounmap(bios);
+ DRM_ERROR(bad rom signature\n);
+ return false;
+ }
+ rdev-bios = kmalloc(size, GFP_KERNEL);
+ if (rdev-bios == NULL) {
+ iounmap(bios);
+ DRM_ERROR(kmalloc failed\n);
+ return false;
+ }
+ memcpy(rdev-bios, bios, size);
+ iounmap(bios);
+ return true;
+}
+
static bool radeon_read_bios(struct radeon_device *rdev)
{
uint8_t __iomem *bios;
size_t size;
rdev-bios = NULL;
+ /* XXX: some cards may return 0 for rom size? ddx has a workaround */
bios = pci_map_rom(rdev-pdev, size);
if (!bios) {
return false;
@@ -341,7 +379,9 @@ static bool legacy_read_disabled_bios(struct
radeon_device *rdev)
static bool radeon_read_disabled_bios(struct radeon_device *rdev)
{
- if (rdev-family = CHIP_RV770)
+ if (rdev-flags RADEON_IS_IGP)
+ return igp_read_bios_from_vram(rdev);
+ else if (rdev-family = CHIP_RV770)
return r700_read_disabled_bios(rdev);
else if (rdev-family = CHIP_R600)
return r600_read_disabled_bios(rdev);
@@ -356,7 +396,12 @@ bool radeon_get_bios(struct radeon_device *rdev)
bool r;
uint16_t tmp;
- r = radeon_read_bios(rdev);
+ if (rdev-flags RADEON_IS_IGP) {
+ r = igp_read_bios_from_vram(rdev);
+ if (r == false)
+ r = radeon_read_bios(rdev);
+ } else
+ r = radeon_read_bios(rdev);
if (r == false) {
r = radeon_read_disabled_bios(rdev);
}
--
1.5.6.3
From c452529658530f18d7295e02d9007417aeca80b4 Mon Sep 17 00:00:00 2001
From: Alex Deucher alexdeuc...@gmail.com
Date: Fri, 2 Oct 2009 17:36:41 -0400
Subject: [PATCH] drm/radeon/kms: add support for Surround View
Surround View is an option in the system bios that
enables the AMD IGP chip in conjunction with a
discrete AMD card. However, since the IGP vbios is
part of the system bios it is not accessible via the
rom bar or the legacy vga location. When Surround View
is enabled in the system bios, the system bios puts a
copy of the IGP vbios image at the start of vram.
This patch adds support for reading the vbios image out
of vram on IGP cards.
Signed-off-by: Alex Deucher alexdeuc...@gmail.com
---
drivers/gpu/drm/radeon/radeon_bios.c | 49 -
1 files changed, 47 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
index 96e37a6..34a9b91 100644
--- a/drivers/gpu/drm/radeon/radeon_bios.c
+++ b/drivers/gpu/drm/radeon/radeon_bios.c
@@ -33,12 +33,50 @@
/*
* BIOS.
*/
+
+/* If you boot an IGP board with a discrete card as the primary,
+ * the IGP rom is not accessible via the rom bar as the IGP rom is
+ * part of the system bios. On boot, the system bios puts a
+ * copy of the igp rom at the start of vram if a discrete card is
+ * present.
+ */
+static bool igp_read_bios_from_vram(struct radeon_device *rdev)
+{
+ uint8_t __iomem *bios;
Re: [PATCH] drm/radeon/kms: respect single crtc cards, only create one crtc.
{0x1002, 0x5a61, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
CHIP_RS400|RADEON_IS_IGP|RADEON_IS_IGPGART}, \
Original radeons (R100) are also single crtc cards.
0x5144, 0x5145, 0x5146, 0x5147
They already had the flag set from ages ago.
there was bug in r100.c also to make this patch work, its running fine on
my RN50 so far though I suspect we probably want to enable output cloning
like we did in the DDX.
Dave.--
Come build with us! The BlackBerryreg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9#45;12, 2009. Register now#33;
http://p.sf.net/sfu/devconf--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [Xen-devel] Re: ATI radeon fails with iommu=soft swiotlb=force (seen on RV730/RV740 and RS780/RS800)
On 10/02/09 10:23, Boris Derzhavets wrote: Jeremy, Please, be aware of bugzilla.xensource.com [1519] the most recent entries :- http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1519 Ah, OK. I pushed a variant of Konrad's patches. Could you try them out? Thanks, J -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [Xen-devel] Re: ATI radeon fails with iommu=soft swiotlb=force (seen on RV730/RV740 and RS780/RS800) . Test commited for JF
On 10/02/09 12:50, Boris Derzhavets wrote: Done via git pull for another close enough linux-2.6-xen clone :- # git pull # git checkout xen/master # git log So you're saying it works? I didn't see anything bad in the dmesg output. If it is working, what does /proc/mtrr say? Thanks, J -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [Xen-devel] Re: ATI radeon fails with iommu=soft swiotlb=force (seen on RV730/RV740 and RS780/RS800)
I will have to make a fresh git clone. Tomorrow by the end of the day it's gonna be done. Boris. --- On Fri, 10/2/09, Jeremy Fitzhardinge jer...@goop.org wrote: From: Jeremy Fitzhardinge jer...@goop.org Subject: Re: [Xen-devel] Re: ATI radeon fails with iommu=soft swiotlb=force (seen on RV730/RV740 and RS780/RS800) To: Boris Derzhavets bderzhav...@yahoo.com Cc: dri-devel@lists.sourceforge.net, xen-de...@lists.xensource.com, jbeul...@novell.com, Konrad Rzeszutek Wilk konrad.w...@oracle.com Date: Friday, October 2, 2009, 2:42 PM On 10/02/09 10:23, Boris Derzhavets wrote: Jeremy, Please, be aware of bugzilla.xensource.com [1519] the most recent entries :- http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1519 Ah, OK. I pushed a variant of Konrad's patches. Could you try them out? Thanks, J -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf-- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [Xen-devel] Re: ATI radeon fails with iommu=soft swiotlb=force (seen on RV730/RV740 and RS780/RS800)
On 10/01/09 23:58, Boris Derzhavets wrote: Dmesg report attached:- [ 18.088588] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.088653] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.338143] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.338214] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.338270] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.378688] [ cut here ] [ 18.378696] kernel BUG at mm/slab.c:521! OK, I have a fix for this. I'll commit it shortly. J -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [Xen-devel] Re: ATI radeon fails with iommu=soft swiotlb=force (seen on RV730/RV740 and RS780/RS800)
Jeremy, Please, be aware of bugzilla.xensource.com [1519] the most recent entries :- http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1519 Boris. --- On Fri, 10/2/09, Jeremy Fitzhardinge jer...@goop.org wrote: From: Jeremy Fitzhardinge jer...@goop.org Subject: Re: [Xen-devel] Re: ATI radeon fails with iommu=soft swiotlb=force (seen on RV730/RV740 and RS780/RS800) To: Boris Derzhavets bderzhav...@yahoo.com Cc: dri-devel@lists.sourceforge.net, xen-de...@lists.xensource.com, jbeul...@novell.com, Konrad Rzeszutek Wilk konrad.w...@oracle.com Date: Friday, October 2, 2009, 1:18 PM On 10/01/09 23:58, Boris Derzhavets wrote: Dmesg report attached:- [ 18.088588] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.088653] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.338143] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.338214] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.338270] mtrr: type mismatch for d000,1000 old: write-back new: write-combining [ 18.378688] [ cut here ] [ 18.378696] kernel BUG at mm/slab.c:521! OK, I have a fix for this. I'll commit it shortly. J ___ Xen-devel mailing list xen-de...@lists.xensource.com http://lists.xensource.com/xen-devel -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf-- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [Xen-devel] Re: ATI radeon fails with iommu=soft swiotlb=force (seen on RV730/RV740 and RS780/RS800)
On Fri, Oct 02, 2009 at 01:52:46PM +0100, Jan Beulich wrote: Konrad Rzeszutek Wilk konrad.w...@oracle.com 01.10.09 21:21 The are other users of 'vmalloc_32' that look like they depend on this memory being under the 4GB mark. Most of them are do video capture through USB - so it probably is limited to only accessing up to 4GB. I just went through all of the users of vmalloc_32(), and more than half of them seem bogus (like some legitimate use of it got cloned many times without really needing all the restrictions that come with this). Of course I can't verify that I'm right with all of those, so I'm not sure how to proceed with trying to do some clean up here... I actually have some of those devices in the basement or I buy some of them at the MIT Flea. Will dig them up and make sure they work properly. -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
