Re: [PATCH 0/5] clean up radeon_asic.h v2
On Fri, Mar 12, 2010 at 7:48 PM, Daniel Vetter dan...@ffwll.ch wrote: On Fri, Mar 12, 2010 at 10:25:56AM +0100, Jerome Glisse wrote: I would merge patch 1 2 into a single patch, I've split this up to make patch-reading easier. And it's fully bisectable. I quite like where this is going compared to what was there before, so I've applied the work so far to drm-radeon-testing, its probably 2.6.35 material at this point anyways. Dave. -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH 0/5] clean up radeon_asic.h v2
On Thu, Mar 11, 2010 at 10:19:13PM +0100, Daniel Vetter wrote: Hi all, All new patch pile to make radeon_asic.h into a real header file. Now all the asic structs are gathered in the new radeon_asic.c file. Tested on my rv570. I've also added a new patch that gathers all r100 specific declarations into radeon_asic.h (at least where it makes sense). This is just an example to convince Jerome that radeon_asic.h might not be totally useless ;) Again, comments higly welcome. Yours, Daniel I would merge patch 1 2 into a single patch, also i think you include radeon_asic.h at top of radeon.h so everyfile would also include radeon_asic.h that would be simplier than adding include to file and reduce the likelyhood to forget doing so in the future. (you might need to add forward declaration like struct radeon; at top of radeon_asic.h no biggy thought). Cheers, Jerome -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH 0/5] clean up radeon_asic.h v2
On Fri, Mar 12, 2010 at 10:25:56AM +0100, Jerome Glisse wrote: I would merge patch 1 2 into a single patch, I've split this up to make patch-reading easier. And it's fully bisectable. ... also i think you include radeon_asic.h at top of radeon.h so everyfile would also include radeon_asic.h that would be simplier than adding include to file and reduce the likelyhood to forget doing so in the future. (you might need to add forward declaration like struct radeon; at top of radeon_asic.h no biggy thought). I disagree. It's not quite there yet, but when all the asic specific stuff is gathered in radeon_asic.h (like I've done for r100 in my last patch), radeon_asic.h is the private header for asic stuff. And radeon.h is the public interface for radeon_asic. Then adding #include radeon_asic.h in random places would serve as a warning sign that there's likely a layering violation ahead. After all, generic code should not muck around in the asic private stuff. Unconditionally including radeon_asic.h therefore runs counter to the bigger idea behind my patches. Cheers, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[PATCH 0/5] clean up radeon_asic.h v2
Hi all, All new patch pile to make radeon_asic.h into a real header file. Now all the asic structs are gathered in the new radeon_asic.c file. Tested on my rv570. I've also added a new patch that gathers all r100 specific declarations into radeon_asic.h (at least where it makes sense). This is just an example to convince Jerome that radeon_asic.h might not be totally useless ;) Again, comments higly welcome. Yours, Daniel Daniel Vetter (5): drm/radeon: create radeon_asic.c drm/radeon: move asic structs to radeon_asic.c drm/radeon: unconfuse return value of radeon_asic-clear_surface_reg drm/radeon: include radeon_asic.h in the asic specific files drm/radeon: collect r100 asic related declarations in radeon_asic.h drivers/gpu/drm/radeon/Makefile|2 +- drivers/gpu/drm/radeon/evergreen.c |1 + drivers/gpu/drm/radeon/r100.c |1 + drivers/gpu/drm/radeon/r200.c |1 + drivers/gpu/drm/radeon/r300.c |1 + drivers/gpu/drm/radeon/r420.c |1 + drivers/gpu/drm/radeon/r520.c |1 + drivers/gpu/drm/radeon/r600.c |1 + drivers/gpu/drm/radeon/radeon.h| 55 +--- drivers/gpu/drm/radeon/radeon_asic.c | 723 drivers/gpu/drm/radeon/radeon_asic.h | 545 +++-- drivers/gpu/drm/radeon/radeon_device.c | 199 - drivers/gpu/drm/radeon/rs400.c |1 + drivers/gpu/drm/radeon/rs600.c |1 + drivers/gpu/drm/radeon/rs690.c |1 + drivers/gpu/drm/radeon/rv515.c |1 + drivers/gpu/drm/radeon/rv770.c |1 + 17 files changed, 793 insertions(+), 743 deletions(-) create mode 100644 drivers/gpu/drm/radeon/radeon_asic.c -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
