Re: [PATCH 2/3] wfx: add antenna configuration files
On Thu, Jul 7, 2022 at 1:04 PM Ben Brown wrote: > > On 21/02/2022 16:37, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > > diff --git a/WHENCE b/WHENCE > > index 0a6cb15..96f67f7 100644 > > --- a/WHENCE > > +++ b/WHENCE > > @@ -5845,8 +5845,18 @@ Driver: wfx - Silicon Labs Wi-Fi Transceiver > > File: wfx/wfm_wf200_C0.sec > > Version: 3.12.1 > > > > +File: wfx/brd4001a.pds not listed in WHENCE > > +File: wfx/brd8022a.pds not listed in WHENCE > > +File: wfx/brd8023a.pds not listed in WHENCE > > This format does not appear to be correct. While this will seemingly > pass the `check_whence.py` check, it will be completely ignored by > `copy-firmware.sh`, as that takes the full line after 'File: ' (e.g. > 'wfx/brd4001a.pds not listed in WHENCE', which of course does not exist). Oh, indeed. > I'm assuming the trailing ' not listed in WHENCE' needs to be removed > from each of these lines. Otherwise these are likely not being picked up > by distros (they are missing from Arch, for example). This may have been > the intention, but that seems odd (and unclear if so). I doubt that was the intention. I'll correct WHENCE in a separate commit. Thank you for reporting the issue. josh ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/3] linux-firmware: update wfx
On Mon, Feb 21, 2022 at 11:38 AM Jerome Pouiller
wrote:
>
> From: Jérôme Pouiller
>
> The two first patches reflect changes made in the kernel.
>
> Jérôme Pouiller (3):
> wfx: rename silabs/ into wfx/
> wfx: add antenna configuration files
> wfx: update to firmware 3.14
All 3 applied and pushed out.
josh
>
> WHENCE| 18 ++
> silabs/wfm_wf200_C0.sec | Bin 305232 -> 0 bytes
> {silabs => wfx}/LICENCE.wf200 | 0
> wfx/brd4001a.pds | Bin 0 -> 625 bytes
> wfx/brd8022a.pds | Bin 0 -> 584 bytes
> wfx/brd8023a.pds | Bin 0 -> 625 bytes
> wfx/wfm_wf200_C0.sec | Bin 0 -> 309328 bytes
> 7 files changed, 14 insertions(+), 4 deletions(-)
> delete mode 100644 silabs/wfm_wf200_C0.sec
> rename {silabs => wfx}/LICENCE.wf200 (100%)
> create mode 100644 wfx/brd4001a.pds
> create mode 100644 wfx/brd8022a.pds
> create mode 100644 wfx/brd8023a.pds
> create mode 100644 wfx/wfm_wf200_C0.sec
>
> --
> 2.34.1
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: imx-hdmi fails to build with v3.13-10094-g9b0cd30
On Thu, Jan 30, 2014 at 2:31 PM, Fabio Estevam wrote: > On Thu, Jan 30, 2014 at 5:28 PM, Josh Boyer wrote: >> Hi All, >> >> After the DRM merge the imx-hdmi driver fails to build with the error >> below. I'm somewhat surprised this wasn't hit in linux-next. >> > > Sachin has already sent a patch to fix this issue: > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-January/045167.html Wonderful. Thanks for the quick response. Out of curiosity, was this hit in linux-next? Or is the config option not enabled in any of the configs built there? josh ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
imx-hdmi fails to build with v3.13-10094-g9b0cd30
Hi All,
After the DRM merge the imx-hdmi driver fails to build with the error
below. I'm somewhat surprised this wasn't hit in linux-next.
josh
drivers/staging/imx-drm/imx-hdmi.c:55:6: error: nested redefinition of
'enum hdmi_colorimetry'
enum hdmi_colorimetry {
^
drivers/staging/imx-drm/imx-hdmi.c:55:6: error: redeclaration of 'enum
hdmi_colorimetry'
In file included from include/drm/drm_crtc.h:33:0,
from include/drm/drmP.h:711,
from drivers/staging/imx-drm/imx-hdmi.c:24:
include/linux/hdmi.h:48:6: note: originally defined here
enum hdmi_colorimetry {
^
make[3]: *** [drivers/staging/imx-drm/imx-hdmi.o] Error 1
make[3]: *** Waiting for unfinished jobs
make[2]: *** [drivers/staging/imx-drm] Error 2
make[1]: *** [drivers/staging] Error 2
make[1]: *** Waiting for unfinished jobs
make: *** [drivers] Error 2
+ exit 1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: imx-drm: Fix modular build of DRM_IMX_IPUV3
On Tue, Nov 19, 2013 at 09:39:19PM -0800, Greg KH wrote: > On Tue, Nov 19, 2013 at 08:56:59PM -0500, Josh Boyer wrote: > > On Mon, Nov 18, 2013 at 10:03:10AM +0100, Sascha Hauer wrote: > > > On Tue, Nov 12, 2013 at 12:15:45PM -0500, Josh Boyer wrote: > > > > commit b8d181e408af (staging: drm/imx: add drm plane support) added a > > > > file > > > > to the make target for DRM_IMX_IPUV3 but didn't adjust the objs required > > > > to actually build that as a module. Kbuild got confused and this lead > > > > to > > > > link errors like: > > > > > > > > ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko] > > > > undefined! > > > > ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] > > > > undefined! > > > > > > > > Additionally, it added a call to imx_drm_crtc_id which also fails with a > > > > link error as above. To fix this, we adjust the make target with the > > > > proper > > > > objs, which will change the name of the resulting .ko. We also add an > > > > EXPORT_SYMBOL_GPL for imx_drm_crtc_id. > > > > > > > > Signed-off-by: Josh Boyer > > > > > > > > > Acked-by: Sascha Hauer > > > > > > Sascha > > > > Thanks. So who picks this fix up? Greg, is that you? > > Yes, I will once 3.13-rc1 is out. OK. And send it to Linus for 3.13-rc2? I know you've been traveling and are busy, so I'm just pointing out it's a fix for 3.13. josh ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: imx-drm: Fix modular build of DRM_IMX_IPUV3
On Mon, Nov 18, 2013 at 10:03:10AM +0100, Sascha Hauer wrote:
> On Tue, Nov 12, 2013 at 12:15:45PM -0500, Josh Boyer wrote:
> > commit b8d181e408af (staging: drm/imx: add drm plane support) added a file
> > to the make target for DRM_IMX_IPUV3 but didn't adjust the objs required
> > to actually build that as a module. Kbuild got confused and this lead to
> > link errors like:
> >
> > ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko]
> > undefined!
> > ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
> >
> > Additionally, it added a call to imx_drm_crtc_id which also fails with a
> > link error as above. To fix this, we adjust the make target with the proper
> > objs, which will change the name of the resulting .ko. We also add an
> > EXPORT_SYMBOL_GPL for imx_drm_crtc_id.
> >
> > Signed-off-by: Josh Boyer
>
>
> Acked-by: Sascha Hauer
>
> Sascha
Thanks. So who picks this fix up? Greg, is that you?
josh
>
> > ---
> > drivers/staging/imx-drm/Makefile | 4 +++-
> > drivers/staging/imx-drm/imx-drm-core.c | 1 +
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/imx-drm/Makefile
> > b/drivers/staging/imx-drm/Makefile
> > index 2c3a9e1..8742432 100644
> > --- a/drivers/staging/imx-drm/Makefile
> > +++ b/drivers/staging/imx-drm/Makefile
> > @@ -8,4 +8,6 @@ obj-$(CONFIG_DRM_IMX_TVE) += imx-tve.o
> > obj-$(CONFIG_DRM_IMX_LDB) += imx-ldb.o
> > obj-$(CONFIG_DRM_IMX_FB_HELPER) += imx-fbdev.o
> > obj-$(CONFIG_DRM_IMX_IPUV3_CORE) += ipu-v3/
> > -obj-$(CONFIG_DRM_IMX_IPUV3)+= ipuv3-crtc.o ipuv3-plane.o
> > +
> > +imx-ipuv3-crtc-objs := ipuv3-crtc.o ipuv3-plane.o
> > +obj-$(CONFIG_DRM_IMX_IPUV3)+= imx-ipuv3-crtc.o
> > diff --git a/drivers/staging/imx-drm/imx-drm-core.c
> > b/drivers/staging/imx-drm/imx-drm-core.c
> > index 4483d47..2b366d8 100644
> > --- a/drivers/staging/imx-drm/imx-drm-core.c
> > +++ b/drivers/staging/imx-drm/imx-drm-core.c
> > @@ -72,6 +72,7 @@ int imx_drm_crtc_id(struct imx_drm_crtc *crtc)
> > {
> > return crtc->pipe;
> > }
> > +EXPORT_SYMBOL_GPL(imx_drm_crtc_id);
> >
> > static void imx_drm_driver_lastclose(struct drm_device *drm)
> > {
> > --
> > 1.8.3.1
> >
> >
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: imx-drm: Fix modular build of DRM_IMX_IPUV3
commit b8d181e408af (staging: drm/imx: add drm plane support) added a file
to the make target for DRM_IMX_IPUV3 but didn't adjust the objs required
to actually build that as a module. Kbuild got confused and this lead to
link errors like:
ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
Additionally, it added a call to imx_drm_crtc_id which also fails with a
link error as above. To fix this, we adjust the make target with the proper
objs, which will change the name of the resulting .ko. We also add an
EXPORT_SYMBOL_GPL for imx_drm_crtc_id.
Signed-off-by: Josh Boyer
---
drivers/staging/imx-drm/Makefile | 4 +++-
drivers/staging/imx-drm/imx-drm-core.c | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/Makefile b/drivers/staging/imx-drm/Makefile
index 2c3a9e1..8742432 100644
--- a/drivers/staging/imx-drm/Makefile
+++ b/drivers/staging/imx-drm/Makefile
@@ -8,4 +8,6 @@ obj-$(CONFIG_DRM_IMX_TVE) += imx-tve.o
obj-$(CONFIG_DRM_IMX_LDB) += imx-ldb.o
obj-$(CONFIG_DRM_IMX_FB_HELPER) += imx-fbdev.o
obj-$(CONFIG_DRM_IMX_IPUV3_CORE) += ipu-v3/
-obj-$(CONFIG_DRM_IMX_IPUV3)+= ipuv3-crtc.o ipuv3-plane.o
+
+imx-ipuv3-crtc-objs := ipuv3-crtc.o ipuv3-plane.o
+obj-$(CONFIG_DRM_IMX_IPUV3)+= imx-ipuv3-crtc.o
diff --git a/drivers/staging/imx-drm/imx-drm-core.c
b/drivers/staging/imx-drm/imx-drm-core.c
index 4483d47..2b366d8 100644
--- a/drivers/staging/imx-drm/imx-drm-core.c
+++ b/drivers/staging/imx-drm/imx-drm-core.c
@@ -72,6 +72,7 @@ int imx_drm_crtc_id(struct imx_drm_crtc *crtc)
{
return crtc->pipe;
}
+EXPORT_SYMBOL_GPL(imx_drm_crtc_id);
static void imx_drm_driver_lastclose(struct drm_device *drm)
{
--
1.8.3.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: imx-drm/ipuv3-crtc.ko fails to link
On Tue, Nov 12, 2013 at 9:57 AM, Sascha Hauer wrote: > Hi Josh, > > On Tue, Nov 12, 2013 at 09:32:08AM -0500, Josh Boyer wrote: >> On Mon, Nov 11, 2013 at 11:22 AM, Josh Boyer >> wrote: >> > Hi All, >> > >> > With v3.12-2839-gedae583 (Linus' tree as of this morning), the >> > ipuv3-crtc.ko module fails to link with the following messages: >> > >> > ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko] >> > undefined! >> > ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] >> > undefined! >> > ERROR: "ipu_plane_irq" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! >> > ERROR: "ipu_plane_get_resources" >> > [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! >> > ERROR: "ipu_plane_init" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! >> > ERROR: "imx_drm_crtc_id" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! >> > ERROR: "ipu_plane_mode_set" [drivers/staging/imx-drm/ipuv3-crtc.ko] >> > undefined! >> > ERROR: "ipu_plane_set_base" [drivers/staging/imx-drm/ipuv3-crtc.ko] >> > undefined! >> > ERROR: "ipu_plane_put_resources" >> > [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! >> > make[1]: *** [__modpost] Error 1 >> > make: *** [modules] Error 2 >> >> Actually, I think this is because ipuv3-plane.c was added to the >> Makefile as a requisite file for ipuv3-crtc.ko with commit >> b8d181e408af6a017d, but Kbuild isn't interpreting it that way because >> it's a tristate option, not a bool. Making it work would require >> something like: >> >> imx-ipuv3-crct-objs := ipuv3-crtc.o ipuv3-plane.o >> obj-$(CONFIG_DRM_IMX_IPUV3) += imx-ipuv3-crct.o >> >> But that would rename the module from ipuv3-crtc.ko to >> imx-ipuv3-crct.ko. Even with that, it still fails to link with: >> >> ERROR: "imx_drm_crtc_id" [drivers/staging/imx-drm/imx-ipuv3-crtc.ko] >> undefined! >> >> So two questions really. >> >> 1) Are the tristate options for DRM_IMX_IPUV3, DRM_IMX_IPUV3_CORE, >> DRM_IMX_LDB, DRM_IMX_TVE, DRM_IMX_PARALLEL_DISPLAY, and >> DRM_IMX_FB_HELPER really all supposed to be separate modules, or >> should they be boolean options to the main DRM_IMX tristate? > > I think at least the ipuv3 core should be a separate module since this > could be used without drm support (for the input pathes, handled via v4l2) > >> >> 2) If the answer to question 1 is "all separate modules", then either >> ipuv3-crtc.c needs to be renamed or the final module name will be >> different. > > The final module name shouldn't matter, we can change it. OK. > Does a EXPORT_SYMBOL_GPL(imx_drm_crtc_id) help fixing the problem? I'm sure it would. Haven't had a chance to test it yet. Since the module name change isn't a big deal, I'll see if I can come up with a patch to fix the Makefile and linking issues and send that out. >> And did anyone actually try building all of these as modules? This >> used to work in 3.12, but I'm not sure that was actually tested there >> either. > > At least I explicitly made this work when writing the IPU stuff, but I > must admit that we mostly use monolithic kernels here. I figured as much. Fedora builds them as modules, presumably because we build multiboard kernels and building this in doesn't benefit everything those run on. josh ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: imx-drm/ipuv3-crtc.ko fails to link
On Mon, Nov 11, 2013 at 11:22 AM, Josh Boyer wrote: > Hi All, > > With v3.12-2839-gedae583 (Linus' tree as of this morning), the > ipuv3-crtc.ko module fails to link with the following messages: > > ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! > ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! > ERROR: "ipu_plane_irq" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! > ERROR: "ipu_plane_get_resources" > [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! > ERROR: "ipu_plane_init" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! > ERROR: "imx_drm_crtc_id" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! > ERROR: "ipu_plane_mode_set" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! > ERROR: "ipu_plane_set_base" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! > ERROR: "ipu_plane_put_resources" > [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 Actually, I think this is because ipuv3-plane.c was added to the Makefile as a requisite file for ipuv3-crtc.ko with commit b8d181e408af6a017d, but Kbuild isn't interpreting it that way because it's a tristate option, not a bool. Making it work would require something like: imx-ipuv3-crct-objs := ipuv3-crtc.o ipuv3-plane.o obj-$(CONFIG_DRM_IMX_IPUV3) += imx-ipuv3-crct.o But that would rename the module from ipuv3-crtc.ko to imx-ipuv3-crct.ko. Even with that, it still fails to link with: ERROR: "imx_drm_crtc_id" [drivers/staging/imx-drm/imx-ipuv3-crtc.ko] undefined! So two questions really. 1) Are the tristate options for DRM_IMX_IPUV3, DRM_IMX_IPUV3_CORE, DRM_IMX_LDB, DRM_IMX_TVE, DRM_IMX_PARALLEL_DISPLAY, and DRM_IMX_FB_HELPER really all supposed to be separate modules, or should they be boolean options to the main DRM_IMX tristate? 2) If the answer to question 1 is "all separate modules", then either ipuv3-crtc.c needs to be renamed or the final module name will be different. And did anyone actually try building all of these as modules? This used to work in 3.12, but I'm not sure that was actually tested there either. josh ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
imx-drm/ipuv3-crtc.ko fails to link
Hi All, With v3.12-2839-gedae583 (Linus' tree as of this morning), the ipuv3-crtc.ko module fails to link with the following messages: ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! ERROR: "ipu_plane_irq" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! ERROR: "ipu_plane_get_resources" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! ERROR: "ipu_plane_init" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! ERROR: "imx_drm_crtc_id" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! ERROR: "ipu_plane_mode_set" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! ERROR: "ipu_plane_set_base" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! ERROR: "ipu_plane_put_resources" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 The relevant .config hunks are configured as such: CONFIG_DRM_IMX=m CONFIG_DRM_IMX_FB_HELPER=m CONFIG_DRM_IMX_PARALLEL_DISPLAY=m CONFIG_DRM_IMX_TVE=m # CONFIG_DRM_IMX_LDB is not set CONFIG_DRM_IMX_IPUV3_CORE=m CONFIG_DRM_IMX_IPUV3=m I can send the full .config if people would like to see it. I'm guessing the ipu_plane_* functions listed here need EXPORT_SYMBOL statements added to them. Is this currently queued in anyone's tree? josh ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
