[PATCH] drivers: staging: Fix spelling in comments
Fixed two spelling in two different comments. s/defalut/default/p This is in linux-next. Signed-off-by: Bhaskar Chowdhury --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index 1af919ff6d93..391c59490718 100644 --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c @@ -52,7 +52,7 @@ static void Init_ODM_ComInfo_88E(struct adapter *Adapter) * The base index = * 12. +((12-n)/2)dB 13~?? = decrease tx pwr by -((n-12)/2)dB */ - dm_odm->BbSwingIdxOfdm = 12; /* Set defalut value as index 12. */ + dm_odm->BbSwingIdxOfdm = 12; /* Set default value as index 12. */ dm_odm->BbSwingIdxOfdmCurrent = 12; dm_odm->BbSwingFlagOfdm = false; @@ -109,7 +109,7 @@ static void Update_ODM_ComInfo_88E(struct adapter *Adapter) * The base index = * 12. +((12-n)/2)dB 13~?? = decrease tx pwr by -((n-12)/2)dB */ - dm_odm->BbSwingIdxOfdm = 12; /* Set defalut value as index 12. */ + dm_odm->BbSwingIdxOfdm = 12; /* Set default value as index 12. */ dm_odm->BbSwingIdxOfdmCurrent = 12; dm_odm->BbSwingFlagOfdm = false; -- 2.26.2 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] drivers: staging: Fix spelling in comments
On Thu, Oct 29, 2020 at 03:37:59PM +0530, Bhaskar Chowdhury wrote: > Fixed two spelling in two different comments. > > s/defalut/default/p > > This is in linux-next. No need for this line, it doesn't make any sense here, right? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] drivers: staging: Fix spelling in comments
On Thu, Oct 29, 2020 at 03:37:59PM +0530, Bhaskar Chowdhury wrote: > Fixed two spelling in two different comments. > > s/defalut/default/p > > This is in linux-next. > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Please put the driver name in the subject line, like other patches for this file do. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: fieldbus: Use %pM format specifier for MAC addresses
On Wed, Oct 28, 2020 at 07:39:58PM -0400, Sven Van Asbroeck wrote: > On Tue, Oct 27, 2020 at 2:34 PM Andy Shevchenko > wrote: > > > > + return snprintf(buf, max_size, "%pM\n", response.addr); > > Judging from a few Outreachy patches that have hit my inbox, snprintf() is > considered unsafe in a sysfs_get callback. It should be replaced by > scnprintf() or even better, sysfs_emit(), which was recently introduced > to address sprintf-variant issues in sysfs callbacks. It's already applied, I think you can send a follow up for above, which is good point, but not the scope of the patch (although they might have been unified together). -- With Best Regards, Andy Shevchenko ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] drivers: staging: rtl8188eu: Fix spelling in two comments i.e defalut to default
Fixed two spelling in two different comments. s/defalut/default/p Signed-off-by: Bhaskar Chowdhury --- Greg, I have included the driver name as you suggested. drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index 1af919ff6d93..391c59490718 100644 --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c @@ -52,7 +52,7 @@ static void Init_ODM_ComInfo_88E(struct adapter *Adapter) * The base index = * 12. +((12-n)/2)dB 13~?? = decrease tx pwr by -((n-12)/2)dB */ - dm_odm->BbSwingIdxOfdm = 12; /* Set defalut value as index 12. */ + dm_odm->BbSwingIdxOfdm = 12; /* Set default value as index 12. */ dm_odm->BbSwingIdxOfdmCurrent = 12; dm_odm->BbSwingFlagOfdm = false; @@ -109,7 +109,7 @@ static void Update_ODM_ComInfo_88E(struct adapter *Adapter) * The base index = * 12. +((12-n)/2)dB 13~?? = decrease tx pwr by -((n-12)/2)dB */ - dm_odm->BbSwingIdxOfdm = 12; /* Set defalut value as index 12. */ + dm_odm->BbSwingIdxOfdm = 12; /* Set default value as index 12. */ dm_odm->BbSwingIdxOfdmCurrent = 12; dm_odm->BbSwingFlagOfdm = false; -- 2.26.2 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] drivers: staging: rtl8188eu: Fix spelling in two comments i.e defalut to default
On Thu, Oct 29, 2020 at 04:36:00PM +0530, Bhaskar Chowdhury wrote: > Fixed two spelling in two different comments. > > s/defalut/default/p > > Signed-off-by: Bhaskar Chowdhury > --- > Greg, I have included the driver name as you suggested. Suggested when, is this a v2 patch? Remember, kernel maintainers have the short-term memory of a squirrel... Please resend and properly version your patch as the Documentation asks you to. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: rtl8723bs: core: rtw_cmd: Fixed four if-statement coding style issues
Fixed four cases where the if-statement coding style wasn't following
the guidelines.
Signed-off-by: Manuel Palenzuela
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c
b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 4cf09d947d32..55142faa2213 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -344,7 +344,7 @@ int rtw_enqueue_cmd(struct cmd_priv *pcmdpriv, struct
cmd_obj *cmd_obj)
cmd_obj->padapter = padapter;
res = rtw_cmd_filter(pcmdpriv, cmd_obj);
- if (_FAIL == res) {
+ if (res == _FAIL) {
rtw_free_cmd_obj(cmd_obj);
goto exit;
}
@@ -460,7 +460,7 @@ int rtw_cmd_thread(void *context)
cmd_start_time = jiffies;
- if (_FAIL == rtw_cmd_filter(pcmdpriv, pcmd)) {
+ if (rtw_cmd_filter(pcmdpriv, pcmd) == _FAIL) {
pcmd->res = H2C_DROPPED;
goto post_process;
}
@@ -908,7 +908,7 @@ u8 rtw_disassoc_cmd(struct adapter *padapter, u32
deauth_timeout_ms, bool enqueu
res = rtw_enqueue_cmd(cmdpriv, cmdobj);
} else {
/* no need to enqueue, do the cmd hdl directly and free cmd
parameter */
- if (H2C_SUCCESS != disconnect_hdl(padapter, (u8 *)param))
+ if (disconnect_hdl(padapter, (u8 *)param) != H2C_SUCCESS)
res = _FAIL;
kfree(param);
}
@@ -1249,7 +1249,7 @@ u8 rtw_set_chplan_cmd(struct adapter *padapter, u8
chplan, u8 enqueue, u8 swconf
res = rtw_enqueue_cmd(pcmdpriv, pcmdobj);
} else {
/* no need to enqueue, do the cmd hdl directly and free cmd
parameter */
- if (H2C_SUCCESS != set_chplan_hdl(padapter, (unsigned char
*)setChannelPlan_param))
+ if (set_chplan_hdl(padapter, (unsigned char
*)setChannelPlan_param) != H2C_SUCCESS)
res = _FAIL;
kfree(setChannelPlan_param);
--
2.26.2
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH V2] drivers: staging: rtl8188eu: Fix spelling in two comments i.e defalut to default
Fixed two spelling in two different comments. s/defalut/default/p Signed-off-by: Bhaskar Chowdhury --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index 1af919ff6d93..391c59490718 100644 --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c @@ -52,7 +52,7 @@ static void Init_ODM_ComInfo_88E(struct adapter *Adapter) * The base index = * 12. +((12-n)/2)dB 13~?? = decrease tx pwr by -((n-12)/2)dB */ - dm_odm->BbSwingIdxOfdm = 12; /* Set defalut value as index 12. */ + dm_odm->BbSwingIdxOfdm = 12; /* Set default value as index 12. */ dm_odm->BbSwingIdxOfdmCurrent = 12; dm_odm->BbSwingFlagOfdm = false; @@ -109,7 +109,7 @@ static void Update_ODM_ComInfo_88E(struct adapter *Adapter) * The base index = * 12. +((12-n)/2)dB 13~?? = decrease tx pwr by -((n-12)/2)dB */ - dm_odm->BbSwingIdxOfdm = 12; /* Set defalut value as index 12. */ + dm_odm->BbSwingIdxOfdm = 12; /* Set default value as index 12. */ dm_odm->BbSwingIdxOfdmCurrent = 12; dm_odm->BbSwingFlagOfdm = false; -- 2.26.2 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH V2] drivers: staging: rtl8188eu: Fix spelling in two comments i.e defalut to default
On Thu, Oct 29, 2020 at 05:37:25PM +0530, Bhaskar Chowdhury wrote: > Fixed two spelling in two different comments. > > s/defalut/default/p > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) What changed from v1? That always goes below the --- line, please fix up and send a v3. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH V3] drivers: staging: rtl8188eu: Fix spelling in two comments i.e defalut to default
Fixed two spelling in two different comments. s/defalut/default/p Signed-off-by: Bhaskar Chowdhury --- Changes from V2 : version change to reflect the correct one. drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index 1af919ff6d93..391c59490718 100644 --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c @@ -52,7 +52,7 @@ static void Init_ODM_ComInfo_88E(struct adapter *Adapter) * The base index = * 12. +((12-n)/2)dB 13~?? = decrease tx pwr by -((n-12)/2)dB */ - dm_odm->BbSwingIdxOfdm = 12; /* Set defalut value as index 12. */ + dm_odm->BbSwingIdxOfdm = 12; /* Set default value as index 12. */ dm_odm->BbSwingIdxOfdmCurrent = 12; dm_odm->BbSwingFlagOfdm = false; @@ -109,7 +109,7 @@ static void Update_ODM_ComInfo_88E(struct adapter *Adapter) * The base index = * 12. +((12-n)/2)dB 13~?? = decrease tx pwr by -((n-12)/2)dB */ - dm_odm->BbSwingIdxOfdm = 12; /* Set defalut value as index 12. */ + dm_odm->BbSwingIdxOfdm = 12; /* Set default value as index 12. */ dm_odm->BbSwingIdxOfdmCurrent = 12; dm_odm->BbSwingFlagOfdm = false; -- 2.26.2 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH, net -> staging, v2] wimax: move out to staging
From: Arnd Bergmann
There are no known users of this driver as of October 2020, and it will
be removed unless someone turns out to still need it in future releases.
According to https://en.wikipedia.org/wiki/List_of_WiMAX_networks, there
have been many public wimax networks, but it appears that many of these
have migrated to LTE or discontinued their service altogether.
As most PCs and phones lack WiMAX hardware support, the remaining
networks tend to use standalone routers. These almost certainly
run Linux, but not a modern kernel or the mainline wimax driver stack.
NetworkManager appears to have dropped userspace support in 2015
https://bugzilla.gnome.org/show_bug.cgi?id=747846, the
www.linuxwimax.org
site had already shut down earlier.
WiMax is apparently still being deployed on airport campus networks
("AeroMACS"), but in a frequency band that was not supported by the old
Intel 2400m (used in Sandy Bridge laptops and earlier), which is the
only driver using the kernel's wimax stack.
Move all files into drivers/staging/wimax, including the uapi header
files and documentation, to make it easier to remove it when it gets
to that. Only minimal changes are made to the source files, in order
to make it possible to port patches across the move.
Also remove the MAINTAINERS entry that refers to a broken mailing
list and website.
Suggested-by: Inaky Perez-Gonzalez
Signed-off-by: Arnd Bergmann
---
changes in v2:
- fix a build regression
- add more information about remaining networks (Dan Carpenter)_
For v1, Greg said he'd appply the patch when he gets an Ack
from the maintainers.
Inaky, Johannes, Jakub: are you happy with this version?
---
Documentation/admin-guide/index.rst | 1 -
Documentation/networking/kapi.rst | 21 --
.../translations/zh_CN/admin-guide/index.rst | 1 -
MAINTAINERS | 22 ---
drivers/net/Kconfig | 2 --
drivers/net/Makefile | 1 -
drivers/net/wimax/Kconfig | 18 ---
drivers/net/wimax/Makefile| 2 --
drivers/staging/Kconfig | 2 ++
drivers/staging/Makefile | 1 +
.../staging/wimax/Documentation}/i2400m.rst | 0
.../staging/wimax/Documentation}/index.rst| 0
.../staging/wimax/Documentation}/wimax.rst| 0
{net => drivers/staging}/wimax/Kconfig| 6 +
{net => drivers/staging}/wimax/Makefile | 2 ++
drivers/staging/wimax/TODO| 18 +++
{net => drivers/staging}/wimax/debug-levels.h | 2 +-
{net => drivers/staging}/wimax/debugfs.c | 2 +-
drivers/{net => staging}/wimax/i2400m/Kconfig | 0
.../{net => staging}/wimax/i2400m/Makefile| 0
.../{net => staging}/wimax/i2400m/control.c | 2 +-
.../wimax/i2400m/debug-levels.h | 2 +-
.../{net => staging}/wimax/i2400m/debugfs.c | 0
.../{net => staging}/wimax/i2400m/driver.c| 2 +-
drivers/{net => staging}/wimax/i2400m/fw.c| 0
.../wimax/i2400m/i2400m-usb.h | 0
.../{net => staging}/wimax/i2400m/i2400m.h| 4 ++--
.../staging/wimax/i2400m/linux-wimax-i2400m.h | 0
.../{net => staging}/wimax/i2400m/netdev.c| 0
.../{net => staging}/wimax/i2400m/op-rfkill.c | 2 +-
drivers/{net => staging}/wimax/i2400m/rx.c| 0
drivers/{net => staging}/wimax/i2400m/sysfs.c | 0
drivers/{net => staging}/wimax/i2400m/tx.c| 0
.../wimax/i2400m/usb-debug-levels.h | 2 +-
.../{net => staging}/wimax/i2400m/usb-fw.c| 0
.../{net => staging}/wimax/i2400m/usb-notif.c | 0
.../{net => staging}/wimax/i2400m/usb-rx.c| 0
.../{net => staging}/wimax/i2400m/usb-tx.c| 0
drivers/{net => staging}/wimax/i2400m/usb.c | 2 +-
{net => drivers/staging}/wimax/id-table.c | 2 +-
.../staging/wimax/linux-wimax-debug.h | 2 +-
.../staging/wimax/linux-wimax.h | 0
.../staging/wimax/net-wimax.h | 2 +-
{net => drivers/staging}/wimax/op-msg.c | 2 +-
{net => drivers/staging}/wimax/op-reset.c | 4 ++--
{net => drivers/staging}/wimax/op-rfkill.c| 4 ++--
{net => drivers/staging}/wimax/op-state-get.c | 4 ++--
{net => drivers/staging}/wimax/stack.c| 2 +-
.../staging}/wimax/wimax-internal.h | 2 +-
net/Kconfig | 2 --
net/Makefile | 1 -
51 files changed, 51 insertions(+), 93 deletions(-)
delete mode 100644 drivers/net/wimax/Kconfig
delete mode 100644 drivers/net/wimax/Makefile
rename {Documentation/admin-guide/wimax =>
drivers/staging/wimax/Documentation}/i2400m.rst (100%)
rename {Documentation/admin-guide/wimax =>
drivers/staging/wimax/Documentation}/index.rst (100%)
rename {Documentation/admin-guide/wimax =>
drivers/staging/wimax/Documentation}/wimax.rst (100%)
rename {net => drivers/staging}/wimax/Kconfig (94%)
rename {net
[PATCH] staging: comedi: cb_pcidas: reinstate delay removed from trimpot setting
Commit eddd2a4c675c ("staging: comedi: cb_pcidas: refactor
write_calibration_bitstream()") inadvertently removed one of the
`udelay(1)` calls when writing to the calibration register in
`cb_pcidas_calib_write()`. Reinstate the delay. It may seem strange
that the delay is placed before the register write, but this function is
called in a loop so the extra delay can make a difference.
This _might_ solve reported issues reading analog inputs on a
PCIe-DAS1602/16 card where the analog input values "were scaled in a
strange way that didn't make sense". On the same hardware running a
system with a 3.13 kernel, and then a system with a 4.4 kernel, but with
the same application software, the system with the 3.13 kernel was fine,
but the one with the 4.4 kernel exhibited the problem. Of the 90
changes to the driver between those kernel versions, this change looked
like the most likely culprit.
Fixes: eddd2a4c675c ("staging: comedi: cb_pcidas: refactor
write_calibration_bitstream()")
Cc:
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/cb_pcidas.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c
b/drivers/staging/comedi/drivers/cb_pcidas.c
index 48ec2ee953dc..4f2ac39aa619 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas.c
@@ -529,6 +529,7 @@ static void cb_pcidas_calib_write(struct comedi_device *dev,
if (trimpot) {
/* select trimpot */
calib_bits |= PCIDAS_CALIB_TRIM_SEL;
+ udelay(1);
outw(calib_bits, devpriv->pcibar1 + PCIDAS_CALIB_REG);
}
--
2.28.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH, net -> staging, v2] wimax: move out to staging
On Thu, 2020-10-29 at 14:43 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> There are no known users of this driver as of October 2020, and it will
> be removed unless someone turns out to still need it in future releases.
>
> According to https://en.wikipedia.org/wiki/List_of_WiMAX_networks, there
> have been many public wimax networks, but it appears that many of these
> have migrated to LTE or discontinued their service altogether.
> As most PCs and phones lack WiMAX hardware support, the remaining
> networks tend to use standalone routers. These almost certainly
> run Linux, but not a modern kernel or the mainline wimax driver stack.
>
> NetworkManager appears to have dropped userspace support in 2015
> https://bugzilla.gnome.org/show_bug.cgi?id=747846, the
> www.linuxwimax.org
> site had already shut down earlier.
>
> WiMax is apparently still being deployed on airport campus networks
> ("AeroMACS"), but in a frequency band that was not supported by the old
> Intel 2400m (used in Sandy Bridge laptops and earlier), which is the
> only driver using the kernel's wimax stack.
>
> Move all files into drivers/staging/wimax, including the uapi header
> files and documentation, to make it easier to remove it when it gets
> to that. Only minimal changes are made to the source files, in order
> to make it possible to port patches across the move.
>
> Also remove the MAINTAINERS entry that refers to a broken mailing
> list and website.
>
> Suggested-by: Inaky Perez-Gonzalez
> Signed-off-by: Arnd Bergmann
> ---
> changes in v2:
> - fix a build regression
> - add more information about remaining networks (Dan Carpenter)_
>
> For v1, Greg said he'd appply the patch when he gets an Ack
> from the maintainers.
>
> Inaky, Johannes, Jakub: are you happy with this version?
Sure, looks fine to me.
Acked-by: Johannes Berg
Not that I have much relation to this code other than having fixed up
genetlink stuff over the years :)
johannes
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH -next] binder: change error code from postive to negative in binder_transaction
On Mon, Oct 26, 2020 at 07:03:14PM +0800, Zhang Qilong wrote: > Depending on the context, the error return value > here (extra_buffers_size < added_size) should be > negative. > > Signed-off-by: Zhang Qilong > --- Thanks! Acked-by: Christian Brauner ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [RFC] wimax: move out to staging
On Wed, 28 Oct 2020 06:56:28 +0100 Greg Kroah-Hartman wrote:
> On Tue, Oct 27, 2020 at 10:20:13PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > There are no known users of this driver as of October 2020, and it will
> > be removed unless someone turns out to still need it in future releases.
> >
> > According to https://en.wikipedia.org/wiki/List_of_WiMAX_networks, there
> > have been many public wimax networks, but it appears that these entries
> > are all stale, after everyone has migrated to LTE or discontinued their
> > service altogether.
> >
> > NetworkManager appears to have dropped userspace support in 2015
> > https://bugzilla.gnome.org/show_bug.cgi?id=747846, the
> > www.linuxwimax.org
> > site had already shut down earlier.
> >
> > WiMax is apparently still being deployed on airport campus networks
> > ("AeroMACS"), but in a frequency band that was not supported by the old
> > Intel 2400m (used in Sandy Bridge laptops and earlier), which is the
> > only driver using the kernel's wimax stack.
> >
> > Move all files into drivers/staging/wimax, including the uapi header
> > files and documentation, to make it easier to remove it when it gets
> > to that. Only minimal changes are made to the source files, in order
> > to make it possible to port patches across the move.
> >
> > Also remove the MAINTAINERS entry that refers to a broken mailing
> > list and website.
> >
> > Suggested-by: Inaky Perez-Gonzalez
> > Signed-off-by: Arnd Bergmann
>
> Is this ok for me to take through the staging tree? If so, I need an
> ack from the networking maintainers.
>
> If not, feel free to send it through the networking tree and add:
>
> Acked-by: Greg Kroah-Hartman
Thinking about it now - we want this applied to -next, correct?
In that case it may be better if we take it. The code is pretty dead
but syzbot and the trivial fix crowd don't know it, so I may slip,
apply something and we'll have a conflict.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8723bs: Add 024c:0627 to the list of SDIO device-ids
Hi,
On 10/29/20 2:52 PM, Brian O'Keefe wrote:
> Add 024c:0627 to the list of SDIO device-ids, based on hardware found in
> the wild. This hardware exists on at least some Acer SW1-011 tablets.
>
> Signed-off-by: Brian O'Keefe
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index 5b1392deb0a7..7256d55fcc1b 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -21,6 +21,7 @@ static const struct sdio_device_id sdio_ids[] =
> { SDIO_DEVICE(0x024c, 0x0525), },
> { SDIO_DEVICE(0x024c, 0x0623), },
> { SDIO_DEVICE(0x024c, 0x0626), },
> + { SDIO_DEVICE(0x024c, 0x0627), },
> { SDIO_DEVICE(0x024c, 0xb723), },
> { /* end: all zeroes */ },
> };
> --
> 2.25.1
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [RFC] wimax: move out to staging
n Thu, Oct 29, 2020 at 4:56 PM Jakub Kicinski wrote: > On Wed, 28 Oct 2020 06:56:28 +0100 Greg Kroah-Hartman wrote: > > On Tue, Oct 27, 2020 at 10:20:13PM +0100, Arnd Bergmann wrote: > > > > Is this ok for me to take through the staging tree? If so, I need an > > ack from the networking maintainers. > > > > If not, feel free to send it through the networking tree and add: > > > > Acked-by: Greg Kroah-Hartman > > Thinking about it now - we want this applied to -next, correct? > In that case it may be better if we take it. The code is pretty dead > but syzbot and the trivial fix crowd don't know it, so I may slip, > apply something and we'll have a conflict. I think git will deal with a merge between branches containing the move vs fix, so it should work either way. A downside of having the move in net-next would be that you'd get trivial fixes send to Greg, but him being unable to apply them to his tree because the code is elsewhere. If you think it helps, I could prepare a pull request with this one patch (and probably the bugfix I sent first that triggered it), and then you can both merge the branch into net-next as well as staging-next. Arnd ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [RFC] wimax: move out to staging
On Thu, 29 Oct 2020 17:26:09 +0100 Arnd Bergmann wrote: > n Thu, Oct 29, 2020 at 4:56 PM Jakub Kicinski wrote: > > On Wed, 28 Oct 2020 06:56:28 +0100 Greg Kroah-Hartman wrote: > > > On Tue, Oct 27, 2020 at 10:20:13PM +0100, Arnd Bergmann wrote: > > > > > > Is this ok for me to take through the staging tree? If so, I need an > > > ack from the networking maintainers. > > > > > > If not, feel free to send it through the networking tree and add: > > > > > > Acked-by: Greg Kroah-Hartman > > > > Thinking about it now - we want this applied to -next, correct? > > In that case it may be better if we take it. The code is pretty dead > > but syzbot and the trivial fix crowd don't know it, so I may slip, > > apply something and we'll have a conflict. > > I think git will deal with a merge between branches containing > the move vs fix, so it should work either way. > > A downside of having the move in net-next would be that > you'd get trivial fixes send to Greg, but him being unable to > apply them to his tree because the code is elsewhere. > > If you think it helps, I could prepare a pull request with this one > patch (and probably the bugfix I sent first that triggered it), and > then you can both merge the branch into net-next as well > as staging-next. If you wouldn't mind branch sounds like the best solution. Acked-by: Jakub Kicinski ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8723bs: Add 024c:0627 to the list of SDIO device-ids
Add 024c:0627 to the list of SDIO device-ids, based on hardware found in
the wild. This hardware exists on at least some Acer SW1-011 tablets.
Signed-off-by: Brian O'Keefe
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index 5b1392deb0a7..7256d55fcc1b 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -21,6 +21,7 @@ static const struct sdio_device_id sdio_ids[] =
{ SDIO_DEVICE(0x024c, 0x0525), },
{ SDIO_DEVICE(0x024c, 0x0623), },
{ SDIO_DEVICE(0x024c, 0x0626), },
+ { SDIO_DEVICE(0x024c, 0x0627), },
{ SDIO_DEVICE(0x024c, 0xb723), },
{ /* end: all zeroes */ },
};
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v6 5/9] media: staging: rkisp1: remove unecessary clocks
On Tue, Oct 20, 2020 at 2:39 PM Helen Koike wrote: > > aclk_isp_wrap is a child of aclk_isp, and hclk_isp_wrap is a child of > hclk_isp, thus we can remove parents from the list. > > Also, for the isp0, we only need the ISP clock, ACLK and HCLK. > In the future we'll need a pixel clock for RK3288 and RK3399, and a JPEG > clock for RK3288. > > So with the goal to cleanup the dt-bindings and remove it from staging, > simplify clock names to isp, aclk and hclk. > > Assigned clocks are meant to refer to the full path in the clock tree, > i.e. the leaf in the tree. > For instance, in RK3399, the clock responsible for ACLK (ISP AXI CLOCK) > is aclk_isp0_wrapper. > > For reference, this is the isp clock topology on RK3399: > > xin24m > pll_npll >npll > clk_isp1 > clk_isp0 > pll_cpll >cpll > aclk_isp1 > aclk_isp1_noc > hclk_isp1 > aclk_isp1_wrapper > hclk_isp1_noc > aclk_isp0 > hclk_isp1_wrapper > aclk_isp0_wrapper > aclk_isp0_noc > hclk_isp0 > hclk_isp0_wrapper > hclk_isp0_noc > pclkin_isp1_wrapper > > Signed-off-by: Helen Koike > Reviewed-by: Tomasz Figa > > --- > > Changes in V6: > - Define clocks in the top level, and use if/else schema to define how > many for each compatible as sugested by Rob Herring on > > https://patchwork.linuxtv.org/project/linux-media/patch/20200722155533.252844-6-helen.ko...@collabora.com/#122626 > --- > .../bindings/media/rockchip-isp1.yaml | 44 +-- > drivers/staging/media/rkisp1/rkisp1-dev.c | 8 ++-- > 2 files changed, 33 insertions(+), 19 deletions(-) Reviewed-by: Rob Herring ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[GIT PULL, staging, net-next] wimax: move to staging
The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec:
Linux 5.10-rc1 (2020-10-25 15:14:11 -0700)
are available in the Git repository at:
git://git.kernel.org:/pub/scm/linux/kernel/git/arnd/playground.git
tags/wimax-staging
for you to fetch changes up to f54ec58fee837ec847cb8b50593e81bfaa46107f:
wimax: move out to staging (2020-10-29 19:27:45 +0100)
wimax: move to staging
After I sent a fix for what appeared to be a harmless warning in
the wimax user interface code, the conclusion was that the whole
thing has most likely not been used in a very long time, and the
user interface possibly been broken since b61a5eea5904 ("wimax: use
genl_register_family_with_ops()").
Using a shared branch between net-next and staging should help
coordinate patches getting submitted against it.
Arnd Bergmann (2):
wimax: fix duplicate initializer warning
wimax: move out to staging
Documentation/admin-guide/index.rst| 1 -
Documentation/networking/kapi.rst | 21
.../translations/zh_CN/admin-guide/index.rst | 1 -
MAINTAINERS| 22
drivers/net/Kconfig| 2 --
drivers/net/Makefile | 1 -
drivers/net/wimax/Kconfig | 18 --
drivers/net/wimax/Makefile | 2 --
drivers/staging/Kconfig| 2 ++
drivers/staging/Makefile | 1 +
.../staging/wimax/Documentation}/i2400m.rst| 0
.../staging/wimax/Documentation}/index.rst | 0
.../staging/wimax/Documentation}/wimax.rst | 0
{net => drivers/staging}/wimax/Kconfig | 6 +
{net => drivers/staging}/wimax/Makefile| 2 ++
drivers/staging/wimax/TODO | 18 ++
{net => drivers/staging}/wimax/debug-levels.h | 2 +-
{net => drivers/staging}/wimax/debugfs.c | 2 +-
drivers/{net => staging}/wimax/i2400m/Kconfig | 0
drivers/{net => staging}/wimax/i2400m/Makefile | 0
drivers/{net => staging}/wimax/i2400m/control.c| 2 +-
.../{net => staging}/wimax/i2400m/debug-levels.h | 2 +-
drivers/{net => staging}/wimax/i2400m/debugfs.c| 0
drivers/{net => staging}/wimax/i2400m/driver.c | 2 +-
drivers/{net => staging}/wimax/i2400m/fw.c | 0
drivers/{net => staging}/wimax/i2400m/i2400m-usb.h | 0
drivers/{net => staging}/wimax/i2400m/i2400m.h | 4 +--
.../staging/wimax/i2400m/linux-wimax-i2400m.h | 0
drivers/{net => staging}/wimax/i2400m/netdev.c | 0
drivers/{net => staging}/wimax/i2400m/op-rfkill.c | 2 +-
drivers/{net => staging}/wimax/i2400m/rx.c | 0
drivers/{net => staging}/wimax/i2400m/sysfs.c | 0
drivers/{net => staging}/wimax/i2400m/tx.c | 0
.../wimax/i2400m/usb-debug-levels.h| 2 +-
drivers/{net => staging}/wimax/i2400m/usb-fw.c | 0
drivers/{net => staging}/wimax/i2400m/usb-notif.c | 0
drivers/{net => staging}/wimax/i2400m/usb-rx.c | 0
drivers/{net => staging}/wimax/i2400m/usb-tx.c | 0
drivers/{net => staging}/wimax/i2400m/usb.c| 2 +-
{net => drivers/staging}/wimax/id-table.c | 2 +-
.../staging/wimax/linux-wimax-debug.h | 2 +-
.../wimax.h => drivers/staging/wimax/linux-wimax.h | 0
.../wimax.h => drivers/staging/wimax/net-wimax.h | 2 +-
{net => drivers/staging}/wimax/op-msg.c| 2 +-
{net => drivers/staging}/wimax/op-reset.c | 4 +--
{net => drivers/staging}/wimax/op-rfkill.c | 4 +--
{net => drivers/staging}/wimax/op-state-get.c | 4 +--
{net => drivers/staging}/wimax/stack.c | 29 ++
{net => drivers/staging}/wimax/wimax-internal.h| 2 +-
net/Kconfig| 2 --
net/Makefile | 1 -
51 files changed, 68 insertions(+), 103 deletions(-)
delete mode 100644 drivers/net/wimax/Kconfig
delete mode 100644 drivers/net/wimax/Makefile
rename {Documentation/admin-guide/wimax =>
drivers/staging/wimax/Documentation}/i2400m.rst (100%)
rename {Documentation/admin-guide/wimax =>
drivers/staging/wimax/Documentation}/index.rst (100%)
rename {Documentation/admin-guide/wimax =>
drivers/staging/wimax/Documentation}/wimax.rst (100%)
rename {net => drivers/staging}/wimax/Kconfig (94%)
rename {net => drivers/staging}/wimax/Makefile (83%)
create mode 100644 drivers/staging/wimax/TODO
rename {net => drivers/staging}/wimax/debug-levels.h (96%)
rename {net => drivers/staging}/wimax/debugfs.c (97%)
rename drivers/{net => staging}/wimax/i2400m/Kconfig (100%)
rename drivers/{net => staging}/wimax/i2400m/Makefile (100%)
rename drivers/{net => staging}/
[driver-core:debugfs_cleanup] BUILD SUCCESS eb27f3832891c8db753d3acb3a2a02d9930ef911
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup branch HEAD: eb27f3832891c8db753d3acb3a2a02d9930ef911 debugfs: remove return value of debugfs_create_devm_seqfile() elapsed time: 780m configs tested: 102 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig powerpc mpc5200_defconfig powerpc maple_defconfig c6xevmc6678_defconfig powerpc arches_defconfig shapsh4ad0a_defconfig mips rb532_defconfig arm hackkit_defconfig arm gemini_defconfig powerpc mpc8313_rdb_defconfig sparc sparc64_defconfig shdreamcast_defconfig shedosk7705_defconfig powerpc mpc885_ads_defconfig sh rsk7264_defconfig sh sh03_defconfig arm prima2_defconfig mips capcella_defconfig c6x alldefconfig mipsmalta_kvm_guest_defconfig sh sdk7780_defconfig arm zx_defconfig ia64 tiger_defconfig mips rbtx49xx_defconfig arm ebsa110_defconfig ia64generic_defconfig arm assabet_defconfig arm simpad_defconfig arm jornada720_defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig c6x allyesconfig nds32 defconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a001-20201029 x86_64 randconfig-a002-20201029 x86_64 randconfig-a003-20201029 x86_64 randconfig-a006-20201029 x86_64 randconfig-a005-20201029 x86_64 randconfig-a004-20201029 i386 randconfig-a002-20201029 i386 randconfig-a005-20201029 i386 randconfig-a003-20201029 i386 randconfig-a001-20201029 i386 randconfig-a004-20201029 i386 randconfig-a006-20201029 i386 randconfig-a016-20201029 i386 randconfig-a014-20201029 i386 randconfig-a015-20201029 i386 randconfig-a013-20201029 i386 randconfig-a012-20201029 i386 randconfig-a011-20201029 riscvnommu_k210_defconfig riscvallyesconfig riscvnommu_virt_defconfig riscv allnoconfig riscv defconfig riscv rv32_defconfig riscvallmodconfig x86_64 rhel x86_64 allyesconfig x86_64rhel-7.6-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 kexec clang tested configs: x86_64 randconfig-a011-20201029 x86_64 randconfig-a013-20201029 x86_64 randconfig-a016-20201029 x86_64
