Re: [Dspace-tech] Browse authority controlled author names by text value, not by authority key

2014-04-28 Thread SUZUKI Keiji
Hi Daniel,


2014-04-25 23:55 GMT+09:00 Daniel Scharon daniel.scha...@uni-konstanz.de:
 This value is set in org.dspace.browse.SolrBrowseCreateDAO.additionaIndex()
 using the value returned by getLabel() method of your class implementing
 ChoiceAuthority interface.

 Maybe your class return the value of second parameter key as-is in the same
 manner as LCNameAuthority.

 Yes, this is the case.

If an authority key has more than one form of the name, this is a common case
in Japanese author, I recommend customizing your getLabel() function.

 Another way is editing SolrBrowseCreateDAO class itself. Replace the
 following lines

 https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/browse/SolrBrowseCreateDAO.java#L217-227

 to

 if (!ignorePrefered)
 {
 preferedLabel = values[x].value;
 }

 But in this case, when more than one name has the same authority code,
 each name is counted and displayed separately. So I do not recommend.

This is my mistake. I assumed you didn't set any properties for discovery
function.

 SolrBrowseCreateDAO seems to check (lines 205-16) whether
 browse.authority.ignore-prefered is set within
 config/modules/discovery.cfg in a similar manner as SolrServiceImpl
 checks (lines 975-985) whether index.authority.ignore-prefered is set to
 true.
 The option for Discovery is documented here:
 https://wiki.duraspace.org/display/DSDOC4x/Discovery#Discovery-GeneralDiscoverysettings%28config/modules/discovery.cfg%29
 whereas I can't find any documentation for the browse option
 browse.authority.ignore-prefered

 Setting index.authority.ignore-prefered for example like this
 index.authority.ignore-prefered.dc.contributor.author=true
 works flawlessly and the discovery sidebar lists the text values and not
 the authority keys. But setting browse.authority.ignore-prefered doesn't
 seem to have any effect, neither globally like
 browse.authority.ignore-prefered=true
 nor specifically like
 browse.authority.ignore-prefered.author=true

 Note: We always use this option in combination with
 authority.ignore-variants

 Is there any possibility we can take advantage of that option?
 The demosite (demo.dspace.org) seems to use choice authority for authors
 but still succeeds to display the text values and not the authority keys
 for browsing. Does anybody know how this is solved there?

I have read the code more seriously and found some doubtful points.
I think there are bugs and you can't get expected results with setting
properties only.

Please refer to the code diff at the following url,
https://gist.github.com/zuki/11365437

Regards,
Keiji Suzuki

--
Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free.
http://p.sf.net/sfu/SauceLabs
___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech
List Etiquette: https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette


Re: [Dspace-tech] Browse authority controlled author names by text value, not by authority key

2014-04-17 Thread SUZUKI Keiji
Hi Daniel,

This value is set in org.dspace.browse.SolrBrowseCreateDAO.additionaIndex()
using the value returned by getLabel() method of your class implementing
ChoiceAuthority interface.

Maybe your class return the value of second parameter key as-is in the same
manner as LCNameAuthority. You have to edit your code to return author name.

Another way is editing SolrBrowseCreateDAO class itself. Replace the
following lines

https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/browse/SolrBrowseCreateDAO.java#L217-227

to

if (!ignorePrefered)
{
preferedLabel = values[x].value;
}

But in this case, when more than one name has the same authority code,
each name is counted and displayed separately. So I do not recommend.

Regards,
Keiji Suzuki








2014-04-16 23:30 GMT+09:00 Daniel Scharon daniel.scha...@uni-konstanz.de:
 Hello all,

 we have successfully implemented authority control for author names.
 But now it seems, that the authors' names listed for browsing/discovery
 are being retrieved (and indexed) from the authority key instead of the
 metadata text value.

 For our users this would mean that they would see author names with
 absolutely no meanings to them (like abc1234).

 So I tried to set the author index to be retrieved by the text value:
 webui.browse.index.2 =
 author:metadataAuthority:dc.contributor.author:text

 But this doesn't show any effect; even after a complete reindexing the
 author names are still listed with their authority values.

 Any hints on how to solve this?

 Kind regards,
 Daniel


 --
 Daniel Scharon
 KIM, Room B 705
 University of Konstanz
 78457 Konstanz, Germany

 Tel: +49 7531 88-2951
 XMPP/E-Mail: daniel.scha...@uni-konstanz.de
 Web: http://www.kim.uni-konstanz.de

 --
 Daniel Scharon
 KIM, Room B 705
 University of Konstanz
 78457 Konstanz, Germany

 Tel: +49 7531 88-2951
 XMPP/E-Mail: daniel.scha...@uni-konstanz.de
 Web: http://www.kim.uni-konstanz.de

 --
 Learn Graph Databases - Download FREE O'Reilly Book
 Graph Databases is the definitive new guide to graph databases and their
 applications. Written by three acclaimed leaders in the field,
 this first edition is now available. Download your free book today!
 http://p.sf.net/sfu/NeoTech
 ___
 DSpace-tech mailing list
 DSpace-tech@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/dspace-tech
 List Etiquette: 
 https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette



-- 
鈴木敬二@江別市

--
Learn Graph Databases - Download FREE O'Reilly Book
Graph Databases is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech
List Etiquette: https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette