[DuMuX] Flyspray Activity for Task 180 (Inconsistent naming - special status of saturation)
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#180 - Inconsistent naming - special status of saturation User who did this - Bernd Flemisch (bernd) -- Ok, most changes resulting from our rules that we decided today are in review. I would leave the issue of class names for the next release cycle. If we stick to our rules, this will also be a lot: everything containing FV or MPFA like FVPressure, BoxFVElementGeometry, FVMPFAOInteractionVolume and so on. And also everything containing 2P/2C/NI like TwoPNIModel, CellData2P and so on. One group is left: chemical component names like CO2, H2O, N2 and so on. This would become, for example, co2Idx or fugacityCoefficientCo2. Should we stick to our rules or make an exception? I tend to \stick.\ -- More information can be found at the following URL: http://www.dumux.org/flyspray/index.php?do=detailstask_id=180#comment350 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. ___ Dumux mailing list Dumux@listserv.uni-stuttgart.de https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
[DuMuX] Flyspray Activity for Task 180 (Inconsistent naming - special status of saturation)
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#180 - Inconsistent naming - special status of saturation User who did this - Bernd Flemisch (bernd) -- I did everything from the list above that seemed clear to me. For the possibly questionable cases, let me first try to rephrase two options for our criterion: Option 1 (words): \We use camelCase with a uncapitalized first letter for the naming of class members. If a part of the name consists of a word and succeeding words that would be sub- or superscripted in \'normal\' writing, these succeeding words are not capitalized.\ Option 2 (characters): \We use camelCase with a uncapitalized first letter for the naming of class members. If a part of the name consists of a character and succeeding characters that would be sub- or superscripted in \'normal\' writing (and do not form a meaningful word themselves), these succeeding characters are not capitalized.\ Unfortunately, both options are still not really clear. For example, what should we do about greek letters like \\tau_\\alpha? It will be hard to come up with a clear rule that is not too complicated. Anyway, if we go with option 1, more changes are still to be made: contiWEqIdx - contiwEqIdx contiNEqIdx - continEqIdx pressNW - pressnw pressW - pressw pressureW - pressurew pressureNW - pressurenw saturationNW - saturationnw saturationW - saturationw velocityNW - velocitynw velocityW - velocityw pGlobalIdx - pglobalIdx pGlobalSn - pglobalSn pGlobalSw - pglobalSw pressureGlobal - pressureglobal velocityTotal - velocitytotal And there are still: dkrw_dSw - dkrw_dsw dkrn_dSw - dkrn_dsw dpC_dSw - dpc_dsw dSw_dpC - dsw_dpc -- More information can be found at the following URL: http://www.dumux.org/flyspray/index.php?do=detailstask_id=180#comment342 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. ___ Dumux mailing list Dumux@listserv.uni-stuttgart.de https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
[DuMuX] Flyspray Activity for Task 180 (Inconsistent naming - special status of saturation)
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#180 - Inconsistent naming - special status of saturation User who did this - Christoph Grüninger (gruenich) -- I\'d like to have a rule that ensures that inner words or abbreviations have always an uppercase letter, i. e. pEq, pGlobal or Greek letters like pTau. -- More information can be found at the following URL: http://www.dumux.org/flyspray/index.php?do=detailstask_id=180#comment344 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. ___ Dumux mailing list Dumux@listserv.uni-stuttgart.de https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
[DuMuX] Flyspray Activity for Task 180 (Inconsistent naming - special status of saturation)
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#180 - Inconsistent naming - special status of saturation User who did this - Bernd Flemisch (bernd) -- That rule is camelCase, right? The point is that we would like to have an exception for sub/superscripts. -- More information can be found at the following URL: http://www.dumux.org/flyspray/index.php?do=detailstask_id=180#comment345 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. ___ Dumux mailing list Dumux@listserv.uni-stuttgart.de https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
[DuMuX] Flyspray Activity for Task 180 (Inconsistent naming - special status of saturation)
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#180 - Inconsistent naming - special status of saturation User who did this - Christoph Grüninger (gruenich) -- Ah ok, I did not get this. In that case I am against it. I can read pGlobalSw more easily compared to pglobalSw. Let alone pressureglobal which is pressu reg lobal *puzzled* -- More information can be found at the following URL: http://www.dumux.org/flyspray/index.php?do=detailstask_id=180#comment346 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. ___ Dumux mailing list Dumux@listserv.uni-stuttgart.de https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
[DuMuX] Flyspray Activity for Task 180 (Inconsistent naming - special status of saturation)
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#180 - Inconsistent naming - special status of saturation User who did this - Bernd Flemisch (bernd) -- Will joyfully be implemented within the next few weeks. -- More information can be found at the following URL: http://www.dumux.org/flyspray/index.php?do=detailstask_id=180#comment335 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. ___ Dumux mailing list Dumux@listserv.uni-stuttgart.de https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
[DuMuX] Flyspray Activity for Task 180 (Inconsistent naming - special status of saturation)
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#180 - Inconsistent naming - special status of saturation User who did this - Bernd Flemisch (bernd) -- We agreed upon the following proposal: The \S\ will become an \s\. If letters in question refer to an Index (like the \n\ in \sn\ or the \rw\ in \krw\ or the \sat\ in \psat\, the first letter will not be capitalized. We need to check whether this leads to consistency; it will definitely improve the situation. The proposals should be included in naming_conventions.ods until 12.4. -- More information can be found at the following URL: http://www.dumux.org/flyspray/index.php?do=detailstask_id=180#comment327 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. ___ Dumux mailing list Dumux@listserv.uni-stuttgart.de https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
