[edk2] [PATCH 0/2] DynamicTablesPkg Updates
DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX This patch adds appropriate dependencies to DynamicTableManagerDxe. The initialization function fails if gEdkiiDynamicTableFactoryProtocolGuid and gEdkiiConfigurationManagerProtocolGuid are not present already. Since we are not relying on a callback but locating these in initialization, we should add these dependencies. Towards the end of initialization function where we build and install ACPI tables, we locate gEfiAcpiTableProtocolGuid and return a failure is not present. We need to add approriate dependency for this as well. Adding these proper dependencies would make the code not rely on drivers forcefully dispatched in a particular order DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART. This patch adds support for 16550 UART in ACPI SPCR table. HLOS support for this type of UART is already present. Both the patches have been verified to work on hardware. Ashish Singhal (2): DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART. .../Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 4 +++- DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) -- 2.7.4 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/2] DynamicTablesPkg Updates
Reviewed-by: Sami Mujawar -Original Message- From: Ashish Singhal Sent: 21 February 2019 06:39 PM To: edk2-devel@lists.01.org Cc: Sami Mujawar ; Alexei Fedorov ; Ashish Singhal Subject: [PATCH 0/2] DynamicTablesPkg Updates DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX This patch adds appropriate dependencies to DynamicTableManagerDxe. The initialization function fails if gEdkiiDynamicTableFactoryProtocolGuid and gEdkiiConfigurationManagerProtocolGuid are not present already. Since we are not relying on a callback but locating these in initialization, we should add these dependencies. Towards the end of initialization function where we build and install ACPI tables, we locate gEfiAcpiTableProtocolGuid and return a failure is not present. We need to add approriate dependency for this as well. Adding these proper dependencies would make the code not rely on drivers forcefully dispatched in a particular order DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART. This patch adds support for 16550 UART in ACPI SPCR table. HLOS support for this type of UART is already present. Both the patches have been verified to work on hardware. Ashish Singhal (2): DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART. .../Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 4 +++- DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) -- 2.7.4 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/2] DynamicTablesPkg Updates
Reviewed-by: Alexei Fedorov Alexei From: Sami Mujawar Sent: 25 February 2019 13:38:17 To: Ashish Singhal; edk2-devel@lists.01.org Cc: Alexei Fedorov; nd Subject: RE: [PATCH 0/2] DynamicTablesPkg Updates Reviewed-by: Sami Mujawar -Original Message- From: Ashish Singhal Sent: 21 February 2019 06:39 PM To: edk2-devel@lists.01.org Cc: Sami Mujawar ; Alexei Fedorov ; Ashish Singhal Subject: [PATCH 0/2] DynamicTablesPkg Updates DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX This patch adds appropriate dependencies to DynamicTableManagerDxe. The initialization function fails if gEdkiiDynamicTableFactoryProtocolGuid and gEdkiiConfigurationManagerProtocolGuid are not present already. Since we are not relying on a callback but locating these in initialization, we should add these dependencies. Towards the end of initialization function where we build and install ACPI tables, we locate gEfiAcpiTableProtocolGuid and return a failure is not present. We need to add approriate dependency for this as well. Adding these proper dependencies would make the code not rely on drivers forcefully dispatched in a particular order DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART. This patch adds support for 16550 UART in ACPI SPCR table. HLOS support for this type of UART is already present. Both the patches have been verified to work on hardware. Ashish Singhal (2): DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART. .../Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 4 +++- DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) -- 2.7.4 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/2] DynamicTablesPkg Updates
On 02/21/19 19:38, Ashish Singhal wrote:
> DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX
>
> This patch adds appropriate dependencies to DynamicTableManagerDxe.
> The initialization function fails if gEdkiiDynamicTableFactoryProtocolGuid
> and gEdkiiConfigurationManagerProtocolGuid are not present already. Since
> we are not relying on a callback but locating these in initialization, we
> should add these dependencies. Towards the end of initialization function
> where we build and install ACPI tables, we locate gEfiAcpiTableProtocolGuid
> and return a failure is not present. We need to add approriate dependency
> for this as well. Adding these proper dependencies would make the code not
> rely on drivers forcefully dispatched in a particular order
>
> DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.
>
> This patch adds support for 16550 UART in ACPI SPCR table. HLOS support for
> this type of UART is already present.
>
> Both the patches have been verified to work on hardware.
>
> Ashish Singhal (2):
> DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX
> DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.
>
> .../Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 4
> +++-
> DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 2 ++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
I think the first patch in this series could be considered a bugfix, but
the second one can't. Therefore minimally commit 0692ef87594f
("DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.", 2019-02-25)
should be reverted.
Please see the explanation at
.
The patches were posted on the 21st, but only reviewed today (on the 25th).
Thanks
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
