Re: [edk2] [PATCH 01/15] ArmPlatformPkg/ArmPlatformLibNull: remove bogus PCD dependencies

2017-11-17 Thread Ard Biesheuvel 
On 17 November 2017 at 16:28, Leif Lindholm  wrote:
> On Fri, Nov 17, 2017 at 04:23:04PM +, Ard Biesheuvel wrote:
>> On 17 November 2017 at 16:20, Leif Lindholm  wrote:
>> > On Fri, Nov 17, 2017 at 04:08:59PM +, Ard Biesheuvel wrote:
>> >> Remove dependencies on gArmTokenSpaceGuid.PcdSystemMemoryBase and
>> >> gArmTokenSpaceGuid.PcdSystemMemorySize, the presence of which in
>> >> a [FixedPcd] section makes this module unusable for ArmVirtQemu.
>> >>
>> >> Contributed-under: TianoCore Contribution Agreement 1.1
>> >> Signed-off-by: Ard Biesheuvel 
>> >
>> > Question: shouldn't specifically ArmVirtQemu work fine with these,
>> > since it defines them as PcdsFixedAtBuild?
>> > Whereas both ArmVirtQemuKernel and ArmVirtXen define them as
>> > patchable.
>>
>> PcdSystemMemorySize is dynamic in ArmVirtQemu, and is the only
>> platform that will include this library after this series. The others
>> have their own PrePi implementation, allowing me to drop any
>> dependencies on ArmPlatformLib altogether.
>
> Right.
>
> Of course I only looked at *Base for ArmVirtQemu.
> Never mind.
>
> Reviewed-by: Leif Lindholm 
>

Pushed as b2662641d56a
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 01/15] ArmPlatformPkg/ArmPlatformLibNull: remove bogus PCD dependencies

2017-11-17 Thread Leif Lindholm 
On Fri, Nov 17, 2017 at 04:23:04PM +, Ard Biesheuvel wrote:
> On 17 November 2017 at 16:20, Leif Lindholm  wrote:
> > On Fri, Nov 17, 2017 at 04:08:59PM +, Ard Biesheuvel wrote:
> >> Remove dependencies on gArmTokenSpaceGuid.PcdSystemMemoryBase and
> >> gArmTokenSpaceGuid.PcdSystemMemorySize, the presence of which in
> >> a [FixedPcd] section makes this module unusable for ArmVirtQemu.
> >>
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Signed-off-by: Ard Biesheuvel 
> >
> > Question: shouldn't specifically ArmVirtQemu work fine with these,
> > since it defines them as PcdsFixedAtBuild?
> > Whereas both ArmVirtQemuKernel and ArmVirtXen define them as
> > patchable.
> 
> PcdSystemMemorySize is dynamic in ArmVirtQemu, and is the only
> platform that will include this library after this series. The others
> have their own PrePi implementation, allowing me to drop any
> dependencies on ArmPlatformLib altogether.

Right.

Of course I only looked at *Base for ArmVirtQemu.
Never mind.

Reviewed-by: Leif Lindholm 

/
Leif
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 01/15] ArmPlatformPkg/ArmPlatformLibNull: remove bogus PCD dependencies

2017-11-17 Thread Ard Biesheuvel 
On 17 November 2017 at 16:20, Leif Lindholm  wrote:
> On Fri, Nov 17, 2017 at 04:08:59PM +, Ard Biesheuvel wrote:
>> Remove dependencies on gArmTokenSpaceGuid.PcdSystemMemoryBase and
>> gArmTokenSpaceGuid.PcdSystemMemorySize, the presence of which in
>> a [FixedPcd] section makes this module unusable for ArmVirtQemu.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel 
>
> Question: shouldn't specifically ArmVirtQemu work fine with these,
> since it defines them as PcdsFixedAtBuild?
> Whereas both ArmVirtQemuKernel and ArmVirtXen define them as
> patchable.
>

PcdSystemMemorySize is dynamic in ArmVirtQemu, and is the only
platform that will include this library after this series. The others
have their own PrePi implementation, allowing me to drop any
dependencies on ArmPlatformLib altogether.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 01/15] ArmPlatformPkg/ArmPlatformLibNull: remove bogus PCD dependencies

2017-11-17 Thread Leif Lindholm 
On Fri, Nov 17, 2017 at 04:08:59PM +, Ard Biesheuvel wrote:
> Remove dependencies on gArmTokenSpaceGuid.PcdSystemMemoryBase and
> gArmTokenSpaceGuid.PcdSystemMemorySize, the presence of which in
> a [FixedPcd] section makes this module unusable for ArmVirtQemu.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel 

Question: shouldn't specifically ArmVirtQemu work fine with these,
since it defines them as PcdsFixedAtBuild?
Whereas both ArmVirtQemuKernel and ArmVirtXen define them as
patchable.

/
Leif

> ---
>  ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf 
> b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
> index 97b2a4b6e495..e59aef611a3c 100644
> --- a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
> +++ b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
> @@ -41,9 +41,6 @@ [Sources.AArch64]
>AArch64/ArmPlatformHelper.S
>  
>  [FixedPcd]
> -  gArmTokenSpaceGuid.PcdSystemMemoryBase
> -  gArmTokenSpaceGuid.PcdSystemMemorySize
> -
>gArmTokenSpaceGuid.PcdArmPrimaryCoreMask
>gArmTokenSpaceGuid.PcdArmPrimaryCore
>  
> -- 
> 2.11.0
> 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 01/15] ArmPlatformPkg/ArmPlatformLibNull: remove bogus PCD dependencies

2017-11-17 Thread Ard Biesheuvel 
Remove dependencies on gArmTokenSpaceGuid.PcdSystemMemoryBase and
gArmTokenSpaceGuid.PcdSystemMemorySize, the presence of which in
a [FixedPcd] section makes this module unusable for ArmVirtQemu.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel 
---
 ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf 
b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
index 97b2a4b6e495..e59aef611a3c 100644
--- a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
+++ b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
@@ -41,9 +41,6 @@ [Sources.AArch64]
   AArch64/ArmPlatformHelper.S
 
 [FixedPcd]
-  gArmTokenSpaceGuid.PcdSystemMemoryBase
-  gArmTokenSpaceGuid.PcdSystemMemorySize
-
   gArmTokenSpaceGuid.PcdArmPrimaryCoreMask
   gArmTokenSpaceGuid.PcdArmPrimaryCore
 
-- 
2.11.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel