Re: [edk2] [PATCH edk2-platforms v1 00/38] Upload for D06 platform

2018-08-04 Thread Ming 


在 8/2/2018 6:12 PM, Leif Lindholm 写道:
> On Thu, Aug 02, 2018 at 09:46:13AM +0800, Ming wrote:
>> I am sorry for the first issue, the modify FIRMWARE_VER patch is add
>> alone just befor send out the patchset.
>>
>> For generating acpi table, I use acpica-tools 20180508 version and it works.
>> I think acpica-tools are not backward compatibility and confused about 
>> acpica-tools.
> 
> Yes, it's a real pain. We used to have lots of issues with this, but
> the last couple of years have been less bad.
> Some platforms moved from .asl to .aslc to get around this.
> 
> I can confirm using 20180508 version resolves this issue.
> And that 20180629 does not work :(
> Unfortunately that won't currently work with our AMD overdrive
> platforms. But we'll have to live with that for now.
> 
> However, I notice the D02 build is now broken, due to the removal of
> Silicon/Hisilicon/Drivers/PciHostBridgeDxe. I guess this is not a huge
> issue, and maybe it is time to retire that platform anyway.
> If so, could you create a set removing D02 and the bits only used by
> it?
> 
> /
> Leif
> 

Yes, D02 is not need to maintain now. I will send the removing patch set later.

Ming


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-platforms v1 00/38] Upload for D06 platform

2018-08-02 Thread Graeme Gregory 
On Thu, Aug 02, 2018 at 11:12:56AM +0100, Leif Lindholm wrote:
> On Thu, Aug 02, 2018 at 09:46:13AM +0800, Ming wrote:
> > I am sorry for the first issue, the modify FIRMWARE_VER patch is add
> > alone just befor send out the patchset.
> > 
> > For generating acpi table, I use acpica-tools 20180508 version and it works.
> > I think acpica-tools are not backward compatibility and confused about 
> > acpica-tools.
> 
> Yes, it's a real pain. We used to have lots of issues with this, but
> the last couple of years have been less bad.
> Some platforms moved from .asl to .aslc to get around this.
> 
> I can confirm using 20180508 version resolves this issue.
> And that 20180629 does not work :(
> Unfortunately that won't currently work with our AMD overdrive
> platforms. But we'll have to live with that for now.
> 
This sounds like a bug in IORT support in acpica tools as it works for
other tables.

Graeme

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-platforms v1 00/38] Upload for D06 platform

2018-08-02 Thread Leif Lindholm 
On Thu, Aug 02, 2018 at 09:46:13AM +0800, Ming wrote:
> I am sorry for the first issue, the modify FIRMWARE_VER patch is add
> alone just befor send out the patchset.
> 
> For generating acpi table, I use acpica-tools 20180508 version and it works.
> I think acpica-tools are not backward compatibility and confused about 
> acpica-tools.

Yes, it's a real pain. We used to have lots of issues with this, but
the last couple of years have been less bad.
Some platforms moved from .asl to .aslc to get around this.

I can confirm using 20180508 version resolves this issue.
And that 20180629 does not work :(
Unfortunately that won't currently work with our AMD overdrive
platforms. But we'll have to live with that for now.

However, I notice the D02 build is now broken, due to the removal of
Silicon/Hisilicon/Drivers/PciHostBridgeDxe. I guess this is not a huge
issue, and maybe it is time to retire that platform anyway.
If so, could you create a set removing D02 and the bits only used by
it?

/
Leif
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-platforms v1 00/38] Upload for D06 platform

2018-08-01 Thread Ming 


在 8/2/2018 5:56 AM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:08:44PM +0800, Ming Huang wrote:
>> The major features of this patchset include:
>> 1 D06 source code;
>> 2 Unify some D0x modules;
>>
>> This patch set is base on pcihostbridage-v2.
>> For compiling D06, add below hunk to edk2-platforms.config
>> [d06]
>> LONGNAME=HiSilicon D06
>> DSC=Platform/Hisilicon/D06/D06.dsc
>> ARCH=AARCH64
> 
> Very helpful, thank you.
> 
>>
>> Code can also be found in github: 
>> https://github.com/hisilicon/OpenPlatformPkg.git
>> branch: d06-platform-v1
> 
> Now, I started by trying to compile this, but I run into two issues.
> 
> First, the platform fails to build without FIRMWARE_VER specified on
> the command line, since there is an extra '"' in the definition of
> PcdFirmwareVersionString.
> 
> Then there is a build fault when generating ACPI tables. I tried to
> update to a newer version of acpica-tools, but I still get:
> ---
> "aarch64-linux-gnu-gcc" -x c -E -include AutoGen.h
> -I/work/git/edk2-platforms/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt
> -I/work/git/edk2-platforms/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables
> -I/work/git/tianocore/Build/D06/DEBUG_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/DEBUG
> -I/work/git/edk2/ArmPkg -I/work/git/edk2/ArmPkg/Include
> -I/work/git/edk2/ArmPlatformPkg
> -I/work/git/edk2/ArmPlatformPkg/Include -I/work/git/edk2/EmbeddedPkg
> -I/work/git/edk2/EmbeddedPkg/Include -I/work/git/edk2/MdeModulePkg
> -I/work/git/edk2/MdeModulePkg/Include -I/work/git/edk2/MdePkg
> -I/work/git/edk2/MdePkg/Include
> -I/work/git/edk2/MdePkg/Include/AArch64
> -I/work/git/edk2-platforms/Silicon/Hisilicon
> -I/work/git/edk2-platforms/Silicon/Hisilicon/Include
> -I/work/git/edk2-platforms/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables
> /work/git/tianocore/Build/D06/DEBUG_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort.i
>> /work/git/tianocore/Build/D06/DEBUG_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort.iii
> Trim --source-code -l -o
> /work/git/tianocore/Build/D06/DEBUG_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/work/git/tianocore/Build/D06/DEBUG_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort."aarch64-linux-gnu-gcc"
> -x c -E -include AutoGen.h
> -I/work/git/edk2-platforms/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt
> -I/work/git/edk2-platforms/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables
> -I/work/git/tianocore/Build/D06/RELEASE_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/DEBUG
> -I/work/git/edk2/ArmPkg -I/work/git/edk2/ArmPkg/Include
> -I/work/git/edk2/ArmPlatformPkg
> -I/work/git/edk2/ArmPlatformPkg/Include -I/work/git/edk2/EmbeddedPkg
> -I/work/git/edk2/EmbeddedPkg/Include -I/work/git/edk2/MdeModulePkg
> -I/work/git/edk2/MdeModulePkg/Include -I/work/git/edk2/MdePkg
> -I/work/git/edk2/MdePkg/Include
> -I/work/git/edk2/MdePkg/Include/AArch64
> -I/work/git/edk2-platforms/Silicon/Hisilicon
> -I/work/git/edk2-platforms/Silicon/Hisilicon/Include
> -I/work/git/edk2-platforms/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables
> /work/git/tianocore/Build/D06/RELEASE_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort.i
>> /work/git/tianocore/Build/D06/RELEASE_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort.iii
> Trim --source-code -l -o
> /work/git/tianocore/Build/D06/RELEASE_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi16Copyright
> (c) 2000 - 2018 Intel Corporation
> /work/git/tianocore/Build/D06/RELEASE_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort.
> 71: [0004] ID Count : 0100
> Error6303 -
> Integer too large for target ^  (0100 - max 1 bytes)
> 
> Table Input:
> /work/git/tianocore/Build/D06/RELEASE_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort.
> - 1991 lines, 59818 bytes, 68 fields
> 
> Compilation complete. 2 Errors, 0 Warnings, 0 Remarks
> ---
> 
> Any ideas what may be causing this?
> 
> /
> Leif
> 

I am sorry for the first issue, the modify FIRMWARE_VER patch is add
alone just befor send out the patchset.

For generating acpi table, I use acpica-tools 20180508 version and it works.
I think acpica-tools are not backward compatibility and confused about 
acpica-tools.

Thanks.

>>
>> Heyi Guo (2):
>>   Hisilicon/Hi1620: Add ACPI PPTT table
>>   Platform/Hisilicon/D06: Enable ACPI PPTT
>>
>> Luqi Jiang (1):
>>   Hisilicon/D06: add apei driver
>>
>> Ming Huang (18):
>>   Silicon/Hisilicon: Modify the MRC interface for other module
>>   Silicon/Hisilicon: Separate PlatformArch.h
>>   Hisilicon/D06: Add several basal file for D06
>>   Platform/Hisilicon/D06: Add M41T83RealTimeClockLib
>>   Platform/Hisilicon/D06: Add binary file for D06
>>

Re: [edk2] [PATCH edk2-platforms v1 00/38] Upload for D06 platform

2018-08-01 Thread Leif Lindholm 
On Tue, Jul 24, 2018 at 03:08:44PM +0800, Ming Huang wrote:
> The major features of this patchset include:
> 1 D06 source code;
> 2 Unify some D0x modules;
> 
> This patch set is base on pcihostbridage-v2.
> For compiling D06, add below hunk to edk2-platforms.config
> [d06]
> LONGNAME=HiSilicon D06
> DSC=Platform/Hisilicon/D06/D06.dsc
> ARCH=AARCH64

Very helpful, thank you.

> 
> Code can also be found in github: 
> https://github.com/hisilicon/OpenPlatformPkg.git
> branch: d06-platform-v1

Now, I started by trying to compile this, but I run into two issues.

First, the platform fails to build without FIRMWARE_VER specified on
the command line, since there is an extra '"' in the definition of
PcdFirmwareVersionString.

Then there is a build fault when generating ACPI tables. I tried to
update to a newer version of acpica-tools, but I still get:
---
"aarch64-linux-gnu-gcc" -x c -E -include AutoGen.h
-I/work/git/edk2-platforms/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt
-I/work/git/edk2-platforms/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables
-I/work/git/tianocore/Build/D06/DEBUG_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/DEBUG
-I/work/git/edk2/ArmPkg -I/work/git/edk2/ArmPkg/Include
-I/work/git/edk2/ArmPlatformPkg
-I/work/git/edk2/ArmPlatformPkg/Include -I/work/git/edk2/EmbeddedPkg
-I/work/git/edk2/EmbeddedPkg/Include -I/work/git/edk2/MdeModulePkg
-I/work/git/edk2/MdeModulePkg/Include -I/work/git/edk2/MdePkg
-I/work/git/edk2/MdePkg/Include
-I/work/git/edk2/MdePkg/Include/AArch64
-I/work/git/edk2-platforms/Silicon/Hisilicon
-I/work/git/edk2-platforms/Silicon/Hisilicon/Include
-I/work/git/edk2-platforms/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables
/work/git/tianocore/Build/D06/DEBUG_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort.i
> /work/git/tianocore/Build/D06/DEBUG_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort.iii
Trim --source-code -l -o
/work/git/tianocore/Build/D06/DEBUG_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/work/git/tianocore/Build/D06/DEBUG_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort."aarch64-linux-gnu-gcc"
-x c -E -include AutoGen.h
-I/work/git/edk2-platforms/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt
-I/work/git/edk2-platforms/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables
-I/work/git/tianocore/Build/D06/RELEASE_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/DEBUG
-I/work/git/edk2/ArmPkg -I/work/git/edk2/ArmPkg/Include
-I/work/git/edk2/ArmPlatformPkg
-I/work/git/edk2/ArmPlatformPkg/Include -I/work/git/edk2/EmbeddedPkg
-I/work/git/edk2/EmbeddedPkg/Include -I/work/git/edk2/MdeModulePkg
-I/work/git/edk2/MdeModulePkg/Include -I/work/git/edk2/MdePkg
-I/work/git/edk2/MdePkg/Include
-I/work/git/edk2/MdePkg/Include/AArch64
-I/work/git/edk2-platforms/Silicon/Hisilicon
-I/work/git/edk2-platforms/Silicon/Hisilicon/Include
-I/work/git/edk2-platforms/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables
/work/git/tianocore/Build/D06/RELEASE_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort.i
> /work/git/tianocore/Build/D06/RELEASE_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort.iii
Trim --source-code -l -o
/work/git/tianocore/Build/D06/RELEASE_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi16Copyright
(c) 2000 - 2018 Intel Corporation
/work/git/tianocore/Build/D06/RELEASE_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort.
71: [0004] ID Count : 0100
Error6303 -
Integer too large for target ^  (0100 - max 1 bytes)

Table Input:
/work/git/tianocore/Build/D06/RELEASE_GCC5/AARCH64/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/AcpiTablesHi1620/OUTPUT/./Hi1620Iort.
- 1991 lines, 59818 bytes, 68 fields

Compilation complete. 2 Errors, 0 Warnings, 0 Remarks
---

Any ideas what may be causing this?

/
Leif

> 
> Heyi Guo (2):
>   Hisilicon/Hi1620: Add ACPI PPTT table
>   Platform/Hisilicon/D06: Enable ACPI PPTT
> 
> Luqi Jiang (1):
>   Hisilicon/D06: add apei driver
> 
> Ming Huang (18):
>   Silicon/Hisilicon: Modify the MRC interface for other module
>   Silicon/Hisilicon: Separate PlatformArch.h
>   Hisilicon/D06: Add several basal file for D06
>   Platform/Hisilicon/D06: Add M41T83RealTimeClockLib
>   Platform/Hisilicon/D06: Add binary file for D06
>   Hisilicon/D06: Add OemMiscLibD06
>   Silicon/Hisilicon/D06: Wait for all disk ready
>   Silicon/Hisilicon/Acpi: Unify HisiAcipPlatformDxe
>   Silicon/Hisilicon/I2C: Optimize I2C library
>   Platform/Hisilicon/D06: Add OemNicLib
>   Hisilicon/D0X: Rename the global variable gDS3231RtcDevice
>   Platform/Hisilicon/D06: Add EarlyConfigPeim peim
>   Platform/Hisilicon/D06: Add PciHostBridgeLib
>   Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h
>   Silicon/Hisilicon/Setup: Support SPCR