Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal
On 12/01/17 02:48, Ni, Ruiyu wrote: > Laszlo, > Thank you very much for that! I will try to become a talkaholic > when writing commit messages next time. I feel a bit of sarcasm directed at me in "talkaholic" :) I do deserve that classification, no questions asked :) Thanks! Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal
Laszlo, Thank you very much for that! I will try to become a talkaholic when writing commit messages next time. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, November 30, 2017 9:16 PM > To: Laszlo Ersek > Cc: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp > library removal > > On 30 November 2017 at 12:22, Laszlo Ersek wrote: > > On 11/29/17 14:53, Laszlo Ersek wrote: > >> Ray, > >> > >> On 11/29/17 11:14, Ruiyu Ni wrote: > >>> The TFTP command was converted from a NULL class library instance to > >>> a dynamic shell command in commit 0961002352e9. > >>> > >>> Contributed-under: TianoCore Contribution Agreement 1.1 > >>> Signed-off-by: Ruiyu Ni > >>> Reviewed-by: Laszlo Ersek > >>> Cc: Ard Biesheuvel > >>> Cc: Julien Grall > >>> --- > >>> ArmVirtPkg/ArmVirt.dsc.inc | 11 +++ > >>> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ++- > >>> ArmVirtPkg/ArmVirtXen.fdf| 3 ++- > >>> 3 files changed, 11 insertions(+), 6 deletions(-) > >> > >> Can you please incorporate points (2) and (3) as well, from my v3 review? > >> > >> https://lists.01.org/pipermail/edk2-devel/2017-November/018191.html > > > > I fixed up the commit message as described above. > > > > I also test-built the ArmVirtQemu, ArmVirtQemuKernel and ArmVirtXen > > platforms, with the patch applied, for ARM and AARCH64. > > > > [ler...@redhat.com: extend commit message] > > Reviewed-by: Laszlo Ersek > > Build-tested-by: Laszlo Ersek > > > > Commit 59fcf0706bf4. > > > > Thanks for taking care of this. The build had been broken long enough ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal
On 30 November 2017 at 12:22, Laszlo Ersek wrote: > On 11/29/17 14:53, Laszlo Ersek wrote: >> Ray, >> >> On 11/29/17 11:14, Ruiyu Ni wrote: >>> The TFTP command was converted from a NULL class library >>> instance to a dynamic shell command in commit 0961002352e9. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ruiyu Ni >>> Reviewed-by: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Cc: Julien Grall >>> --- >>> ArmVirtPkg/ArmVirt.dsc.inc | 11 +++ >>> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ++- >>> ArmVirtPkg/ArmVirtXen.fdf| 3 ++- >>> 3 files changed, 11 insertions(+), 6 deletions(-) >> >> Can you please incorporate points (2) and (3) as well, from my v3 review? >> >> https://lists.01.org/pipermail/edk2-devel/2017-November/018191.html > > I fixed up the commit message as described above. > > I also test-built the ArmVirtQemu, ArmVirtQemuKernel and ArmVirtXen > platforms, with the patch applied, for ARM and AARCH64. > > [ler...@redhat.com: extend commit message] > Reviewed-by: Laszlo Ersek > Build-tested-by: Laszlo Ersek > > Commit 59fcf0706bf4. > Thanks for taking care of this. The build had been broken long enough ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal
On 11/29/17 14:53, Laszlo Ersek wrote: > Ray, > > On 11/29/17 11:14, Ruiyu Ni wrote: >> The TFTP command was converted from a NULL class library >> instance to a dynamic shell command in commit 0961002352e9. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ruiyu Ni >> Reviewed-by: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Julien Grall >> --- >> ArmVirtPkg/ArmVirt.dsc.inc | 11 +++ >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ++- >> ArmVirtPkg/ArmVirtXen.fdf| 3 ++- >> 3 files changed, 11 insertions(+), 6 deletions(-) > > Can you please incorporate points (2) and (3) as well, from my v3 review? > > https://lists.01.org/pipermail/edk2-devel/2017-November/018191.html I fixed up the commit message as described above. I also test-built the ArmVirtQemu, ArmVirtQemuKernel and ArmVirtXen platforms, with the patch applied, for ARM and AARCH64. [ler...@redhat.com: extend commit message] Reviewed-by: Laszlo Ersek Build-tested-by: Laszlo Ersek Commit 59fcf0706bf4. Thanks Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal
Ray, On 11/29/17 11:14, Ruiyu Ni wrote: > The TFTP command was converted from a NULL class library > instance to a dynamic shell command in commit 0961002352e9. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Reviewed-by: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Julien Grall > --- > ArmVirtPkg/ArmVirt.dsc.inc | 11 +++ > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ++- > ArmVirtPkg/ArmVirtXen.fdf| 3 ++- > 3 files changed, 11 insertions(+), 6 deletions(-) Can you please incorporate points (2) and (3) as well, from my v3 review? https://lists.01.org/pipermail/edk2-devel/2017-November/018191.html (If you keep posting new versions faster than I can review them, it's likely that I'll never catch up.) Thanks, Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
