Re: [BUG] org-save-all-org-buffers reapplies startup visibility [9.5 (release_9.5 @ /usr/local/share/emacs/29.0.50/lisp/org/)]

[Mark Barton]

The debugger shows that pred gets set to org-mode rather than the function to 
test for org mode.

Debugger entered--returning value: org-mode
  (setq pred pred-fun)
* (progn (setq pred pred-fun))
* (if (functionp pred-fun) (progn (setq pred pred-fun)))
* (let ((pred-fun (and (functionp pred) (funcall pred (if (functionp 
pred-fun) (progn (setq pred pred-fun
* (closure (backup-extract-version-start t) ( arg pred) "Save some 
modified file-visiting buffers.  Asks us..." (interactive "P") (if pred nil 
(setq pred save-some-buffers-default-predicate)) (let ((pred-fun (and 
(functionp pred) (funcall pred (if (functionp pred-fun) (progn (setq pred 
pred-fun (let* ((switched-buffer nil) 
(save-some-buffers--switch-window-callback #'(lambda (buffer) (setq 
switched-buffer buffer))) queried autosaved-buffers files-done abbrevs-done) 
(unwind-protect (let ((wconfig (current-window-configuration))) (unwind-protect 
(progn (let ... ...) (setq files-done ...) (and save-abbrevs abbrevs-changed 
...) (or queried ... abbrevs-done ...)) (set-window-configuration wconfig))) 
(if switched-buffer (progn (pop-to-buffer-same-window switched-buffer))(t 
#)
* apply((closure (backup-extract-version-start t) ( arg pred) "Save 
some modified file-visiting buffers.  Asks us..." (interactive "P") (if pred 
nil (setq pred save-some-buffers-default-predicate)) (let ((pred-fun (and 
(functionp pred) (funcall pred (if (functionp pred-fun) (progn (setq pred 
pred-fun (let* ((switched-buffer nil) 
(save-some-buffers--switch-window-callback #'(lambda (buffer) (setq 
switched-buffer buffer))) queried autosaved-buffers files-done abbrevs-done) 
(unwind-protect (let ((wconfig (current-window-configuration))) (unwind-protect 
(progn (let ... ...) (setq files-done ...) (and save-abbrevs abbrevs-changed 
...) (or queried ... abbrevs-done ...)) (set-window-configuration wconfig))) 
(if switched-buffer (progn (pop-to-buffer-same-window switched-buffer)) (t 
#))
* save-some-buffers(t #)
  org-save-all-org-buffers()
  funcall-interactively(org-save-all-org-buffers)
  command-execute(org-save-all-org-buffers record)
  execute-extended-command(nil "org-save-all-org-buffers" nil)
  funcall-interactively(execute-extended-command nil "org-save-all-org-buffers" 
nil)
  command-execute(execute-extended-command)


> On Oct 8, 2021, at 3:00 PM, Mark Barton  wrote:
> 
> I can confirm this too.
> 
> (defun org-save-all-org-buffers ()
>  "Save all Org buffers without user confirmation."
>  (interactive)
>  (message "Saving all Org buffers...")
>  (save-some-buffers t (lambda () (derived-mode-p 'org-mode)))
>  (when (featurep 'org-id) (org-id-locations-save))
>  (message "Saving all Org buffers... done"))
> 
> If I comment out this change to the function save-some-buffers, then 
> org-save-all-org-buffers works again.
> 
> a9ad3d477441feefa3bf6107d58281cb64e0e78a
> Author: Juri Linkov 
> AuthorDate: Fri Aug 13 10:10:29 2021 +0300
> Commit: Juri Linkov 
> CommitDate: Fri Aug 13 10:10:29 2021 +0300
> 
> Parent: c4d34d24e3 CC Mode: Enhance C++ Mode raw strings to multi-line 
> strings for any language
> Merged: emacs-27 feature/native-comp
> Contained:  master
> Follows:emacs-27.1 (8875)
> 
> Add save-some-buffers-root to save-some-buffers-default-predicate (bug#46374)
> 
> * lisp/files.el (save-some-buffers-default-predicate): Add choice
> 'save-some-buffers-root'.
> (save-some-buffers-root): New predicate function.
> (save-some-buffers): Check if 'pred' returns a lexically-bound lambda,
> then use it as 'pred'.
> 
> 
> (defun save-some-buffers ( arg pred)
>   "Save some modified file-visiting buffers.  Asks user about each one.
> You can answer `y' or SPC to save, `n' or DEL not to save, `C-r'
> @@ -5758,6 +5772,11 @@ save-some-buffers
>   (interactive "P")
>   (unless pred
> (setq pred save-some-buffers-default-predicate))
> +  ;; Allow `pred' to be a function that returns a predicate
> +  ;; with lexical bindings in its original environment (bug#46374).
> +  (let ((pred-fun (and (functionp pred) (funcall pred
> +(when (functionp pred-fun)
> +  (setq pred pred-fun)))
>   (let* ((switched-buffer nil)
>  (save-some-buffers--switch-window-callback
>   (lambda (buffer)
> 
> I think it has to do with how org-save-all-org-buffers sets the pred argument 
> with:
> (lambda () (derived-mode-p 'org-mode))
> 
>> On Oct 8, 2021, at 4:55 AM, Lennart C. Karssen  wrote:
>> 
>> Dear list,
>> 
>> Confirmed.
>> 
>> This is to confirm Micheal's overservation that
>> `org-save-all-org-buffers' doesn't save any Org buffers any more in
>> Emacs 28, compiled a few days ago from commit d86b2e59c and Org 9.5 from
>> Elpa, running on Ubuntu Linux 21.04.
>> I can't say if this is because of the upgrade of Org 9.5 or the newly
>> compiled Emacs as I did both at the same time.
>> Command used for testing:
>> emacs -Q -L ~/.emacs.d/elpa/org-9.5/ /tmp/test.org
>> 
>> 
>> Best regards,
>> 
>> Lennart Karssen.

Re: [BUG] org-save-all-org-buffers reapplies startup visibility [9.5 (release_9.5 @ /usr/local/share/emacs/29.0.50/lisp/org/)]

[Mark Barton]

I can confirm this too.

(defun org-save-all-org-buffers ()
  "Save all Org buffers without user confirmation."
  (interactive)
  (message "Saving all Org buffers...")
  (save-some-buffers t (lambda () (derived-mode-p 'org-mode)))
  (when (featurep 'org-id) (org-id-locations-save))
  (message "Saving all Org buffers... done"))

If I comment out this change to the function save-some-buffers, then 
org-save-all-org-buffers works again.

a9ad3d477441feefa3bf6107d58281cb64e0e78a
Author: Juri Linkov 
AuthorDate: Fri Aug 13 10:10:29 2021 +0300
Commit: Juri Linkov 
CommitDate: Fri Aug 13 10:10:29 2021 +0300

Parent: c4d34d24e3 CC Mode: Enhance C++ Mode raw strings to multi-line 
strings for any language
Merged: emacs-27 feature/native-comp
Contained:  master
Follows:emacs-27.1 (8875)

Add save-some-buffers-root to save-some-buffers-default-predicate (bug#46374)

* lisp/files.el (save-some-buffers-default-predicate): Add choice
'save-some-buffers-root'.
(save-some-buffers-root): New predicate function.
(save-some-buffers): Check if 'pred' returns a lexically-bound lambda,
then use it as 'pred'.


 (defun save-some-buffers ( arg pred)
   "Save some modified file-visiting buffers.  Asks user about each one.
 You can answer `y' or SPC to save, `n' or DEL not to save, `C-r'
@@ -5758,6 +5772,11 @@ save-some-buffers
   (interactive "P")
   (unless pred
 (setq pred save-some-buffers-default-predicate))
+  ;; Allow `pred' to be a function that returns a predicate
+  ;; with lexical bindings in its original environment (bug#46374).
+  (let ((pred-fun (and (functionp pred) (funcall pred
+(when (functionp pred-fun)
+  (setq pred pred-fun)))
   (let* ((switched-buffer nil)
  (save-some-buffers--switch-window-callback
   (lambda (buffer)

I think it has to do with how org-save-all-org-buffers sets the pred argument 
with:
(lambda () (derived-mode-p 'org-mode))

> On Oct 8, 2021, at 4:55 AM, Lennart C. Karssen  wrote:
> 
> Dear list,
> 
> Confirmed.
> 
> This is to confirm Micheal's overservation that
> `org-save-all-org-buffers' doesn't save any Org buffers any more in
> Emacs 28, compiled a few days ago from commit d86b2e59c and Org 9.5 from
> Elpa, running on Ubuntu Linux 21.04.
> I can't say if this is because of the upgrade of Org 9.5 or the newly
> compiled Emacs as I did both at the same time.
> Command used for testing:
>  emacs -Q -L ~/.emacs.d/elpa/org-9.5/ /tmp/test.org
> 
> 
> Best regards,
> 
> Lennart Karssen.
> 
> On 05-10-2021 21:51, Michael Powe wrote:
>> 
>> forgot to hit 'reply all.'
>> 
>> 
>>  Forwarded Message 
>> Subject: Re: [BUG] org-save-all-org-buffers reapplies startup
>> visibility [9.5 (release_9.5 @ /usr/local/share/emacs/29.0.50/lisp/org/)]
>> Date:Tue, 5 Oct 2021 15:47:42 -0400
>> From:Michael Powe 
>> To:  Bhavin Gandhi 
>> 
>> 
>> 
>> Hello,
>> 
>> I hesitate to reply, but here's a report from Windows 10.
>> 
>> works as expected
>> C:\Emacs\emacs-28\bin\runemacs.exe -Q -L
>> C:\Users\micha\AppData\Roaming\.emacs.d\elpa\org-9.5\ 'G:\My
>> Drive\org\daily.org'
>> GNU Emacs 28.0.50 (build 1, x86_64-w64-mingw32) of 2021-08-11
>> Org mode version 9.5 (9.5-g0a86ad @
>> c:/Users/micha/AppData/Roaming/.emacs.d/elpa/org-9.5/)
>> 
>> Now for the bad news.
>> 
>> does not save files at all!
>> C:\Emacs\emacs29\bin\runemacs.exe -Q 'G:\My Drive\org\daily.org'
>> GNU Emacs 29.0.50 (build 1, x86_64-w64-mingw32) of 2021-10-02
>> Org mode version 9.5 (release_9.5 @
>> c:/Emacs/emacs29/share/emacs/29.0.50/lisp/org/)
>> 
>> Upon invoking the save, contents of the file shift to the left, then
>> shift back; and that's it.
>> 
>> HTH.
>> 
>> mp
>> 
>> Bhavin Gandhi wrote on 10/5/2021 13:53:
>>> Hello Marcel,
>>> 
>>> On Tue, 5 Oct 2021 at 19:14, Marcel van der Boom  wrote:
 […]
 - emacs -Q test.org
 - make sure the outline is unfolded
 - make a change so test.org is 'dirty'
 - M-x org-save-all-org-buffers
 
 Observed behaviour:
 The outline in test.org will collapse and only show 'Header one'
 
 Expected behaviour:
 Outline state does not change on calling `org-save-all-buffers`
 
>>> I tried to follow the above steps with Emacs 27.1, and Org mode latest
>>> main branch as well as the release_9.5 tag. The only different step I
>>> took was this:
>>> 
>>> emacs -Q -L ~/src/org-mode/lisp/ ~/test.org
>>> 
>>> When I modify the test.org and call org-save-all-org-buffers, all the
>>> headings remain unfolded. I tried to switch to a different buffer and
>>> called the function, but still it remained in overview state. Maybe
>>> someone with the latest Emacs build from master can try to reproduce?
>>> 
>> 
>> -- 
>> Sent from Postbox 
> 
> -- 
> *-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
> L.C. Karssen
> 's-Hertogenbosch
> The Netherlands
> 
> lenn...@karssen.org
> http://blog.karssen.org
> GPG key ID: A88F554A
> 

[ANN] New `bibtex' citation processor

[Nicolas Goaziou]

Hello,

I just added the no-thrill "oc-bibtex" citation processor, which relies
on the standard "\cite" and "\nocite" LaTeX commands. It only supports
citation suffixes.

Regards,
-- 
Nicolas Goaziou

Re: Citations: Locale specific adaptions?

[Nicolas Goaziou]

M. ‘quintus’ Gülker  writes:

> I agree with Bruce that this should be mentioned in the manual,
> including a pointer to the aforementioned Git repository, because I
> needed to find that one on my own.

Meanwhile, the `csl' processor is copiously documented in the
"Commentary" section of the "oc-csl.el" file.

Regards,

Re: Citations: Locale specific adaptions?

[M . ‘quintus’ Gülker]

Am Freitag, dem 08. Oktober 2021 schrieb Nicolas Goaziou:
> I think you need to provide locales in addition to the style file, see
> `org-cite-csl-locales-dir'.

That resolved the problem! Thank you (and Bruce). I cloned
https://github.com/citation-style-language/locales and set
`org-cite-csl-locales-dir' to the repository's directory.

I agree with Bruce that this should be mentioned in the manual,
including a pointer to the aforementioned Git repository, because I
needed to find that one on my own.

Thanks again!

  -quintus

-- 
Dipl.-Jur. M. Gülker | https://mg.guelker.eu | PGP: Siehe Webseite
Passau, Deutschland  | kont...@guelker.eu| O<

Re: Citations: Locale specific adaptions?

[András Simonyi]

Dear All,

setting the `org-cite-csl-locales-dir' variable to a directory
containing the German CSL locale file I indeed get the localized

Akbarian, Samira, An einen, der vorüberfuhr, Stand: 14. Dezember 2020,
https://verfassungsblog.de/an-einen-der-voruberfuhr/ (besucht am
02.01.2021).

version of the bibliography entry,

best wishes,
András





> I think you need to provide locales in addition to the style file, see
> `org-cite-csl-locales-dir'.
>
> Regards,
> --
> Nicolas Goaziou
>

Re: Citations: Locale specific adaptions?

[Nicolas Goaziou]

Hello,

M. ‘quintus’ Gülker  writes:

> CSL has a concept of locales, where things like specific terms or the
> date format are drawn from locale files (see
> https://docs.citationstyles.org/en/1.0.1/specification.html#locale). I
> am not entirely sure if this is supported yet by the new citations
> functionality. Take this test document test.org:
>
> #+TITLE: Test
> #+LANGUAGE: de
>
> #+AUTHOR: Testauthor
> #+bibliography: /tmp/test/test.bib
>
> #+cite_export: csl /tmp/test/juristische-zitierweise.csl
>
> Das ist ein Test. [cite: @boehme-neßler2017unscharfes-recht-digital p. 
> 3033] Zweiter Satz.
> Noch ein Test. [cite: @akbarian2020oeffentliche-raeume]

[...]

> juristische-zitierweise.csl is a style for longer judicial works and
> available from the CSL repository at 
> https://github.com/citation-style-language/styles/blob/e22b8a566bad9b4c7f52720f60dd875057a5d210/juristische-zitierweise.csl.
>
> Given that test.org spefies “#+LANGUAGE: de”, I would expect that
> exporting uses the German terms and date format. However, exporting e.g.
> to HTML gives this in the bibliography:
>
> Akbarian, Samira, An einen, der vorüberfuhr, Stand: December 14,
> 2020, https://verfassungsblog.de/an-einen-der-voruberfuhr/
> (accessed 01/02/2021).
>
> The correctly German word “Stand” is hardcoded in
> juristische-zitierweise.el, so ignore that one for a moment. Other than
> that, you will notice that the date format is US English. This should
> not be the case. 

I think you need to provide locales in addition to the style file, see
`org-cite-csl-locales-dir'.

Regards,
-- 
Nicolas Goaziou

Re: Citations: Locale specific adaptions?

[Bruce D'Arcus]

On Fri, Oct 8, 2021 at 12:38 PM M. ‘quintus’ Gülker
 wrote:

> I am not entirely sure if this is a bug, a missing feature (if so, I
> would like to request it), or a user error on my side. Please enlighten
> me.

>From reading the code, it looks like you need to set org-cite-csl-locales-dir.

Have you done that, and is the locale you need there?

Another detail to add to the manual.

Bruce

Citations: Locale specific adaptions?

[M . ‘quintus’ Gülker]

Dear list,

CSL has a concept of locales, where things like specific terms or the
date format are drawn from locale files (see
https://docs.citationstyles.org/en/1.0.1/specification.html#locale). I
am not entirely sure if this is supported yet by the new citations
functionality. Take this test document test.org:

#+TITLE: Test
#+LANGUAGE: de
#+AUTHOR: Testauthor
#+bibliography: /tmp/test/test.bib
#+cite_export: csl /tmp/test/juristische-zitierweise.csl

Das ist ein Test. [cite: @boehme-neßler2017unscharfes-recht-digital p. 
3033] Zweiter Satz.
Noch ein Test. [cite: @akbarian2020oeffentliche-raeume]

#+print_bibliography:

Where /tmp/test/test.bib looks like this:

@Article{boehme-neßler2017unscharfes-recht-digital,
author = {Volker Boehme-Neßler},
title = {Die Macht der Algorithmen und die Ohnmacht des Rechts},
shortjournal = {NJW},
journaltitle = {Neue Juristische Wochenschrift},
year = {2017},
pages = {3031-3037},
langid = {ngerman}
}

@online{akbarian2020oeffentliche-raeume,
author = "Samira Akbarian",
title = "An einen, der vorüberfuhr",
language = "de",
date = "2020-12-14",
url = "https://verfassungsblog.de/an-einen-der-voruberfuhr/;,
urldate = "2021-01-02"
}

juristische-zitierweise.csl is a style for longer judicial works and
available from the CSL repository at 
https://github.com/citation-style-language/styles/blob/e22b8a566bad9b4c7f52720f60dd875057a5d210/juristische-zitierweise.csl.

Given that test.org spefies “#+LANGUAGE: de”, I would expect that
exporting uses the German terms and date format. However, exporting e.g.
to HTML gives this in the bibliography:

Akbarian, Samira, An einen, der vorüberfuhr, Stand: December 14,
2020, https://verfassungsblog.de/an-einen-der-voruberfuhr/
(accessed 01/02/2021).

The correctly German word “Stand” is hardcoded in
juristische-zitierweise.el, so ignore that one for a moment. Other than
that, you will notice that the date format is US English. This should
not be the case. For comparison, here is the same document in Pandoc
Markdown:

---
title: Test
author: Testauthor
lang: de
---

Das ist ein Test. [@boehme-neßler2017unscharfes-recht-digital, p. 3033] 
Zweiter Satz.
Noch ein Test. [@akbarian2020oeffentliche-raeume]

If this is exported with

pandoc -o test-pandoc.html -s --toc -C --csl=juristische-zitierweise.csl 
--bibliography=test.bib test.md

then the cited entry in the bibliography correctly reads

  Akbarian, Samira, An einen, der vorüberfuhr, Stand: 14.
  Dezember 2020, https://verfassungsblog.de/an-einen-der-voruberfuhr/
  (besucht am 02.01.2021).

You see how the date format changed for both the long and the numeric
format and how the translated string "besucht am" is used.

I am not entirely sure if this is a bug, a missing feature (if so, I
would like to request it), or a user error on my side. Please enlighten
me.

I used org 9.5 from MELPA with citeproc.el from the Git repository at
34e66583d95a8d80fb5b9f2960f3382ca0e6d3ab.

  -quintus

-- 
Dipl.-Jur. M. Gülker | https://mg.guelker.eu | PGP: Siehe Webseite
Passau, Deutschland  | kont...@guelker.eu| O<

Re: Someone to help merging orgmode.org/contribute.html and orgmode.org/worg/org-contribute.html ?

[Greg Minshall]

Bastien,

> I added you, you can now clone g...@git.sr.ht:~bzg/worg 
> and push commits.

thanks.

cheers, Greg

Re: Someone to help merging orgmode.org/contribute.html and orgmode.org/worg/org-contribute.html ?

[Bastien]

Greg Minshall  writes:

> thanks.  i'm "minshall" there, too.

I added you, you can now clone g...@git.sr.ht:~bzg/worg 
and push commits.

-- 
 Bastien

Re: Someone to help merging orgmode.org/contribute.html and orgmode.org/worg/org-contribute.html ?

[Greg Minshall]

Bastien,

> Applied, thanks a lot!  Let me know if you have a user on git.sr.ht, I
> can add you as a regular committer on https://git.sr.ht/~bzg/worg

thanks.  i'm "minshall" there, too.

cheers, Greg

Re: Citation not inserted as 1st item in footnote (using org-cite and org-ref-cite)

[Elias Bounatirou]

Great, thanks! I can confirm it works now. Once again thank you very much.
Best regards,
Elias

Am Mi., 6. Okt. 2021 um 14:44 Uhr schrieb Nicolas Goaziou <
m...@nicolasgoaziou.fr>:

> Nicolas Goaziou  writes:
>
> > This allows one to insert a citation in the middle of the citation
> > number, which is not desirable either. IOW, an additional check is
> > required.
>
> I think this is now fixed. Thank you.
>
> Regards,
> --
> Nicolas Goaziou
>

Re: Someone to help merging orgmode.org/contribute.html and orgmode.org/worg/org-contribute.html ?

[Bastien]

Hi Greg,

Greg Minshall  writes:

> sure.  some comments and a patch (and, without the nice css, the .html
> file it generates, just for ease of reviewing).

Applied, thanks a lot!  Let me know if you have a user on git.sr.ht, I
can add you as a regular committer on https://git.sr.ht/~bzg/worg

All best,

-- 
 Bastien

Re: Citation in footnote not expanded/exported to LaTeX (using Org-ref-cite)

[Elias Bounatirou]

 Many thanks, Nicolas !!!
I've just tested. It looks good now. I should rather say it's excellent.

Am Mi., 6. Okt. 2021 um 16:13 Uhr schrieb Nicolas Goaziou <
m...@nicolasgoaziou.fr>:

> Hello,
>
> Elias Bounatirou  writes:
>
> > However, it appears Nicolas' MWE unfortunately does not  reproduce the
> > issue. It's not the footnote that is omitted/ not exported, it's the
> > citation in the footnote that is left out (when the footnote follows two
> or
> > more citations, of which one has a suffix). In Nicolas' MWE, there is no
> > citation in the footnote. What seems to me (being no export on LaTeX)
> > strange about Bruce's LaTeX output is that there is no command
> > \footnote{...} or the like. So is the footnote-part of the LaTeX output
> > real LaTeX? (Sorry for this naïve question.)
>
> I noticed my ECM was not right. It took me a while to figure out the
> issue.
>
> > I've tested again.
> > With verbose I get the same erroneous result: the citation in the
> footnote
> > is not rendered (using the development version of org-mode, see below):
> > INPUT:
> >
>
> [...]
>
> > Body text [cite: @ravlic2021; @saric2010 with a SUFFIX][fn:1]
>
> [...]
>
> > [fn:1]Test [cite: @senker1987]
> >
> > LaTeX OUTPUT (shortened):
> >
> > Body text \autocites{ravlic2021}[][with a
> SUFFIX]{saric2010}\footnote{Test}
>
> I think I fixed it. Could you confirm it?
>
> Thank you.
>
> Regards,
> --
> Nicolas Goaziou
>

Re: Inequalities in math blocks

[Greg Minshall]

Rudolf,

> I do not understand. As Max pointed out, inequalities break HTML
> export in \( and \) as well.

my apologies for not having understood where we were in the discussion!

cheers, Greg

Re: Someone to help merging orgmode.org/contribute.html and orgmode.org/worg/org-contribute.html ?

[Greg Minshall]

Bastien,

> thanks a lot for volunteering, but I did the merge a few days ago.

great!

> Perhaps you can still carefully proofread
> https://orgmode.org/worg/org-contribute.html and enhance it?

sure.  some comments and a patch (and, without the nice css, the .html
file it generates, just for ease of reviewing).

i was thinking of (more or less) sorting the "ways to contribute" in
terms of difficulty/level of expertise required.  the below patch tries
to do this (ysomv -- your sort order may vary).

other than that, i did a bit of editing, added a few links and
footnotes, etc.

nit: i don't know how widespread this is, or whether it matters when someone
is looking on worg about how to contribute, but my setup (arch linux,
qutebrowser) doesn't include
: "C-x 8 RET 1f984" or "C-x 8 RET UNICORN FACE"

hope it's of use.

cheers, Greg

>From 8cf98908c94c2f8bbc0abcfc5cf948dc0a0820e3 Mon Sep 17 00:00:00 2001
From: Greg Minshall 
Date: Fri, 8 Oct 2021 15:08:17 +0300
Subject: [PATCH 2/2] org-contribute.org: Edit and re-organize slightly

---
 org-contribute.org | 90 --
 1 file changed, 48 insertions(+), 42 deletions(-)

diff --git a/org-contribute.org b/org-contribute.org
index a21c5223..d684ccdb 100644
--- a/org-contribute.org
+++ b/org-contribute.org
@@ -19,48 +19,54 @@
 
 The Org codebase is large, and contributing can be daunting at first,
 but don't hesitate to call for directions on [[file:org-mailing-list.org][the mailing list]].  If you
-are willing to help, there is plenty of low-hanging fruits for you and
+are willing to help, there is plenty of low-hanging fruit for you, and
 the community will welcome your contribution.
 
-: When contributing, always beware of the maintenance burden:
-: are you alleviating it or are you adding to it?
+: When contributing, always keep the maintenance burden in mind:
+: are you alleviating it, or are you adding to it?
 
 * Ways to contribute 濾
 :PROPERTIES:
 :CUSTOM_ID: types-of-contributions
 :END:
 
-- *Maintain an Org file*: If a file in the git repository does not have
-  a maintainer, and you want to help by maintaining it, please read
-  more on [[file:org-maintenance.org][how Org is maintained]] and let us know by sending an email to
-  [[file:org-mailing-list.org][the mailing list]].
+** Ways that do not involve programming
 
-- *Check the [[https://updates.orgmode.org/#help][requests for help]]*: If you want to help with one of these
-  tasks, say so on the list.
-
-- *Check the [[https://updates.orgmode.org/#bugs][list of confirmed bugs]]*: Even if you just provide more
-  information or ideas on how to fix them, this helps.
+- *Send bug reports*.  Before sending a bug report, make sure you read
+  the section of the manual on how to provide useful [[https://orgmode.org/org.html#Feedback][feedback]] or this
+  other great text: [[http://www.chiark.greenend.org.uk/~sgtatham/bugs.html][How to Send Bug Reports Effectively]].
 
 - *Try to reproduce bugs*: That's always very helpful.  Do subscribe to
   [[https://lists.gnu.org/mailman/listinfo/emacs-orgmode][Org's mailing list]] and monitor new unreferenced bugs.  Try to
   reproduce them.  If you can reproduce a bug, reply to the original
-  poster and add =X-Woof-Bug: confirmed= to your mail headers, and the
+  poster and add [[https://github.com/bzg/woof][=X-Woof-Bug: confirmed=]] to your mail headers, and the
   bug will then be shown on [[https://updates.orgmode.org/#bugs][updates.orgmode.org]].
 
 - *Help other users by replying to their questions* [[file:org-mailing-list.org][on the mailing list]]
   or on [[file:org-web-social.org][other web places]].
 
-- *Send bug reports*.  Before sending a bug report, make sure you read
-  the section of the manual on how to provide useful [[https://orgmode.org/org.html#Feedback][feedback]] or this
-  other great text: [[http://www.chiark.greenend.org.uk/~sgtatham/bugs.html][How to Send Bug Reports Effectively]].
-
-- *Submit patches* to the mailing list.  See how to format [[#first-patch][your first
-  patch]] and [[#patches][details on how to submit it]].
-
 - *Contribute to Worg*.  Worg is collaborative documentation made of Org
   files.  It's very easy to contribute to it.  Learn more [[file:worg-about.org][about Worg]]
   and [[file:worg-about.org::*How to use git for Worg][how to contribute]].
 
+- *Share ideas and feature requests*.  Org is already mature, but new
+  ideas keep popping up.  If you want to request a feature, first dig
+  into [[file:org-mailing-list.org][the mailing list]] to find similar proposals.  If you cannot find
+  any, subscribe to the list, read it for a while, then make your
+  proposal.  Formulate it with as much detail as possible, especially
+  with examples.
+
+** Ways that involve programming
+
+- *Check the [[https://updates.orgmode.org/#help][requests for help]]*: If you want to help with one of these
+  tasks, say so on the list.
+
+- *Check the 

Re: Fwd: [BUG] org-save-all-org-buffers reapplies startup visibility [9.5 (release_9.5 @ /usr/local/share/emacs/29.0.50/lisp/org/)]

[Lennart C. Karssen]

Dear list,

Confirmed.

This is to confirm Micheal's overservation that
`org-save-all-org-buffers' doesn't save any Org buffers any more in
Emacs 28, compiled a few days ago from commit d86b2e59c and Org 9.5 from
Elpa, running on Ubuntu Linux 21.04.
I can't say if this is because of the upgrade of Org 9.5 or the newly
compiled Emacs as I did both at the same time.
Command used for testing:
  emacs -Q -L ~/.emacs.d/elpa/org-9.5/ /tmp/test.org


Best regards,

Lennart Karssen.

On 05-10-2021 21:51, Michael Powe wrote:
> 
> forgot to hit 'reply all.'
> 
> 
>  Forwarded Message 
> Subject:  Re: [BUG] org-save-all-org-buffers reapplies startup
> visibility [9.5 (release_9.5 @ /usr/local/share/emacs/29.0.50/lisp/org/)]
> Date: Tue, 5 Oct 2021 15:47:42 -0400
> From: Michael Powe 
> To:   Bhavin Gandhi 
> 
> 
> 
> Hello,
> 
> I hesitate to reply, but here's a report from Windows 10.
> 
> works as expected
> C:\Emacs\emacs-28\bin\runemacs.exe -Q -L
> C:\Users\micha\AppData\Roaming\.emacs.d\elpa\org-9.5\ 'G:\My
> Drive\org\daily.org'
> GNU Emacs 28.0.50 (build 1, x86_64-w64-mingw32) of 2021-08-11
> Org mode version 9.5 (9.5-g0a86ad @
> c:/Users/micha/AppData/Roaming/.emacs.d/elpa/org-9.5/)
> 
> Now for the bad news.
> 
> does not save files at all!
> C:\Emacs\emacs29\bin\runemacs.exe -Q 'G:\My Drive\org\daily.org'
> GNU Emacs 29.0.50 (build 1, x86_64-w64-mingw32) of 2021-10-02
> Org mode version 9.5 (release_9.5 @
> c:/Emacs/emacs29/share/emacs/29.0.50/lisp/org/)
> 
> Upon invoking the save, contents of the file shift to the left, then
> shift back; and that's it.
> 
> HTH.
> 
> mp
> 
> Bhavin Gandhi wrote on 10/5/2021 13:53:
>> Hello Marcel,
>>
>> On Tue, 5 Oct 2021 at 19:14, Marcel van der Boom  wrote:
>>> […]
>>> - emacs -Q test.org
>>> - make sure the outline is unfolded
>>> - make a change so test.org is 'dirty'
>>> - M-x org-save-all-org-buffers
>>>
>>> Observed behaviour:
>>> The outline in test.org will collapse and only show 'Header one'
>>>
>>> Expected behaviour:
>>> Outline state does not change on calling `org-save-all-buffers`
>>>
>> I tried to follow the above steps with Emacs 27.1, and Org mode latest
>> main branch as well as the release_9.5 tag. The only different step I
>> took was this:
>>
>> emacs -Q -L ~/src/org-mode/lisp/ ~/test.org
>>
>> When I modify the test.org and call org-save-all-org-buffers, all the
>> headings remain unfolded. I tried to switch to a different buffer and
>> called the function, but still it remained in overview state. Maybe
>> someone with the latest Emacs build from master can try to reproduce?
>>
> 
> -- 
> Sent from Postbox 

-- 
*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
L.C. Karssen
's-Hertogenbosch
The Netherlands

lenn...@karssen.org
http://blog.karssen.org
GPG key ID: A88F554A
-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-



OpenPGP_signature
Description: OpenPGP digital signature

Re: [BUG] org-context called from link in org-agenda entry returns wrong values [9.5 (9.5-g0a86ad @ /home/.emacs.d/elpa/org-9.5/)]

[Harald Judt]

Am 07.10.21 um 06:10 schrieb Ihor Radchenko:

Harald Judt  writes:


Hi,

I am using this function to copy links from the agenda to the clipboard:

(defun my-copy-org-url ()
  (interactive)
  (let* ((link-info (assoc :link (org-context)))
...


org-context is ancient. It relies on org-links being fontified using
'org-link face and would fail for any non-standard link with :face link
parameter. Moreover, the return value will be different depending on
org-link-descriptive setting.

We should probably deprecate this function and encourage using
org-element-context. So, I recommend rewriting your code with
org-element-context.


Thank you, that helped me updating the function, which works fine with 
org-element-context:


  (defun my-copy-org-url ()
(interactive)
(let* ((raw-link (plist-get (nth 1 (org-element-context)) :raw-link)))
  (if (not raw-link)
  (error "Point not in an org link.")
(kill-new raw-link)
(message "Org link URL copied to clipboard."

Regards,
Harald

--
`Experience is the best teacher.'

PGP Key ID: 4FFFAB21B8580ABD
Fingerprint: E073 6DD8 FF40 9CF2 0665 11D4 4FFF AB21 B858 0ABD


OpenPGP_0x4FFFAB21B8580ABD.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

Re: [PATCH] Bug: Tag Selection Face Doesn't Toggle

[Daniel Fleischer]

> Daniel Fleischer  writes:
>
>> Hi, when selecting tags using fast selection and then de-selecting, the
>> face doesn't toggle back to regular face.
>>

It's better to have a default face instead of 'org-default face.

>From f269d3ad99b8ad570c19961831f38653046f07fb Mon Sep 17 00:00:00 2001
From: Daniel Fleischer 
Date: Fri, 8 Oct 2021 12:55:04 +0300
Subject: [PATCH] lisp/org.el: fast tag selection disabled tag face

A tag can be either selected in "current", "inherited" or disabled. When
disabled, it should have the 'org-default face. Previously, if a tag was
already selected, upon deselection it will still have an 'org-todo face.
---
 lisp/org.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 18cb53af6..1dfe70735 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12440,8 +12440,7 @@ (defun org-fast-tag-selection (current inherited table  todo-table)
 			   (cond
 ((member tag current) c-face)
 ((member tag inherited) i-face)
-(t (get-text-property (match-beginning 1) '
-		  face
+(t 'default)))
 		  (goto-char (point-min)
 	(delete-overlay org-tags-overlay)
 	(if rtn
-- 
2.33.0

Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken

[Marco Wahl]

Max Nikulin  writes:

> On 05/10/2021 23:32, Ihor Radchenko wrote:
>> Max Nikulin writes:
>> I tried come up with the reason why org-no-popup was used in the
>> initial
>> implementation. I think, the reason is avoiding situation like what you
>> may see after running
>> (let ((pop-up-frames t)) (funcall-interactively #'org-goto))
>> So, removing the macro completely is not a good idea.
>> I have updated the patch that should work without dropping the
>> macro.
>> See the attached.
>
> Thank you, Ihor.
>
> Your updated patch works in default configuration (-Q). I am not
> familiar with knobs of `display-buffer' function so I have no idea if
> someone may complain that such variant overrides his setup or works
> incorrectly with his preferences.

Please note the documentation of variable `pop-up-windows'.

This variable is provided mainly for backward compatibility and
should not be used in new code.

The same holds for `pop-up-frames'.

The drop of the macro looks like a good idea to me.  Can someone please
describe the price for dropping macro `org-no-popups'?

@Ihor I do not understand what "situation" you mean.

[PATCH] Bug: Tag Selection Face Doesn't Toggle

[Daniel Fleischer]

Daniel Fleischer  writes:

> Hi, when selecting tags using fast selection and then de-selecting, the
> face doesn't toggle back to regular face.
>
> Fast selection means `org-use-fast-tag-selection' is t.

See attached.

>From 0352757d7012dc543bae4039deaed7bbd401bb9f Mon Sep 17 00:00:00 2001
From: Daniel Fleischer 
Date: Fri, 8 Oct 2021 12:55:04 +0300
Subject: [PATCH] lisp/org.el: fast tag selection disabled tag face

A tag can be either selected in "current", "inherited" or disabled. When
disabled, it should have the 'org-default face. Previously, if a tag was
already selected, upon deselection it will still have an 'org-todo face.
---
 lisp/org.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 18cb53af6..e6a0350c1 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12440,8 +12440,7 @@ (defun org-fast-tag-selection (current inherited table  todo-table)
 			   (cond
 ((member tag current) c-face)
 ((member tag inherited) i-face)
-(t (get-text-property (match-beginning 1) '
-		  face
+(t 'org-default)))
 		  (goto-char (point-min)
 	(delete-overlay org-tags-overlay)
 	(if rtn
-- 
2.33.0


-- 

Daniel Fleischer