CI tests

[Christian Köstlin]

Dear org-mode users,


at the moment I am trying to enable as much of the org-mode testsuite
on the ci server (see https://builds.sr.ht/~bzg for the latest
testruns).

>From time to time some tests fail, because the time when e.g. a
timestamp is written to the buffer is different to when the timestamp
is calculated in the test (the minute just flips there).

The buildserver already stumbled over:
- test-org/org-log-done
- test-org-capture/fill-template
but I think there might be more problems like that.

Did you also see that when running the tests locally?

Kind regards,
Christian

Re: [PATCH] Ignore flaky ob-python tests

[Christian Köstlin]

Hi Ihor,

I somehow seem to remember that the async tests were also broken with
python.el (python-mode.el not installed).
at least sometimes? or is this only the underscore test?
If it's only the underscore test, I would suggest not installing
python-mode for ci and ignoring the really flaky tests (i think the
underscore one is a candidate here).

I somehow got the async things mixed up with the flaky tests, which is
not true for python-mode.el installed.

what do you think?

I really would like to see python tests pass ...

Kind regards,
Christian

On Thu, Nov 3, 2022 at 8:13 AM Ihor Radchenko  wrote:
>
> Christian Köstlin  writes:
>
> > With my patch the tests are still failing but the testsuite continues
> > to run and returns
> > with 0 as status code (one can see the failed test though).
>
> FYI, I am using automated scripts to run make test locally on multiple
> Emacs versions. 0 status code would do no good for my testing.
>
> >> Maybe we can instead provide some variable that can turn-on ignoring
> >> some problematic tests only during CI tests?
> > Yes ... that would also be possible e.g. skip the test or test nothing
> > if it's running on the ci.
> > (I am talking only about the 3 tests!).
>
> More like just 1 test with underscore :)
> The 3 tests in the patch are real failures because ob-python does not
> fully support python-mode.el.
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>

Re: [PATCH] Ignore flaky ob-python tests

[Christian Köstlin]

On Wed, Nov 2, 2022 at 7:52 AM Ihor Radchenko  wrote:
>
> Christian Köstlin  writes:
>
> > The new async feature of python seems to be implemented in a way
> > that can break with high CPU load. This patch still runs the 3 tests in
> > question, but does not fail the complete testsuite if any of those fail.
>
> Thanks for the patch, but I'm afraid that it will drive the tests useless.
> After the patch, even if the tests fail for a valid reason, it will not
> be visible upon running make test, AFAIU.
I think we know of the async problem, and you reported that as well,
so I would expect
if someone is able to fix it, he will also move the tests to "sharp" again.
With my patch the tests are still failing but the testsuite continues
to run and returns
with 0 as status code (one can see the failed test though).

> Maybe we can instead provide some variable that can turn-on ignoring
> some problematic tests only during CI tests?
Yes ... that would also be possible e.g. skip the test or test nothing
if it's running on the ci.
(I am talking only about the 3 tests!).

Kind regards,
Christian

[PATCH] Ignore flaky ob-python tests

[Christian Köstlin]

The new async feature of python seems to be implemented in a way
that can break with high CPU load. This patch still runs the 3 tests in
question, but does not fail the complete testsuite if any of those fail.

Kind regards,
Christian


0001-testing-lisp-test-ob-python.el-Ignore-flaky-tests.patch
Description: Binary data

Re: Problems running ob-julia tests (testing/test-ob-julia.el)

[Christian Köstlin]

On Wed, Oct 19, 2022 at 3:32 AM Ihor Radchenko  wrote:
>
> Pedro Bruel  writes:
>
> > I believe the ob-julia version we have on orgmode does not support sessions.
>
> There is definitely session support in lisp/ob-julia.el. ob-julia does
> define org-babel-load-session:julia and org-babel-prep-session:julia.
>
> Session support is even tested in testing/lisp/test-ob-julia.el
> For example, in test-ob-julia/session-multiline.
>
> ob-julia documentation also declares full session support:
> https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-julia.html
>
> For context, Christian is helping us to setup automatic CI tests for Org
> and we are now experiencing some issues with tests for babel languages.
> Those tests are normally disabled as they require external packages,
> which is why the problem was not noticed in the past.
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at .
> Support Org development at ,
> or support my work at 

I looked some more into testing/lisp/test-ob-julia.el. And it
seems for me, that the file was not completely ported over from python.
There are still python examples in it + some of the tests, are only
there, because they we're written for python (e.g.
test-ob-julia/insert-necessary-blank-line-when-sending-code-to-interpreter).

I could get hello worlds without session running (:reports output).
When I try :reports value I do not get good results.

ATM I am testing with emacs28 and julia 1.4.1 and org-mode master

Kind regards,
Christian

Problems running ob-julia tests (testing/test-ob-julia.el)

[Christian Köstlin]

Dear org-mode wizards,

I am trying to run the ob-julia tests but `make test` is prompting me
for a project folder. Has anybody the tests (or the ob-julia setup) in
a working state? (Simple ob-julia evaluations (without session) do
work for me).

Kind regards,
Christian

[PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el

[Christian Köstlin]

Aforementioned unit-test.

Kind regards,
Christian


0002-testing-lisp-test-ob-C.el-Add-test-for-dub-support-i.patch
Description: Binary data

[PATCH] Please add support for dlangs packagemanager to ob-C.el - v3

[Christian Köstlin]

After adding unit-tests (following in another patchset) I found a bug in my
last patch.
Sorry for the noise.

Kind regards,
Christian


0001-lisp-ob-C.el-Support-dub-in-ob-D.patch
Description: Binary data

[PATCH] Please add support for dlangs packagemanager to ob-C.el

[Christian Köstlin]

Thanks a lot for you feedbacks!

I rebased my change now, and I hope my changed commit message now conforms
more the the projects standard.
I will send in another patchset including some unittests, if I can get them
to work locally at my machine.

Thanks in advance,
Christian


0001-lisp-ob-C.el-Support-dub-in-ob-D.patch
Description: Binary data

Please add support for dlangs packagemanager to ob-C.el

[Christian Köstlin]

Please see the patch comment. I reworked my original patch to fit into the
TINYPATCH category.

Kind regards,
Christian


0001-lisp-ob-C.el-Support-dub-dependencies-for-dlang.patch
Description: Binary data

Re: Re: Please add support for dlangs packagemanager to ob-C.el

[Christian Köstlin]

Hi Thierry,

thanks for your feedback and please let me know if I should change
anything to fit
better into the org-mode codebase.



> Easily adding DLang dependencies while keeping a single code block seems
> quite useful.
> I will take a deeper look at your proposal.
> Also, you marked your patch as TINYCHANGE, which imply it is less than
> 15 lines long. However your patch is 24 lines long. This requires that
> you assign the copyright for your contributions to the FSF. Have you
> signed the assignment? More on this process here:
> https://orgmode.org/contribute.html

Thanks for the hint. I filled and sent out the form, but did not yet
hear anything back.
Not sure if I can manage to squeeze the patch into 15 lines so I try
to do the signing.


Kind regards,
Christian

Please add support for dlangs packagemanager to ob-C.el

[Christian Köstlin]

I Hope the patch already contains enough background information why its a
nice feature to have in ob-C.el.

Kind regards,
Christian


0001-lisp-ob-C.el-Support-dub-dependencies-for-dlang.patch
Description: Binary data

[O] Is there a addon or corefunctionality that helps with e.g. clock-tables?

[Christian Köstlin]

Whenever I want to work with a clock-table I have to open up
https://orgmode.org/manual/The-clock-table.html and look at the
options that clock-table supports.

It would be great to have a simple ui e.g. like magit or deadgrep that
can be opened for a clocktable and change the settings.

kind regards,
christian