[O] help with org-mobile-push
Hello all! I'm trying to get the MobileOrg app working on my iPhone. I've followed the instructions at http://mobileorg.ncogni.to/doc/getting-started/using-dropbox/; for sanity checking purposes here are the values of the vars referenced there: org-directory: ~/Dropbox/org/ org-mobile-inbox-for-pull: ~/Dropbox/org/inbox.org org-mobile-directory: ~/Dropbox/MobileOrg/ I've run the MobileOrg app on my phone, linked to Dropbox (setting the index file to /MobileOrg/index.org -- not sure if that's correct, but I couldn't find any insight on what that value should be), and then from emacs, run org-mobile-push. I see files created in the MobileOrg directory in dropbox. When I then go back to my phone and sync, I see nothing show up in outlines. Interestingly, syncing in the other direction works just fine; if I create a new capture, sync, and then run org-mobile-pull from emacs, the new note ends up in inbox.org. It's just the push functionality that I'm running into trouble with. The files in MobileOrg look correct to me, so my guess is that org-mobile-push is working just fine, but I've misconfigured something on the phone app side. Thanks in advance for any insight that you folks can provide. Madan R.
Re: [O] [PATCH] Agenda: Fix org-agenda-bulk-toggle when point is at already marked item
Hi Nick, Ah, of course, you're right; it would result in a change in behavior. While I can certainly tweak the patch to maintain the old behavior in the case of a negative or zero arg, stepping back, I don't quite understand the reasoning for the current behavior. If a user has gone to the trouble of providing a negative arg, it doesn't seem intuitive that org-agenda-bulk-mark just does the same thing as if no negative arg was passed in. For what it's worth, the only caller that I see for this function in the codebase is the one in org-agenda-bulk-toggle that I was aiming to fix with this patch. Of course there could be folks relying on the current behavior, but I'd be curious as to what they're looking to do. Madan R. On Mon, Apr 16, 2012 at 2:36 AM, Nick Dokos nicholas.do...@hp.com wrote: Madan Ramakrishnan madan...@gmail.com wrote: * lisp/org-agenda.el (org-agenda-bulk-mark): truly make arg optional as advertised by the function Problem here was that org-agenda-bulk-toggle calls org-agenda-bulk-mark with no parameters; however, the (max arg 1) call inside org-agenda-bulk-mark will fail with no parameter. Change the max to an or and all is well. This is my first patch for org so apologies for any inadvertent missteps TINYCHANGE --- lisp/org-agenda.el |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 0ffaadb..4e9473d 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -8299,7 +8299,7 @@ This is a command that has to be installed in `calendar-mode-map'. (defun org-agenda-bulk-mark (optional arg) Mark the entry at point for future bulk action. (interactive p) - (dotimes (i (max arg 1)) + (dotimes (i (or arg 1)) (unless (org-get-at-bol 'org-agenda-diary-link) (let* ((m (org-get-at-bol 'org-hd-marker)) ov) -- 1.7.9.2 I presume arg can be negative or zero. If arg is e.g. -3 (max arg 1) - 1 (or arg 1) - -3 so your patch changes the behavior of the function in these cases. Nick
[O] [PATCH] Agenda: Fix org-agenda-bulk-toggle when point is at already marked item
* lisp/org-agenda.el (org-agenda-bulk-mark): truly make arg optional as advertised by the function Problem here was that org-agenda-bulk-toggle calls org-agenda-bulk-mark with no parameters; however, the (max arg 1) call inside org-agenda-bulk-mark will fail with no parameter. Change the max to an or and all is well. This is my first patch for org so apologies for any inadvertent missteps TINYCHANGE --- lisp/org-agenda.el |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 0ffaadb..4e9473d 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -8299,7 +8299,7 @@ This is a command that has to be installed in `calendar-mode-map'. (defun org-agenda-bulk-mark (optional arg) Mark the entry at point for future bulk action. (interactive p) - (dotimes (i (max arg 1)) + (dotimes (i (or arg 1)) (unless (org-get-at-bol 'org-agenda-diary-link) (let* ((m (org-get-at-bol 'org-hd-marker)) ov) -- 1.7.9.2
