Re: [O] Fix to property inheritance
Hi Bill, sorry for the late (and probably disappointing) reply. Bill Wishon b...@wishon.org writes: This is my first major org-mode contribution, and I'm new to git, so if there is something I haven't got quite right in terms of how to contribute please advise. org-entry-get with inherit set didn't work for sub-heading additions or overrides to properties found in parent headings as of Org-mode version 7.9.2 (release_7.9.2-738-g442b2a-git @ org-loaddefs.el can not be found!). An example test org-mode file is attached (modified from the testing/ examples directory and also updated in my git repository). Thanks for providing such a file with tests and examples. As far as I understand, problems are for cumulative properties, right? Eric, do you have time to check Bill's tests and see what's wrong with cumulative properties and inheritance? I'm not familiar enough with this part of the code to *enjoy* fixing this :) As for the patch themselves... 1) I did not receive confirmation from the FSF copyright clerk that your assignment is processed -- let me know if it is; 2) Please shrink commit messages and code lines to 75 characters when possible. See org.el: we avoid long lines. This is not only for code readability, but also - and importantly here - for patch readability... If I overlooked a bug about something else than cumulative props, please let me know and let's have a separate fix for it. Thanks! -- Bastien
Re: [O] Fix to property inheritance
Hi Bastien, I'll edit the code and commit messages so they're 75 chars. I'll check in again to see where the FSF process is at. And yes this is about property inheritance with accumulation. ~Bill On Jan 7, 2013, at 9:35 AM, Bastien b...@altern.org wrote: Hi Bill, sorry for the late (and probably disappointing) reply. Bill Wishon b...@wishon.org writes: This is my first major org-mode contribution, and I'm new to git, so if there is something I haven't got quite right in terms of how to contribute please advise. org-entry-get with inherit set didn't work for sub-heading additions or overrides to properties found in parent headings as of Org-mode version 7.9.2 (release_7.9.2-738-g442b2a-git @ org-loaddefs.el can not be found!). An example test org-mode file is attached (modified from the testing/ examples directory and also updated in my git repository). Thanks for providing such a file with tests and examples. As far as I understand, problems are for cumulative properties, right? Eric, do you have time to check Bill's tests and see what's wrong with cumulative properties and inheritance? I'm not familiar enough with this part of the code to *enjoy* fixing this :) As for the patch themselves... 1) I did not receive confirmation from the FSF copyright clerk that your assignment is processed -- let me know if it is; 2) Please shrink commit messages and code lines to 75 characters when possible. See org.el: we avoid long lines. This is not only for code readability, but also - and importantly here - for patch readability... If I overlooked a bug about something else than cumulative props, please let me know and let's have a separate fix for it. Thanks! -- Bastien
Re: [O] Fix to property inheritance
Hi Bill, Bill Wishon b...@wishon.org writes: I'll edit the code and commit messages so they're 75 chars. I'll check in again to see where the FSF process is at. And yes this is about property inheritance with accumulation. Great, *thanks*! -- Bastien
Re: [O] Fix to property inheritance
Hi Bill, Bill Wishon b...@wishon.org writes: While I'm figuring out how to create the patch and email it in the right format (I don't think I can with gmail), I've tried to make my bitbucket.org repository as public as possible. Perhaps give it another shot in the meantime. https://bitbucket.org/mrvwman/wishon-org-mode.git I confirm I can pull the repo correctly, thanks. -- Bastien
Re: [O] Fix to property inheritance
While I'm figuring out how to create the patch and email it in the right format (I don't think I can with gmail), I've tried to make my bitbucket.orgrepository as public as possible. Perhaps give it another shot in the meantime. https://bitbucket.org/mrvwman/wishon-org-mode.git ~Bill On Mon, Dec 24, 2012 at 7:28 PM, Bastien b...@altern.org wrote: Hi Bill, Bill Wishon b...@wishon.org writes: My public git repository info is: git clone g...@bitbucket.org:mrvwman /wishon-org-mode.git branch name: fix-property-inheritance I could not clone this repository, apparently I don't have enough rights. Can you send a patch? Thanks, -- Bastien
Re: [O] Fix to property inheritance
Hi Bill, Bill Wishon b...@wishon.org writes: My public git repository info is: git clone g...@bitbucket.org:mrvwman /wishon-org-mode.git branch name: fix-property-inheritance I could not clone this repository, apparently I don't have enough rights. Can you send a patch? Thanks, -- Bastien
Re: [O] Fix to property inheritance
Hi Bill, Bill Wishon b...@wishon.org writes: This is my first major org-mode contribution, and I'm new to git, so if there is something I haven't got quite right in terms of how to contribute please advise. Thanks for contributing. org-entry-get with inherit set didn't work for sub-heading additions or overrides to properties found in parent headings as of Org-mode version 7.9.2 (release_7.9.2-738-g442b2a-git @ org-loaddefs.el can not be found!). An example test org-mode file is attached (modified from the testing/ examples directory and also updated in my git repository). Yes, I see the problem. My public git repository info is: git clone g...@bitbucket.org:mrvwman /wishon-org-mode.git branch name: fix-property-inheritance Unless this is a big serie of patches (e.g. 5) can you send the patch to the mailing list? We use a patchwork instance to store patches and be able to review them later. Make sure to read this : http://orgmode.org/worg/org-contribute.html#sec-4 I've submitted my request to ass...@gnu.org, but have not yet received a reply. I've added you to Worg: http://orgmode.org/worg/org-contribute.html#sec-6-2 Thanks in advance for the patch! -- Bastien
[O] Fix to property inheritance
This is my first major org-mode contribution, and I'm new to git, so if there is something I haven't got quite right in terms of how to contribute please advise. org-entry-get with inherit set didn't work for sub-heading additions or overrides to properties found in parent headings as of Org-mode version 7.9.2 (release_7.9.2-738-g442b2a-git @ org-loaddefs.el can not be found!). An example test org-mode file is attached (modified from the testing/examples directory and also updated in my git repository). My public git repository info is: git clone g...@bitbucket.org: mrvwman/wishon-org-mode.git branch name: fix-property-inheritance I've submitted my request to ass...@gnu.org, but have not yet received a reply. Best, ~Bill my-property-inheritance.org Description: Binary data
