Re: [PATCH] Throw an error when bibliography field is not properly parsed (was: [PATCH] oc-basic.el: Fix wrong type for the editors field when parsing JSON.)

[Ihor Radchenko]

Ihor Radchenko  writes:

> I am attaching tentative patch that will make
> `org-cite-basic--get-field' throw an error when the filed value is not a
> string.

Applied, onto main; with minor amendments.
I made the new code not throw error on nil return value.

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=104311c7f

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

[PATCH] Throw an error when bibliography field is not properly parsed (was: [PATCH] oc-basic.el: Fix wrong type for the editors field when parsing JSON.)

[Ihor Radchenko]

Ihor Radchenko  writes:

>> As explained in the ChangeLog entry, this points to a more general issue 
>> where
>> `org-cite-basic--get-field' is expected to return nil or a string, but calls
>> `org-cite-basic--get-entry' that may return an association list. I am not 
>> sure
>> how to fix that since it means converting anything that
>> `org-cite-basic--get-entry' may return into a string.
>
> Non-string can only be for JSON bibliographies for fields that are not
> supported. `org-cite-basic--get-field' can probably return nil in such
> scenarios.

I am attaching tentative patch that will make
`org-cite-basic--get-field' throw an error when the filed value is not a
string.

I would appreciate testing.

Best,
Ihor

>From 9fe6284fdc7ceeb0e0aa8e5a58b6828ca415b6b2 Mon Sep 17 00:00:00 2001
Message-Id: <9fe6284fdc7ceeb0e0aa8e5a58b6828ca415b6b2.1672323564.git.yanta...@posteo.net>
From: Ihor Radchenko 
Date: Thu, 29 Dec 2022 17:18:35 +0300
Subject: [PATCH] org-cite-basic--get-field: Throw an error on non-nil field
 values

* lisp/oc-basic.el (org-cite-basic--get-field): Throw an error when
the field value is not a string.  Document the new behavior.

Link: https://orgmode.org/list/87edsnsocj.fsf@localhost
---
 lisp/oc-basic.el | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lisp/oc-basic.el b/lisp/oc-basic.el
index 01e314bfd..8e69db03c 100644
--- a/lisp/oc-basic.el
+++ b/lisp/oc-basic.el
@@ -332,7 +332,9 @@ (defun org-cite-basic--get-field (field entry-or-key  info raw)
 
 Return value may be nil or a string.  If current export back-end is derived
 from `latex', return a raw string instead, unless optional argument RAW is
-non-nil."
+non-nil.
+
+Throw an error if the field value is non-string and non-nil."
   (let ((value
  (cdr
   (assq field
@@ -343,6 +345,8 @@ (defun org-cite-basic--get-field (field entry-or-key  info raw)
entry-or-key)
   (_
(error "Wrong value for ENTRY-OR-KEY: %S" entry-or-key)))
+(unless (and value (stringp value))
+  (error "Non-string bibliography field value: %S" value))
 (if (and value
  (not raw)
  (org-export-derived-backend-p (plist-get info :back-end) 'latex))
-- 
2.38.1



-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [PATCH] oc-basic.el: Fix wrong type for the editors field when parsing JSON.

[Ihor Radchenko]

Hugo Cisneros  writes:

> I use org-cite with a JSON bibliography and noticed a bug when an entry only 
> has
> an "editors" field but no "authors" field. The function
> `org-cite-basic—get-author' correctly falls back to using the editors instead 
> of
> the authors, but `org-cite-basic--parse-json’ stringifies only the "authors"
> field and not the "editors." This creates an error when other functions assume
> they got a string from `org-cite-basic—get-author'. The patch fixes the issue 
> by
> applying the same transformation to both "authors" and "editors".

Thanks!
Applied onto bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=318807013
Use are now also listed as an Org contributor.
https://git.sr.ht/~bzg/worg/commit/c2bb6a52

> As explained in the ChangeLog entry, this points to a more general issue where
> `org-cite-basic--get-field' is expected to return nil or a string, but calls
> `org-cite-basic--get-entry' that may return an association list. I am not sure
> how to fix that since it means converting anything that
> `org-cite-basic--get-entry' may return into a string.

Non-string can only be for JSON bibliographies for fields that are not
supported. `org-cite-basic--get-field' can probably return nil in such
scenarios.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

[PATCH] oc-basic.el: Fix wrong type for the editors field when parsing JSON.

[Hugo Cisneros]

I use org-cite with a JSON bibliography and noticed a bug when an entry only has
an "editors" field but no "authors" field. The function
`org-cite-basic—get-author' correctly falls back to using the editors instead of
the authors, but `org-cite-basic--parse-json’ stringifies only the "authors"
field and not the "editors." This creates an error when other functions assume
they got a string from `org-cite-basic—get-author'. The patch fixes the issue by
applying the same transformation to both "authors" and "editors".

As explained in the ChangeLog entry, this points to a more general issue where
`org-cite-basic--get-field' is expected to return nil or a string, but calls
`org-cite-basic--get-entry' that may return an association list. I am not sure
how to fix that since it means converting anything that
`org-cite-basic--get-entry' may return into a string.





oc-basic.el.patch
Description: Binary data


Hugo Cisneros