Re: [O] org-gnus-follow-link and nnimap-request-scan

2011-04-12 Thread Tassilo Horn
Eden Cardim  writes:

> Tassilo> No, I just wasn't really sure what that SCAN argument
> Tassilo> means, so I tried to be as safe as possible.  If it's
> Tassilo> always safe to provide nil, let's change that.
>
> Well, right now all it does is to check split rules against incoming
> mail. But, if we have a link to a message in org, then that message
> already went through the split process, so re-splitting is
> unnecessary.

Ok, so here we go:

>From 89fecc7b938385647618dc28c4df304df872e6eb Mon Sep 17 00:00:00 2001
From: Tassilo Horn 
Date: Tue, 12 Apr 2011 20:27:54 +0200
Subject: [PATCH] Call gnus-activate-group without SCAN arg.

* org-gnus.el (org-gnus-follow-link): Don't request scan of
group when following link.
---
 lisp/org-gnus.el |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
index eba4cb4..a5ece8b 100644
--- a/lisp/org-gnus.el
+++ b/lisp/org-gnus.el
@@ -249,7 +249,7 @@ If `org-store-link' was called with a prefix arg the meaning of
   (when article
 (setq article (org-substring-no-properties article)))
   (cond ((and group article)
-	 (gnus-activate-group group t)
+	 (gnus-activate-group group)
 	 (condition-case nil
 	 (let* ((method (gnus-find-method-for-group group))
 		(backend (car method))
-- 
1.7.5.rc1


Bye,
Tassilo


Re: [O] org-gnus-follow-link and nnimap-request-scan

2011-04-12 Thread Eden Cardim
> "Tassilo" == Tassilo Horn  writes:

Tassilo> No, I just wasn't really sure what that SCAN argument
Tassilo> means, so I tried to be as safe as possible.  If it's
Tassilo> always safe to provide nil, let's change that.

Well, right now all it does is to check split rules against incoming
mail. But, if we have a link to a message in org, then that message
already went through the split process, so re-splitting is unnecessary.

-- 
Eden Cardim
Software Engineer
edencardim.com
+55 73 9986-3963




Re: [O] org-gnus-follow-link and nnimap-request-scan

2011-04-12 Thread Tassilo Horn
Eden Cardim  writes:

Hi Eden,

> After switching to using gnus mail splitting, following links to
> nnimap messages has become very slow. I'm fairly familiar with the
> gnus source, but not org-mode's as much, after wading a bit in the
> source I landed on

[...]

> ,[ org-gnus-follow-link ]
> |  (gnus-activate-group group t)
> `
> Which is certainly dispensable for visiting articles via nnimap.
> Switching to
> ,[ org-gnus-follow-link ]
> |  (gnus-activate-group group nil)
> `
> Makes the linked articles appear nearly instantly.
>
> Am I missing something here?

No, I just wasn't really sure what that SCAN argument means, so I tried
to be as safe as possible.  If it's always safe to provide nil, let's
change that.

Bye,
Tassilo