Re: Big desktop undo buffer crashes Emacs

2006-05-14 Thread Lars Hansen
Luc Teirlinck wrote:

Is there any reason to keep this buffer hanging around
consuming some memory and being user visible?
  

I don't think there is. I suggest to use with-temp-buffer (and
buffer-disable-undo)
Patch attached.

*** desktop.el.~1.99.~	2006-02-19 15:43:52.0 +0100
--- desktop.el	2006-05-12 08:47:57.615841646 +0200
***
*** 763,772 
  (setq locals (cdr locals)))
ll)))
(buffer-list)))
!   (eager desktop-restore-eager)
!   (buf (get-buffer-create *desktop*)))
!   (set-buffer buf)
!   (erase-buffer)
  
(insert
  ;; -*- mode: emacs-lisp; coding: emacs-mule; -*-\n
--- 763,771 
  (setq locals (cdr locals)))
ll)))
(buffer-list)))
!   (eager desktop-restore-eager))
!   (with-temp-buffer
! (buffer-disable-undo)
  
  (insert
   ;; -*- mode: emacs-lisp; coding: emacs-mule; -*-\n
***
*** 801,807 
  info)
(setq default-directory dirname)
(let ((coding-system-for-write 'emacs-mule))
! (write-region (point-min) (point-max) filename nil 'nomessage
(setq desktop-dirname dirname))
  
  ;; 
--- 800,806 
info)
  (setq default-directory dirname)
  (let ((coding-system-for-write 'emacs-mule))
!   (write-region (point-min) (point-max) filename nil 'nomessage)
(setq desktop-dirname dirname))
  
  ;; 

___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


with-temp-buffer and undo [was: Big desktop undo buffer crashes Emacs]

2006-05-12 Thread Lars Hansen
Lars Hansen wrote:

I suggest to use with-temp-buffer (and buffer-disable-undo)
  

Does it ever make sense to save undo information in a temporary buffer?
If not, I suggest to disable it in with-temp-buffer.
Patch attached.
*** subr.el~	2006-05-12 08:24:10.0 +0200
--- subr.el	2006-05-12 12:40:59.575290323 +0200
***
*** 2220,2226 
  See also `with-temp-file' and `with-output-to-string'.
(declare (indent 0) (debug t))
(let ((temp-buffer (make-symbol temp-buffer)))
! `(let ((,temp-buffer (generate-new-buffer  *temp*)))
 (unwind-protect
  	   (with-current-buffer ,temp-buffer
  	 ,@body)
--- 2220,2227 
  See also `with-temp-file' and `with-output-to-string'.
(declare (indent 0) (debug t))
(let ((temp-buffer (make-symbol temp-buffer)))
! `(let ((,temp-buffer (generate-new-buffer  *temp*))
!(buffer-undo-list t))
 (unwind-protect
  	   (with-current-buffer ,temp-buffer
  	 ,@body)
___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: with-temp-buffer and undo [was: Big desktop undo buffer crashes Emacs]

2006-05-12 Thread Eli Zaretskii
 Date: Fri, 12 May 2006 12:50:23 +0200
 From: Lars Hansen [EMAIL PROTECTED]
 Cc: emacs-pretest-bug@gnu.org, Luc Teirlinck [EMAIL PROTECTED],
   [EMAIL PROTECTED], [EMAIL PROTECTED]
 
 Does it ever make sense to save undo information in a temporary buffer?

Why not?  The fact that it's temporary doesn't necessarily mean it
cannot be used interactively.  For example, I could imagine some
specialized mode that pops up a temporary buffer where the user is
supposed to type some text that the mode then uses.  Some VC-related
feature could, for example, ask for a comment or descriptive text that
way.



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: with-temp-buffer and undo [was: Big desktop undo buffer crashes Emacs]

2006-05-12 Thread Andreas Schwab
Lars Hansen [EMAIL PROTECTED] writes:

 Lars Hansen wrote:

I suggest to use with-temp-buffer (and buffer-disable-undo)
  

 Does it ever make sense to save undo information in a temporary buffer?
 If not, I suggest to disable it in with-temp-buffer.
 Patch attached.
 *** subr.el~  2006-05-12 08:24:10.0 +0200
 --- subr.el   2006-05-12 12:40:59.575290323 +0200
 ***
 *** 2220,2226 
   See also `with-temp-file' and `with-output-to-string'.
 (declare (indent 0) (debug t))
 (let ((temp-buffer (make-symbol temp-buffer)))
 ! `(let ((,temp-buffer (generate-new-buffer  *temp*)))
  (unwind-protect
  (with-current-buffer ,temp-buffer
,@body)
 --- 2220,2227 
   See also `with-temp-file' and `with-output-to-string'.
 (declare (indent 0) (debug t))
 (let ((temp-buffer (make-symbol temp-buffer)))
 ! `(let ((,temp-buffer (generate-new-buffer  *temp*))
 !(buffer-undo-list t))
  (unwind-protect
  (with-current-buffer ,temp-buffer
,@body)

This won't disable undo in the temp buffer, you'd need to move that below
with-current-buffer.

Andreas.

-- 
Andreas Schwab, SuSE Labs, [EMAIL PROTECTED]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
And now for something completely different.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: with-temp-buffer and undo [was: Big desktop undo buffer crashes Emacs]

2006-05-12 Thread Lars Hansen
Andreas Schwab wrote:

This won't disable undo in the temp buffer, you'd need to move that below
with-current-buffer.
  

Oops.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-05-12 Thread Stefan Monnier
 !   (when (consp buffer-undo-list)
 !(setq buffer-undo-list nil))
 !   (let ((buffer-undo-list t))
 !(erase-buffer)

Why not just (buffer-disable-undo) ??

 Because I want to allow people who visit the buffer to undo any
 changes they deliberately or inadvertently make to it.

That's what I understood, but why?
Actually, a better question is: why is it called *desktop* rather
than  *desktop*?
Calling it  *desktop* would not just hide the buffer but would also
disable undo.  It's an internal buffer, after all, that normal users aren't
supposed to display or edit.


Stefan


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: with-temp-buffer and undo [was: Big desktop undo buffer crashes Emacs]

2006-05-12 Thread Richard Stallman
Using with-temp-buffer seems like a good idea.

Does it ever make sense to save undo information in a temporary buffer?
If not, I suggest to disable it in with-temp-buffer.

Undo is always disabled for with-temp-buffer, because it is disabled
by default for buffers whose names start with space.



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-05-11 Thread Bill Wohler
Richard Stallman [EMAIL PROTECTED] writes:

 Every morning for the past weeks, I've had a message in my minibuffer
 that roughly goes, Desktop undo buffer is 3+ MB, discard? (yes or no).
 I've been saying yes. This morning, feeling snarky, I said no and
 Emacs crashed.

 Could you please provide the precise text of the message?
 The message includes a buffer name; what is the buffer name?

OK, it's back. Here's the message:

   Buffer `*desktop*' undo info is 3159101 bytes long; discard it? (yes or no)

-- 
Bill Wohler [EMAIL PROTECTED]  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-05-11 Thread Luc Teirlinck
Bill Wohler wrote:

   OK, it's back. Here's the message:

  Buffer `*desktop*' undo info is 3159101 bytes long; discard it? (yes or 
no)

The patch below should solve your problem, or part of your problem.
There is no reason for the `*desktop*' buffer to accumulate a huge
undo entry just to allow you to erase the buffer completely using `M-x
undo'.  So the patch below disables undo while desktop.el writes all
these entries in the *desktop* buffer.  After that, undo is re-enabled
however.  So if you then inadvertently mess up the buffer, repeated
undo will restore the buffer to what desktop.el wrote in it.  But one
more undo will not erase the buffer.  Instead, it will tell you that
there is no further undo info.

I said that it might solve part of your problem.  The question is
whether the 3M of undo is legitimate.  Take a look at what is in that
buffer.  Does the huge size of the buffer seem legitimate, because
there really is that much info to save?  I guess that you know that
you can produce the buffer using `M-x desktop-save'.

I believe that my patch should be applied regardless of whether the 3M
is legitimate, but if it is not, additional changes may be necessary.

===File ~/desktop.el-diff===
*** desktop.el  10 Feb 2006 08:34:46 -0600  1.99
--- desktop.el  11 May 2006 20:42:50 -0500  
***
*** 766,804 
(eager desktop-restore-eager)
(buf (get-buffer-create *desktop*)))
(set-buffer buf)
!   (erase-buffer)
  
!   (insert
! ;; -*- mode: emacs-lisp; coding: emacs-mule; -*-\n
! desktop-header
! ;; Created  (current-time-string) \n
! ;; Desktop file format version  desktop-file-version \n
! ;; Emacs version  emacs-version \n\n
! ;; Global section:\n)
!   (mapc (function desktop-outvar) desktop-globals-to-save)
!   (if (memq 'kill-ring desktop-globals-to-save)
! (insert
!   (setq kill-ring-yank-pointer (nthcdr 
!   (int-to-string (- (length kill-ring) (length 
kill-ring-yank-pointer)))
!kill-ring))\n))
  
!   (insert \n;; Buffer section -- buffers listed in same order as in 
buffer list:\n)
!   (mapc #'(lambda (l)
! (when (apply 'desktop-save-buffer-p l)
!   (insert (
!   (if (or (not (integerp eager))
!   (unless (zerop eager)
! (setq eager (1- eager))
! t))
!   desktop-create-buffer
! desktop-append-buffer-args)
!
!   desktop-file-version)
!   (mapc #'(lambda (e)
! (insert \n   (desktop-value-to-string e)))
! l)
!   (insert )\n\n)))
! info)
(setq default-directory dirname)
(let ((coding-system-for-write 'emacs-mule))
  (write-region (point-min) (point-max) filename nil 'nomessage
--- 766,807 
(eager desktop-restore-eager)
(buf (get-buffer-create *desktop*)))
(set-buffer buf)
!   (when (consp buffer-undo-list)
!   (setq buffer-undo-list nil))
!   (let ((buffer-undo-list t))
!   (erase-buffer)
  
!   (insert
!;; -*- mode: emacs-lisp; coding: emacs-mule; -*-\n
!desktop-header
!;; Created  (current-time-string) \n
!;; Desktop file format version  desktop-file-version \n
!;; Emacs version  emacs-version \n\n
!;; Global section:\n)
!   (mapc (function desktop-outvar) desktop-globals-to-save)
!   (if (memq 'kill-ring desktop-globals-to-save)
!   (insert
!(setq kill-ring-yank-pointer (nthcdr 
!(int-to-string (- (length kill-ring) (length 
kill-ring-yank-pointer)))
! kill-ring))\n))
  
!   (insert \n;; Buffer section -- buffers listed in same order as in 
buffer list:\n)
!   (mapc #'(lambda (l)
! (when (apply 'desktop-save-buffer-p l)
!   (insert (
!   (if (or (not (integerp eager))
!   (unless (zerop eager)
! (setq eager (1- eager))
! t))
!   desktop-create-buffer
! desktop-append-buffer-args)
!
!   desktop-file-version)
!   (mapc #'(lambda (e)
! (insert \n   (desktop-value-to-string e)))
! l)
!   (insert )\n\n)))
! info))
(setq default-directory dirname)
(let ((coding-system-for-write 'emacs-mule))
  (write-region (point-min) (point-max) filename nil 'nomessage

Re: Big desktop undo buffer crashes Emacs

2006-05-11 Thread Luc Teirlinck
From my previous reply:

   I said that it might solve part of your problem.  The question is
   whether the 3M of undo is legitimate.  Take a look at what is in that
   buffer.  Does the huge size of the buffer seem legitimate, because
   there really is that much info to save?  I guess that you know that
   you can produce the buffer using `M-x desktop-save'.

Well, the size of the undo info is not necessarily related to the size
of the buffer.  In my setup, after `M-x desktop-save', I get a
*desktop* buffer of size 2943, but my buffer-undo-list (_without_ my
patch applied) is very small:

(nil
 (1 . 2944)
 (t 0 . 0))

I guess that if you created the *desktop* buffer and did 
`C-h v buffer-undo-list' in it, you would get a really huge *Help*
buffer, assuming it would not make your Emacs crash.

Sincerely,

Luc.





___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-05-11 Thread Luc Teirlinck
I believe that we can forget about that potential second undo problem.
It is apparently when you do `M-x desktop-save' while you already have
a *desktop* buffer that you can accumulate a large undo entry
proportional to the size of the buffer.  This seems to happen as a
result of the call to `erase-buffer'.  But after my patch, recording
of undo info during the call to `erase-buffer' is disabled anyway.  So
the problem should be completely solved.

Sincerely,

Luc.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-05-11 Thread Luc Teirlinck
I mangled Bill's email address in my previous reply, re-included
below.  So if you follow up, please follow up on this version rather
than the original to prevent CC-ing a mangled address:

I believe that we can forget about that potential second undo problem.
It is apparently when you do `M-x desktop-save' while you already have
a *desktop* buffer that you can accumulate a large undo entry
proportional to the size of the buffer.  This seems to happen as a
result of the call to `erase-buffer'.  But after my patch, recording
of undo info during the call to `erase-buffer' is disabled anyway.  So
the problem should be completely solved.

Sincerely,

Luc.



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-05-11 Thread Stefan Monnier
 !   (when (consp buffer-undo-list)
 ! (setq buffer-undo-list nil))
 !   (let ((buffer-undo-list t))
 ! (erase-buffer)

Why not just (buffer-disable-undo) ??


Stefan


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-05-11 Thread Bill Wohler
Luc Teirlinck [EMAIL PROTECTED] wrote:

 From my previous reply:
 
I said that it might solve part of your problem.  The question is
whether the 3M of undo is legitimate.  Take a look at what is in that
buffer.  Does the huge size of the buffer seem legitimate, because
there really is that much info to save?  I guess that you know that
you can produce the buffer using `M-x desktop-save'.
 
 Well, the size of the undo info is not necessarily related to the size
 of the buffer.  In my setup, after `M-x desktop-save', I get a
 *desktop* buffer of size 2943, but my buffer-undo-list (_without_ my
 patch applied) is very small:
 
 (nil
  (1 . 2944)
  (t 0 . 0))
 
 I guess that if you created the *desktop* buffer and did 
 `C-h v buffer-undo-list' in it, you would get a really huge *Help*
 buffer, assuming it would not make your Emacs crash.

Right now my desktop buffer is 32 kB; the size of the *Help* buffer you
describe is 68 kB. Running desktop-save did not change the size of
either (much, the *Help* buffer grew by 200 bytes after running `C-h v
buffer-undo-list' again).

By the way, the only two desktop-related items in my .emacs are turning
on desktop-save-mode (which is probably obvious ;-) and this:

  (run-at-time 60 300 'desktop-save ~) ;it would be better to catch HUP and
 ;call desktop-save before exiting

I've yet to write the code to catch a kill or quit and run desktop-save
on an as-needed basis rather than regularly--maybe someone can volunteer
a trick there--but still, why would the buffer go from 68 kB to 3 MB
overnight? I think this is the only cron job *I've* set up.

Still, I think Stefan might be correct. What does it mean to have undo
in the *desktop* buffer in the first place?

-- 
Bill Wohler [EMAIL PROTECTED]  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-05-11 Thread Luc Teirlinck
Stefan Monnier wrote:

!   (when (consp buffer-undo-list)
!  (setq buffer-undo-list nil))
!   (let ((buffer-undo-list t))
!  (erase-buffer)

   Why not just (buffer-disable-undo) ??

Because I want to allow people who visit the buffer to undo any
changes they deliberately or inadvertently make to it.

Sincerely,

Luc.



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-05-11 Thread Richard Stallman
OK, it's back. Here's the message:

   Buffer `*desktop*' undo info is 3159101 bytes long; discard it? (yes or 
no)

Does this change give good results?
(Lars, do you object?)


*** desktop.el  11 Feb 2006 11:43:50 -0500  1.99
--- desktop.el  11 May 2006 22:14:05 -0400  
***
*** 766,771 
--- 766,772 
(eager desktop-restore-eager)
(buf (get-buffer-create *desktop*)))
(set-buffer buf)
+   (buffer-disable-undo)
(erase-buffer)
  
(insert


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-05-11 Thread Bill Wohler
Luc Teirlinck [EMAIL PROTECTED] wrote:

 Bill Wohler wrote:
 
By the way, the only two desktop-related items in my .emacs are turning
on desktop-save-mode (which is probably obvious ;-) and this:
 
  (run-at-time 60 300 'desktop-save ~) ;it would be better to catch HUP 
 and
   ;call desktop-save before exiting
 
 The latter was your problem.   From `(elisp)Timers':
 
  It is usually a bad idea for timer functions to alter buffer
   contents.  When they do, they usually should call `undo-boundary' both
   before and after changing the buffer, to separate the timer's changes
   from user commands' changes and prevent a single undo entry from
   growing to be quite large.
 
 So it is no surprise that you accumulated such a large single undo entry.

Thanks for the information. Since I don't understand the mechanics of
desktop, I have a couple of questions about that. First, I thought
desktop-save just saves the buffer to a file. Is it really altering the
the *desktop* buffer? Oh, running desktop-save a couple of times shows
that it at least updates the Created header field. OK, desktop-save must
gather buffer information, write it to *desktop*, and *then* save it to
a file. Right?

Second, I also don't understand the mechanics of undo very well. I was
under the impression that undo-boundary only grouped a set of changes
into a single undo entry. As I sit here writing, only a limited amount
of changes are saved and at some point the oldest undo information will
be discarded. How is the timer different?

Interesting, as I typed this, the timer had run a couple of times (I was
thinking and trying to understand desktop and undo). I re-ran `C-h v
buffer-undo-list' a few times too. It just produced buffers with only 35
kB, not 68 kB.

Right now my desktop buffer is 32 kB;
 
 So that is approximately 32 kB every five minutes.  After eight hours,
 you exceed 3M.
 
 Anyway, my patch, or disabling undo, completely gets rid of this problem.

So, which one should I apply? Before I fix my timer ;-).

If the *desktop* buffer is ephemeral and recreated when desktop-save is
run, it seems that disabling undo is the proper course of action.
Otherwise, preserving undo while protecting against abuse would be wise.
What do you think?

-- 
Bill Wohler [EMAIL PROTECTED]  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-05-11 Thread Bill Wohler
Luc Teirlinck [EMAIL PROTECTED] wrote:

 I now realize that *desktop* is not a file visiting buffer, so it does
 not matter if people mess it up.  Thus one can indeed just disable
 undo rather than applying the patch I proposed.  But that user visible
 *desktop* buffer is confusing, especially if the user also has a
 buffer visiting his desktop-base-file-name, since the two buffers are
 identical.  Is there any reason not to rename *desktop* to
  *desktop (with a leading space) and kill it after it is written to
 disk?  Is there any reason to keep this buffer hanging around
 consuming some memory and being user visible?

Thanks, Luc. This exact thought coursed through my mind. Would Mr.
Desktop please chime in?
 
-- 
Bill Wohler [EMAIL PROTECTED]  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-05-02 Thread Bill Wohler
Richard Stallman [EMAIL PROTECTED] wrote:

 Every morning for the past weeks, I've had a message in my minibuffer
 that roughly goes, Desktop undo buffer is 3+ MB, discard? (yes or no).
 I've been saying yes. This morning, feeling snarky, I said no and
 Emacs crashed.
 
 Could you please provide the precise text of the message?
 The message includes a buffer name; what is the buffer name?

I haven't seen the prompt in a couple of days. Could a recent update
have suppressed it?

-- 
Bill Wohler [EMAIL PROTECTED]  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-04-30 Thread Bill Wohler
Richard Stallman [EMAIL PROTECTED] wrote:

 Every morning for the past weeks, I've had a message in my minibuffer
 that roughly goes, Desktop undo buffer is 3+ MB, discard? (yes or no).
 I've been saying yes. This morning, feeling snarky, I said no and
 Emacs crashed.
 
 Could you please provide the precise text of the message?
 The message includes a buffer name; what is the buffer name?

Weird, a copy of the message was *not* saved in the *Messages* buffer.
I'll write it down on a piece of paper tomorrow.

-- 
Bill Wohler [EMAIL PROTECTED]  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-04-30 Thread Luc Teirlinck
Bill Wohler wrote:

   Weird, a copy of the message was *not* saved in the *Messages* buffer.

It is not a message, but a yes-or-no-p prompt.

Sincerely,

Luc.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-04-30 Thread Bill Wohler
Luc Teirlinck [EMAIL PROTECTED] wrote:

 Bill Wohler wrote:
 
Weird, a copy of the message was *not* saved in the *Messages* buffer.
 
 It is not a message, but a yes-or-no-p prompt.

Oh, right. Duh.

Not the first time I've said something stupid before coffee. Definitely
not a morning person.

Will transcribe the message tomorrow.

-- 
Bill Wohler [EMAIL PROTECTED]  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-04-29 Thread Bill Wohler
Bill Wohler [EMAIL PROTECTED] writes:

 Every morning for the past weeks, I've had a message in my minibuffer
 that roughly goes, Desktop undo buffer is 3+ MB, discard? (yes or no).
 I've been saying yes. This morning, feeling snarky, I said no and
 Emacs crashed.

I said no to that question twice this morning, and Emacs did not
crash.

 What is this Desktop undo buffer by the way? And why does Emacs keep
 asking me this question?

I'd still like to know the answer to these questions. Thanks.

-- 
Bill Wohler [EMAIL PROTECTED]  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-04-29 Thread Henrik Enberg
Bill Wohler [EMAIL PROTECTED] writes:

 What is this Desktop undo buffer by the way? And why does Emacs keep
 asking me this question?
 
 I'd still like to know the answer to these questions. Thanks.

`undo-outer-limit' might provide some explanation.  admin/FOR-RELEASE
has an item about `undo-ask-before-discard' too.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-04-29 Thread Luc Teirlinck
Bill Wohler wrote:

   Bill Wohler [EMAIL PROTECTED] writes:

Every morning for the past weeks, I've had a message in my minibuffer
that roughly goes, Desktop undo buffer is 3+ MB, discard? (yes or no).
I've been saying yes. This morning, feeling snarky, I said no and
Emacs crashed.

   I said no to that question twice this morning, and Emacs did not
   crash.

Emacs only crashes if the size of the undo info is big enough to
cause memory overflow.  So the fact that if you answer no, Emacs
sometimes crashes and sometimes not is to be expected.

Also, if you leave Emacs running while the question is being asked and
leave your computer without answering the question for a relatively
long time, memory leakage will occur.

What is this Desktop undo buffer by the way?

I do not use desktop.  But my impression is that desktop should
disable undo somewhere.  Somebody who uses and knows desktop should
take a look at that.

   And why does Emacs keep asking me this question?

For debugging purposes.  I do not know desktop well enough, but this
seems to be a bug in desktop (failing to disable undo).  Once Emacs-22
is released, the undo info will be discarded automatically, to prevent
crashes and memory leakage.

Sincerely,

Luc.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-04-29 Thread Richard Stallman
Every morning for the past weeks, I've had a message in my minibuffer
that roughly goes, Desktop undo buffer is 3+ MB, discard? (yes or no).
I've been saying yes. This morning, feeling snarky, I said no and
Emacs crashed.

Could you please provide the precise text of the message?
The message includes a buffer name; what is the buffer name?


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Big desktop undo buffer crashes Emacs

2006-04-29 Thread Richard Stallman
What is this Desktop undo buffer by the way?

I do not use desktop.  But my impression is that desktop should
disable undo somewhere.  Somebody who uses and knows desktop should
take a look at that.

It is really fishy that Desktop does so much consing.
We need to figure out why.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug