Re: [Engine-devel] Jenkins testing of patch what do we want to check?

2012-08-09 Thread Eyal Edri


- Original Message -
> From: "Itamar Heim" 
> To: "Robert Middleswarth" 
> Cc: engine-devel@ovirt.org, "infra" 
> Sent: Thursday, August 9, 2012 8:37:03 AM
> Subject: Re: [Engine-devel] Jenkins testing of patch what do we want to   
> check?
> 
> On 08/09/2012 05:05 AM, Robert Middleswarth wrote:
> > Unlike vdsm were the entire unit test takes 2 min to process the
> > Engine
> > has several jobs many that take longer then 15 min to run. So here
> > is
> > the questions.
> >
> > What current jobs do we want to run on each patch submission?
> >
> 
> all...
> developers should verify the default unitests, or specific tests for
> areas they are touching.
> but jenkins should run the findbugs, gwt compilation and enable all
> unitests.
> 

like itamar said.
we should run every job we can to verify code with to avoid regressions and 
errors pre-commit.

- create/upgrade db
- checkstyle, findbugs, unit-tests, dao-tests... 
- maybe animal sniffer - to verify backward compatibility to jdk6

We can't do it with current jenkins resources, that's the main reason why
we need more slaves. 

> 
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Proposal to add Juan Hernandez as maintainer to packaging

2012-08-12 Thread Eyal Edri
+1 for it without a doubt.

- Original Message -
> From: "Itamar Heim" 
> To: "Barak Azulay" , "Eyal Edri" , 
> "Ofer Schreiber" 
> Cc: engine-devel@ovirt.org
> Sent: Sunday, August 12, 2012 1:19:50 AM
> Subject: Proposal to add Juan Hernandez as maintainer to packaging
> 
> Juan has worked on oVirt for the past 12 months, with considerable
> contribution to the packaging and deployment parts.
> he also almost single handedly packaged ovirt engine for fedora and
> the
> new ovirt-engine service for fedora.
> 
> I'd like to propose Juan as a maintainer of the packaging subproject
> of
> ovirt-engine.
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Jenkins testing.

2012-08-14 Thread Eyal Edri
Great job!

I know it required a great effort and time to make this work so kudos for 
making it happen.

Eyal.

- Original Message -
> From: "Robert Middleswarth" 
> To: "infra" , engine-devel@ovirt.org, "VDSM Project 
> Development"
> , "arch" 
> Sent: Tuesday, August 14, 2012 8:43:06 AM
> Subject: Jenkins testing.
> 
> After a few false starts it looks like we have per patch testing
> working
> on VDSM, oVirt-engine, oVirt-engine-sdk and oVirt-engine-cli.  There
> are
> 3 status a patch can get.  1) Success - Means the patch ran though
> the
> tests without issue.  2) Failure - Means the tests failed.  3)
> Aborted -
> Generally means the submitter is not in the whitelist and the tests
> were
> never run.  If you have any questions please feel free to ask.
> 
> --
> Thanks
> Robert Middleswarth
> @rmiddle (twitter/IRC)
> 
> ___
> Infra mailing list
> in...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [vdsm] Jenkins testing.

2012-08-14 Thread Eyal Edri


- Original Message -
> From: "Deepak C Shetty" 
> To: "Deepak C Shetty" 
> Cc: engine-devel@ovirt.org, "arch" , "VDSM Project 
> Development" ,
> "infra" 
> Sent: Tuesday, August 14, 2012 11:54:31 AM
> Subject: Re: [Engine-devel] [vdsm] Jenkins testing.
> 
> On 08/14/2012 12:52 PM, Deepak C Shetty wrote:
> > On 08/14/2012 11:13 AM, Robert Middleswarth wrote:
> >> After a few false starts it looks like we have per patch testing
> >> working on VDSM, oVirt-engine, oVirt-engine-sdk and
> >> oVirt-engine-cli.  There are 3 status a patch can get.  1) Success
> >> -
> >> Means the patch ran though the tests without issue.  2) Failure -
> >> Means the tests failed.  3) Aborted - Generally means the
> >> submitter
> >> is not in the whitelist and the tests were never run.  If you have
> >> any questions please feel free to ask.
> >>
> > So what is needed for the submitted to be in whitelist ?
> > I once for Success for few of my patches.. then got failure for
> > some
> > other patch( maybe thats due to the false starts u had) and then
> > for
> > the latest patch of mine, it says aborted.
> >
> > So not sure if i am in whitelist or not ?
> > If not, what do i need to do to be part of it ?
> > If yes, why did the build abort for my latest patch ?
> >
> Pls see http://gerrit.ovirt.org/#/c/6856/
> For patch1 it says build success, for patch 2, it says aborted.. why
> ?
> 

it's because your email address wasn't in the jenkins-whitelist.txt file.
this file includes emails address for users that jenkins will allow running 
test jobs on thier patches.
this was introduced as a way for defending the jenkins from malicious users 
that might send harmful patches to jenkins.

i've added you to the whitelist, you should be ok now.

the list was generated automaticly from git log, so it still might missing 
known people,
if anyone sees this aborted msg in the gerrit, please contact infra team so he 
can be added to the whitelist.

Eyal.

> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Any way to break the dao_unit_tests up?

2012-08-20 Thread Eyal Edri


- Original Message -
> From: "Itamar Heim" 
> To: "Robert Middleswarth" 
> Cc: "Yaniv Kaul" , engine-devel@ovirt.org, "Eyal Edri" 
> 
> Sent: Monday, August 20, 2012 10:26:10 AM
> Subject: Re: [Engine-devel] Any way to break the dao_unit_tests up?
> 
> On 08/20/2012 09:40 AM, Robert Middleswarth wrote:
> > On 08/20/2012 02:02 AM, Yaniv Kaul wrote:
> >> On 08/19/2012 11:03 PM, Robert Middleswarth wrote:
> >>> The DAO unit tests take twice as long as the rest of the test to
> >>> run
> >>> is there any way to break them up into two pieces?
> >>>
> >>>
> >>
> >> Can they run in parallel to the rest of the tests?
> >> May be a KISS solution for this problem.
> >> Y.
> >>
> > Yaniv,
> >
> > That is what I am doing but the current test can't be ran in
> > parallel on
> > the same host and the jobs backup several hours and none of the
> > results
> 
> actually, why can't the test run in parallel on same host?

i think we run into errors when trying to do it.. 
it's worth trying to do again and see if the errors are due to environment 
issues or problems in the tests themselfs.

> 
> > get written  to Gerrit until all the jobes finishes.
> >
> 
> 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Any way to break the dao_unit_tests up?

2012-08-20 Thread Eyal Edri


- Original Message -
> From: "Itamar Heim" 
> To: "Eyal Edri" 
> Cc: "Yaniv Kaul" , engine-devel@ovirt.org, "Robert 
> Middleswarth" 
> Sent: Monday, August 20, 2012 10:31:15 AM
> Subject: Re: [Engine-devel] Any way to break the dao_unit_tests up?
> 
> On 08/20/2012 10:30 AM, Eyal Edri wrote:
> >
> >
> > - Original Message -
> >> From: "Itamar Heim" 
> >> To: "Robert Middleswarth" 
> >> Cc: "Yaniv Kaul" , engine-devel@ovirt.org, "Eyal
> >> Edri" 
> >> Sent: Monday, August 20, 2012 10:26:10 AM
> >> Subject: Re: [Engine-devel] Any way to break the dao_unit_tests
> >> up?
> >>
> >> On 08/20/2012 09:40 AM, Robert Middleswarth wrote:
> >>> On 08/20/2012 02:02 AM, Yaniv Kaul wrote:
> >>>> On 08/19/2012 11:03 PM, Robert Middleswarth wrote:
> >>>>> The DAO unit tests take twice as long as the rest of the test
> >>>>> to
> >>>>> run
> >>>>> is there any way to break them up into two pieces?
> >>>>>
> >>>>>
> >>>>
> >>>> Can they run in parallel to the rest of the tests?
> >>>> May be a KISS solution for this problem.
> >>>> Y.
> >>>>
> >>> Yaniv,
> >>>
> >>> That is what I am doing but the current test can't be ran in
> >>> parallel on
> >>> the same host and the jobs backup several hours and none of the
> >>> results
> >>
> >> actually, why can't the test run in parallel on same host?
> >
> > i think we run into errors when trying to do it..
> > it's worth trying to do again and see if the errors are due to
> > environment issues or problems in the tests themselfs.
> 
> if you try to use same schema name, you will fail, but i think we
> fixed
> the dao tests to run in parallel in the past by setting the schema
> name
> per run, etc.
> 

we're using a diff db name, if that's what you mean.
i meant some random tests were failing, but lets check it again and verify it 
is the case.

___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] JUnit tests in 'bll' project

2012-08-29 Thread Eyal Edri


- Original Message -
> From: "Shireesh Anjal" 
> To: engine-devel@ovirt.org
> Sent: Wednesday, August 29, 2012 1:19:16 PM
> Subject: [Engine-devel] JUnit tests in 'bll' project
> 
> Hi,
> 
> When I do a full build of oVirt engine (mvn clean install
> -Pgwtdev,gwt-admin,dep,enable-dao-tests), it seems that the JUnit
> tests
> in project 'bll' are not executed. Is this done intentionally? If
> yes,
> is there a simple way to execute them using mvn ?

there is a maven profile enable-bll-itests from the bll submodule dir.

hanv't run it in a while so it might not work... 

> 
> Thanks,
> Shireesh
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] commit breaks ovirt-engine due to compilation error

2012-09-09 Thread Eyal Edri
this commit break ovirt-engine on jenkins.ovirt.org:

http://jenkins.ovirt.org/job/ovirt_engine_animal_sniffer_check/425/org.ovirt.engine.core$vdsbroker/changes#detail0

core: add vdsName to vdsBroker log info (#853883) (details)
Commit 35c2e7ceb5109c9349e3699c3f53414cbe0b4c4e by ybronhei
core: add vdsName to vdsBroker log info (#853883)

https://bugzilla.redhat.com/show_bug.cgi?id=853883

Logger gets VdsCommandBase.toString() method's output,
this patch adds call to getAdditionalInformation from
toString to add to log string VdsName.

Change-Id: Ieb0589bb5f5e157c04f85e46f6769d66ef98b2d1
Signed-off-by: Yaniv Bronhaim 


please check,

Eyal.










[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ vdsbroker ---
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/home/jenkins/workspace/ovirt_engine_animal_sniffer_check/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RemoveVdsVDSCommand.java:[5,7]
 error: RemoveVdsVDSCommand is not abstract and does not override abstract 
method getAdditionalInformation() in VDSCommandBase
[ERROR] 
/home/jenkins/workspace/ovirt_engine_animal_sniffer_check/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/UpdateVmDynamicDataVDSCommand.java:[5,7]
 error: UpdateVmDynamicDataVDSCommand is not abstract and does not override 
abstract method getAdditionalInformation() in VDSCommandBase
[ERROR] 
/home/jenkins/workspace/ovirt_engine_animal_sniffer_check/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/FailedToRunVmVDSCommand.java:[5,7]
 error: FailedToRunVmVDSCommand is not abstract and does not override abstract 
method getAdditionalInformation() in VDSCommandBase
[ERROR] 
/home/jenkins/workspace/ovirt_engine_animal_sniffer_check/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ActivateVdsVDSCommand.java:[5,7]
 error: ActivateVdsVDSCommand is not abstract and does not override abstract 
method getAdditionalInformation() in VDSCommandBase
[ERROR] 
/home/jenkins/workspace/ovirt_engine_animal_sniffer_check/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java:[28,7]
 error: CreateVmVDSCommand is not abstract and does not override abstract 
method getAdditionalInformation() in VDSCommandBase
[ERROR] 
/home/jenkins/workspace/ovirt_engine_animal_sniffer_check/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/UpdateVdsVMsClearedVDSCommand.java:[5,7]
 error: UpdateVdsVMsClearedVDSCommand is not abstract and does not override 
abstract method getAdditionalInformation() in VDSCommandBase
[ERROR] 
/home/jenkins/workspace/ovirt_engine_animal_sniffer_check/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/AddVdsVDSCommand.java:[12,7]
 error: AddVdsVDSCommand is not abstract and does not override abstract method 
getAdditionalInformation() in VDSCommandBase
[ERROR] 
/home/jenkins/workspace/ovirt_engine_animal_sniffer_check/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java:[13,7]
 error: SetVdsStatusVDSCommand is not abstract and does not override abstract 
method getAdditionalInformation() in VDSCommandBase
[ERROR] 
/home/jenkins/workspace/ovirt_engine_animal_sniffer_check/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResumeVDSCommand.java:[10,7]
 error: ResumeVDSCommand is not abstract and does not override abstract method 
getAdditionalInformation() in VDSCommandBase
[ERROR] 
/home/jenkins/workspace/ovirt_engine_animal_sniffer_check/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java:[18,7]
 error: DestroyVmVDSCommand is not abstract and does not override abstract 
method getAdditionalInformation() in VDSCommandBase
[ERROR] 
/home/jenkins/workspace/ovirt_engine_animal_sniffer_check/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java:[21,7]
 error: MigrateVDSCommand is not abstract and does not override abstract method 
getAdditionalInformation() in VDSCommandBase
[ERROR] 
/home/jenkins/workspace/ovirt_engine_animal_sniffer_check/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/UpdateVdsDynamicDataVDSCommand.java:[5,7]
 error: UpdateVdsDynamicDataVDSCommand is not abstract and does not override 
abstract method getAdditionalInformation() in VDSCommandBase
[INFO] 12 errors 
[INFO] -
mojoFailed org.apache.maven.plugins:maven-compiler-plugin:2.3.2(default-compile)
projectFailed org.ovirt.engine.core:vdsbroker:3.1.0
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mail

Re: [Engine-devel] is gerrit.ovirt.org down?

2012-09-12 Thread Eyal Edri


- Original Message -
> From: "Itamar Heim" 
> To: "Asaf Shakarchi" 
> Cc: "Alon Bar-Lev" , "Shireesh Anjal" , 
> engine-devel@ovirt.org, "VDSM Project
> Development" , "Shu Ming" 
> , "Eyal Edri"
> 
> Sent: Wednesday, September 12, 2012 6:34:56 PM
> Subject: Re: [Engine-devel] is gerrit.ovirt.org down? 
> 
> On 09/12/2012 06:23 PM, Asaf Shakarchi wrote:
> > It happens from time to time, restart is required, Itamar only.
> 
> restarted.
> eyal - can we make progress on the jenkins job with permission to
>  more
> people to restart gerrit?

the job is ready 
http://jenkins.ovirt.org/view/system-monitoring/job/restart_gerrit_service
but i need to have jenkins user access to gerrit server + sudo access to run 
'service' restart... 

it has access to www.ovirt.org but not to gerrit.ovirt.org. 

> others - please email infra on gerrit issues (well, me personally
> always
> help as well)
> 
> >
> > - Original Message -
> >>
> >> Yes, I am experiencing this too...
> >>
> >> Itamar?
> >>
> >> - Original Message -
> >>> From: "Shu Ming" 
> >>> To: "Alon Bar-Lev" 
> >>> Cc: "Shireesh Anjal" , engine-devel@ovirt.org,
> >>> "VDSM Project Development"
> >>> 
> >>> Sent: Wednesday, September 12, 2012 5:50:14 PM
> >>> Subject: Re: [Engine-devel] is gerrit.ovirt.org down? 
> >>>
> >>> It seems gerrit has downed for several times recently. Is there
> >>> any
> >>> special reason?
> >>> 于 2012-9-12 22:45, Alon Bar-Lev:
> >>>> yes.
> >>>>
> >>>> - Original Message -
> >>>>> From: "Shireesh Anjal" 
> >>>>> To: engine-devel@ovirt.org
> >>>>> Sent: Wednesday, September 12, 2012 5:43:35 PM
> >>>>> Subject: [Engine-devel] is gerrit.ovirt.org down? 
> >>>>>
> >>>>>
> >>>>> ___
> >>>>> Engine-devel mailing list
> >>>>> Engine-devel@ovirt.org
> >>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>>>
> >>>> ___
> >>>> Engine-devel mailing list
> >>>> Engine-devel@ovirt.org
> >>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>>>
> >>>
> >>>
> >>> --
> >>> ---
> >>> 舒明 Shu Ming
> >>> Open Virtualization Engineerning; CSTL, IBM Corp.
> >>> Tel: 86-10-82451626  Tieline: 9051626 E-mail: shum...@cn.ibm.com
> >>> or
> >>> shum...@linux.vnet.ibm.com
> >>> Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian
> >>> District, Beijing 100193, PRC
> >>>
> >>>
> >>>
> >> ___
> >> Engine-devel mailing list
> >> Engine-devel@ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>
> 
> 
>
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] jenkins ovirt-engine_create_rpms project

2012-10-11 Thread Eyal Edri
thanks for pointing that out!

for some reason the job was missing the poll scm value, and didn't have a 
trigger.

it will run run on every commit to ovirt-engine.

Eyal.

- Original Message -
> From: ov...@qip.ru
> To: engine-devel@ovirt.org
> Sent: Tuesday, October 9, 2012 10:18:54 AM
> Subject: [Engine-devel] jenkins ovirt-engine_create_rpms project
> 
> Hi,
> 
> last start of ovirt-engine_create_rpms job was more than one month
> ago, may be it is possible to start ovirt-engine_create_rpms once a
> day before publish_ovirt_rpms_nightly ?
> 
> 
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] libosinfo integration

2012-10-11 Thread Eyal Edri


- Original Message -
> From: "Roy Golan" 
> To: engine-devel@ovirt.org
> Sent: Thursday, October 11, 2012 12:45:58 PM
> Subject: Re: [Engine-devel] libosinfo integration
> 
> On 10/11/2012 12:39 PM, Alon Bar-Lev wrote:
> >
> > - Original Message -
> >> From: "Ewoud Kohl van Wijngaarden"
> >> 
> >> To: engine-devel@ovirt.org
> >> Sent: Thursday, October 11, 2012 12:38:12 PM
> >> Subject: Re: [Engine-devel] libosinfo integration
> >>
> >> On Thu, Oct 11, 2012 at 12:22:51PM +0200, Roy Golan wrote:
> >>> After considering the pros and cons and making poc's I've decided
> >>> to
> >>> take the direct XML and java pure implementation.
> >>> http://gerrit.ovirt.org/#/c/8472/
> >>> http://gerrit.ovirt.org/#/c/8473/
> >> Any particular reason I have no permission to view these?
> > I cannot either... it must be a draft.
> > We should solve the drafts permission issues and make them public.
> Eedri do you know how to solve this?

don't have permissions to gerrit.ovirt.org.
you should ask on in...@ovirt.org

> I'll just add you manually meanwhile.
> > Alon.
> > ___
> > Engine-devel mailing list
> > Engine-devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] jenkin­s ovirt-engine_create_rpm­s project

2012-10-11 Thread Eyal Edri
not sure why jenkins doesn't show them,
but you can see from the rpm name 
ovirt-engine-3.1.0-3.20121011.git38912fc.fc17.noarch.rpm

it's built from the HEAD git SHA 38912fc89fb3acc8411e5d3332b2ab81e3cafc22

- Original Message -
> From: ov...@qip.ru
> To: engine-devel@ovirt.org
> Sent: Thursday, October 11, 2012 3:18:04 PM
> Subject: Re: [Engine-devel] jenkin­s ovirt-engine_create_rpm­s project
> 
> thanks, Eyal
> 
> but why there are no chages in #1605 build, where are all commits
> since 16.08.2012?
>   
> 
> Чтв 11 Окт 2012 13:00:34 +0400, Eyal Edri  написал:
> > thanks for pointing that out!
> > 
> > for some reason the job was missing the poll scm value, and didn't
> > have a trigger.
> > 
> > it will run run on every commit to ovirt-engine.
> > 
> > Eyal.
> > 
> > - Original Message -
> > > From: ov...@qip.ru
> > > To: engine-devel@ovirt.org
> > > Sent: Tuesday, October 9, 2012 10:18:54 AM
> > > Subject: [Engine-devel] jenkins ovirt-engine_create_rpms project
> > > 
> > > Hi,
> > > 
> > > last start of ovirt-engine_create_rpms job was more than one
> > > month
> > > ago, may be it is possible to start ovirt-engine_create_rpms once
> > > a
> > > day before publish_ovirt_rpms_nightly ?
> > > 
> > > 
> > > ___
> > > Engine-devel mailing list
> > > Engine-devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > >
> 
> --
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Proposal to add Allon Mureinik as maintainer to engine core

2012-11-14 Thread Eyal Edri
+1

- Original Message -
> From: "Itamar Heim" 
> To: engine-devel@ovirt.org
> Sent: Wednesday, November 14, 2012 6:12:09 AM
> Subject: [Engine-devel] Proposal to add Allon Mureinik as maintainer to   
> engine core
> 
> Allon has worked on oVirt for the past 10 months.
> With 534 patches ranging from cleanups, to complex features like user
> level api and storage live migration. In addition, Allon has been
> instrumental in the number of patch reviews he has done.
> 
> I'd like to propose Allon as a maintainer of engine core.
> 
> Thanks,
> Itamar
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] [Jenkins] outage

2012-11-20 Thread Eyal Edri
fyi,

due to an outage and network issues jenkins.ovirt.org was restarted.

failing jobs should now return to normal state.

Eyal Edri.
oVirt Infra Team
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] Proposal of Alon bar-lev as oVirt jenkins power user

2012-11-22 Thread Eyal Edri
Hi,

To continue our new tradition of delegating power users for various oVirt sub 
project management in jenkins,

I want to propose Alon bar-lev as power user for oVirt jenkins.
Alon is well known within the oVirt community, and been contributing it in the 
past months.

Alon has contributed code to many oVirt projects including massive re-factoring 
of the bootstrap process and
numerous patches on other oVirt projects, Latest projects are otopi and 
ovirt-host-deploy.

He is very technical with previous knowledge of Jenkins.

as a power user he will be to:

1. create/update new jobs in jenkins.ovirt.org
2. run/trigger builds
3. run manual gerrit trigger jobs.


i vote +1.

please vote confidence with +1 or -1 for not.

thanks,

Eyal Edri.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Proposal of Alon bar-lev as oVirt jenkins power user

2012-11-25 Thread Eyal Edri
OK,

seems like only +1 and no -1.

approved alon as power user.

alon, you can start creating your jobs,
if you have any questions, please direct them to in...@ovirt.org.

i will send you the initial credentials off the list.

enjoy :)

eyal.

- Original Message -
> From: "Igor Lvovsky" 
> To: "Eyal Edri" 
> Cc: engine-devel@ovirt.org, "infra" 
> Sent: Sunday, November 25, 2012 1:44:29 PM
> Subject: Re: [Engine-devel] Proposal of Alon bar-lev as oVirt jenkins power 
> user
> 
> +1
> 
> - Original Message -
> > From: "Eyal Edri" 
> > To: "infra" 
> > Cc: engine-devel@ovirt.org
> > Sent: Thursday, November 22, 2012 4:16:37 PM
> > Subject: [Engine-devel] Proposal of Alon bar-lev as oVirt jenkins
> > power user
> > 
> > Hi,
> > 
> > To continue our new tradition of delegating power users for various
> > oVirt sub project management in jenkins,
> > 
> > I want to propose Alon bar-lev as power user for oVirt jenkins.
> > Alon is well known within the oVirt community, and been
> > contributing
> > it in the past months.
> > 
> > Alon has contributed code to many oVirt projects including massive
> > re-factoring of the bootstrap process and
> > numerous patches on other oVirt projects, Latest projects are otopi
> > and ovirt-host-deploy.
> > 
> > He is very technical with previous knowledge of Jenkins.
> > 
> > as a power user he will be to:
> > 
> > 1. create/update new jobs in jenkins.ovirt.org
> > 2. run/trigger builds
> > 3. run manual gerrit trigger jobs.
> > 
> > 
> > i vote +1.
> > 
> > please vote confidence with +1 or -1 for not.
> > 
> > thanks,
> > 
> > Eyal Edri.
> > ___
> > Engine-devel mailing list
> > Engine-devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Request power-user status for mom project in jenkins

2012-12-11 Thread Eyal Edri
[adding engine-devel]

usually there is an official vote on each new power user for jenkins,
and as long as there are no objections it is approved.

since i know you're a mom maintainer and familiar with jenkins, i vote +1.

Eyal.

- Original Message -
> From: "Adam Litke" 
> To: in...@ovirt.org
> Cc: ee...@redhat.com
> Sent: Tuesday, December 11, 2012 6:11:45 PM
> Subject: Request power-user status for mom project in jenkins
> 
> Hi all,
> 
> I am the maintainer of the mom sub-project.  Recently we upgraded the
> mom build
> process to use autotools.  Unfortunately this has broken the Jenkins
> build for
> the project.  Rather than asking here whenever I need an update to
> the build
> job, I think it makes sense for me to administer that myself.  If
> there is
> agreement about this, could someone help me to acquire the relavent
> permissions?
> 
> Thanks!
> 
> --
> Adam Litke 
> IBM Linux Technology Center
> 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 2971 - Still Unstable!

2012-12-27 Thread Eyal Edri
fyi,

unit tests are failing from yesterday, please check.

Eyal Edri.
oVirt infra team.

- Original Message -
> From: "Jenkins oVirt Server" 
> To: ee...@redhat.com, engine-patc...@ovirt.org, ol...@redhat.com, 
> yzasl...@redhat.com, mkole...@redhat.com
> Sent: Thursday, December 27, 2012 9:53:20 AM
> Subject: [oVirt Jenkins] ovirt_engine_unit_tests - Build # 2971 - Still 
> Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2971/
> Build Number: 2971
> Build Status:  Still Unstable
> Triggered By: Started by upstream project "ovirt_engine" build number
> 3,735
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #2969
> 
> Changes for Build #2970
> [emesika] core:fixing GeneralDbDAOTest
> 
> 
> Changes for Build #2971
> [mkolesni] engine: Add network command packages to factory
> 
> [mkolesni] engine: Move DC network commands to their package
> 
> [mkolesni] engine: Moved VM NIC commands to their package
> 
> [mkolesni] engine: Move template NIC commands to their package
> 
> [mkolesni] engine: Extract SetNetworkStatus method
> 
> [mkolesni] engine: Move cluster network commands to their package
> 
> [mkolesni] engine: Move host network commands to their package
> 
> 
> 
> 
> -
> Failed Tests:
> -
> 2 tests failed.
> REGRESSION:
>  org.ovirt.engine.api.restapi.types.VmMapperTest.testRoundtrip
> 
> Error Message:
> expected: but was:
> 
> Stack Trace:
> java.lang.AssertionError: expected: but was:
>   at org.junit.Assert.fail(Assert.java:93)
>   at org.junit.Assert.failNotEquals(Assert.java:647)
>   at org.junit.Assert.assertEquals(Assert.java:128)
>   at org.junit.Assert.assertEquals(Assert.java:147)
>   at
>   
> org.ovirt.engine.api.restapi.types.VmMapperTest.verify(VmMapperTest.java:109)
>   at
>   
> org.ovirt.engine.api.restapi.types.VmMapperTest.verify(VmMapperTest.java:26)
>   at
>   
> org.ovirt.engine.api.restapi.types.AbstractInvertibleMappingTest.testRoundtrip(AbstractInvertibleMappingTest.java:57)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at
>   
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at
>   
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:601)
>   at
>   
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
>   at
>   
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
>   at
>   
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
>   at
>   
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
>   at
>   
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:47)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:18)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
>   at
>   
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
>   at
>   
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
>   at
>   
> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
>   at
>   
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
>   at
>   
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at
>   
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at
>   
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Metho

Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 2971 - Still Unstable!

2012-12-27 Thread Eyal Edri
Arik,

it seems your commit [1] is related to the unit test that is failing,
can you please fix or disable the test? 

[1] 
http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git&a=commit&h=f673ddb66a0fdaaaf8902fe9dacc6d0e55178eb1

Eyal.

- Original Message -
> From: "Eyal Edri" 
> To: engine-devel@ovirt.org, mkole...@redhat.com, "Eli Mesika" 
> 
> Sent: Thursday, December 27, 2012 10:05:30 AM
> Subject: Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 
> 2971 - Still Unstable!
> 
> fyi,
> 
> unit tests are failing from yesterday, please check.
> 
> Eyal Edri.
> oVirt infra team.
> 
> - Original Message -
> > From: "Jenkins oVirt Server" 
> > To: ee...@redhat.com, engine-patc...@ovirt.org, ol...@redhat.com,
> > yzasl...@redhat.com, mkole...@redhat.com
> > Sent: Thursday, December 27, 2012 9:53:20 AM
> > Subject: [oVirt Jenkins] ovirt_engine_unit_tests - Build # 2971 -
> > Still Unstable!
> > 
> > Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
> > Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2971/
> > Build Number: 2971
> > Build Status:  Still Unstable
> > Triggered By: Started by upstream project "ovirt_engine" build
> > number
> > 3,735
> > 
> > -
> > Changes Since Last Success:
> > -
> > Changes for Build #2969
> > 
> > Changes for Build #2970
> > [emesika] core:fixing GeneralDbDAOTest
> > 
> > 
> > Changes for Build #2971
> > [mkolesni] engine: Add network command packages to factory
> > 
> > [mkolesni] engine: Move DC network commands to their package
> > 
> > [mkolesni] engine: Moved VM NIC commands to their package
> > 
> > [mkolesni] engine: Move template NIC commands to their package
> > 
> > [mkolesni] engine: Extract SetNetworkStatus method
> > 
> > [mkolesni] engine: Move cluster network commands to their package
> > 
> > [mkolesni] engine: Move host network commands to their package
> > 
> > 
> > 
> > 
> > -
> > Failed Tests:
> > -
> > 2 tests failed.
> > REGRESSION:
> >  org.ovirt.engine.api.restapi.types.VmMapperTest.testRoundtrip
> > 
> > Error Message:
> > expected: but was:
> > 
> > Stack Trace:
> > java.lang.AssertionError: expected: but was:
> > at org.junit.Assert.fail(Assert.java:93)
> > at org.junit.Assert.failNotEquals(Assert.java:647)
> > at org.junit.Assert.assertEquals(Assert.java:128)
> > at org.junit.Assert.assertEquals(Assert.java:147)
> > at
> > 
> > org.ovirt.engine.api.restapi.types.VmMapperTest.verify(VmMapperTest.java:109)
> > at
> > 
> > org.ovirt.engine.api.restapi.types.VmMapperTest.verify(VmMapperTest.java:26)
> > at
> > 
> > org.ovirt.engine.api.restapi.types.AbstractInvertibleMappingTest.testRoundtrip(AbstractInvertibleMappingTest.java:57)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at
> > 
> > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > at
> > 
> > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at java.lang.reflect.Method.invoke(Method.java:601)
> > at
> > 
> > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
> > at
> > 
> > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> > at
> > 
> > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
> > at
> > 
> > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> > at
> > 
> > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
> > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:47)
> > at org.junit.rules.RunRules.evaluate(RunRules.java:18)
> > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
> > at
> > 
> > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
> > at
> > 
> > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
> > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
> >

Re: [Engine-devel] Java code formatting

2013-01-04 Thread Eyal Edri


- Original Message -
> From: "David Jaša" 
> To: "engine-devel" 
> Sent: Friday, January 4, 2013 4:37:13 PM
> Subject: Re: [Engine-devel] Java code formatting
> 
> Doron Fediuck píše v St 02. 01. 2013 v 03:24 -0500:
> > 
> > - Original Message -
> > > From: "Livnat Peer" 
> > > To: "Doron Fediuck" 
> > > Cc: "engine-devel" 
> > > Sent: Tuesday, January 1, 2013 5:58:15 PM
> > > Subject: Re: [Engine-devel] Java code formatting
> > > 
> > > On 01/01/2013 05:39 PM, Doron Fediuck wrote:
> > > > 
> > > > 
> > > > - Original Message -
> > > >> From: "Alon Bar-Lev" 
> > > >> To: "Doron Fediuck" 
> > > >> Cc: "engine-devel" 
> > > >> Sent: Tuesday, January 1, 2013 5:05:09 PM
> > > >> Subject: Re: [Engine-devel] Java code formatting
> > > >>
> > > >>
> > > >>
> > > >> - Original Message -
> > > >>> From: "Doron Fediuck" 
> > > >>> To: "Alon Bar-Lev" 
> > > >>> Cc: "engine-devel" 
> > > >>> Sent: Tuesday, January 1, 2013 5:00:20 PM
> > > >>> Subject: Re: [Engine-devel] Java code formatting
> > > >>>
> > > >>>
> > > >>>
> > > >>> - Original Message -
> > >  From: "Alon Bar-Lev" 
> > >  To: "Doron Fediuck" 
> > >  Cc: "engine-devel" 
> > >  Sent: Tuesday, January 1, 2013 4:53:49 PM
> > >  Subject: Re: [Engine-devel] Java code formatting
> > > 
> > > 
> > > 
> > >  - Original Message -
> > > > From: "Doron Fediuck" 
> > > > To: "Alon Bar-Lev" 
> > > > Cc: "engine-devel" 
> > > > Sent: Tuesday, January 1, 2013 4:48:22 PM
> > > > Subject: Re: [Engine-devel] Java code formatting
> > > >
> > > >
> > > >
> > > > - Original Message -
> > > >> From: "Alon Bar-Lev" 
> > > >> To: "Doron Fediuck" 
> > > >> Cc: "engine-devel" 
> > > >> Sent: Tuesday, January 1, 2013 4:33:20 PM
> > > >> Subject: Re: [Engine-devel] Java code formatting
> > > >>
> > > >>
> > > >>
> > > >> - Original Message -
> > > >>> From: "Doron Fediuck" 
> > > >>> To: "Alon Bar-Lev" 
> > > >>> Cc: "engine-devel" 
> > > >>> Sent: Tuesday, January 1, 2013 4:28:15 PM
> > > >>> Subject: Re: [Engine-devel] Java code formatting
> > > >>>
> > > >>>
> > > >>>
> > > >>> - Original Message -
> > >  From: "Alon Bar-Lev" 
> > >  To: "Doron Fediuck" 
> > >  Cc: "engine-devel" 
> > >  Sent: Tuesday, January 1, 2013 4:17:18 PM
> > >  Subject: Re: [Engine-devel] Java code formatting
> > > 
> > > 
> > > 
> > >  - Original Message -
> > > > From: "Doron Fediuck" 
> > > > To: "engine-devel" 
> > > > Sent: Tuesday, January 1, 2013 4:07:53 PM
> > > > Subject: [Engine-devel] Java code formatting
> > > >
> > > > Hi,
> > > > Recently I saw many patches with multiple code
> > > > re-formatting.
> > > > When looking into it, we saw that many people didn't
> > > > use
> > > > the
> > > > project
> > > > policy, and now we have many files with bad formatting.
> > > >
> > > > So I just posted a big ugly fix for this[1], and
> > > > hopefully
> > > > if
> > > > accepted
> > > > people should start using the right conventions and
> > > > reduce
> > > > the
> > > > amount
> > > > of non-relevant changes we see in the patches.
> > > >
> > > > I'm aware of the fact that this may create some issues
> > > > when
> > > > porting
> > > > patches, but better sooner than later.
> > > > Doron.
> > > >
> > > > [1] http://gerrit.ovirt.org/#/c/10541/1
> > > 
> > >  Hi,
> > > 
> > >  These automatic conversions are not better than current
> > >  state,
> > >  also
> > >  I
> > >  don't think that this is that important. If you want
> > >  machine
> > >  written
> > >  code, then also provide commit hook to reformat
> > >  anything,
> > >  and
> > >  probably machines to read it.
> > > 
> > >  I, personally, think that this change over the sources I
> > >  manage
> > >  did
> > >  not do any good.
> > > 
> > >  Regards,
> > >  Alon
> > > >>>
> > > >>> Alon,
> > > >>> there's a formatting convention for the project set long
> > > >>> ago.
> > > >>> If you feel it needs to be fixed, go ahead and suggest a
> > > >>> fix
> > > >>> for
> > > >>> the xml.
> > > >>> Otherwise we end up in the current chaos, where every 2nd
> > > >>> or
> > > >>> 3rd
> > > >>> patch carries unneeded changes.
> > > >>>
> > > >>
> > > >> What do you mean unneeded changes? how do you prevent this
> > > >> in
> > > >> future?
> > > >>
> > > >> Alon
> > >

[Engine-devel] ovirt-engine unit tests are broken

2013-01-12 Thread Eyal Edri
fyi,

since build # unit tests are broken.

last commits:
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] ovirt-engine unit tests are broken

2013-01-12 Thread Eyal Edri
sorry, sent w/o details:

last changes after stable build:

http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3115/changes#detail0

test failing: 
org.ovirt.engine.core.bll.CommandBaseTest.testHandlersInEndWithFailure

- Original Message -
> From: "Eyal Edri" 
> To: "engine-devel" , "Yair Zaslavsky" 
> 
> Sent: Saturday, January 12, 2013 8:36:33 PM
> Subject: [Engine-devel] ovirt-engine unit tests are broken
> 
> fyi,
> 
> since build # unit tests are broken.
> 
> last commits:
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 3091 - Still Failing!

2013-01-20 Thread Eyal Edri
looks like this patch cause new unit test failure, can you check?

http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git&a=commit&h=6fa50420e5c8365bea80125dc3e559d9edb57396

thanks

eyal edri
ovirt infra 

- Original Message -
> From: "Jenkins oVirt Server" 
> To: ee...@redhat.com, engine-patc...@ovirt.org, ol...@redhat.com, 
> yzasl...@redhat.com, in...@ovirt.org,
> gerr...@gerrit.ovirt.org
> Sent: Sunday, January 20, 2013 10:43:39 PM
> Subject: [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 3091 - Still 
> Failing!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/3091/
> Build Number: 3091
> Build Status:  Still Failing
> Triggered By: Started by upstream project "ovirt_engine" build number
> 4,062
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #3084
> [gerrit2] core, db: add cluster view
> 
> [gerrit2] webadmin: show data center name for each cluster
> 
> 
> Changes for Build #3085
> [asaf] restapi: A check for possible NPE BackendVmsResource:remove
> method
> 
> 
> Changes for Build #3086
> [gerrit2] core: improve error msg text in storage connection
> 
> 
> Changes for Build #3087
> 
> Changes for Build #3088
> 
> Changes for Build #3089
> [gerrit2] webadmin: move disks popup - fix alignment
> 
> [gerrit2] core: prevent failure on concurrent live snapshots
> 
> 
> Changes for Build #3090
> [gerrit2] core: required space validation - destination domain
> 
> 
> Changes for Build #3091
> [gerrit2] engine: VmDeviceUtils cleanup
> 
> [gerrit2] engine: VmDeviceUtils cleanup 2
> 
> 
> 
> 
> -
> Failed Tests:
> -
> 1 tests failed.
> FAILED:
>  org.ovirt.engine.core.dao.GeneralDbDAOTest.testBusinessEntitiesColumnSize
> 
> Error Message:
> null
> 
> Stack Trace:
> java.lang.AssertionError
>   at org.junit.Assert.fail(Assert.java:92)
>   at org.junit.Assert.assertTrue(Assert.java:43)
>   at org.junit.Assert.assertTrue(Assert.java:54)
>   at
>   
> org.ovirt.engine.core.dao.GeneralDbDAOTest.testBusinessEntitiesColumnSize(GeneralDbDAOTest.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at
>   
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at
>   
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:601)
>   at
>   
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
>   at
>   
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
>   at
>   
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
>   at
>   
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
>   at
>   
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
>   at
>   
> org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:74)
>   at
>   
> org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:83)
>   at
>   
> org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:72)
>   at
>   
> org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:231)
>   at
>   
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
>   at
>   
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
>   at
>   
> org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
>   at
>   
> org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:71)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
>   at
>   
&g

Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 3216 - Still unstable!

2013-01-25 Thread Eyal Edri
fyi,

seems like this patch introduced new unit test failure, please check,

http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git&a=commit&h=207cda518399d0474154d5c3a9c363bcc43b6a72
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3212/


Eyal.
Infra team.

- Original Message -
> From: "Jenkins oVirt Server" 
> To: ee...@redhat.com, engine-patc...@ovirt.org, ol...@redhat.com, 
> yzasl...@redhat.com
> Sent: Friday, January 25, 2013 11:49:10 AM
> Subject: [oVirt Jenkins] ovirt_engine_unit_tests - Build # 3216 - Still 
> unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3216/
> Build Number: 3216
> Build Status:  Still unstable
> Triggered By: Started by upstream project "ovirt_engine" build number
> 4,107, Started by upstream project "ovirt_engine" build number 4,109
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #3212
> [gerrit2] engine: consolidate VM and Poll queries
> 
> 
> Changes for Build #3213
> [gerrit2] core:unlock_entity.sh is not finding a locked ...
> 
> [gerrit2] core:unlock_entity.sh is not unlocking the vm...
> 
> [emesika] core:If no power management configured or fails...
> 
> 
> Changes for Build #3214
> 
> Changes for Build #3215
> [gerrit2] packaging: Starting ssh before adding host in AIO
> 
> [gerrit2] packaging: Updated spec to use sdk version that supports
> ssl.
> 
> [gerrit2] spelling: s/mster/master/
> 
> 
> Changes for Build #3216
> 
> 
> 
> -
> Failed Tests:
> -
> 1 tests failed.
> FAILED:
>  
> org.ovirt.engine.core.bll.GetAllVmPoolsAttachedToUserQueryTest.testQueryIsAUserQuery
> 
> Error Message:
> A query tested for filtered access should not be an admin query
> 
> Stack Trace:
> java.lang.AssertionError: A query tested for filtered access should
> not be an admin query
>   at org.junit.Assert.fail(Assert.java:93)
>   at org.junit.Assert.assertTrue(Assert.java:43)
>   at org.junit.Assert.assertFalse(Assert.java:68)
>   at
>   
> org.ovirt.engine.core.bll.AbstractUserQueryTest.testQueryIsAUserQuery(AbstractUserQueryTest.java:58)
>   at sun.reflect.GeneratedMethodAccessor11.invoke(Unknown Source)
>   at
>   
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:601)
>   at
>   
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
>   at
>   
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
>   at
>   
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
>   at
>   
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
>   at
>   
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
>   at
>   
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
>   at
>   
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
>   at
>   
> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
>   at
>   
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
>   at
>   
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at
>   
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at
>   
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:601)
>   at
>   
> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:164)
>   at
>   
> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:110)
>   at
>   
> org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:175)
>   at
>   
> org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcessWhenForked(SurefireStarter.java:107)
>   at
>   org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:68)
> 
> 
>  
> 
> --
> Build Log:
> --

[Engine-devel] [JENKINS] important change in findbugs analysis

2013-01-27 Thread Eyal Edri
fyi,

as part of the efforts to reduce bugs found by findbugs jenkins job, 
NORMAL priority bugs limit has been set to 15 (current count), 
this means that any NEW NORMAL bugs that will enter ovirt-engine code will fail 
the job,
and it's the committer responsibility to fix it.

if you're not sure about your code, you can run mvn findbugs:findbugs before 
merging (there's also an eclipse plugin for it).

there is on-going work on reducing NORMAL bugs, and this limit will reduce in 
the near future,
until it will reach '0' (similar to HIGH prirority).

thanks for the cooperation.

Eyal Edri
oVirt infra team.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] May I apply for a user account on jenkins.ovirt.org to run VDSM functional tests?

2013-01-29 Thread Eyal Edri


- Original Message -
> From: "Zhou Zheng Sheng" 
> To: in...@ovirt.org
> Cc: "ShaoHe Feng" 
> Sent: Tuesday, January 29, 2013 12:24:27 PM
> Subject: May I apply for a user account on jenkins.ovirt.org to run VDSM  
> functional tests?
> 
> Hi all,
> 
> I notice there is no VDSM functional tests running in oVirt Jenkins.
> Currently in VDSM we have some XML-RPC functional test cases for
> iSCSI,
> localfs and glusterfs storage as well as creating and destroying VMs
> on
> those storage. Functional tests through JSON-RPC are under review. I
> also submit a patch to Gerrit for running the tests easily
> (http://gerrit.ovirt.org/#/c/11238/). More test cases will be added
> to
> improve test coverage and reduce the chance of regression.
> 
> Some bugs that can not be covered by unit test can be caught by
> functional tests. I think it would be helpful to run these functional
> tests continuously. We can also configure the Gerrit trigger in
> Jenkins
> to run functional tests when someone verifies the patch or when it
> gets
> approved but not merged. This may be helpful to the maintainer.
> 
> I've setup a Jenkins job for VDSM functional tests in my lab server.
> You
> can refer to the job configuration of my current setup
> (https://github.com/edwardbadboy/vdsm-jenkins/blob/master/config.xml).
> After my patch in Gerrit is accepted, the job configuration will be
> simpler and the hacks can be removed. May I apply a user account for
> creating job in the oVirt Jenkins?
> 

Hi Zhou,
Basically there shouldn't be any problem with that.
we have an option for giving a 'power-user' permissions for certain users on 
oVirt misc projects 
to add and and configure jobs for thier project. 

it requires knowledge in jenkins, which it seems that you have and recognition 
from the 
team/other developers from the relevant project (in this case, VDSM) that you 
are an active member of the project. 
(just a formality essentially)

I've added engine-devel list to this thread so anyone from vdsm team can vote 
+1 for adding you as a power user for jenkins.

once we'll receive a few +1 and not objections i'll create a user for you and 
send you the details.

you'll be able to:

1. create new jobs
2. update jobs configurations
3. run jobs.. 


> --
> Thanks and best regards!
> 
> Zhou Zheng Sheng / 周征晟
> E-mail: zhshz...@linux.vnet.ibm.com
> Telephone: 86-10-82454397
> 
> ___
> Infra mailing list
> in...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3413 - Unstable!

2013-02-01 Thread Eyal Edri
fyi,

new HIGH priority bug has been detected via findbugs in Managedomains.java file:

http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3413/findbugsResult/HIGH/?

it was inserted in one of the commits since jan 29:

(git blames this commit 
..http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git&a=commit&h=35722c064f876ab9ead4b62105f7031623ec4471)
 


> 
> Changes Since Last Success:
> -

> [alkaplan] webadmin: Showing more than one canDoMessage for action in
> multiple action
> [alkaplan] engine: Extended error for pinned host missing non
> required network
> [alkaplan] webadmin: Add default description to multiple action
> result
> [gerrit2] engine: Moving Duplicate Code to Base Class
> [juan.hernandez] packaging: Bump version number to 3.3.0-SNAPSHOT
> [gerrit2] frontend: force admin-console only on AdminPortal
> [mkublin] engine: Stop flood a logs by Autorecovering 0 
> [rgolan] core: cancel migration better error handling
> [amureini] core: Remove dead JPA implementation
> [gerrit2] gluster: fixed NPE in GlusterAuditLogUtil
> [gerrit2] packaging: suggest path for local storage during AIO setup
> [ofrenkel] core: add support for tunnel migration
> [ofrenkel] restapi: Add support for tunnel migration
> [gerrit2] core: cleanup Handler classes
> [amureini] packaging: Complete removal of Hibernate
> [gerrit2] core: prevent changing display settings when vm isn't down
> [ahadas] webadmin: replace 'VM' with 'Virtual Machine'
> [alonbl] packaging: set both PGPASSFILE and ENGINE_PGPASS
> [alonbl] packaging: substitute engineVersion.js in target that
> actually create it
> [amureini] core,ui: test duplicate keys in appErrors 
> [gerrit2] core: Make dependency on commons-collections explicit
> [gerrit2] compat: convert to base64 without line feed
> [gerrit2] pki: process template files not in-place
> [gerrit2] pki: install private directories not world readable
> [gerrit2] pki: encryptpasswd: remove unneeded pushd/popd
> [gerrit2] cleanup: update .gitignore
> 


- Original Message -
> From: "Jenkins oVirt Server" 
> To: ee...@redhat.com, engine-patc...@ovirt.org, ol...@redhat.com, 
> yzasl...@redhat.com, dc...@redhat.com
> Sent: Friday, February 1, 2013 3:40:56 PM
> Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3413 - Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3413/
> Build Number: 3413
> Build Status:  Unstable
> Triggered By: Started by user David Caro Estevez
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #3402
> [alkaplan] webadmin: Showing more than one canDoMessage for action in
> multiple action
> 
> [alkaplan] engine: Extended error for pinned host missing non
> required network
> 
> [alkaplan] webadmin: Add default description to multiple action
> result
> 
> [gerrit2] engine: Moving Duplicate Code to Base Class
> 
> [juan.hernandez] packaging: Bump version number to 3.3.0-SNAPSHOT
> 
> 
> Changes for Build #3403
> 
> Changes for Build #3404
> [gerrit2] frontend: force admin-console only on AdminPortal
> 
> 
> Changes for Build #3405
> [mkublin] engine: Stop flood a logs by Autorecovering 0 
> 
> [rgolan] core: cancel migration better error handling
> 
> 
> Changes for Build #3406
> 
> Changes for Build #3407
> [amureini] core: Remove dead JPA implementation
> 
> [gerrit2] gluster: fixed NPE in GlusterAuditLogUtil
> 
> 
> Changes for Build #3408
> 
> Changes for Build #3409
> [gerrit2] packaging: suggest path for local storage during AIO setup
> 
> [ofrenkel] core: add support for tunnel migration
> 
> [ofrenkel] restapi: Add support for tunnel migration
> 
> [gerrit2] core: cleanup Handler classes
> 
> [amureini] packaging: Complete removal of Hibernate
> 
> [gerrit2] core: prevent changing display settings when vm isn't down
> 
> [ahadas] webadmin: replace 'VM' with 'Virtual Machine'
> 
> [alonbl] packaging: set both PGPASSFILE and ENGINE_PGPASS
> 
> [alonbl] packaging: substitute engineVersion.js in target that
> actually create it
> 
> [amureini] core,ui: test duplicate keys in appErrors
> 
> [gerrit2] core: Make dependency on commons-collections explicit
> 
> 
> Changes for Build #3410
> [gerrit2] compat: convert to base64 without line feed
> 
> [gerrit2] pki: process template files not in-place
> 
> [gerrit2] pki: install private directories not world readable
> 
> [gerrit2] pki: encryptpasswd: remove unneeded pushd/popd
> 
> 
> Changes for Build #3411
> 
> Changes for Build #3412
> [gerrit2] cleanup: update .gitignore
> 
> 
> Changes for Build #3413
> 
> 
> 
> -
> Failed Tests:
> -
> No tests ran.
> 
> --
> Build Log:
> --
> [...truncated 32804 lines...]
> Downloading:
> http://repo1.maven.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.0-alpha-7

[Engine-devel] Proposing Kiril nesenko as power user for "ovirt engine tools"

2013-02-07 Thread Eyal Edri
Hi,

I would like to propose kiril nesenko as 'jenkins power user' for ovirt engine 
tools.
These tools indlude iso uploader, log collector, image uploader and others. 

Kiril is very involved in building and running Jenkins jobs on the rhevm 
product,
and maintains & package the ovirt tools currently.
As part of being power user on jenkins.ovirt.org, he will create new jobs to 
build and release tools for the various OS supported.

I vote +1 as i personally know kiril and he's experience. 

Thansk,

Eyal.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Proposing Kiril nesenko as power user for "ovirt engine tools"

2013-02-07 Thread Eyal Edri
Seems like enough +1 and not objections,

Kiril, i will send you credentials in private.

thanks,

eyal.

- Original Message -
> From: "Moti Asayag" 
> To: "Eyal Edri" 
> Cc: "infra" , "knesenko" , 
> "engine-devel" 
> Sent: Thursday, February 7, 2013 7:00:39 PM
> Subject: Re: [Engine-devel] Proposing Kiril nesenko as power user for "ovirt 
> engine tools"
> 
> On 02/07/2013 10:39 AM, Eyal Edri wrote:
> > Hi,
> > 
> > I would like to propose kiril nesenko as 'jenkins power user' for
> > ovirt engine tools.
> > These tools indlude iso uploader, log collector, image uploader and
> > others.
> > 
> > Kiril is very involved in building and running Jenkins jobs on the
> > rhevm product,
> > and maintains & package the ovirt tools currently.
> > As part of being power user on jenkins.ovirt.org, he will create
> > new jobs to build and release tools for the various OS supported.
> > 
> > I vote +1 as i personally know kiril and he's experience.
> > 
> 
> +1 as well.
> 
> > Thansk,
> > 
> > Eyal.
> > ___
> > Engine-devel mailing list
> > Engine-devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3528 - Still Unstable!

2013-02-14 Thread Eyal Edri
2 new NORMAL priority bugs were introduced after this commit:

[tnisan] core: Rename storage_domains entity to StorageDomain
http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git&a=commit&h=8c5e31a30b0579db46b5f29fde253ad361e24f7e

http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3524/findbugsResult/NORMAL/?

please check,

Eyal Edri.


- Original Message -
> From: "Jenkins oVirt Server" 
> To: ee...@redhat.com, engine-patc...@ovirt.org, ol...@redhat.com, 
> yzasl...@redhat.com, dc...@redhat.com
> Sent: Thursday, February 14, 2013 9:13:17 PM
> Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3528 - Still 
> Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3528/
> Build Number: 3528
> Build Status:  Still Unstable
> Triggered By: Started by upstream project "ovirt_engine" build number
> 4,315
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #3524
> [tnisan] core: Rename storage_domains entity to StorageDomain
> 
> 
> Changes for Build #3525
> [gerrit2] tools: Remove some notifier dependencies
> 
> [gerrit2] webadmin: Refactored base Model class probihition reason
> option
> 
> 
> Changes for Build #3526
> [amureini] core: Fix db upgrade in PostgreSQL 8.x
> 
> 
> Changes for Build #3527
> 
> Changes for Build #3528
> 
> 
> 
> -
> Failed Tests:
> -
> No tests ran.
> 
> --
> Build Log:
> --
> [...truncated 1709 lines...]
> [INFO] javac option: -proc:only
> [INFO] javac option: -d
> [INFO] javac option:
> /ephemeral0/ovirt_engine_find_bugs/frontend/webadmin/modules/userportal-gwtp/target/userportal-3.3.0-SNAPSHOT/WEB-INF/classes
> [INFO] javac option: -s
> [INFO] javac option:
> /ephemeral0/ovirt_engine_find_bugs/frontend/webadmin/modules/userportal-gwtp/target/generated-sources/annotations
> [INFO] diagnostic warning: Supported source version 'RELEASE_6' from
> annotation processor
> 'com.gwtplatform.dispatch.annotation.processor.GenDtoProcessor' less
> than -source '1.7'
> [INFO] diagnostic warning: Supported source version 'RELEASE_6' from
> annotation processor
> 'com.gwtplatform.dispatch.annotation.processor.GenEventProcessor'
> less than -source '1.7'
> [INFO] diagnostic Note:
> com.gwtplatform.dispatch.annotation.processor.GenEventProcessor
> started.
> [INFO] diagnostic Note: Searching for @GenEvent annotations.
> [INFO] diagnostic Note: Found
> org.ovirt.engine.ui.userportal.section.main.presenter.SearchableModelActivation.
> [INFO] diagnostic Note: Generating
> 'org.ovirt.engine.ui.userportal.section.main.presenter.SearchableModelActivationEvent'
> from 'SearchableModelActivation'.
> [INFO] diagnostic Note: Found
> org.ovirt.engine.ui.userportal.section.main.presenter.tab.extended.SideTabExtendedTemplatePresenter.ExtendedTemplateSelectionChange.
> [INFO] diagnostic Note: Generating
> 'org.ovirt.engine.ui.userportal.section.main.presenter.tab.extended.ExtendedTemplateSelectionChangeEvent'
> from 'ExtendedTemplateSelectionChange'.
> [INFO] diagnostic Note: Found
> org.ovirt.engine.ui.userportal.section.main.presenter.tab.extended.SideTabExtendedVirtualMachinePresenter.ExtendedVirtualMachineSelectionChange.
> [INFO] diagnostic Note: Generating
> 'org.ovirt.engine.ui.userportal.section.main.presenter.tab.extended.ExtendedVirtualMachineSelectionChangeEvent'
> from 'ExtendedVirtualMachineSelectionChange'.
> [INFO] diagnostic Note: Found
> org.ovirt.engine.ui.userportal.section.main.presenter.popup.console.ConsolePopupPresenterWidget.ConsoleModelChanged.
> [INFO] diagnostic Note: Generating
> 'org.ovirt.engine.ui.userportal.section.main.presenter.popup.console.ConsoleModelChangedEvent'
> from 'ConsoleModelChanged'.
> [INFO] diagnostic Note: Found
> org.ovirt.engine.ui.userportal.uicommon.model.UserPortalModelInit.
> [INFO] diagnostic Note: Generating
> 'org.ovirt.engine.ui.userportal.uicommon.model.UserPortalModelInitEvent'
> from 'UserPortalModelInit'.
> [INFO] diagnostic Note: Found
> org.ovirt.engine.ui.userportal.uicommon.model.vm.VmMonitorValueChange.
> [INFO] diagnostic Note: Generating
> 'org.ovirt.engine.ui.userportal.uicommon.model.vm.VmMonitorValueChangeEvent'
> from 'VmMonitorValueChange'.
> [INFO] diagnostic Note:
> com.gwtplatform.dispatch.annotation.processor.GenEventProcessor
> finished.
> [INFO] diagnostic warning: Supported source ve

Re: [Engine-devel] oVirt on Fedora 17

2013-02-16 Thread Eyal Edri
Hey sandro,

Are you sure? 
i'm seeing fedora 17 rpms here: 
http://resources.ovirt.org/releases/stable/rpm/Fedora/17/noarch/

can you check again?

Eyal.

- Original Message -
> From: "Sandro Bonazzola" 
> To: engine-devel@ovirt.org
> Sent: Friday, February 15, 2013 2:33:22 PM
> Subject: [Engine-devel] oVirt on Fedora 17
> 
> Hi,
> I'm testing the upgrade path from Fedora 17 with oVirt 3.1 to Fedora
> 18
> with oVirt 3.2 now that 3.2 is released.
> I've seen that ovirt-stable is not available anymore on Fedora 17:
> http://resources.ovirt.org/releases/stable/rpm/Fedora/ shows only
> Fedora
> 18 and Fedora 19.
> 
> I can fix the repository url on my system pointing to
> http://resources.ovirt.org/releases/3.1/rpm/Fedora/
> but since Fedora 17 is still available I think that the 3.1 / F17
> repo
> should be still available on ovirt.org.
> 
> --
> Sandro
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] [JENKINS] unplanned outage for jenkins.ovirt.org

2013-02-17 Thread Eyal Edri
Fyi,

Due to important update jenkins.ovirt.org will be unavailable for the next few 
min,

sorry for the inconvenience,

Eyal.
oVirt infra team 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [JENKINS] unplanned outage for jenkins.ovirt.org

2013-02-17 Thread Eyal Edri
Outage is over.

jenkins.ovirt.org has been upgraded to 1.480.3 LTS.

thanks,

Eyal.
- Original Message -
> From: "Eyal Edri" 
> To: "engine-devel" 
> Cc: "infra" 
> Sent: Sunday, February 17, 2013 10:08:50 AM
> Subject: [Engine-devel] [JENKINS] unplanned outage for jenkins.ovirt.org
> 
> Fyi,
> 
> Due to important update jenkins.ovirt.org will be unavailable for the
> next few min,
> 
> sorry for the inconvenience,
> 
> Eyal.
> oVirt infra team
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Engine - top 10 with patches with no activity for more than 30 days

2013-02-20 Thread Eyal Edri


- Original Message -
> From: "Itamar Heim" 
> To: "Yair Zaslavsky" 
> Cc: "engine-devel" 
> Sent: Wednesday, February 20, 2013 6:17:43 PM
> Subject: Re: [Engine-devel] Engine - top 10 with patches with no activity for 
> more than 30 days
> 
> On 20/02/2013 18:04, Yair Zaslavsky wrote:
> > Hi,
> > Why not sending this as a reminder?
> > But sending also the gerrit links
> > For example, I assume mkolesni sent an engine patch, maybe I as
> > someone who also sends patches to engine can review (even if not
> > ACK, share some thoughts?)
> >

ohad wrote a nagios plugin that send alerts on old patches for jenkins repo 
(currently set for 7 days),
i'm guessing it can be enhanced and generalize to handle more projects to to 
alert on old patches.

> 
> if you want to help and review old patches, just set your gerrit
> search
> to age:30d and review old patches...
> 
> > Thanks,
> > Yair
> >
> >
> > - Original Message -
> >> From: "Itamar Heim" 
> >> To: "engine-devel" 
> >> Sent: Wednesday, February 20, 2013 5:39:16 PM
> >> Subject: [Engine-devel] Engine - top 10 with patches with no
> >> activity for   more than 30 days
> >>
> >> thoughts on how to trim these?
> >> (in openstack gerrit they auto-abandon patches with no activity
> >> for a
> >> couple of weeks - author can revive them back when they are
> >> relevant)
> >>
> >>preferred_email   | count
> >>--+--
> >>mkole...@redhat.com   | 17
> >>rgo...@redhat.com | 12
> >>sesub...@redhat.com   | 8
> >>lhorn...@redhat.com   | 5
> >>lara...@redhat.com| 4
> >>juan.hernan...@redhat.com | 4
> >>lver...@redhat.com| 4
> >>aw...@redhat.com  | 4
> >>mhun...@gmail.com | 3
> >>vsz...@redhat.com | 3
> >> ___
> >> Engine-devel mailing list
> >> Engine-devel@ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>
> 
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] new ovirt-dwh & ovirt-reports nightly builds are avaliable for fedora 18

2013-02-25 Thread Eyal Edri
fyi,

per request, ovirt-dwh & ovirt-reports are now built nightly and published on 
ovirt.org repos.

http://resources.ovirt.org/releases/nightly/rpm/Fedora/18/noarch/

Eyal Edri
oVirt infra team.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3652 - Still Unstable!

2013-03-03 Thread Eyal Edri
New patches inserted NORMAL priority find bugs, 
please review and fix asap:

http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/changes

E.

- Original Message -
> From: "Jenkins oVirt Server" 
> To: ee...@redhat.com, engine-patc...@ovirt.org, dc...@redhat.com, 
> a...@redhat.com, amure...@redhat.com,
> gerr...@gerrit.ovirt.org
> Sent: Sunday, March 3, 2013 3:06:08 PM
> Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3652 - Still 
> Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3652/
> Build Number: 3652
> Build Status:  Still Unstable
> Triggered By: Started by upstream project "ovirt_engine" build number
> 4,474
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #3647
> [gerrit2] webadmin: get HotPlugEnabled config value synchronously
> 
> [gerrit2] webadmin: get LocalFSPath config value synchronously
> 
> 
> Changes for Build #3648
> [gerrit2] userportal: ignore the NetworkUser role
> 
> [fkobzik] core: Non-plugin automatic invocation of console session
> 
> [fkobzik] frontend: Non-plugin automatic invocation of console
> session
> 
> [ecohen] userportal: fix memory leaks
> 
> [ecohen] userportal: stop basic list provider on extended tab
> 
> [ecohen] userportal: Optimize basic view
> 
> [ecohen] userportal: Optimize extended view VM/Pool grid
> 
> [ecohen] userportal: Optimization fixes
> 
> [ecohen] userportal: fix memory leak when VM selected
> 
> [ecohen] userportal: Set default VM/Pool refresh rate to 30s for IE8
> 
> [ecohen] userportal: Fix UI update for Basic list item
> 
> 
> Changes for Build #3649
> [gerrit2] core: Disable unsupported fence agents in UI
> 
> 
> Changes for Build #3650
> [gerrit2] packaging: Updated psql calls not to ask password
> 
> [amureini] core: Remove fixtures.out.xml
> 
> [amureini] core: Singleton row mappers for EventDAO
> 
> [amureini] core: StorageDoaminSynamic Singleton row mapper
> 
> [amureini] core: StoragePoolDAO single RowMapper
> 
> [amureini] core: Singleton row mapper for StoragePoolIsoMap
> 
> [amureini] core: Singleton row mapper for DiskImageDynamic
> 
> [amureini] core: Singleton row mapper for DiskLunMap
> 
> [amureini] core: final RowMapper for ImageStorageDomainMaoDao
> 
> [amureini] core: Singleton row mapper for VdcOption
> 
> [amureini] core: Use VdsRowMapper static instance
> 
> [amureini] core: Singleton row mapper for VdsDynamic
> 
> [amureini] core: Singleton row mapper for VdsStatistics
> 
> 
> Changes for Build #3651
> 
> Changes for Build #3652
> [nslomian] webadmin: add isCancel to command in quota
> 
> [gerrit2] core:Upgrade from 3.1 to 3.2 fails
> 
> [gerrit2] core: change shared-lock msg of AddVmFromTemplate
> 
> [amureini] core: ImagesHandler: filterImageDisks readability
> 
> [amureini] core: ImageHandlerTest - add missing annotation
> 
> 
> 
> 
> -
> Failed Tests:
> -
> No tests ran.
> 
> --
> Build Log:
> --
> [...truncated 36768 lines...]
>  [java] Warnings generated: 12
> [INFO] Done FindBugs Analysis
> [INFO]
> [INFO]
> 
> [INFO] Building oVirt Server EAR 3.3.0-SNAPSHOT
> [INFO]
> 
> [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is
> missing, no dependency information available
> [WARNING] Failed to retrieve plugin descriptor for
> org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin
> org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies
> could not be resolved: Failed to read artifact descriptor for
> org.eclipse.m2e:lifecycle-mapping:jar:1.0.0
> [INFO]
> [INFO] --- maven-ear-plugin:2.8:generate-application-xml
> (default-generate-application-xml) @ engine-server-ear ---
> Downloading:
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-archiver/2.1.2/plexus-archiver-2.1.2.pom
> 4 KB
>
> Downloaded:
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-archiver/2.1.2/plexus-archiver-2.1.2.pom
> (4 KB at 27.3 KB/sec)
> Downloading:
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-utils/3.0.2/plexus-utils-3.0.2.pom
> 3 KB
>
> Downloaded:
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-utils/3.0.2/plexus-utils-3.0.2.pom
> (3 KB at 59.8 KB/sec)
> Downloading:
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus/3.1/plexus-3.1.pom
> 4 KB
> 8 KB
> 12 KB
> 15 KB
> 19 KB
> 19 KB
> 
> Downloaded:
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus/3.1/plexus-3.1.pom
> (19 KB at 586.4 KB/sec)
> Downloading:
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-io/2.0.4/plexus-io-2.0.4.pom
> 2 KB
>
> Downloaded:
> http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-io/2.0.4/plexus-io-2.0.4.pom
> (2 KB at 188.0 KB/sec)
> D

Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3653 - Still Unstable!

2013-03-03 Thread Eyal Edri
the following is the 2 new bugs added by the followings commits:

http://jenkins.ovirt.org/view/00%20-%20Unstable%20Jobs/job/ovirt_engine_find_bugs/3648/findbugsResult/new/NORMAL/category.-675839583/
http://jenkins.ovirt.org/view/00%20-%20Unstable%20Jobs/job/ovirt_engine_find_bugs/3648/findbugsResult/new/NORMAL/category.1731749696/

looks like cause by the following commit: 
http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git&a=commit&h=ecdfea9300cc27081203fde5c6b2dcff6665a3d4

other commits in the same build:

userportal: ignore the NetworkUser role (detail / gitweb)
core: Non-plugin automatic invocation of console session (detail / gitweb)
frontend: Non-plugin automatic invocation of console session (detail / gitweb)
userportal: fix memory leaks (detail / gitweb)
userportal: stop basic list provider on extended tab (detail / gitweb)
userportal: Optimize basic view (detail / gitweb)
userportal: Optimize extended view VM/Pool grid (detail / gitweb)
userportal: Optimization fixes (detail / gitweb)
userportal: fix memory leak when VM selected (detail / gitweb)
userportal: Set default VM/Pool refresh rate to 30s for IE8 (detail / gitweb)
userportal: Fix UI update for Basic list item (detail / gitweb)

- Original Message -
> From: "Jenkins oVirt Server" 
> To: ee...@redhat.com, engine-patc...@ovirt.org, dc...@redhat.com, 
> a...@redhat.com, oourf...@redhat.com
> Sent: Sunday, March 3, 2013 4:57:54 PM
> Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3653 - Still 
> Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3653/
> Build Number: 3653
> Build Status:  Still Unstable
> Triggered By: Started by upstream project "ovirt_engine" build number
> 4,475
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #3647
> [gerrit2] webadmin: get HotPlugEnabled config value synchronously
> 
> [gerrit2] webadmin: get LocalFSPath config value synchronously
> 
> 
> Changes for Build #3648
> [gerrit2] userportal: ignore the NetworkUser role
> 
> [fkobzik] core: Non-plugin automatic invocation of console session
> 
> [fkobzik] frontend: Non-plugin automatic invocation of console
> session
> 
> [ecohen] userportal: fix memory leaks
> 
> [ecohen] userportal: stop basic list provider on extended tab
> 
> [ecohen] userportal: Optimize basic view
> 
> [ecohen] userportal: Optimize extended view VM/Pool grid
> 
> [ecohen] userportal: Optimization fixes
> 
> [ecohen] userportal: fix memory leak when VM selected
> 
> [ecohen] userportal: Set default VM/Pool refresh rate to 30s for IE8
> 
> [ecohen] userportal: Fix UI update for Basic list item
> 
> 
> Changes for Build #3649
> [gerrit2] core: Disable unsupported fence agents in UI
> 
> 
> Changes for Build #3650
> [gerrit2] packaging: Updated psql calls not to ask password
> 
> [amureini] core: Remove fixtures.out.xml
> 
> [amureini] core: Singleton row mappers for EventDAO
> 
> [amureini] core: StorageDoaminSynamic Singleton row mapper
> 
> [amureini] core: StoragePoolDAO single RowMapper
> 
> [amureini] core: Singleton row mapper for StoragePoolIsoMap
> 
> [amureini] core: Singleton row mapper for DiskImageDynamic
> 
> [amureini] core: Singleton row mapper for DiskLunMap
> 
> [amureini] core: final RowMapper for ImageStorageDomainMaoDao
> 
> [amureini] core: Singleton row mapper for VdcOption
> 
> [amureini] core: Use VdsRowMapper static instance
> 
> [amureini] core: Singleton row mapper for VdsDynamic
> 
> [amureini] core: Singleton row mapper for VdsStatistics
> 
> 
> Changes for Build #3651
> 
> Changes for Build #3652
> [nslomian] webadmin: add isCancel to command in quota
> 
> [gerrit2] core:Upgrade from 3.1 to 3.2 fails
> 
> [gerrit2] core: change shared-lock msg of AddVmFromTemplate
> 
> [amureini] core: ImagesHandler: filterImageDisks readability
> 
> [amureini] core: ImageHandlerTest - add missing annotation
> 
> 
> Changes for Build #3653
> [oourfali] rest: after creating a REST session request without Prefer
> returns 401
> 
> 
> 
> 
> -
> Failed Tests:
> -
> No tests ran.
> 
> --
> Build Log:
> --
> [...truncated 3 lines...]
> [INFO] Installing
> /ephemeral0/ovirt_engine_find_bugs/frontend/webadmin/modules/userportal-gwtp/pom.xml
> to
> /home/jenkins/workspace/ovirt_engine_find_bugs/.repository/org/ovirt/engine/ui/userportal/3.3.0-SNAPSHOT/userportal-3.3.0-SNAPSHOT.pom
> [INFO]
> [INFO] --- findbugs-maven-plugin:2.5.2:findbugs (default-cli) @
> userportal ---
> [INFO] Fork Value is true
>  [java] Warnings generated: 12
> [INFO] Done FindBugs Analysis
> [INFO]
> [INFO]
> 
> [INFO] Building oVirt Server EAR 3.3.0-SNAPSHOT
> [INFO]
> 
> [WARNING] The POM for org.eclipse.m2e:lif

[Engine-devel] [JENKINS][ANN] jenkins.ovirt.org new look and infra

2013-03-05 Thread Eyal Edri
fyi,

Starting from yesterday (4/3/13) jenkins.ovirt.org [1] has migrated to a new 
hosting server provided by alterway [2].
the new server has a new ui look that is similar to ovirt.org and is running on 
stronger infra then the previous one.

All jobs and configuration have migrated from the old instance,
but if you're still missing a certain job or permissions please contact infra 
team at in...@ovirt.org.

I want to thank David caro from the infra team in helping with the migration 
and einav cohen from the 
ovirt frontend developer community for helping with the new css for jenkins.


[1] http://jenkins.ovirt.org/
[2] http://www.ovirt.org/Sponsors_and_supporters

Eyal Edri
oVirt infra team.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] "find bugs" - please solve the following

2013-03-05 Thread Eyal Edri


- Original Message -
> From: "Vojtech Szocs" 
> To: "Einav Cohen" 
> Cc: "engine-devel" , "Eyal Edri" , 
> "Michael Kublin" ,
> "Frantisek Kobzik" , "Libor Spevak" 
> Sent: Monday, March 4, 2013 8:11:08 PM
> Subject: Re: "find bugs" - please solve the following
> 
> Hi,
> 
> just a small note on how you can invoke findbugs-maven-plugin
> manually:
> 
>   $ cd 
>   $ mvn clean site -Preporting
> 
> after that, just open
> /target/site/findbugs.html
> 

or use eclipse findbugs plugin 
http://findbugs.sourceforge.net/manual/eclipse.html

> Regards,
> Vojtech
> 
> 
> - Original Message -
> From: "Einav Cohen" 
> To: "Vojtech Szocs" , "Michael Kublin"
> , "Frantisek Kobzik" ,
> "Libor Spevak" 
> Cc: "engine-devel" , "Eyal Edri"
> 
> Sent: Sunday, March 3, 2013 6:48:00 PM
> Subject: "find bugs" - please solve the following
> 
> @Vojtech:
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3648/findbugsResult/NORMAL/file.-1256403867/source.1011/#436
> warning introduced by the "Resizable Table Columns" commit
> [http://gerrit.ovirt.org/#/c/5243/]
> 
> @Kublin:
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3648/findbugsResult/NORMAL/file.1463187495/source.486/#24
> last update of relevant line was in "Fixing possible
> ConcurrentModificationException" commit
> [http://gerrit.ovirt.org/#/c/8436]
> 
> @Frantisek:
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3648/findbugsResult/NORMAL/file.1591650016/category.-675839583/source.580/#43
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3648/findbugsResult/NORMAL/file.1591650016/category.1731749696/source.579/#22
> file introduced in "Non-plugin automatic invocation of console
> session" [http://gerrit.ovirt.org/#/c/11702/]
> 
> @Libor:
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3648/findbugsResult/NORMAL/file.742587459/source.1588/#176
> last update of relevant line was in " webadmin,userportal: Show data
> centers and their clusters based on configured cluster service"
> [http://gerrit.ovirt.org/#/c/11395]
> 
> 
> - Forwarded Message -
> From: "Eyal Edri" 
> To: engine-patc...@ovirt.org, "engine-devel" 
> Cc: dc...@redhat.com
> Sent: Sunday, March 3, 2013 8:11:55 AM
> Subject: Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs -
> Build # 3652 - Still Unstable!
> 
> New patches inserted NORMAL priority find bugs,
> please review and fix asap:
> 
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/changes
> 
> E.
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] [JENKINS] new job on jenkins.ovirt.org - verify errors codes on engine <-> vdsm

2013-03-06 Thread Eyal Edri
fyi,

a new job has been added (more liked fixed) - 
http://jenkins.ovirt.org/view/vdsm/job/vdsm_verify_error_codes/

Job Desc:
"
The purpose of this jenkins job is verify each error code reported by VDSM 
has a correlated message on the engine side, else we get the 'Unexpected error'.

The missing error code should be added to: 
ovirt-engine/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
  and the error message to: 
ovirt-engine/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties

If a specific VDSM error code should not be reported by VDSM and needed to be 
ignored, we can add it to the 'ignored list' of the jenkins job.
"

please notice if this job breaks after your commit, it will probably mean you 
changed/added an error code in one
component but not in the other.


eyal edri
oVirt infra team.


___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [JENKINS][ANN] jenkins.ovirt.org new look and infra

2013-03-06 Thread Eyal Edri


- Original Message -
> From: "Itamar Heim" 
> To: "Eyal Edri" 
> Cc: us...@ovirt.org, "engine-devel" , 
> vdsm-de...@lists.fedorahosted.org, "infra"
> 
> Sent: Wednesday, March 6, 2013 11:37:29 PM
> Subject: Re: [JENKINS][ANN] jenkins.ovirt.org new look and infra
> 
> On 03/05/2013 10:01 AM, Eyal Edri wrote:
> > fyi,
> >
> > Starting from yesterday (4/3/13) jenkins.ovirt.org [1] has migrated
> > to a new hosting server provided by alterway [2].
> > the new server has a new ui look that is similar to ovirt.org and
> > is running on stronger infra then the previous one.
> >
> > All jobs and configuration have migrated from the old instance,
> > but if you're still missing a certain job or permissions please
> > contact infra team at in...@ovirt.org.
> >
> > I want to thank David caro from the infra team in helping with the
> > migration and einav cohen from the
> > ovirt frontend developer community for helping with the new css for
> > jenkins.
> >
> >
> > [1] http://jenkins.ovirt.org/
> > [2] http://www.ovirt.org/Sponsors_and_supporters
> >
> > Eyal Edri
> > oVirt infra team.
> > ___
> > Infra mailing list
> > in...@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> 
> finally... (and looks very nice)
> can we shutdown the ec2 instance for now?

not yet, me & quaid should change the dns 1st (tomorrow)? 
and then we can do it.

> do we have more horsepower to start running say engine findbugs on
> gerrit patches?

not really, since we're still using the same ec2 slaves.
(unless we'll run it on the master, but that's not recommended in terms of 
security)
once we'll have ovirt instance running with vms, i imagine we can. 
hopefully we'll have it running soon (either on alterway02 or on the rackspace 
servers)

> 
> Thanks,
> Itamar
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [JENKINS][ANN] jenkins.ovirt.org new look and infra

2013-03-07 Thread Eyal Edri


- Original Message -
> From: "Karsten 'quaid' Wade" 
> To: "Eyal Edri" 
> Cc: "Itamar Heim" , us...@ovirt.org, "engine-devel" 
> ,
> vdsm-de...@lists.fedorahosted.org, "infra" 
> Sent: Thursday, March 7, 2013 2:34:49 AM
> Subject: Re: [JENKINS][ANN] jenkins.ovirt.org new look and infra
> 
> On 03/06/2013 01:43 PM, Eyal Edri wrote:
> > 
> > 
> > - Original Message -
> >> From: "Itamar Heim" 
> >> can we shutdown the ec2 instance for now?
> > 
> > not yet, me & quaid should change the dns 1st (tomorrow)?
> > and then we can do it.
> 
> If the host thinks it's already jenkins.ovirt.org, then we can just
> do
> the DNS switch "soonest". Do we need to coordinate more closely on
> timing? Otherwise I can just file the ticket. (I'll wait for your
> word
> before picking a time.)

i think we're OK with moving it:
i changed all configuration files & hostname on alterway01 to be 
jenkins.ovirt.org,
so we just need to point jenkins.ovirt.org to alterway01.ovirt.org (ip) in dns 
i belive.

so go a head and open the ticket.

itamar, let's wait with deleting the vm until we're sure it's OK?

> 
> >> do we have more horsepower to start running say engine findbugs on
> >> gerrit patches?
> > 
> > not really, since we're still using the same ec2 slaves.
> > (unless we'll run it on the master, but that's not recommended in
> > terms of security)
> > once we'll have ovirt instance running with vms, i imagine we can.
> > hopefully we'll have it running soon (either on alterway02 or on
> > the rackspace servers)
> 
> I was supposed to be working RackSpace servers today, but I got
> caught
> up in being a bit sick and post-travel. But the plan is to load F18 +
> the oVirt all-in-one on rax01.
> 
> - Karsten
> --
> Karsten 'quaid' Wade, Sr. Analyst - Community Growth
> http://TheOpenSourceWay.org  .^\  http://community.redhat.com
> @quaid (identi.ca/twitter/IRC)  \v'  gpg: AD0E0C41
> 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3737 - Still Unstable!

2013-03-14 Thread Eyal Edri
Latest commit introduced new NORMAL findbugs, please fix.

eyal.
infra team.

- Original Message -
> From: "Jenkins ci oVirt Server" 
> To: ee...@redhat.com, engine-patc...@ovirt.org, ol...@redhat.com, 
> yzasl...@redhat.com, dc...@redhat.com,
> gerr...@gerrit.ovirt.org
> Sent: Thursday, March 14, 2013 12:32:10 AM
> Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3737 - Still 
> Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3737/
> Build Number: 3737
> Build Status:  Still Unstable
> Triggered By: Started by an SCM change
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #3733
> [Michael Kublin] engine: Making all internal actions to have same
> correlationId
> 
> 
> Changes for Build #3734
> [Gerrit Code Review] webadmin: Attach disk - verify valid selection
> 
> [Gerrit Code Review] webadmin: Make Template dialog - style
> modifications
> 
> [Gerrit Code Review] webadmin: About dialog - remove redundant code
> 
> 
> Changes for Build #3735
> [Allon Mureinik] core: AuditLogableBaseTest synthetic access
> 
> [Allon Mureinik] core: TestAuditLoggableBase serial warning
> 
> 
> Changes for Build #3736
> [Kiril Nesenko] webadmin: Change default doc path.
> 
> 
> Changes for Build #3737
> [Gerrit Code Review] db: do not write to dbscripts after installation
> 
> 
> 
> 
> -
> Failed Tests:
> -
> No tests ran.
> 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] [EL6 RPMS] new nightly ovirt rpms

2013-03-14 Thread Eyal Edri
fyi,

EL6 rpms for various ovirt project are now available via the nightly repos:

http://resources.ovirt.org/releases/nightly/rpm/EL/6/noarch/

Eyal.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Sandro Bonazzola as a tools maintainer

2013-03-18 Thread Eyal Edri
+1, i know sandro and familiar with his major contribution in
the past few months to the tools code.

Eyal.

- Original Message -
> From: "Keith Robertson" 
> To: engine-devel@ovirt.org
> Sent: Monday, March 18, 2013 5:16:34 PM
> Subject: [Engine-devel] Sandro Bonazzola as a tools maintainer
> 
> I would like to propose that we add Sandro Bonazzola as a maintainer
> for
> the Ovirt ISO Uploader, Image Uploader and Log Collector.  He too has
> been enormously helpful with the maintenance of the tools.
> 
> Thanks,
> Keith Robertson
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Kiril Nesenko as a tools maintainer

2013-03-18 Thread Eyal Edri
+1, 

kiril has been building and contributing to these oVirt tools for some time now.


- Original Message -
> From: "Keith Robertson" 
> To: engine-devel@ovirt.org
> Cc: "Kiril Nesenko" 
> Sent: Monday, March 18, 2013 5:13:24 PM
> Subject: [Engine-devel] Kiril Nesenko as a tools maintainer
> 
> I would like to propose that we add Kiril Nesenko as a maintainer for
> the Ovirt ISO Uploader, Image Uploader and Log Collector.  He has
> been
> enormously helpful with the maintenance of the tools.
> 
> Thanks,
> Keith Robertson
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3868 - Still Unstable!

2013-04-03 Thread Eyal Edri
fyi,

these commits introduced new HIGH priority BUGS (via findbugs) [1]:

[Gerrit Code Review] webadmin: Disable destroy on Storage Domain when active
[Gerrit Code Review] webadmin: Added POSIX options in Storage general sub tab
[Gerrit Code Review] webadmin: Added NFS advanced options in Storage general

please fix asap,

Eyal Edri
oVirt infra team

[1] 
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3868/findbugsResult/HIGH/?

- Original Message -
> From: "Jenkins ci oVirt Server" 
> To: ee...@redhat.com, engine-patc...@ovirt.org, ol...@redhat.com, 
> yzasl...@redhat.com, dc...@redhat.com,
> gerr...@gerrit.ovirt.org
> Sent: Thursday, April 4, 2013 8:52:43 AM
> Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3868 - Still 
> Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3868/
> Build Number: 3868
> Build Status:  Still Unstable
> Triggered By: Started by an SCM change
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #3862
> [Gerrit Code Review] webadmin: Disable destroy on Storage Domain when active
> 
> [Gerrit Code Review] webadmin: Added POSIX options in Storage general sub tab
> 
> [Gerrit Code Review] webadmin: Added NFS advanced options in Storage general
> sub tab
> 
> 
> Changes for Build #3863
> [Gerrit Code Review] Revert "core: on handing over a VM mark it as
> MigratingTo"
> 
> 
> Changes for Build #3864
> [Gerrit Code Review] webadmin: 'Vnic status' column was truncated in 'ja'
> locale
> 
> [Gerrit Code Review] Edit Network dialog is cropped in 'es' locale
> 
> [Einav Cohen] webadmin, userportal: translations update
> 
> 
> Changes for Build #3865
> [Einav Cohen] webadmin, userportal: introducing German (de) - part 1
> 
> [Einav Cohen] userportal, webadmin: introducing German (de) - part 2
> 
> [Gerrit Code Review] history: fixed user usage data collection (#926952)
> 
> [Gerrit Code Review] history: fixed storage domain status collection
> (#922499)
> 
> 
> Changes for Build #3866
> [Gerrit Code Review] core: on handing over a VM mark it as MigratingTo
> 
> 
> Changes for Build #3867
> [Einav Cohen] webadmin: remove hide popup feature.
> 
> 
> Changes for Build #3868
> [Gerrit Code Review] pki: cleanup: Found reliance on default encoding
> 
> 
> 
> 
> -
> Failed Tests:
> -
> No tests ran.
> 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] find-bugs errors - please investigate/fix

2013-04-24 Thread Eyal Edri
thanks for the fix.

Also,

finally we see some progress on the 'low' priority bugs, fixing 337, 
which now stands on ~1600 instead of ~1900...

http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4073/findbugsResult/?

Eyal.

- Original Message -
> From: "Einav Cohen" 
> To: "Sahina Bose" , "Michal Skrivanek" 
> , "Tal Nisan"
> 
> Cc: "engine-devel" , "Eyal Edri" 
> Sent: Wednesday, April 24, 2013 3:48:34 PM
> Subject: Re: [Engine-devel] find-bugs errors - please investigate/fix
> 
> it seems that after the fixes and clean-up, find-bugs is now back to normal:
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4073/
> 
> all - many thanks for your prompt response!
> 
> 
> Regards,
> Einav
> 
> ----- Original Message -
> > From: "Einav Cohen" 
> > To: "Sahina Bose" , "Michael Kublin"
> > , "Michal Skrivanek"
> > , "Eyal Edri" 
> > Cc: "engine-devel" 
> > Sent: Tuesday, April 23, 2013 10:17:20 PM
> > Subject: [Engine-devel] find-bugs errors - please investigate/fix
> > 
> > ovirt find-bugs errors in jenkins - please investigate/fix asap.
> > [@Eyal - FYI: some of them seem really strange - see Michal's section
> > below]
> > 
> > @Sahina Bose:
> > find-bugs error details:
> > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23
> > caused by: http://gerrit.ovirt.org/#/c/13831/
> > 
> > @Michael Kublin:
> > find-bugs error details:
> > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346
> > caused by:
> > http://gerrit.ovirt.org/#/c/13740/
> > 
> > @Michal Skrivanek:
> > 
> > the following seem strange - can you please investigate? could be false
> > positives.
> > 
> > - find-bugs error details:
> > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349
> > [not sure when introduced - seems old, hence I suspect it is a false
> > positive]
> > 
> > - Two additional errors in the same file as ^^^, you can see them at:
> > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/
> > when clicking on them, there aren't any details, however according to their
> > tool-tips, it seems to be an "unreachable
> > OnSuccess method within an anonymous class" or something similar.
> > 
> > - another suspicious error is in VmListModel.java:
> > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406
> > [again - not sure when introduced - seems old, hence I suspect it is a
> > false
> > positive]
> > 
> > 
> > Thanks,
> > Einav
> > ___
> > Engine-devel mailing list
> > Engine-devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] findbugs [normal priority] - *please fix ASAP*

2013-05-29 Thread Eyal Edri
thanks guys for the help, 

we're planning to add a findbugs jos to run per patch so you'll be able to see 
it before merging.

Eyal.

- Original Message -
> From: "Einav Cohen" 
> To: "Yair Zaslavsky" , "Lior Vernia" 
> , "Daniel Erez" 
> Cc: "engine-devel" 
> Sent: Wednesday, May 29, 2013 12:03:35 AM
> Subject: Re: [Engine-devel] findbugs [normal priority] - *please fix ASAP*
> 
> many thanks Yair/Lior/Derez for checking/fixing/reviewing/verifying/merging.
> findbugs is now back to green:
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4338/
> 
> 
> Regards,
> Einav
> 
> - Original Message -
> > From: "Yair Zaslavsky" 
> > To: "Einav Cohen" 
> > Cc: "engine-devel" 
> > Sent: Monday, May 27, 2013 8:17:03 AM
> > Subject: Re: [Engine-devel] findbugs [normal priority] - *please fix ASAP*
> > 
> > 
> > 
> > - Original Message -
> > > From: "Einav Cohen" 
> > > To: "engine-devel" 
> > > Sent: Monday, May 27, 2013 3:07:55 PM
> > > Subject: [Engine-devel] findbugs [normal priority] - *please fix ASAP*
> > > 
> > > lvernia:
> > > find bugs error:
> > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4323/findbugsResult/NORMAL/module.935532853/source.199038/#60
> > > in file:
> > > frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Uri.java
> > > caused by patch:
> > > http://gerrit.ovirt.org/#/c/14695/ [webadmin: Added validation to
> > > ProviderModel, merged: May 27]
> > > 
> > > 
> > > 
> > > mkublin:
> > > find bugs error:
> > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4323/findbugsResult/NORMAL/module.-609324659/source.198236/#342
> > > in file:
> > > backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
> > > caused by patch:
> > > http://gerrit.ovirt.org/#/c/13740/ [engine: Fixing perfomance issue
> > > between
> > > VdsRunTimeInfo and RunVmCommandBase, merged: Apr 10]
> > 
> > This should have been handled by the findbugs filter . The fact that it was
> > not handled means we still have an issue with filters.
> > I'm taking a look.
> > 
> > > 
> > > 
> > > Thanks,
> > > Einav
> > > ___
> > > Engine-devel mailing list
> > > Engine-devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > 
> > ___
> > Engine-devel mailing list
> > Engine-devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> > 
> > 
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] [JENKINS][GERRIT][ANN] new jenkins jobs added to run per patch on ovirt-engine

2013-05-30 Thread Eyal Edri
fyi,

starting from now a new jenkins job [1] will run on every patch in ovirt-engine 
that has java files in it. 
the job will verify:

 1. compilation
 2. findbugs (HIGH + NORMAL)

if your patch will fail in one of the above, jenkins will give -1 to the patch 
and you'll have to send a new patchset to fix it.
if the failure was not justified (infra error/network/etc...) - contact 
in...@ovirt.org and you can re-trigger your job manually [2],
by searching for your commit sha or changeid.


Eyal Edri
ovirt infra team.


[1] http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/
[2] http://jenkins.ovirt.org/gerrit_manual_trigger/?
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still Unstable!

2013-06-07 Thread Eyal Edri
fyi,

your last commits add NORAMAL & HIGH priority FINDBUGS issues.

please resolve asap.

http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4389/changes#detail

Eyal.

- Original Message -
> From: "Jenkins ci oVirt Server" 
> To: ee...@redhat.com, yzasl...@redhat.com, dc...@redhat.com, "juan hernandez" 
> 
> Sent: Friday, June 7, 2013 3:09:59 PM
> Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still 
> Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4393/
> Build Number: 4393
> Build Status:  Still Unstable
> Triggered By: Started by an SCM change
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #4389
> [Shahar Havivi] findbugs: resultSet is not close after use
> 
> [Shahar Havivi] findbugs: inaccurate floating point comparison
> 
> [Shahar Havivi] findbugs: Unwritten public fields
> 
> [Alona Kaplan] engine: multiple gateways
> 
> 
> Changes for Build #4390
> [Alon Bar-Lev] novnc: no need to raise terminate exception on termination
> 
> 
> Changes for Build #4391
> [Alon Bar-Lev] novnc: cleanup defaults file
> 
> [Alon Bar-Lev] novnc: log file is actually trace file
> 
> [Alon Bar-Lev] novnc: override get_target instead of new_client
> 
> [Alon Bar-Lev] novnc: use service debug instead of configuration
> 
> [Alon Bar-Lev] packaging: service: add debug when module returns
> 
> 
> Changes for Build #4392
> [Sahina Bose] engine: Multiple gateways test failure fixed
> 
> 
> Changes for Build #4393
> [Juan Hernandez] core: Make GUID encoders singletons
> 
> 
> 
> 
> -
> Failed Tests:
> -
> No tests ran.
> 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still Unstable!

2013-06-08 Thread Eyal Edri


- Original Message -
> From: "Shahar Havivi" 
> To: "Eyal Edri" 
> Cc: "Alona Kaplan" , "engine-devel" 
> , "infra" 
> Sent: Saturday, June 8, 2013 4:10:07 PM
> Subject: Re: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still 
> Unstable!
> 
> On 07.06.13 15:36, Eyal Edri wrote:
> > fyi,
> > 
> > your last commits add NORAMAL & HIGH priority FINDBUGS issues.
> > 
> > please resolve asap.
> Need to check,
> Please note that when fixing a findbugs issue a new issue/s can be found.

1. you can run findbugs maven plugin before you merge your patch (via command 
line / eclipse plugin).
2. we're working on enabling the findbugs per patch as soon as gerrit is back 
to normal state.

> > 
> > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4389/changes#detail
> > 
> > Eyal.
> > 
> > - Original Message -
> > > From: "Jenkins ci oVirt Server" 
> > > To: ee...@redhat.com, yzasl...@redhat.com, dc...@redhat.com, "juan
> > > hernandez" 
> > > Sent: Friday, June 7, 2013 3:09:59 PM
> > > Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still
> > > Unstable!
> > > 
> > > Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> > > Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4393/
> > > Build Number: 4393
> > > Build Status:  Still Unstable
> > > Triggered By: Started by an SCM change
> > > 
> > > -
> > > Changes Since Last Success:
> > > -
> > > Changes for Build #4389
> > > [Shahar Havivi] findbugs: resultSet is not close after use
> > > 
> > > [Shahar Havivi] findbugs: inaccurate floating point comparison
> > > 
> > > [Shahar Havivi] findbugs: Unwritten public fields
> > > 
> > > [Alona Kaplan] engine: multiple gateways
> > > 
> > > 
> > > Changes for Build #4390
> > > [Alon Bar-Lev] novnc: no need to raise terminate exception on termination
> > > 
> > > 
> > > Changes for Build #4391
> > > [Alon Bar-Lev] novnc: cleanup defaults file
> > > 
> > > [Alon Bar-Lev] novnc: log file is actually trace file
> > > 
> > > [Alon Bar-Lev] novnc: override get_target instead of new_client
> > > 
> > > [Alon Bar-Lev] novnc: use service debug instead of configuration
> > > 
> > > [Alon Bar-Lev] packaging: service: add debug when module returns
> > > 
> > > 
> > > Changes for Build #4392
> > > [Sahina Bose] engine: Multiple gateways test failure fixed
> > > 
> > > 
> > > Changes for Build #4393
> > > [Juan Hernandez] core: Make GUID encoders singletons
> > > 
> > > 
> > > 
> > > 
> > > -
> > > Failed Tests:
> > > -
> > > No tests ran.
> > > 
> > > 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still Unstable!

2013-06-09 Thread Eyal Edri
thanks.

once it's merged and job is back to stable, we'll enable back the per-patch job.

eyal.

- Original Message -
> From: "Shahar Havivi" 
> To: "Eyal Edri" 
> Cc: "Alona Kaplan" , "engine-devel" 
> , "infra" 
> Sent: Sunday, June 9, 2013 11:21:07 AM
> Subject: Re: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 - Still 
> Unstable!
> 
> it was my commit and I sent a fix to:
> http://gerrit.ovirt.org/#/c/15474/
> 
> On 08.06.13 16:46, Eyal Edri wrote:
> > 
> > 
> > - Original Message -
> > > From: "Shahar Havivi" 
> > > To: "Eyal Edri" 
> > > Cc: "Alona Kaplan" , "engine-devel"
> > > , "infra" 
> > > Sent: Saturday, June 8, 2013 4:10:07 PM
> > > Subject: Re: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 -
> > > Still Unstable!
> > > 
> > > On 07.06.13 15:36, Eyal Edri wrote:
> > > > fyi,
> > > > 
> > > > your last commits add NORAMAL & HIGH priority FINDBUGS issues.
> > > > 
> > > > please resolve asap.
> > > Need to check,
> > > Please note that when fixing a findbugs issue a new issue/s can be found.
> > 
> > 1. you can run findbugs maven plugin before you merge your patch (via
> > command line / eclipse plugin).
> > 2. we're working on enabling the findbugs per patch as soon as gerrit is
> > back to normal state.
> > 
> > > > 
> > > > http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4389/changes#detail
> > > > 
> > > > Eyal.
> > > > 
> > > > - Original Message -
> > > > > From: "Jenkins ci oVirt Server" 
> > > > > To: ee...@redhat.com, yzasl...@redhat.com, dc...@redhat.com, "juan
> > > > > hernandez" 
> > > > > Sent: Friday, June 7, 2013 3:09:59 PM
> > > > > Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4393 -
> > > > > Still
> > > > > Unstable!
> > > > > 
> > > > > Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> > > > > Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4393/
> > > > > Build Number: 4393
> > > > > Build Status:  Still Unstable
> > > > > Triggered By: Started by an SCM change
> > > > > 
> > > > > -
> > > > > Changes Since Last Success:
> > > > > -
> > > > > Changes for Build #4389
> > > > > [Shahar Havivi] findbugs: resultSet is not close after use
> > > > > 
> > > > > [Shahar Havivi] findbugs: inaccurate floating point comparison
> > > > > 
> > > > > [Shahar Havivi] findbugs: Unwritten public fields
> > > > > 
> > > > > [Alona Kaplan] engine: multiple gateways
> > > > > 
> > > > > 
> > > > > Changes for Build #4390
> > > > > [Alon Bar-Lev] novnc: no need to raise terminate exception on
> > > > > termination
> > > > > 
> > > > > 
> > > > > Changes for Build #4391
> > > > > [Alon Bar-Lev] novnc: cleanup defaults file
> > > > > 
> > > > > [Alon Bar-Lev] novnc: log file is actually trace file
> > > > > 
> > > > > [Alon Bar-Lev] novnc: override get_target instead of new_client
> > > > > 
> > > > > [Alon Bar-Lev] novnc: use service debug instead of configuration
> > > > > 
> > > > > [Alon Bar-Lev] packaging: service: add debug when module returns
> > > > > 
> > > > > 
> > > > > Changes for Build #4392
> > > > > [Sahina Bose] engine: Multiple gateways test failure fixed
> > > > > 
> > > > > 
> > > > > Changes for Build #4393
> > > > > [Juan Hernandez] core: Make GUID encoders singletons
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > -
> > > > > Failed Tests:
> > > > > -
> > > > > No tests ran.
> > > > > 
> > > > > 
> > > 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4398 - Still Unstable!

2013-06-09 Thread Eyal Edri
fyi,

findbugs is still failing on NORMAL priority bugs.
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4398/findbugsResult/NORMAL/?


Commit 44687e0b885a478e3ddbd39376be5d4e9beb07d1 by Shahar Havivi
findbugs: remove unread fields

Change-Id: Ied4990cd90e58e566679851b3e2c5dcde05629cd


please resolve asap, this might hide other new bugs introduced. 

Eyal.
infra team.


- Original Message -
> From: "Jenkins ci oVirt Server" 
> To: ee...@redhat.com, yzasl...@redhat.com, dc...@redhat.com, 
> shav...@redhat.com, abo...@redhat.com
> Sent: Sunday, June 9, 2013 3:48:10 PM
> Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4398 - Still 
> Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4398/
> Build Number: 4398
> Build Status:  Still Unstable
> Triggered By: Started by an SCM change, Started by an SCM change
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #4389
> [Shahar Havivi] findbugs: resultSet is not close after use
> 
> [Shahar Havivi] findbugs: inaccurate floating point comparison
> 
> [Shahar Havivi] findbugs: Unwritten public fields
> 
> [Alona Kaplan] engine: multiple gateways
> 
> 
> Changes for Build #4390
> [Alon Bar-Lev] novnc: no need to raise terminate exception on termination
> 
> 
> Changes for Build #4391
> [Alon Bar-Lev] novnc: cleanup defaults file
> 
> [Alon Bar-Lev] novnc: log file is actually trace file
> 
> [Alon Bar-Lev] novnc: override get_target instead of new_client
> 
> [Alon Bar-Lev] novnc: use service debug instead of configuration
> 
> [Alon Bar-Lev] packaging: service: add debug when module returns
> 
> 
> Changes for Build #4392
> [Sahina Bose] engine: Multiple gateways test failure fixed
> 
> 
> Changes for Build #4393
> [Juan Hernandez] core: Make GUID encoders singletons
> 
> 
> Changes for Build #4394
> [Shahar Havivi] findbugs: fix for inaccurate floating point comparison
> 
> 
> Changes for Build #4395
> [Ori Liel] restapi: RSDL rename power_management.user_name-->username
> (#969097)
> 
> 
> Changes for Build #4396
> [Ori Liel] restapi: RSDL Missing 'fence_type' param - #969797
> 
> [Ravi Nori] restapi : memory_policy-guaranteed option doesn't exists in 'add
> vm' autocompletion
> 
> 
> Changes for Build #4397
> [Moti Asayag] engine: Use NetworkUtils.getEngineNetwork where possible
> 
> [Moti Asayag] engine: Some network cleanups
> 
> 
> Changes for Build #4398
> [Alissa Bonas] core: rename methods to start with lowercase
> 
> [Shahar Havivi] findbugs: ignore: Log interface should not be the same as the
> implemented class name
> 
> [Shahar Havivi] findbugs: ignore Unwritten public fields
> 
> [Shahar Havivi] findbugs: remove unread fields
> 
> 
> 
> 
> -
> Failed Tests:
> -
> No tests ran.
> 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] Failures on findbugs - ovirt-engine

2013-06-23 Thread Eyal Edri
fyi,

Findbugs has a new 1 NORMAL priority failure in jenkins.ovirt.org [1]
it seems that the patch that introduced it had a failure from jenkins [2], 
probably on the same issue.

Any reason why this was ignored/overlooked in the patch before merging it ?
(rebasing the patch retriggered the job that didn't complete on the 2nd run).

Please contact any infra team member if you see a failure that you think is 
wrong or not relevant,
before merging. 

The reason we have these jobs is exactly to stop such regressions from 
happening post merge. 
it is important to acknowledge those errors and address them, even if might be 
false positives some times. 

hopefully we'll soon have more powerful slaves to run those gerrit jobs and 
they will finish faster. 

[1] 
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4492/findbugsResult/NORMAL/?
[2] http://gerrit.ovirt.org/#/c/15783/

thank you

Eyal
ovirt infra team.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] checkstyle and tools project

2013-06-24 Thread Eyal Edri
Can we add a gerrit hook to run checkstyle on the code?
rather than waiting it to be merged and fail on jenkins? 

- Original Message -
> From: "Laszlo Hornyak" 
> To: "engine-devel" 
> Sent: Monday, June 24, 2013 11:15:38 AM
> Subject: [Engine-devel] checkstyle and tools project
> 
> Hi,
> 
> Checkstyle is not executed on tools project. I have sent a patch to gerrit to
> fix this, could you guys review?
> 
> http://gerrit.ovirt.org/15719
> 
> And there are some more cleanup patches for tools:
> http://gerrit.ovirt.org/15720
> http://gerrit.ovirt.org/15721
> http://gerrit.ovirt.org/15722
> 
> 
> Thank you,
> Laszlo
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] unit tests failing

2013-06-24 Thread Eyal Edri
fyi,

there are 11 unit tests failing on engine:
http://jenkins.ovirt.org/view/ovirt_engine/job/ovirt_engine_unit_tests/4398/

starting from these builds:
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/4398/
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/4411/#showFailuresLink


please check/fix.

Eyal.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] checkstyle and tools project

2013-06-24 Thread Eyal Edri
i believe it's running by default every time you run mvn compile (or install),
so actually findbugs job will catch checkstyle errors too. (i.e fail to compile)

- Original Message -
> From: "Itamar Heim" 
> To: "Eyal Edri" 
> Cc: "Laszlo Hornyak" , "engine-devel" 
> , "infra" 
> Sent: Monday, June 24, 2013 9:57:02 PM
> Subject: Re: [Engine-devel] checkstyle and tools project
> 
> On 06/24/2013 05:28 PM, Eyal Edri wrote:
> > Can we add a gerrit hook to run checkstyle on the code?
> 
> i wouldn't want gerrit to build, but can we add this to jenkins job?
> 
> > rather than waiting it to be merged and fail on jenkins?
> >
> > - Original Message -
> >> From: "Laszlo Hornyak" 
> >> To: "engine-devel" 
> >> Sent: Monday, June 24, 2013 11:15:38 AM
> >> Subject: [Engine-devel] checkstyle and tools project
> >>
> >> Hi,
> >>
> >> Checkstyle is not executed on tools project. I have sent a patch to gerrit
> >> to
> >> fix this, could you guys review?
> >>
> >> http://gerrit.ovirt.org/15719
> >>
> >> And there are some more cleanup patches for tools:
> >> http://gerrit.ovirt.org/15720
> >> http://gerrit.ovirt.org/15721
> >> http://gerrit.ovirt.org/15722
> >>
> >>
> >> Thank you,
> >> Laszlo
> >> ___
> >> Engine-devel mailing list
> >> Engine-devel@ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> >>
> > ___
> > Engine-devel mailing list
> > Engine-devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> >
> 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Jenkins failure - findbugs failed: Timeout: killed the sub-process

2013-06-29 Thread Eyal Edri
i tried fixing this with alternating the timeout for mvn commnd:

clean install findbugs:findbugs -P findbugs-general -DskipTests 
-Dtimeout=120

according to http://mojo.codehaus.org/findbugs-maven-plugin/findbugs-mojo.html.

i will try increasing it even more.

- Original Message -
> From: "Douglas Schilling Landgraf" 
> To: engine-devel@ovirt.org
> Sent: Saturday, June 29, 2013 1:40:34 AM
> Subject: [Engine-devel] Jenkins failure - findbugs failed: Timeout: killed
> the sub-process
> 
> Hi,
> 
> Anyone else facing the below jenkins failure when sending patches to
> gerrit?
> 
> [ERROR] Failed to execute goal
> org.codehaus.mojo:findbugs-maven-plugin:2.5.2:findbugs (default-cli) on
> project jboss-modules-maven-plugin: Execution default-cli of goal
> org.codehaus.mojo:findbugs-maven-plugin:2.5.2:findbugs failed: Timeout:
> killed the sub-process -> [Help 1]
> 
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/2650/
> 
> Thanks!
> 
> --
> Cheers
> Douglas
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4555 - Unstable!

2013-07-01 Thread Eyal Edri
fyi.

- Original Message -
> From: "Jenkins ci oVirt Server" 
> To: ee...@redhat.com, yzasl...@redhat.com, dc...@redhat.com, 
> fkob...@redhat.com
> Sent: Monday, July 1, 2013 4:37:28 PM
> Subject: [oVirt Jenkins] ovirt_engine_find_bugs - Build # 4555 - Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4555/
> Build Number: 4555
> Build Status:  Unstable
> Triggered By: Started by an SCM change, Started by an SCM change
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #4555
> [Frantisek Kobzik] frontend: Make VNC implementation configurable from UI
> 
> 
> 
> 
> -
> Failed Tests:
> -
> No tests ran.
> 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Build step 'Publish FindBugs analysis results' changed build result to UNSTABLE

2013-07-01 Thread Eyal Edri
seems to be failing to due to last commit. frontend: Make VNC implementation 
configurable from UI (detail)

sent seperate email on it.

- Original Message -
> From: "Einav Cohen" 
> To: "Wei D Chen" , "Eyal Edri" 
> Cc: "engine-devel" , "Lijuan Zhang" 
> 
> Sent: Monday, July 1, 2013 4:47:40 PM
> Subject: Re: [Engine-devel] Build step 'Publish FindBugs analysis results' 
> changed build result to UNSTABLE
> 
> Hi Dave,
> 
> Typically, what you would want to do with find-bugs unstable jobs is to go
> to the job status page ([1] in your case) and look for the new warnings (in
> your case there are two new warnings, one of them is a High-priority warning
> that should be addressed in order to stabilize the job).
> 
> click on the "2 new warnings" link, and drill down to the red (high-priority)
> warning itself to see its details.
> 
> (@Eyal - it seems that there is a problem within of finding/copying files -
> see [2] - not sure if related)
> 
> 
> Thanks,
> Einav
> 
> [1] http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/2928/
> 
> [2]
> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/2928/findbugsResult/new/package.207693557/source.133782/#48
> 
> - Original Message -
> > From: "Wei D Chen" 
> > To: "engine-devel" 
> > Cc: "Lijuan Zhang" 
> > Sent: Monday, July 1, 2013 1:14:15 AM
> > Subject: [Engine-devel] Build step 'Publish FindBugs analysis results'
> > changed build result to UNSTABLE
> > 
> > Is there anyone know the reason for these error message? what can I do to
> > fix
> > it?
> > 
> > 
> > [INFO]
> > [INFO] --- maven-install-plugin:2.3.1:install (default-install) @
> > engine-server-ear ---
> > [INFO] Installing
> > /jenkins-workspaces/ovirt_engine_find_bugs_gerrit/ovirt-engine/ear/target/engine.ear
> > to
> > /home/jenkins/workspace/ovirt_engine_find_bugs_gerrit/.repository/org/ovirt/engine/engine-server-ear/3.3.0-SNAPSHOT/engine-server-ear-3.3.0-SNAPSHOT.ear
> > [INFO] Installing
> > /jenkins-workspaces/ovirt_engine_find_bugs_gerrit/ovirt-engine/ear/pom.xml
> > to
> > /home/jenkins/workspace/ovirt_engine_find_bugs_gerrit/.repository/org/ovirt/engine/engine-server-ear/3.3.0-SNAPSHOT/engine-server-ear-3.3.0-SNAPSHOT.pom
> > [INFO]
> > [INFO] --- findbugs-maven-plugin:2.5.2:findbugs (default-cli) @
> > engine-server-ear ---
> > [INFO]
> > 
> > [INFO] Reactor Summary:
> > [INFO]
> > [INFO] ovirt-root  SUCCESS [4.719s]
> > [INFO] oVirt Build Tools root  SUCCESS [0.129s]
> > [INFO] oVirt checkstyle .. SUCCESS [2.001s]
> > [INFO] oVirt JBoss Modules Maven Plugin .. SUCCESS
> > [39.769s]
> > [INFO] oVirt Checkstyle Checks ... SUCCESS
> > [27.944s]
> > [INFO] oVirt Modules - backend ... SUCCESS [0.054s]
> > [INFO] oVirt Manager . SUCCESS [0.052s]
> > [INFO] oVirt DB Scripts .. SUCCESS [0.210s]
> > [INFO] oVirt Engine dependencies . SUCCESS [2.262s]
> > [INFO] oVirt Modules - manager ... SUCCESS [1.150s]
> > [INFO] CSharp Compatibility .. SUCCESS
> > [36.770s]
> > [INFO] Common Code ... SUCCESS
> > [1:43.000s]
> > [INFO] Common utilities .. SUCCESS
> > [1:15.054s]
> > [INFO] Data Access Layer . SUCCESS
> > [1:45.658s]
> > [INFO] engine scheduler bean . SUCCESS
> > [33.039s]
> > [INFO] Vds broker  SUCCESS
> > [1:41.045s]
> > [INFO] Search Backend  SUCCESS
> > [48.983s]
> > [INFO] Backend Logic @Service bean ... SUCCESS
> > [3:15.813s]
> > [INFO] oVirt RESTful API Backend Integration . SUCCESS [0.242s]
> > [INFO] oVirt RESTful API interface ... SUCCESS [0.334s]
> > [INFO] oVirt Engine API Definition ... SUCCESS
> > [1:04.592s]
> > [INFO] oVirt Engine API Commom Parent POM  SUCCESS [0.195s]
> > [INFO] oVirt Engine API Common JAX-RS  SUCCESS
> > [46.398s]
> > [INFO] oVirt R

[Engine-devel] [JENKINS][ANN] disabling jenkins gerrit job for findbugs

2013-07-02 Thread Eyal Edri
fyi,

due to multiple errors lately with the jenkins jobs that runs per patch on 
gerrit patches for engine,
infra team has disabled the job for now and enabled a basic compilation job 
instead. [1]

this is caused by a slow jenkins slave that doesn't have the capacity to handle 
the load of patches.
we're working hard on adding new and powerful jenkins slaves soon and hopefully 
by next week we can start using them.

for now, if you have a patch that has -1 from the 'gerrit findbugs' job you can:

1. contact gerrit admin (dcaro) to remove the jenkins user from that patch
2. if you'll send a new patchset, it will be removed automaticly.
3. contact in...@ovirt.org if need help/info 


sorry for the noise, hopefully we'll be able to enable it back soon with newer 
infra.

Eyal.
oVirt infra team.

[1] 
http://jenkins.ovirt.org/view/ovirt_engine/job/ovirt_engine_sanity_compile_checkstyle_gerrit/
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [Users] Linkedin oVirt company profile

2013-07-07 Thread Eyal Edri
+1.. 

great, i'm following it.
who's maintaining it now? (i.e adding news/events on future workshops and such)

- Original Message -
> From: "Kiril Nesenko" 
> To: "infra" , engine-devel@ovirt.org, us...@ovirt.org
> Sent: Sunday, July 7, 2013 2:02:03 PM
> Subject: [Users] Linkedin oVirt company profile
> 
> Hello,
> 
> I would like to introduce the new company profile[1] for oVirt project.
> You are more than welcome to join and follow the company profile.
> 
> [1] http://www.linkedin.com/company/ovirt?trk=top_nav_home
> 
> - Kiril
> ___
> Users mailing list
> us...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/users
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] Proposal for new commit msg design for engine commits

2013-07-09 Thread Eyal Edri
Hi,

You all probably know and familiar with 'ovirt-engine' git hook for commit msg 
template [1].
this helps understand the general area of the patch in the project but it lacks 
additional info that might
be valuable for scaling automatic tests in Jenkins CI.

Let me explain:

Infra team is working hard on expanding oVirt CI infrastructure and adding more 
tests in jenkins (per commit/patch).
Adding important meta-data per patch can significatly improve the ability to 
run specific tests for each patch/commit,
and not waste valuable resources on Jenkins jobs that are not relevant to the 
code in the patch.

So the idea is to add/expand current metadata per patch, in the form of: 
(either)
 1. expanding current header template to include more data like 'network' , 
'setup', 'tools', 'virt'
 2. adding a new label with relevant tags for the patch, called e.g 'METADATA: 
network, rest, virt'

Jenkins jobs will then be able to parse that data and trigger only relevant 
jobs for it.
this can also allow us to add more jobs per patch, an option that is very 
problematic today considering the amount of 
patches coming in to engine.

Once agreed on a format, we'll be able to add a git hook to verify the validity 
of the commit msg. (similar to bug-url). 

if we're not 100% sure that the tags will cover all corner cases and we feel 
like we need to run the code on all jobs,
we can a nightly job to run all the remaining jobs (but at least it won't run 
on every patch/commit).

[1] :


thoughts? 

Eyal Edri.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Proposal for new commit msg design for engine commits

2013-07-09 Thread Eyal Edri


- Original Message -
> From: "Fabian Deutsch" 
> To: "Alon Bar-Lev" 
> Cc: "engine-devel" , "infra" 
> Sent: Tuesday, July 9, 2013 3:54:06 PM
> Subject: Re: [Engine-devel] Proposal for new commit msg design for engine 
> commits
> 
> Am Dienstag, den 09.07.2013, 08:49 -0400 schrieb Alon Bar-Lev:
> > 
> > 
> > - Original Message -
> > > From: "Yair Zaslavsky" 
> > > To: "Alon Bar-Lev" 
> > > Cc: "Eyal Edri" , "engine-devel"
> > , "infra" 
> > > Sent: Tuesday, July 9, 2013 3:42:24 PM
> > > Subject: Re: [Engine-devel] Proposal for new commit msg design for
> > engine commits
> > > 
> > > 
> > > 
> > > - Original Message -
> > > > From: "Alon Bar-Lev" 
> > > > To: "Eyal Edri" 
> > > > Cc: "engine-devel" , "infra"
> > 
> > > > Sent: Tuesday, July 9, 2013 3:33:57 PM
> > > > Subject: Re: [Engine-devel] Proposal for new commit msg design for
> > engine
> > > > commits
> > > > 
> > > > 
> > > > 
> > > > - Original Message -
> > > > > From: "Eyal Edri" 
> > > > > To: "engine-devel" 
> > > > > Cc: "infra" 
> > > > > Sent: Tuesday, July 9, 2013 12:38:51 PM
> > > > > Subject: Proposal for new commit msg design for engine commits
> > > > > 
> > > > > Hi,
> > > > > 
> > > > > You all probably know and familiar with 'ovirt-engine' git hook
> > for
> > > > > commit
> > > > > msg template [1].
> > > > > this helps understand the general area of the patch in the
> > project but it
> > > > > lacks additional info that might
> > > > > be valuable for scaling automatic tests in Jenkins CI.
> > > > > 
> > > > > Let me explain:
> > > > > 
> > > > > Infra team is working hard on expanding oVirt CI infrastructure
> > and
> > > > > adding
> > > > > more tests in jenkins (per commit/patch).
> > > > > Adding important meta-data per patch can significatly improve
> > the ability
> > > > > to
> > > > > run specific tests for each patch/commit,
> > > > > and not waste valuable resources on Jenkins jobs that are not
> > relevant to
> > > > > the
> > > > > code in the patch.
> > > > > 
> > > > > So the idea is to add/expand current metadata per patch, in the
> > form of:
> > > > > (either)
> > > > >  1. expanding current header template to include more data like
> > 'network'
> > > > >  ,
> > > > >  'setup', 'tools', 'virt'
> > > > 
> > > > Please do not expand header, it is too short anyway.
> > > > 
> > > > >  2. adding a new label with relevant tags for the patch, called
> > e.g
> > > > >  'METADATA: network, rest, virt'
> > > > 
> > > > Having:
> > > > 
> > > > CI-Tests: xxx
> > > > CI-Tests: yyy
> > > > CI-Tests: zzz
> > > > 
> > > > Is much better.
> > > 
> > > I'm not sure we should have CI-Test - as we might use this for
> > something else
> > > besides CI.
> > > Region_of_Interest as Dan suggests sounds better IMHO.
> > 
> > I don't care how this is to be called.
> > However, I do not think that commit message is the place for
> > instructing CI to do anything.
> > Commit message stays for good, it should contain information that is
> > required a year from now.
> > It has nothing to do with tests and such.
> 
> I agree with Alon here that the Ci informations don't belong in the
> commit msg.
> My opinion is that a testcase should know what it covers. This
> information from the testcase can then be used by any party to determin
> if the testcase should be run on a specific commit (which yields
> informations about the changed paths, files, owner, author, etc ...
> which might be valuable).

i don't understand what you mean by "a testcase should know what it covers".
of course it does. that's not the problem though.
the problem is ovirt-engine has multiple components with him that apply to 
various 
fields, some patches are relevant to specific areas and not not.

so a "test case" (that clones ovirt-engine repo) can't know which tests to run 
if he doesn't have that info somewhere in the patch.

if we don't want info in the git commit msg, we can try using git notes [1]

but i think that this meta-data isn't all about ci jobs, it's about additional 
info on 
what the patch touches/adds. it can also help qa testing later to pinpoint 
where the code was changed
and perhaps enable the use of future automation scripts that can scan the 
commits 
and generate statics on coverage per subject/field.

[1]  https://www.kernel.org/pub/software/scm/git/docs/git-notes.html
 http://alblue.bandlem.com/2011/11/git-tip-of-week-git-notes.html
> 
> - fabian
> 
> ___
> Infra mailing list
> in...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Recommended mechanism to restart Jenkins

2013-07-09 Thread Eyal Edri
i assume you mean restarting a failing gerrit jenkins job and not the master 
server right?

there is a special link to exactly that, no need to rebases...

http://jenkins.ovirt.org/gerrit_manual_trigger/?

just put in your change id or sha1, click search and trigger it.

Eyal.

- Original Message -
> From: "Keith Robertson" 
> To: engine-devel@ovirt.org
> Cc: "Spenser Shumaker" 
> Sent: Tuesday, July 9, 2013 3:35:34 PM
> Subject: [Engine-devel] Recommended mechanism to restart Jenkins
> 
> What is the recommended mechanism to restart the oVirt Jenkins CI server job
> when it fails due to an issue unrelated to a pushed patch? Should I...
> 
> a) Add some newline/space to the commit message and re-push the patch (clunky
> but it shd work).
> b) Remove/add the 'oVirt Jenkins CI Server' reviewer from the Reviewer's list
> and re-add? (have no idea if this actually works)
> c) Something else here...
> 
> Keith
> 
> 
> Keith Robertson
> 1-919-754-4004
> 
> 
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Proposal for new commit msg design for engine commits

2013-07-10 Thread Eyal Edri


- Original Message -
> From: "Fabian Deutsch" 
> To: "Alon Bar-Lev" 
> Cc: "engine-devel" , "infra" 
> Sent: Tuesday, July 9, 2013 3:54:06 PM
> Subject: Re: [Engine-devel] Proposal for new commit msg design for engine 
> commits
> 
> Am Dienstag, den 09.07.2013, 08:49 -0400 schrieb Alon Bar-Lev:
> > 
> > 
> > - Original Message -
> > > From: "Yair Zaslavsky" 
> > > To: "Alon Bar-Lev" 
> > > Cc: "Eyal Edri" , "engine-devel"
> > , "infra" 
> > > Sent: Tuesday, July 9, 2013 3:42:24 PM
> > > Subject: Re: [Engine-devel] Proposal for new commit msg design for
> > engine commits
> > > 
> > > 
> > > 
> > > - Original Message -
> > > > From: "Alon Bar-Lev" 
> > > > To: "Eyal Edri" 
> > > > Cc: "engine-devel" , "infra"
> > 
> > > > Sent: Tuesday, July 9, 2013 3:33:57 PM
> > > > Subject: Re: [Engine-devel] Proposal for new commit msg design for
> > engine
> > > > commits
> > > > 
> > > > 
> > > > 
> > > > - Original Message -
> > > > > From: "Eyal Edri" 
> > > > > To: "engine-devel" 
> > > > > Cc: "infra" 
> > > > > Sent: Tuesday, July 9, 2013 12:38:51 PM
> > > > > Subject: Proposal for new commit msg design for engine commits
> > > > > 
> > > > > Hi,
> > > > > 
> > > > > You all probably know and familiar with 'ovirt-engine' git hook
> > for
> > > > > commit
> > > > > msg template [1].
> > > > > this helps understand the general area of the patch in the
> > project but it
> > > > > lacks additional info that might
> > > > > be valuable for scaling automatic tests in Jenkins CI.
> > > > > 
> > > > > Let me explain:
> > > > > 
> > > > > Infra team is working hard on expanding oVirt CI infrastructure
> > and
> > > > > adding
> > > > > more tests in jenkins (per commit/patch).
> > > > > Adding important meta-data per patch can significatly improve
> > the ability
> > > > > to
> > > > > run specific tests for each patch/commit,
> > > > > and not waste valuable resources on Jenkins jobs that are not
> > relevant to
> > > > > the
> > > > > code in the patch.
> > > > > 
> > > > > So the idea is to add/expand current metadata per patch, in the
> > form of:
> > > > > (either)
> > > > >  1. expanding current header template to include more data like
> > 'network'
> > > > >  ,
> > > > >  'setup', 'tools', 'virt'
> > > > 
> > > > Please do not expand header, it is too short anyway.
> > > > 
> > > > >  2. adding a new label with relevant tags for the patch, called
> > e.g
> > > > >  'METADATA: network, rest, virt'
> > > > 
> > > > Having:
> > > > 
> > > > CI-Tests: xxx
> > > > CI-Tests: yyy
> > > > CI-Tests: zzz
> > > > 
> > > > Is much better.
> > > 
> > > I'm not sure we should have CI-Test - as we might use this for
> > something else
> > > besides CI.
> > > Region_of_Interest as Dan suggests sounds better IMHO.
> > 
> > I don't care how this is to be called.
> > However, I do not think that commit message is the place for
> > instructing CI to do anything.
> > Commit message stays for good, it should contain information that is
> > required a year from now.
> > It has nothing to do with tests and such.
> 
> I agree with Alon here that the Ci informations don't belong in the
> commit msg.
> My opinion is that a testcase should know what it covers. This
> information from the testcase can then be used by any party to determin
> if the testcase should be run on a specific commit (which yields
> informations about the changed paths, files, owner, author, etc ...
> which might be valuable).

i think you're missing the point here.
can you explain how do you propose a test case will know "what it covers"? 

let's take an example: 
let's say a new commit comes from ovirt-engine: 
http://gerrit.ovirt.org/#/c/16668/
commit msg: "core: Use images instead of volumes at CDA message".

now you have 1000 test cases (could be system or functional test).
(let's assume that your infra can't support running 1000 tests per 
patch/commit). 

Some of these test suits checks network flow, some virt (migration/template for 
e.g), some host install, others storage flows and so on... ). 
you have one repo to clone (ovirt-engine, let's keep vdsm a side for a min), 
and to compile the project from for the tests.

now given this scenario, please explain how will you know which test from the 
1000 you have you'll run on it.
do you believe that according to the author/path/filename you'll know if that 
patch involves storage or virt scenario? 

i don't think there's an alternative to a metadata to assist mapping the patch 
to a relevant "topic" in the code.
whether it exists as a git note or a label in the commit, that's another matter 
and probably less important. 

eyal. 

> 
> - fabian
> 
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Proposal for new commit msg design for engine commits

2013-07-10 Thread Eyal Edri


- Original Message -
> From: "Itamar Heim" 
> To: "Eyal Edri" 
> Cc: "Fabian Deutsch" , "engine-devel" 
> , "infra" 
> Sent: Wednesday, July 10, 2013 10:37:03 PM
> Subject: Re: [Engine-devel] Proposal for new commit msg design for engine 
> commits
> 
> On 07/10/2013 10:27 PM, Eyal Edri wrote:
> >
> >
> > - Original Message -
> >> From: "Fabian Deutsch" 
> >> To: "Alon Bar-Lev" 
> >> Cc: "engine-devel" , "infra" 
> >> Sent: Tuesday, July 9, 2013 3:54:06 PM
> >> Subject: Re: [Engine-devel] Proposal for new commit msg design for engine
> >> commits
> >>
> >> Am Dienstag, den 09.07.2013, 08:49 -0400 schrieb Alon Bar-Lev:
> >>>
> >>>
> >>> - Original Message -
> >>>> From: "Yair Zaslavsky" 
> >>>> To: "Alon Bar-Lev" 
> >>>> Cc: "Eyal Edri" , "engine-devel"
> >>> , "infra" 
> >>>> Sent: Tuesday, July 9, 2013 3:42:24 PM
> >>>> Subject: Re: [Engine-devel] Proposal for new commit msg design for
> >>> engine commits
> >>>>
> >>>>
> >>>>
> >>>> - Original Message -
> >>>>> From: "Alon Bar-Lev" 
> >>>>> To: "Eyal Edri" 
> >>>>> Cc: "engine-devel" , "infra"
> >>> 
> >>>>> Sent: Tuesday, July 9, 2013 3:33:57 PM
> >>>>> Subject: Re: [Engine-devel] Proposal for new commit msg design for
> >>> engine
> >>>>>  commits
> >>>>>
> >>>>>
> >>>>>
> >>>>> - Original Message -
> >>>>>> From: "Eyal Edri" 
> >>>>>> To: "engine-devel" 
> >>>>>> Cc: "infra" 
> >>>>>> Sent: Tuesday, July 9, 2013 12:38:51 PM
> >>>>>> Subject: Proposal for new commit msg design for engine commits
> >>>>>>
> >>>>>> Hi,
> >>>>>>
> >>>>>> You all probably know and familiar with 'ovirt-engine' git hook
> >>> for
> >>>>>> commit
> >>>>>> msg template [1].
> >>>>>> this helps understand the general area of the patch in the
> >>> project but it
> >>>>>> lacks additional info that might
> >>>>>> be valuable for scaling automatic tests in Jenkins CI.
> >>>>>>
> >>>>>> Let me explain:
> >>>>>>
> >>>>>> Infra team is working hard on expanding oVirt CI infrastructure
> >>> and
> >>>>>> adding
> >>>>>> more tests in jenkins (per commit/patch).
> >>>>>> Adding important meta-data per patch can significatly improve
> >>> the ability
> >>>>>> to
> >>>>>> run specific tests for each patch/commit,
> >>>>>> and not waste valuable resources on Jenkins jobs that are not
> >>> relevant to
> >>>>>> the
> >>>>>> code in the patch.
> >>>>>>
> >>>>>> So the idea is to add/expand current metadata per patch, in the
> >>> form of:
> >>>>>> (either)
> >>>>>>   1. expanding current header template to include more data like
> >>> 'network'
> >>>>>>   ,
> >>>>>>   'setup', 'tools', 'virt'
> >>>>>
> >>>>> Please do not expand header, it is too short anyway.
> >>>>>
> >>>>>>   2. adding a new label with relevant tags for the patch, called
> >>> e.g
> >>>>>>   'METADATA: network, rest, virt'
> >>>>>
> >>>>> Having:
> >>>>>
> >>>>> CI-Tests: xxx
> >>>>> CI-Tests: yyy
> >>>>> CI-Tests: zzz
> >>>>>
> >>>>> Is much better.
> >>>>
> >>>> I'm not sure we should have CI-Test - as we might use this for
> >>> something else
> >>>> besides CI.
> >>>> Region_of_Interest as Dan suggests sounds better IMHO.
> >

Re: [Engine-devel] Proposal for new commit msg design for engine commits

2013-07-11 Thread Eyal Edri


- Original Message -
> From: "Fabian Deutsch" 
> To: "Eyal Edri" 
> Cc: "Alon Bar-Lev" , "engine-devel" 
> , "infra" 
> Sent: Thursday, July 11, 2013 11:41:24 AM
> Subject: Re: [Engine-devel] Proposal for new commit msg design for engine 
> commits
> 
> Am Mittwoch, den 10.07.2013, 15:27 -0400 schrieb Eyal Edri:
> > 
> > - Original Message -
> > > From: "Fabian Deutsch" 
> > > To: "Alon Bar-Lev" 
> > > Cc: "engine-devel" , "infra" 
> > > Sent: Tuesday, July 9, 2013 3:54:06 PM
> > > Subject: Re: [Engine-devel] Proposal for new commit msg design for engine
> > > commits
> > > 
> > > Am Dienstag, den 09.07.2013, 08:49 -0400 schrieb Alon Bar-Lev:
> > > > 
> > > > 
> > > > - Original Message -
> > > > > From: "Yair Zaslavsky" 
> > > > > To: "Alon Bar-Lev" 
> > > > > Cc: "Eyal Edri" , "engine-devel"
> > > > , "infra" 
> > > > > Sent: Tuesday, July 9, 2013 3:42:24 PM
> > > > > Subject: Re: [Engine-devel] Proposal for new commit msg design for
> > > > engine commits
> > > > > 
> > > > > 
> > > > > 
> > > > > - Original Message -
> > > > > > From: "Alon Bar-Lev" 
> > > > > > To: "Eyal Edri" 
> > > > > > Cc: "engine-devel" , "infra"
> > > > 
> > > > > > Sent: Tuesday, July 9, 2013 3:33:57 PM
> > > > > > Subject: Re: [Engine-devel] Proposal for new commit msg design for
> > > > engine
> > > > > > commits
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > - Original Message -
> > > > > > > From: "Eyal Edri" 
> > > > > > > To: "engine-devel" 
> > > > > > > Cc: "infra" 
> > > > > > > Sent: Tuesday, July 9, 2013 12:38:51 PM
> > > > > > > Subject: Proposal for new commit msg design for engine commits
> > > > > > > 
> > > > > > > Hi,
> > > > > > > 
> > > > > > > You all probably know and familiar with 'ovirt-engine' git hook
> > > > for
> > > > > > > commit
> > > > > > > msg template [1].
> > > > > > > this helps understand the general area of the patch in the
> > > > project but it
> > > > > > > lacks additional info that might
> > > > > > > be valuable for scaling automatic tests in Jenkins CI.
> > > > > > > 
> > > > > > > Let me explain:
> > > > > > > 
> > > > > > > Infra team is working hard on expanding oVirt CI infrastructure
> > > > and
> > > > > > > adding
> > > > > > > more tests in jenkins (per commit/patch).
> > > > > > > Adding important meta-data per patch can significatly improve
> > > > the ability
> > > > > > > to
> > > > > > > run specific tests for each patch/commit,
> > > > > > > and not waste valuable resources on Jenkins jobs that are not
> > > > relevant to
> > > > > > > the
> > > > > > > code in the patch.
> > > > > > > 
> > > > > > > So the idea is to add/expand current metadata per patch, in the
> > > > form of:
> > > > > > > (either)
> > > > > > >  1. expanding current header template to include more data like
> > > > 'network'
> > > > > > >  ,
> > > > > > >  'setup', 'tools', 'virt'
> > > > > > 
> > > > > > Please do not expand header, it is too short anyway.
> > > > > > 
> > > > > > >  2. adding a new label with relevant tags for the patch, called
> > > > e.g
> > > > > > >  'METADATA: network, rest, virt'
> > > > > > 
> > > > > > Having:
> > > > > > 
> > > > > > CI-Tests: xxx
> > > > > > CI-Tests: yyy
> > > > > > CI-Tests: 

Re: [Engine-devel] Proposal for new commit msg design for engine commits

2013-07-20 Thread Eyal Edri
OK, Rome wasn't built in a day.

To move things forward, 
I propose we'll just improve current commit header template to include more 
relevant code
areas [1], and start looking into mapping all code to the relevant components 
(either via renaming folders, adding a metadata file under each folder mapping 
the files/classnames/directory names or using automated tools like sonar)

[1] instead of   
change to something like 

Eyal.

- Original Message -
> From: "Moran Goldboim" 
> To: "Eyal Edri" 
> Cc: "Fabian Deutsch" , "engine-devel" 
> , "infra" 
> Sent: Sunday, July 14, 2013 6:07:05 PM
> Subject: Re: [Engine-devel] Proposal for new commit msg design for engine 
> commits
> 
> On 07/11/2013 11:57 AM, Eyal Edri wrote:
> >
> > - Original Message -
> >> From: "Fabian Deutsch" 
> >> To: "Eyal Edri" 
> >> Cc: "Alon Bar-Lev" , "engine-devel"
> >> , "infra" 
> >> Sent: Thursday, July 11, 2013 11:41:24 AM
> >> Subject: Re: [Engine-devel] Proposal for new commit msg design for engine
> >> commits
> >>
> >> Am Mittwoch, den 10.07.2013, 15:27 -0400 schrieb Eyal Edri:
> >>> - Original Message -
> >>>> From: "Fabian Deutsch" 
> >>>> To: "Alon Bar-Lev" 
> >>>> Cc: "engine-devel" , "infra" 
> >>>> Sent: Tuesday, July 9, 2013 3:54:06 PM
> >>>> Subject: Re: [Engine-devel] Proposal for new commit msg design for
> >>>> engine
> >>>> commits
> >>>>
> >>>> Am Dienstag, den 09.07.2013, 08:49 -0400 schrieb Alon Bar-Lev:
> >>>>>
> >>>>> - Original Message -
> >>>>>> From: "Yair Zaslavsky" 
> >>>>>> To: "Alon Bar-Lev" 
> >>>>>> Cc: "Eyal Edri" , "engine-devel"
> >>>>> , "infra" 
> >>>>>> Sent: Tuesday, July 9, 2013 3:42:24 PM
> >>>>>> Subject: Re: [Engine-devel] Proposal for new commit msg design for
> >>>>> engine commits
> >>>>>>
> >>>>>>
> >>>>>> - Original Message -
> >>>>>>> From: "Alon Bar-Lev" 
> >>>>>>> To: "Eyal Edri" 
> >>>>>>> Cc: "engine-devel" , "infra"
> >>>>> 
> >>>>>>> Sent: Tuesday, July 9, 2013 3:33:57 PM
> >>>>>>> Subject: Re: [Engine-devel] Proposal for new commit msg design for
> >>>>> engine
> >>>>>>>  commits
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> - Original Message -
> >>>>>>>> From: "Eyal Edri" 
> >>>>>>>> To: "engine-devel" 
> >>>>>>>> Cc: "infra" 
> >>>>>>>> Sent: Tuesday, July 9, 2013 12:38:51 PM
> >>>>>>>> Subject: Proposal for new commit msg design for engine commits
> >>>>>>>>
> >>>>>>>> Hi,
> >>>>>>>>
> >>>>>>>> You all probably know and familiar with 'ovirt-engine' git hook
> >>>>> for
> >>>>>>>> commit
> >>>>>>>> msg template [1].
> >>>>>>>> this helps understand the general area of the patch in the
> >>>>> project but it
> >>>>>>>> lacks additional info that might
> >>>>>>>> be valuable for scaling automatic tests in Jenkins CI.
> >>>>>>>>
> >>>>>>>> Let me explain:
> >>>>>>>>
> >>>>>>>> Infra team is working hard on expanding oVirt CI infrastructure
> >>>>> and
> >>>>>>>> adding
> >>>>>>>> more tests in jenkins (per commit/patch).
> >>>>>>>> Adding important meta-data per patch can significatly improve
> >>>>> the ability
> >>>>>>>> to
> >>>>>>>> run specific tests for each patch/commit,
> >>>>>>>> and not waste valuable resources on Jenkins jobs that are not
> >

Re: [Engine-devel] Proposal for new commit msg design for engine commits

2013-07-20 Thread Eyal Edri
This change to commit template has nothing to do with CI.
it's a change that should reflect updated components relevance to the commit 
code.

Nevertheless, i have no problems with your suggestions for metadata per 
directory to map all ovirt code.
any suggestion how to push it forward? 

Eyal.

- Original Message -
> From: "Alon Bar-Lev" 
> To: "Eyal Edri" 
> Cc: "infra" , "engine-devel" , 
> "Fabian Deutsch" 
> Sent: Saturday, July 20, 2013 9:34:13 PM
> Subject: Re: [Engine-devel] Proposal for new commit msg design for engine 
> commits
> 
> 
> 
> - Original Message -
> > From: "Eyal Edri" 
> > To: "infra" 
> > Cc: "engine-devel" , "Fabian Deutsch"
> > 
> > Sent: Saturday, July 20, 2013 8:34:28 PM
> > Subject: Re: [Engine-devel] Proposal for new commit msg design for engine
> > commits
> > 
> > OK, Rome wasn't built in a day.
> > 
> > To move things forward,
> > I propose we'll just improve current commit header template to include more
> > relevant code
> > areas [1], and start looking into mapping all code to the relevant
> > components
> > (either via renaming folders, adding a metadata file under each folder
> > mapping the files/classnames/directory names or using automated tools like
> > sonar)
> 
> Again, and I am sorry, but I disagree of any relationship between commit
> message and CI.
> 
> It will be simple to add metadata to sources, and have CI run tests based on
> actual source change thus probable impact, this way we won't be exposed to
> human errors, nor make commit message unusable for actual history.
> 
> All we need is someone to take ownership of the task of adding metadata to
> source tree.
> 
> As I proposed this can be either within every source using special signature,
> or can be in a directory at special file, for example .ovirt-metadata, and
> have the mapping between source component to relevant tests at a simple text
> file at source root.
> 
> Regards,
> Alon Bar-Lev.
> 
> > 
> > [1] instead of> userportal | webadmin>
> > change to something like  > webadmin
> > | network | storage | virt | packaging>
> > 
> > Eyal.
> > 
> > - Original Message -
> > > From: "Moran Goldboim" 
> > > To: "Eyal Edri" 
> > > Cc: "Fabian Deutsch" , "engine-devel"
> > > , "infra" 
> > > Sent: Sunday, July 14, 2013 6:07:05 PM
> > > Subject: Re: [Engine-devel] Proposal for new commit msg design for engine
> > > commits
> > > 
> > > On 07/11/2013 11:57 AM, Eyal Edri wrote:
> > > >
> > > > - Original Message -
> > > >> From: "Fabian Deutsch" 
> > > >> To: "Eyal Edri" 
> > > >> Cc: "Alon Bar-Lev" , "engine-devel"
> > > >> , "infra" 
> > > >> Sent: Thursday, July 11, 2013 11:41:24 AM
> > > >> Subject: Re: [Engine-devel] Proposal for new commit msg design for
> > > >> engine
> > > >> commits
> > > >>
> > > >> Am Mittwoch, den 10.07.2013, 15:27 -0400 schrieb Eyal Edri:
> > > >>> - Original Message -
> > > >>>> From: "Fabian Deutsch" 
> > > >>>> To: "Alon Bar-Lev" 
> > > >>>> Cc: "engine-devel" , "infra"
> > > >>>> 
> > > >>>> Sent: Tuesday, July 9, 2013 3:54:06 PM
> > > >>>> Subject: Re: [Engine-devel] Proposal for new commit msg design for
> > > >>>> engine
> > > >>>> commits
> > > >>>>
> > > >>>> Am Dienstag, den 09.07.2013, 08:49 -0400 schrieb Alon Bar-Lev:
> > > >>>>>
> > > >>>>> - Original Message -
> > > >>>>>> From: "Yair Zaslavsky" 
> > > >>>>>> To: "Alon Bar-Lev" 
> > > >>>>>> Cc: "Eyal Edri" , "engine-devel"
> > > >>>>> , "infra" 
> > > >>>>>> Sent: Tuesday, July 9, 2013 3:42:24 PM
> > > >>>>>> Subject: Re: [Engine-devel] Proposal for new commit msg design for
> > > >>>>> engine commits
> > > >>>>>>
> > > >>>>>>

[Engine-devel] [ANN] ovirt nigthly rpms for fedora19 available for download

2013-07-23 Thread Eyal Edri
Fyi,

fedora19 rpm for ovirt projects are now available on 
http://resources.ovirt.org/releases/nightly/rpm/Fedora/19.

Eyal. 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 4737 - Still Unstable!

2013-07-28 Thread Eyal Edri
fyi,

the following patch [1] 
caused new unit tests failures:

http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/4733/

[1] 
http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git&a=commit&h=3806a44b33e303c89c8b4b03c902944d6784a44e

- Original Message -
> From: "Jenkins ci oVirt Server" 
> To: ee...@redhat.com, engine-patc...@ovirt.org, ol...@redhat.com, 
> yzasl...@redhat.com, oba...@redhat.com,
> gerr...@gerrit.ovirt.org
> Sent: Sunday, July 28, 2013 3:25:18 PM
> Subject: [oVirt Jenkins] ovirt_engine_unit_tests - Build # 4737 - Still 
> Unstable!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/4737/
> Build Number: 4737
> Build Status:  Still Unstable
> Triggered By: Started by an SCM change
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #4733
> [Vojtech Szocs] core: i18n welcome page with branding
> 
> 
> Changes for Build #4734
> [Vojtech Szocs] userportal,webadmin: Frontend refactor
> 
> 
> Changes for Build #4735
> [Gerrit Code Review] packaging: update README.developer broken by feefb12b
> 
> [Gerrit Code Review] webadmin: support Memory Balloon
> 
> [Gerrit Code Review] packaging: setup: fix pep8 issue
> 
> 
> Changes for Build #4736
> [Gilad Chaplik] webadmin: Fix QoS validator error tooltip
> 
> [Gilad Chaplik] core: Add Audit log messages for Quota "Audit" mode
> 
> [Gilad Chaplik] webadmin: cluster policy look & feel enhancements
> 
> [Gerrit Code Review] packaging: spec: create ovirt user for
> ovirt-websocket-proxy
> 
> 
> Changes for Build #4737
> [Gerrit Code Review] packaging: setup: produce and manage setup logs at
> /var/log
> 
> 
> 
> 
> -
> Failed Tests:
> -
> 2 tests failed.
> FAILED:
> org.ovirt.engine.core.WelcomeServletTest.testDoGetHttpServletRequestHttpServletResponseNoDispatcher
> 
> Error Message:
> null
> 
> Stack Trace:
> java.lang.NullPointerException
>   at
>   
> org.ovirt.engine.core.utils.branding.BrandingManager.getWelcomeSections(BrandingManager.java:247)
>   at org.ovirt.engine.core.WelcomeServlet.doGet(WelcomeServlet.java:104)
>   at
>   
> org.ovirt.engine.core.WelcomeServletTest.testDoGetHttpServletRequestHttpServletResponseNoDispatcher(WelcomeServletTest.java:65)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at
>   
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at
>   
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at
>   
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
>   at
>   
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
>   at
>   
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
>   at
>   
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
>   at
>   
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
>   at
>   
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
>   at
>   
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
>   at
>   
> org.mockito.internal.runners.JUnit45AndHigherRunnerImpl.run(JUnit45AndHigherRunnerImpl.java:37)
>   at 
> org.mockito.runners.MockitoJUnitRunner.run(MockitoJUnitRunner.java:62)
>   at
>   
> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:35)
>   at
>   
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:115)
>   at
>   
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:97)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at
>   
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at
>   
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at
>   
> org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103)
>   at com.sun.proxy.$Proxy0.invoke(Unknown Source)
>   at
>  

Re: [Engine-devel] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 4736 - Failure!

2013-07-29 Thread Eyal Edri
fyi,

gwt compilations on gwt-user & gwt-admin are failing post these commits.
changed: 
http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4925/changes#detail5
error:   http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4925/console

Eyal.
oVirt infra team.


- Original Message -
> From: "Jenkins ci oVirt Server" 
> To: ee...@redhat.com, engine-patc...@ovirt.org, ol...@redhat.com, 
> yzasl...@redhat.com, gerr...@gerrit.ovirt.org
> Sent: Monday, July 29, 2013 10:32:56 AM
> Subject: [oVirt Jenkins] ovirt_engine_gwt_user - Build # 4736 - Failure!
> 
> Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/
> Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/4736/
> Build Number: 4736
> Build Status:  Failure
> Triggered By: Started by an SCM change
> 
> -
> Changes Since Last Success:
> -
> Changes for Build #4736
> [Gerrit Code Review] packaging: setup: allow uninstall ca,cert.conf
> 
> [Gerrit Code Review] engine:Trusted Compute Pools - Open Attestation
> integration with oVirt engine
> 
> [Gerrit Code Review] engine:Trusted Compute Pools - Open Attestation
> integration with oVirt engine
> 
> [Gerrit Code Review] engine:Trusted Compute Pools - Open Attestation
> integration with oVirt engine
> 
> [Gerrit Code Review] engine:Trusted Compute Pools - Open Attestation
> integration with oVirt engine
> 
> [Gerrit Code Review] engine:Trusted Compute Pools - Open Attestation
> integration with oVirt engine
> 
> 
> 
> 
> -
> Failed Tests:
> -
> No tests ran.
> 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Proposal for new commit msg design for engine commits

2013-08-13 Thread Eyal Edri
now that gerrit was upgraded to 2.6.1 this becomes much more easier with custom 
fields options.[1]


[1] 
http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-2.6.html

"The patch set review screen can include radio buttons for custom labels if 
enabled by submit rules. ".

- Original Message -
> From: "Antoni Segura Puimedon" 
> To: "infra" 
> Cc: "engine-devel" 
> Sent: Tuesday, July 9, 2013 12:41:45 PM
> Subject: Re: [Engine-devel] Proposal for new commit msg design for engine 
> commits
> 
> I like the idea of having a label in the bottom part of the commit that is:
> 
> METADATA: network
> 
> which would be your second proposal.
> 
> - Original Message -
> > From: "Eyal Edri" 
> > To: "engine-devel" 
> > Cc: "infra" 
> > Sent: Tuesday, July 9, 2013 11:38:51 AM
> > Subject: [Engine-devel] Proposal for new commit msg design for engine
> > commits
> > 
> > Hi,
> > 
> > You all probably know and familiar with 'ovirt-engine' git hook for commit
> > msg template [1].
> > this helps understand the general area of the patch in the project but it
> > lacks additional info that might
> > be valuable for scaling automatic tests in Jenkins CI.
> > 
> > Let me explain:
> > 
> > Infra team is working hard on expanding oVirt CI infrastructure and adding
> > more tests in jenkins (per commit/patch).
> > Adding important meta-data per patch can significatly improve the ability
> > to
> > run specific tests for each patch/commit,
> > and not waste valuable resources on Jenkins jobs that are not relevant to
> > the
> > code in the patch.
> > 
> > So the idea is to add/expand current metadata per patch, in the form of:
> > (either)
> >  1. expanding current header template to include more data like 'network' ,
> >  'setup', 'tools', 'virt'
> >  2. adding a new label with relevant tags for the patch, called e.g
> >  'METADATA: network, rest, virt'
> > 
> > Jenkins jobs will then be able to parse that data and trigger only relevant
> > jobs for it.
> > this can also allow us to add more jobs per patch, an option that is very
> > problematic today considering the amount of
> > patches coming in to engine.
> > 
> > Once agreed on a format, we'll be able to add a git hook to verify the
> > validity of the commit msg. (similar to bug-url).
> > 
> > if we're not 100% sure that the tags will cover all corner cases and we
> > feel
> > like we need to run the code on all jobs,
> > we can a nightly job to run all the remaining jobs (but at least it won't
> > run
> > on every patch/commit).
> > 
> > [1] :
> > 
> > 
> > thoughts?
> > 
> > Eyal Edri.
> > ___
> > Engine-devel mailing list
> > Engine-devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> ___
> Infra mailing list
> in...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Jenkins job to run networking functional tests

2013-08-19 Thread Eyal Edri
[adding devel lists]

Usually to get power user privileges you need get +1 community (mostly relevant 
people in your team/project).
saying you're familiar with jenkins and the project and is cabaple of adding 
jobs to the project.

I personally give +1 since i know you're contribution and experience.

Eyal.

- Original Message -
> From: "Giuseppe Vallarelli" 
> To: "infra" 
> Sent: Monday, August 19, 2013 10:19:46 AM
> Subject: Jenkins job to run networking functional tests
> 
> Hello everybody, following the previous discussion with Eyal,
> I need to get rights in order to create a jenkins job to
> achieve what stated in the subject.
> 
> Is it the right place for such request?
> 
> Cheers, Giuseppe
> 
> - Forwarded Message -
> | From: "Eyal Edri" 
> | To: "Giuseppe Vallarelli" 
> | Cc: "infra" 
> | Sent: Sunday, August 18, 2013 2:06:22 PM
> | Subject: Re: running network functional tests
> | 
> | Hi,
> | 
> | Usually in these cases when a new job is requested to a specific
> | project/component,
> | A 'power user' for the relevant team (in your case network), is given
> | privileges on the Jenkins machine
> | to add any job required.
> | 
> | I would propose the following:
> |  1. request power user access to jenkins.ovirt.org (if you don't already
> |  have)
> |  2. add a new job with your functional test per commit (not per patch for
> |  starts)
> | any infra member can assist you with the labels for slaves / os /etc...
> |  3. once that job is running properly, you can contact infra to assist in
> |  converting it to a per-patch job
> | with the topic / field verification logic done.
> |  4. not sure if this is relevant to your tests, but all existing jenkins
> |  slaves are VMs and not bare-metal.
> | 
> | i hope this helps.
> | 
> | Eyal.
> | 
> | - Original Message -
> | > From: "Giuseppe Vallarelli" 
> | > To: "infra" 
> | > Sent: Friday, August 16, 2013 12:28:43 PM
> | > Subject: Fwd: running network functional tests
> | > 
> | > - Forwarded Message -
> | > | From: "Giuseppe Vallarelli" 
> | > | To: "infra" 
> | > | Cc: "David Caro Estevez" 
> | > | Sent: Monday, August 12, 2013 10:58:04 AM
> | > | Subject: running network functional tests
> | > | 
> | > | Hello everbody!
> | > | Just recently we added networking functional tests and we would like
> | > | to have them running when we submit patches network related, i.e.
> | > | going to affect network modules. Displaying success or failure
> | > | as it happens with the current unittests.
> | > | 
> | > | Requirements/ideas:
> | > | 
> | > | - OS Fedora 19/RHEL6.4 should not matter.
> | > | 
> | > | - Kernel module used: bonding, dummy.
> | > | 
> | > | - No more than one 'instance' of networkTests should run
> | > |   on a specific host, simply because we use some global
> | > |   constants to identify network name vlan id and so on.
> | > | 
> | > | - Ideally we can use a previously proposed idea of commit tag
> | > |   where for example @networking is provided in the commit msg
> | > |   title to identify the need of running also the network
> | > |   functional tests.
> | > | 
> | > | - We should be able to run at the same time functional networking
> | > |   tests and unit tests - I don't expect any conflicts.
> | > | 
> | > | Would be cool to have a test run before -1s all networking patches
> | > | in case of problems :-)
> | > | 
> | > | Let me know if more information are needed.
> | > | 
> | > | 
> | > | Cheers, Giuseppe
> | > 
> | > Is there any update on the subject?
> | > 
> | > Any estimate to have functional network tests running?
> | > I mind that we can run network functional tests upstream
> | > that will speed up our workflow and possibly decrease the
> | > regressions.
> | > 
> | > Thanks Giuseppe
> | > ___
> | > Infra mailing list
> | > in...@ovirt.org
> | > http://lists.ovirt.org/mailman/listinfo/infra
> | > 
> | 
> ___
> Infra mailing list
> in...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [vdsm] Jenkins job to run networking functional tests

2013-08-20 Thread Eyal Edri
OK,

Since i see now -1 and enough +1, i'll add giuseppe as power user for network 
tests on ovirt.
congrats.

I will send you the details in private.
please contact infra team if you need assistance with setting up the jobs.

Eyal.

- Original Message -
> From: "Assaf Muller" 
> To: "Sandro Bonazzola" 
> Cc: "Eyal Edri" , "engine-devel" , 
> "vdsm-devel"
> , "infra" 
> Sent: Monday, August 19, 2013 5:50:16 PM
> Subject: Re: [vdsm] Jenkins job to run networking functional tests
> 
> +1
> 
> Giuseppe is our go to guy as far as networking tests go!
> 
> - Original Message -
> From: "Sandro Bonazzola" 
> To: "Eyal Edri" 
> Cc: "engine-devel" , "vdsm-devel"
> , "infra" 
> Sent: Monday, August 19, 2013 2:20:36 PM
> Subject: Re: [vdsm] Jenkins job to run networking functional tests
> 
> Il 19/08/2013 11:26, Eyal Edri ha scritto:
> > [adding devel lists]
> > 
> > Usually to get power user privileges you need get +1 community (mostly
> > relevant people in your team/project).
> > saying you're familiar with jenkins and the project and is cabaple of
> > adding jobs to the project.
> > 
> > I personally give +1 since i know you're contribution and experience.
> > 
> > Eyal.
> 
> +1 from me too.
> 
> Sandro
> 
> 
> 
> 
> 
> > 
> > - Original Message -
> >> From: "Giuseppe Vallarelli" 
> >> To: "infra" 
> >> Sent: Monday, August 19, 2013 10:19:46 AM
> >> Subject: Jenkins job to run networking functional tests
> >>
> >> Hello everybody, following the previous discussion with Eyal,
> >> I need to get rights in order to create a jenkins job to
> >> achieve what stated in the subject.
> >>
> >> Is it the right place for such request?
> >>
> >> Cheers, Giuseppe
> >>
> >> - Forwarded Message -
> >> | From: "Eyal Edri" 
> >> | To: "Giuseppe Vallarelli" 
> >> | Cc: "infra" 
> >> | Sent: Sunday, August 18, 2013 2:06:22 PM
> >> | Subject: Re: running network functional tests
> >> | 
> >> | Hi,
> >> | 
> >> | Usually in these cases when a new job is requested to a specific
> >> | project/component,
> >> | A 'power user' for the relevant team (in your case network), is given
> >> | privileges on the Jenkins machine
> >> | to add any job required.
> >> | 
> >> | I would propose the following:
> >> |  1. request power user access to jenkins.ovirt.org (if you don't already
> >> |  have)
> >> |  2. add a new job with your functional test per commit (not per patch
> >> |  for
> >> |  starts)
> >> | any infra member can assist you with the labels for slaves / os
> >> | /etc...
> >> |  3. once that job is running properly, you can contact infra to assist
> >> |  in
> >> |  converting it to a per-patch job
> >> | with the topic / field verification logic done.
> >> |  4. not sure if this is relevant to your tests, but all existing jenkins
> >> |  slaves are VMs and not bare-metal.
> >> | 
> >> | i hope this helps.
> >> | 
> >> | Eyal.
> >> | 
> >> | - Original Message -
> >> | > From: "Giuseppe Vallarelli" 
> >> | > To: "infra" 
> >> | > Sent: Friday, August 16, 2013 12:28:43 PM
> >> | > Subject: Fwd: running network functional tests
> >> | > 
> >> | > - Forwarded Message -
> >> | > | From: "Giuseppe Vallarelli" 
> >> | > | To: "infra" 
> >> | > | Cc: "David Caro Estevez" 
> >> | > | Sent: Monday, August 12, 2013 10:58:04 AM
> >> | > | Subject: running network functional tests
> >> | > | 
> >> | > | Hello everbody!
> >> | > | Just recently we added networking functional tests and we would like
> >> | > | to have them running when we submit patches network related, i.e.
> >> | > | going to affect network modules. Displaying success or failure
> >> | > | as it happens with the current unittests.
> >> | > | 
> >> | > | Requirements/ideas:
> >> | > | 
> >> | > | - OS Fedora 19/RHEL6.4 should not matter.
> >> | > | 
> >> | > | - Kernel module used: bonding, dummy.
> >> | > 

[Engine-devel] [action needed] failing jenkins job "ovirt db report engine"

2013-09-11 Thread Eyal Edri
fyi,

the following job [1] is failing due to missing files on the slave (it used 
local files/software).
the original slave is now not available.

does this jobs is still needed? is so, the owner of the job should write a 
puppet class
to install needed files for it so it won't be locally only on the jenkins 
slaves (which should be stateless).

job will be disabled until fixed.

[1] http://jenkins.ovirt.org/job/ovirt_db_report_engine/

thank you,

eyal edri,
oVirt infra team.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] fake VDSM as oVirt project?

2013-09-15 Thread Eyal Edri
shouldn't this be on vdsm-devel?

[adding relevant groups]

- Original Message -
> From: "Liran Zelkha" 
> To: "Tomas Jelinek" 
> Cc: "engine-devel" 
> Sent: Friday, September 13, 2013 9:52:42 AM
> Subject: Re: [Engine-devel] fake VDSM as oVirt project?
> 
> +1 I use it constantly.
> 
> 
> On Fri, Sep 13, 2013 at 8:48 AM, Tomas Jelinek < tjeli...@redhat.com > wrote:
> 
> 
> Hi all,
> 
> some time ago Libor Spevak created a simple web app called vdsm fake:
> documented: http://www.ovirt.org/VDSM_Fake
> published: https://github.com/lspevak/ovirt-vdsmfake
> 
> It is basically a simple hackable java web application which can emulate the
> VDSM so you can connect the
> engine to it. It is especially useful for:
> - having tons of cheap fake hosts on one machine to stress your engine
> - doing some experiments with VDSM API (e.g. vfeenstr proposes a new VDSM API
> to lower the network traffic between
> engine <-> VDSM and uses the vdsm fake to implement it and do some tests to
> get some numbers on how does this change the things)
> 
> Omer came up with an idea of making this app as one of oVirt's project (
> http://www.ovirt.org/Subprojects ) maybe with repository on
> oVirt's gerrit making it more accessible for getting/contributing for the
> whole community.
> 
> What do you think about it?
> 
> Tomas
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Suggesting new packaging and setup maintainer

2013-09-23 Thread Eyal Edri
+1.

Agree and fully support the nomination for sandro as maintainer for 
ovirt-engine.

Eyal.

- Original Message -
> From: "Ofer Schreiber" 
> To: "board" , "engine-devel" 
> Sent: Monday, September 23, 2013 1:49:36 PM
> Subject: [Engine-devel] Suggesting new packaging and setup maintainer
> 
> Nominating Sandro Bonazzola as packaging and setup maintainer
> --
> 
> During his recent year of participation in ovirt-engine development,
> Sandro demonstrated a genuine care for the product health, great coding
> abilities,
> and great responsibility to the setup and packaging components.
> 
> Sandro's contribution the the project is undoubtable, he's responsible for
> over 70 patches in ovirt-engine,
> and he's the maintainer of log-collector, iso-uploader and image-uploader
> packages.
> 
> I suggest that Sandro will obtain +2 and merge rights in the ovirt-engine
> gerrit project,
> in the understanding that those rights should be used only in packaging and
> setup parts of the code.
> 
> --
> Ofer Schreiber.
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Jenkins job for ovirt-iso-uploader and ovirt-image-uploader

2013-09-23 Thread Eyal Edri
+1,

Sandro is indeed already ovirt-engine-tools maintainer and is more than capable 
of 
creating jobs for testing them.

Eyal.

- Original Message -
> From: "Sandro Bonazzola" 
> To: "infra" , "engine-devel" 
> Cc: "Eyal Edri" 
> Sent: Tuesday, September 24, 2013 9:30:11 AM
> Subject: Re: Jenkins job for ovirt-iso-uploader and ovirt-image-uploader
> 
> Hi oVirt community,
>   following the previous discussion with infra team, I need to get power user
>   rights for jenkins
> in order to create a jenkins job for basic sanity testing of
> ovirt-iso-uploader and ovirt-image-uploader.
> That said, I formally request a power user for jenkins (for those tools I'm
> already the maintainer)
> in order to create new jobs for them as well and ask the community for acks.
> Thanks,
> 
> Sandro Bonazzola
> 
> 
> 
> Il 11/09/2013 09:56, Eyal Edri ha scritto:
> > Hi Sandro,
> > 
> > I assume we can create a new vm on rackspace to act as NFS server for the
> > job,
> > or even convert one of the existing jenkins slave vms to be one.
> > 
> > any other thoughts from the infra team?
> > 
> > Also, you will need to get a power user for jenkins (for tools) in order to
> > create new jobs
> > for them as well.
> > The process for that is sending email to this list & engine-devel to
> > request it formally and
> > get acks from the community.
> > 
> > Eyal.
> > 
> > 
> > - Original Message -
> >> From: "Sandro Bonazzola" 
> >> To: "infra" 
> >> Sent: Wednesday, September 11, 2013 9:31:36 AM
> >> Subject: Jenkins job for ovirt-iso-uploader and ovirt-image-uploader
> >>
> >> Hi,
> >> I would like to introduce a jenkins job for basic sanity testing of
> >> ovirt-iso-uploader and ovirt-image-uploader.
> >> For covering NFS upload it will be needed an NFS share where to upload the
> >> images, writable by an user having UID and GID of 36.
> >> For covering SSH uploads it would be needed also SSH access with a user
> >> having UID and GID of 36.
> >> For covering upload using the domain id it would be needed a running
> >> ovirt-engine instance.
> >>
> >> The space needed for the images may be little: sample ovf provided by
> >> ovirt-image-uploader is ~2kb and for the iso image any non empty file
> >> should
> >> be
> >> enough. The uploaded images will be deleted by the job after running.
> >>
> >> Is it possible for infra to provide the needed services?
> >> Thanks,
> >> --
> >> Sandro Bonazzola
> >> Better technology. Faster innovation. Powered by community collaboration.
> >> See how it works at redhat.com
> >> ___
> >> Infra mailing list
> >> in...@ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/infra
> >>
> 
> 
> --
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at redhat.com
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Request for Fedora 20 VM

2013-10-13 Thread Eyal Edri


- Original Message -
> From: "Fabian Deutsch" 
> To: "Sandro Bonazzola" 
> Cc: "engine-devel" , in...@ovirt.org
> Sent: Monday, September 30, 2013 3:52:12 PM
> Subject: Re: Request for Fedora 20 VM
> 
> Am Montag, den 30.09.2013, 08:21 +0200 schrieb Sandro Bonazzola:
> > Hi,
> > Fedora 20 Alpha has been released and can be downloaded from
> > http://fedoraproject.org/get-prerelease.
> > I think it's time to start running our tests and build nightly also on
> > Fedora 20 in order to discover
> > possible compatibility issues.
> > Can infra provide a Fedora 20 VM for jenkins use?
> 
> That would also be helpful for us - ovirt-node - to get started with the
> F20 migration.

@ewoud - is it possible to use oVirt forman to reinstall one of the f18 slaves 
as f20? 

> 
> Greetings
> fabian
> 
> ___
> Infra mailing list
> in...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] [JENKINS] failure in upstream job - conflict in db file name

2013-10-16 Thread Eyal Edri
fyi,

following patches broke the db scripts (wrong order of naming):

core: Fix PinToHostPolicyUnit when PinToHost is enabled (details)
core: Use pin to host only when present in cluster policy (details)
engine: adding no-arg constructor to RemoveVdsParameters (details)
[core] rename VdsStatic hostname to hostName. (details)
webadmin: Hide "public" InfoIcon if checkbox hidden (details)

error:

Running upgrade sql script upgrade/03_03_0910_remove_migration_filter.sql ...
Running upgrade sql script upgrade/03_03_0920_add_fqdn_to_vm_dynamic.sql ...
Running upgrade sql script upgrade/03_03_0930_add_dwh_heartbeat.sql ...
Running upgrade sql script 
upgrade/03_03_0940_clear_snapshot_id_of_floating_disks.sql ...
Illegal script version number 03030990,version should be in max 10 gap from 
last installed version: 03030940
Please fix numbering to interval 03030941 to 03030950 and run the upgrade 
script.
Failed to create schema for database ovirt_engine_dao_unit_tests_gerrit_50
Build step 'Execute shell' marked build as failure
Performing Post build task...
Could not match :INFO  : False
Logical operation result is FALSE
Skipping script  : dropdb -U postgres ${JOB_NAME}_${BUILD_NUMBER} || /bin/true
END OF POST BUILD TASK  : 0
Recording test results
Email was triggered for: Failure

full log:
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_gerrit/50/console

___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch

2013-10-24 Thread Eyal Edri
there are already in place gerrit jobs for all flows, only this was introduced 
before they were added:

ovirt_engine_3.2_update_db_to_3.3_gerrit
ovirt_engine_3.3.0_update_db_to_3.3_gerrit
ovirt_engine_3.3.1_update_db_to_3.3_gerrit
ovirt_engine_3.3_update_db_to_master_gerrit
ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit
ovirt_engine_master_update_db_to_master_gerrit
ovirt_engine_3.3_update_db_to_3.3_latest_gerrit

- Original Message -
> From: "Barak Azulay" 
> To: "Eli Mesika" 
> Cc: "engine-devel" , in...@ovirt.org, "Eyal Edri" 
> 
> Sent: Thursday, October 24, 2013 7:13:04 PM
> Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for 
> stable branch
> 
> We should  add a gerrit hook to enforce the right naming/version  of db
> upgrade scripts.
> 
> 
> Thanks
> Barak Azulay
> 
> - Original Message -
> > From: "Eli Mesika" 
> > To: "engine-devel" 
> > Sent: Thursday, October 24, 2013 6:49:21 PM
> > Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for
> > stable branch
> > 
> > Hi
> > 
> > Please note that any upgrade script introduced to the master branch should
> > have the 03_04 prefix.
> > If this script is resolving a blocker/exception BZ it should be ported to
> > the
> > ovirt-engine-3.3 branch with a 03_03 prefix !!!
> > 
> > We have encountered some patches that broke the upgrade from
> > ovirt-engine-3.3
> > to master as a result of
> > 
> > 1) naming new upgrade scripts in master branch with 03_03 prefix
> > 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with 03_04
> > prefix
> > 
> > I am available for any question and asking you to add me to any DB related
> > script as a reviewer even if I +2 the master patch and you just back-port
> > it
> > to ovirt-engine-3.3.
> > It may save us a lot of noise.
> > 
> > Thanks for your cooperation
> > 
> > Eli
> > ___
> > Engine-devel mailing list
> > Engine-devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> > 
> > 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch

2013-10-24 Thread Eyal Edri
already active.

- Original Message -
> From: "Barak Azulay" 
> To: "Eyal Edri" 
> Cc: "engine-devel" , in...@ovirt.org
> Sent: Thursday, October 24, 2013 8:12:27 PM
> Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for 
> stable branch
> 
> Even better,
> 
> When will these hooks be effective on engine  master & ovirt-3.3 ?
> 
> Barak
> 
> - Original Message -
> > From: "Eyal Edri" 
> > To: "Barak Azulay" 
> > Cc: "engine-devel" , in...@ovirt.org
> > Sent: Thursday, October 24, 2013 7:20:11 PM
> > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and
> > for stable branch
> > 
> > there are already in place gerrit jobs for all flows, only this was
> > introduced before they were added:
> > 
> > ovirt_engine_3.2_update_db_to_3.3_gerrit
> > ovirt_engine_3.3.0_update_db_to_3.3_gerrit
> > ovirt_engine_3.3.1_update_db_to_3.3_gerrit
> > ovirt_engine_3.3_update_db_to_master_gerrit
> > ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit
> > ovirt_engine_master_update_db_to_master_gerrit
> > ovirt_engine_3.3_update_db_to_3.3_latest_gerrit
> > 
> > - Original Message -
> > > From: "Barak Azulay" 
> > > To: "Eli Mesika" 
> > > Cc: "engine-devel" , in...@ovirt.org, "Eyal Edri"
> > > 
> > > Sent: Thursday, October 24, 2013 7:13:04 PM
> > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and
> > > for   stable branch
> > > 
> > > We should  add a gerrit hook to enforce the right naming/version  of db
> > > upgrade scripts.
> > > 
> > > 
> > > Thanks
> > > Barak Azulay
> > > 
> > > - Original Message -
> > > > From: "Eli Mesika" 
> > > > To: "engine-devel" 
> > > > Sent: Thursday, October 24, 2013 6:49:21 PM
> > > > Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and
> > > > for
> > > > stable branch
> > > > 
> > > > Hi
> > > > 
> > > > Please note that any upgrade script introduced to the master branch
> > > > should
> > > > have the 03_04 prefix.
> > > > If this script is resolving a blocker/exception BZ it should be ported
> > > > to
> > > > the
> > > > ovirt-engine-3.3 branch with a 03_03 prefix !!!
> > > > 
> > > > We have encountered some patches that broke the upgrade from
> > > > ovirt-engine-3.3
> > > > to master as a result of
> > > > 
> > > > 1) naming new upgrade scripts in master branch with 03_03 prefix
> > > > 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch with
> > > > 03_04
> > > > prefix
> > > > 
> > > > I am available for any question and asking you to add me to any DB
> > > > related
> > > > script as a reviewer even if I +2 the master patch and you just
> > > > back-port
> > > > it
> > > > to ovirt-engine-3.3.
> > > > It may save us a lot of noise.
> > > > 
> > > > Thanks for your cooperation
> > > > 
> > > > Eli
> > > > ___
> > > > Engine-devel mailing list
> > > > Engine-devel@ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > 
> > > > 
> > > > 
> > > 
> > ___
> > Engine-devel mailing list
> > Engine-devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> > 
> > 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for stable branch

2013-10-27 Thread Eyal Edri


- Original Message -
> From: "Barak Azulay" 
> To: "Eyal Edri" 
> Cc: "engine-devel" , in...@ovirt.org
> Sent: Sunday, October 27, 2013 12:49:33 PM
> Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and for 
> stable branch
> 
> 
> 
> - Original Message -
> > From: "Eyal Edri" 
> > To: "Barak Azulay" 
> > Cc: "engine-devel" , in...@ovirt.org
> > Sent: Thursday, October 24, 2013 8:42:46 PM
> > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and
> > for stable branch
> > 
> > already active.
> 
> I may be missing something, so how wasn't it caught by those hooks ?

1. job was added AFTER failure was introduced (flow from 3.3 -> master).
2. job will now fail on every patch until issue is fixed.



> 
> 
> > 
> > - Original Message -
> > > From: "Barak Azulay" 
> > > To: "Eyal Edri" 
> > > Cc: "engine-devel" , in...@ovirt.org
> > > Sent: Thursday, October 24, 2013 8:12:27 PM
> > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master and
> > > for   stable branch
> > > 
> > > Even better,
> > > 
> > > When will these hooks be effective on engine  master & ovirt-3.3 ?
> > > 
> > > Barak
> > > 
> > > - Original Message -
> > > > From: "Eyal Edri" 
> > > > To: "Barak Azulay" 
> > > > Cc: "engine-devel" , in...@ovirt.org
> > > > Sent: Thursday, October 24, 2013 7:20:11 PM
> > > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master
> > > > and
> > > > for stable branch
> > > > 
> > > > there are already in place gerrit jobs for all flows, only this was
> > > > introduced before they were added:
> > > > 
> > > > ovirt_engine_3.2_update_db_to_3.3_gerrit
> > > > ovirt_engine_3.3.0_update_db_to_3.3_gerrit
> > > > ovirt_engine_3.3.1_update_db_to_3.3_gerrit
> > > > ovirt_engine_3.3_update_db_to_master_gerrit
> > > > ovirt_engine_3.3.0_update_db_to_3.3.1_gerrit
> > > > ovirt_engine_master_update_db_to_master_gerrit
> > > > ovirt_engine_3.3_update_db_to_3.3_latest_gerrit
> > > > 
> > > > - Original Message -
> > > > > From: "Barak Azulay" 
> > > > > To: "Eli Mesika" 
> > > > > Cc: "engine-devel" , in...@ovirt.org, "Eyal
> > > > > Edri"
> > > > > 
> > > > > Sent: Thursday, October 24, 2013 7:13:04 PM
> > > > > Subject: Re: [Engine-devel] [IMPORTANT] DB upgrade scripts for master
> > > > > and
> > > > > for   stable branch
> > > > > 
> > > > > We should  add a gerrit hook to enforce the right naming/version  of
> > > > > db
> > > > > upgrade scripts.
> > > > > 
> > > > > 
> > > > > Thanks
> > > > > Barak Azulay
> > > > > 
> > > > > - Original Message -
> > > > > > From: "Eli Mesika" 
> > > > > > To: "engine-devel" 
> > > > > > Sent: Thursday, October 24, 2013 6:49:21 PM
> > > > > > Subject: [Engine-devel] [IMPORTANT] DB upgrade scripts for master
> > > > > > and
> > > > > > for
> > > > > > stable branch
> > > > > > 
> > > > > > Hi
> > > > > > 
> > > > > > Please note that any upgrade script introduced to the master branch
> > > > > > should
> > > > > > have the 03_04 prefix.
> > > > > > If this script is resolving a blocker/exception BZ it should be
> > > > > > ported
> > > > > > to
> > > > > > the
> > > > > > ovirt-engine-3.3 branch with a 03_03 prefix !!!
> > > > > > 
> > > > > > We have encountered some patches that broke the upgrade from
> > > > > > ovirt-engine-3.3
> > > > > > to master as a result of
> > > > > > 
> > > > > > 1) naming new upgrade scripts in master branch with 03_03 prefix
> > > > > > 2) naming new upgrade scripts in ovirt-engine-3.3 stable branch
> > > > > > with
> > > > > > 03_04
> > > > > > prefix
> > > > > > 
> > > > > > I am available for any question and asking you to add me to any DB
> > > > > > related
> > > > > > script as a reviewer even if I +2 the master patch and you just
> > > > > > back-port
> > > > > > it
> > > > > > to ovirt-engine-3.3.
> > > > > > It may save us a lot of noise.
> > > > > > 
> > > > > > Thanks for your cooperation
> > > > > > 
> > > > > > Eli
> > > > > > ___
> > > > > > Engine-devel mailing list
> > > > > > Engine-devel@ovirt.org
> > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > 
> > > > ___
> > > > Engine-devel mailing list
> > > > Engine-devel@ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > 
> > > > 
> > > > 
> > > 
> > 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] [ATT] jenkins.ovirt.org is down

2013-10-31 Thread Eyal Edri
fyi,

Jenkins server is experiencing problems, and is currently down.
infra team is investigating the problems and will update once server is back up.

Eyal.
oVirt infra.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Fedora 20 support, Was: [Users] oVirt Weekly Meeting Minutes -- 2013-11-27

2013-11-30 Thread Eyal Edri
I updated the environment to support f20, including new slave and nighlites.

i will send a separate email on it soon to infra/users/devel.

Eyal.

- Original Message -
> From: "Doron Fediuck" 
> To: "Dan Kenigsberg" , "David Caro Estevez" 
> 
> Cc: bo...@ovirt.org, "users" , ee...@redhat.com, "Sandro 
> Bonazzola" 
> Sent: Thursday, November 28, 2013 1:55:13 PM
> Subject: Re: Fedora 20 support, Was: [Users] oVirt Weekly Meeting Minutes -- 
> 2013-11-27
> 
> 
> 
> - Original Message -
> > From: "Dan Kenigsberg" 
> > To: bo...@ovirt.org, "users" 
> > Cc: "Doron Fediuck" , ee...@redhat.com
> > Sent: Thursday, November 28, 2013 12:19:05 PM
> > Subject: Fedora 20 support, Was: [Users] oVirt Weekly Meeting Minutes --
> > 2013-11-27
> > 
> > We've forgotten to discuss an important issue: Fedora 20, which is
> > expected to be out in two weeks:
> > http://fedoraproject.org/wiki/Releases/20/Schedule.
> > I believe that ovirt-3.4 must support it, and that ovirt-3.3.2 would
> > better do so.
> > 
> > Toni has fixed two issues regarding Vdsm-networking, and they are going
> > into ovirt-3.3.2 beta. However, we must perform much more comprehensive
> > testing.
> > 
> > We'd need to have f20 Jenkins slave(s), and someone in each team
> > responsible to testing functionality. Who can cover for storage, virt,
> > infra and integration?
> > 
> > Dan.
> > 
> 
> Indeed so, thanks Dan.
> David, is this something we have resources for?
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] [ANN] new fedora20 nightlies rpms for oVirt are available for download

2013-11-30 Thread Eyal Edri
fyi,

oVirt infra has added support for nighlies rpms for various oVirt projects for 
fedora 20.
the following has be done:

- All ovirt projects were added f20 nightlies on jenkins.ovirt.org. (replaced 
f18, which is NOT built nightly anymore).
- One jenkins f19 slave (vm02) was upgraded to f20, and we also have a bare 
metal host running f20 as well.
- Nightlies rpms can be downloaded on the repos [1]
- Nightlies publish & cleanup scripts were updated on the resources.ovirt.org 
to support f20.

I didn't update any ovirt-node* job, since i'm not familiar with them.
if you would like to build f20 builds, just add the 'fedora20' label to the 
relevant jobs.

Eyal.

[1] http://resources.ovirt.org/releases/nightly/rpm/Fedora/20/
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] RES: Jenkins JAVA_HOME

2013-12-06 Thread Eyal Edri
Hi Gustavo,

The problem was misconfigured jnlp jenkins slave, please see other reply i sent 
to infra.

should be ok now, you can try and retrigger any jobs that failed on gerrit 
here: http://jenkins.ovirt.org/gerrit_manual_trigger/?

eyal.

- Original Message -
> From: "Gustavo Frederico Temple Pedrosa" 
> To: "Itamar Heim" , in...@ovirt.org, "engine-devel" 
> 
> Sent: Friday, December 6, 2013 2:48:23 PM
> Subject: RES: Jenkins JAVA_HOME
> 
> (#22107)
> http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/1098/console
> 
> (#18226)
> http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/1095/console
> 
> (#17972)
> http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/1039/console
> 
> 
> 
> 
> De: Itamar Heim [ih...@redhat.com]
> Enviado: sexta-feira, 6 de dezembro de 2013 10:24
> Para: Gustavo Frederico Temple Pedrosa; in...@ovirt.org; engine-devel
> Assunto: Re: Jenkins JAVA_HOME
> 
> On 12/05/2013 09:55 PM, Gustavo Frederico Temple Pedrosa wrote:
> > Hello all,
> >
> > I have two changes that the build failed with "Error: JAVA_HOME is not
> > defined correctly."
> >
> > Anyone knows how I fix this?
> 
> more details/link?
> ___
> Infra mailing list
> in...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Please add an account for me in oVirt Jenkins.

2013-12-12 Thread Eyal Edri
+1. (adding engine-devel also)

yaniv should have access to build ovirt dwh & reports projects on jenkins.

Eyal.

- Original Message -
> From: "Yaniv Dary" 
> To: in...@ovirt.org
> Sent: Thursday, December 12, 2013 6:50:33 PM
> Subject: Please add an account for me in oVirt Jenkins.
> 
> Hi,
> I need access to Jenkins to build projects and add/manage jobs. Can you
> please create an account for me?
> My fedora openID is ydary.
> 
> 
> Thanks!
> 
> ---
> Yaniv Dary
> BI Software Engineer
> Red Hat Israel Ltd.
> 34 Jerusalem Road
> Building A, 4th floor
> Ra'anana, Israel 43501
> 
> Tel : +972 (9) 7692306
> 72306
> Email: yd...@redhat.com
> IRC : ydary
> 
> ___
> Infra mailing list
> in...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] [jenkins] dao tests broken

2013-12-15 Thread Eyal Edri
fyi,

dao tests are broken for some time now, who can look into it?
current failing tests are:

Tests in error: 
  testAdUserConstrcutor(org.ovirt.engine.core.common.users.VdcUserTest): 
org.ovirt.engine.core.common.businessentities.LdapUser.setPassword(Ljava/lang/String;)V
  
testAdUserAndFalseBooleanConstrcutor(org.ovirt.engine.core.common.users.VdcUserTest):
 
org.ovirt.engine.core.common.businessentities.LdapUser.setPassword(Ljava/lang/String;)V
  
testAdUserAndTrueBooleanConstrcutor(org.ovirt.engine.core.common.users.VdcUserTest):
 
org.ovirt.engine.core.common.businessentities.LdapUser.setPassword(Ljava/lang/String;)V
  getUserFQN(org.ovirt.engine.core.common.users.VdcUserTest): 
org.ovirt.engine.core.common.businessentities.LdapUser.setPassword(Ljava/lang/String;)V

http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/5446/console

looks like it started after commit : 
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/5438/
core: scheduling: handle cpu load duration (detail / gitweb)

Eyal.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [CORE] broken backward compatibility for vm creation

2013-12-24 Thread Eyal Edri


- Original Message -
> From: "Michael Pasternak" 
> To: "Vitor de Lima" , "engine-devel" 
> , "Eyal Edri"
> 
> Cc: "Michal Skrivanek" 
> Sent: Tuesday, December 24, 2013 2:10:13 PM
> Subject: Re: [Engine-devel] [CORE] broken backward compatibility for vm 
> creation
> 
> 
> Thanks Vitor,
> 
> Such changes should be merged all together, otherwise they create significant
> noise in master,
> and make testing not possible what can lead to not stable master afterwards,
> 
> btw eyal, shouldn't Jenkins job be alerting on such changes?

we don't have currently any tests on engine rest other than unit tests/dao 
tests running on oVirt.


> 
> On 12/24/2013 02:04 PM, Vitor de Lima wrote:
> > This is temporarily broken due to the introduction of multi-architecture
> > support. Changes #18227 and #20667 are going to fix this by blocking the
> > addition of VMs into clusters without a defined architecture and properly
> > selecting the default OS when creating VMs.
> > 
> >> -Original Message-
> >> From: engine-devel-boun...@ovirt.org [mailto:engine-devel-
> >> boun...@ovirt.org] On Behalf Of Michael Pasternak
> >> Sent: terça-feira, 24 de dezembro de 2013 07:30
> >> To: engine-devel
> >> Cc: Michal Skrivanek
> >> Subject: [Engine-devel] [CORE] broken backward compatibility for vm
> >> creation
> >>
> >>
> >> [oVirt shell (connected)]# add vm --name test --cluster-id 0001-0001-
> >> 0001-0001-0001 --template-id ----
> >> 
> >>
> >>
> >> ==
> >> = ERROR
> >> ==
> >> ===
> >>   status: 400
> >>   reason: Bad Request
> >>   detail: Cannot add VM. Selected operating system is not supported by the
> >> architecture.
> >>
> >> ==
> >> ==
> >> ===
> >>
> >> [oVirt shell (connected)]# show template ----
> >> 
> >>
> >> id: ----
> >> name  : Blank
> >> description   : Blank template
> >> cluster-id: 0001-0001-0001-0001-0001
> >> cpu-architecture  : UNDEFINED
> >> cpu-topology-cores: 1
> >> cpu-topology-sockets  : 1
> >> cpu_shares: 0
> >> creation_time : 2008-04-01 00:00:00+03:00
> >> delete_protected  : False
> >> display-allow_override: False
> >> display-monitors  : 1
> >> display-single_qxl_pci: False
> >> display-smartcard_enabled : False
> >> display-type  : spice
> >> high_availability-enabled : False
> >> high_availability-priority: 0
> >> memory: 1073741824
> >> origin: rhev
> >> os-boot-dev   : hd
> >> os-type   : other
> >> stateless : False
> >> status-state  : ok
> >> type  : desktop
> >> usb-enabled   : False
> >>
> >> [oVirt shell (connected)]# show cluster 0001-0001-0001-0001-
> >> 0001
> >>
> >> id :
> >> 0001-0001-0001-0001-0001
> >> name   : Default
> >> description: The default server cluster
> >> ballooning_enabled : False
> >> data_center-id :
> >> 0002-0002-0002-0002-0002
> >> error_handling-on_error: migrate
> >> gluster_service: False
> >> memory_policy-overcommit-percent   : 100
> >> memory_policy-transparent_hugepages-enabled: True
> >> scheduling_policy-policy   : none
> >> threads_as_cores   : False
> >> trusted_service: False
> >> tunnel_migration   : False
> >> version-major  : 3
> >> version-minor  : 3
> >> virt_service   : True
> >>
> >> --
> >>
> >> Michael Pasternak
> >> RedHat, ENG-Virtualization R&D
> >> ___
> >> Engine-devel mailing list
> >> Engine-devel@ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> 
> --
> 
> Michael Pasternak
> RedHat, ENG-Virtualization R&D
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] [test email - sent at 12:30 IST]

2013-12-26 Thread Eyal Edri
sorry for the noise, testing mailman.

Eyal.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Request for power-user permissions

2013-12-28 Thread Eyal Edri
OK, +1 from me as well, i don't see any objections.
Nir, i will send you the credentials in private, please contact
the infra team for any assistance in configuring a specific job if needed.

Eyal.

- Original Message -
> From: "Dan Kenigsberg" 
> To: "Ayal Baron" 
> Cc: "engine-devel" , in...@ovirt.org
> Sent: Friday, December 27, 2013 2:34:36 AM
> Subject: Re: [Engine-devel] Request for power-user permissions
> 
> On Thu, Dec 26, 2013 at 03:10:27AM -0500, Ayal Baron wrote:
> > 
> > 
> > - Original Message -
> > > Hi all,
> > > 
> > > I'm Nir from storage team. I work mostly on vdsm.
> > > 
> > > I want power-user permissions for jenkins.ovirt.org so I would be able to
> > > create and modify jobs related to vdsm.
> > 
> > +1 from me.
> 
> +1
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] [jenkins] patch breaks jenkins jobs - compilation error

2014-01-01 Thread Eyal Edri
fyi,

patch http://gerrit.ovirt.org/#/c/22614/ has compilation errors and currently 
fails most of jenkins jobs.
the reason for jenkins not failing the patch is the short time between the new 
patchset #3 was added (rebased)
to the actual merge time, so jenkins didn't have enough time to run on the new 
patchset.

please allow time after rebasing for jenkins to re-run all tests.

Eyal.
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Strange findbugs warning for a phantom class

2014-01-02 Thread Eyal Edri
The obvious is to enable wipe workspace per run, but i fear that will be 
add much more run time per patch and that jenkins won't be able to handle the 
queue of jobs, but it's worth a try.

i will enable it for now, and we'll monitor the queue size.

eyal. 

- Original Message -
> From: "Yair Zaslavsky" 
> To: "Moti Asayag" 
> Cc: "engine-devel" ovirt.org>
> Sent: Friday, January 3, 2014 7:39:45 AM
> Subject: Re: [Engine-devel] Strange findbugs warning for a phantom class
> 
> I saw this today as well - findbugs showed new warnings for jsonrpc java
> client code , but my patches are not rebased against that work (the jsonrpc
> code is not merged to master).
> 
> 
> - Original Message -
> > From: "Yair Zaslavsky" 
> > To: "Moti Asayag" 
> > Cc: "engine-devel" ovirt.org>
> > Sent: Thursday, January 2, 2014 11:54:28 PM
> > Subject: Re: [Engine-devel] Strange findbugs warning for a phantom class
> > 
> > 
> > 
> > - Original Message -
> > > From: "Moti Asayag" 
> > > To: "engine-devel" ovirt.org>
> > > Sent: Thursday, January 2, 2014 7:40:47 PM
> > > Subject: [Engine-devel] Strange findbugs warning for a phantom class
> > > 
> > > It seems that findbugs complains [1] about a class which never
> > > existed in ovirt-engine (a job which is run per pushed patch):
> > > 
> > > org.ovirt.engine.core.authentication.tls.TlsSocketFactoryN
> > 
> > I can only say what is the source of this class - the AAA rewrite Juan and
> > I
> > are working on.
> > > 
> > > This produces too much noise in gerrit. I'm not sure what is the
> > > origin of the class, but i was under the assumption that findbugs
> > > should be run for each patch on a clean env, without leftovers
> > > from job on other patches.
> > > 
> > > Any idea how to clear this class/error ?
> > 
> > +1 on Moti's question - I think I saw this behavior last week as well.
> > 
> > > 
> > > [1]
> > > http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/3269/findbugsResult/?
> > > 
> > > Thanks,
> > > Moti
> > > 
> > > 
> > > 
> > > ___
> > > Engine-devel mailing list
> > > Engine-devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > 
> > ___
> > Engine-devel mailing list
> > Engine-devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Strange findbugs warning for a phantom class

2014-01-02 Thread Eyal Edri
not sure, the results are created from the src code, and if the same job 
checksout diff patches to the same place that can create the fp errors we see 
now..
deleting the results will just mean they will be created again the same...

On Jan 3, 2014 9:42 AM, Itamar Heim  wrote:
>
> On 01/03/2014 08:58 AM, Eyal Edri wrote: 
> > The obvious is toOn 01/03/2014 08:58 AM, Eyal Edri wrote:
> The obvious is to enable wipe workspace per run, but i fear that will be
> add much more run time per patch and that jenkins won't be able to handle the
> queue of jobs, but it's worth a try.
>
> i will enable it for now, and we'll monitor the queue size.

I don't think you need to clean the entire workspace, just the findbugs 
results, which are probably showing results of a class no longer there.

>
> eyal.
>
> - Original Message -
>> From: "Yair Zaslavsky" 
>> To: "Moti Asayag" 
>> Cc: "engine-devel" ovirt.org>
>> Sent: Friday, January 3, 2014 7:39:45 AM
>> Subject: Re: [Engine-devel] Strange findbugs warning for a phantom class
>>
>> I saw this today as well - findbugs showed new warnings for jsonrpc java
>> client code , but my patches are not rebased against that work (the jsonrpc
>> code is not merged to master).
>>
>>
>> - Original Message -
>>> From: "Yair Zaslavsky" 
>>> To: "Moti Asayag" 
>>> Cc: "engine-devel" ovirt.org>
>>> Sent: Thursday, January 2, 2014 11:54:28 PM
>>> Subject: Re: [Engine-devel] Strange findbugs warning for a phantom class
>>>
>>>
>>>
>>> - Original Message -
>>>> From: "Moti Asayag" 
>>>> To: "engine-devel" ovirt.org>
>>>> Sent: Thursday, January 2, 2014 7:40:47 PM
>>>> Subject: [Engine-devel] Strange findbugs warning for a phantom class
>>>>
>>>> It seems that findbugs complains [1] about a class which never
>>>> existed in ovirt-engine (a job which is run per pushed patch):
>>>>
>>>> org.ovirt.engine.core.authentication.tls.TlsSocketFactoryN
>>>
>>> I can only say what is the source of this class - the AAA rewrite Juan and
>>> I
>>> are working on.
>>>>
>>>> This produces too much noise in gerrit. I'm not sure what is the
>>>> origin of the class, but i was under the assumption that findbugs
>>>> should be run for each patch on a clean env, without leftovers
>>>> from job on other patches.
>>>>
>>>> Any idea how to clear this class/error ?
>>>
>>> +1 on Moti's question - I think I saw this behavior last week as well.
>>>
>>>>
>>>> [1]
>>>> http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/3269/findbugsResult/?
>>>>
>>>> Thanks,
>>>> Moti
>>>>
>>>>
>>>>
>>>> ___
>>>> Engine-devel mailing list
>>>> Engine-devel@ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>
>>> ___
>>> Engine-devel mailing list
>>> Engine-devel@ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>> ___
>> Engine-devel mailing list
>> Engine-devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>

___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] IMPORTANT: FindBugs threshold update

2014-01-05 Thread Eyal Edri


- Original Message -
> From: "Moti Asayag" 
> To: "Yair Zaslavsky" 
> Cc: "Oved Ourfalli" , "Eyal Edri" , 
> "engine-devel" 
> Sent: Thursday, January 2, 2014 11:46:29 AM
> Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update
> 
> 
> 
> - Original Message -
> > From: "Yair Zaslavsky" 
> > To: "Moti Asayag" 
> > Cc: "Oved Ourfalli" , "Eyal Edri" ,
> > "engine-devel" 
> > Sent: Thursday, January 2, 2014 11:12:17 AM
> > Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update
> > 
> > 
> > 
> > - Original Message -
> > > From: "Moti Asayag" 
> > > To: "Oved Ourfalli" , "Eyal Edri" 
> > > Cc: "engine-devel" 
> > > Sent: Thursday, January 2, 2014 12:08:43 AM
> > > Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update
> > > 
> > > 
> > > 
> > > - Original Message -
> > > > From: "Oved Ourfalli" 
> > > > To: "engine-devel" , "Allon Mureinik"
> > > > , "Alissa Bonas"
> > > > 
> > > > Sent: Wednesday, January 1, 2014 4:25:50 PM
> > > > Subject: [Engine-devel] IMPORTANT: FindBugs threshold update
> > > > 
> > > > Hi all,
> > > > 
> > > > Up until now the jenkins jobs on the gerrit patches included a findbugs
> > > > job,
> > > > that failed only in case of a warning of level NORMAL or higher.
> > > > Now we update this threshold to fail on any findbugs warning, including
> > > > LOW
> > > > ones.
> > 
> > Moti -
> > 1. Aren't use running a local jenkins instance on one of your hosts? Maybe
> > Eyal can publish the findbugs job?
> 
> Well...that server is on maintenance for quite a while...
> 
> > 2. What about running the findbugs UI? I find it kinda handy...
> 
> The findbugs UI expects the xml created by findbugs with all of the
> violations.
> The question is how those violation are created ? where are the rules by
> which
> findbugs verifies the code (can be findbugs jar or jenkins findbugs plugin or
> other...).
> 
> Currently by running 'mvn findbugs:findbugs' i don't get a a single xml
> aggregating
> all of the violations and the produced ones contain a lot of warnings.
> 
> So I'd like to know how can i be able to run this test locally ?

did you try using eclipse findbugs plugin? 
http://findbugs.sourceforge.net/manual/eclipse.html
i think the most easiest will be is just to check the failures you get on 
jenkins per patch job.
and if there are false positives - report to infra and we'll check and fix.

you're missing the aggregate part jenkins findbugs plugin does - 
http://fpaste.org/65793/09122138/.
and i'm not sure if the mvn findbugs plugin has that option on the cli. 

> 
> > 
> > 
> > > > 
> > > 
> > > Could you provide instructions of running findbugs locally and how to
> > > evaluate
> > > the result the same as done by the jenkins job ?
> > > 
> > > > Please make sure to rebase your current patches and check that the
> > > > findbugs
> > > > job finish successfully.
> > > > It will probably fail without a rebase, as the last patches clearing
> > > > the
> > > > warnings were merged a few hours ago.
> > > > 
> > > > Kodus to everyone involved in clearing all the LOW level warnings...
> > > > mostly
> > > > Allon and Alissa, but others helped as well! :-)
> > > > 
> > > 
> > > Well done!
> > 
> > Great news - good work guys!
> > 
> > > 
> > > > Cheers,
> > > > Oved
> > > > ___
> > > > Engine-devel mailing list
> > > > Engine-devel@ovirt.org
> > > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > > 
> > > ___
> > > Engine-devel mailing list
> > > Engine-devel@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > > 
> > 
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] proposing Alexander Wels as an ovirt-engine UI maintainer

2014-01-21 Thread Eyal Edri
- Original Message -
> From: "Einav Cohen" 
> To: "Tal Nisan" , "Gilad Chaplik" , 
> "Vojtech Szocs" ,
> "Kanagaraj" , "Daniel Erez" , "Tomas 
> Jelinek" , "Lior
> Vernia" 
> Cc: "engine-devel" , in...@ovirt.org
> Sent: Tuesday, January 21, 2014 5:39:09 PM
> Subject: [Engine-devel] proposing Alexander Wels as an ovirt-engine UI
> maintainer
> 
> Hello UI Maintainers,
> 
> I would like to propose Alexander Wels as an ovirt-engine UI maintainer.
> 
> Alexander started his ovirt involvement more than a year ago,
> contributing over 100 patches (to 'master' alone), including the
> branding mechanism, Frontend refactoring (cleanup, unit-tests, requests
> retry mechanism, requests-aggregation mechanism), cross-GUI refresh
> synchronization and low-resolutions support.
> 
> Your response would be appreciated.
> 
> Thanks in advance.

+1. well deserved.

eyal.

> 
> 
> Regards,
> Einav
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


  1   2   >