Re: [E-devel] imlib2 xpm buffer overflow
On Tue, 4 Jan 2005, Carsten Haitzler wrote: > On Sun, 12 Dec 2004 23:41:16 -0500 "Laurence J. Lane" <[EMAIL PROTECTED]> > babbled: > > > The xpm buffer overflow reported for imlib also appears to affect > > imlib2. You can read the details at: http://bugs.debian.org/285138 > > (a bit slow thanks to xmas and new years...) but.. fixed in cvs. i am tempted > to release imlib2 1.2.0 - does anyone have any objections, patches etc. etc. > etc. ? no objection, just the patch i've send you for the hsv<->rgb conversion Vincent Torri --- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almosthttp://www.thinkgeek.com/sfshirt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Odd chown assignment in e16.8.0 themes
On Thursday, 06 January 2005, at 14:44:10 (-0500), Peter Hyman wrote: > Precisely the point. Because no group is set, a default is assigned. > That is wrong. If you're root, yes. As a user, no. In any event, proper packaging results in this not mattering one wit because the packaging instructions (like the ones in the spec file) determine user and group ownerships. And in any event, group ownership doesn't matter. Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]> n + 1, Inc., http://www.nplus1.net/ Author, Eterm (www.eterm.org) --- "So tonight I'll ask the stars above, how did I ever win your love? What did I do? What did I say to turn your Angel Eyes my way?" -- Jeff Healy Band, "Angel Eyes" --- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almosthttp://www.thinkgeek.com/sfshirt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Odd chown assignment in e16.8.0 themes
On Thursday, 06 January 2005, at 14:29:18 (-0500), Peter Hyman wrote: > On my system, Group becomes a 601 for some reason which in packaging > is unacceptable. Either set the group too or omit this. [EMAIL PROTECTED] ~/cvs >> grep -ri group e16/e/themes/Makefile* [EMAIL PROTECTED] ~/cvs >> 'Nuff said. Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]> n + 1, Inc., http://www.nplus1.net/ Author, Eterm (www.eterm.org) --- "That little Huggie bastard just threw a spear at me!" -- Calista Flockhart, "Ally McBeal" --- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almosthttp://www.thinkgeek.com/sfshirt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Odd chown assignment in e16.8.0 themes
On my system, Group becomes a 601 for some reason which in packaging is unacceptable. Either set the group too or omit this. On Thu, 2005-01-06 at 14:22 -0500, Michael Jennings wrote: > On Thursday, 06 January 2005, at 12:11:42 (-0500), > Peter Hyman wrote: > > > make install in e/themes is perhaps incorrect in that it tries and > > assign a group equal to the themes install directory. > > Not on this planet, it doesn't. Where on earth did you come up with > that idea? > > > install-data-local: > > $(mkinstalldirs) $(THEME_DIR) > > for tf in $(THEME_FILES); do \ > > gzip -d -c < $(srcdir)/$$tf | (cd $(THEME_DIR); tar -xmf -); \ > > done > > -if [ -n "$(USER)" ]; then chown -R $(USER) $(THEME_DIR); else chown -R > > root $(THEME_DIR); fi > > > > Did you mean maybe $(GROUP)? Why is this even here? > > Umm, no. chOWN is not the same as chGRP. Furthermore, the command > cannot cause the build to fail; it is preceeded by a -. > > The command is correct. > > Michael > -- Peter --- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almosthttp://www.thinkgeek.com/sfshirt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Odd chown assignment in e16.8.0 themes
On Thursday, 06 January 2005, at 12:11:42 (-0500), Peter Hyman wrote: > make install in e/themes is perhaps incorrect in that it tries and > assign a group equal to the themes install directory. Not on this planet, it doesn't. Where on earth did you come up with that idea? > install-data-local: > $(mkinstalldirs) $(THEME_DIR) > for tf in $(THEME_FILES); do \ > gzip -d -c < $(srcdir)/$$tf | (cd $(THEME_DIR); tar -xmf -); \ > done > -if [ -n "$(USER)" ]; then chown -R $(USER) $(THEME_DIR); else chown -R > root $(THEME_DIR); fi > > Did you mean maybe $(GROUP)? Why is this even here? Umm, no. chOWN is not the same as chGRP. Furthermore, the command cannot cause the build to fail; it is preceeded by a -. The command is correct. Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]> n + 1, Inc., http://www.nplus1.net/ Author, Eterm (www.eterm.org) --- "I'll be leaving soon; it's hard to say when I'll return, and I don't want to lead you on. So if you feel the need, close your eyes and share this dream. It will be Eternity." -- Blessid Union of Souls, "Forever for Tonight" --- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almosthttp://www.thinkgeek.com/sfshirt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Odd chown assignment in e16.8.0 themes
On Thu, 2005-01-06 at 14:34 -0500, Michael Jennings wrote: > On Thursday, 06 January 2005, at 14:29:18 (-0500), > Peter Hyman wrote: > > > On my system, Group becomes a 601 for some reason which in packaging > > is unacceptable. Either set the group too or omit this. > > [EMAIL PROTECTED] ~/cvs >> grep -ri group e16/e/themes/Makefile* > [EMAIL PROTECTED] ~/cvs >> Precisely the point. Because no group is set, a default is assigned. That is wrong. As Kim pointed out, this method is odd to say the least. > > 'Nuff said. Michael, not everyone knows as much as you do, but you do not need to be condescending to those trying to learn and help. > > Michael > -- Peter --- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almosthttp://www.thinkgeek.com/sfshirt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e16.8 in CVS
cypher wrote: It's great to see that E has begun to make use of the new X extensions before the other window managers. :) Are there any plans to use the new composite manager in conjunction with the pager and/or iconified windows? It would be awfully nice (and very useful) to have off-screen window-contents updated in real-time on the pager's display and on iconified window representations. Most of the the code to do that is already in there, at least for the iconboxes, but has been disabled for the moment. The only thing missing is a regular refresh of the window snapshots, which can be done in more and less clever ways. It should be fairly easy to extend this to the pagers, I think. Some day... :) /Kim --- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almosthttp://www.thinkgeek.com/sfshirt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Odd chown assignment in e16.8.0 themes
See thread: http://sourceforge.net/mailarchive/message.php?msg_id=6022045. I have regularly considered expanding the *.etheme's into plain CVS trees. That should bypass the problem entirely. IMO, archiving the .etheme's as such goes against the whole purpose of CVS anyway. /Kim Peter Hyman wrote: make install in e/themes is perhaps incorrect in that it tries and assign a group equal to the themes install directory. This, of course, cannot work. e/themes/Makefile.am install-data-local: $(mkinstalldirs) $(THEME_DIR) for tf in $(THEME_FILES); do \ gzip -d -c < $(srcdir)/$$tf | (cd $(THEME_DIR); tar -xmf -); \ done -if [ -n "$(USER)" ]; then chown -R $(USER) $(THEME_DIR); else chown -R root $(THEME_DIR); fi Did you mean maybe $(GROUP)? Why is this even here? --- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almosthttp://www.thinkgeek.com/sfshirt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Odd chown assignment in e16.8.0 themes
make install in e/themes is perhaps incorrect in that it tries and assign a group equal to the themes install directory. This, of course, cannot work. e/themes/Makefile.am install-data-local: $(mkinstalldirs) $(THEME_DIR) for tf in $(THEME_FILES); do \ gzip -d -c < $(srcdir)/$$tf | (cd $(THEME_DIR); tar -xmf -); \ done -if [ -n "$(USER)" ]; then chown -R $(USER) $(THEME_DIR); else chown -R root $(THEME_DIR); fi Did you mean maybe $(GROUP)? Why is this even here? -- Peter --- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almosthttp://www.thinkgeek.com/sfshirt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Spec file(s) patche
On Thursday, 06 January 2005, at 09:01:31 (-0500), Jason Williams wrote: > I was messing around with the CVS code last night and got all the > stuff to build for e17/apps/e. Attached is a spec file for the libs > and such so that you can easily build the RPMS for them. The only > thing that probably should be committed is the change for freetype > in the evas package. On Fedora, the package is freetype-2.x.x on > other boxes it might be noted as freetype2... just a inconsistancy > I came across anyway, enjoy. Applied, thanks. Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]> n + 1, Inc., http://www.nplus1.net/ Author, Eterm (www.eterm.org) --- "The first lesson reading teaches is how to be alone." -- Jonathan Franzen --- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almosthttp://www.thinkgeek.com/sfshirt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Doxygen small start
I decided I might give it a try at commenting e 17. This about the first
time I deal with C and I have never used doxygen before.
I'd like someone to review my patch and tell me if it can be of any use
(or if I'm just wasting my time). Comments and constructive feedback are
welcomed. If my doxygen comments are dumb and useless please let me know
I won't be offended.
Cheers,
Till
diff -Naur src.old/bin/e_module.h src/bin/e_module.h
--- src.old/bin/e_module.h 2005-01-06 03:43:49.833807960 +0100
+++ src/bin/e_module.h 2005-01-06 16:21:02.984680008 +0100
@@ -17,10 +17,42 @@
void*handle;
struct {
+ /**
+ @brief This is called when the module is initialised.
+
+ Use it to fill the menu and whatever else you should do to make the
+ module availlable to the user. However this souldn't start the module
+ without any checks.
+ \n Since the module has it's own menu it is best to let the user start
+ it from there (and choose wether he wants or not to have the module
+ running).
+ */
void * (*init)(E_Module *m);
+ /**
+ @brief Exits the module
+
+ Stops the modules and cleans up behind (removes the entries in the
+ contextual menu...)
+ */
int(*shutdown)(E_Module *m);
+ /**
+ @brief Saves the configuration data for the modules.
+ */
int(*save)(E_Module *m);
+ /**
+ @brief Initializes the infos used to represent this module in the menus.
+
+ Sets the icon and label associated with module.
+ [EMAIL PROTECTED] _E_Module::label},[EMAIL PROTECTED]
_E_Module::icon_file},
+ [EMAIL PROTECTED] _E_Module::edje_icon_file} [EMAIL PROTECTED]
_E_Module::edje_icon_key}
+ can be set during this function (and they shouldn't be set elsewere).
+ */
int(*info)(E_Module *m);
+ /**
+ @brief Shows info about this module.
+
+ Usually will pop up an about dialogue box (...)
+ */
int(*about) (E_Module *m);
} func;
@@ -28,14 +60,48 @@
/* the module is allowed to modify these */
void*data;
+ /**
+ @brief The menu corresponding to this module (accessible via right click)
+ \n
+ It is up to the module itself to fill it (generaly during the init phase)
+ */
E_Menu *config_menu;
/* modify these but only set them up when the info func is called */
/* e_module will free them when the module is freed. */
/* note you will need to malloc (strdup) these fields due to the free */
+
+ /**
+ @brief The label for this module (name that will show up in the menu)
+
+ modify these but only set it up when the info func is called
+ e_module will free them when the module is freed.
+ \warning note you will need to malloc (strdup) this field due to the free
+ */
char*label;
+ /**
+ @brief The icon for this module (will show up in the right click desktop
+ menu)
+
+ modify this but only set it up when the info func is called
+ \n
+ e_module will free it when the module is freed.
+ \warning note you will need to malloc (strdup) this field due to the free
+ */
char*icon_file;
+ /**
+ modify this but only set it up when the info func is called
+ \n
+ e_module will free it when the module is freed.
+ \warning note you will need to malloc (strdup) this field due to the free
+ */
char*edje_icon_file;
+ /**
+ modify this but only set it up when the info func is called
+ \n
+ e_module will free it when the module is freed.
+ \warning note you will need to malloc (strdup) this field due to the free
+ */
char*edje_icon_key;
};
diff -Naur src.old/modules/test/e_mod_main.c src/modules/test/e_mod_main.c
--- src.old/modules/test/e_mod_main.c 2005-01-06 03:43:49.849805464 +0100
+++ src/modules/test/e_mod_main.c 2005-01-06 04:09:26.096113648 +0100
@@ -1,6 +1,16 @@
+/**
+ @file test/e_mod_main.c
+ @brief A sample minimale module
+ */
+
#include "e.h"
#include "e_mod_main.h"
+/**
+ @brief Initializes the module
+ The options are added in the module menu (right click). However the module
+ itself shouldn't be lauched.
+*/
void *
init(E_Module *m)
{
[E-devel] Spec file(s) patche
I was messing around with the CVS code last night and got all the stuff to
build for e17/apps/e. Attached is a spec file for the libs and such so
that you can easily build the RPMS for them. The only thing that probably
should be committed is the change for freetype in the evas package. On
Fedora, the package is freetype-2.x.x on other boxes it might be noted as
freetype2... just a inconsistancy I came across anyway, enjoy.
--
Jason Williams
Lead Developer
Gaim Assistant
<[EMAIL PROTECTED]>diff -ur e17/apps/e/enlightenment.spec e17-vanilla/apps/e/enlightenment.spec
--- e17/apps/e/enlightenment.spec 2005-01-05 00:05:23.0 -0500
+++ e17-vanilla/apps/e/enlightenment.spec 2005-01-05 19:31:02.802239769 -0500
@@ -18,6 +18,16 @@
%description
Enlightenment is a window manager.
+%package devel
+Summary: Development headers for Enlightenment.
+Group: User Interface/Desktops
+Requires: %{name} = %{version}
+Requires: libjpeg-devel XFree86-devel eet-devel embryo-devel
+Requires: evas-devel edb-devel edje-devel imlib2-devel ecore-devel
+
+%description devel
+Development headers for Enlightenment.
+
%prep
%setup -q
@@ -45,4 +55,8 @@
%{_libdir}/%{name}
%{_datadir}/%{name}
+%files devel
+%defattr(-, root, root)
+%{_includedir}/enlightenment/*.h
+
%changelog
diff -ur e17/libs/epsilon/epsilon.spec e17-vanilla/libs/epsilon/epsilon.spec
--- e17/libs/epsilon/epsilon.spec 2005-01-05 00:05:29.0 -0500
+++ e17-vanilla/libs/epsilon/epsilon.spec 2005-01-05 19:05:45.705921729 -0500
@@ -10,7 +10,6 @@
Packager: %{?_packager:%{_packager}}%{!?_packager:Michael Jennings <[EMAIL PROTECTED]>}
Vendor: %{?_vendorinfo:%{_vendorinfo}}%{!?_vendorinfo:The Enlightenment Project (http://www.enlightenment.org/)}
Distribution: %{?_distribution:%{_distribution}}%{!?_distribution:%{_vendor}}
-Vendor: The Enlightenment Development Team <[EMAIL PROTECTED]>
#BuildSuggests: xorg-x11-devel
BuildRequires: epeg-devel imlib2-devel libjpeg-devel freetype-devel XFree86-devel
Requires: epeg >= 0.9.0
diff -ur e17/libs/esmart/esmart.spec e17-vanilla/libs/esmart/esmart.spec
--- e17/libs/esmart/esmart.spec 2005-01-05 00:05:29.0 -0500
+++ e17-vanilla/libs/esmart/esmart.spec 2005-01-05 19:10:18.523607004 -0500
@@ -11,7 +11,6 @@
Packager: %{?_packager:%{_packager}}%{!?_packager:Michael Jennings <[EMAIL PROTECTED]>}
Vendor: %{?_vendorinfo:%{_vendorinfo}}%{!?_vendorinfo:The Enlightenment Project (http://www.enlightenment.org/)}
Distribution: %{?_distribution:%{_distribution}}%{!?_distribution:%{_vendor}}
-Vendor: The Enlightenment Development Team <[EMAIL PROTECTED]>
Requires: evas >= 1.0.0 imlib2 libjpeg ecore epsilon
Requires: edje freetype eet edb embryo
#BuildSuggests: xorg-x11-devel
diff -ur e17/libs/evas/evas.spec e17-vanilla/libs/evas/evas.spec
--- e17/libs/evas/evas.spec 2005-01-05 00:05:29.0 -0500
+++ e17-vanilla/libs/evas/evas.spec 2005-01-05 18:56:31.752387057 -0500
@@ -12,7 +12,7 @@
Vendor: %{?_vendorinfo:%{_vendorinfo}}%{!?_vendorinfo:The Enlightenment Project (http://www.enlightenment.org/)}
Distribution: %{?_distribution:%{_distribution}}%{!?_distribution:%{_vendor}}
#BuildSuggests: xorg-x11-devel
-BuildRequires: libpng-devel eet-devel edb-devel XFree86-devel freetype2-devel libjpeg-devel
+BuildRequires: libpng-devel eet-devel edb-devel XFree86-devel freetype-devel libjpeg-devel
Provides: evas evas_software_x11 evas_loader_png evas_loader_jpeg evas_loader_eet evas_loader_edb
BuildRoot: %{_tmppath}/%{name}-%{version}-root
diff -ur e17/libs/ewl/ewl.spec e17-vanilla/libs/ewl/ewl.spec
--- e17/libs/ewl/ewl.spec 2005-01-05 00:05:30.0 -0500
+++ e17-vanilla/libs/ewl/ewl.spec 2005-01-05 19:16:33.186798843 -0500
@@ -72,7 +72,6 @@
%{_bindir}/ewl-config
%{_bindir}/ewl_test
%{_bindir}/ewl_embed_test
-%{_bindir}/ewl_media_test
%{_bindir}/ewl_simple_test
%changelog
diff -ur e17/libs/imlib2/imlib2.spec e17-vanilla/libs/imlib2/imlib2.spec
--- e17/libs/imlib2/imlib2.spec 2005-01-04 09:47:03.0 -0500
+++ e17-vanilla/libs/imlib2/imlib2.spec 2005-01-05 18:30:01.274620690 -0500
@@ -136,12 +136,18 @@
%defattr(-, root, root)
%doc AUTHORS COPYING README ChangeLog doc/index.html doc/imlib2.gif doc/blank.gif
%{_libdir}/lib*.so.*
+/usr/share/imlib2/data/fonts/*.ttf
+/usr/share/imlib2/data/images/*.png
%{_bindir}/*
%files devel
%defattr(-, root, root, 0755)
%{_libdir}/libImlib2.so
%{_libdir}/*.a
+%{_libdir}/imlib2/loaders/*.a
+%{_libdir}/imlib2/loaders/*.la
+%{_libdir}/imlib2/filters/*.a
+%{_libdir}/imlib2/filters/*.la
%{_libdir}/*.la
%{_libdir}/pkgconfig/imlib2.pc
%{_includedir}/*
