Re: [E-devel] E CVS: libs/e_dbus ravenlock

2007-11-17 Thread Nathan Ingersoll 
Yes, a warning would be better than silently returning.

On 11/17/07, Kenneth Christiansen <[EMAIL PROTECTED]> wrote:
> At least it would be better to show an error, than just returning, right?
>
> - Kenneth
>
> On 11/17/07, Ulisses Furquim <[EMAIL PROTECTED]> wrote:
> > On Nov 17, 2007 2:11 PM, Nathan Ingersoll <[EMAIL PROTECTED]> wrote:
> > > Is this a proper fix or hiding a bug in the calling application (or
> > > another part of the lib)? I would think the application should be
> > > responsible of knowing when they should unref the connection.
> >
> > I strongly agree with you. I don't like this type of "defensive"
> > programming that hides real errors. It seems we need a proper fix
> > somewhere else, indeed.
> >
> > -- Ulisses
> >
> > -
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2005.
> > http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
> -
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E CVS: libs/e_dbus ravenlock

2007-11-17 Thread Kenneth Christiansen 
At least it would be better to show an error, than just returning, right?

- Kenneth

On 11/17/07, Ulisses Furquim <[EMAIL PROTECTED]> wrote:
> On Nov 17, 2007 2:11 PM, Nathan Ingersoll <[EMAIL PROTECTED]> wrote:
> > Is this a proper fix or hiding a bug in the calling application (or
> > another part of the lib)? I would think the application should be
> > responsible of knowing when they should unref the connection.
>
> I strongly agree with you. I don't like this type of "defensive"
> programming that hides real errors. It seems we need a proper fix
> somewhere else, indeed.
>
> -- Ulisses
>
> -
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E CVS: libs/e_dbus ravenlock

2007-11-17 Thread Ulisses Furquim 
On Nov 17, 2007 2:11 PM, Nathan Ingersoll <[EMAIL PROTECTED]> wrote:
> Is this a proper fix or hiding a bug in the calling application (or
> another part of the lib)? I would think the application should be
> responsible of knowing when they should unref the connection.

I strongly agree with you. I don't like this type of "defensive"
programming that hides real errors. It seems we need a proper fix
somewhere else, indeed.

-- Ulisses

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E CVS: libs/e_dbus ravenlock

2007-11-17 Thread Nathan Ingersoll 
Is this a proper fix or hiding a bug in the calling application (or
another part of the lib)? I would think the application should be
responsible of knowing when they should unref the connection.

On 11/16/07, Enlightenment CVS <[EMAIL PROTECTED]> wrote:
> Enlightenment CVS committal
>
> Author  : ravenlock
> Project : e17
> Module  : libs/e_dbus
>
> Dir : e17/libs/e_dbus/src/lib/dbus
>
>
> Modified Files:
> e_dbus.c
>
>
> Log Message:
> Ive gotten a segfault or two here.
>
> ===
> RCS file: /cvs/e/e17/libs/e_dbus/src/lib/dbus/e_dbus.c,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -3 -r1.2 -r1.3
> --- e_dbus.c4 Nov 2007 07:51:36 -   1.2
> +++ e_dbus.c17 Nov 2007 03:26:08 -  1.3
> @@ -548,6 +548,7 @@
>  EAPI void
>  e_dbus_connection_unref(E_DBus_Connection *conn)
>  {
> +  if (!conn) return;
>if (--(conn->refcount) == 0) e_dbus_connection_close(conn);
>  }
>
>
>
>
> -
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
> ___
> enlightenment-cvs mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
>

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [PATCH] ecore_evas_fb crash fix

2007-11-17 Thread Lars Munch 
Hi

This small patch fixes a crash in ecore_evas_fb when there are no input
devices in /dev/input.

Please apply

-- Lars Munch
Index: src/lib/ecore_evas/ecore_evas_fb.c
===
RCS file: /var/cvs/e/e17/libs/ecore/src/lib/ecore_evas/ecore_evas_fb.c,v
retrieving revision 1.29
diff -u -r1.29 ecore_evas_fb.c
--- src/lib/ecore_evas/ecore_evas_fb.c	26 Sep 2007 15:41:50 -	1.29
+++ src/lib/ecore_evas/ecore_evas_fb.c	17 Nov 2007 16:16:06 -
@@ -74,6 +74,7 @@
 	ee = (Ecore_Evas *)l;
 	ee->visible = 0;
  }
+   if(!ecore_evas_input_devices) return;
ecore_list_first_goto(ecore_evas_input_devices);
dev = ecore_list_current(ecore_evas_input_devices);
do
@@ -99,6 +100,7 @@
 	else
 	  evas_damage_rectangle_add(ee->evas, 0, 0, ee->w, ee->h);
  }
+   if(!ecore_evas_input_devices) return;
ecore_list_first_goto(ecore_evas_input_devices);
dev = ecore_list_current(ecore_evas_input_devices);
do
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel