Re: [E-devel] Cut'n'paste error in ecore_pipe.c
On Tue, Jun 7, 2011 at 8:41 AM, Vincent Torri vto...@univ-evry.fr wrote:
On Tue, 7 Jun 2011, Ulrich Eckhardt wrote:
I've been reading commits recently, and found a small buglet committed in
revision 59823. The line
ECORE_MAGIC_FAIL(p, ECORE_MAGIC_PIPE, ecore_pipe_read_close);
should probably contain the function name as string, but it doesn't for the
freeze/thaw functions.
in svn, thanks.
I'm wondering why __FUNCTION__ is not used, though. We could then define a
macro:
#define ECORE_PIPE_CHECK(p) \
if (!ECORE_MAGIC_CHECK((p), ECORE_MAGIC_PIPE)) \
{ \
ECORE_MAGIC_FAIL((p), ECORE_MAGIC_PIPE, __FUNCTION__); \
return; \
}
It would be less error-prone. And actually, that could be used in a lot of
places other than ecore_pipe.
In fact we should move to Eina Magic that already do all that stuff properly.
--
Cedric BAIL
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Working on Docs
C isn't a big issue. The main problem is that even if you can read doxygen and see params needed for every functions, and what they return, it is sometimes hard to see how to build your App. Tutorials and examples are few. On 07/06/2011 00:02, Gustavo Sverzut Barbieri wrote: On Mon, Jun 6, 2011 at 6:44 PM, Steven Le Rouxste...@le-roux.info wrote: Hi, at the last EFL meeting in france with #e.fr , yoz suggested few, bloody simple example which could be run by simple copy/paste/compile I think it's a good idea too because doxygen and API (documentation) works great with devs, but it's maybe not sexy enough to convert a web dev/sysadmin/whatever into a C developper... well, this is another problem I'm personally interested for a while. EFL's biggest problem is the lack of applications(*) using it. And lack of application is deeply linked with lack of high level languages(**), at least supported officially and as a first class citizen. I tried to solve this long ago when I created python-efl to save our development time with Canola software (circa 2007). It turned out to be successfully OUTSIDE efl community, with great adoption on Maemo and OpenMoko and it you aggregate these applications, it turns out we have more Python-EFL applications than C applications using EFL :-) Nonetheless EFL community bashes Python's usage and I have no free time (or motivation for the sake of it) to maintain python-efl or bring it to a first-class citizen of our community. In the hope to solve this problem I'm trying to find companies to sponsor/contract a project to create JavaScript bindings and actually an even higher level layer on top of Elementary to make development as simple as web. It's being hard, but if you know interested companies let me know ;-) The idea is instead of just exposing widgets to users and having them to do plumbing to get something that resembles an application, we follow Web Frameworks (Rails, Django) or Mobile Frameworks (iPhone, Android) and deliver solutions that abstract those and let the developer focus on the problem rather then extensive work to get basics. -- Real world example is the amount of work you have to do to create drill down navigation in EFL x (Android|iPhone). The combination of Higher Level Languages x Higher Level Toolkit will result in LESS code to type, LESS places to do mistakes and EASIER copy and paste of common cases as examples. If you ever did Web development you know that CSS, JS and HTML are things few people know properly, but anyway you see millions of web sites that people like :-) (*) writing libraries without actual use cases (applications) leads to infinite rework on some bits, and wrong designs that when we try to put in use we face unusable patterns. For a long time E17 was the sole application using EFL. I know it's hard to get core people to work on UI/applications, thus that's why we need to solve the problem listed in (**). (**) many people don't get along with C, even people that contribute with core EFL make gross mistakes on its usage. Pointers, callbacks and manual memory management are major pitfalls for developers. While developing an application to do X you rather focus on doing X properly than dealing with low level language nasties. The more you focus on creating auxiliary structures, doing casts, checking memory pointers and freeing them, the less stamina you have to think about the actual purpose of your application. Then either you have an application that suck because you struggled too much with the internals instead of designing a proper UI, or you don't even finish your application at all. -- a common pattern ;-) attachment: guillaume_friloux.vcf-- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Working on Docs
There is http://svn.enlightenment.org/svn/e/trunk/EXAMPLES/ Examples are welcome =) On 06/06/2011 23:44, Steven Le Roux wrote: Hi, at the last EFL meeting in france with #e.fr , yoz suggested few, bloody simple example which could be run by simple copy/paste/compile I think it's a good idea too because doxygen and API (documentation) works great with devs, but it's maybe not sexy enough to convert a web dev/sysadmin/whatever into a C developper... On Mon, Jun 6, 2011 at 8:49 PM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: Hi all, ProFUSION is proud to be back to work on EFL, thanks Samsung ;-) Our current work is to improve documentation of core EFL so we can match competitors like Android and iPhone, it should not just improve parts of API, but lots of examples, diagrams and things that lead third party application developers to use our libraries properly. Rasterman requested us to cover few goals: - examples should be external files that can be compiled and checked, avoiding bogus examples ;-) - all doc should be in doxygen - example files should be installable - all examples/docs in the package itself (see below for some shortcomings) - big picture should be provided to introduce users to concepts and ways of doing things, with diagrams and screenshots whenever possible. Screenshots should be auto-generated to match theme changes with ease. Shortcomings: EFL is well split into independent modules, Evas does not depend on Ecore, for instance. But to make actual useful examples, we rather focus on the important bits and instead of creating our own implementation to keep modules independent, we'll depend on these external libraries FOR THE EXAMPLES. That means that if you --enable-build-examples it will pull in ecore-evas so we have ecore_evas_new() and ecore_main_loop_begin(). This will require examples to have 2 phase builds. An alternative we could do is to create a new sub project inside examples/, with it's own autogen.sh, configure.ac and Makefile.am that can even be installed into /usr/share/$PACKAGE/examples/. We can link the main project to have make examples to enter examples and run the build on it. I like this idea more, but let's see what others think. We're currently starting with Eina, Eet, Evas and Elementary. Please try to avoid endless commits changing whitespaces, okay? (/me looks at Seoz and Hermet). -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Discover what all the cheering's about. Get your free trial download today. http://p.sf.net/sfu/quest-dev2dev2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel attachment: guillaume_friloux.vcf-- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: mike_m IN trunk/PROTO/elev8/data: . javascript
On 06/07/2011 04:29 PM, Nicolas Aguirre wrote: Added: trunk/PROTO/elev8/data/javascript/ trunk/PROTO/elev8/data/javascript/button.js Im' just curious, but what's this javascript stuff ? What's the difference with elixir ? Hi Nicholas, Elixir wraps EFL function by function, however elev8 will abstract away the detail of writing EFL applications. For example, main loops, windows and backgrounds will be created automatically. It's still in the prototyping phase at the moment, so if anybody has any flames or suggestions, please fire away :-) thanks, Mike -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Emas mode
Hi, I suggest to add this hook which deletes trailing whitespace before saving. Indeed a painless C-x C-s will remove all trailing whitespaces. (add-hook 'before-save-hook 'delete-trailing-whitespace) Xavier-Emmanuel -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Emas mode
On Tue, 2011-06-07 at 10:29 +0200, Xavier-Emmanuel VINCENT wrote: I suggest to add this hook which deletes trailing whitespace before saving. Indeed a painless C-x C-s will remove all trailing whitespaces. This is a bad idea because we still have trailing whites and this means people will change both logic and style in the same commit without wanting to. We should remove trailing whites in SVN hooks. -- Tom. -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Emas mode
2011/6/7 Xavier-Emmanuel VINCENT xev.deb...@gmail.com Hi, I suggest to add this hook which deletes trailing whitespace before saving. Indeed a painless C-x C-s will remove all trailing whitespaces. (add-hook 'before-save-hook 'delete-trailing-whitespace) Xavier-Emmanuel -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel I think it's not a good idea. I had do that previously, and your patched are always rejected as you modify the code and the spaces in the same time ! -- Nicolas Aguirre Mail: aguirre.nico...@gmail.com Web: http://enna.geexbox.org Blog: http://dev.enlightenment.fr/~captainigloo/ -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: mike_m IN trunk/PROTO/elev8/data: . javascript
On Tue, Jun 7, 2011 at 10:23 AM, Mike McCormack mj.mccorm...@samsung.com wrote: On 06/07/2011 04:29 PM, Nicolas Aguirre wrote: Added: trunk/PROTO/elev8/data/javascript/ trunk/PROTO/elev8/data/javascript/button.js Im' just curious, but what's this javascript stuff ? What's the difference with elixir ? Hi Nicholas, Elixir wraps EFL function by function, however elev8 will abstract away the detail of writing EFL applications. For example, main loops, windows and backgrounds will be created automatically. It's still in the prototyping phase at the moment, so if anybody has any flames or suggestions, please fire away :-) That's an interesting concept. I would like to take that opportunity to give feedback from my experience with elixir and its community. First a little background, elixir was created by Freebox S.A.S. to be a way to create apps on the Freebox v5 set top box (a poor little mips at 250Mhz with a limited graphic blitter and 64MB of RAM). As this set top box is only delivered to French ISP customer Free, the comunity is exclusivly french. A web site and a svn with example was open for it at http://code.google.com/p/freebox-elixir/ . Free did have around 2millions active set top box and around 200 developpers were activ. It resulted in around 150 apps behing since August 2010 (The SDK was first deployed and installed on all set top box in november 2009, but the AppStore like interface only came later in August 2010). We also did a weekend of introduction/teaching to 70 developpers in Paris with the help of the french Enlightenment community early in 2010. Biggest hit is http://www.bouncebox.fr/ a network game with a permanent 100 users playing with it. Other successfull apps get downloaded around 2000 times. The number of active developpers only increased once the store to easily deploy apps was available. All that numbers are public. Now what is Elixir, and just to explain the choice behind it. It was designed around SpiderMonkey Javascript VM, because at the time it was the only light, available on MIPS and standalone library for a Javascript VM. As we did lack the ressource to fully document and barely have the ressource to keep the binding up to date, it was decided to follow the C API. This give a way to directly get examples (like eweather in JS: http://code.google.com/p/freebox-elixir/source/browse/#svn%2Ftrunk%2Fapplications%2Feweather ) and docs from enlightenment.org. The script could only be distributed inside an edje file in a special eet section : elixir/main (other script could also easily be included in other section and requested dynamically from inside any other script). It was requested by a lot of devs to provide a kind of DRM to protect their apps code, so the elixir/main section was ciphered on the 'AppStore' server with a key only known by Freebox and deployed on the set top box that needed to request it every time they wanted to run it. Finally the last and most important point, elixir script should be always safe to execute. For that they didn't have a way to modify a file, only sqlite database was available for config file. As you can understand the entry level was high ! Really high ! EFL wasn't released at all at the start, Spidermonkey isn't packaged properly. Building Elixir wasn't really a trivial task, but devs quickly came with script and ppa that helped every one to setup a dev environment. People at the beginning complained that the SDK wasn't a more higher level JavaScript, but they quickly understand the reason of that decision and a few public (and some other private) JavaScript toolkit where written on top of it (http://code.google.com/p/freebox-elixir/source/browse/#svn%2Ftrunk%2Ftoolkit). As a matter of fact, most dev did what they wanted without really following any guideline :-) But due to the strict rules for publying apps most used edje (or at least learned how to put image inside an eet and open it with evas). The biggest complain wasn't about edje, but about the lack of an interface to easily create them (or at least understand the basic to get started). Editje was hard to get running and people want really a way to edit the code manually at some point. Another lack, was the fact that elementary wasn't available, due to a few reason (lack of a light theme and arrow navigation, nothing really impossible to add to elementary, but no ressource were dedicated to do that job). I have only one thing I really disliked, Spidermonkey API and release. They managed to provide something with less docs, with poorest snapshot (we can't call that release) and more breakage than EFL in the last 10 years ever did ! If I can only give you one feedback that you would remember from this long mail, avoid SpiderMonkey. And indeed v8 seems like the most interesting Javascript VM currently available. So after having maintained during that long an apps without a stable API, the first thing I can say is that you can avoid breaking Javascript apps
Re: [E-devel] e17 todo list - clock+calendar thing done
On Tue, 07 Jun 2011 08:09:06 +0200 Florian Schaefer list...@netego.de said: Ciao tutti! On 06.06.2011 05:24, Carsten Haitzler (The Rasterman) wrote: [...] has a todo list... and i'm wading through it bit by bit. i've knocked off a few of the items and this weekend i polished off the clock one. added a whole data calendar display in a popup when u click on the clock and a digital mode etc. [...] Great stuff. Thanks. However, please let me point out one issue and one feature request. :) Issue: When disabling seconds in analogue mode, the shelf clock does not get updated any more. (SVN revision 60022) hm. bug. i'll check. Feature request: Could the date also be displayed directly in the shelf (at least in digital mode it seems to me that above/below the time display there should be sufficient space)? Then I could finally get rid of the separate calendar module. no. you can make your own theme if you want to do that, but i'm not touching the clock module anymore for release. i'm done with it. if you need the date so often that a click on the clock is too much work, and you cant remember it from the last time you needed it today, then maybe you need another tool. :) -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Emas mode
On Tue, Jun 7, 2011 at 4:31 AM, Vincent Torri vto...@univ-evry.fr wrote: Hey, i've updated the wiki page of the emacs mode: http://trac.enlightenment.org/e/wiki/ECoding/Emacs Hi vtorri, I've looked for this page yesterday and couldn't find it without searching for it on google. My assumption was that it should in the Contribute page, under the Coding Style section, but it's not there. Maybe it's somewhere else, but isn't the case of putting it into that page too? I don't think that more than one link to this page would be bad... Regards, -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Emas mode
You can find this page in e.org-tracker-Coding-ECoding/Emacshttp://trac.enlightenment.org/e/wiki/ECoding/Emacs 2011/6/7 Rafael Antognolli antogno...@profusion.mobi On Tue, Jun 7, 2011 at 4:31 AM, Vincent Torri vto...@univ-evry.fr wrote: Hey, i've updated the wiki page of the emacs mode: http://trac.enlightenment.org/e/wiki/ECoding/Emacs Hi vtorri, I've looked for this page yesterday and couldn't find it without searching for it on google. My assumption was that it should in the Contribute page, under the Coding Style section, but it's not there. Maybe it's somewhere else, but isn't the case of putting it into that page too? I don't think that more than one link to this page would be bad... Regards, -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Nicolas Aguirre Mail: aguirre.nico...@gmail.com Web: http://enna.geexbox.org Blog: http://dev.enlightenment.fr/~captainigloo/ -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Emas mode
On Tue, 7 Jun 2011, Rafael Antognolli wrote: On Tue, Jun 7, 2011 at 4:31 AM, Vincent Torri vto...@univ-evry.fr wrote: Hey, i've updated the wiki page of the emacs mode: http://trac.enlightenment.org/e/wiki/ECoding/Emacs Hi vtorri, I've looked for this page yesterday and couldn't find it without searching for it on google. My assumption was that it should in the Contribute page, under the Coding Style section, but it's not there. it's in http://trac.enlightenment.org/e/wiki/ECoding, the editors section : http://trac.enlightenment.org/e/wiki/ECoding#Editors It's small, so it's easy to miss it Vincent Maybe it's somewhere else, but isn't the case of putting it into that page too? I don't think that more than one link to this page would be bad... Regards, -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Emas mode
On Tue, Jun 7, 2011 at 10:30 AM, Vincent Torri vto...@univ-evry.fr wrote: On Tue, 7 Jun 2011, Rafael Antognolli wrote: On Tue, Jun 7, 2011 at 4:31 AM, Vincent Torri vto...@univ-evry.fr wrote: Hey, i've updated the wiki page of the emacs mode: http://trac.enlightenment.org/e/wiki/ECoding/Emacs Hi vtorri, I've looked for this page yesterday and couldn't find it without searching for it on google. My assumption was that it should in the Contribute page, under the Coding Style section, but it's not there. it's in http://trac.enlightenment.org/e/wiki/ECoding, the editors section : http://trac.enlightenment.org/e/wiki/ECoding#Editors It's small, so it's easy to miss it Nicolas and Vincent, thanks for the answer. But sorry, I wasn't clear. My point isn't finding Emacs inside ECoding, but finding ECoding in the Contribute page. We have it linked in the first page of our trac (I found it now that you linked it to me): http://trac.enlightenment.org/e/wiki - there's a link to ECoding here But not here, where we have a specific section to Coding Style: http://www.enlightenment.org/p.php?p=contribute Shouldn't it have a link to it too? -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Emas mode
On Tue, 7 Jun 2011, Rafael Antognolli wrote: On Tue, Jun 7, 2011 at 10:30 AM, Vincent Torri vto...@univ-evry.fr wrote: On Tue, 7 Jun 2011, Rafael Antognolli wrote: On Tue, Jun 7, 2011 at 4:31 AM, Vincent Torri vto...@univ-evry.fr wrote: Hey, i've updated the wiki page of the emacs mode: http://trac.enlightenment.org/e/wiki/ECoding/Emacs Hi vtorri, I've looked for this page yesterday and couldn't find it without searching for it on google. My assumption was that it should in the Contribute page, under the Coding Style section, but it's not there. it's in http://trac.enlightenment.org/e/wiki/ECoding, the editors section : http://trac.enlightenment.org/e/wiki/ECoding#Editors It's small, so it's easy to miss it Nicolas and Vincent, thanks for the answer. But sorry, I wasn't clear. My point isn't finding Emacs inside ECoding, but finding ECoding in the Contribute page. We have it linked in the first page of our trac (I found it now that you linked it to me): http://trac.enlightenment.org/e/wiki - there's a link to ECoding here But not here, where we have a specific section to Coding Style: http://www.enlightenment.org/p.php?p=contribute Shouldn't it have a link to it too? haaa, ok. Well, i guess so. Maybe a big fat blinking link in red that goes to ECoding. You can choose another color, though :) Vincent -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Emas mode
2011/6/7 Vincent Torri vto...@univ-evry.fr haaa, ok. Well, i guess so. Maybe a big fat blinking link in red that goes to ECoding. You can choose another color, though :) Vincent ahahah, Page Rafael mentionned is the right place IMO :) -- Nicolas Aguirre Mail: aguirre.nico...@gmail.com Web: http://enna.geexbox.org Blog: http://dev.enlightenment.fr/~captainigloo/ -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e17 todo list - clock+calendar thing done
On Tue, Jun 7, 2011 at 12:42 PM, Carsten Haitzler ras...@rasterman.com wrote: On Tue, 07 Jun 2011 08:09:06 +0200 Florian Schaefer list...@netego.de said: Ciao tutti! On 06.06.2011 05:24, Carsten Haitzler (The Rasterman) wrote: [...] has a todo list... and i'm wading through it bit by bit. i've knocked off a few of the items and this weekend i polished off the clock one. added a whole data calendar display in a popup when u click on the clock and a digital mode etc. [...] Great stuff. Thanks. However, please let me point out one issue and one feature request. :) Issue: When disabling seconds in analogue mode, the shelf clock does not get updated any more. (SVN revision 60022) hm. bug. i'll check. Feature request: Could the date also be displayed directly in the shelf (at least in digital mode it seems to me that above/below the time display there should be sufficient space)? Then I could finally get rid of the separate calendar module. no. you can make your own theme if you want to do that, but i'm not touching the clock module anymore for release. i'm done with it. if you need the date so often that a click on the clock is too much work, and you cant remember it from the last time you needed it today, then maybe you need another tool. :) There is now an action to show the calendar when you can't remember it ! -- Cedric BAIL -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e17 todo list - clock+calendar thing done
Hi Raster! On 07.06.2011 12:42, Carsten Haitzler (The Rasterman) wrote: [...] Issue: When disabling seconds in analogue mode, the shelf clock does not get updated any more. (SVN revision 60022) hm. bug. i'll check. Thx. Feature request: Could the date also be displayed directly in the shelf (at least in digital mode it seems to me that above/below the time display there should be sufficient space)? Then I could finally get rid of the separate calendar module. no. you can make your own theme if you want to do that, but i'm not touching the clock module anymore for release. i'm done with it. if you need the date so often that a click on the clock is too much work, and you cant remember it from the last time you needed it today, then maybe you need another tool. :) OK, I got it. As my brain is seemingly unable to adjust for a new date every day (hey, come on, that's a lot of effort) I will either stick to 3rd party modules or hack the source myself. ;-) Ciao Florian signature.asc Description: OpenPGP digital signature -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Leak in _ecore_thread_win32_join()?
Hi!
The functions looks like this:
int _ecore_thread_win32_join(win32_thread *x, void **res)
{
if (!PHE(x, PHS()))
{
WaitForSingleObject(x-thread, INFINITE);
CloseHandle(x-thread);
}
if (res) *res = x-val;
return 0;
}
What I'm wondering is if there shouldn't be a free(x); before the return
statement. At least the complementary _ecore_thread_win32_create() will
allocate the structure using malloc(). Hopefully someone with better insight
there can verify/falsify it...
Cheers!
Uli
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e17 todo list - clock+calendar thing done
Hi Rasterman, i'm one of the students that sent some mails about making widgets some weeks ago. Your new version of the clock widget reminds me what i was supposed to do in my course project, i've included an elementary clock into a skel and added some options, i've used elm_widget for the link between elementary and the skel, but it's still in development (and said to be unstable), but you have found a better solution, i've seen that you recreated the elementary clock directly in the edc of e, nice work (well that was too hard for my project) ! I've planned to share my work with the community but it doesn't seem to be necessary now, your work is better… :) Just an idea… I've also thought it'd be usefull to give the possibility to set a time difference to see the time in an other country, so i've modified skel to have a configuration per instance of the widget… maybe can it be add (by me, if i can manage it) in this new clock you've made ? Regards, Quentin Gibeaux. 2011/6/7 Carsten Haitzler ras...@rasterman.com On Tue, 07 Jun 2011 08:09:06 +0200 Florian Schaefer list...@netego.de said: Ciao tutti! On 06.06.2011 05:24, Carsten Haitzler (The Rasterman) wrote: [...] has a todo list... and i'm wading through it bit by bit. i've knocked off a few of the items and this weekend i polished off the clock one. added a whole data calendar display in a popup when u click on the clock and a digital mode etc. [...] Great stuff. Thanks. However, please let me point out one issue and one feature request. :) Issue: When disabling seconds in analogue mode, the shelf clock does not get updated any more. (SVN revision 60022) hm. bug. i'll check. Feature request: Could the date also be displayed directly in the shelf (at least in digital mode it seems to me that above/below the time display there should be sufficient space)? Then I could finally get rid of the separate calendar module. no. you can make your own theme if you want to do that, but i'm not touching the clock module anymore for release. i'm done with it. if you need the date so often that a click on the clock is too much work, and you cant remember it from the last time you needed it today, then maybe you need another tool. :) -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Casts in ecore_win32_window.c necessary?
Hi!
The following code is an example from that file:
EAPI void
ecore_win32_window_free(Ecore_Win32_Window *window)
{
Ecore_Win32_Window *wnd = window;
if (!window) return;
INF(destroying window);
if (wnd-shape.mask)
free(wnd-shape.mask);
DestroyWindow(((Ecore_Win32_Window *)window)-window);
free(window);
}
There are two things, repeated several times in that file:
1. In the call to DestroyWindow(), the window parameter is converted to an
Ecore_Win32_Window*, which is the same type it already has.
2. The input parameter is stored in a local parameter (here: wnd) of the
same type, which is then used in place of the input parameter.
I guess some refactoring took place here, but was only partially finished. I'd
try if removing that changes anything, but I don't have any win32 machine
here...
Uli
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Fwd: bug in wlan E-MODULES-EXTRA/wlan
thanks, i'lldo shortly, then -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] about packaging/debian directories
On Thu, Jun 2, 2011 at 10:06 AM, Carsten Haitzler ras...@rasterman.com wrote: On Wed, 1 Jun 2011 12:03:14 +0200 michael bouchaud michael.bouch...@gmail.com said: The probleme of debianization of this packages aren't the stability of libraries or softwares but migration between each update. And this can made a lot of work. For exemple edje have break the file format before the release. So Lutin had to done a patch to verify all theme loaded and make sure it was compatible. If the theme aren't compatible convert it on the fly. This is not trivial. So I agree to upload all stable and released packages to debian but not snapshoted packages for moment. For information Lutin has made all this work except eeze. I prefer support our own 'ppa' as raster said, and provide this packages here. agreed. for those who are happy to live on bleeding edge - use our ppa/repo/whatever. those who want stable and really well, will have to wait longer and go for debian etc. upstream well tested stuff. i agree too :) if i can be of any help, let me know! -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Leak in _ecore_thread_win32_join()?
Hey,
On Tue, 7 Jun 2011, Ulrich Eckhardt wrote:
The functions looks like this:
int _ecore_thread_win32_join(win32_thread *x, void **res)
{
if (!PHE(x, PHS()))
{
WaitForSingleObject(x-thread, INFINITE);
CloseHandle(x-thread);
}
if (res) *res = x-val;
return 0;
}
What I'm wondering is if there shouldn't be a free(x); before the return
statement. At least the complementary _ecore_thread_win32_create() will
allocate the structure using malloc(). Hopefully someone with better insight
there can verify/falsify it...
It's nice to see someone interested in the win32 code :)
Honestly, i'm not good at all with threads, pthreads or wthreads. Does
pthread_join() automatically destroy its first parameter (the calling
thread) when it returns ?
Vincent
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Casts in ecore_win32_window.c necessary?
Hey
On Tue, 7 Jun 2011, Ulrich Eckhardt wrote:
The following code is an example from that file:
EAPI void
ecore_win32_window_free(Ecore_Win32_Window *window)
{
Ecore_Win32_Window *wnd = window;
if (!window) return;
INF(destroying window);
if (wnd-shape.mask)
free(wnd-shape.mask);
DestroyWindow(((Ecore_Win32_Window *)window)-window);
free(window);
}
There are two things, repeated several times in that file:
1. In the call to DestroyWindow(), the window parameter is converted to an
Ecore_Win32_Window*, which is the same type it already has.
yes. I actually changed the type used in the functions. Originally, it
was:
struct _Ecore_Win32_Window *wnd = (struct _Ecore_Win32_Window *)window;
I modified this, but i forgot to remove the cast in other places.
2. The input parameter is stored in a local parameter (here: wnd) of the
same type, which is then used in place of the input parameter.
same reason :)
I guess some refactoring took place here, but was only partially finished. I'd
try if removing that changes anything, but I don't have any win32 machine
here...
indeed, all this code can be simplified. Same for the Windows CE code.
thanks for the report
Vincent
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Leak in _ecore_thread_win32_join()?
On Tuesday 07 June 2011 22:53:59 Vincent Torri wrote: It's nice to see someone interested in the win32 code :) Thank you for writing it! Actually, I'm interested in the WinCE port even, because that's the platform I work with for a living, doing embedded programming in an industrial environment. Honestly, i'm not good at all with threads, pthreads or wthreads. Does pthread_join() automatically destroy its first parameter (the calling thread) when it returns ? It's not explicitly stated in the manpages I have, but there's these statements: 1. Joining with a thread that has previously been joined results in undefined behavior. This seems to imply that the handle (pthread_t) has become unusable, similar to the pointer given to free(). 2. Failure to join with a thread [...] produces a zombie thread. Avoid doing this, since each zombie thread consumes some system resources[...] This seems to imply that pthread_join() releases all resources associated with the thread, again similar to free(). That's also why I thought that there should be a free() in that function. The CloseHandle() on the thread handle is just one part of the cleanup. Cheers! Uli -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Leak in _ecore_thread_win32_join()?
On Tue, 7 Jun 2011, Ulrich Eckhardt wrote: On Tuesday 07 June 2011 22:53:59 Vincent Torri wrote: It's nice to see someone interested in the win32 code :) Thank you for writing it! Actually, I'm interested in the WinCE port even, because that's the platform I work with for a living, doing embedded programming in an industrial environment. Hooo, that's nice for the windows ce port if I have some help. In case you don't know : http://trac.enlightenment.org/e/wiki/EFLWindowsCE Honestly, i'm not good at all with threads, pthreads or wthreads. Does pthread_join() automatically destroy its first parameter (the calling thread) when it returns ? It's not explicitly stated in the manpages I have, but there's these statements: 1. Joining with a thread that has previously been joined results in undefined behavior. This seems to imply that the handle (pthread_t) has become unusable, similar to the pointer given to free(). 2. Failure to join with a thread [...] produces a zombie thread. Avoid doing this, since each zombie thread consumes some system resources[...] This seems to imply that pthread_join() releases all resources associated with the thread, again similar to free(). That's also why I thought that there should be a free() in that function. The CloseHandle() on the thread handle is just one part of the cleanup. ok, i'll free it, then. thank you Vincent -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Casts in ecore_win32_window.c necessary?
On Tue, 7 Jun 2011, Ulrich Eckhardt wrote:
Hi!
The following code is an example from that file:
EAPI void
ecore_win32_window_free(Ecore_Win32_Window *window)
{
Ecore_Win32_Window *wnd = window;
if (!window) return;
INF(destroying window);
if (wnd-shape.mask)
free(wnd-shape.mask);
DestroyWindow(((Ecore_Win32_Window *)window)-window);
free(window);
}
There are two things, repeated several times in that file:
1. In the call to DestroyWindow(), the window parameter is converted to an
Ecore_Win32_Window*, which is the same type it already has.
2. The input parameter is stored in a local parameter (here: wnd) of the
same type, which is then used in place of the input parameter.
i've fixed the casts in win32 and wince.
thank you !
Vincent
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Leak in _ecore_thread_win32_join()?
On Tue, 7 Jun 2011, Ulrich Eckhardt wrote: On Tuesday 07 June 2011 22:53:59 Vincent Torri wrote: It's nice to see someone interested in the win32 code :) Thank you for writing it! Actually, I'm interested in the WinCE port even, because that's the platform I work with for a living, doing embedded programming in an industrial environment. Honestly, i'm not good at all with threads, pthreads or wthreads. Does pthread_join() automatically destroy its first parameter (the calling thread) when it returns ? It's not explicitly stated in the manpages I have, but there's these statements: 1. Joining with a thread that has previously been joined results in undefined behavior. This seems to imply that the handle (pthread_t) has become unusable, similar to the pointer given to free(). 2. Failure to join with a thread [...] produces a zombie thread. Avoid doing this, since each zombie thread consumes some system resources[...] This seems to imply that pthread_join() releases all resources associated with the thread, again similar to free(). That's also why I thought that there should be a free() in that function. The CloseHandle() on the thread handle is just one part of the cleanup. fixed, thanks :) Vincent -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Edje: using fdopen instead of fopen in edje_cc
Hey,
On windows, using open() followed by fopen() does not work. Hence, in
edje_cc, where mkstemp (which uses open) is followed by fopen, edje_cc
fails.
Instead of fopen, we can use fdopen. I pasted a patch below. Can you
comment it (like, instead of keeping the filename in the function that i
modified, why not using it for the fd?
thank you
Vincent
Index: src/bin/edje_cc_out.c
===
--- src/bin/edje_cc_out.c (revision 60043)
+++ src/bin/edje_cc_out.c (working copy)
@@ -708,9 +708,9 @@
}
static void
-create_script_file(Eet_File *ef, const char *filename, const Code *cd)
+create_script_file(Eet_File *ef, const char *filename, const Code *cd,
int fd)
{
- FILE *f = fopen(filename, wb);
+ FILE *f = fdopen(fd, wb);
if (!f)
error_and_abort(ef, Unable to open temp file \%s\ for script
compilation.\n, filename);
@@ -787,7 +787,7 @@
static void
compile_script_file(Eet_File *ef, const char *source, const char *output,
- int script_num)
+ int script_num, int fd)
{
FILE *f;
char buf[4096];
@@ -802,7 +802,7 @@
if (ret 0 || ret 1)
error_and_abort(ef, Compiling script code not clean.\n);
- f = fopen(output, rb);
+ f = fdopen(fd, rb);
if (!f)
error_and_abort(ef, Unable to open script object \%s\ for reading.\n,
output);
@@ -864,7 +864,7 @@
error_and_abort(ef, Unable to open temp file \%s\ for script
compilation.\n, tmpn);
- create_script_file(ef, tmpn, cd);
+ create_script_file(ef, tmpn, cd, fd);
close(fd);
snprintf(tmpo, PATH_MAX, %s/edje_cc.amx-tmp-XX, tmp_dir);
@@ -876,7 +876,7 @@
compilation.\n, tmpn);
}
- compile_script_file(ef, tmpn, tmpo, i);
+ compile_script_file(ef, tmpn, tmpo, i, fd);
close(fd);
unlink(tmpn);
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch]Added Unlock to msgbus module
Hi, This is a small patch to allow you to unlock E from dbus. unlock.patch Description: Binary data -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Edje: using fdopen instead of fopen in edje_cc
On Tue, Jun 7, 2011 at 8:24 PM, Vincent Torri vto...@univ-evry.fr wrote: Hey, On windows, using open() followed by fopen() does not work. Hence, in edje_cc, where mkstemp (which uses open) is followed by fopen, edje_cc fails. Instead of fopen, we can use fdopen. I pasted a patch below. Can you comment it (like, instead of keeping the filename in the function that i modified, why not using it for the fd? The patch looks a bit weird. IMO you should take one of the following approaches (in order of preference): 1) Pass only the file descriptor instead of the filename. This way you will write to the file descriptor recently opened by mkstemp. 2) call close(fd) before calling create_script_file() and compile_script_file(). This is very ugly thing that should work as well, however one might argument that there's a race because the file might disappear between the call to mkstemp() -- its creation -- and the above functions. regards, Lucas De Marchi -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Evas code reentrant/thread-safe by design?
Hi! I have a question regarding the thread-safety and reentrancy of Evas. Firstly, are these actually goals or is Evas intended by design to be used in a single thread for rendering? If so, you can ignore my other questions Now, what got me started on this issue is the commit in http://trac.enlightenment.org/e/changeset/59780/trunk/evas/src. There, a function-local, static buffer is added in _escaped_char_get(), who's address is returned from the function. This means that one call will overwrite the previous call's results and simultaneous calls by two threads might cause even more problems. I checked the rest of the file (Actually, I think that is the biggest single file of sourcecode I have ever seen with almost 9k lines! :D) but there is only a single further incident where a non-const, local and static variable is used. This second use is in the initialisation of textblock objects where linebreak_init() is called on demand when HAVE_LINEBREAK is defined. Isn't this latter case something for evas_init(), BTW? Cheers! Uli -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Evas code reentrant/thread-safe by design?
On Wed, 8 Jun 2011 07:05:01 +0200 Ulrich Eckhardt dooms...@knuut.de said: designed to be used from a single thread. in fact almost ALL of efl is not threadsafe/re-entrant. that is .. well .. an assumed baseline, so no code tries to work in a threaded environment (app threadeD) except for some very specific exceptions in eina and ecore_thread itself. (the idea is you fram off the non-efl heavy processing/io work to a worker thread and when its done it messages back the mainloop (state machine of the app) and that state machine updates the ui. Hi! I have a question regarding the thread-safety and reentrancy of Evas. Firstly, are these actually goals or is Evas intended by design to be used in a single thread for rendering? If so, you can ignore my other questions Now, what got me started on this issue is the commit in http://trac.enlightenment.org/e/changeset/59780/trunk/evas/src. There, a function-local, static buffer is added in _escaped_char_get(), who's address is returned from the function. This means that one call will overwrite the previous call's results and simultaneous calls by two threads might cause even more problems. I checked the rest of the file (Actually, I think that is the biggest single file of sourcecode I have ever seen with almost 9k lines! :D) but there is only a single further incident where a non-const, local and static variable is used. This second use is in the initialisation of textblock objects where linebreak_init() is called on demand when HAVE_LINEBREAK is defined. Isn't this latter case something for evas_init(), BTW? Cheers! Uli -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Edje: using fdopen instead of fopen in edje_cc
On Tue, 7 Jun 2011, Lucas De Marchi wrote: On Tue, Jun 7, 2011 at 8:24 PM, Vincent Torri vto...@univ-evry.fr wrote: Hey, On windows, using open() followed by fopen() does not work. Hence, in edje_cc, where mkstemp (which uses open) is followed by fopen, edje_cc fails. Instead of fopen, we can use fdopen. I pasted a patch below. Can you comment it (like, instead of keeping the filename in the function that i modified, why not using it for the fd? The patch looks a bit weird. IMO you should take one of the following approaches (in order of preference): 1) Pass only the file descriptor instead of the filename. This way you will write to the file descriptor recently opened by mkstemp. that's the kind of weirdness i mentioned in the mail. I kept the filename only for the error message. I can just display the value of the fd. thanks Vincent 2) call close(fd) before calling create_script_file() and compile_script_file(). This is very ugly thing that should work as well, however one might argument that there's a race because the file might disappear between the call to mkstemp() -- its creation -- and the above functions. regards, Lucas De Marchi -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Edje: using fdopen instead of fopen in edje_cc
On Tue, 7 Jun 2011, Lucas De Marchi wrote: On Tue, Jun 7, 2011 at 8:24 PM, Vincent Torri vto...@univ-evry.fr wrote: Hey, On windows, using open() followed by fopen() does not work. Hence, in edje_cc, where mkstemp (which uses open) is followed by fopen, edje_cc fails. Instead of fopen, we can use fdopen. I pasted a patch below. Can you comment it (like, instead of keeping the filename in the function that i modified, why not using it for the fd? The patch looks a bit weird. IMO you should take one of the following approaches (in order of preference): 1) Pass only the file descriptor instead of the filename. This way you will write to the file descriptor recently opened by mkstemp. compile_script_file() needs the filename (it is passed to embryo_cc) Vincent 2) call close(fd) before calling create_script_file() and compile_script_file(). This is very ugly thing that should work as well, however one might argument that there's a race because the file might disappear between the call to mkstemp() -- its creation -- and the above functions. regards, Lucas De Marchi -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch] Improve elm_entry_filter_limit_size function.
Hello ~ I made a patch for improving elm_entry_filter_limit_size function. After updating this patch, elm_entry_filter_limit_size function will care about tags and escape characters. Can anybody check about this patch ? Thanks : ) entry_filter.patch Description: Binary data -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
